--- Log opened Wed Oct 17 00:00:39 2018
00:01 < meshcollider> sipa: thanks, appreciate the amount of time youre putting into reviewing this, I'll work on them as soon as I can
00:02 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
00:02 -!- echonaut14 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
00:08 -!- instagibbs [~instagibb@pool-100-15-136-249.washdc.fios.verizon.net] has quit [Ping timeout: 250 seconds]
00:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
00:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
00:16 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 244 seconds]
00:18 < sipa> meshcollider: happy to see someone working on this; we should have done this 2 releases ago, so the alternative is probably that i'd need to do it myself :)
00:18 < sipa> also, it's great to get some more people familiar with this code
00:23 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:23 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has joined #bitcoin-core-dev
00:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zgmasefbmrphfffb] has joined #bitcoin-core-dev
00:24 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/23419e4c4939...27bf14f6f3e0
00:24 < bitcoin-git> bitcoin/master 4ae50da practicalswift: Revert "qa: Fix codespell error and have lint-spelling error instead of warn"...
00:24 < bitcoin-git> bitcoin/master c32cf6a practicalswift: Add ignored word: mut
00:24 < bitcoin-git> bitcoin/master 27bf14f Pieter Wuille: Merge #14495: build: Warn (don't fail!) on spelling errors...
00:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zgmasefbmrphfffb] has left #bitcoin-core-dev []
00:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ltjxfxdpmiajogcy] has joined #bitcoin-core-dev
00:25 < bitcoin-git> [bitcoin] sipa closed pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495
00:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ltjxfxdpmiajogcy] has left #bitcoin-core-dev []
00:25 < AM5800> Hi, can someone tell me what is the current status of dandelion (BIP 156)?
00:27 < sipa> AM5800: people are working on an implementation, but there is a lot of unclarity on how to combine it with the DoS protections the current mempool model has
00:28 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Remote host closed the connection]
00:29 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
00:29 < AM5800> sipa, thanks. I would like to offer an assistance on this feature, who should I contact?
00:30 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
00:30 < sipa> AM5800: sdaftuar and MarcoFalke are probably people to talk to
00:31 < AM5800> sipa, one final question: what would be the best way to reach them?
00:31 < sipa> irc is pretty good :)
00:32 < sipa> you may need to wait a few hours or days, though
00:32 < meshcollider> sipa: yes, I find the wallet and descriptor stuff all very interesting, much more interesting than say network code hehe
00:33 < AM5800> sipa: thank you!
00:34 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
00:44 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Ping timeout: 250 seconds]
00:54 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:58 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds]
01:00 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection]
01:15 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:16 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
01:18 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
01:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:23 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:28 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev
01:38 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev
01:42 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
01:43 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
01:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
01:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
01:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
01:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
01:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
02:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
02:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
02:06 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Ping timeout: 252 seconds]
02:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-eqvtvdulzuigcuur] has joined #bitcoin-core-dev
02:08 < bitcoin-git> [bitcoin] luke-jr opened pull request #14501: Fix possible data race when committing block files (master...fsync_dir) https://github.com/bitcoin/bitcoin/pull/14501
02:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-eqvtvdulzuigcuur] has left #bitcoin-core-dev []
02:14 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
02:14 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
02:15 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has quit [Ping timeout: 250 seconds]
02:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
02:24 -!- laurentmt [~Thunderbi@185.242.6.6] has joined #bitcoin-core-dev
02:24 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac]
02:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
02:25 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
02:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:30 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev
02:32 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
02:35 -!- laurentmt [~Thunderbi@185.242.6.6] has quit [Quit: laurentmt]
02:39 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds]
02:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 276 seconds]
02:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
02:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
02:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
02:51 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac]
02:59 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:00 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Client Quit]
03:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:06 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:33 -!- david___ [1b26f899@gateway/web/freenode/ip.27.38.248.153] has joined #bitcoin-core-dev
03:35 < david___> LS
03:37 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has quit [Ping timeout: 256 seconds]
03:40 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
03:40 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
03:50 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
03:52 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
03:52 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
04:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
04:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
04:06 -!- Guest87013 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 245 seconds]
04:10 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
04:10 -!- schmidty is now known as Guest3968
04:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kuocaduixpzdphie] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] karel-3d opened pull request #14502: Rpc helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502
04:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kuocaduixpzdphie] has left #bitcoin-core-dev []
04:52 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev
04:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
04:55 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has joined #bitcoin-core-dev
05:00 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 245 seconds]
05:00 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
05:01 -!- phwalkr [~phwalkr@194.210.90.196] has joined #bitcoin-core-dev
05:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
05:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:24 -!- josephnicholas [~josephnic@49.145.51.90] has joined #bitcoin-core-dev
05:32 -!- Guest3968 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 244 seconds]
05:36 -!- Drakon [~Drakon@p4FFC8F11.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
05:36 < Drakon> The option to minimize to system tray instead of the taskbar ist available, but doesn't have an effect if it is started with the -min option. If I start it via that option, I have to click on the program symbil on the taskbar and then minimize it again in order to get it minimized to system tray.
05:37 < Drakon> That's annoying.
05:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
05:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
05:51 -!- josephnicholas [~josephnic@49.145.51.90] has quit [Remote host closed the connection]
05:51 -!- josephnicholas [~josephnic@49.145.51.90] has joined #bitcoin-core-dev
05:51 -!- josephnicholas [~josephnic@49.145.51.90] has quit [Read error: Connection reset by peer]
05:51 -!- josephnicholas [~josephnic@49.145.51.90] has joined #bitcoin-core-dev
05:56 -!- josephnicholas [~josephnic@49.145.51.90] has quit [Remote host closed the connection]
06:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
06:05 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
06:07 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has quit [Quit: Page closed]
06:07 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
06:08 -!- Drakon [~Drakon@p4FFC8F11.dip0.t-ipconnect.de] has quit [Quit: ~ Trillian - www.trillian.im ~]
06:13 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection]
06:13 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
06:15 -!- phwalkr [~phwalkr@194.210.90.196] has quit [Quit: Leaving...]
06:28 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
06:28 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
06:29 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
06:30 -!- schmidty is now known as Guest63155
06:32 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
06:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
06:33 -!- david___ [1b26f899@gateway/web/freenode/ip.27.38.248.153] has quit [Ping timeout: 256 seconds]
06:33 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Client Quit]
06:34 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
06:40 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 244 seconds]
06:49 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
06:51 < wumpus> can you open an issue for that please? https://github.com/bitcoin/bitcoin/issues/new
06:53 < wumpus> (if there isn't one yet-)
06:58 -!- bergz [~berg@69.12.27.194] has quit [Quit: bergz]
07:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hflcoxygeexqhbsb] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27bf14f6f3e0...3036faf51a18
07:01 < bitcoin-git> bitcoin/master ee0b7c4 practicalswift: build: Pin to specific versions of Python packages we install from PyPI in Travis
07:01 < bitcoin-git> bitcoin/master 3036faf Wladimir J. van der Laan: Merge #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis...
07:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hflcoxygeexqhbsb] has left #bitcoin-core-dev []
07:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-witegrloklhawpax] has joined #bitcoin-core-dev
07:03 < bitcoin-git> [bitcoin] laanwj closed pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496
07:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-witegrloklhawpax] has left #bitcoin-core-dev []
07:04 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
07:09 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev
07:24 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev
07:25 -!- jarthur [~jarthur@2605:6000:1019:41ab:d4ba:cbc9:403b:5c91] has quit [Ping timeout: 252 seconds]
07:25 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit]
07:31 -!- ossifrage_ [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
07:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
07:34 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
07:34 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
07:34 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds]
07:34 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds]
07:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
07:36 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
07:38 -!- harding_ [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev
07:47 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
07:49 -!- Netsplit *.net <-> *.split quits: Taek, TheRec, gribble, profmac
07:50 -!- Netsplit *.net <-> *.split quits: harding, cryptocat, qinfengling
07:50 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:52 -!- Netsplit over, joins: profmac
07:53 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:55 -!- qinfengling [~qinfengli@45.32.53.207] has joined #bitcoin-core-dev
07:55 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev
07:55 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host]
07:55 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
08:01 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:02 -!- grubles_ is now known as grubles
08:05 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]
08:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
08:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
08:15 < promag> ken2812221: do you build bitcoin-qt with msvc?
08:23 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev
08:24 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit]
08:24 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
08:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fbamwqkikkcpokrb] has joined #bitcoin-core-dev
08:24 < bitcoin-git> [bitcoin] isghe opened pull request #14504: show the progress of functional test (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504
08:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fbamwqkikkcpokrb] has left #bitcoin-core-dev []
08:24 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
08:29 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 244 seconds]
08:30 -!- jarthur [~jarthur@207.114.244.5] has quit []
08:35 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
08:35 < promag> hebasto: regarding #14450 I've replaced the mingw setup with msvc
08:36 < promag> but I don't know how to build bitcoin-qt to test it
08:37 < promag> I'm waiting for `vcpkg install qt5` ..
08:39 < ken2812221> promag: No, I don't know how to do that.
08:40 < ken2812221> vcpkg is still using Qt 5.2
08:40 < promag> here says 5.9.2
08:42 < ken2812221> oh, I missed that 9 for a while ago.
08:44 < ken2812221> But it's complicate to use qt tools on msvc. This could be done by cmake, but that's a difficult task.
08:45 -!- bralyclow3 [~bralyclow@195.242.213.120] has joined #bitcoin-core-dev
08:46 -!- bralyclow3 [~bralyclow@195.242.213.120] has quit [Client Quit]
08:50 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has joined #bitcoin-core-dev
08:53 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Disconnected by services]
08:55 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
09:03 -!- AM5800 [5f5bd412@gateway/web/freenode/ip.95.91.212.18] has quit [Ping timeout: 256 seconds]
09:11 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
09:24 -!- Taek [~quassel@2001:41d0:1:472e::] has joined #bitcoin-core-dev
09:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
09:24 -!- cryptocat [~cryptocat@unaffiliated/cryptocat] has joined #bitcoin-core-dev
09:28 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 252 seconds]
09:29 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev
09:50 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:55 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
09:56 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
09:56 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
09:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
09:56 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
09:57 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
09:58 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
10:03 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:03 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qxfevibwrhwjpivl] has joined #bitcoin-core-dev
10:08 < bitcoin-git> [bitcoin] sdaftuar closed pull request #14220: Transaction relay privacy bugfix (master...2018-09-txrelay) https://github.com/bitcoin/bitcoin/pull/14220
10:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qxfevibwrhwjpivl] has left #bitcoin-core-dev []
10:14 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac]
10:18 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
10:22 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
10:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-koxzrsfmrcvamich] has joined #bitcoin-core-dev
10:25 < bitcoin-git> [bitcoin] practicalswift opened pull request #14505: Make all single parameter constructors explicit (C++11) (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
10:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-koxzrsfmrcvamich] has left #bitcoin-core-dev []
10:30 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
10:38 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
10:38 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
10:42 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 245 seconds]
10:45 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:45 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
10:49 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds]
10:55 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
10:55 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
11:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iwviewxmldmhcdbd] has joined #bitcoin-core-dev
11:10 < bitcoin-git> [bitcoin] practicalswift opened pull request #14506: Remove redundancies: redundant forward declaration, redundant namespace, redundancy copying, redundant conditionals (master...remove) https://github.com/bitcoin/bitcoin/pull/14506
11:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iwviewxmldmhcdbd] has left #bitcoin-core-dev []
11:12 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:19 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
11:20 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
11:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:24 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 244 seconds]
11:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
11:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dabkqkvdhgzzljam] has joined #bitcoin-core-dev
11:25 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3036faf51a18...816fab9ccae5
11:25 < bitcoin-git> bitcoin/master 081cc02 Hennadii Stepanov: Fix QCompleter popup regression...
11:25 < bitcoin-git> bitcoin/master 816fab9 Jonas Schnelli: Merge #14450: qt: Fix QCompleter popup regression...
11:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dabkqkvdhgzzljam] has left #bitcoin-core-dev []
11:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wqyomzsfzsktjrqz] has joined #bitcoin-core-dev
11:27 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #14450: qt: Fix QCompleter popup regression (master...20181009-console-autocomplete) https://github.com/bitcoin/bitcoin/pull/14450
11:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wqyomzsfzsktjrqz] has left #bitcoin-core-dev []
11:27 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has quit [Read error: Connection reset by peer]
11:28 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
11:29 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:34 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
11:35 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:36 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
11:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
11:36 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
11:36 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:36 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
11:42 -!- bergz [~berg@69.12.27.194] has quit [Quit: bergz]
11:43 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev
11:43 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
11:48 -!- bergz [~berg@69.12.27.194] has quit [Quit: bergz]
12:03 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
12:04 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev
12:05 -!- laurentmt [~Thunderbi@185.242.6.6] has joined #bitcoin-core-dev
12:21 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
12:22 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
12:26 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 244 seconds]
12:27 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
12:29 -!- bralycl__ [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev
12:31 -!- bralyclow [~bralyclow@195.242.213.117] has quit [Ping timeout: 276 seconds]
12:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
12:34 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 276 seconds]
12:35 -!- bergz [~berg@69.12.27.194] has left #bitcoin-core-dev []
12:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
12:39 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
12:39 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:42 -!- jpe [~jpe@2001:16b8:48df:1900:dc7c:d547:abf:71f3] has joined #bitcoin-core-dev
12:46 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 244 seconds]
12:47 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
12:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
12:57 -!- ra_ [0e8bde4d@gateway/web/freenode/ip.14.139.222.77] has joined #bitcoin-core-dev
12:57 < ra_> Hello Everyone
12:58 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
13:00 < ra_> Hello Lei
13:02 -!- ra_ [0e8bde4d@gateway/web/freenode/ip.14.139.222.77] has quit [Quit: Page closed]
13:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
13:09 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
13:09 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
13:09 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
13:13 -!- laurentmt [~Thunderbi@185.242.6.6] has quit [Quit: laurentmt]
13:17 -!- iphelix_ [~iphelix@iphelix.powered.by.lunarbnc.net] has left #bitcoin-core-dev ["Be back later..."]
13:26 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
13:26 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
13:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:27 -!- iceberg [2ea68f75@gateway/web/freenode/ip.46.166.143.117] has joined #bitcoin-core-dev
13:30 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
13:33 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
13:34 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
13:38 < iceberg> Hello, I would like to ask question related to the hot wallet implementation of Gemini. Gemini is using the CloudHSM (the cloud-based HSM of AWS) for their hot wallet. As far as I know CloudHSM does not support the secp256k1. How is it possible to implement such a solution? Can such a solution be as safe as if the CloudHSM was supporting the secp256k1? I also asked the question on stack exchange https://tinyurl.com/yaq8al5
13:39 < sipa> you'll need to ask gemini :)
13:39 < iceberg> I am sorry if the question is not relevant for this channel, but I am very curious...
13:40 < sipa> to me personally, "cloud HSM" sounds like marketing nonsense, but I haven't really looked into it
13:40 < sipa> but yes, off topic here
13:42 < iceberg> I asked Gemini and they replied with a link from their website, which didn't help. Thanks for the reply.
13:45 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
13:46 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
13:46 < gmaxwell> I don't know anything about gemini, but it is routine for bitcoin companies to more or less outright lie about their security.
13:46 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has quit [Read error: Connection reset by peer]
13:47 < gmaxwell> MTGox also claimed to be using HSMs, for example.
13:47 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
13:47 < gmaxwell> Using 'cloud hsm' might just mean they're securing passwords using it. Or they keep the private keys in it normally but routinely export them for signing.
13:48 < sipa> i assume that if gemini claims to be using amazon cloudhsm, then they're indeed actually using those in some kind or form. whether that product actually gives them a security advantage is a very different question though :)
13:48 < gmaxwell> Yes, indeed.
13:50 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 250 seconds]
13:59 < phantomcircuit> iceberg, there's keystorage which is what i assume they're using
13:59 < phantomcircuit> i cant see how that would provide any meaningful security
14:01 < phantomcircuit> gmaxwell, well he had them at least
14:01 < phantomcircuit> lol
14:06 -!- ossifrage_ is now known as ossifrage
14:12 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
14:17 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 245 seconds]
14:21 -!- qu4ku [~qu4ku@public-gprs351671.centertel.pl] has joined #bitcoin-core-dev
14:24 -!- otoburb [~otoburb@unaffiliated/otoburb] has joined #bitcoin-core-dev
14:24 -!- iceberg [2ea68f75@gateway/web/freenode/ip.46.166.143.117] has quit [Quit: Page closed]
14:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
14:32 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
14:32 < ap4lmtree> hi
14:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
14:36 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
14:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:39 -!- qu4ku [~qu4ku@public-gprs351671.centertel.pl] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:41 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
14:46 < sipa> what's up with appveyor failing random builds?
14:47 < sipa> or am i actually doing something wrong that travis doesn't catch?
14:47 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
14:48 < phantomcircuit> sipa, which tests fail?
14:48 < sipa> i've seen ua_comment fail a few times
14:49 < sipa> now also example_test: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19592226
14:51 < sipa> wth is example_test anyway
14:52 < meshcollider> sipa: see #14446
14:52 < gribble> https://github.com/bitcoin/bitcoin/issues/14446 | tests: Some issue about running functional tests on Windows · Issue #14446 · bitcoin/bitcoin · GitHub
14:52 < andytoshi> seeing failures in rust-land too https://github.com/solson/miri/pull/485
14:53 < jamesob> I've seen a lot of spurious appveyor failures recently too - and they queue up pretty deep so green lights take forever to come on
14:53 < jamesob> we use that for windows testing, right?
14:53 < sipa> yes
14:54 < sipa> specifically, msvc-built windows - which isn't used for production anywhere
14:55 < meshcollider> Ugh if someone suggests changes in that new commit thing then you can't reply to their comments
15:01 -!- g687 [~quassel@nz177l45.bb122100.ctm.net] has quit [Remote host closed the connection]
15:17 < ken2812221> sipa: Instead of disabling the CI, why don't do review #13501 and #14465 ASAP?
15:17 < gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
15:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14465 | tests: Stop node before removing the notification file by ken2812221 · Pull Request #14465 · bitcoin/bitcoin · GitHub
15:19 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev
15:20 < ken2812221> The act the same behaviour with mingw builds
15:21 < sipa> ken2812221: i had no idea there was a fix
15:21 < sipa> ken2812221: perhaps you should comment there is one on 14446?
15:22 < ken2812221> I did mention them in issue description.
15:23 < sipa> ken2812221: my apologies
15:24 < sipa> i didn't notice there were fixes mentioned 
15:26 -!- harding_ is now known as harding
15:27 -!- profmac [~ProfMac@2001:470:1f0f:226:3def:8273:dfdb:87c6] has quit [Remote host closed the connection]
15:29 < ken2812221> Now I use bold font to mention to fixes in the description. Hope that people won't ignore them again.
15:34 < sipa> ken2812221: thanks!
15:36 < sipa> ken2812221: i'm sorry if i came about as dismissive about appveyor, but i was a bit annoyed how it is interfering with development for little purpose (being compatible with building on windows is a nice to have, but it's not like we'll create production binaries that way)... though i have to take my words back if there are actual issues that are at the basis here
15:41 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:41 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:42 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
15:46 < jnewbery> sipa: example_test is an example test, for people who don't know how to use our test framework. It didn't used to run in CI. It shouldn't ever fail
15:49 < ken2812221> As laanwj say, the appveyor ci status is not merge blocker. It's a bit racy on Windows, so the error shows more often, we could find the same issue on travis sometimes.
15:57 -!- profmac [~ProfMac@2001:470:1f0f:226:3077:c0f:7e15:6ec3] has joined #bitcoin-core-dev
16:04 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
16:08 -!- tknp [~tknp@unaffiliated/tknp] has quit [Quit: tknp]
16:08 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev
16:08 -!- tknp [~tknp@unaffiliated/tknp] has quit [Client Quit]
16:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:13 -!- jarthur [~jarthur@2605:6000:1019:41ab:3ce8:37ee:b8f0:f5e5] has joined #bitcoin-core-dev
16:16 -!- romanz_ [~romanz@185.3.147.213] has joined #bitcoin-core-dev
16:16 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:17 -!- jarthur [~jarthur@2605:6000:1019:41ab:3ce8:37ee:b8f0:f5e5] has quit [Ping timeout: 276 seconds]
16:17 -!- romanz [~romanz@185.3.147.213] has quit [Ping timeout: 260 seconds]
16:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
16:29 -!- josephnicholas [~josephnic@49.145.51.90] has joined #bitcoin-core-dev
16:36 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds]
16:38 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
16:38 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:41 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
16:42 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 245 seconds]
16:43 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:49 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
16:49 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:53 < promag> jnewbery: I think #13339 can be added to https://github.com/bitcoin/bitcoin/projects/2?
16:53 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
16:53 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 244 seconds]
17:00 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
17:03 -!- jarthur [~jarthur@2605:6000:1019:41ab:9534:a0a5:4f3e:eeb] has joined #bitcoin-core-dev
17:09 < promag> meshcollider: how are you testing #14478?
17:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14478 | Show error to user when corrupt wallet unlock fails by MeshCollider · Pull Request #14478 · bitcoin/bitcoin · GitHub
17:09 < meshcollider> promag: I haven't tested it yet
17:09 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
17:09 < meshcollider> I will have to make a corrupt wallet somehow
17:09 < meshcollider> latest commit is WIP tho
17:11 < promag> you can fake CCryptoKeyStore::Unlock
17:11 -!- josephnicholas [~josephnic@49.145.51.90] has quit [Remote host closed the connection]
17:11 < promag> anyway for these changes a test guide would be nice
17:13 -!- leishman [~leishman@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev
17:15 -!- leishman [~leishman@64-71-8-130.static.wiline.com] has quit [Client Quit]
17:19 < promag> I'm dying with vcpkg install qt5..
17:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
17:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:30 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]
17:39 -!- spinza [~spin@155.93.246.187] has quit [Excess Flood]
17:40 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
17:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
17:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds]
17:49 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:51 -!- Murch [~murch@ip-173-139-83-70.ftwttx.spcsdns.net] has joined #bitcoin-core-dev
18:06 -!- Murch [~murch@ip-173-139-83-70.ftwttx.spcsdns.net] has quit [Quit: Snoozing.]
18:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
18:08 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
18:09 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
18:09 < fanquake> cfields carldong fwiw I started collecting together the determinism cases we discussed at Core Dev, just for easy reference. Let me know if you want anything added, still some to add.
18:09 < fanquake> Notes are here: https://github.com/fanquake/core-review/blob/master/determinism.md
18:11 -!- josephnicholas [~josephnic@49.145.51.90] has joined #bitcoin-core-dev
18:12 -!- hellobitnomics [183c8ca0@gateway/web/freenode/ip.24.60.140.160] has joined #bitcoin-core-dev
18:13 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has joined #bitcoin-core-dev
18:13 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has quit [Changing host]
18:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
18:14 -!- hellobitnomics [183c8ca0@gateway/web/freenode/ip.24.60.140.160] has quit [Client Quit]
18:16 -!- jpe_ [~jpe@2001:16b8:48fd:8300:2fd5:7fe8:28da:c43f] has joined #bitcoin-core-dev
18:19 -!- jpe [~jpe@2001:16b8:48df:1900:dc7c:d547:abf:71f3] has quit [Ping timeout: 260 seconds]
18:32 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
18:33 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has quit [Quit: Lost terminal]
18:34 -!- coolpup is now known as coolcat
18:41 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 246 seconds]
18:45 -!- josephnicholas [~josephnic@49.145.51.90] has quit [Remote host closed the connection]
18:47 -!- IceHard [~user@176.107.82.36] has quit [Remote host closed the connection]
18:58 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
19:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit]
19:10 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
19:11 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev
19:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
19:12 < meshcollider> dongcarl *
19:13 < dongcarl> fanquake: thank you, will take a look
19:14 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit]
19:29 -!- coolcat is now known as coolpup
19:32 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev
19:37 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 252 seconds]
19:39 -!- pkx1 [~pkx@unaffiliated/pkx] has joined #bitcoin-core-dev
19:45 -!- ken2812221_ [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
19:48 -!- pkx1 [~pkx@unaffiliated/pkx] has quit [Remote host closed the connection]
19:49 -!- ken2812221__ [~ken281222@2001-b011-4010-14fa-5940-50b4-e455-30f9.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
19:53 -!- ken2812221_ [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Ping timeout: 276 seconds]
19:59 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev
19:59 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit]
20:00 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Read error: Connection reset by peer]
20:01 -!- ken2812221__ is now known as ken2812221
20:05 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
20:13 -!- jarthur_ [~jarthur@2605:6000:1019:41ab:3ce8:37ee:b8f0:f5e5] has joined #bitcoin-core-dev
20:16 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-5940-50b4-e455-30f9.dynamic-ip6.hinet.net] has quit [Remote host closed the connection]
20:16 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-5940-50b4-e455-30f9.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
20:18 -!- jarthur_ [~jarthur@2605:6000:1019:41ab:3ce8:37ee:b8f0:f5e5] has quit [Ping timeout: 260 seconds]
20:27 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has quit [Read error: Connection reset by peer]
20:28 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
20:57 -!- schnerch_ [~schnerchi@p3EE1C1B7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
21:00 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 260 seconds]
21:00 -!- schnerchi [~schnerchi@p3EE1C053.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
21:22 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
21:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gbpewtctrpuvfmgt] has joined #bitcoin-core-dev
21:33 < bitcoin-git> [bitcoin] kallewoof opened pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507
21:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gbpewtctrpuvfmgt] has left #bitcoin-core-dev []
21:39 < achow101> meshcollider: easy way to corrupt a wallet is to db_dump, change some bytes randomly, and then db_load to make the .dat file again
21:40 < achow101> I can make one for you
21:40 < meshcollider> achow101: ah yep, although promag is right, I could just force the code to throw the error anyway
21:41 < meshcollider> ill come back to that after the segwit importmulti stuff is done
21:41 < achow101> there's a bunch of failures involving corrupted wallets that we don't test. we could add a corrupted wallet to the test suite and then test those things
22:08 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
22:12 -!- bralycl__ [~bralyclow@195.242.213.117] has quit [Ping timeout: 245 seconds]
22:13 -!- bralyclo_ [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev
22:16 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 250 seconds]
22:28 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
22:29 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
22:32 -!- josephnicholas [~josephnic@110.54.244.40] has joined #bitcoin-core-dev
22:35 -!- josephnicholas [~josephnic@110.54.244.40] has quit [Client Quit]
22:35 -!- jarthur [~jarthur@2605:6000:1019:41ab:9534:a0a5:4f3e:eeb] has quit [Remote host closed the connection]
22:42 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has quit [Read error: Connection reset by peer]
22:43 -!- Krellan [~Krellan@2601:640:4000:9258:96b:c6b4:7ae:b201] has joined #bitcoin-core-dev
22:49 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-5940-50b4-e455-30f9.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds]
23:37 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xwdumxkevttgixor] has joined #bitcoin-core-dev
23:45 < bitcoin-git> [bitcoin] laanwj closed pull request #14370: utils and libraries: Allow values quoting in config files (master...20181002-config-quotes) https://github.com/bitcoin/bitcoin/pull/14370
23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xwdumxkevttgixor] has left #bitcoin-core-dev []
23:50 < promag> achow101: instead of adding a corrupted wallet, could add code to corrupt the wallet
23:52 < promag> wumpus: I'd love to see 14291 reviewed
23:55 < promag> wumpus: I think that optimisations could be added next if worth it, like caching results, pagination or ryanofsky suggestion 
23:56 < wumpus> 'code to corrupt the wallet' ehhh what about no :$
23:57 < wumpus> that's, like, wiring a footgun to your program, or do you mean in the test framework?
23:57 < wumpus> promag: ok
23:58 < wumpus> promag: I don't really care about it being optimized, just it being correct and not interfering with other use of the file system
23:58 < wumpus> promag: will re-review
23:59 < promag> wumpus: thanks!
23:59 < wumpus> so does it avoid nuking the lock now?
--- Log closed Thu Oct 18 00:00:40 2018