--- Log opened Thu Nov 01 00:00:54 2018 00:01 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 00:02 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 00:04 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 00:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 00:57 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 01:02 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 01:02 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 246 seconds] 01:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:06 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 01:08 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:09 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 01:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 01:24 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 01:36 -!- rhavar [uid237883@gateway/web/irccloud.com/x-sseoqjwatueyouni] has quit [Quit: Connection closed for inactivity] 01:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:41 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 01:49 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: No route to host] 01:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:56 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 01:57 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 01:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bwyurmvhyyptqouw] has joined #bitcoin-core-dev 01:57 < bitcoin-git> [bitcoin] merland closed pull request #14553: [wip] qt: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553 01:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bwyurmvhyyptqouw] has left #bitcoin-core-dev [] 02:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jumokudbmgwudeln] has joined #bitcoin-core-dev 02:29 < bitcoin-git> [bitcoin] murrayn opened pull request #14628: Trivial: Rename misleading 'defaultPort' to 'rpc_port' (master...rpc_port) https://github.com/bitcoin/bitcoin/pull/14628 02:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jumokudbmgwudeln] has left #bitcoin-core-dev [] 02:31 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 02:52 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 02:58 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 03:07 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has joined #bitcoin-core-dev 03:08 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 03:08 < wumpus> phantomcircuit: looking at it 03:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 03:19 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 03:30 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has quit [Read error: Connection reset by peer] 03:39 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:50 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:01 -!- wxss [~user@185.169.255.74] has joined #bitcoin-core-dev 04:14 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 04:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 05:03 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 05:03 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 05:03 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 05:08 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 05:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 05:15 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 05:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 05:34 -!- Jack_ [44865a9c@gateway/web/freenode/ip.68.134.90.156] has joined #bitcoin-core-dev 05:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:41 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Ping timeout: 276 seconds] 05:41 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 264 seconds] 05:42 -!- Jack_ [44865a9c@gateway/web/freenode/ip.68.134.90.156] has quit [Quit: Page closed] 05:51 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 05:53 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 05:53 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 05:56 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:58 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 05:59 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 06:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:07 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 06:11 -!- echonaut15 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 06:12 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 06:13 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 06:13 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 06:13 < wumpus> can we get some reviews for #14532? at one point everyone seemed concerned about this issue, and not it just lingers 06:13 < gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub 06:13 < wumpus> now* 06:13 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 06:23 -!- wxss [~user@185.169.255.74] has quit [Quit: leaving] 06:24 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 06:24 -!- wxss [~user@185.169.255.74] has joined #bitcoin-core-dev 06:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rdwvcjtzxogtmcyy] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b312579c69f1...d38a5092f17f 06:25 < bitcoin-git> bitcoin/master 0e6de3a Martin Erlandsson: added details about commit messages 06:25 < bitcoin-git> bitcoin/master d38a509 Wladimir J. van der Laan: Merge #14600: docs: Clarify commit message guidelines... 06:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rdwvcjtzxogtmcyy] has left #bitcoin-core-dev [] 06:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wvtjygfplhgkpufz] has joined #bitcoin-core-dev 06:27 < bitcoin-git> [bitcoin] laanwj closed pull request #14600: docs: Clarify commit message guidelines (master...update-contrib) https://github.com/bitcoin/bitcoin/pull/14600 06:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wvtjygfplhgkpufz] has left #bitcoin-core-dev [] 06:27 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 06:28 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 06:28 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 06:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lxszrmgwthfnbmjk] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d38a5092f17f...08a57d51e90c 06:29 < bitcoin-git> bitcoin/master cf2f430 fanquake: gui: explicitly disable "Dark Mode" appearance on macOS 06:29 < bitcoin-git> bitcoin/master 08a57d5 Wladimir J. van der Laan: Merge #14593: gui: explicitly disable "Dark Mode" appearance on macOS... 06:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lxszrmgwthfnbmjk] has left #bitcoin-core-dev [] 06:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-anuiqmumxqvpjqnt] has joined #bitcoin-core-dev 06:30 < bitcoin-git> [bitcoin] laanwj closed pull request #14593: gui: explicitly disable "Dark Mode" appearance on macOS (master...macos-disable-darkmode) https://github.com/bitcoin/bitcoin/pull/14593 06:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-anuiqmumxqvpjqnt] has left #bitcoin-core-dev [] 06:32 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 06:36 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 06:53 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 06:53 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...] 06:58 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 07:08 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 07:08 -!- josephnicholas [~josephnic@110.54.246.39] has joined #bitcoin-core-dev 07:09 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 07:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:14 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds] 07:14 -!- josephnicholas [~josephnic@110.54.246.39] has quit [Ping timeout: 272 seconds] 07:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 07:35 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wjxazgqbapuivsdx] has joined #bitcoin-core-dev 07:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08a57d51e90c...6a095bc5f239 07:43 < bitcoin-git> bitcoin/master 4bd125f Chun Kuan Lee: tests: Print dots by default 07:43 < bitcoin-git> bitcoin/master 6a095bc MarcoFalke: Merge #14569: tests: Print dots by default in functional tests... 07:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wjxazgqbapuivsdx] has left #bitcoin-core-dev [] 07:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ulkdewydeiehnshp] has joined #bitcoin-core-dev 07:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14569: tests: Print dots by default in functional tests (master...travis-avoid-timeout) https://github.com/bitcoin/bitcoin/pull/14569 07:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ulkdewydeiehnshp] has left #bitcoin-core-dev [] 07:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wquwpkzqymfflofo] has joined #bitcoin-core-dev 07:59 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14630: test_runner: Remove travis specific code (master...Mf1811-testNoTravis) https://github.com/bitcoin/bitcoin/pull/14630 07:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wquwpkzqymfflofo] has left #bitcoin-core-dev [] 08:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nnbsxnesdoqyqtil] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a095bc5f239...9899e65d84e7 08:05 < bitcoin-git> bitcoin/master 0a04667 Murray Nesbitt: FreeBSD: Document Python 3 requirement for 'gmake check' 08:05 < bitcoin-git> bitcoin/master 9899e65 Wladimir J. van der Laan: Merge #14617: FreeBSD: Document Python 3 requirement for 'gmake check'... 08:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nnbsxnesdoqyqtil] has left #bitcoin-core-dev [] 08:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oqccsuvjksfgafpt] has joined #bitcoin-core-dev 08:07 < bitcoin-git> [bitcoin] laanwj closed pull request #14617: FreeBSD: Document Python 3 requirement for 'gmake check' (master...freebsd-test-doc) https://github.com/bitcoin/bitcoin/pull/14617 08:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oqccsuvjksfgafpt] has left #bitcoin-core-dev [] 08:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ojfuxslonurcilpj] has joined #bitcoin-core-dev 08:10 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9899e65d84e7...f6df989842a1 08:10 < bitcoin-git> bitcoin/master f8c1714 Andrew Chow: Convert non-witness UTXOs to witness if witness sig created... 08:10 < bitcoin-git> bitcoin/master 862d159 Pieter Wuille: Add test for conversion from non-witness to witness UTXO 08:10 < bitcoin-git> bitcoin/master f6df989 Wladimir J. van der Laan: Merge #14197: [psbt] Convert non-witness UTXOs to witness if witness sig created... 08:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ojfuxslonurcilpj] has left #bitcoin-core-dev [] 08:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xhxqrqbyfopdspld] has joined #bitcoin-core-dev 08:11 < bitcoin-git> [bitcoin] laanwj closed pull request #14197: [psbt] Convert non-witness UTXOs to witness if witness sig created (master...psbt-utxos) https://github.com/bitcoin/bitcoin/pull/14197 08:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xhxqrqbyfopdspld] has left #bitcoin-core-dev [] 08:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vjfjafnziudytmlk] has joined #bitcoin-core-dev 08:12 < bitcoin-git> [bitcoin] jnewbery opened pull request #14631: [tests] Move deterministic address import to setup_nodes (master...deprecate_generate2) https://github.com/bitcoin/bitcoin/pull/14631 08:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vjfjafnziudytmlk] has left #bitcoin-core-dev [] 08:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cxlpmguopntyadkj] has joined #bitcoin-core-dev 08:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6df989842a1...f69d92299dea 08:18 < bitcoin-git> bitcoin/master fa77aaa MarcoFalke: doc: Add external interface consistency guarantees 08:18 < bitcoin-git> bitcoin/master f69d922 Wladimir J. van der Laan: Merge #14592: doc: Add external interface consistency guarantees... 08:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cxlpmguopntyadkj] has left #bitcoin-core-dev [] 08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ghchszlpxfcouutl] has joined #bitcoin-core-dev 08:19 < bitcoin-git> [bitcoin] laanwj closed pull request #14592: doc: Add external interface consistency guarantees (master...Mf1810-docCon) https://github.com/bitcoin/bitcoin/pull/14592 08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ghchszlpxfcouutl] has left #bitcoin-core-dev [] 08:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rmeskirjvfsyjsjw] has joined #bitcoin-core-dev 08:26 < bitcoin-git> [bitcoin] fridokus opened pull request #14632: Tests: Fix a comment (master...typo_fix) https://github.com/bitcoin/bitcoin/pull/14632 08:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rmeskirjvfsyjsjw] has left #bitcoin-core-dev [] 08:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lptvnclbmzctdcpm] has joined #bitcoin-core-dev 08:31 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f69d92299dea...5049f7f7a9e7 08:31 < bitcoin-git> bitcoin/master 9605bbd Carl Dong: Make clear function argument case in dev notes 08:31 < bitcoin-git> bitcoin/master 5049f7f Wladimir J. van der Laan: Merge #14625: Make clear function argument case in dev notes... 08:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lptvnclbmzctdcpm] has left #bitcoin-core-dev [] 08:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hprliruocnkvgimu] has joined #bitcoin-core-dev 08:33 < bitcoin-git> [bitcoin] laanwj closed pull request #14625: Make clear function argument case in dev notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14625 08:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hprliruocnkvgimu] has left #bitcoin-core-dev [] 08:34 < achow101> that's a lot of merges 08:36 < wumpus> yeh 08:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:45 < achow101> wumpus: while you're at it, merge #14377? 08:45 < gribble> https://github.com/bitcoin/bitcoin/issues/14377 | check that a separator is found for psbt inputs, outputs, and global map by achow101 · Pull Request #14377 · bitcoin/bitcoin · GitHub 09:08 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Ping timeout: 252 seconds] 09:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:09 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 09:13 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 09:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 09:18 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 09:20 -!- rhavar [uid237883@gateway/web/irccloud.com/x-hsahsgckzbpkvdll] has joined #bitcoin-core-dev 09:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds] 09:25 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 09:26 < sipa> MarcoFalke: idea for the conflict checker... have DrahtBot post a dummy comment on every PR as soon as it's opened, and then update that comment whenever needed 09:27 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:35 < wumpus> that... sounds like a good idea 09:35 < wumpus> achow101: ok 09:36 < wumpus> could keep updating the same post instead of posting new ones would save on some mail 09:53 < luke-jr> sipa: that will break the email notifications :/ 09:53 < luke-jr> (updating it sounds fine though) 09:54 < sipa> luke-jr: i don't think the email notifications are useful (they mostly mess up my workflow in trying to find recently updated PRs to review... and then realize that they haven't been touched in 2 months, but someone just opened a tiny refactor that conflicts with it) 09:55 < sipa> the "needs rebase" messages are kinda useful, i think 09:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-boxemagqdjvqaguc] has joined #bitcoin-core-dev 09:56 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5049f7f7a9e7...51e5ef3971c7 09:56 < bitcoin-git> bitcoin/master 4fb3388 Andrew Chow: check that a separator is found for psbt inputs, outputs, and global map 09:56 < bitcoin-git> bitcoin/master 51e5ef3 Wladimir J. van der Laan: Merge #14377: check that a separator is found for psbt inputs, outputs, and global map... 09:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-boxemagqdjvqaguc] has left #bitcoin-core-dev [] 09:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fwkywlyhkinewpjm] has joined #bitcoin-core-dev 09:57 < bitcoin-git> [bitcoin] laanwj closed pull request #14377: check that a separator is found for psbt inputs, outputs, and global map (master...fix-psbt-seps) https://github.com/bitcoin/bitcoin/pull/14377 09:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fwkywlyhkinewpjm] has left #bitcoin-core-dev [] 10:00 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 10:01 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 10:03 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 10:06 < luke-jr> sipa: I think the initial notification after opening might be useful to get the content emailed, I mean 10:06 < luke-jr> ie, just skip the dummy post 10:07 < wumpus> I don't think the email notifications for the bot are useful either 10:07 < wumpus> sure, the 'needs rebase' mail is useful for the author of the PR but not others subscribing to it 10:08 < wumpus> I think that's the crux, most of the information is aimed at the author but everyone somehow involved will get the mail, I get so much github notifications I can't pay much attention to them 10:09 < wumpus> (though I have notifications specifically tagging me sorted differently) 10:09 < sipa> i don't generally use the notifications at all; but at least "sort by recently updated" was useful before the bot :) 10:10 < luke-jr> hmm 10:10 < luke-jr> maybe the bot should hook in like Travis 10:10 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 10:11 < gmaxwell> breaking sort by recently updated has probably reduced the amount of review I do by 80%, FWIW. 10:11 < gmaxwell> as I'd typical go and sort by updated and check in on all the active PRs. 10:12 < wumpus> luke-jr: yes that would be preferable, but I do not know if github provides that functionality to random developers, lacking that, sipa's idea to post once then update is a good idea 10:13 < sipa> actually, a top comment that gets updated may not be enough to un-break it; the PRs that get newly referenced by another post's "conflicts with" will still be marked as recently updated 10:16 < gmaxwell> another alternative would be to just post some external thing with the real recently updated data. 10:16 < gmaxwell> e.g. go scrap github or new commits every couple hours and post a report somewhere. 10:17 < gmaxwell> scrape* 10:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 10:18 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Read error: Connection timed out] 10:19 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 10:21 < wumpus> gmaxwell: ah yes kind of what bitcoinacks.com does 10:33 * gmaxwell quietly leaves https://www.silasreinagel.com/blog/2018/10/30/indirection-is-not-abstraction/ here 10:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:46 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection] 10:47 < phantomcircuit> wumpus, thanks for reviewing 10:48 < wumpus> gmaxwell: looks interesting! 10:49 < MarcoFalke> hmm, just catching up on the bot review. 10:50 < MarcoFalke> I wasn't aware that people actually used the github sort by most recent change 10:50 < MarcoFalke> *update 10:51 < sipa> MarcoFalke: it's the only thing i use :) 10:51 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 10:51 < sipa> (but maybe others have different workflows) 10:51 < ryanofsky> posted feature request for bitcoin-acks: https://github.com/PierreRochard/bitcoin-acks/issues/78 10:52 < MarcoFalke> By moving the content somewhere else, I am worried no one will look at it. 10:52 < sipa> MarcoFalke: agree 10:52 < gmaxwell> it sounds like even without the bot the most recent update is kinda broken 10:52 < gmaxwell> the bot just makes it much worse. 10:52 < sipa> gmaxwell: how so? 10:53 < gmaxwell> you were saying above that it moves PRs to the top when they're mentioned in other PRs. 10:53 < MarcoFalke> I can definetly break the links with a url like https://drahtbot.github.io/bitcoin_issue_redirect/1111 10:53 < sipa> yeah, but that used to be pretty rare 10:53 < gmaxwell> (I don't recall that but I figure I wouldn't have noticed because it would have been infrequent) 10:54 < sipa> MarcoFalke: i think that would be useful if it's not too much work 10:54 < MarcoFalke> Should be ~zero work. Static html should be sufficient 10:55 < sipa> this is obviously some strange usage of the word zero that i wasn't previously aware of :) 10:55 < MarcoFalke> ~zero == about zero == little 10:58 < MarcoFalke> ryanofsky actually brought up the idea to have one comment per pull request that gets updated. That would be a bit more work, depending on how much I want to solve edit conflicts. (The bot runs in multiple processes) 10:58 < MarcoFalke> Also it'd mean more empty comments 10:59 < sipa> just one per PR 11:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:01 < ryanofsky> i think it'd be nice if draftbot just claimed and kept updating the first comment in every pr. especially if it could tell you useful status information, like how many acks the pr has 11:02 < sipa> that would be great 11:02 < sipa> (but quite a bit of work i imagine) 11:03 < sipa> some review on #13501 would be welcome; it may fix some of the appveyor spurious failures 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub 11:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 11:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:12 < jnewbery> MarcoFalke: sort-by-most-recent-change used to be the only thing I used, but it's mostly not very helpful now 11:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 11:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vgmsbneykivoquzz] has joined #bitcoin-core-dev 11:21 < bitcoin-git> [bitcoin] kostyantyn opened pull request #14633: Fix height serialization inside script of coinbase input (master...fix_height_serialization_in_coinbase) https://github.com/bitcoin/bitcoin/pull/14633 11:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vgmsbneykivoquzz] has left #bitcoin-core-dev [] 11:27 < pierre_rochard> ryanofsky I added a question on the GH issue, for potential or current users of bitcoinacks: is "most-recent-change" preference to be the PR comment thread (excluding bots) or to the actual PR code? 11:27 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 11:28 -!- rhavar [uid237883@gateway/web/irccloud.com/x-hsahsgckzbpkvdll] has quit [Quit: Connection closed for inactivity] 11:28 < pierre_rochard> I can do both, I just want to avoid making the table wider than it already is if one is clearly more useful for reviewers 11:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:34 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 11:36 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 11:37 -!- Tralfaz [~none@185.156.175.59] has quit [Remote host closed the connection] 11:37 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 11:38 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Client Quit] 11:38 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 11:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qubctzixamrmdbna] has joined #bitcoin-core-dev 11:41 < bitcoin-git> [bitcoin] JBaczuk closed pull request #14610: Docs: correction to test readme compile instructions (master...fix_test_readme_compile_instructions) https://github.com/bitcoin/bitcoin/pull/14610 11:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qubctzixamrmdbna] has left #bitcoin-core-dev [] 11:53 < MarcoFalke> See for example https://github.com/bitcoin/bitcoin/pull/14630#issuecomment-435107340 with the new redirect url 11:53 < MarcoFalke> Let me know if it doesn't work for anyone 11:56 -!- bralyclo_ [~bralyclow@2600:1700:3d70:93b0:1b4:d1ad:2649:4f3b] has joined #bitcoin-core-dev 11:59 < provoostenator> Ok, so I can confirm the meeting time sucks for Asia :-) But we already tried the poll thing. Back in Europe now. 12:00 < MarcoFalke> huh, though I wonder if GitHub will update the "last-updated" when I edit (the first) or any comment 12:00 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Ping timeout: 268 seconds] 12:00 < MarcoFalke> meat thing? 12:01 < jnewbery> wumpus ^ 12:01 < achow101> meat? 12:01 < jnewbery> summer time is over 12:01 < MarcoFalke> https://www.google.com/search?q=time+in+rejkjavik 12:01 < MarcoFalke> 7pm 12:01 < jnewbery> (in europe) 12:02 < provoostenator> Summer time might even be permanently over in some parts of Europe 12:03 < achow101> when does dst end in the us? 12:03 < jnewbery> this sunday 12:03 < jcorgan> in some parts of europe the idea of summer is merely a theoretical construct anyway 12:04 < sipa> #startmeeting 12:04 < lightningbot> Meeting started Thu Nov 1 19:04:17 2018 UTC. The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:04 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:04 < instagibbs> hi 12:04 < sipa> topics? 12:04 < MarcoFalke> hi 12:04 < jnewbery> hi 12:04 < luke-jr> suggested topic: do we have a way to test non-HD wallet code paths at this point? :/ 12:04 < MarcoFalke> Could someone do the ping string? 12:05 < jnewbery> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:05 < MarcoFalke> suggested topic: High priority for review 12:05 < provoostenator> Topic suggesiton: wallet refactor progress 12:05 < MarcoFalke> thx 12:05 < jnewbery> that one? 12:05 < sipa> thanks jnewbery 12:05 < sipa> #topic high priority for review 12:05 < sipa> let's start with that one 12:05 < achow101> we should make a gribble command for the meeting ping 12:06 < sipa> on the list are #14532 #14350 #14046 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub 12:06 < sipa> anyone wants to add/remove something? 12:06 < meshcollider> Hi 12:07 < kanzure> hi. 12:07 < achow101> can I get #13932 on hi prio? 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub 12:07 < achow101> I'll rebase it today 12:07 < phantomcircuit> hello 12:07 < luke-jr> usually hi-prio requires up-to-date-base before being added, but no reason it needs to be added during meetings 12:08 < sipa> achow101: yeah, ping me when rebased 12:08 < MarcoFalke> I'd like to propose #14437 if ryanofsky commits to rebasing it 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/14437 | Refactor: Start to separate wallet from node by ryanofsky · Pull Request #14437 · bitcoin/bitcoin · GitHub 12:08 < provoostenator> ^ good idea, this new PR is much smaller than the original and a good start 12:09 < sipa> i'd like to add #14477 12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub 12:09 < provoostenator> ^ works for me 12:10 < phantomcircuit> i believe #14336 is done and needs more eyeballs 12:10 < sipa> done 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub 12:10 < sipa> ryanofsky: happy to put on the list if up to date 12:10 < sipa> phantomcircuit: ack 12:10 < provoostenator> It also needs a more appealing description. 12:10 < phantomcircuit> provoostenator, true 12:10 < sipa> agree, but let's not do review in this meeting 12:11 < MarcoFalke> Added #14437 and #14477 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/14437 | Refactor: Start to separate wallet from node by ryanofsky · Pull Request #14437 · bitcoin/bitcoin · GitHub 12:11 < achow101> sipa: rebased it 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub 12:11 < provoostenator> No, that was more a general suggestion, some PR's have quite poor descriptions. 12:11 < sipa> phantomcircuit: added to the list 12:12 < sipa> achow101: done 12:12 < sipa> ok 12:12 < meshcollider> sipa: btw I realise 14477 duplicates the addition of solvable to getaddressinfo 12:12 < luke-jr> provoostenator: more annoying is the intentionally confusing titles IMO :/ 12:12 < sipa> #topic do we have a way to test non-HD wallet code paths at this point? 12:13 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 12:13 < sipa> luke-jr: ^ 12:13 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 12:13 < luke-jr> yeah, it looks like -usehd removal just removed the tests :/ 12:13 < luke-jr> and I think it should get tested 12:13 < provoostenator> Easiest solution might be just add a legacy wallet payload to the functional test suite and then load that. 12:13 < achow101> there's no way to create a non-hd wallet, so they can't be tested unless a non-hd wallet is put into the test data 12:14 < sipa> phantomcircuit: seems reasonable to me 12:14 < MarcoFalke> sipa: Any reason why you added 13932 to "For backport" in high priority? 12:14 < sipa> eh, provoostenator ^ 12:14 < MarcoFalke> It is tagged with 0.18.0 12:14 < luke-jr> good idea, didn't think of that 12:14 < provoostenator> Dynamic wallet loading feature is quite handy. 12:14 < sipa> MarcoFalke: did i? 12:14 < sipa> oh, indeed; fixed 12:15 < luke-jr> or github did and attributed it to you? XD 12:15 < gwillen> I would love for #14588 to get looked at, I don't know what the criteria for high priority are. :-) I did just rebase it. 12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14588 | Refactor PSBT signing logic to enforce invariant and fix signing bug by gwillen · Pull Request #14588 · bitcoin/bitcoin · GitHub 12:15 < MarcoFalke> on topic: The way to test legacy wallet paths is #14536 12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14536 | functional test with ancient wallet.dat (upgrade test) · Issue #14536 · bitcoin/bitcoin · GitHub 12:15 < sipa> gwillen: every active contributor gets to nominate one PR they want to encourage others to look at, because it is blocking their own work 12:15 < jnewbery> lukejr: see also https://github.com/bitcoin/bitcoin/pull/12134#issuecomment-430107394 . Having some different version wallet payloads in the test framework would be generally useful 12:16 < sipa> yes, i agree 12:16 < sipa> we do not care about the ability to create such wallets anymore, but as long as they're supported we should test them - especially we should test upgrade scenarios 12:16 < jnewbery> ah, thanks Marco. I'll take a look at that 12:16 < luke-jr> hmm 12:17 < luke-jr> so we might actually want to run the wallet tests against N different wallets 12:17 < sipa> i guess we may want to discuss different approaches on #14536? 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14536 | functional test with ancient wallet.dat (upgrade test) · Issue #14536 · bitcoin/bitcoin · GitHub 12:21 < luke-jr> sgtm 12:21 < sipa> anything more on this topic? 12:21 < sipa> #topic wallet refactor progress 12:21 < sipa> provoostenator: ^ 12:22 < provoostenator> sipa: you've been adding a lot of descriptor magic, which is great 12:22 < provoostenator> What's next? 12:22 < provoostenator> And do we want to have a seperate recurring wallet-refactor meeting? 12:22 < sipa> provoostenator: tomorrow's wallet meeting (DING DING reminder) 12:22 < provoostenator> TIL, nice 12:22 < sipa> provoostenator: yes, we had the first one 2 weeks ago 12:22 < instagibbs> waiting for review go ahead for #14565 12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub 12:22 < instagibbs> in prep for importmulti descriptor.. 12:22 < provoostenator> What time? 12:23 < sipa> provoostenator: same time as this meeting, but a day later, and only every 2 weeks 12:24 < sipa> more concretely what's next: * the current "old style" descriptor import (which downconverts the descriptor to the existing wallet structures) 12:24 < achow101> #14491 implements descriptor import for importmulti, although that should probably be rebased onto #14565 12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub 12:24 < sipa> yup, that 12:24 < sipa> then some preparation work for being able to use descriptors instead of keypools (which requires logic for caching pubkeys etc), i plan to work on that 12:25 < meshcollider> Yep I'll rebase it as soon as 14565 is in 12:25 < provoostenator> Sweet, that should make achow101's hardware wallet stuff easier too. 12:25 < provoostenator> Feel free to tag me on those PRs, in case I miss them. 12:25 < sipa> with follow up some refactoring to move the existing keypool/ismine logic behind an abstraction that can be instantiated with the old logic, or descriptors (so we can natively import descriptors) 12:25 < achow101> provoostenator: instagibbs: the plan is to make hwi do things with descriptors instead of the different pubkey stuff I was doing earlier 12:26 < sipa> and i think independently there is also a possibility for a few more RPCs now, like PSBT signing that takes descriptors as inpit 12:26 < instagibbs> achow101, That was my assumption 12:26 < achow101> so i'll have to rebase #14075 on top of 14491 12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub 12:26 < achow101> probably 12:27 < instagibbs> should be simply 12:27 < sipa> there are other wallet related topics, like ryanofsky's wallet separation 12:28 < sipa> ryanofsky: here? 12:28 < ryanofsky> yes sir 12:28 < sipa> or maybe we can bring that up in tomorrow's meeting 12:28 < provoostenator> Thanks for the quick overview, happy to wait until tomorrow for more details. 12:28 < sipa> it's on high priority too, so hopefully it can get some more attention 12:28 < sipa> if that's enough for this topic, i have another one myself: appveyor failures 12:29 < phantomcircuit> sipa, the wallet stuff seems to be sort of a specialized thing 12:29 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 12:29 < phantomcircuit> it's pretty difficult to maintain any idea of how it's working unless you're spending a lot of time looking at it 12:30 < provoostenator> The refactoring seems to be taking it to a place where it's easier to understand. 12:30 < sipa> phantomcircuit: yeah... i hope it will improve in the future 12:30 < provoostenator> I generally find the "after" code a lot more readable than the "before" code. 12:30 < provoostenator> And descriptors are very useful. 12:31 < luke-jr> they even do the dishes 12:31 < sipa> ha 12:32 < sipa> #topic appveyor failures 12:32 < sipa> i find it pretty annoying that appveyor currently spuriously fails quite frequently 12:33 < jnewbery> they're annoying 12:33 < meshcollider> Indeed 12:33 < sipa> there's an open issue (#14446) 12:33 < gribble> https://github.com/bitcoin/bitcoin/issues/14446 | tests: Some issue about running functional tests on Windows · Issue #14446 · bitcoin/bitcoin · GitHub 12:33 < provoostenator> Is it fixable or is there an alternative platform? 12:33 < provoostenator> Because ignoring Windows may be less annoying, but not a good idea :-) 12:33 < sipa> and one alleged improvement to it, #13501, which i think should urgently get some attention 12:33 < gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub 12:33 < sipa> provoostenator: it's doing MSVC builds and MinGW on windows, which aren't used for any production binaries 12:34 < sipa> so they're useful in likely testing for other types of issues by means of platform variety, but they're not necessarily issues that affect real production deployments 12:34 < luke-jr> sipa: well, we don't test Windows binaries when built on gitian/Linux, right? 12:34 < luke-jr> with CI I mean 12:35 < sipa> luke-jr: that's fair! 12:35 < sipa> anyway, i'd just very much like to get some attention to improving this, as continuously seeing red crosses in travis is pretty annoying 12:36 < luke-jr> for now I just ignore the appveyor failures on my PRs 12:37 < sipa> anyone have other topics? 12:38 < meshcollider> It is quite easy to restart appveyor in the same way to restart Travis btw, if it fails 12:38 < sipa> meshcollider: yes, i've restarted dozens of appveyor failures the past days... 12:40 < sipa> #topic open floor: what are people working on? 12:40 < jarthur> I'd bring up unix socket RPC topic again, but haven't had time to think about it. It sounded like folks are ok if it needs to go forward on bitcoind even if cli only has TCP, provided there are thorough tests. 12:40 < luke-jr> rebasing all my PRs :x 12:41 < sipa> jarthur: i personally am ok with that, especially since we have an option to use a different HTTP implementation in bitcoin-cli 12:41 < achow101> psbt + hww stuff ..... and taking lots of exams 12:41 < jnewbery> sipa: still not enough, but hoping to spend much more time reviewing wallet PRs before the end of the year 12:41 < sipa> achow101: good luck! 12:43 < sipa> i've picked up looking at private authentication again (being able to tell a peer is one of multiple acceptable peers who pubkey you know, but they don't learn who you were looking for, and you don't learn who they are, just that they're part of your acceptable set)... this is probably too novel to deploy, but it's a fun exercise 12:43 < sipa> jnewbery: cool :) 12:44 < instagibbs> jnewbery, same, as well as HWI assistance 12:44 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 12:45 < meshcollider> I want to continue focusing on the wallet rework and everything mainly and reviewing wallet stuff like jnewbery 12:45 < meshcollider> And exams like achow101 xD 12:46 < sipa> perhaps you guys should collaborate on the exam thing? :p 12:46 < sipa> ok, any more topics? 12:47 < meshcollider> sipa: lol, he can write it and I'll review :) 12:47 < luke-jr> LOL 12:47 < luke-jr> open source exam answers 12:48 < sipa> #endmeeting 12:48 < lightningbot> Meeting ended Thu Nov 1 19:48:24 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:48 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.html 12:48 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.txt 12:48 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.log.html 12:48 < sipa> thanks all 12:50 < wumpus> oh crap I missed the meeting due to daylight saving difference, sorry 12:51 < achow101> wumpus: don't worry, all of us in the US will do the same next week 12:51 * wumpus wants to move to iceland... 12:51 < luke-jr> achow101: not those of us who use Tonal 12:52 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection] 12:53 < sipa> wumpus: isn't the EU going to abolish DST? 12:53 < provoostenator> EU in bureaucratic tradition decided to make it up to individual countries. 12:54 < sipa> so reminder: the meeting time next week will be 11am west coast, 2pm east coast, 20:00 central european 12:54 < provoostenator> Some of which think it's a good idea to make DST permanent. 12:54 < sipa> provoostenator: yeah, i saw that - making the netherlands and belgium generally 2 hours off solar time 12:54 < sipa> or 1:40 at least 12:55 < provoostenator> With sunrise in winter at 9:50am 12:55 < luke-jr> what is solar time? 12:55 < provoostenator> 12:00 should be when the sun is directly overhead 12:55 < provoostenator> which in my opinion should be done per city :-) 12:55 < luke-jr> ah 12:56 < sipa> provoostenator: the sun is never directly overhead unless you're between the tropics 12:56 < sipa> you mean having the sun at its highest point at 12:00 12:56 < provoostenator> Yes 12:56 < luke-jr> usually I have a roof between me and the sun 12:56 * sipa is in favor of 1 timezone per continent 12:57 * luke-jr is in favour of 1 timezone period and everyone just gets used to what times the sun rises and falls in their own region 12:57 < wumpus> sipa: I hope they will, I really do 12:58 < provoostenator> Gondwana time? 12:58 < luke-jr> ? 12:59 < provoostenator> https://en.wikipedia.org/wiki/Gondwana 12:59 < luke-jr> provoostenator: https://en.wikipedia.org/wiki/File:Hexadecimal_Clock_by_Nystrom.jpg 12:59 -!- Tralfaz [~none@185.156.175.59] has quit [Quit: Leaving] 13:03 < phantomcircuit> sipa, appveyor failed on 14336... 13:03 < phantomcircuit> (i added a comment and now it fails 13:09 < wumpus> wasn't that just a random failure? 13:14 -!- clarkmoo_ [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 13:14 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 13:17 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Ping timeout: 268 seconds] 13:17 < phantomcircuit> wumpus, yes he's been resetting them 13:17 < phantomcircuit> obviously not a long term solution 13:23 < MarcoFalke> agree. I wasn't expecting we see so much failures nor that it takes so long to fix them. 13:24 < MarcoFalke> Might want to disable most of the functional tests for now on windows. 13:24 < MarcoFalke> And make it a target to fix them until 0.18.0? 13:24 < sipa> well let's see how things improve with #13501 first? 13:24 < gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub 13:26 < MarcoFalke> yeah, fine. I am not fluent in libevent, so at least I can't review it apart from Concept ACK 13:29 < wumpus> phantomcircuit: appveyor has been kind of flakey since the beginning, I don't put as much weight in its result as travis' 13:29 < wumpus> it's useful to see what the windows build does, but not a merge blocker for me 13:30 < esotericnonsense> the worst thing about the EU DST thing is brexit. 13:30 < esotericnonsense> it could have been glorious. i could be in UTC _forever_. 13:30 < esotericnonsense> this is so much worse than mass deportations etc. 13:33 < esotericnonsense> (ok technically I'd be in GMT, but whatever). 13:35 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [] 13:42 < sipa> wumpus: i wish there was a way to have it report its status without changing the PR's "CI passed" status 13:43 < wumpus> sipa: agree that would be useful 13:44 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 13:50 < wumpus> provoostenator: heh I'd never heard of Gondwana, just Pangaea 14:02 -!- jarthur [~jarthur@207.114.244.5] has quit [] 14:08 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 14:14 -!- ken2812221_ [~ken281222@110.50.135.178] has joined #bitcoin-core-dev 14:17 -!- nejon [uid38993@gateway/web/irccloud.com/x-sntgjvqjcxvubnyc] has joined #bitcoin-core-dev 14:17 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Ping timeout: 246 seconds] 14:17 -!- clarkmoo_ [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Remote host closed the connection] 14:18 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 14:18 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Client Quit] 14:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yhckrtjqclbgyjqj] has joined #bitcoin-core-dev 14:19 < bitcoin-git> [bitcoin] ryanofsky opened pull request #14635: developer-notes: allow lowerCamelCase (master...pr/camelow) https://github.com/bitcoin/bitcoin/pull/14635 14:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yhckrtjqclbgyjqj] has left #bitcoin-core-dev [] 14:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jhwhgthbhltzpmas] has joined #bitcoin-core-dev 14:26 < bitcoin-git> [bitcoin] ryanofsky opened pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636 14:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jhwhgthbhltzpmas] has left #bitcoin-core-dev [] 14:32 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 14:36 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Ping timeout: 252 seconds] 14:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 14:41 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 240 seconds] 14:43 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 14:44 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:57 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:14 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:16 -!- mrush [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 15:21 -!- mrush [~user@unaffiliated/mrush] has quit [Quit: leaving] 15:26 -!- mrush [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 15:27 -!- mrush [~user@unaffiliated/mrush] has quit [Client Quit] 15:28 -!- mrush [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 15:30 -!- mrush [~user@unaffiliated/mrush] has quit [Client Quit] 15:31 -!- mrush [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 15:32 -!- mrush [~user@unaffiliated/mrush] has quit [Client Quit] 15:33 -!- mrush [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 15:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:35 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 15:41 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:45 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 245 seconds] 15:46 -!- mrush [~user@unaffiliated/mrush] has left #bitcoin-core-dev [] 15:51 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 15:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 15:55 -!- lukedashjr is now known as luke-jr 15:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 16:09 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 16:10 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 16:10 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 16:16 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 16:22 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 16:22 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds] 16:24 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 16:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:26 -!- teardown [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 16:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 16:30 -!- wxss [~user@185.169.255.74] has quit [Remote host closed the connection] 16:35 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 16:38 -!- teardown [~user@unaffiliated/mrush] has quit [Quit: leaving] 16:44 -!- teardown [~user@unaffiliated/mrush] has joined #bitcoin-core-dev 16:48 -!- Tralfaz [~none@185.156.175.59] has quit [Quit: Leaving] 16:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 16:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:54 < meshcollider> maybe appveyor could call drahtbot in a build_failure webhook and then report success anyway 16:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 16:54 < meshcollider> then drahtbot could just comment or something 16:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:59 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 17:01 -!- Tralfaz [~none@185.156.175.59] has quit [Client Quit] 17:03 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:30 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:32 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 17:35 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 17:42 -!- molz [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 17:42 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:49 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 17:50 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Read error: Connection reset by peer] 17:50 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 17:54 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:55 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 17:55 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit] 17:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mijtbgpbjdfmulzj] has joined #bitcoin-core-dev 17:56 < bitcoin-git> [bitcoin] fanquake closed pull request #14463: Reduce usage of the platform dependent `unsigned int` type (master...20181011-rbf-nseq) https://github.com/bitcoin/bitcoin/pull/14463 17:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mijtbgpbjdfmulzj] has left #bitcoin-core-dev [] 17:58 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds] 18:01 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 18:15 < sipa> MarcoFalke: it seems that editing a comment indeed moves PRs up the "recently updated" queue 18:17 < gwillen> :-( 18:32 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 18:32 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Read error: Connection reset by peer] 18:32 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 18:34 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 18:35 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 18:38 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 18:49 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 18:51 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 18:51 -!- rhavar [uid237883@gateway/web/irccloud.com/x-wupwmywmdubtxalx] has joined #bitcoin-core-dev 18:52 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 19:13 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 19:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 19:23 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 272 seconds] 19:26 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 19:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 19:27 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Client Quit] 19:37 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 19:39 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Client Quit] 19:52 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 19:59 -!- ken2812221 [~ken281222@2001-b011-4010-1b2c-d89c-cd71-5e83-011c.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 20:06 -!- ken2812221 [~ken281222@2001-b011-4010-1b2c-d89c-cd71-5e83-011c.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds] 20:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 20:39 -!- robo7 [~robo7@unaffiliated/robo7] has joined #bitcoin-core-dev 21:07 -!- robo7_ [~robo7@unaffiliated/robo7] has joined #bitcoin-core-dev 21:07 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 21:08 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 21:08 -!- cubancorona2 [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 21:08 -!- schnerchi [~schnerchi@p3EE1DF82.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:09 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 21:09 -!- schnerch_ [~schnerchi@p3EE1DF82.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 21:10 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 268 seconds] 21:11 -!- robo7 [~robo7@unaffiliated/robo7] has quit [Ping timeout: 268 seconds] 21:11 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 268 seconds] 21:31 -!- bralyclo_ [~bralyclow@2600:1700:3d70:93b0:1b4:d1ad:2649:4f3b] has quit [Remote host closed the connection] 21:41 -!- josephni_ [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 21:42 -!- schnerch_ [~schnerchi@p3EE1D7AE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:43 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 21:45 -!- schnerchi [~schnerchi@p3EE1DF82.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 21:45 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 21:45 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 21:45 -!- josephni_ [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 21:45 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 21:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:53 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Ping timeout: 264 seconds] 21:53 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 21:58 -!- ken2812221 [~ken281222@2001-b011-4010-1b2c-d89c-cd71-5e83-011c.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 22:02 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Remote host closed the connection] 22:05 -!- josephnicholas [~josephnic@49.147.169.87] has joined #bitcoin-core-dev 22:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 22:15 -!- josephni_ [~josephnic@110.54.251.53] has joined #bitcoin-core-dev 22:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 22:17 -!- cubancorona2 [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 22:18 -!- josephnicholas [~josephnic@49.147.169.87] has quit [Ping timeout: 252 seconds] 22:26 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 22:36 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 22:38 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Quit: Leaving] 22:39 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 22:39 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host] 22:39 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 22:41 -!- rhavar [uid237883@gateway/web/irccloud.com/x-wupwmywmdubtxalx] has quit [Quit: Connection closed for inactivity] 22:42 -!- ken2812221 [~ken281222@2001-b011-4010-1b2c-d89c-cd71-5e83-011c.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds] 22:44 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@p2003005F6E1F7C80ECB9386700129B55.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 22:45 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 22:47 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 260 seconds] 22:47 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E1F7C97507A01E4516C5B06.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 23:02 -!- josephni_ [~josephnic@110.54.251.53] has quit [Remote host closed the connection] 23:05 -!- josephnicholas [~josephnic@110.54.251.53] has joined #bitcoin-core-dev 23:06 -!- josephnicholas [~josephnic@110.54.251.53] has quit [Remote host closed the connection] 23:07 -!- josephnicholas [~josephnic@110.54.251.53] has joined #bitcoin-core-dev 23:18 -!- josephnicholas [~josephnic@110.54.251.53] has quit [Remote host closed the connection] 23:18 -!- josephnicholas [~josephnic@110.54.251.53] has joined #bitcoin-core-dev 23:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 23:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 23:46 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 23:52 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev --- Log closed Fri Nov 02 00:00:21 2018