--- Log opened Fri Nov 16 00:00:23 2018
00:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
00:07 -!- M_D [~Mibbit@119.160.97.138] has joined #bitcoin-core-dev
00:10 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
00:18 -!- M_D [~Mibbit@119.160.97.138] has quit [Quit: Allah Hafiz]
00:21 -!- laptop__ [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has quit [Ping timeout: 240 seconds]
00:28 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
00:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
00:46 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 252 seconds]
00:49 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
00:49 -!- niiil [~shizzler@46.140.141.178] has quit [Read error: Connection reset by peer]
00:52 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
00:53 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
00:53 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
00:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
00:56 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
00:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds]
00:59 -!- lukedashjr is now known as luke-jr
00:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
01:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:10 -!- zhangzf [~zhangzf@1.202.169.235] has quit [Remote host closed the connection]
01:10 -!- zhangzf [~zhangzf@1.202.169.238] has joined #bitcoin-core-dev
01:12 -!- zhangzf [~zhangzf@1.202.169.238] has quit [Client Quit]
01:14 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has joined #bitcoin-core-dev
01:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
01:14 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
01:15 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has quit [Client Quit]
01:19 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
01:23 -!- promag [~promag@193.126.224.118] has joined #bitcoin-core-dev
01:33 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
01:45 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:46 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
01:46 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
01:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:49 -!- niiil [~shizzler@46.140.141.178] has quit [Read error: Connection reset by peer]
01:50 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev
01:50 -!- ctrlbreak_MAD [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev
01:50 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Client Quit]
01:50 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Read error: Connection reset by peer]
01:50 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
01:50 -!- drexl_ [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
01:52 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood]
01:52 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
01:52 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev
01:53 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer]
01:53 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Ping timeout: 268 seconds]
01:53 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Ping timeout: 268 seconds]
01:53 -!- ccook [~ccook@208.66.192.142] has quit [Ping timeout: 268 seconds]
01:53 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 268 seconds]
01:53 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:53 -!- wpaulino [~wpaulino@142.93.92.243] has joined #bitcoin-core-dev
01:53 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
01:53 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Client Quit]
01:53 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev
01:53 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 268 seconds]
01:53 -!- n1bor [~n1bor@185.9.34.66] has quit [Ping timeout: 268 seconds]
01:53 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has quit [Ping timeout: 268 seconds]
01:53 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 268 seconds]
01:54 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev
01:54 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
01:54 -!- n1bor [~n1bor@185.9.34.66] has joined #bitcoin-core-dev
01:55 -!- ccook [~ccook@208.66.192.142] has joined #bitcoin-core-dev
01:56 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
01:57 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:00 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
02:04 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev
02:04 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host]
02:04 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev
02:17 -!- _cryptosignal_me [~John@91.245.76.90] has joined #bitcoin-core-dev
02:28 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Ping timeout: 244 seconds]
02:33 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
02:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
02:44 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 244 seconds]
02:48 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
02:48 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:52 -!- _cryptosignal_me [~John@91.245.76.90] has quit [Ping timeout: 252 seconds]
02:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:55 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 252 seconds]
02:58 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
02:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:04 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 245 seconds]
03:08 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
03:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:11 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
03:11 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
03:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:18 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
03:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
03:35 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 264 seconds]
03:41 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
03:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:02 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 244 seconds]
04:04 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev
04:04 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Remote host closed the connection]
04:04 -!- niiil [~shizzler@46.140.141.178] has quit [Read error: Connection reset by peer]
04:09 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer]
04:09 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev
04:10 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539]
04:10 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
04:13 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Ping timeout: 240 seconds]
04:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:18 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev
04:22 -!- promag [~promag@193.126.224.118] has quit [Remote host closed the connection]
04:25 -!- _cryptodesktop_i [~John@91.245.76.90] has joined #bitcoin-core-dev
04:27 -!- ken2812221 [~ken281222@110.50.135.219] has joined #bitcoin-core-dev
04:35 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 252 seconds]
04:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
04:41 -!- JackH [~laptop@62.232.170.181] has quit [Ping timeout: 260 seconds]
04:46 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev
04:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
04:55 -!- _cryptodesktop_i [~John@91.245.76.90] has quit [Ping timeout: 268 seconds]
04:57 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
04:58 < provoostenator> Is there (or should there be) a document in the repo or elsewhere to describe best practices for replacing deprecated RPC calls? 
04:59 < provoostenator> E.g. someone asked me what to use instead of signrawtransaction (answer: signrawtransactionwithkey or signrawtransactionwithwallet).
05:01 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
05:02 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
05:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
05:26 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:32 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
05:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds]
05:36 -!- lukedashjr is now known as luke-jr
05:37 -!- _cryptodesktop_i [~John@91.245.76.90] has joined #bitcoin-core-dev
05:38 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has joined #bitcoin-core-dev
05:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
05:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
05:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
05:45 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
05:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:21 -!- bralyclow [~bralyclow@195.242.213.119] has quit []
06:23 -!- cltrbreak_MAD2 [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev
06:24 -!- _cryptodesktop_i [~John@91.245.76.90] has quit [Ping timeout: 240 seconds]
06:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:27 -!- ctrlbreak_MAD [~ctrlbreak@142.162.20.53] has quit [Ping timeout: 272 seconds]
06:30 -!- cltrbreak_MAD2 is now known as ctrlbreak
06:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
06:44 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
06:47 -!- brianhoffman [~brianhoff@pool-71-163-147-195.washdc.fios.verizon.net] has quit [Quit: brianhoffman]
06:50 -!- brianhoffman [~brianhoff@pool-71-163-147-195.washdc.fios.verizon.net] has joined #bitcoin-core-dev
06:58 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev
06:59 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has quit [Ping timeout: 252 seconds]
07:02 -!- kexkey [~kexkey@87.101.92.68] has joined #bitcoin-core-dev
07:06 < wumpus> for 'getinfo' we had a special message for a while, if you used the old RPC call, it'd give an error message to use the new ones, I think that would be good practice for other removed RPC calls as well at least for one major release
07:08 < instagibbs> Is there a great cost to just leaving around a disabled message indefinitely? No supporting code infra etc.
07:08 < instagibbs> Doesn't even have to be verbose, just "disabled, see release notes version blah" or something
07:15 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
07:19 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has joined #bitcoin-core-dev
07:35 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Ping timeout: 252 seconds]
07:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
07:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
07:44 -!- wahaha001 [~wahaha007@124.64.18.109] has joined #bitcoin-core-dev
07:45 -!- wahaha001 [~wahaha007@124.64.18.109] has quit [Client Quit]
07:45 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
07:45 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
07:45 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:45 -!- wahaha001 [~wahaha007@124.64.18.109] has joined #bitcoin-core-dev
07:45 -!- riemann_ [~riemann@217.96.172.173.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
07:46 -!- wahaha001 [~wahaha007@124.64.18.109] has quit [Client Quit]
07:48 -!- riemann [~riemann@217.96.137.240.ipv4.supernova.orange.pl] has quit [Ping timeout: 245 seconds]
07:54 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has quit [Quit: Snoozing.]
07:55 -!- zivl_ [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
07:56 -!- zivl [~zivl@unaffiliated/zivl] has quit [Ping timeout: 264 seconds]
07:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
08:00 -!- dviola [~diego@186.222.90.83] has joined #bitcoin-core-dev
08:00 -!- dviola [~diego@186.222.90.83] has quit [Changing host]
08:00 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
08:04 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:04 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer]
08:05 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev
08:15 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 245 seconds]
08:18 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has quit [Quit: This computer has gone to sleep]
08:18 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has quit [Remote host closed the connection]
08:18 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:20 -!- ken2812221 [~ken281222@110.50.135.219] has quit [Ping timeout: 244 seconds]
08:21 -!- Sibi_ [5b40d684@gateway/web/freenode/ip.91.64.214.132] has joined #bitcoin-core-dev
08:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kccgluexuuvnmoqm] has joined #bitcoin-core-dev
08:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/384967f311b4...35739976c1d9
08:22 < bitcoin-git> bitcoin/master 07e286d Carl Dong: Improve scripted-diff developer docs...
08:22 < bitcoin-git> bitcoin/master 3573997 MarcoFalke: Merge #14731: doc: Improve scripted-diff developer docs...
08:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kccgluexuuvnmoqm] has left #bitcoin-core-dev []
08:22 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hxtsbtaeottcgury] has joined #bitcoin-core-dev
08:23 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14731: doc: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
08:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hxtsbtaeottcgury] has left #bitcoin-core-dev []
08:25 -!- Sibi_ [5b40d684@gateway/web/freenode/ip.91.64.214.132] has quit [Client Quit]
08:26 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has quit [Client Quit]
08:27 -!- lnostdal [~lnostdal@151.251.245.183] has joined #bitcoin-core-dev
08:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
08:34 -!- rhavar [uid237883@gateway/web/irccloud.com/x-jereaanwbrirlsdy] has joined #bitcoin-core-dev
08:35 -!- lnostdal [~lnostdal@151.251.245.183] has quit [Ping timeout: 268 seconds]
08:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
08:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:44 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has quit [Quit: Leaving]
08:45 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
08:52 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
09:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
09:02 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds]
09:15 < phantomcircuit> anybody else had issues getting -pg to work?
09:15 < phantomcircuit> i get a gmon.out file but gprof analysis is empty
09:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:26 -!- JackH [~laptop@62.232.170.181] has quit [Quit: Leaving]
09:26 < phantomcircuit> apparently gcc 6 doesn't work with pie and pg
09:26 < phantomcircuit> sad
09:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
09:35 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
09:35 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
09:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:38 -!- reardencode [~reardenco@hank.reardencode.com] has quit [Quit: leaving]
09:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
09:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:47 -!- Krellan [~Krellan@2601:640:4000:a876:6d3d:b601:8e82:37ed] has joined #bitcoin-core-dev
10:04 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
10:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
10:25 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:30 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has joined #bitcoin-core-dev
10:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
10:38 < zallarak> Is there any reviewer here that is willing to provide feedback on a PR that adds a flag to bitcoind?
10:39 < sipa> zallarak: what PR?
10:41 < zallarak> sipa: https://github.com/bitcoin/bitcoin/pull/14733
10:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
10:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbzvuxolqslkfhlg] has joined #bitcoin-core-dev
10:43 < bitcoin-git> [bitcoin] kristapsk opened pull request #14738: Fix running wallet_listtransactions.py individually through test_runner.py (master...listtransactions) https://github.com/bitcoin/bitcoin/pull/14738
10:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbzvuxolqslkfhlg] has left #bitcoin-core-dev []
10:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
10:46 -!- Krellan [~Krellan@2601:640:4000:a876:6d3d:b601:8e82:37ed] has quit [Remote host closed the connection]
10:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:51 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
10:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
10:52 < zallarak> Am I clear in understanding that all new code should be in snake case, even if surrounding code is camel case?
10:53 < sipa> zallarak: correct (for variable names)
10:53 < zallarak> Thank you, updating my PR for that.
10:54 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
10:57 < sipa> sorry, i'm going to be 10-15 minutes late for the wallet meeting
11:00 < instagibbs> #timeforwalletmeeting
11:00 < instagibbs> or we can wait until pieter is here
11:00 < provoostenator> I can wait 15 mins...
11:00 < gwillen> :+1:
11:00 < instagibbs> ack
11:01 < meshcollider> I probably won't be able to be here the whole time, leaving in around half an hour
11:01 < achow101> wallet meeting?
11:03 < meshcollider> achow101: See messages above :p
11:14 < sipa> back.
11:15 < sipa> #startmeeting
11:15 < lightningbot> Meeting started Fri Nov 16 19:15:03 2018 UTC.  The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:15 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:15 < sipa> topics?
11:16 < provoostenator> Not really, I need to catch up on review and testing.
11:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:16 < instagibbs> #14565 needs rebase/more review
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
11:16 < meshcollider> Hi
11:16 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
11:17 < sipa> yeah, i need to get back to that
11:17 < meshcollider> Yeah I need to rebase #14491 on it to
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
11:17 < sipa> and i need to add more tests
11:17 < sipa> and address ryanofsky_'s comments
11:18 < instagibbs> gwillen, any update on psbt signing stuff? 
11:19 < provoostenator> For those reading (the logs): ##hwi is a fun place for those interesting in _hardware_ wallet support, and there's some overlap with this effort.
11:19 < sipa> a question i had, how do we progress with things like #14481 ?
11:19 < gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
11:19 < gwillen> instagibbs: no update, other than I think https://github.com/bitcoin/bitcoin/pull/14588 getting in happened since the last time we had this meeting 
11:20 < sipa> because it seems to me that using descriptors instead of lists of keys/redeemscript/witnessnessscript in sign* RPCs will be a much better user experience
11:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:20 < gwillen> I still owe another PR of PSBT related refactoring, and I have a working demo of offline signing UI if anybody wants to play with it (it's the same one I had around this time last week already)
11:20 < provoostenator> How would listunspent return descriptors?
11:20 < sipa> provoostenator: #14477
11:21 < sipa> already implemented
11:21 < meshcollider> provoostenator: accept, not return
11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
11:21 < sipa> meshcollider: no, return
11:21 < instagibbs> the stuff you need to pass to other calls
11:21 < provoostenator> Ah ok, by converting scripts, that makes sense.
11:21 < meshcollider> Oh right
11:21 < provoostenator> And ultimately if the wallet contains descriptors, then it would just take that descriptor and an array of indexes?
11:21 < sipa> provoostenator: sure, but i'm talking about right now
11:22 < sipa> we can also add descriptor responses to addmultisig etc
11:22 < provoostenator> I like the idea of using descriptors for both inputs and outputs wherever feasible.
11:22 < instagibbs> basically we're taking advantage of descriptors pre-descriptor-record based wallets
11:22 < meshcollider> After I've finished reviewing the last few wallet PRs adding more descriptor support is what I really want to work on anyway
11:23 < sipa> that would mean adding descriptor support to signrawtransaction etc
11:23 < instagibbs> is there a list of places to be added?
11:23 < instagibbs> or is that an action item
11:23 < sipa> that's a good idea, we should make such a list
11:23 < sipa> i'll open an issue
11:23 < provoostenator> Yes please
11:23 < meshcollider> +1
11:24 < sipa> the question is then: do we go for that, or do we also try to keep the pre-descriptor approach functional?
11:24 < sipa> (which needs things like 14481, because listunspent + signrawtransactionwithkey is pretty much broken right now)
11:24 < meshcollider> I feel like it would have to be deprecated like accounts were
11:25 < sipa> i don't think there is a strong need to actually remove it
11:25 < meshcollider> 14481 is only broken for P2SH-P2WSH I think
11:25 < sipa> it's more a question of do we keep updating it with new stuff
11:26 < meshcollider> Ah yep, well if we're keeping the old stuff it at least needs to be maintained to a working level right
11:26 < meshcollider> But not new features no, IMO
11:27 < sipa> ok, fair
11:27 < ryanofsky_> 14481 also adds a test for signrawtransaction, though that could be added separately
11:27 -!- mistergold [~mistergol@185.37.26.125] has joined #bitcoin-core-dev
11:28 < sipa> ryanofsky_: ah, good
11:28 < meshcollider> See also #11708
11:28 < gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
11:28 < meshcollider> Which was the precursor to 14481
11:29 < meshcollider> Which it sounds like is actually a better approach to resurrect after all
11:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:33 < sipa> another topic: #13932
11:33 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
11:33 < sipa> achow101: when rebase?
11:33 < achow101> later today
11:34 < sipa> i was thinking about a processpsbtwithdescriptor RPC, and was wondering if it should be integrated with utxoupdatepsbt
11:34 < meshcollider> Ok I have to go now, I'll catch up on the rest later today
11:34 < sipa> as we have all the pieces in place now
11:35 < sipa> or should we keep them separate, where you'd first run utxoupdatepsbt, then processpsbtwithdescriptor to fill in scripts, and then sign (which could be done by any signer, or with processpsbtwithdescriptor at once)
11:35 < instagibbs> sipa, would that be a "stateless" call?
11:35 < sipa> utxoupdatepsbt is not stateless (it looks at the UTXO set), but processpsbtwithdescriptor would be
11:36 < instagibbs> was asking about latter
11:36 < instagibbs> so it would involve passing in xprv-containing descriptors when signing required
11:37 < sipa> i was thinking you could give it either public descriptors, private descriptors, or private keys separately
11:39 < achow101> i think it should stay separate
11:40 < sipa> i have a slight preference for that as well, but it's less convenient
11:41 < achow101> but do you really need a descriptor to process a psbt? what if we just made it a simple signer?
11:41 < achow101> the descriptor is only needed for finalizing
11:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
11:42 < achow101> i guess you could also fill in keys from a descriptor
11:42 < sipa> achow101: to fill in witnessscript/redeemscripts/keys
11:42 < sipa> so yes
11:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
11:45 < provoostenator> Just a key could be a handy shortcut for some descriptors, but perhaps the base case should be a descriptor.
11:46 < sipa> provoostenator: just a key is for the case where you have an xpub-based descriptor, and a private key separately
11:46 < provoostenator> For the unambiguous case if you have pwpk(blah xpub blah) then if you pass in an xpriv that's clear.
11:46 < provoostenator> Right
11:46 < provoostenator> But that would just be a shortcut for pwpk(blah xpriv blah)
11:46 < sipa> or when the PSBT already has all script fields, and all you have is a private key
11:47 < sipa> i'll add them to the issue i'm opening
11:47 < sipa> anything else we want to discuss?
11:51 -!- oneark [uid254801@gateway/web/irccloud.com/x-ugkmcmrjrwictzsi] has quit [Quit: Connection closed for inactivity]
11:54 -!- drexl_ is now known as drexl
11:54 < provoostenator> Nope
11:54 < sipa> as decreed by provoostenator:
11:54 < sipa> #endmeeting
11:54 < lightningbot> Meeting ended Fri Nov 16 19:54:56 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:54 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-16-19.15.html
11:54 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-16-19.15.txt
11:54 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-16-19.15.log.html
11:55 < sipa> opened https://github.com/bitcoin/bitcoin/issues/14739
12:07 < zallarak> meshcollider: I updated per your feedback, and the build is passing. Any other thoughts / comments welcome. I am thinking about a new way of testing, that is why I worked on this.
12:10 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
12:10 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:17 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:17 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
12:24 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:24 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:26 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:26 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:29 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:29 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:29 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:39 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:39 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:40 -!- wpaulino [~wpaulino@142.93.92.243] has quit [Changing host]
12:40 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has joined #bitcoin-core-dev
12:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
12:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:42 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev
12:42 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:42 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:44 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:47 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:47 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
12:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
13:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:08 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Ping timeout: 252 seconds]
13:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:12 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:12 < zallarak> MarcoFalke: friendly ping if you have any thoughts on the revised PR I submitted (https://github.com/bitcoin/bitcoin/pull/14733)
13:13 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev
13:16 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
13:16 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
13:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
13:18 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
13:18 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
13:18 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:19 -!- satwo [~textual@2600:1700:3691:2a30:d961:4b97:14e8:2b9a] has joined #bitcoin-core-dev
13:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
13:21 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
13:21 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
13:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
13:23 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
13:23 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
13:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:28 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has quit [Ping timeout: 256 seconds]
13:35 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
13:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
13:49 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
13:50 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
13:59 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has joined #bitcoin-core-dev
14:07 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:24 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ewpyfwzqvareulyy] has joined #bitcoin-core-dev
14:37 < bitcoin-git> [bitcoin] sp4ke opened pull request #14740: Update `rpcbind` doc to match the manpage closes #9272 (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
14:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ewpyfwzqvareulyy] has left #bitcoin-core-dev []
14:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
14:44 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
14:45 -!- mistergo1d [~mistergol@37.19.109.41] has joined #bitcoin-core-dev
14:48 -!- mistergold [~mistergol@185.37.26.125] has quit [Ping timeout: 245 seconds]
14:49 -!- mck [590e21bc@gateway/web/freenode/ip.89.14.33.188] has joined #bitcoin-core-dev
14:49 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Read error: Connection reset by peer]
14:51 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev
14:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
14:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
15:04 -!- mistergo1d [~mistergol@37.19.109.41] has quit [Quit: leaving]
15:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:05 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has quit [Quit: Page closed]
15:06 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:06 -!- mck is now known as mck_
15:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:19 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
15:20 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
15:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
15:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:32 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds]
15:38 -!- hex17or [~hex17or@2a02:8071:ba7:d300:8854:d2ef:22ed:7b7f] has joined #bitcoin-core-dev
15:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
15:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
15:43 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:48 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in]
15:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:53 -!- hex17or [~hex17or@2a02:8071:ba7:d300:8854:d2ef:22ed:7b7f] has quit [Ping timeout: 252 seconds]
15:54 -!- booyah_ is now known as booyah
16:08 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:09 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
16:09 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
16:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
16:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:14 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
16:14 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
16:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:24 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
16:24 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
16:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:27 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
16:31 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 260 seconds]
16:38 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
16:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
16:42 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
16:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
17:01 -!- harrymm [~harrymm@69.161.195.103] has quit [Remote host closed the connection]
17:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
17:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:22 -!- Dizzle [~Dizzle@unaffiliated/dizzle] has joined #bitcoin-core-dev
17:29 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:30 -!- mck_ [590e21bc@gateway/web/freenode/ip.89.14.33.188] has quit [Quit: Page closed]
17:30 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
17:34 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]
17:35 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
17:36 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:53 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
17:56 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
18:00 -!- zivl_ [~zivl@unaffiliated/zivl] has quit [Ping timeout: 264 seconds]
18:01 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dexkkxuzjdvoebzv] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] dongcarl opened pull request #14741: Indicate -rpcauth option password hashing alg (master...2018-11-improve-rpcauth-help) https://github.com/bitcoin/bitcoin/pull/14741
18:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dexkkxuzjdvoebzv] has left #bitcoin-core-dev []
18:03 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
18:08 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds]
18:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
18:08 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
18:12 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
18:18 < meshcollider> Ooh GitHub now has force-push notifications
18:18 < meshcollider> That's useful
18:19 < meshcollider> See e.g. #14733
18:19 < gribble> https://github.com/bitcoin/bitcoin/issues/14733 | p2p: allow p2ptimeout to be configurable, speed up slow test by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub
18:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
18:53 -!- _cryptosignal_me [~John@91.245.76.90] has joined #bitcoin-core-dev
19:01 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]
19:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:15 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
19:19 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:22 -!- henry_ma [805a091a@gateway/web/freenode/ip.128.90.9.26] has joined #bitcoin-core-dev
19:23 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
19:26 -!- henry_ma [805a091a@gateway/web/freenode/ip.128.90.9.26] has quit [Ping timeout: 256 seconds]
19:27 -!- _cryptosignal_me [~John@91.245.76.90] has quit [Ping timeout: 244 seconds]
19:37 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:38 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
19:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
19:43 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
19:46 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:51 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
19:54 -!- jarthur [~jarthur@2605:6000:1019:41ab:b922:9704:18f9:1c94] has joined #bitcoin-core-dev
19:59 -!- ryanofsky_ is now known as ryanofsky
20:01 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:06 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
20:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:13 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
20:17 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:18 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
20:22 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
20:22 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
20:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds]
20:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
20:45 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
20:49 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds]
20:50 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
20:54 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
20:55 -!- michaelfolkson [~textual@host86-131-209-198.range86-131.btcentralplus.com] has joined #bitcoin-core-dev
20:55 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
21:02 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has joined #bitcoin-core-dev
21:05 -!- michaelfolkson [~textual@host86-131-209-198.range86-131.btcentralplus.com] has quit [Quit: Sleep mode]
21:06 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has quit [Remote host closed the connection]
21:27 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:32 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
21:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
21:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
21:59 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:00 -!- keer4n [~keer4n@132.178.207.4] has quit [Read error: Connection reset by peer]
22:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:14 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
22:15 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
22:16 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
22:23 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:26 -!- shesek [~shesek@109.253.214.56] has joined #bitcoin-core-dev
22:26 -!- shesek [~shesek@109.253.214.56] has quit [Changing host]
22:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
22:35 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
22:36 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
22:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
22:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
22:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
22:42 < dongcarl> Any reason why `bitcoin/share/rpcauth/rpcauth.py` generates a 16 byte salt instead of a 32 byte salt? I believe RFC 2104 recommends the key length to be larger than or equal to the hash output length: https://tools.ietf.org/html/rfc2104#section-3
22:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
22:44 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:46 < dongcarl> It also seems that the format string will only output one character if the randomly generated byte is below 0x10, which I don't think is the expected behavior...
22:47 < sipa> dongcarl: you don't need an HMAC here
22:48 < sipa> or ratherx you don't actually need a MAC here
22:48 < sipa> just a hash with some protection against dictionaries
22:48 < sipa> so making the salt large enough to make a dictionary attack infeasible is enough
22:48 < sipa> 64 bits probably suffices
22:50 < dongcarl> sipa: right, but it wouldn't hurt to have a few more bits of entropy and conform to the spec?
22:50 < dongcarl> Also with the format string bug we have less than 64 bits at times
22:50 < sipa> dongcarl: link to code?
22:51 < dongcarl> sipa: https://github.com/bitcoin/bitcoin/blob/master/share/rpcauth/rpcauth.py#L18
22:51 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
22:52 < dongcarl> That format string will only output 1 character if the r in salt_sequence is less than 0x10
22:52 < sipa> nice catch
22:52 < sipa> but it's not a problem; the set of encoded salts still has 128 bits of entropy
22:53 < sipa> oh, no!
22:53 < sipa> slightly less
22:53 < dongcarl> Right
22:53 < sipa> there are collisions
22:53 < dongcarl> I'll PR to fix it to make it according to normal expectations
22:54 < sipa> dongcarl: i don't think "comforming to the spec" matters here; the spec is to satsify the requirements of a secure MAaC; we don't need a secure MAC
22:54 < sipa> but yes, please fix the formatting issue
22:54 < dongcarl> Okay gotcha
22:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
22:57 -!- Krellan [~Krellan@2601:640:4000:a876:28aa:470d:5184:ca88] has joined #bitcoin-core-dev
23:10 -!- satwo [~textual@2600:1700:3691:2a30:d961:4b97:14e8:2b9a] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:13 < jarthur> Wait, why slightly less than 128? If r is more than 0x10, don't we get more than 1 character?
23:17 < sipa> the number of characters doesn't matter
23:17 < sipa> the number of combinations matters
23:19 < sipa> but given that there are distinct inputs that map to the same salt string (e.g. (0x1, 0x23, 0x45) and (0x12, 0x34, 0x5) both map to 12345)
23:19 < jarthur> Makes sense now. Thanks :)
23:24 -!- satwo [~textual@2600:1700:3691:2a30:2c18:f42:cbcc:ae93] has joined #bitcoin-core-dev
23:24 -!- satwo [~textual@2600:1700:3691:2a30:2c18:f42:cbcc:ae93] has quit [Client Quit]
23:32 < jarthur> The format line could just be replaced by using binascii.hexlify, that way we'll get two-digit hexes as ASCII bytes and won't need the later UTF-8 encodes. Would just need to use salt.decode('ascii') in the printed string.
23:32 < dongcarl> jarthur: I just did os.random(16).hex()
23:32 < dongcarl> works fine
23:32 < jarthur> I like that even better
23:32 < jarthur> nice
23:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lbyqsczuoiyzjdes] has joined #bitcoin-core-dev
23:34 < bitcoin-git> [bitcoin] dongcarl opened pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
23:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lbyqsczuoiyzjdes] has left #bitcoin-core-dev []
23:41 < sipa> dongcarl: do we require python 3.6?
23:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
23:42 < dongcarl> sipa: I think we require python at least
23:42 < dongcarl> python3
23:43 < jarthur> bytes.hex was introduced in Python 3.5
23:43 < dongcarl> we require python 3.4 for tests according to https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md
23:44 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
23:44 < dongcarl> jarthur: link?
23:44 < jarthur> https://docs.python.org/3/library/stdtypes.html#bytes.hex
23:45 < dongcarl> Ooof
23:45 < sipa> because python 3.6 has the "secret" module
23:46 < sipa> for generating cryptographic strength randomness
23:47 < luke-jr> RHEL seems to be at Python 3.4 (w/ EPEL)
23:50 < dongcarl> Okay guess I'll conform to python 3.4...
23:50 < dongcarl> :-(
23:51  * luke-jr guesses he should probably reinstall Py3.4 for this purpose
23:51 < jarthur> Too bad. Python 3.6 was one of the best Python releases to date, features-wise.
23:52 < dongcarl> Yeah I think 3.6 was optional types as well?
23:52 < luke-jr> jarthur: we'll get there eventually
23:52 < luke-jr> it tends to be RHEL holding things back, and RHEL 8 is supposedly due this year
23:53 < luke-jr> with 3.6 apparently: https://developers.redhat.com/blog/2018/11/14/python-in-rhel-8/
23:54 < Dizzle> Cool, I'm not worried, just wishful
23:54 < luke-jr> although Debian stable is only 3.5
23:54 < luke-jr> and next not due until 2019
23:55 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E1F7C34F954F7C7C32D55E7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
23:57 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
23:59 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@p2003005F6E1F7C3680CF4C900DB8AD43.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
--- Log closed Sat Nov 17 00:00:23 2018