--- Log opened Tue Nov 20 00:00:26 2018
00:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
00:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:08 < sipa> gwillen: gmaxwell suggests we may want to include it in 0.17.1
00:08 < sipa> and no, not aimed at you (but feel to comment whether you think that's a good idea)
00:09 < gmaxwell> yeah, feel free to say if you think it should/shouldn't be.
00:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
00:20 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
00:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
00:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
00:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
00:55 < wumpus> meshcollider: I'm now
00:58 < wumpus> provoostenator: that really shouldn't have been merged before being sure about it, linters cause enough issues without feeding them false input
00:59 < wumpus> oh it doesn't change the linter config, just removes a header too much causing compile issues
01:00 < wumpus> why is fstream only needed on some platforms?
01:01 < wumpus> oh I see, it sometimes gets included through other headers
01:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uxehhwqkgxusercq] has joined #bitcoin-core-dev
01:07 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/09f1d7fe7243...1b99d153d071
01:07 < bitcoin-git> bitcoin/master e816b34 Karl-Johan Alm: revert removal of fstream.hpp header in fs.h...
01:07 < bitcoin-git> bitcoin/master 1b99d15 Wladimir J. van der Laan: Merge #14768: revert removal of fstream.hpp header in fs.h...
01:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uxehhwqkgxusercq] has left #bitcoin-core-dev []
01:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rvlbktmvhkjazrzp] has joined #bitcoin-core-dev
01:08 < bitcoin-git> [bitcoin] laanwj closed pull request #14768: revert removal of fstream.hpp header in fs.h (master...restore-fs-h-include-boost-fs-fstream) https://github.com/bitcoin/bitcoin/pull/14768
01:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rvlbktmvhkjazrzp] has left #bitcoin-core-dev []
01:14 < wumpus> ouch, travis being down and it not being noticed is quite dangerous
01:20 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:20 < wumpus> luckily it was only a header issue then
01:24 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
01:28 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
01:33 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
01:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
01:43 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]
01:45 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
01:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:12 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
02:16 < luke-jr> if Travis being down is dangerous, the real danger is the conclusion that things are being merged without real review :x
02:18 < luke-jr> ie, it's being used as more than just a mere convenience
02:22 -!- michaelfolkson [~textual@82.132.187.12] has joined #bitcoin-core-dev
02:28 < wumpus> nah not fatally dangerous, the PR didn't go without review
02:28 < promag> is there a way to make a long RPC call? like server side sleep?
02:28 < wumpus> promag: yes, RPC calls can sleep as long as they want, although the client has to make sure they don't time out
02:29 < promag> I thought we were doing blind merges :D
02:29 < wumpus> it does hold up a RPC thread but there's other calls that can take a long time for example the utxo stats one
02:29 < promag> wumpus: for testing I don't think we have?
02:29 < wumpus> I think the mining RPC does long-polling
02:30 < wumpus> and there's RPCs to wait for next block and such?
02:30 < promag> ah!
02:30 < promag> thank you sir
02:30 < wumpus> np
02:40 < promag> do we have tests to concurrently call RPC to the same node?
02:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
02:53 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:54 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:01 -!- cryptoboy [~cryptoboy@78.30.30.28] has joined #bitcoin-core-dev
03:09 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:26 -!- cryptoboy [~cryptoboy@78.30.30.28] has quit [Ping timeout: 268 seconds]
03:27 -!- cryptoboy [~cryptoboy@78.30.20.233] has joined #bitcoin-core-dev
03:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
03:46 -!- speedChicken_ [~speedChic@121.144.192.16] has joined #bitcoin-core-dev
03:46 -!- speedChicken_ [~speedChic@121.144.192.16] has quit [Remote host closed the connection]
03:48 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
03:49 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
03:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:53 -!- michaelfolkson [~textual@82.132.187.12] has quit [Remote host closed the connection]
03:53 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:53 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:57 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
04:05 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
04:14 < wumpus> promag: I don't think so
04:26 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...]
04:42 -!- zhangzf [~zhangzf@223.72.71.115] has joined #bitcoin-core-dev
04:42 -!- zhangzf [~zhangzf@223.72.71.115] has quit [Client Quit]
04:51 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Quit: rex4539]
05:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
05:10 -!- rhavar [uid237883@gateway/web/irccloud.com/x-jereaanwbrirlsdy] has quit [Quit: Connection closed for inactivity]
05:14 < provoostenator> One reason we didn't notice Travis missing is that there's still a green checkbox from the other tools. That's strange, shouldn't Github show an error if any integration is missing / fails?
05:17 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds]
05:21 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
05:33 < wumpus> normally yes
05:39 < Varunram> only if it misses / fails though, not if it doesn't boot up the tests in the first place
05:55 < wumpus> yes, that sound plausible
06:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ppvlsunnimayjqcq] has joined #bitcoin-core-dev
06:16 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b99d153d071...afa506f6ebeb
06:16 < bitcoin-git> bitcoin/master c456fbd Russell Yanofsky: Refactor: Move m_db pointers into BerkeleyDatabase...
06:16 < bitcoin-git> bitcoin/master 15c93f0 Chun Kuan Lee: wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory.
06:16 < bitcoin-git> bitcoin/master 5912031 Chun Kuan Lee: wallet: Create IsDatabaseLoaded function
06:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ppvlsunnimayjqcq] has left #bitcoin-core-dev []
06:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cumzcnlkzqgqfsrd] has joined #bitcoin-core-dev
06:17 < bitcoin-git> [bitcoin] laanwj closed pull request #14552: wallet: detecting duplicate wallet by comparing the db filename. (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
06:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cumzcnlkzqgqfsrd] has left #bitcoin-core-dev []
06:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:29 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 252 seconds]
06:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
06:46 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
06:50 -!- cryptoboy [~cryptoboy@78.30.20.233] has quit [Ping timeout: 264 seconds]
06:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ghwoxqrvzyowsicg] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] scravy opened pull request #14770: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
06:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ghwoxqrvzyowsicg] has left #bitcoin-core-dev []
06:51 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
06:53 -!- cryptoboy [~cryptoboy@78.30.19.239] has joined #bitcoin-core-dev
07:07 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:12 < promag> wumpus: I was waiting for https://github.com/bitcoin/bitcoin/pull/14552#pullrequestreview-176535062
07:14 < wumpus> promag: huh didn't see that, you had already utACKed it
07:14 < promag> yeah, that was a previous commit
07:15 < wumpus> *sigh* ok
07:15 < promag> how can I cancel an utACK?
07:15 < wumpus> edit->delete it
07:15 < promag> anyway, ken2812221_ ^
07:15 -!- LGzr [0550d75e@gateway/web/freenode/ip.5.80.215.94] has joined #bitcoin-core-dev
07:16 < wumpus> I can revert it if that's really necessary
07:16 < promag> I don't think so
07:16 < promag> the mutex is for g_dbenvs, but there is no mutex for WalletEnvironment
07:17 < promag> so I wonder if it should use the same
07:23 < LGzr> Hola, all. I've a question about the p2sh example at https://bitcoin.org/en/developer-examples#p2sh-multisig; is there a more appropriate forum than here? (Question is: what purpose it serves that createmultisig uses public key for one, and addresses for the others)
07:26 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
07:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 244 seconds]
07:33 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:40 -!- mr_paz [~mr_paz@84.39.112.84] has joined #bitcoin-core-dev
07:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
07:47 < wumpus> LGzr: I think https://bitcoin.stackexchange.com/ is the best place to ask such things
07:50 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
07:50 < LGzr> Wumpus - thanks!
07:51 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
07:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
07:54 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds]
07:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:09 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
08:19 -!- dqx [~dqx@unaffiliated/dqx] has quit [Quit: .]
08:20 < achow101> meshcollider: can you rebase #14491
08:20 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
08:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:32 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has joined #bitcoin-core-dev
08:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
08:43 -!- promag [~promag@83.223.250.232] has quit [Remote host closed the connection]
08:46 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
08:55 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sscouurkwwusuxie] has joined #bitcoin-core-dev
09:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14755: Remove redundant readme info in /doc (master...issue-14639) https://github.com/bitcoin/bitcoin/pull/14755
09:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sscouurkwwusuxie] has left #bitcoin-core-dev []
09:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
09:10 -!- gelmutshmidt [~gelmuth@188.113.27.168] has quit [Remote host closed the connection]
09:11 -!- gelmutshmidt [~gelmuth@188.113.27.168] has joined #bitcoin-core-dev
09:16 -!- IRC-Source_71688 [550a70d1@gateway/web/cgi-irc/kiwiirc.com/ip.85.10.112.209] has joined #bitcoin-core-dev
09:18 -!- IRC-Source_71688 [550a70d1@gateway/web/cgi-irc/kiwiirc.com/ip.85.10.112.209] has quit [Client Quit]
09:19 -!- kexkey [~kexkey@173.209.63.134] has joined #bitcoin-core-dev
09:20 -!- kelt [~kelt@166.137.105.158] has quit [Ping timeout: 252 seconds]
09:21 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has quit [Quit: Sleep mode]
09:22 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has joined #bitcoin-core-dev
09:22 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has quit [Client Quit]
09:23 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:31 -!- cryptoboy [~cryptoboy@78.30.19.239] has quit [Ping timeout: 272 seconds]
09:31 -!- kelt [~kelt@166.137.105.158] has joined #bitcoin-core-dev
09:31 -!- cryptoboy [~cryptoboy@78.30.21.50] has joined #bitcoin-core-dev
09:32 -!- promag [~promag@83.223.234.53] has joined #bitcoin-core-dev
09:37 < provoostenator> I notice that dumpwallet (on a fresh wallet) contains two sections, I'm confused why: 
09:37 < provoostenator> cV6... 2018-11-20T17:23:30Z reserve=1 # addr=tb1q... hdkeypath=m/0'/0'/11'
09:37 < provoostenator> 001433... 0 script=1 # addr=2Ms...
09:39 < sipa> the script is the p2sh wrapper of that address, i suppose
09:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
09:42 < provoostenator> Ah hence they start with 0014? So the first section is for legacy & native segwit, the second for p2sh wrapped segwit? But why don't the p2sh entries show an hdkeypath?
09:44 < sipa> they're not keys
09:45 < sipa> in the current wallet design, you don't import addresses
09:45 < sipa> you import keys and scripts, and it figures out on its own what that implies for what is yours
09:45 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:45 < sipa> in practice for the P2SH-P2WPKH address derived from a wallet key, IsMine works as follows:
09:45 < sipa> * it sees a P2SH address, so it looks up the script for that scripthash
09:46 < sipa> * it notices the script is a P2WPKH script, so it recurses by replacing it with the corresponding P2PKH script
09:46 < sipa> * it notices it's a P2PKH script, so it looks up the pubkeyhash
09:46 < sipa> * it finds the private key for it, so it's considered spendable
09:47 < sipa> but the only thing in that whole sequence that has a keypath is the key at the end
09:48 -!- ddd [b9870274@gateway/web/freenode/ip.185.135.2.116] has joined #bitcoin-core-dev
09:49 -!- zallarak [450e785b@gateway/web/freenode/ip.69.14.120.91] has joined #bitcoin-core-dev
09:49 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
09:50 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 245 seconds]
09:50 -!- ddd [b9870274@gateway/web/freenode/ip.185.135.2.116] has quit [Client Quit]
09:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-apscfgrctlaamzvx] has joined #bitcoin-core-dev
09:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afa506f6ebeb...6b90a2a0e065
09:51 < bitcoin-git> bitcoin/master feeef7d Julian Fleischer: Do not specify sudo in .travis...
09:51 < bitcoin-git> bitcoin/master 6b90a2a Wladimir J. van der Laan: Merge #14770: travis: Do not specify sudo in .travis...
09:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-apscfgrctlaamzvx] has left #bitcoin-core-dev []
09:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pjebwilfrledmthn] has joined #bitcoin-core-dev
09:52 < bitcoin-git> [bitcoin] laanwj closed pull request #14770: travis: Do not specify sudo in .travis (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14770
09:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pjebwilfrledmthn] has left #bitcoin-core-dev []
09:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:54 -!- oneark [uid254801@gateway/web/irccloud.com/x-xhfeucbfcvqlzcwx] has quit [Quit: Connection closed for inactivity]
09:57 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev
09:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
09:58 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:59 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
10:03 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]
10:14 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:15 < provoostenator> sipa: thanks. Perhaps no point in cleaning up the current wallet, but dumpwallet could add comments to the script entries like "p2sh-segwit script for hdkeypath=m/0..."?
10:16 < sipa> provoostenator: or we could dump the inferred descriptor for each entry :)
10:16 -!- promag [~promag@83.223.234.53] has quit [Read error: Connection reset by peer]
10:19 < provoostenator> That makes sense on top of #11803, but more for the key entries than for the script entries.
10:19 < gribble> https://github.com/bitcoin/bitcoin/issues/11803 | Bugfix: RPC/Wallet: Include HD key metadata in dumpwallet by luke-jr · Pull Request #11803 · bitcoin/bitcoin · GitHub
10:19 < sipa> provoostenator: no, that makes no sense
10:19 < sipa> keys are keys, not addresses
10:19 < provoostenator> But they're supposed to be interpreted as combo() descriptors
10:19 < sipa> they participate in all scripts that use them
10:19 < provoostenator> Depending on wallet age
10:19 < sipa> and we can't even efficiently iterate those
10:20 < sipa> yes, they also (for now) imply a combo descriptor on their own
10:20 < sipa> but that's not very informative
10:20 < sipa> "this key acts in all the way it itself can be an address!"
10:21 < provoostenator> It's perhaps more informative than the current address= comment which is misleading.
10:21 < sipa> ah, i see
10:21 < sipa> it could list all addresses, or a combo descriptor - that's fair
10:21 < sipa> but for scripts it's actually interesting, as it will tell which which keys it is related to
10:23 < provoostenator> Yes, but the script is only relevant for p2sh wrapped segwit, right? (in a default new wallet)
10:23 < sipa> sure
10:23 < sipa> or anything you manually imported
10:24 < sipa> (multisig etc)
10:24 < provoostenator> In that case I think it's more clear for the comment to indicate that it's only there for p2sh wrapped segwit support, i.e. those entries are redundant once descriptors take over.
10:25 < sipa> dumpwallet as a whole will need to be revamped post-descriptors
10:25 < sipa> i don't understand what you're trying to argue for
10:25 < sipa> scripts are not just there for p2sh wrapped segwit
10:25 < sipa> they are there for p2sh and p2wsh everything
10:26 < provoostenator> Indeed, but it might be useful to get it good enough so it's easier to test things (like upgrade paths) once we have descriptor functionality complete.
10:26 < provoostenator> Right now it's really to inspect what is actually in a wallet.
10:26 < provoostenator> *really hard
10:28 < provoostenator> The comment would only be there for scripts that relate to the standard wallet, not any imported / generated p2(w)sh stuff.
10:28 < sipa> we don't know that
10:28 < sipa> there is just a bunch of scripts
10:28 < sipa> they're not in any way linked to other wallet information
10:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:30 < provoostenator> You could re-match them using the private keys from all keys with an hdmasterkeyid?
10:31 < sipa> or you could just print their inferred descriptor
10:31 < sipa> which works for everything
10:31 < sipa> and is efficient
10:32 < sipa> even that may be confusing, though
10:32 < sipa> as a p2sh-p2wsh script will have two entries
10:32 < sipa> and we don't dump watched scripts
10:33  * sipa would like to see dumpwallet die
10:34 < provoostenator> I think dumpwallet can be useful for testing transition to descriptor based wallets, but I'm fine with making it die after that :-)
10:34 < sipa> yeah, of course
10:37 < provoostenator> sipa: about REST https://github.com/bitcoin/bitcoin/pull/12040#discussion_r235092254
10:38 < provoostenator> Look for my example "do some wallet operation on wallet"
10:38 < provoostenator> It passes an Authorization: Basic param with the request, which contains the RPC username and password in  some base64 converted form. Afaik it has full RPC access.
10:38 < provoostenator> That's not because of this PR.
10:39 < provoostenator> (or if it is, that's very underhanded code)
10:40 < sipa> provoostenator: yes, i see that, but that is just  the RPC interface
10:40 < provoostenator> Oh wait, but then what is the -rest parameter doing?
10:40 < sipa> not the REST interface, which uses .../rest/... URLs
10:40 < provoostenator> -rpcport=8080 is just cancelling my -rest=1?
10:41 < sipa> no
10:41 < sipa> -rest enables the REST interface
10:41 < sipa> that doesn't mean you can't use RPC anymore
10:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
10:42 < sipa> ah, -rpcport is somewhat confusingly named i guess, as that option indeed does affect both rpc and rest
10:42 -!- LGzr [0550d75e@gateway/web/freenode/ip.5.80.215.94] has quit [Quit: Page closed]
10:42 < provoostenator> Ah, it seems very unhealthy that RPC and REST are so intertwined.
10:42 < provoostenator> Shouldn't REST just launch it's own server?
10:43 < sipa> why?
10:43 < sipa> they're entirely separate, apart from both being HTTP
10:43 < sipa> rpcport should be named httpport i guess, but it's a bit late for that
10:43 < provoostenator> I might not want to expose my RPC port to the internet
10:44 < provoostenator> Oh wait, it doesn't move the RPC port? Ok, that is _really_ confusing :-)
10:44 < sipa> sigh
10:44 < sipa> rpcport sets the HTTP listen port
10:44 < sipa> both RPC and REST use HTTP
10:44 < sipa> and you shouldn't expose either to the internet
10:45 < sipa> only the P2P interface is designed to be DoS resilient
10:45 < provoostenator> Ok, but DoS is a different threat than someone gaining RPC control.
10:46 < sipa> sure
10:46 < sipa> but neither are designed to be exposed to the internet
10:47 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
10:48 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
10:53 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
10:54 < wumpus> it would be fully possible to start multiple http servers, and have rpc run on one and rest on the other, though I doubt it's going to be a feature that sees much use
10:55 < provoostenator> I think it would be less confusing if it was a seperate server with its own port, but for this ticket that doesn't matter. The trick is just to only add CORS stuff to /rest/* so we don't have to worry about the phishing scenario I described.
10:55 < wumpus> *if* you want to expose anything to the internet you're going to want to put an nginx server or such in front, which would filter what URLs are allowed
10:56 < wumpus> I don't see how it's confusing, it has been like this since the beginning and AFAIK it's all documented *shrugs*
10:57 < sipa> provoostenator: why do you need CORS on REST?
10:57 < wumpus> that sounds really scary
10:58 < provoostenator> Well that's the point of that PR, which we could debate in general.
10:58 < sipa> i thought it was about something something browser security (i don't understand browsers, this may be my misunderstanding)
10:58 < sipa> but for REST there is no security needed
10:59 < provoostenator> At the moment browsers refuse to connect to the REST RPC via JSON.
10:59 < wumpus> it'd be about letting websites make requests to the local bitcoind instance, hence 'cross-origin'
10:59 < wumpus> I think that's completely ill-advices
10:59 < sipa> ah, it's permitting something, not denying something
10:59 < wumpus> right
10:59 < provoostenator> Yes
10:59 < sipa> i see
11:00 < provoostenator> I don't see any downside with read-only access.
11:00 < sipa> permitting sites to access REST sounds much less scary than letting them access RPC though
11:00 < wumpus> it increases the attack surface to any random website
11:00 < provoostenator> That's true.
11:00 < wumpus> what if it's not really read-only but there is some bug in the REST code or a heartbleed-kind of bug that exposes memory and private keys or whoknowswhat
11:01 < wumpus> I really prefer not having that kind of stuff in bitcoind, sorry
11:01 < provoostenator> I guess that begs the question why this REST service exists in the first place.
11:01 < wumpus> it's a fast way of accessing bitcoind's state
11:02 < wumpus> no need for JSON parsing and formatting, it can give various binary objects directly
11:02 < wumpus> also it can work without autentication for *local* programs, which is useful
11:02 < jarthur> Yea, and that's a big plus. In sidecar services that need to parse the blockchain from a node, so much CPU time is spent on JSON parsing when using the RPC api.
11:03 < wumpus> that doesn't mean you'd want to either expose it to the whole internet, or to every website in a browser
11:04 < wumpus> that'd instantly lift any vulnerability from local-only and limited scope to, pretty much, rce
11:04 < wumpus> same for DoS
11:04 < provoostenator> So it's for fast queries by semi-trusted software.
11:05 < wumpus> yes
11:05 < provoostenator> That makes sense. It might be good to document that intention to set expectations: https://github.com/bitcoin/bitcoin/blob/master/doc/REST-interface.md
11:05 < wumpus> or say, at most internal to your company if you bind on a local network interface and know what you're doing
11:07 < wumpus> bitcoind's P2P interface is the only interface that is hardened for public internet access, and even there improvements are certainly possible
11:07 < sipa> provoostenator: that sounds like a good idea
11:07 < wumpus> yes
11:07 < wumpus> would be good to document that better
11:08 < sipa> wumpus: so, in fairness, the issue of exposing REST to browsers (or any local program running untrusted code) already exists, and it's only through browsers' self-restraint that this is somewhat curbed
11:09 < sipa> i don't think CORS makes things any worse, it's just a question of whether we should treat browsers accessing REST as a supported/recommended practice
11:10 < sipa> and in general i think the answer is no, but perhaps for a company's internal site it makes sense
11:11 < gmaxwell> at least so long as REST is merely a DOS/RCE vector and not intentionally given access to anything too interesting it's not as big a deal.
11:11 < gmaxwell> don't want to repeat ethereum's mistakes.
11:13 < wumpus> sipa: *everything* is due to browser's self restraint, any security at all, if javascript would run unrestricted it would be really bad
11:14 < wumpus> and sure, there could be an option to add CORS headers for specific sites
11:14 < sipa> the PR lets you configure domains
11:14 < wumpus> if anyone is going to use that and test that
11:14 < wumpus> I'm just afraid of scope creep, as you know
11:15 < sipa> wumpus: i understand, but my point is that this isn't really restricted to browsers; the issue exists equally for say someone running an untrusted VM image that makes a connection to the host network
11:15 < wumpus> look, there's this concern we haven't even ever *thought* about and suddenly it needs to be considered in bitcoin core
11:15 < sipa> so our job should be to make sure that by default, these things aren't a concern, and document them well
11:16 < wumpus> yes, okay, the general case where peopel run untrusted software that can access local network, it's not possible to protect against that
11:16 < provoostenator> Someone who really wants this could add an nginx server that just adds the header etc.
11:16 < sipa> (i'm not arguing in favor of the CORS PR; I don't understand the use cases well enough, it just sounds to me that if remote access from local software is a problem, the solution is elsewhere)
11:17 < wumpus> remote access from random websites that the user opens in their browser is a problem
11:17 < wumpus> 'remote' I mean, it's effectively local, the browser protects that using CORS
11:18 < sipa> i mean things like by default not exposing REST, not exposing RPC port publicly, not having a trivial RPC username/password are all protections against this
11:18 < provoostenator> Scope creep is a nice thing to prevent. Even having to explain in documentation what the pitfalls of CORS are, and keep track of that, is overhead.
11:18 < gmaxwell> sipa: to be fair 'VM sandbox that has network access as localhost' is kind of a special case that applies to FAR fewer users than "I run a browser"
11:19 < sipa> wumpus: also, unix domain sockets instead of TCP/IP for RPC would be an improvement
11:19 < sipa> so it's at least restricted to the same user on the same machine
11:19 < jarthur> Yea, someone just needs to find time to finish that out.
11:20 < jarthur> Maybe I'll get some time this weekend if no one else is working on it
11:21 < wumpus> yes unix domain sockets would be great, I should rebase that some time
11:21 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
11:21 < wumpus> or someone else :)
11:21 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:25 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 252 seconds]
11:30 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
11:31 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
11:35 < provoostenator> Unix domain sockets also to get data in other formats than JSON (so you don't need the REST API at all)?
11:37 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
11:39 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:40 < wumpus> it'd be the same http server just over a different socket
11:41 < wumpus> not a completely different API
11:41 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
11:41 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
11:42 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 252 seconds]
11:43 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
11:46 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
11:46 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
11:46 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
11:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:48 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
11:48 -!- zallarak [450e785b@gateway/web/freenode/ip.69.14.120.91] has quit [Ping timeout: 256 seconds]
11:49 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
11:50 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Quit: .]
11:54 -!- mr_paz [~mr_paz@84.39.112.84] has quit [Ping timeout: 268 seconds]
11:58 -!- kelt [~kelt@166.137.105.158] has quit [Quit: Leaving]
12:06 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
12:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wvffaznrswehxpqz] has joined #bitcoin-core-dev
12:06 < bitcoin-git> [bitcoin] vim88 closed pull request #14753: Refactor: Changes postincrement to preincrement for iterator in for loops in src/wallet files (master...postincrement_to_preincrement_src_wallet) https://github.com/bitcoin/bitcoin/pull/14753
12:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wvffaznrswehxpqz] has left #bitcoin-core-dev []
12:06 -!- promag [~promag@83.223.249.26] has joined #bitcoin-core-dev
12:07 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has quit [Remote host closed the connection]
12:16 < jnewbery> promag: > do we have tests to concurrently call RPC to the same node?
12:16 < jnewbery> yes: check mining_getblocktemplate_longpoll.py
12:16 < promag> jnewbery: hi, yap saw that
12:17 < promag> see #14670
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
12:17 < jnewbery> If you want to do similar in a new test, I recommend you take the LongPoll thread class and lift it into TestNode
12:17 < promag> https://github.com/bitcoin/bitcoin/pull/14670/files#diff-9ee18e00fd5f5f1444ba12e8e1378e6a
12:18 < promag> leave a comment there please, bbl
12:33 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
12:34 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
12:34 -!- andrew79 [5266159d@gateway/web/freenode/ip.82.102.21.157] has joined #bitcoin-core-dev
12:34 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
12:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
12:46 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:47 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
12:49 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:52 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
12:58 -!- wpaulino [~wpaulino@142.93.92.243] has quit [Changing host]
12:58 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has joined #bitcoin-core-dev
12:59 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
12:59 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
12:59 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:01 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit []
13:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
13:03 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:04 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
13:08 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds]
13:16 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:19 -!- gelmutshmidt [~gelmuth@188.113.27.168] has quit [Read error: Connection reset by peer]
13:24 -!- Jbaczuk_ [~Jbaczuk@ec2-18-237-204-133.us-west-2.compute.amazonaws.com] has quit [Quit: leaving]
13:34 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 252 seconds]
13:34 -!- andrew79 [5266159d@gateway/web/freenode/ip.82.102.21.157] has quit [Quit: Page closed]
13:39 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
13:40 -!- cryptoboy [~cryptoboy@78.30.21.50] has quit []
13:40 -!- jrayhawk_ is now known as jrayhawk
13:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
13:45 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hiwpopjytsxphpxf] has quit [Quit: Connection closed for inactivity]
13:52 -!- shesek [~shesek@185.3.147.72] has joined #bitcoin-core-dev
13:52 -!- shesek [~shesek@185.3.147.72] has quit [Changing host]
13:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:54 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 245 seconds]
13:54 -!- tmz24 [~tmz@p57A612FD.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
13:55 -!- tmz24 [~tmz@p57A612FD.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
13:57 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
14:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
14:15 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has joined #bitcoin-core-dev
14:18 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has quit [Client Quit]
14:20 -!- promag [~promag@83.223.249.26] has quit []
14:21 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has joined #bitcoin-core-dev
14:21 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Quit: rex4539]
14:33 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:36 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
14:40 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has quit [Ping timeout: 268 seconds]
14:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
14:42 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has joined #bitcoin-core-dev
14:46 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has quit [Ping timeout: 246 seconds]
14:50 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has joined #bitcoin-core-dev
14:53 -!- hex17or [~hex17or@aftr-95-222-26-239.unity-media.net] has quit [Client Quit]
14:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
14:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:04 -!- iphelix [~iphelix@unaffiliated/iphelix] has quit [Quit: Goodbye]
15:04 -!- iphelix- [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev
15:04 -!- iphelix- is now known as iphelix
15:05 -!- iphelix is now known as Guest19336
15:07 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qjlzinpimeghohsc] has quit [Ping timeout: 264 seconds]
15:07 -!- jamesob [sid180710@gateway/web/irccloud.com/x-xeasitrurvyjvgxa] has joined #bitcoin-core-dev
15:11 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
15:28 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
15:40 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ysqylhkqnoxzlcqo] has joined #bitcoin-core-dev
15:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14771: test: Add BOOST_REQUIRE to getters returning optional (master...Mf1811-testNoDiscard) https://github.com/bitcoin/bitcoin/pull/14771
15:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ysqylhkqnoxzlcqo] has left #bitcoin-core-dev []
15:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
15:53 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has joined #bitcoin-core-dev
15:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
16:02 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has quit [Quit: Sleep mode]
16:08 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
16:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:17 -!- owner [~owner@47-215-226-191.sdoncmtk01.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
16:17 -!- owner is now known as Guest70039
16:17 -!- Guest70039 is now known as TGeek
16:20 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:22 < TGeek> Hi all, I am having an issue in bitcoin core 0.17.0.1 with the bumpfee rpc call.. It keeps throwing an error "(-4) Transaction does not have a change output". Which is strange because the output for the tx has two outputs, one for the to address and one for change. I have been troubleshooting this issue for 2 days now and cannot seem to find anything related in searches.. Any help would be greatly appreciated.
16:23 < sipa> how was the transaction created?
16:24 < TGeek> via createrawtransaction and set as replaceable
16:25 < sipa> how did you create the change?
16:25 < sipa> *the change address
16:26 < TGeek> tried both getnewaddress and getrawchangeaddress.. both do not work 
16:26 < sipa> i think you should open an issue
16:26 < gmaxwell> does the fee bumper give correct errors on all the other cases it can't handle?
16:27 < TGeek> also tried using a specific static address with a UTXO's 
16:27 < sipa> i would expect getrawchangeaddress to work
16:28 < sipa> but maybe the change information is held as metadata in the wallet, which means it won't work with anything but sendtoaddress/sendmany
16:29 < TGeek> hmm.. but getrawchangeaddress says in the docs that it is only for using with RAW transactions "NOT normal use"
16:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:30 < sipa> TGeek: yes, i mean that it's possible that bumpfee only works on transaction created through sendtoaddress/sendmany, and not through any of the rawtransaction RPCs
16:31 < sipa> in any case, if so, that should be improved upon
16:31 < sipa> so perhaps best to open an issue so more people can chime in
16:32 < TGeek> ok, will do.. thanks for your time, have a good one
16:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rnstayckiyxtsaii] has joined #bitcoin-core-dev
16:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
16:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rnstayckiyxtsaii] has left #bitcoin-core-dev []
16:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
16:47 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
16:51 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
16:52 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
17:00 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
17:02 -!- TGeek [~owner@47-215-226-191.sdoncmtk01.res.dyn.suddenlink.net] has quit [Quit: Leaving]
17:17 -!- _cryptodesktop_i [~John@91.245.76.90] has joined #bitcoin-core-dev
17:22 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:25 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has joined #bitcoin-core-dev
17:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
17:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
17:48 -!- bitconner [~conner@136.24.75.121] has quit [Quit: leaving]
17:51 -!- _cryptodesktop_i [~John@91.245.76.90] has quit [Ping timeout: 252 seconds]
17:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
18:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
18:21 -!- michaelfolkson [~textual@host86-171-12-237.range86-171.btcentralplus.com] has quit [Quit: Sleep mode]
18:31 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
18:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
18:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds]
18:37 -!- shesek [~shesek@185.3.147.72] has joined #bitcoin-core-dev
18:37 -!- shesek [~shesek@185.3.147.72] has quit [Changing host]
18:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
18:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
18:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
18:39 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Quit: rex4539]
18:45 -!- profmac [~ProfMac@2001:470:1f0f:226:c95f:120c:a710:e7eb] has quit [Ping timeout: 276 seconds]
18:57 -!- profmac [~ProfMac@2001:470:1f0f:226:fd31:2708:3955:79e2] has joined #bitcoin-core-dev
19:02 -!- Bullit [~Bullit01@156-209-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
19:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.2]
19:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
19:36 -!- mineralnov [~androirc@195.208.173.159] has joined #bitcoin-core-dev
19:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
19:38 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
19:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
19:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
20:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bxoxsrdirdvnbogc] has joined #bitcoin-core-dev
20:16 < bitcoin-git> [bitcoin] kallewoof opened pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774
20:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bxoxsrdirdvnbogc] has left #bitcoin-core-dev []
20:21 -!- schnerchi [~schnerchi@p3EE1CF5F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
20:24 -!- schnerch_ [~schnerchi@p3EE1C108.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
20:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
20:53 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
20:54 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
21:03 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 240 seconds]
21:05 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev
21:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gmrbtksgenudpvxl] has joined #bitcoin-core-dev
21:10 < bitcoin-git> [bitcoin] dooglus opened pull request #14775: 'break' should be 'continue' here? (master...patch-6) https://github.com/bitcoin/bitcoin/pull/14775
21:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gmrbtksgenudpvxl] has left #bitcoin-core-dev []
21:27 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Quit: Leaving]
21:29 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
21:40 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
21:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
21:42 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Ping timeout: 245 seconds]
21:45 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
21:46 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Ping timeout: 268 seconds]
21:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
22:20 -!- oneark [uid254801@gateway/web/irccloud.com/x-kvunjirrshvqnfqu] has joined #bitcoin-core-dev
22:40 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 240 seconds]
22:41 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
22:50 -!- rex4539 [~rex4539@88.128.81.50] has joined #bitcoin-core-dev
22:52 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds]
22:55 -!- schnerchi [~schnerchi@p3EE1CF5F.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
22:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-smlcngrilwrgwqse] has joined #bitcoin-core-dev
22:57 < bitcoin-git> [bitcoin] jameshilliard opened pull request #14776: Add process based prctl spectre mitigation controls. (master...spectre-prctl) https://github.com/bitcoin/bitcoin/pull/14776
22:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-smlcngrilwrgwqse] has left #bitcoin-core-dev []
23:10 -!- schnerchi [~schnerchi@p54A79131.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
23:11 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Remote host closed the connection]
23:12 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
23:16 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
23:16 -!- rex4539 [~rex4539@88.128.81.50] has quit [Quit: rex4539]
23:29 -!- rex4539 [~rex4539@88.128.81.50] has joined #bitcoin-core-dev
23:35 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Quit: leaving]
23:36 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
23:38 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Remote host closed the connection]
23:38 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
--- Log closed Wed Nov 21 00:00:27 2018