--- Log opened Thu Nov 29 00:00:35 2018
--- Day changed Thu Nov 29 2018
00:00 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
00:00 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
00:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:07 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
00:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
00:22 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
00:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
00:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sbpxqegtvkterrem] has joined #bitcoin-core-dev
00:25 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #14837: Stricter & More Performant Invariant Checking in CheckBlock (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14837
00:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sbpxqegtvkterrem] has left #bitcoin-core-dev []
00:29 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
00:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
00:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ypciddbhxkxowiwd] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] fanquake closed pull request #14387: Faster Input Deduplication Algorithm (master...faster-dedup) https://github.com/bitcoin/bitcoin/pull/14387
00:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ypciddbhxkxowiwd] has left #bitcoin-core-dev []
00:35 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
00:35 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
00:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:38 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Quit: Konversation terminated!]
00:38 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:40 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
00:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:44 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:44 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
00:46 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
00:46 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
00:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:47 -!- chenpo [~chenpo@210-61-125-222.HINET-IP.hinet.net] has joined #bitcoin-core-dev
00:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:02 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:04 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
01:04 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
01:04 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:04 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:05 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
01:05 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
01:05 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:08 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
01:08 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
01:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:09 -!- chenpo [~chenpo@210-61-125-222.HINET-IP.hinet.net] has quit [Remote host closed the connection]
01:09 -!- chenpo [~chenpo@61-216-136-90.HINET-IP.hinet.net] has joined #bitcoin-core-dev
01:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
01:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsjemevtppgahrqq] has joined #bitcoin-core-dev
01:13 < bitcoin-git> [bitcoin] hebasto opened pull request #14838: Use const in COutPoint class (master...20181129-const-null-outpoint) https://github.com/bitcoin/bitcoin/pull/14838
01:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsjemevtppgahrqq] has left #bitcoin-core-dev []
01:13 -!- chenpo [~chenpo@61-216-136-90.HINET-IP.hinet.net] has quit [Ping timeout: 240 seconds]
01:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:16 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
01:16 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
01:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:17 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
01:30 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:39 -!- indistylo [~indistylo@49.204.67.58] has quit [Ping timeout: 250 seconds]
01:44 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has joined #bitcoin-core-dev
01:45 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has quit [Remote host closed the connection]
01:45 -!- chenpo [~chenpo@61-216-77-164.HINET-IP.hinet.net] has joined #bitcoin-core-dev
01:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
01:46 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-gpbcvnveanzrlmln] has joined #bitcoin-core-dev
01:47 -!- chenpo [~chenpo@61-216-77-164.HINET-IP.hinet.net] has quit [Read error: Connection reset by peer]
01:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
01:47 -!- chenpo_ [~chenpo@211-22-103-211.HINET-IP.hinet.net] has joined #bitcoin-core-dev
01:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
01:51 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
01:52 -!- chenpo_ [~chenpo@211-22-103-211.HINET-IP.hinet.net] has quit [Ping timeout: 268 seconds]
02:02 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
02:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:08 -!- chenpo [~chenpo@210-61-125-222.HINET-IP.hinet.net] has joined #bitcoin-core-dev
02:08 -!- chenpo [~chenpo@210-61-125-222.HINET-IP.hinet.net] has quit [Remote host closed the connection]
02:09 -!- chenpo [~chenpo@140.109.239.1] has joined #bitcoin-core-dev
02:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
02:18 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
02:18 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
02:18 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:22 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:24 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
02:25 -!- chenpo_ [~chenpo@125-227-20-139.HINET-IP.hinet.net] has joined #bitcoin-core-dev
02:28 -!- chenpo [~chenpo@140.109.239.1] has quit [Ping timeout: 246 seconds]
02:29 < fanquake> dongcarl I reckon that'd be too much pressure..
02:29 < fanquake> dongcarl Also, not sure where you are at with turtles work, but you might want to have a look at #14342
02:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14342 | threads: fix potential unitialized members in sched_param by theuni · Pull Request #14342 · bitcoin/bitcoin · GitHub
02:40 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev
02:48 -!- chenpo_ [~chenpo@125-227-20-139.HINET-IP.hinet.net] has quit [Remote host closed the connection]
02:49 -!- chenpo [~chenpo@59-124-157-80.HINET-IP.hinet.net] has joined #bitcoin-core-dev
02:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
02:49 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
02:49 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
02:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds]
02:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
02:53 -!- chenpo [~chenpo@59-124-157-80.HINET-IP.hinet.net] has quit [Remote host closed the connection]
02:53 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
02:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
02:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
02:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xocsqfpbhjrfyyon] has joined #bitcoin-core-dev
02:59 < bitcoin-git> [bitcoin] fanquake opened pull request #14839: [rebase] threads: fix unitialized members in sched_param (master...rebased-fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14839
02:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xocsqfpbhjrfyyon] has left #bitcoin-core-dev []
02:59 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmpcdtevdwuhkyry] has joined #bitcoin-core-dev
03:00 < bitcoin-git> [bitcoin] fanquake closed pull request #14342: threads: fix potential unitialized members in sched_param (master...fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14342
03:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmpcdtevdwuhkyry] has left #bitcoin-core-dev []
03:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:01 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has joined #bitcoin-core-dev
03:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:12 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has quit [Remote host closed the connection]
03:12 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:12 -!- chenpo [~chenpo@61-216-77-164.HINET-IP.hinet.net] has joined #bitcoin-core-dev
03:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:17 -!- chenpo [~chenpo@61-216-77-164.HINET-IP.hinet.net] has quit [Ping timeout: 250 seconds]
03:17 -!- chenpo_ [~chenpo@60-250-236-43.HINET-IP.hinet.net] has joined #bitcoin-core-dev
03:19 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
03:19 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
03:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:20 -!- chenpo_ [~chenpo@60-250-236-43.HINET-IP.hinet.net] has quit [Remote host closed the connection]
03:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
03:22 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
03:22 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
03:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:23 -!- chenpo [~chenpo@220-128-240-242.HINET-IP.hinet.net] has joined #bitcoin-core-dev
03:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
03:26 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
03:26 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
03:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:26 -!- chenpo [~chenpo@220-128-240-242.HINET-IP.hinet.net] has quit [Remote host closed the connection]
03:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
03:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
03:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:32 -!- murchandamus [~murchghos@ghostdub.de] has quit [Ping timeout: 250 seconds]
03:32 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has joined #bitcoin-core-dev
03:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bmspmijoqzlhoxun] has joined #bitcoin-core-dev
03:33 < bitcoin-git> [bitcoin] AmirAbrams opened pull request #14840: Remove duplicate libconsensus linking in test make (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14840
03:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bmspmijoqzlhoxun] has left #bitcoin-core-dev []
03:33 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:34 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:46 -!- promag [~promag@193.126.224.118] has joined #bitcoin-core-dev
03:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hufcuwtzjfsbecem] has joined #bitcoin-core-dev
03:55 < bitcoin-git> [bitcoin] hebasto opened pull request #14841: consensus: Move CheckBlock() call to critical section (master...20181129-checkblock-mutex) https://github.com/bitcoin/bitcoin/pull/14841
03:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hufcuwtzjfsbecem] has left #bitcoin-core-dev []
03:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
04:02 < fanquake> appveyor: the perpetually failing CI 
04:03 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
04:03 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
04:03 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
04:08 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
04:08 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
04:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:15 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has quit [Remote host closed the connection]
04:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
04:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:24 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has joined #bitcoin-core-dev
04:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
04:24 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
04:24 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
04:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
04:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
04:39 -!- promag [~promag@193.126.224.118] has quit [Remote host closed the connection]
04:51 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has quit [Quit: rex4539]
04:52 -!- sakalli_ [~Mutter@mobile-access-bcee7f-74.dhcp.inet.fi] has joined #bitcoin-core-dev
04:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
04:54 -!- sakalli_ [~Mutter@mobile-access-bcee7f-74.dhcp.inet.fi] has quit [Client Quit]
04:57 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
05:00 -!- indistylo [~indistylo@49.204.67.58] has joined #bitcoin-core-dev
05:11 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has quit [Remote host closed the connection]
05:12 -!- chenpo [~chenpo@125.227.16.37] has joined #bitcoin-core-dev
05:12 -!- chenpo [~chenpo@125.227.16.37] has quit [Remote host closed the connection]
05:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
05:14 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
05:14 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
05:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:16 -!- chenpo [~chenpo@61-216-136-90.HINET-IP.hinet.net] has joined #bitcoin-core-dev
05:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:20 -!- chenpo [~chenpo@61-216-136-90.HINET-IP.hinet.net] has quit [Remote host closed the connection]
05:20 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has joined #bitcoin-core-dev
05:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
05:21 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
05:21 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
05:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:25 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has quit [Ping timeout: 250 seconds]
05:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
05:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
05:44 -!- indistylo [~indistylo@49.204.67.58] has quit [Ping timeout: 268 seconds]
05:45 -!- indistylo [~indistylo@27.59.27.31] has joined #bitcoin-core-dev
05:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
06:03 -!- indistylo [~indistylo@27.59.27.31] has quit [Remote host closed the connection]
06:04 -!- indistylo [~indistylo@27.59.27.31] has joined #bitcoin-core-dev
06:04 -!- indistylo [~indistylo@27.59.27.31] has quit [Remote host closed the connection]
06:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
06:27 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has joined #bitcoin-core-dev
06:28 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has quit [Remote host closed the connection]
06:28 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has joined #bitcoin-core-dev
06:33 -!- chenpo [~chenpo@211-22-103-211.HINET-IP.hinet.net] has quit [Ping timeout: 250 seconds]
06:35 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev
06:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfumgnnrztonqfzd] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] ariaamz opened pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
06:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfumgnnrztonqfzd] has left #bitcoin-core-dev []
06:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-czocmgnjlaqbnbqd] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] fanquake closed pull request #14843: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14843
06:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-czocmgnjlaqbnbqd] has left #bitcoin-core-dev []
07:07 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
07:07 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
07:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
07:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
07:12 -!- schmidty_ [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
07:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit []
07:14 -!- schmidty_ [~schmidty@unaffiliated/schmidty] has quit []
07:16 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
07:26 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 246 seconds]
07:32 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev
07:35 -!- wumpus2 is now known as wumpus
07:40 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev
07:41 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:44 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-gpbcvnveanzrlmln] has quit [Quit: Connection closed for inactivity]
07:46 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:46 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
07:46 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
07:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
07:51 -!- chenpo [~chenpo@2001-b011-5c0d-155a-b928-7a88-7148-4881.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
07:54 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
07:56 < adiabat> saw sipa's mention of the work I'm doing on accumulators, I don't have anything published yet but if anyone's interested can discuss on #utreexo (or here, but might be off-topic)
07:57 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:13 -!- chenpo [~chenpo@2001-b011-5c0d-155a-b928-7a88-7148-4881.dynamic-ip6.hinet.net] has quit [Remote host closed the connection]
08:13 -!- chenpo [~chenpo@2001-b011-5c0d-155a-b928-7a88-7148-4881.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
08:15 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
08:17 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:18 -!- chenpo [~chenpo@2001-b011-5c0d-155a-b928-7a88-7148-4881.dynamic-ip6.hinet.net] has quit [Ping timeout: 250 seconds]
08:40 < dongcarl> fanquake: Been on hold for a bit as I've been busy with other stuff... I'll take a look at your rebase for that PR
08:41 -!- wxss [~user@77.243.177.40] has joined #bitcoin-core-dev
08:57 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:59 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
09:10 -!- mr_paz [~mr_paz@84.39.112.89] has joined #bitcoin-core-dev
09:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
09:11 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
09:11 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
09:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:11 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
09:15 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 244 seconds]
09:19 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
09:21 -!- _cryptodesktop_i [~John@91.245.77.21] has joined #bitcoin-core-dev
09:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
09:27 -!- promag [~promag@83.223.251.160] has joined #bitcoin-core-dev
09:31 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
09:46 < promag> can't attend meeting :(
09:46 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer]
09:48 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 264 seconds]
09:49 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
09:55 -!- _cryptodesktop_i [~John@91.245.77.21] has quit [Ping timeout: 244 seconds]
09:56 -!- hashist [~hashist@157.157.113.25] has joined #bitcoin-core-dev
09:59 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has quit [Remote host closed the connection]
10:00 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
10:03 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 240 seconds]
10:03 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
10:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
10:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
10:14 < promag> fanquake: the perpetually failing CI << I'm hoping #14670 fixes it
10:14 < gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
10:15 -!- promag [~promag@83.223.251.160] has quit [Remote host closed the connection]
10:17 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
10:19 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has joined #bitcoin-core-dev
10:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aexeadtpckptzxzc] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] jnewbery opened pull request #14845: [tests] Add wallet_balance.py (master...balance_tests) https://github.com/bitcoin/bitcoin/pull/14845
10:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aexeadtpckptzxzc] has left #bitcoin-core-dev []
10:39 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 246 seconds]
10:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qtdyuhfsufpbulhp] has joined #bitcoin-core-dev
10:43 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14803: consensus: Avoid data race in CBlock class (master...20181125-cblock-threadsafe) https://github.com/bitcoin/bitcoin/pull/14803
10:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qtdyuhfsufpbulhp] has left #bitcoin-core-dev []
10:45 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev
10:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
10:51 -!- brianhoffman_ [~brianhoff@104.194.218.180] has joined #bitcoin-core-dev
10:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
10:53 -!- brianhoffman [~brianhoff@pool-71-163-147-195.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds]
10:53 -!- brianhoffman_ is now known as brianhoffman
10:56 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
10:56 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
10:56 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
10:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:00 < provoostenator> Meeting?
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Nov 29 19:00:25 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < sipa> oh, meeting!
11:00 < dongcarl> hi
11:00 < moneyball> hi
11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
11:01 < moneyball> suggested topic: proposed meeting topics ahead of time
11:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:01 < meshcollider> hi
11:01 < BlueMatt> topics: 0.17.1
11:01 < wumpus> #topic high priority for review
11:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:02 < wumpus> current PRs: #14670 #13932 #14336 #14646
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
11:02 < kanzure> hi.
11:03 < wumpus> anyone want to add or remove anything?
11:04 < sipa> lgtm
11:04 < meshcollider> Pieter already has one but it'd be great to have #14565 
11:04 < gmaxwell> whats the overlap with 0.17.1 tag?
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
11:04 < chenpo> hi
11:05 < wumpus> does the 0.17.1 tag have any non-backports left?
11:05 < gmaxwell> #14380  
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
11:05 < gmaxwell> is what I was thinking of.
11:05 < wumpus> https://github.com/bitcoin/bitcoin/milestone/39
11:06 < wumpus> let's add that one then
11:06 < meshcollider> 14782 is sort-of not a backport
11:06 < jnewbery> hi
11:06 < wumpus> meshcollider: which one is the most-blocking?
11:07 < wumpus> #14646 seems like it needs to go in before something else so looks like a typical candidate at least
11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
11:07 < meshcollider> Yeah don't remove that one
11:08 < gmaxwell> The broken getbalance behavior should get fixed. It's an actual bug.
11:08 < wumpus> that's only broken on 0.17 and not master?
11:08 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:08 < provoostenator> #14602
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
11:09 < achow101> hi
11:09 < wumpus> wait, I added #14782 which is the 0.17 backport
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
11:09 < jnewbery> I'm not clear what the behaviour is 'supposed' to be. There's no documentation or test coverage
11:09 < gmaxwell> wumpus: not yet, there is another PR
11:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:09 < wumpus> why is a backport open before something is merged into master? is it signifiantly different?
11:09 < provoostenator> Ah yes, it's already marked for backport.
11:09 < meshcollider> The 0.17 backport of it is different yes
11:09 < meshcollider> Because of the accounts removal
11:09 < sipa> maybe the getbalance behaviour needs to be topic on its own>?
11:09 < wumpus> right
11:10 < gmaxwell> jnewbery: thats a fine concern, but it's not cool to break functionality just because there wasn't enough tests to stop you from doing so
11:10 < meshcollider> ping luke-jr 
11:10 < wumpus> if there's any doubt it probably needs to stay as it was
11:10 < gmaxwell> The alternative of going and reverting the breaking change is unfortunately too disruptive (I already tried).
11:10 < meshcollider> Re-implementing the old behaviour without reintroducing account parameters is the issue
11:10 < jnewbery> the new behaviour in the fix is different from pre-0.17
11:11 < meshcollider> And it has some weird parameter type polymorphism
11:11 < wumpus> well for 0.18, changing the behavior can be discussed if there's agood reason
11:11 < sipa> gmaxwell: well given the removal of accounts, i think it's fair to say that anyone passing not-nothing as the account parameter to getbalance needs to change, and you can get the 0-conf behavior using getunconfirmedbalance
11:11 < jnewbery> so before we decide whether it should be merged, we should figure out what the behavious should be, document it and cover it with tests so it's not regressed
11:11 < provoostenator> getunconfirmedbalance _only_ includes unconfirmed balance afaik
11:11 < sipa> oh
11:12 < wumpus> for 0.17 it'd be good to go back to the old behavior because it was not announced in the release notes that it would change
11:12 < sipa> ignore my suggestion, again
11:12 < meshcollider> Add them together then :)
11:12 < gmaxwell> if you add them you'll double count
11:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:12 < meshcollider> wumpus: that's why the 0.17 backport was opened already
11:12 < provoostenator> It's useful in practice to be able to get the balance including unconfirmed, so you can compose a PSBT while you're waiting for confirmation.
11:12 < BlueMatt> also for 0.17.1 this seems a bit too late to be figuring out
11:12 < BlueMatt> we can revisit for 0.17.2 if there is one
11:12 < provoostenator> (without doing math)
11:13 < BlueMatt> but 0.17.0 currently cannot be self-built and bitcoin-qt opened on latest fedora/ubuntu release
11:13 < BlueMatt> both of which have been out for a bit now
11:13 < gmaxwell> It isn't just a question of unconfirmed or not, it's a question of your balance suddenly showing zero when you make a small payment.. because now your change is unconfirmed.
11:13 < sipa> gmaxwell: getbalance includes change
11:13 < sipa> just not unconfirmed incoming payments
11:14 < sipa> that was the distinction between getbalance and getbalance *, afaik
11:14 < wumpus> #topic getbalance
11:14 < gmaxwell> Right
11:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
11:14 < gmaxwell> sipa: and thats also why you can't add getunconfirmedbalance.
11:14 < jnewbery> for those without context, this is (mostly) my fault for removing accounts. The first parameter to getbalance was 'account', it was marked DEPRECATED with a warning saying 'don't use this'. I removed it and it turns out people were using it to sum up untrusted coins
11:14 < sipa> you can simulate "getbalance *" using "getbalance minconf=1" + "getunconfirmedbalance" i guess
11:14 < wumpus> BlueMatt: yes, let's discuss what to in include in 0.17.1 in the 0.17.1 topic
11:15 < meshcollider> But the actual difference wasn't just unspent, it was untrusted, right?
11:15 < sipa> meshcollider: indeed
11:15 < meshcollider> Unconfirmed*
11:15 < jnewbery> getbalance -minconf=0 includes unconfirmed but not untrusted coins (eg your change)
11:15 < jnewbery> getbalance * 0 would (prior to 0.17) include untrusted
11:16 < jnewbery> so for example if someone sent you an output, then RBF'ed it, you'd still see that in your getbalance * 0
11:16 < meshcollider> as you pointed out on the PR though john, does that also include conflicting transactions and stuff too?
11:16 < jnewbery> or RBF'ed it to you, you'd double count it
11:16 < jnewbery> or you could have a negative balance
11:16 < meshcollider> Thats not sane behaviour to keep then :/
11:17 < wumpus> that sounds pretty broken
11:17 < gmaxwell> I didn't think it included conflicteds, but actually it makes sense.
11:17 < jnewbery> I don't know why people were using getbalance * 0, or what they were using it for. I've asked a few times on the PR but no-one can answer
11:17 < gmaxwell> If you recall when we removed accounts I raised a concern that didn't we still need move to fixed people's negative balances... because we still had those reported from time to time.
11:17 < jnewbery> ok, I've fixed that :)
11:18 < gmaxwell> jnewbery: to see unconfirmed payments... it's certantly what I always did before I gave up on balances and just switched to looking at the unspent outputs directly
11:18 < ryanofsky> It sounded to me like people were just using it to get unconfirmed balance without having two make two calls
11:18 < provoostenator> That's exactly how I use it.
11:18 < sipa> how about adding a "requiretrusted" parameter to getbalance...?
11:18 < gmaxwell> ryanofsky: not just without having to make two calls, because getbalance included 0 conf trusted coins. 
11:18 < provoostenator> If you want to prepare a transaction to spend all, you need to enter the amount to send. 
11:18 < gmaxwell> ryanofsky: and the minconf parameter was added later
11:19 < jnewbery> I think it's fine to have a balance including unconfirmeds if they're trusted (ie all inputs were yours). Having a balance containing unconfirmeds that aren't trusted and so can be double-accounted or worse doesn't make sense to me
11:19 < meshcollider> sipa: the PR introduces a bool for trustedness
11:19 < sipa> meshcollider: oh!
11:19 < jnewbery> I strongly discourage any 'balance' that contains untrusted coins
11:19 < sipa> does it allow counting untrusted, while excluding conflicting etc?
11:19 < meshcollider> No
11:19 < gmaxwell> jnewbery: I don't understand "trusted and so can be double-accounted" -- even a trusted payment could be conflicted
11:20 < provoostenator> jnewbery: why? Isn't that implied when the user enters 0 instead of 1 confirmations?
11:20 < meshcollider>  unconfirmed != untrusted though
11:20 < gmaxwell> jnewbery: we _show_ unconfirmed payments in the wallet, so it's somewhat odd and confusing that we don't have "pending balance"
11:21 < wumpus> the GUI does have a 'unconfirmed balance' IIRC?
11:21 < sipa> showing untrusted balance sounds perfectly reasonable, but it shouldn't include conflicting/... things
11:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
11:21 -!- hebasto [~hebasto@95.164.65.194] has quit [Quit: Leaving]
11:21 < meshcollider> We could break the getbalance output and return an array of "confirmed":, "unconfirmed":, "conflicting:
11:21 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
11:21 < jnewbery> for me 'pending balance' doesn't make sense if it can double-count conflicting transactions. It's worse that not having a pending balance at all
11:21 -!- shesek [~shesek@141.226.218.76] has joined #bitcoin-core-dev
11:21 -!- shesek [~shesek@141.226.218.76] has quit [Changing host]
11:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:22 < meshcollider> ^
11:22 < sipa> jnewbery: i agree
11:22 < morcos> yes, its not clear to me what the problem is with using getbalance and getunconfirmedbalance when using -cli and the GUI already does the right thing?
11:22 < gmaxwell> In any case, you wanted the use case, the reason people use getbalance "*" is to (Attempt) to learn their pending balance.  What they'll have assuming nothing goes wrong.  Now if that was also double counting conflicteds and ending up negative, I think thats a bug. (and probably the origin of the negative balances I was concerned about before)
11:22 < wumpus> users don't know what 'untrusted balance' is supposed to be, I think exposing these kind of implementation details on the interface is a bit confusing
11:22 < provoostenator> I agree double counting is undesirable.
11:22 < jnewbery> it will make users think their money has disappeared because once one of those conflicting transactions is confirmed their balance goes down
11:22 < morcos> can someone clearly point out exactly what we can not do now (other than we didn't properly explain what was changing)
11:22 < meshcollider> luke-jr: should be here to argue the other side
11:22 < sipa> jnewbery: i think no getbalance* call should evr include conflicted things
11:22 < provoostenator> It should probably use mempool rules to figure out which transaction to ignore.
11:23 < sipa> provoostenator: some things do
11:23 < meshcollider> IMO setting min_conf to 0 is enough?
11:23 < gmaxwell> sipa: wait. I would think that it would include one side of a conflict...
11:23 < sipa> gmaxwell: oh sure; terminology
11:23 < wumpus> isn't it supposed to make one side of a conflict non-conflicting?
11:23 < sipa> i guess by non-conflicting i mean "in the mempool" ?
11:23 < wumpus> right
11:24 < gmaxwell> Good! jnewbery's comment about balances going down confused me
11:24 < sipa> gmaxwell: or do you think unconfirmed untrusted not-in-the-mempool unconflicted things should be counted?
11:24 < jnewbery> sorry, I've got to step away now. My main point is that the expected behaviour should be well documented and covered by tests
11:24 -!- brianhoffman_ [~brianhoff@pool-71-163-147-195.washdc.fios.verizon.net] has joined #bitcoin-core-dev
11:24 < gmaxwell> sipa: no. I don't.
11:24 < sipa> ok, good
11:24 < jnewbery> I've written a test script for wallet balances, but we need to agree what the behaviour *should* be before merging any of this stuff
11:25 < meshcollider> Agreed
11:25 < provoostenator> If something gets confirmed against what you would expect fromt he mempool then a balance change is fine imo, but not otherwise.
11:25 < sipa> so how about getbalance requires the minconf as directed, and (if trusted is directed, trusted, otherwise in-the-mempool)
11:26 < provoostenator> sipa: the only criteria for "trusted" is whether it's change, right?
11:26 < gmaxwell> I think if sipa is right that the behavior can be emulated by getbalance minconf=1 + getunconfirmed then at least we have a workaround.  Though it's always confusing to have a deault behavior which cannot be explained by some setting of the arguments
11:26 < sipa> provoostenator: or confirmed
11:27 < gmaxwell> "What is the default minconf setting of getbalance? Mu.  getbalance output shows minconf=0 for trusted outputs, and minconf=1 for others.  so trusted defaults to true? No, there is no trusted argument."
11:27 -!- brianhoffman [~brianhoff@104.194.218.180] has quit [Ping timeout: 268 seconds]
11:27 -!- brianhoffman_ is now known as brianhoffman
11:28 < sipa> gmaxwell: #14602 includes a trusted_only argument that is true by default
11:28 < gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
11:28 < provoostenator> I know the wallet makes a distinction between change and non-change when it comes to spending, which is fine, but I don't think we should do that for balance. So by default minconf=0 should show change and non-change, but not replaced-by.
11:28 < ryanofsky> just want to note, it looks like we didn't delete the GetLegacyBalance function, so it would be trivial to restore the old getbalance "*" behavior, if we can't figure out something better right now
11:28 < gmaxwell> I know 14602 does. I'm trying to imagine a world where we keep things as they are and try to release note ourselves out of it
11:29 < provoostenator> (as for 0.17 I'm fine with release-noting our way of it)
11:29 < sipa> oh, i was just trying to establish what the desired behavior is before we go discuss what to do about it
11:30 < provoostenator> sipa: that's a good idea
11:30 < sipa> and i think there is at least a rough conclusion? allow counting untrusted, but never count not-in-mempool?
11:31 < gmaxwell> Right, I think the desired behavior is that balances shows confirmed + trusted-in-mempool-0conf.  And that you be able to adjust the threshold for confirmed and turn the trusted-in-mempool-zeroconf on and off. And if you make the confirmed=0, it should still only count in-mempool
11:31 < provoostenator> (and maybe add a 4th argument along the lines of unconfirmed_change_only
11:31 < gmaxwell> (and potentially the arguments should just be  minconf_for_not_you=1 minconf_for_from_you=0 )
11:32 < sipa> i think the default of minconf=0 but trusted_only=true makes sense; if you choose trusted_only=false it should still only include confirmed or mempool things
11:32 < morcos> sipa: the problem with never counting not-in-mempool is if you spend a 10 BTC input to pay 0.001 BTC, and that tx doesn't go in your mempool then your balance goes down by 10 mysteriously, but thats hard to solve
11:32 < sipa> morcos: yeah...
11:32 < gmaxwell> morcos: yes, I think thats hard to solve, also it's kinda good that it goes down in that you're actually screwed for the moment :P
11:33 < gmaxwell> like if that txn doesn't confirm, your funds are actually stuck.
11:33 < gmaxwell> (until you abandon the transaction)
11:33 < wumpus> right
11:34 < gmaxwell> I guess I can argue the consequences either way, I can imagine someone losing a wallet file with lots of bitcoin in it because it showed a low balance due to some easily abandoned transactions.
11:34 < sipa> so i think we can work out how to implement this for 0.17 and 0.18 on the PRs or issues; no need for further design here?
11:34 < gmaxwell> I thought luke's PR basically implemented what we came up with here. But I'm not sure.
11:35 < sipa> gmaxwell: i'm not sure about the mempool part
11:35 < wumpus> gmaxwell: people are likely to use 'getbalance' without parameters in that case, to check wallet balance, not the specific combo that this is about
11:35 < gmaxwell> certantly if we're showing all unconfirmeds, including both sides of a conflict, thats bad. :P
11:36 < provoostenator> Luke's PR adds a trusted_only as a first parameter. I find that a fairly confusing term, so hopefully we can avoid it with the ^
11:36 < sipa> with the what?
11:37 < wumpus> trusted_only sounds really confusing to users, if you make a parameter like that you need to carefully explain in the RPC help what 'truste'd means in this setting
11:37 < sipa> agree, it needs documentation for sure
11:37 < wumpus> it's far from obvious, I don't know if we picked a good term for it
11:37 < provoostenator> With what you said: "allow counting untrusted, but never count not-in-mempool"
11:38 < provoostenator> It's already a default, so maybe just a matter of renaming and documenting it.
11:38 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
11:38 < sipa> provoostenator: it can certainly be explained more friendly as "Whether unconfirmed payments from others are excluded"
11:38 < provoostenator> 1. zero_conf_change_only (default: false)
11:39 < wumpus> sipa: that sounds much better
11:39 < sipa> i think we're getting in the weeds here
11:39 < wumpus> yes, time for next otpic?
11:39 < sipa> agree
11:39 < wumpus> #topic 0.17.1
11:39 < provoostenator> Next topic sounds good.
11:39 < BlueMatt> release time!
11:39 < wumpus> 20 minutes left
11:39 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:40 < BlueMatt> cool, release in 20 minutes? :p
11:40 < provoostenator> BlueMatt is the main reason Ubutnu?
11:40 < meshcollider> Lol
11:40 < BlueMatt> provoostenator: also fedora, debian testing, .......
11:40 < provoostenator> Because an alternative could be 0.17.0.2 like we did with MacOS. Though I'm fine with proper 0.17.1 too
11:40 < wumpus> still lots of backports open https://github.com/bitcoin/bitcoin/milestone/39 I guess they need review, or at least merging 
11:40 < BlueMatt> provoostenator: also there are a number of other bugs and backports that are done, etc
11:40 < sipa> we have a bunch of bugfixes lined up too
11:40 < wumpus> nah let's do a proper release
11:40 < sipa> it may be time for a 0.17.1
11:40 < BlueMatt> things already merged on master probably worth backporting
11:40 < wumpus> it's too late for 0.17.0.2 IMO
11:40 < BlueMatt> cause there are a bunch there
11:41 < provoostenator> Right, that would involve branching off of the 0.17.0.1 tag and get weird.
11:41 < wumpus> .z releases are really 'oops we did a release and need to fix this thing up'
11:41 < BlueMatt> but, at least IMO, its super annoying that you cant build+run bitcoin-qt on the now-several-months-old versions of various OSs, and I presume other rolling distros (eg arch) also have this issue
11:41 < wumpus> not for month later
11:41 < instagibbs> I keep crashing, get 14380 in please ;P
11:41 < BlueMatt> so I would prefer we not wait around for fixing getbalance :p
11:41 < wumpus> I agree with BlueMatt on this
11:42 < BlueMatt> #14380 looks more than merge-able from where I'm sitting in the ack department
11:42 < gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub
11:42 < BlueMatt> and not too hard to backport
11:42 < sipa> can people have a look at #14780 too?
11:42 < gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
11:42 < sipa> (i'm mostly unfamiliar with the backports process)
11:43 < wumpus> there is no agreement on getbalance yet, it can wait for 0.17.2
11:43 < wumpus> sipa: sure!
11:43 < sipa> thanks
11:43 < wumpus> sipa: please make sure you include the commit metadata (Github-Pull: #.... and Rebased-From: <commit>)
11:44 < BlueMatt> next topic: the wall of text I just posted to bitcoin-dev :p
11:44 < wumpus> (see the commits in other backport PRs such as https://github.com/bitcoin/bitcoin/pull/14835)
11:44 < sipa> BlueMatt: not there
11:44 < wumpus> next topic is moneyball's 
11:44 < moneyball> hi
11:44 < BlueMatt> err, topic suggestion
11:44 < BlueMatt> anything else on 0.17.1?
11:45 < BlueMatt> or just generally a "lets take things that we can merge today, do backports, and get this thing going"
11:45 < provoostenator> BlueMatt: "IRC logs have been disabled due to the EU General Data Protection Regulation (GDPR)."
11:45 < wumpus> BlueMatt: +1
11:45 < provoostenator> +1
11:45 < wumpus> #topic proposed meeting topics ahead of time (moneyball)
11:46 < moneyball> I’d like to suggest that people can propose Core weekly meeting topics anytime throughout the week in this IRC channel using #proposedmeetingtopic tag. I will collect these throughout the week, add them to a gist that anyone can have a look at during the week. The primary intended benefit of this is to allow people to know which topics are going to be discussed ahead of time allowing them to prepare.
11:46 < moneyball> Any concerns?
11:46 < BlueMatt> seems reasonable
11:46 < provoostenator> +1
11:46 < BlueMatt> easier than remembering to mention them in meeting
11:46 < Chris_Stewart_5> +1
11:46 < meshcollider> +1
11:46 < BlueMatt> next topic? #thatwaseasy
11:46 -!- marpme [5e865800@gateway/web/freenode/ip.94.134.88.0] has joined #bitcoin-core-dev
11:47 < wumpus> yes, good idea, let's see how it goes
11:47 < moneyball> Ok I will start doing it!
11:47 < wumpus> BlueMatt: ok what was your proposal, I'm not in #bitcoin-dev
11:47 < provoostenator> And there's no logs..
11:47 < BlueMatt> oh, i meant bitcoin-dev ml but it hasnt passed moderation yet
11:47 < BlueMatt> anyway, I can tl;dr it in two lines
11:47 < BlueMatt> in lightning (and other related payment channel-y systems) you have the general issue of pre-signing transactions
11:48 < BlueMatt> so you have to predict what the feerate on the network will be in the future at the time your counterparty misbehaves
11:48 < wumpus> #topic pre-signing transactions (BlueMatt)
11:48 < BlueMatt> this is....obviously insane
11:48 < BlueMatt> instead, we'd (obviously) like to use cpfp
11:48 < BlueMatt> but there are the cpfp rbf-pinning-ish issues where your counterparty can fill up the package with big-bug-low-ish-feerate txn
11:48 < BlueMatt> so that you cant cpfp it yourself
11:49 < BlueMatt> I'd like to propose we tweak the cpfp/rbf rules
11:49 < BlueMatt> The last transaction which is added to a package of dependent transactions in the mempool must:
11:49 < BlueMatt>  * Have no more than one unconfirmed parent,
11:49 < BlueMatt>  * Be of size no greater than 1K in virtual size. 
11:49 < BlueMatt> (we'd, in practice, first decrease the package size limits by 1 1K-virtual-size transaction, then make it so that the last one must meet those rules)
11:49 < BlueMatt> this allows for cpfp by letting each side of a lightning channel independantly cpfp without considering what the other side may be doing
11:49 < provoostenator> Current RBF rules for reference: https://github.com/bitcoin/bips/blob/master/bip-0125.mediawiki#Implementation_Details
11:50 < BlueMatt> that may be too much to think about before reading the full ml post, but mostly it just covers background material
11:50 < BlueMatt>  /fin
11:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
11:50 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
11:50 < BlueMatt> (oh, also this fix requires package relay, which is another can of worms itself)
11:50 < sipa> here is another earlier proposed modification: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-February/015717.html
11:50 < sipa> BlueMatt: oh dear
11:51 < BlueMatt> well, luckily only one-deep package relay and only for small-ish packages
11:51 < BlueMatt> or at least small dependents
11:51 < instagibbs> sorry how does cpfp get pinned again?
11:51 < instagibbs> RBF pinning I know
11:52 < BlueMatt> instagibbs: A -> B where B is 100KB but low feerate, but high fee. its the same issue for lightning
11:52 < BlueMatt> cause you cant add to the package cause the package is max size
11:52 < instagibbs> ah
11:52 < sipa> my response to this is "eh... sure.... but how?"
11:52 < instagibbs> so it's not something you can attach B'
11:52 < BlueMatt> so you have to add to the package by rbf which means you have to increase total size, if you can even do that, which you'd have to tweak rbf rules to let you replace B with C, but you cant do that today
11:52 < BlueMatt> sipa: hmm?
11:52 < sipa> you need package relay...
11:53 < sipa> that's not just a small few-lines policy change
11:53 < provoostenator> An alternative, I forgot what the problem was, is to drop RBF rule "3. The replacement transaction pays an absolute fee of at least the sum paid by the original transactions." and only consider fee rate of the replacement, regardless of size.
11:53 < sdaftuar> so i think package relay is a whole other topic
11:53 < BlueMatt> I have another bitcoin-dev post coming discussing package relay, but we have a few options there, if we just want to solve package relay for contracting applications like lightning, we can do so with limited consideration, I think
11:53 < BlueMatt> if we want a more general solution I still think its possible but requires more in-depth ATMP refactoring
11:54 < sipa> and P2P changes...
11:54 < BlueMatt> assuming we do at least one of those two, this is a simple (I think) policy change that I'm hoping people here dont object to
11:54 < BlueMatt> possibly, though actaully not neccessarily
11:54 < BlueMatt> but, probably
11:54 < sipa> this sounds very preliminary to me
11:54 < BlueMatt> i presume you mean the package relay part?
11:54 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds]
11:54 < BlueMatt> the policy rule here is pretty straightforward, I think?
11:55 < BlueMatt> and not very preliminary, again assuming some form of package relay
11:55 < sipa> i don't understand how you can say it's not preliminary, while relying on something we have no idea about yet
11:55 < meshcollider> Shall we discuss next week instead after reading the ml
11:55 < gmaxwell> MAGIC
11:55 < BlueMatt> heh, sdaftuar and I have been batting package relay back and forth for months, but, whatever
11:56 < BlueMatt> agreed we need a harder proposal for package relay
11:56 < sdaftuar> well i think it'd be useful to layout the design goals for a package relay ssytem
11:56 < BlueMatt> anyway, yes, we'll discuss package relay on the ml and then come back to this
11:56 < sipa> BlueMatt: yes i'd like to see a proposal for that :)
11:56 < gmaxwell> BlueMatt: the point is that the policy change justification is a black box to us for the moment. :P
11:56 < BlueMatt> also what sdaftuar said
11:56 < BlueMatt> this is also a motivator for package relay
11:56 < BlueMatt> as its yet another thing to feed into the design goals
11:56 < BlueMatt> gmaxwell: I mean if you presume package relay it isnt at all a black box?
11:56 < BlueMatt> huh
11:57 < BlueMatt> anyway, -> ml
11:57 < provoostenator> Topic suggestion: dandelion stempool relay :-P
11:57  * sdaftuar hides
11:57 < BlueMatt> 4 minutes, GO
11:57 < BlueMatt> err, 3
11:57 < instagibbs> sdaftuar, you ahve 3 minutes to resolve it
11:58 < wumpus> #topic wallet maintainer
11:58 < wumpus> meshcollider has shown interest in becoming wallet maintainer!
11:59 < provoostenator> Awesome
11:59  * sipa offers condolences
11:59 < sipa> :)
11:59 < provoostenator> Anyoe against, no, done. End meeting :-)
11:59 < wumpus> which is great news, I think he'd be good at his, many of his his contributions have been to the wallet
11:59 < meshcollider> :)
11:59 < wumpus> and he's been active contributor for quite a while
12:00 < sipa> more seriously, sounds great to me
12:00 < achow101> +1
12:00 < wumpus> yes!
12:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qwuuibbgxkvitqiy] has joined #bitcoin-core-dev
12:00 < bitcoin-git> [bitcoin] vim88 opened pull request #14846: Docs: Adds development guidelines about Scripts shebang to developer-notes.md. (master...add_scripts_development_guidelines) https://github.com/bitcoin/bitcoin/pull/14846
12:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qwuuibbgxkvitqiy] has left #bitcoin-core-dev []
12:00 < wumpus> ok, that was a quick topic, was intending to bring it up sooner but BlueMatt kind of ninja'd it :)
12:00 < wumpus> #endmeeting
12:00 < lightningbot> Meeting ended Thu Nov 29 20:00:46 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:00 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-29-19.00.html
12:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-29-19.00.txt
12:00 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-29-19.00.log.html
12:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds]
12:01 < provoostenator> So have we figured out what a mainainter actually does? Shepharding PR's on the topic and some sort of super ACK?
12:01 -!- Jbaczuk [~Jbaczuk@ec2-18-237-204-133.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev
12:01 < meshcollider> I don't want a super ACK ;)
12:02 < provoostenator> By super ACK I mean that you would consider it reviewed by enough compentent people.
12:02 < wumpus> he decides when to merge the stuff
12:02 < provoostenator> More of a meta-ACK
12:02 < BlueMatt> no, definitely no such thing as super ack
12:02 < BlueMatt> super-concept-ack, though, yes :)
12:03 < wumpus> "consider it reviewed by enough compentent people", that's more or less the idea yes
12:03 < wumpus> understand the changes where possible
12:03 < provoostenator> That sounds good.
12:03 < wumpus> unless it's coin selection he opted out of that :)
12:03 < meshcollider> ^ lol
12:03 < achow101> coin selection? what's wrong with that?
12:04 < achow101> it's super simple and not at all hard to understand :p
12:04 < meshcollider> Trivial even :p
12:04 < provoostenator> You get a coin, you get a coin, everyone gets a coin!
12:04 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
12:04 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
12:04 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:04 < sipa> we'll just ask Bob who gets which coin
12:05 < BlueMatt> sipa: it was pointed out that the above policy doesnt, entirely rely on package relay - eg if you have a transaction A that you want to confirm, today, you pay a feerate that is reasonable for today and hope that that's enough to get confirmed later...well obviously if it isnt maybe you're still gonna meet the get-into-mempool limit even if not get-mined-limit
12:05 < BlueMatt> so its still a significant improvement over today
12:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:12 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
12:12 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
12:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:21 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
12:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:22 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
12:23 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
12:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:27 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Client Quit]
12:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
12:43 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
12:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
12:46 -!- Aaronvan_ is now known as AaronvanW
12:47 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
12:47 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
12:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:47 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has quit [Quit: Page closed]
12:47 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 250 seconds]
12:49 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
12:50 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
12:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
12:52 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
12:54 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has quit [Quit: rex4539]
12:55 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 250 seconds]
12:59 -!- marpme [5e865800@gateway/web/freenode/ip.94.134.88.0] has quit [Quit: Page closed]
13:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:03 < jnewbery> sorry, missed the end of the meeting, but big ACK for meshcollider being wallet maintainer 🎉
13:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
13:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:10 < meshcollider> jnewbery: thank you!
13:10 < luke-jr> [19:38:58] <provoostenator> 1. zero_conf_change_only (default: false) <-- that's too behaviour-specific IMO
13:13 < luke-jr> I can very well imagine the definition of trusted being revised in the future
13:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
13:19 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:20 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
13:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:22 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
13:24 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
13:24 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
13:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:25 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
13:25 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
13:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:27 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
13:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
13:35 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev
13:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:37 -!- mr_paz [~mr_paz@84.39.112.89] has quit [Ping timeout: 246 seconds]
13:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
14:02 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has joined #bitcoin-core-dev
14:13 < zallarak> Is there any sort of prioritization among open issues? I picked one up to start with, and now in finding the next one to work on, was wondering how to choose.
14:20 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Remote host closed the connection]
14:25 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 250 seconds]
14:27 < jnewbery> zallarak: any testing/review of PRs in 'high priority for review' is always appreciated: https://github.com/bitcoin/bitcoin/projects/8
14:28 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 268 seconds]
14:29 < hebasto> wumpus: hi, regarding #14409 "This absolutely needs testing in a functional test." Should I submit another PR for this functional test or should it be as another commit in the same PR?
14:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
14:29 < zallarak> jnewbery: excellent, will do.
14:29 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev
14:30 < jnewbery> hebasto: same PR please (so they can be reviewed and merged together)
14:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
14:31 < hebasto> jnewbery: ty
14:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:32 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev
14:35 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
14:36 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
14:36 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
14:37 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
14:39 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:42 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:42 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
14:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
14:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:45 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:47 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 250 seconds]
14:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
14:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
14:49 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
14:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
14:52 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:53 < moneyball> Here is the gist I created for weekly meeting topics #proposedmeetingtopic https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
14:54 < moneyball> Perhaps this link is pinned to the channel like the logs for easy access
14:54 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 246 seconds]
14:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:57 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
14:58 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:02 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
15:02 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
15:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:05 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Read error: Connection reset by peer]
15:05 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:06 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
15:06 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
15:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
15:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood]
15:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
15:11 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
15:11 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:12 < promag> meshcollider: congrats!
15:14 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
15:14 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
15:17 < meshcollider> promag: thank you!
15:17 < meshcollider> moneyball: +1 for pin
15:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
15:24 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
15:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 246 seconds]
15:26 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
15:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
15:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
15:27 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 264 seconds]
15:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:34 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev
15:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:37 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
15:37 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
15:37 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
15:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:38 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
15:38 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
15:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:40 -!- blackbear01 [407c4cfa@gateway/web/freenode/ip.64.124.76.250] has joined #bitcoin-core-dev
15:53 < gleb> Who I should ask to add me to that ping list at the beginning of the meeting? wumpus ? I keep coming one hour later... 
15:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:58 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
16:00 < gmaxwell> gleb: yes, wumpus.. though the reliable way to get in the list is to talk in the meetings.
16:00 < gmaxwell> :)
16:00 < gmaxwell> kinda circular, but I built the list originally based on who was talking in the meetings.
16:02 < gleb> gmaxwell: When I made it to the meeting at 10.55 today, I saw the last message and was excited for the Dandelion discussion but then...
16:02 < gleb> 11.55*, whatever
16:07 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
16:07 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
16:08 < meshcollider> gleb: there was no dandelion discussion, that was a last-5-minutes joke :p
16:08 < meshcollider> But the list does need an update, I have more names on the one I use for the wallet meeting
16:08 < meshcollider> I'll send it to wumpus in PM to avoid pinging everyone 
16:09 < gleb> meshcollider: I know it was a joke, I wish there was a discussion though :)
16:10 < meshcollider> Use steves new proposed topic tag then :D
16:13 < gleb> I better recall all the related challenges and potential solutions first... I'm wondering whether kanzure recorded the discussion in Tokyo :P
16:14 < gleb> meshcollider: I don't recall it being thoroughly discussed in ml or anywhere else where I can read it, but let me know if I'm wrong :)
16:15 < sipa> yeah, a summary of the issues discussed in tokyo would be great
16:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:21 < jnewbery> https://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/
16:21 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
16:21 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
16:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:23 < kanzure> dandelion was discussed.. but not in the group. so i wasn't there.
16:24 < kanzure> it was one of the smaller meeting rooms with like only 5 chairs
16:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:31 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
16:31 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
16:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:39 < Chris_Stewart_5> Yes, a lot of the discussion was around avoiding mempool duplication / segregating a mempool for dandelion
16:39 < Chris_Stewart_5> and privacy vulnerabilities that can be exposed by relay policies with your mempool
16:40 -!- _cryptodesktop_i [~John@91.245.77.21] has joined #bitcoin-core-dev
16:41 < sipa> plus bandwidth protection
16:41 < sipa> and especially the combination with unconfirmed dependencies is tricky
16:42 < Chris_Stewart_5> I believe sdaftuar has a write up of this some where... 
16:45 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
16:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:49 < Chris_Stewart_5> maybe not -- at least i can't dig it up.
16:51 -!- blackbear01 [407c4cfa@gateway/web/freenode/ip.64.124.76.250] has quit [Ping timeout: 256 seconds]
16:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
16:55 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
16:55 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
16:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:56 < Chris_Stewart_5> if anyone wants to take a stab at answering this loaded question ;) ttps://bitcoin.stackexchange.com/questions/81503/what-is-the-tradeoff-between-privacy-and-implementation-complexity-of-dandelion
16:57 < Murch> you're missing an h there. ;)
16:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:01 -!- grubles [~grubles@unaffiliated/grubles] has left #bitcoin-core-dev ["Leaving"]
17:01 < Murch> gmaxwell: Want to take that one? 0:-)
17:02  * sipa would like to see sdaftuar answer that
17:02 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
17:02 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
17:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:03 < sipa> i don't remember all the problems
17:03 < sipa> and suggested solutions
17:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:04 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
17:04 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
17:04 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:05 < Chris_Stewart_5> +1, or MarcoFalke 
17:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oaqxunaxrmoltbiq] has joined #bitcoin-core-dev
17:05 < bitcoin-git> [bitcoin] kallewoof opened pull request #14847: refactor: SHA256Autodetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
17:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oaqxunaxrmoltbiq] has left #bitcoin-core-dev []
17:05 < Chris_Stewart_5> since I believe he has the current implmentation in #13947
17:05 < gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub
17:05 < sdaftuar> oh man
17:06 < sdaftuar> "what is the hold up with implementing Dandelion in Bitcoin Core" <-- definitely a loaded question
17:06 < sdaftuar> but sure i'll take a stab at it
17:06 < sipa> yeah, the answer to that part is "it's not done" :)
17:08 -!- zallarak [47ca64ff@gateway/web/freenode/ip.71.202.100.255] has quit [Quit: Page closed]
17:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
17:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
17:15 -!- _cryptodesktop_i [~John@91.245.77.21] has quit [Ping timeout: 272 seconds]
17:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:18 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
17:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:41 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
17:41 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
17:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:45 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
17:45 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
17:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
17:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
17:59 -!- shesek [~shesek@5.22.134.170] has joined #bitcoin-core-dev
17:59 -!- shesek [~shesek@5.22.134.170] has quit [Changing host]
17:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
18:02 < sdaftuar> sipa: done
18:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
18:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
18:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
18:17 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
18:29 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
18:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
18:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pixondzjxcqphrtl] has joined #bitcoin-core-dev
18:34 < bitcoin-git> [bitcoin] kallewoof closed pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
18:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pixondzjxcqphrtl] has left #bitcoin-core-dev []
18:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
18:36 < kallewoof> wumpus / fanquake: #13258 has a lot of utACKs (5+, with most of them on latest commit id). Good to merge? I guess a tACK would be nice though..
18:36 < gribble> https://github.com/bitcoin/bitcoin/issues/13258 | uint256: Remove unnecessary crypto/common.h dependency by kallewoof · Pull Request #13258 · bitcoin/bitcoin · GitHub
19:03 -!- dxu_ [~dxu_@91.82.228.183] has joined #bitcoin-core-dev
19:03 -!- dxu_ [~dxu_@91.82.228.183] has quit [Remote host closed the connection]
19:09 < phantomcircuit> sdaftuar, "it's not done yet cause you haven't finished it, get working!"
19:10 < gwillen> has it ever been considered to do something about the "CCoinsView viewDummy;" pattern?
19:10 < gwillen> it's kind of gross and should really be doing something RAII, it seems like
19:12 < sipa> gwillen: suggestions welcome :)
19:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
19:37 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
19:38 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
19:44 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
19:44 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
19:54 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
19:55 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has quit [Remote host closed the connection]
19:55 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
20:00 -!- chenpo [~chenpo@2001-b011-5c0d-155a-84c8-2659-2395-4dc5.dynamic-ip6.hinet.net] has quit [Ping timeout: 268 seconds]
20:10 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
20:12 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
20:19 -!- chenpo [~chenpo@220-128-240-242.HINET-IP.hinet.net] has joined #bitcoin-core-dev
20:19 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
20:21 -!- chenpo [~chenpo@220-128-240-242.HINET-IP.hinet.net] has quit [Remote host closed the connection]
20:23 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has joined #bitcoin-core-dev
20:31 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
20:35 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Client Quit]
20:37 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has quit [Remote host closed the connection]
20:37 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has joined #bitcoin-core-dev
20:42 < gwillen> sipa: hmmm, ok, I'll have to see what I can come up with :-)
20:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
20:47 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:48 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
20:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
20:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
20:53 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20:56 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:25 -!- chenpo [~chenpo@125-227-20-139.HINET-IP.hinet.net] has quit [Remote host closed the connection]
21:33 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has joined #bitcoin-core-dev
21:38 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has quit [Remote host closed the connection]
21:42 < phantomcircuit> when running the raii tests 
21:42 < phantomcircuit> Test setup error: no test cases matching filter or all test cases were disabled
21:42 < phantomcircuit> any ideas?
21:42 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has joined #bitcoin-core-dev
21:46 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has quit [Remote host closed the connection]
21:46 < sipa> what is your command line?
21:53 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has joined #bitcoin-core-dev
22:00 < phantomcircuit> sipa, just make check
22:00 < sipa> huh
22:00 < sipa> are those tests dependent on some compile flag?
22:25 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Ping timeout: 250 seconds]
22:26 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
22:44 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Remote host closed the connection]
22:45 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev
22:46 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
22:46 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
22:58 -!- hashist [~hashist@157.157.113.25] has quit [Read error: Connection reset by peer]
23:01 -!- hashist [~hashist@157.157.113.25] has joined #bitcoin-core-dev
23:03 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds]
23:05 -!- sakalli_ [~Mutter@mobile-access-bcee3d-44.dhcp.inet.fi] has joined #bitcoin-core-dev
23:08 -!- sakalli_ [~Mutter@mobile-access-bcee3d-44.dhcp.inet.fi] has quit [Client Quit]
23:10 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 260 seconds]
23:11 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
23:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jtmdqnyoukgzkebv] has joined #bitcoin-core-dev
23:11 < bitcoin-git> [bitcoin] kallewoof closed pull request #14847: refactor: SHA256AutoDetect dead stores (master...20181129-sha256autodetect-deadstores) https://github.com/bitcoin/bitcoin/pull/14847
23:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jtmdqnyoukgzkebv] has left #bitcoin-core-dev []
23:11 < phantomcircuit> sipa, i didn't think so
23:12 < kallewoof> they're conditional for EVENT_SET_MEM_FUNCTIONS_IMPLEMENTED
23:13 < kallewoof> which is defined to be def'd if the event_set_mem_functions() function is available
23:13 < kallewoof> which it sometimes isn't
23:13 < kallewoof> phantomcircuit: ^
23:13 < phantomcircuit> kallewoof, huh
23:14 < kallewoof> https://github.com/kallewoof/bitcoin/commit/95f97f4b94b9d534cf61c3c82ff728eff00423e5
23:14 < kallewoof> meant https://github.com/bitcoin/bitcoin/commit/95f97f4b94b9d534cf61c3c82ff728eff00423e5
23:14 < phantomcircuit> oh i see
23:15 < kallewoof> Issue is https://github.com/bitcoin/bitcoin/issues/9493
23:19 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
23:19 -!- indistylo [~indistylo@49.204.67.58] has joined #bitcoin-core-dev
23:28 < phantomcircuit> kallewoof, yeah that broke the tests when it's not there lol
23:28 < phantomcircuit> which i guess is sort of better?
23:28 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
23:28 < kallewoof> phantomcircuit: I'm a bit confused. Are you getting an error from just typing "make check"?
23:29 < phantomcircuit> kallewoof, yes, it's complaining about there being no tests in the test
23:30 < phantomcircuit> kallewoof, it's cause the test is being run by ./src/test/test_bitcoin
23:30 < phantomcircuit> but isn't actually there
23:30 < sipa> we should just ignore that error
23:30 < sipa> if possihle
23:31 < kallewoof> huh, i see it now
23:31 < phantomcircuit> the test file should just be removed by the autoconf stuff
23:31 < phantomcircuit> when EVENT_SET_MEM_FUNCTIONS_IMPLEMENTED isn't defined
23:31 < phantomcircuit> but like
23:31 < phantomcircuit> autoconf magic so i cant help
23:32 < sipa> how can it delete a file?
23:32 < sipa> it shoulrn't modify your sourcr code
23:32 < phantomcircuit> sipa, autoconf can remove it from the make file
23:33 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
23:39 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
23:40 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
23:43 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has quit [Remote host closed the connection]
23:46 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has joined #bitcoin-core-dev
23:54 -!- chenpo [~chenpo@60-250-236-43.HINET-IP.hinet.net] has quit [Remote host closed the connection]
23:58 -!- chenpo [~chenpo@125-227-16-37.HINET-IP.hinet.net] has joined #bitcoin-core-dev
--- Log closed Fri Nov 30 00:00:38 2018