--- Log opened Fri Dec 14 00:00:48 2018 --- Day changed Fri Dec 14 2018 00:00 -!- chenpo [~chenpo@2001-b011-2012-10ec-149a-30fc-7b37-855e.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 00:09 < fanquake> Is anyone able to successfully compile on macOS with --with-sanitizers=thread ? 00:11 < fanquake> Seeing issues when compiling libbitcoinconsensus.la, output here: https://gist.github.com/fanquake/79a9a12286d3cd2e4cb961c32a32dee3 00:13 < fanquake> Also sipa, the new RNG changes build on macOS, but are failing on the thread sanitizer travis job: https://travis-ci.org/bitcoin/bitcoin/jobs/467863069 00:13 -!- TheCharlatan [~TheCharla@109.236.87.57] has quit [Read error: Connection reset by peer] 00:14 -!- TheCharlatan [~TheCharla@109.236.87.57] has joined #bitcoin-core-dev 00:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:20 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 00:22 -!- TheCharlatan [~TheCharla@109.236.87.57] has quit [Read error: Connection reset by peer] 00:22 -!- TheCharlatan [~TheCharla@109.236.87.57] has joined #bitcoin-core-dev 00:23 < gwillen> fanquake: I ran into something like this, it's hard to recall the details but I think they may be in scrollback here 00:24 < gwillen> IIRC, the resolution in my case is that OS X libtool is somewhat elderly and was stripping linker flags it didn't recognize, inappropraitely 00:27 -!- bitcoinjunior [~bitcoinju@87.101.92.100] has quit [Ping timeout: 250 seconds] 00:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 00:27 < gwillen> you can force libtool to pass through a flag by changing "-fblahblah" to "-XCClinker -fblahblah", or something to that effect 00:27 < gwillen> (see https://www.gnu.org/software/libtool/manual/html_node/Link-mode.html) 00:28 < gwillen> I think you have to do that with -fsanitizer, assuming you're hitting the same issue I was 00:28 < gwillen> which I faintly suspect you are because it's awfully similar 00:29 < wumpus> so the reason that historical release notes are committed directly is that it is part of a long list of steps around a release, and other steps rely on it, for example creating a release on github has a link to the historical release notes in git which then need to have been committed; it's also simply a copy operation 00:29 < fanquake> gwillen thanks, I'll check it out this arvo 00:30 < gwillen> np, good lfuck 00:30 < gwillen> er... luck* 00:30 -!- ppisati [~ppisati@net-93-71-1-61.cust.vodafonedsl.it] has quit [Quit: leaving] 00:30 < wumpus> doesn't seem very useful to create a PR then as there's nothing to review, it's simply more work 00:34 -!- JackH [~laptop@host86-175-127-233.range86-175.btcentralplus.com] has quit [Ping timeout: 268 seconds] 00:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-actwclkyxwfjuprc] has joined #bitcoin-core-dev 00:37 < bitcoin-git> [bitcoin] kallewoof closed pull request #13430: use IsBlockPruned() where appropriate (master...use-isblockpruned) https://github.com/bitcoin/bitcoin/pull/13430 00:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-actwclkyxwfjuprc] has left #bitcoin-core-dev [] 00:38 -!- ppisati [~ppisati@net-2-35-7-108.cust.vodafonedsl.it] has joined #bitcoin-core-dev 00:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 00:41 -!- miknotauro [~miknotaur@201.114.143.145] has quit [Ping timeout: 250 seconds] 00:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dqvmjlsdhkjlfsru] has joined #bitcoin-core-dev 00:42 < bitcoin-git> [bitcoin] kallewoof closed pull request #14774: interface/wallet: get rid of missing initializer warnings (master...suppwarn-empty-constructor) https://github.com/bitcoin/bitcoin/pull/14774 00:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dqvmjlsdhkjlfsru] has left #bitcoin-core-dev [] 00:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 00:44 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has quit [Quit: rex4539] 00:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds] 00:51 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 00:53 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 00:53 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 01:00 -!- chenpo [~chenpo@2001-b011-2012-10ec-149a-30fc-7b37-855e.dynamic-ip6.hinet.net] has quit [] 01:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oprgsusbzhohnhfm] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] laanwj reopened pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919 01:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oprgsusbzhohnhfm] has left #bitcoin-core-dev [] 01:09 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 01:10 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 01:11 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 250 seconds] 01:19 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev 01:30 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 01:33 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev 01:34 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has quit [Client Quit] 01:34 -!- aelxsam [3a98c470@gateway/web/freenode/ip.58.152.196.112] has quit [Quit: Page closed] 01:35 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:35 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev 01:37 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 01:41 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:47 -!- miknotauro [~miknotaur@201.114.143.145] has joined #bitcoin-core-dev 01:47 -!- miknotauro [~miknotaur@201.114.143.145] has quit [Remote host closed the connection] 01:58 < fanquake> wumpus I've used GH's new (beta) issue "pinning" feature to pin #14902 & #14438 to the top of the issues page. Let me know if you object/can think of a third issue to add. 01:58 < gribble> https://github.com/bitcoin/bitcoin/issues/14902 | v0.17.1 testing · Issue #14902 · bitcoin/bitcoin · GitHub 01:58 < gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub 01:58 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 01:58 < fanquake> I feel having the current testing issue, and release schedule pinned at the top can makes sense 01:59 < fanquake> If anything maybe it'll draw more attention to testing rc1 02:05 -!- ChA1NsAw [~ChA1NsAw@77.243.191.202] has joined #bitcoin-core-dev 02:12 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has quit [Quit: rex4539] 02:13 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:15 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:21 -!- ChA1NsAw [~ChA1NsAw@77.243.191.202] has quit [Ping timeout: 250 seconds] 02:23 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:24 < wumpus> fanquake: makes sense, I think this is enough 02:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:36 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 02:37 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 02:44 -!- wxss [~user@211.197.11.6] has joined #bitcoin-core-dev 02:45 -!- wxss [~user@211.197.11.6] has quit [Client Quit] 02:47 < wumpus> so effectively (#14948), the unit tests can only run now with a filesystem locale that supports fancy unicode characters, which is not the default on BSD; this wa already the case for the Python tests 02:47 < gribble> https://github.com/bitcoin/bitcoin/issues/14948 | Error when running gmake check on NetBSD 8.0 · Issue #14948 · bitcoin/bitcoin · GitHub 02:49 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 02:49 < wumpus> it's somewhat annoying but also understandable, I don't think anyone *intends* to run a pure ASCII locale and only support ASCII filenames on the other hand the assumption that the locale always matches UTF-8 might be incorrect 02:52 < wumpus> (or is always able to represent all unicode characters) 02:55 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Remote host closed the connection] 02:59 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 03:04 < fanquake> wumpus got to have wallet names/dirs full of emojis 03:08 < wumpus> U+1F45B.dat 03:08 < fanquake> heh 03:08 < wumpus> that makes me wonder, though, how does git handle filenames with emojis, would it refuse to check out the tree on those platforms? 03:11 < wumpus> or what about programs such as firefox? is "ignore the filesystem locale and assume it's always UTF-8" valid behavior for modern software? 03:14 < fanquake> wumpus we shall know shortly https://github.com/fanquake/fictional-giggle 03:16 < promag> nice wallet fanquake 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ljrkflpzeokmyfpq] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] AkioNak closed pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ljrkflpzeokmyfpq] has left #bitcoin-core-dev [] 03:17 < fanquake> promag thanks 03:18 < fanquake> wumpus this is the result of a clone https://gist.github.com/fanquake/4bcd4c3b09958d1a709f97084fbda329 03:18 -!- wxss [~user@211.197.11.6] has joined #bitcoin-core-dev 03:18 < promag> not so pretty now 03:19 -!- wxss [~user@211.197.11.6] has quit [Client Quit] 03:36 < wumpus> it changes the unknown unicode character to literal '????' oh my 03:38 < wumpus> at least that's different from boost's handling which is to fail the conversion, not sure what's better... 03:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:51 < promag> disallow that madness? 03:52 < wumpus> like what? reject non-utf locales at startup? 03:53 < wumpus> I mean, I guess ASCII file system locale simply works as long as you don't try to use non-ASCII characters in filenames 03:53 < wumpus> which might be fine for English/US people 03:54 < promag> I don't know, but it's a headache having wallet names from the filename 03:55 < wumpus> that's why I wondered how other software handles this, but replacing iwht ???? doesn't seem that useful either... 03:57 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 03:58 < promag> yeah, comes from "what the heck???? are you mad?" 03:58 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 04:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-igvsknzsawexyyng] has joined #bitcoin-core-dev 04:01 < bitcoin-git> [bitcoin] promag opened pull request #14958: qa: Remove race between conneting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958 04:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-igvsknzsawexyyng] has left #bitcoin-core-dev [] 04:05 < wumpus> seems the options are https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-447305576 04:14 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Quit: laurentmt] 04:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:46 -!- Giszmo [~leo@ip-125-234-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 04:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 05:04 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 05:20 -!- ChA1NsAw [~ChA1NsAw@77.243.191.202] has joined #bitcoin-core-dev 05:52 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 05:52 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 06:02 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 06:05 -!- riemann [~riemann@217.96.174.198.ipv4.supernova.orange.pl] has quit [Ping timeout: 268 seconds] 06:23 -!- bralyclow2 [~bralyclow@195.242.213.148] has joined #bitcoin-core-dev 06:23 -!- bralyclow2 [~bralyclow@195.242.213.148] has quit [Client Quit] 06:24 -!- Giszmo [~leo@ip-125-234-219-201.nextelmovil.cl] has quit [Ping timeout: 240 seconds] 06:27 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:57 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 250 seconds] 06:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds] 07:00 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:01 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 07:06 -!- TheRec [toto@84-72-172-79.dclient.hispeed.ch] has joined #bitcoin-core-dev 07:06 -!- TheRec [toto@84-72-172-79.dclient.hispeed.ch] has quit [Changing host] 07:06 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 07:07 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 07:13 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Ping timeout: 250 seconds] 07:24 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [] 07:24 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev 07:40 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 07:40 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 07:40 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ckgzwvuwqumkyaqy] has joined #bitcoin-core-dev 07:44 < bitcoin-git> [bitcoin] luke-jr opened pull request #14960: lint/format-strings: Correctly exclude escaped percent symbols (master...bugfix_lint_fmtstr) https://github.com/bitcoin/bitcoin/pull/14960 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ckgzwvuwqumkyaqy] has left #bitcoin-core-dev [] 07:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:47 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 07:47 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 07:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:53 -!- Giszmo [~leo@168.196.201.249] has joined #bitcoin-core-dev 07:54 < jnewbery> luke-jr: https://github.com/bitcoin/bips/pull/745 is ready for merge 07:59 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 08:00 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 08:03 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 08:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 08:13 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Ping timeout: 250 seconds] 08:18 -!- TX1683 [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev 08:26 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 268 seconds] 08:28 -!- JackH [~laptop@62.232.170.181] has quit [Ping timeout: 250 seconds] 08:40 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev 08:46 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 09:08 -!- JackH [~laptop@host86-175-127-233.range86-175.btcentralplus.com] has joined #bitcoin-core-dev 09:12 < BlueMatt> gmaxwell: I will do that today, that is a good point 09:14 < BlueMatt> errr, or make ryanofsky do it 09:14 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 09:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tdsggfnjgxsxcftd] has joined #bitcoin-core-dev 09:16 < bitcoin-git> [bitcoin] ch4ot1c closed pull request #14601: [rpc] Descriptions: Consistent arg labels for types 'object', 'array', 'boolean', and 'string' (master...fix/rpc-arg-types) https://github.com/bitcoin/bitcoin/pull/14601 09:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tdsggfnjgxsxcftd] has left #bitcoin-core-dev [] 09:25 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 09:30 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 09:35 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has quit [Ping timeout: 245 seconds] 09:46 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 09:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 09:59 -!- TX1683_ [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev 10:01 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Ping timeout: 250 seconds] 10:01 -!- TX1683_ is now known as TX1683 10:01 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 10:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 10:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uljnkbtbeyhhwflp] has joined #bitcoin-core-dev 10:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7a30e0f6c544...b53573e5c6c7 10:03 < bitcoin-git> bitcoin/master faa8311 MarcoFalke: Revert "tests: Support calling add_nodes more than once"... 10:03 < bitcoin-git> bitcoin/master fa4b8c9 MarcoFalke: test: add_nodes can only be called once after set_test_params 10:03 < bitcoin-git> bitcoin/master b53573e MarcoFalke: Merge #14951: Revert "tests: Support calling add_nodes more than once"... 10:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uljnkbtbeyhhwflp] has left #bitcoin-core-dev [] 10:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dvcefvkluypcykoe] has joined #bitcoin-core-dev 10:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14951: Revert "tests: Support calling add_nodes more than once" (master...Mf1812-TestrevertAddNodes) https://github.com/bitcoin/bitcoin/pull/14951 10:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dvcefvkluypcykoe] has left #bitcoin-core-dev [] 10:06 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:07 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 10:14 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection] 10:31 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 10:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:34 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:45 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 10:48 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:48 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has joined #bitcoin-core-dev 10:48 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:50 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has joined #bitcoin-core-dev 10:53 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has quit [Ping timeout: 250 seconds] 10:54 < jnewbery> is today a wallet meeting day? 10:54 < instagibbs> yes 10:54 < sipa> yes 10:56 < provoostenator> Indeed, it's that time of the fortnight. 10:57 -!- Giszmo [~leo@168.196.201.249] has quit [Quit: Leaving.] 10:58 < jnewbery> you're right, it has been fourteen nights since the last wallet meeting 10:59 < sipa> might i add that in fact 336 hours have passed since our last colloquium on these matters 10:59 < meshcollider> lol 11:01 < meshcollider> sipa: want to host it? Or shall I 11:01 < gwillen> wait wait... is "fortnight" from "fourteen" 11:01 < gwillen> this feels obvious now but I had no idea 11:01 < sipa> meshcollider: go ahead 11:01 < meshcollider> #startmeeting 11:01 < lightningbot> Meeting started Fri Dec 14 19:01:42 2018 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:01 < sipa> gwillen: i always assumed that it did 11:02 < jnewbery> feowertyne niht 11:02 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 11:02 < meshcollider> Ok topics? 11:02 < kanzure> hi. 11:02 < jnewbery> high priority for review? 11:02 < sipa> yay, some stuff got merged 11:03 < instagibbs> yes yay 11:03 < provoostenator> Probably topics: 11:03 < jnewbery> #14565 is wallety 11:03 < provoostenator> 1. progress towards descriptor wallets 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub 11:03 < provoostenator> 2. progrress towards hardware wallets 11:03 < jnewbery> #11082 isn't wallety, but is blocking provoostenator's wallety PRs 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub 11:04 < achow101> hi 11:04 < meshcollider> #topic high priority 11:04 < provoostenator> jnewbery: it's blocking my future walety PR's (once I start on the GUI side of hardware wallets) 11:05 < meshcollider> jnewbery: they are both already on the list right 11:05 < provoostenator> Correct 11:05 < jnewbery> 14565 looks good. It was missing tests, but now looks pretty well covered (thanks sipa!) 11:05 < jnewbery> yes, both there already: https://github.com/bitcoin/bitcoin/projects/8 11:06 < provoostenator> Once that's in, I would say #14491 become priority. 11:06 < meshcollider> Yes 14565 is very nearly ready I think 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 11:06 < jnewbery> reminder that 14565 blocks PRs from meshcollider and achow101, so it'd be nice to move it towards merge 11:07 < meshcollider> Yes 11:08 < meshcollider> I had one last little question on there 11:09 < meshcollider> Is there anything else wallet related that should go onto high priority list now? 11:10 < meshcollider> #topic progress towards descriptor wallets (provoostenator) 11:10 * provoostenator looks as sipa 11:10 < provoostenator> *at 11:10 * sipa stares back 11:11 < instagibbs> various descriptor support, like in listunspent? 11:11 < meshcollider> sipa: have you thought more about it recently or been mostly focused on the PRNG stuff 11:11 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has quit [Ping timeout: 246 seconds] 11:11 < sipa> meshcollider: no, sorry - i've been busy with a few other projects 11:12 < meshcollider> that's fine of course :) I guess that is your update provoostenator 11:12 < meshcollider> There was an issue tracking which RPCs to add descriptor support to iirc 11:12 < provoostenator> Well, I'd like to know what's next, but we do have enough review work already I guess. 11:13 < sipa> next step is moving IsMine and related functions to be part of the wallet or some other abstraction, rather than free functions 11:13 < sipa> so they can later be extended to be descriptor based 11:13 < provoostenator> Ok 11:13 < provoostenator> Anything about the Keypool we can improve? 11:13 < meshcollider> I can take a stab at the ismine stuff 11:14 < sipa> that needs to be part of the same interface, i expect 11:14 < provoostenator> For example I'm a bit worried about #14075 interacting with the keypool from RPC code. 11:14 < sipa> but maybe a later step 11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub 11:14 < sipa> that looks like it may interact, indeed 11:14 < provoostenator> Though it can be refactored after that, it's nice if we at least have an idea of what the final thing needs to look like. 11:15 < meshcollider> So instead of the keypool being generated by a single descriptor, it will have imports in it too 11:15 < provoostenator> Right now the keypool, when it expands itself, makes strong assumptions about the wallet and just uses the HD structure. 11:16 < provoostenator> Whereas what we want probably is for the keypool (or something like it) to expand a specific descriptor. 11:16 < sipa> well there won't be a keypool anymore 11:16 < sipa> it's just a descriptor, which some entries cached, and some not (yet) 11:17 < sipa> the hard part is integrating the existing logic into such a structure 11:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bwlsclapunoofjug] has joined #bitcoin-core-dev 11:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b53573e5c6c7...6723d8e3a694 11:17 < bitcoin-git> bitcoin/master fa30a0e MarcoFalke: test: mempool_persist: Verify prioritization is dumped correctly 11:17 < bitcoin-git> bitcoin/master 6723d8e MarcoFalke: Merge #14931: test: mempool_persist: Verify prioritization is dumped correctly... 11:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bwlsclapunoofjug] has left #bitcoin-core-dev [] 11:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pgsrtvinkwbpfwxm] has joined #bitcoin-core-dev 11:17 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14931: test: mempool_persist: Verify prioritization is dumped correctly (master...Mf1812-testMempoolPrio) https://github.com/bitcoin/bitcoin/pull/14931 11:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pgsrtvinkwbpfwxm] has left #bitcoin-core-dev [] 11:18 < provoostenator> Any prose or pseudo-code describing how such integration would work is most welcome (in a Github issue). 11:18 < sipa> i think we'll want to see the existing keypool/keys/... as a special "legacy" descriptor that doesn't really have a text representation 11:19 < meshcollider> sipa: to cache them, would you expand() them with the cache function during the existin topup function 11:19 < sipa> meshcollider: right, exactly 11:19 < provoostenator> Why wouldn't it have a text representation? 11:20 < sipa> provoostenator: well the text representation is the entire set of keys, pubkeys, scripts, hdpaths, ... that are currently stored in the wallet :) 11:20 < sipa> i guess you could dump it in hex or something 11:20 < provoostenator> A migration wizard should be able to, at least for standard wallets, turn that into a series of regular descriptors no? 11:21 < sipa> that may be possible, but i don't think that's the priority now 11:21 < meshcollider> It'd be quicker and safer to just move-only the code type of thing into legacy functions 11:21 < sipa> (because then you have to worry about all existing RPCs, and their effect on those descriptors) 11:22 < provoostenator> Right, just depends on what's easier in practice. Personally I suspect it'll be easier to make the wallet _only_ have descriptors, just from a writing tests point of view. 11:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oygdvfzirbzsfonr] has joined #bitcoin-core-dev 11:22 < sipa> i think it's not too much work to just have a legacy subsystem, and a new system - and a wallet can contain just one of them, or both 11:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6723d8e3a694...9133227298ad 11:22 < bitcoin-git> bitcoin/master c84c2b8 practicalswift: tests: Test for expected return values when calling functions returning a success code 11:22 < bitcoin-git> bitcoin/master 9133227 MarcoFalke: Merge #14935: tests: Test for expected return values when calling functions returning a success code... 11:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oygdvfzirbzsfonr] has left #bitcoin-core-dev [] 11:22 < provoostenator> But the RPC thing could be a pain yes. 11:22 < sipa> maybe we even want to forbid mixing them in one wallet 11:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gubqtmoanhfvywma] has joined #bitcoin-core-dev 11:23 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935 11:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gubqtmoanhfvywma] has left #bitcoin-core-dev [] 11:23 < sipa> but forced migration may getting it accepted much harder 11:23 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 11:23 < sipa> so my idea is that every record is a descriptor + some metadata (like gap limit, whether it's change or no), plus some cached keys... and there can be a special "legacy" record that's just all the existing keypool/ismine logic 11:24 < phantomcircuit> the rw config is mostly because the qt stuff writes to random places for settings right? 11:24 < provoostenator> So then you might end up with two seperate wallet systems and a migration tool, where the old system only gets maintenance updates to be able to read from it. 11:24 < luke-jr> phantomcircuit: random? not really; just different from bitcoind 11:24 < sipa> provoostenator: maybe 11:24 < phantomcircuit> luke-jr, i mean it writes to reg on windows 11:24 < phantomcircuit> which is super annoying to change 11:24 < sipa> phantomcircuit: please stick to topic 11:24 < meshcollider> phantomcircuit: we are in a wallet meeting btw :) 11:26 < meshcollider> We could open an issue to discuss the alternative approaches, or just discuss which is easier as we start actually writing the code 11:26 < provoostenator> A new wallet subsystem might also let us cleanly long-term deprecate some wallet RPC methods and replace them with clean ones, that happen to support descriptors? 11:26 < sipa> provoostenator: yup 11:26 < provoostenator> And maybe move to Sqlite3 at the same time. 11:26 < sipa> i think that's completely orthogonal 11:26 < provoostenator> Could be, yes. 11:27 < luke-jr> phantomcircuit: I answered in #bitcoin fyi 11:28 < provoostenator> Anyway, we have some next actions now to continue progress, maybe next topic? 11:28 < meshcollider> #topic progress towards hardware wallets (provoostenator) 11:28 < jnewbery> IsMine moved from wallet to common here: https://github.com/bitcoin/bitcoin/commit/a25a4f5b04c3e045557e9e7e807b2af74ad75128 . Was that just because of the way the multisig and P2SH tests are constructed (ie could those tests just be rewritten)? 11:28 < provoostenator> Now that #14491 has been rebased, the `hww` branch I'm building off should also soon be rebased. 11:28 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 11:29 < provoostenator> #14912 11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub 11:29 < provoostenator> I'll do some cleaning up of my ugly string concatenation descriptor code after rebase. 11:29 < provoostenator> People can already test it though. It compiles and actually works (at your own risk, so use testnet). 11:30 < meshcollider> jnewbery: looks like it? 11:30 < provoostenator> As in, you can create a new wallet, put read-only keys in it, show address on the device and spend coins. Using achow101's HWI library to talk to the device. 11:31 < provoostenator> So the idea is that users would download that library seperately and just launch bitcoind -signer=../HWI/hwi.py (or some other tool). That way we don't ahve to review individual hardware wallet code. 11:31 < meshcollider> provoostenator: cool \o/ 11:32 < provoostenator> With very little code changes this could also work against a gRPC server, but there's some security trade-offs compared to calling commands. We talked about that a few weeks ago. 11:33 < provoostenator> I am trying to keep it generic enough to keep that possible, so e.g. the -signer= command could later also be a URL. But for now, it just executes a command and parses the JSON that command spits out to stdout. 11:34 < provoostenator> Next step for me is to work on GUI support for this. But there's already a pile of prerequisite stuff to review, so don't worry too much about that :-) 11:34 < provoostenator> I personally just like to see the big picture in action. 11:34 < meshcollider> Yes let's not stack too many PRs at once again ;) 11:35 < provoostenator> For GUI proof of concept I'd just like to nag promag about #13100, which we want anyway. 11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub 11:36 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:36 < provoostenator> (that's all I have) 11:37 < MarcoFalke> wget https://bitcointools.jonasschnelli.ch/data/builds/914/ ... failed: Connection refused 11:37 < meshcollider> that PR hasn't been rebased for 2 months, perhaps you'd like to take it up and rebased it yourself? 11:37 < MarcoFalke> ^ jonasschnelli 11:38 < provoostenator> He actually said he's working on it soon. 11:38 < meshcollider> Oh ok 11:38 < provoostenator> I think he needs this to go in first #14573, that's almost mergeable. 11:38 < meshcollider> I'm happy to review it as soon as its ready, its already tagged for 0.18 11:38 < gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub 11:39 < meshcollider> Are there any other topics? 11:40 < provoostenator> luke-jr phantomcircuit did you want to discuss rw_config stuff? 11:40 < provoostenator> I noticed the rabase, so I'll rebase my Settings migration stuff as well. 11:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zpelbwdefmznqqiw] has joined #bitcoin-core-dev 11:40 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #14961: [docs] Root readme improvements (master...improvements/readme) https://github.com/bitcoin/bitcoin/pull/14961 11:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zpelbwdefmznqqiw] has left #bitcoin-core-dev [] 11:40 < provoostenator> But it's not very wallety. 11:41 < meshcollider> Looks like that might be it for today 11:41 < meshcollider> Thanks provoostenator :) 11:41 < meshcollider> #endmeeting 11:41 < lightningbot> Meeting ended Fri Dec 14 19:41:51 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:41 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-12-14-19.01.html 11:41 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-12-14-19.01.txt 11:41 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-12-14-19.01.log.html 11:42 < jnewbery> good colloquium! 11:43 < provoostenator> By the way, it would be nice if bitcoincore.org and such sites could link to the IRC logs. Many places now point to BotBot and Google can't find these other URLs either. 11:43 < provoostenator> jnewbery: splendit! 11:43 < jnewbery> I expect some/most people won't be around for the next scheduled one (Dec 28th) 11:43 < provoostenator> 35C3 11:43 < jnewbery> I almost certainly won't be online for it 11:44 < provoostenator> Maybe bump that, and thus the whole schedule, by one week? 11:44 < luke-jr> might make sense to cancel meetings during Christmas 11:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 11:44 < sipa> provoostenator: will you be at 35c3? 11:45 < jnewbery> provoostenator: aj was looking at uploading the IRC logs onto bitcoincore.org every week. Not sure what the progress is on that. 11:45 < provoostenator> That also moves closer to new moon. 11:45 < provoostenator> sipa: I can neither confirm nor deny that :-) 11:53 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 11:53 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 11:54 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 11:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 11:55 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 11:55 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 11:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:56 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Read error: Connection reset by peer] 11:57 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 11:59 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 12:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:01 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 12:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:02 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 12:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 12:03 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has quit [Ping timeout: 244 seconds] 12:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:11 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 12:11 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 12:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 12:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:13 -!- riemann_ [~riemann@217.96.159.135.ipv4.supernova.orange.pl] has quit [Quit: Leaving] 12:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:21 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zdtsjxrnyykgdfpf] has joined #bitcoin-core-dev 12:22 < bitcoin-git> [bitcoin] DrahtBot closed pull request #13200: Process logs in a separate thread (master...2018-05-asynclog) https://github.com/bitcoin/bitcoin/pull/13200 12:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zdtsjxrnyykgdfpf] has left #bitcoin-core-dev [] 12:23 -!- michaels_ [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev 12:28 -!- michaels_ [~michaelsd@208.59.170.5] has quit [Ping timeout: 246 seconds] 12:29 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 12:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:32 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Client Quit] 12:32 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 12:32 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 12:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:49 -!- chenpo [~chenpo@220-136-78-105.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 12:50 < instagibbs> how are subtrees updated? The linter logic is looking for a template of a commit style, I presume generated by a script? 12:50 < instagibbs> Can't find resource in contributor docs 12:52 < sipa> git subtree update :p 12:53 < sipa> git subtree merge --squash, actually 12:54 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 12:56 < instagibbs> after a few hours of course I find the answer as soon as I ask via google :) 12:56 < instagibbs> need CSV on my irc questions 12:57 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 12:57 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has joined #bitcoin-core-dev 13:00 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has joined #bitcoin-core-dev 13:02 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has quit [Ping timeout: 240 seconds] 13:05 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 250 seconds] 13:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 13:25 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 13:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 13:27 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 13:27 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 13:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:29 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 13:33 < sipa> anyone know why https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/21022194 (#14955) is failing? 13:33 < gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub 13:34 < sipa> (i've restarted it 3 times, same error each time) 13:35 -!- chenpo [~chenpo@220-136-78-105.dynamic-ip.hinet.net] has quit [] 13:50 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 13:58 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has quit [Ping timeout: 250 seconds] 13:59 < sipa> gmaxwell: using sha256d4 (or even simple sha256) in the rng code would require the sha256 to auto-initialize on first use rather than using a dedicated initialize function 14:01 < sipa> that doesn't seem too hard (c++11 has std::call_once for exactly that purpose), but maybe more than we want in one PR 14:02 < gmaxwell> oh damn, we need some init crap to sniff hardware support. 14:02 < gmaxwell> sipa: Well it could directly call the C version if not initilized. 14:06 < sipa> it's not hard to do 14:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aysvsjzrtofvxpzp] has joined #bitcoin-core-dev 14:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14963: doc: Add comment to cs_main and mempool::cs (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963 14:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aysvsjzrtofvxpzp] has left #bitcoin-core-dev [] 14:07 -!- fasefwef [d80de906@gateway/web/freenode/ip.216.13.233.6] has joined #bitcoin-core-dev 14:10 < sipa> std::call_once seems to take 2ns here 14:11 -!- fasefwef [d80de906@gateway/web/freenode/ip.216.13.233.6] has quit [Client Quit] 14:11 < sipa> that seems acceptable as an overhead to the SHA256 functions (it's equivalent to adding less than a byte of input on average) 14:11 < gmaxwell> well if we care about 2ns we could make the rng state hasher sha256, reduce the chained state size a little and get that time back, ... 14:12 < sipa> no, i don't mean for the RNG 14:12 < sipa> this would be overhead added to every invocation of SHA256 functions 14:13 < gmaxwell> oh. I was thinking you'd just put the call once in the rng functions ahead of the sha256d64 use. 14:13 < gmaxwell> but right okay, only half paying attention. 14:13 < sipa> that would... probably work 14:14 < sipa> an alternative is making sure no global constructors use the RNG 14:14 < sipa> that would have no overhead at all, but is pretty inconvenient for some things 14:14 < gmaxwell> it's also unfortunate that we couldn't make that compile-time fail. 14:15 < sipa> yes 14:16 < sipa> for the RNG itself, currently it's SHA512(new_entropy || previous_state), which is split into rng_output and next_state 14:16 < sipa> which means it's reducing to 256 bits of entropy after every extraction, for no go reason 14:17 < gmaxwell> well I like not keeping around the randomness we just output, it's a liability in memory. 14:17 < sipa> obviously 14:18 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 14:19 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 14:21 < gmaxwell> it seems kinda odd to me that we could end up with with two strenghteners going at once, but I think completely harmless. 14:21 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 14:21 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:22 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 14:23 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 14:23 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 14:30 -!- ChA1NsAw [~ChA1NsAw@77.243.191.202] has quit [Quit: Leaving] 14:34 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:34 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:41 -!- thoreg [54a1b2fb@gateway/web/freenode/ip.84.161.178.251] has joined #bitcoin-core-dev 14:42 -!- thoreg [54a1b2fb@gateway/web/freenode/ip.84.161.178.251] has quit [Client Quit] 15:07 -!- bbq [5f5bd038@gateway/web/freenode/ip.95.91.208.56] has joined #bitcoin-core-dev 15:08 -!- bbq [5f5bd038@gateway/web/freenode/ip.95.91.208.56] has left #bitcoin-core-dev [] 15:14 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev 15:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbhbvuolonhexnht] has joined #bitcoin-core-dev 15:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14964: test: Fix race in mempool_accept (master...Mf1812-testRaceMempoolAccept) https://github.com/bitcoin/bitcoin/pull/14964 15:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbhbvuolonhexnht] has left #bitcoin-core-dev [] 15:23 -!- kmels [~kmels@190.14.131.146] has quit [Ping timeout: 250 seconds] 15:27 -!- bralyclow [~bralyclow@195.242.213.119] has quit [] 15:33 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has joined #bitcoin-core-dev 15:34 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has joined #bitcoin-core-dev 15:38 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has quit [Ping timeout: 268 seconds] 15:39 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has quit [Ping timeout: 240 seconds] 15:45 -!- Tralfaz [~none@185.156.175.59] has quit [Ping timeout: 244 seconds] 15:46 -!- Tralfaz [~none@104.248.145.220] has joined #bitcoin-core-dev 15:48 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:51 -!- Tralfaz [~none@104.248.145.220] has quit [Quit: Leaving] 15:55 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 16:01 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 16:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds] 16:03 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 16:04 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 16:07 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:15 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 16:42 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:50 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has joined #bitcoin-core-dev 16:50 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has joined #bitcoin-core-dev 16:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:53 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 16:54 -!- bitcoinjunior [~bitcoinju@132.205.230.14] has quit [Ping timeout: 250 seconds] 16:58 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:02 < fanquake> bluematt If you or ryanofsky do test, can you add to this issue: #14902 17:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14902 | v0.17.1 testing · Issue #14902 · bitcoin/bitcoin · GitHub 17:03 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving] 17:03 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 17:07 -!- bitcoinsushi [~bitcoinju@87.101.92.100] has quit [Ping timeout: 268 seconds] 17:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wxmumskizqiirdet] has joined #bitcoin-core-dev 17:26 < bitcoin-git> [bitcoin] isghe opened pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965 17:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wxmumskizqiirdet] has left #bitcoin-core-dev [] 17:27 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 17:30 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:35 -!- anthraxx4 [~anthraxx@182-166-171-226f1.osk2.eonet.ne.jp] has joined #bitcoin-core-dev 17:35 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:35 -!- anthraxx4 [~anthraxx@182-166-171-226f1.osk2.eonet.ne.jp] has quit [Remote host closed the connection] 17:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 17:38 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 17:38 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 17:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 17:52 -!- duderonomy [~duderonom@p1343011-ipngn201007fukuokachu.fukuoka.ocn.ne.jp] has joined #bitcoin-core-dev 17:52 -!- duderonomy is now known as Guest98799 17:52 -!- Guest98799 [~duderonom@p1343011-ipngn201007fukuokachu.fukuoka.ocn.ne.jp] has quit [Remote host closed the connection] 18:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 18:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uwjywfbzikxhklnr] has joined #bitcoin-core-dev 18:13 < bitcoin-git> [bitcoin] 1Il1 opened pull request #14966: fix testmempoolaccept CLI syntax (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14966 18:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uwjywfbzikxhklnr] has left #bitcoin-core-dev [] 18:22 -!- Varunram [sid210151@gateway/web/irccloud.com/x-opoprpqfanjtzjgw] has quit [Ping timeout: 252 seconds] 18:24 -!- rhavar [uid237883@gateway/web/irccloud.com/x-tqmkgzqejhlysnul] has quit [Ping timeout: 252 seconds] 18:24 -!- rhavar [uid237883@gateway/web/irccloud.com/x-ovfmiyupohgxxerj] has joined #bitcoin-core-dev 18:24 -!- Varunram [sid210151@gateway/web/irccloud.com/x-eujzminnvuiivwbm] has joined #bitcoin-core-dev 18:38 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 18:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 250 seconds] 19:12 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 19:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:18 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 19:18 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 19:18 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:23 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 19:23 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 19:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:36 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 19:36 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 19:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:37 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 19:37 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 19:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 19:39 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 19:47 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com] 19:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:51 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 19:51 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 19:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:02 -!- shesek [~shesek@141.226.218.112] has joined #bitcoin-core-dev 20:02 -!- shesek [~shesek@141.226.218.112] has quit [Changing host] 20:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:03 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 20:05 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 20:06 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 20:18 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com] 20:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:38 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 20:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 21:16 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 21:52 -!- dRbiG13 [~dRbiG@88.135.237.236] has joined #bitcoin-core-dev 21:53 -!- dRbiG13 [~dRbiG@88.135.237.236] has quit [Remote host closed the connection] 22:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 22:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-klfzmvlrmatejshj] has joined #bitcoin-core-dev 22:37 < bitcoin-git> [bitcoin] laanwj closed pull request #14635: developer-notes: allow lowerCamelCase (master...pr/camelow) https://github.com/bitcoin/bitcoin/pull/14635 22:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-klfzmvlrmatejshj] has left #bitcoin-core-dev [] 22:46 < fanquake> Looks like #14935 broke the Travis build with TSAN enabled? 22:46 < gribble> https://github.com/bitcoin/bitcoin/issues/14935 | tests: Test for expected return values when calling functions returning a success code by practicalswift · Pull Request #14935 · bitcoin/bitcoin · GitHub 22:46 < fanquake> i.e #14967 22:46 < gribble> https://github.com/bitcoin/bitcoin/issues/14967 | TSAN issue in cuckoocache_erase_parallel_ok test after 14935 · Issue #14967 · bitcoin/bitcoin · GitHub 23:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vbayeetqqvvcgdcc] has joined #bitcoin-core-dev 23:05 < bitcoin-git> [bitcoin] laanwj opened pull request #14968: http: Fail initialization when any bind fails (master...2018_12_http_bind_error) https://github.com/bitcoin/bitcoin/pull/14968 23:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vbayeetqqvvcgdcc] has left #bitcoin-core-dev [] 23:22 -!- ebonit [2599e846@gateway/web/freenode/ip.37.153.232.70] has joined #bitcoin-core-dev 23:31 -!- ebonit [2599e846@gateway/web/freenode/ip.37.153.232.70] has quit [Quit: Page closed] 23:38 -!- deadpoet [~deadpoet@27.29.168.118] has joined #bitcoin-core-dev 23:38 -!- deadpoet [~deadpoet@27.29.168.118] has quit [Remote host closed the connection] 23:47 -!- ChA1NsAw [~ChA1NsAw@77.243.191.202] has joined #bitcoin-core-dev --- Log closed Sat Dec 15 00:00:52 2018