--- Log opened Mon Jan 14 00:00:20 2019 00:01 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 00:09 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 00:10 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 00:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 00:20 < booyah> fyi going to "http://bitcoin.sipa.be/depths.png" --> "Warning: Unsafe Website Blocked!" (I was redirected to http://warn.recursive.dnsbycomodo.com/?host=bitcoin.sipa.be ) 00:21 < booyah> and same thing for seed. 00:23 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 00:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:32 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 00:37 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 00:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 00:57 -!- guoguo [7c7f22a2@gateway/web/freenode/ip.124.127.34.162] has joined #bitcoin-core-dev 00:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 01:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:05 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds] 01:05 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds] 01:05 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 01:05 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 01:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:09 -!- rhavar [uid237883@gateway/web/irccloud.com/x-zqynynxiwzoizjxp] has quit [Quit: Connection closed for inactivity] 01:18 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:19 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:23 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 01:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:40 -!- guoguo [7c7f22a2@gateway/web/freenode/ip.124.127.34.162] has quit [Quit: Page closed] 01:41 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 250 seconds] 01:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 250 seconds] 01:41 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:46 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 01:48 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 01:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 01:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 02:02 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:02 -!- kexkey [~kexkey@87.101.92.74] has quit [Read error: Connection reset by peer] 02:16 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:18 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has joined #bitcoin-core-dev 02:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:36 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 02:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 02:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 02:58 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:02 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:29 -!- brianhoffman_ [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev 03:30 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Ping timeout: 264 seconds] 03:30 -!- brianhoffman_ is now known as brianhoffman 03:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:41 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 03:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 03:46 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has quit [Quit: rex4539] 03:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:48 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has joined #bitcoin-core-dev 03:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:49 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 03:50 < fanquake> wumpus / sipa can you block sinette on GH. Spamming, and by the look of their profile doing in on multiple repos. 03:53 < wumpus> sure 03:55 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has quit [Quit: rex4539] 03:56 < wumpus> done 03:57 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 04:01 -!- tintin [~tintin@62.12.175.133] has joined #bitcoin-core-dev 04:05 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds] 04:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 04:07 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 04:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:13 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 04:24 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev 04:30 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 04:33 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 04:33 < pbase> what should be the starting point to start understanding the bitcoin-core code? 04:35 -!- Aaronvan_ is now known as AaronvanW 04:36 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has quit [Ping timeout: 272 seconds] 04:42 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 04:46 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 04:48 < wumpus> pbase: what part are you interested in? 04:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:49 < wumpus> validation, the wallet, etc, that already provides a place to start looking 04:49 < pbase> wumpus, i intend to create a decentralized identity system from it 04:49 < pbase> wumpus, so guess all the components 04:50 < pbase> will have to forgo anonymity 04:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 05:00 -!- rex4539 [~rex4539@2a02:587:a10:aa00:e951:1e88:5ab1:99a9] has joined #bitcoin-core-dev 05:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:06 < pbase> Will it be a good idea to start from the first version of the code? 05:08 -!- rex4539 [~rex4539@2a02:587:a10:aa00:e951:1e88:5ab1:99a9] has quit [Ping timeout: 252 seconds] 05:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 05:16 -!- schnerchi [~schnerchi@p54A7971B.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 05:30 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 05:46 < wumpus> pbase: not necessarily, newer versions tend to have more code, but also cleaned up a lot of the code, made better abstractions, and so on 05:47 < wumpus> and better comments (hopefully) 05:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 06:01 -!- rex4539 [~rex4539@athedsl-4544730.home.otenet.gr] has joined #bitcoin-core-dev 06:02 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:15 < promag> what's the deal with travis failures? 06:15 < wumpus> I don't know… 06:15 < promag> "SC2236: Use -z instead of ! -n" 06:15 < promag> https://travis-ci.org/bitcoin/bitcoin/jobs/479413409 06:16 -!- rex4539 [~rex4539@athedsl-4544730.home.otenet.gr] has quit [Ping timeout: 245 seconds] 06:16 < wumpus> it's not failing on master is it? 06:16 < wumpus> not getting mails at least 06:16 < promag> update to shellcheck? 06:18 < promag> doesn't look like 06:19 < wumpus> please not another linter issue I can't survive this... 06:21 < promag> keep calm and fix linter 06:23 -!- kexkey [~kexkey@172.98.82.4] has joined #bitcoin-core-dev 06:24 < wumpus> rm -rf /linters 06:24 < promag> path not found 06:24 < promag> well honestly I like linters 06:24 < wumpus> everyone does but me 06:24 < promag> most of the time they play on our side 06:25 < promag> on my system it's "version: 0.4.7", on travis 0.6.0 06:27 < promag> weird, that's not on bionic 06:27 < promag> where does that come from? 06:28 < wumpus> I like static checking that finds bugs, or rules out classes of bugs. What I don't like is test failures because of what are essentially style suggestions. 06:28 < wumpus> ! -n is perfectly fine, yes -z is shorter no shit no that's not something that needs to be fixed 06:28 < gribble> Error: "-n" is not a valid command. 06:29 < promag> ok, upgraded shellcheck to 0.6.1 and got that error 06:31 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a006:776f:a24:fe6c] has joined #bitcoin-core-dev 06:31 < promag> pushing fix 06:32 < wumpus> I think SC2236 needs to be added to 'shellcheck -e ...'. though if they change the shellcheck version arbitrarily it'd be better to list the cases that should be checked inclusively, instead of excluding certain checks 06:32 < promag> yes 06:32 -!- Tralfaz [~none@104.248.145.220] has joined #bitcoin-core-dev 06:33 < wumpus> https://github.com/bitcoin/bitcoin/commit/908a559f33 is similar 06:34 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a006:776f:a24:fe6c] has quit [Remote host closed the connection] 06:36 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a006:776f:a24:fe6c] has joined #bitcoin-core-dev 06:37 < promag> #15164 06:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15164 | qa: Ignore shellcheck warning SC2236 by promag · Pull Request #15164 · bitcoin/bitcoin · GitHub 06:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:42 -!- guga [59f4d7c3@gateway/web/freenode/ip.89.244.215.195] has joined #bitcoin-core-dev 06:44 < wumpus> I'm confused by #15104, how can adding unit tests *decrease* test coverage 06:44 < gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub 06:52 < promag> wumpus: green https://travis-ci.org/bitcoin/bitcoin/jobs/479425164 06:52 < wumpus> good 06:57 < wumpus> $ ../devtools/github-merge.py 15164 06:57 < wumpus> Warning: unable to retrieve pull information from github: HTTP Error 403: Forbidden 06:57 < wumpus> this happens a lot lately, did github change the request limits? 06:57 < wumpus> --might make sense to add reporting of the detailed http error to gh-merge 07:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:03 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.] 07:05 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 07:08 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 07:09 < promag> https://developer.github.com/v3/#rate-limiting 07:09 < promag> do you exceed 5000req/hr? 07:09 < wumpus> yep... "message":"API rate limit exceeded for X.X.X.X" 07:10 < wumpus> eh definitely not 07:10 < promag> it counts all your requests 07:11 < promag> "all OAuth applications authorized by a user share the same quota of 5000 requests per hour when they authenticate with different tokens owned by the same user." 07:12 < wumpus> this is for *authenticated requests*? FWIW, that script uses unauthenticated ones 07:12 < promag> then it's 60 requests per hour 07:13 < wumpus> that's still somewhat unlikely but of a more realistic magnitude 07:13 < promag> but it could use your PAT? 07:14 < promag> it's for retrieve_pr_info? 07:15 -!- testbot_ [4f4530ad@gateway/web/freenode/ip.79.69.48.173] has joined #bitcoin-core-dev 07:15 < wumpus> req = Request("https://api.github.com/repos/"+repo+"/pulls/"+pull) 07:15 < wumpus> yes 07:15 -!- testbot_ [4f4530ad@gateway/web/freenode/ip.79.69.48.173] has quit [Client Quit] 07:16 < wumpus> hi testbot_ 07:17 < wumpus> just going to patch it locally for now to put in my token 07:23 < wumpus> that works ! 07:23 < promag> \o/ 07:31 -!- miknotauro [~miknotaur@187.207.15.113] has quit [Ping timeout: 246 seconds] 07:51 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:54 < promag> wumpus: I don't think we should encourage that 07:54 < promag> .. git config for secrets 07:57 < promag> I'd say something like "set environment variable GITHUB_TOKEN with Github Personal Access Token to overcome API rate limits" 07:58 < wumpus> environment variables are not better! 07:58 < wumpus> FWIW what i have myself is 07:58 < wumpus> [include] 07:59 < wumpus> path = ~/.gitsecrets 08:00 < promag> wumpus: I don't mean to have the envvar in the shell 08:00 < wumpus> but I thought that would be overly pedantic to suggest in the documentation, this is a token without privileges 08:00 < promag> is it? 08:00 < wumpus> yes 08:01 < wumpus> where else would you have environment variables than in the shell? it's often possible to get the envvars in 'ps' output on a shared system, at least configuration files can be set with appropriate permissions 08:02 < promag> I mean PAT=(securely get my pat) ./gh-merge 08:02 < wumpus> then agian, I don't feel like having an argument about this, closing that PR if this is controversial 08:03 < promag> don't do that 08:03 < wumpus> promag: that has the same result! and do you want to copy/paste the token every time you use the script? 08:05 < wumpus> also that exposes it to shoulder surfers 08:06 < promag> PAT=(run-command-to-securely-get-my-pat) ./gh-merge is unsecure? anyway I'm too dumb in this regard.. :P 08:07 < wumpus> I thought about suggesting to add the token in the *local* git config, might be less likely to accidentally check that in 08:07 < wumpus> (e.g. it's part of the .git directory so I don't think you even can) 08:08 < promag> https://stackoverflow.com/a/51505417 08:08 -!- pbase [~pbase@unaffiliated/pbase] has quit [Ping timeout: 272 seconds] 08:08 < wumpus> for me, though, it's much more useful to have it globally available 08:08 < wumpus> (I use the tool for more repos) 08:09 < promag> err nevermind that, that's for git via http iiuc 08:10 < promag> moving forward X) 08:11 < wumpus> promag: I don't know, I might be confused too, but isn't this what 'ps e' is? 08:11 < promag> mother-of-god 08:12 < promag> back to linux for dummies 08:12 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 250 seconds] 08:12 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a006:776f:a24:fe6c] has quit [Quit: Sleep mode] 08:14 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev 08:18 -!- tintin [~tintin@62.12.175.133] has quit [Read error: Connection reset by peer] 08:20 < promag> wumpus: since you utACK on #14941 do you mind weight about ryanofsky suggestion? 08:21 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 08:22 < wumpus> promag: will take a look 08:22 < promag> ty 08:33 < wumpus> promag: he makes a valid suggestion IMO, no strong opinion on it, I'd slightly prefer simpler code (I don't think it's too bad that the last RPC wallet call, if it's still in progress, has to wait too -- I think it is unlikely in practice that that happens at the same time) 08:33 < promag> wumpus: yap, I agree with you all 08:34 < promag> if that turns to be a problem then it can be avoided 08:40 < MarcoFalke> [09:44] I'm confused by #15104, how can adding unit tests *decrease* test coverage 08:40 < gribble> https://github.com/bitcoin/bitcoin/issues/15104 | Tests: Add unit testing for the CompressScript function by mmachicao · Pull Request #15104 · bitcoin/bitcoin · GitHub 08:40 < MarcoFalke> They are not deterministic right now, so you get different coverage each run 08:41 -!- rhavar [uid237883@gateway/web/irccloud.com/x-qbpfpehtnvzazgpb] has joined #bitcoin-core-dev 08:52 < wumpus> MarcoFalke: right, so the interpretation would be: the gain in test coverage, if any, is within the random margin 08:53 < MarcoFalke> Yeah, to see where coverage increases you'd have to manually discard all files which you think shouldn't change 08:55 < MarcoFalke> So compare 08:55 < MarcoFalke> https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/15104/total.coverage/src/compressor.cpp.gcov.html#54 08:55 < MarcoFalke> https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/src/compressor.cpp.gcov.html#54 08:55 < gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub 08:55 < gribble> https://github.com/bitcoin/bitcoin/issues/54 | do not create "Your Address" account when creating a new wallet by tcatm · Pull Request #54 · bitcoin/bitcoin · GitHub 08:56 < MarcoFalke> Looks like coverage is already there, but I wouldn't mind additional tests if they make sense 08:58 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 08:59 -!- guga [59f4d7c3@gateway/web/freenode/ip.89.244.215.195] has quit [Quit: Page closed] 09:01 * luke-jr pokes gribble 09:02 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:07 < wumpus> MarcoFalke: +1 09:08 < wumpus> also don't think those few extra unit tests make test_bitcoin take significantly more time 09:14 < gmaxwell> Re: coverage, is the coverage analysis excluding the tests themselves? If they aren't it's totally unsurprising that adding a test would reduce coverage. 09:24 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 09:26 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 09:27 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:51 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:51 -!- sergey [8754a72b@gateway/web/freenode/ip.135.84.167.43] has joined #bitcoin-core-dev 09:52 -!- sergey [8754a72b@gateway/web/freenode/ip.135.84.167.43] has left #bitcoin-core-dev [] 09:56 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:01 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:08 < MarcoFalke> They are not excluded, but since they are run, they are covered 10:10 < gmaxwell> MarcoFalke: tests frequently contain error handling code which doesn't run (because the tests pass), which means that adding a test that mostly covers otherwise covered code can reduce coverage. 10:11 < MarcoFalke> Right. Though, we mostly use the BOOST_* macros for error handling/reporting and those system libs are excluded from coverage 10:28 < luke-jr> macros != libs; are you sure they're excluded? 10:31 < MarcoFalke> This is all that is included: https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/index.html 10:31 < MarcoFalke> (Only folders or files in /src) 10:33 < MarcoFalke> Makefile.am:LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1" 10:35 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds] 10:35 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 10:38 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 245 seconds] 10:39 -!- miknotauro [~miknotaur@187.207.15.113] has joined #bitcoin-core-dev 10:39 < luke-jr> MarcoFalke: yeah, but I'm not sure how it determines which file it's in 10:40 < luke-jr> with a macro, it could very well be considered part of the test file 10:40 < MarcoFalke> Ah 10:40 < MarcoFalke> Yeah, for branch coverage it does, I think. 10:41 < MarcoFalke> I couldn't really get meaningful data for branch coverage anyway. I guess the compiler is adding too many optimization branches or removes them 10:41 < MarcoFalke> For line and function coverage it doesn't matter 10:42 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:42 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:45 < gmaxwell> MarcoFalke: what do you mean you couldn't get meaningful data? 10:46 < MarcoFalke> I mean that I am too dumb to parse the html output 10:46 < MarcoFalke> See for example https://drahtbot.github.io/reports/coverage/bitcoin/bitcoin/master/total.coverage/src/logging.h.gcov.html 10:47 < MarcoFalke> bool Enabled() const has two branches 10:47 < MarcoFalke> But the compiler adds hundered or so more 10:48 < MarcoFalke> Could be some inlining of the template stuff further down, idk 10:49 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 11:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 11:02 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 11:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:03 < gmaxwell> MarcoFalke: yes, thats totally sensible, those are real branches that come in due to exception handling and templates. 11:03 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:04 -!- Krellan [~Krellan@2601:640:4000:a876:f4d8:1bb6:7972:a9d0] has quit [Remote host closed the connection] 11:04 -!- miknotauro [~miknotaur@187.207.15.113] has quit [Ping timeout: 250 seconds] 11:10 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 11:26 -!- jarthur [~jarthur@207.114.244.5] has quit [] 11:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:00 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 12:06 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds] 12:09 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:13 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-dev 12:36 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Ping timeout: 272 seconds] 12:36 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:38 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 12:42 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 12:45 -!- yxz [~a4@142.177.73.13] has joined #bitcoin-core-dev 12:45 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Sleep mode] 12:50 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-dev 13:04 -!- karelb_ [sid316741@gateway/web/irccloud.com/x-bimhxdkslfzsbkcy] has joined #bitcoin-core-dev 13:04 -!- hsmiths__ [uid95325@gateway/web/irccloud.com/x-zvpkravfmxbxyzmb] has joined #bitcoin-core-dev 13:04 -!- RubenSomsen_ [sid301948@gateway/web/irccloud.com/x-cgndugybjyvdgwvb] has joined #bitcoin-core-dev 13:04 -!- noganoo_ [sid146237@gateway/web/irccloud.com/x-npxeqteoyfnfkzxc] has joined #bitcoin-core-dev 13:05 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 13:07 -!- nodweber2 [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev 13:08 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 13:11 -!- hsmiths_ [uid95325@gateway/web/irccloud.com/x-yjbrnlzobbwadzzh] has quit [Ping timeout: 268 seconds] 13:11 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-ezybmmomhdxtcvby] has quit [Ping timeout: 268 seconds] 13:11 -!- karelb [sid316741@gateway/web/irccloud.com/x-dcvobpenhjmxaofi] has quit [Ping timeout: 268 seconds] 13:11 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Ping timeout: 268 seconds] 13:11 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 268 seconds] 13:11 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 268 seconds] 13:11 -!- noganoo [sid146237@gateway/web/irccloud.com/x-aqqntiooctsfjjvn] has quit [Ping timeout: 268 seconds] 13:11 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-rryghbuxutzdaqwh] has quit [Ping timeout: 268 seconds] 13:11 -!- noganoo_ is now known as noganoo 13:11 -!- karelb_ is now known as karelb 13:11 -!- RubenSomsen_ is now known as RubenSomsen 13:12 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-iwrvtydtsirertlc] has joined #bitcoin-core-dev 13:13 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 13:15 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 13:38 -!- echeveria [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 13:50 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Sleep mode] 13:55 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-dev 13:55 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 13:57 -!- Tralfaz [~none@104.248.145.220] has quit [Remote host closed the connection] 13:58 -!- Tralfaz [~none@104.248.145.220] has joined #bitcoin-core-dev 14:02 -!- Tralfaz [~none@104.248.145.220] has quit [Remote host closed the connection] 14:02 -!- Tralfaz [~none@104.248.145.220] has joined #bitcoin-core-dev 14:06 < promag> should I include release notes in a backport? 14:11 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 14:15 < luke-jr> probably depends on which gets released first 14:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 14:19 -!- hsmiths__ is now known as hsmiths 14:21 < promag> makes sense 14:21 < promag> luke-jr: do you still dislike #15149? 14:21 < gribble> https://github.com/bitcoin/bitcoin/issues/15149 | gui: Show current wallet name in window title by promag · Pull Request #15149 · bitcoin/bitcoin · GitHub 14:23 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 14:25 < luke-jr> promag: no, the responses satisfy my concern 14:25 < promag> cool thanks 14:25 * luke-jr edits a strikeout into his comment 14:26 < luke-jr> I mean, I guess I dislike it, but it's not unreasonable 14:26 < luke-jr> I actually am annoyed sometimes that I can search my open browser windows, but it misses non-active tabs :P 14:28 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds] 14:28 < phantomcircuit> i've almost got the 0.7 bdb based node to 2018, it's been literally a month i think 14:34 -!- michaelfolkson [~textual@85.211.233.88] has quit [Remote host closed the connection] 14:34 -!- mistergold [~mistergol@37.19.107.33] has joined #bitcoin-core-dev 14:45 < promag> I think hebasto can be added to the gh org? 14:45 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfclivqndzppdfty] has joined #bitcoin-core-dev 14:57 < bitcoin-git> [bitcoin] promag closed pull request #15107: rest: Return 404 in /rest/headers if block hash does not exists (master...2019-rest-header-404) https://github.com/bitcoin/bitcoin/pull/15107 14:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfclivqndzppdfty] has left #bitcoin-core-dev [] 15:01 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev 15:04 -!- miknotauro [~miknotaur@187.207.15.113] has joined #bitcoin-core-dev 15:05 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:07 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 15:09 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:19 < gkrizek> ^^ GitHub IRC Service is out of its brown out until the 31st when it’s fully depreciated. I’m still working on a replacement and it’s close to done. Will def be done before the 31st. 15:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:27 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:29 < gwillen> meshcollider: as wallet maintainer do you have any official opinion on how much more review #14978 should have 15:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub 15:32 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:35 -!- bzb_ [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev 15:39 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Ping timeout: 246 seconds] 15:44 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:50 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 15:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 15:53 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 16:24 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:26 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 16:32 -!- bzb_ [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Quit: Leaving] 16:35 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:39 -!- mistergold [~mistergol@37.19.107.33] has quit [Quit: leaving] 16:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 17:01 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 17:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 17:05 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.3] 17:13 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:17 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 17:18 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 17:32 -!- Tralfaz [~none@104.248.145.220] has quit [Read error: Connection reset by peer] 17:35 -!- benthecarman [~benthecar@ics133-250.icsincorporated.com] has joined #bitcoin-core-dev 17:36 < benthecarman> Is the mailing list down? It won't let me add myself 17:37 -!- wajz [ba349490@gateway/web/freenode/ip.186.52.148.144] has joined #bitcoin-core-dev 17:38 < wajz> Hi there!, just a simple question. I'm reading a blockchain paper which I would like to discuss. Is this an appropiate channel or there's any 'research channel'? 17:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:40 < kanzure> /join #bitcoin-wizards 17:41 < wajz> Thanks kanzure 17:51 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 17:51 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 18:12 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 18:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 18:16 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:17 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 18:17 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 18:23 -!- wajz [ba349490@gateway/web/freenode/ip.186.52.148.144] has quit [Ping timeout: 256 seconds] 18:44 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 18:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:57 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 19:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cxcilwhvqqevdjeh] has joined #bitcoin-core-dev 19:01 < bitcoin-git> [bitcoin] sdaftuar opened pull request #15169: WIP: Parallelize CheckInputs() in AcceptToMemoryPool() (master...2018-12-parallel-mempool-scriptchecks) https://github.com/bitcoin/bitcoin/pull/15169 19:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cxcilwhvqqevdjeh] has left #bitcoin-core-dev [] 19:07 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 19:12 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has joined #bitcoin-core-dev 19:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pvbsrmojfhiyyjqs] has joined #bitcoin-core-dev 19:12 < bitcoin-git> [bitcoin] koalaman opened pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170 19:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pvbsrmojfhiyyjqs] has left #bitcoin-core-dev [] 19:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:39 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 19:40 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has quit [Ping timeout: 250 seconds] 20:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 20:06 -!- schnerch_ [~schnerchi@p54A7911F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:08 -!- schnerchi [~schnerchi@p54A7971B.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds] 20:10 -!- rasrenato [bb3b0265@gateway/web/freenode/ip.187.59.2.101] has joined #bitcoin-core-dev 20:10 -!- rasrenato [bb3b0265@gateway/web/freenode/ip.187.59.2.101] has quit [Client Quit] 20:23 -!- benthecarman [~benthecar@ics133-250.icsincorporated.com] has quit [Read error: Connection reset by peer] 20:27 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 20:32 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has joined #bitcoin-core-dev 20:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds] 21:08 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 21:19 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 21:20 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 21:36 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:c977:813f:a17:2b0] has quit [Ping timeout: 260 seconds] 21:39 < meshcollider> gwillen: maybe only one or two more, hopefully promag or someone who commented early on is willing to do a full review 21:54 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 244 seconds] 22:01 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:bd98:ecdf:a4bc:977] has joined #bitcoin-core-dev 22:10 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has quit [Ping timeout: 250 seconds] 22:11 -!- Klox [~Klox@c-73-22-66-195.hsd1.il.comcast.net] has joined #bitcoin-core-dev 22:14 < gwillen> meshcollider: cool, thanks 22:14 < gwillen> I would ping promag here but he doesn't seem to be on at the moment 22:14 < meshcollider> He'll get pinged by my message anyway :) 22:15 < gwillen> well he would if he were here, anyway :-) 22:20 -!- rhavar [uid237883@gateway/web/irccloud.com/x-qbpfpehtnvzazgpb] has quit [Quit: Connection closed for inactivity] 22:30 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 240 seconds] 23:10 -!- Krellan [~Krellan@2601:640:4000:a876:802d:4df9:46f1:3e2e] has joined #bitcoin-core-dev 23:22 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:26 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ftvqtmumyvboigeq] has joined #bitcoin-core-dev 23:35 < bitcoin-git> [bitcoin] Empact opened pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171 23:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ftvqtmumyvboigeq] has left #bitcoin-core-dev [] 23:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 23:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:58 -!- wangkaixuan [de803cdb@gateway/web/freenode/ip.222.128.60.219] has joined #bitcoin-core-dev --- Log closed Tue Jan 15 00:00:19 2019