--- Log opened Thu Jan 17 00:00:24 2019 00:03 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-gapuzocgirgzqdju] has quit [Quit: Connection closed for inactivity] 00:19 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 00:20 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 00:24 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 00:36 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:37 -!- bintangblue [7da18b5f@gateway/web/freenode/ip.125.161.139.95] has joined #bitcoin-core-dev 00:38 -!- bintangblue [7da18b5f@gateway/web/freenode/ip.125.161.139.95] has quit [Client Quit] 00:39 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 00:42 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 00:44 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 00:58 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 00:58 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 01:03 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 01:03 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 01:18 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfajprxfpnaktdmi] has joined #bitcoin-core-dev 01:22 < bitcoin-git> [bitcoin] Empact closed pull request #15133: [WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder (master...factories) https://github.com/bitcoin/bitcoin/pull/15133 01:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfajprxfpnaktdmi] has left #bitcoin-core-dev [] 01:47 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:48 -!- Wilmar [ac3a630c@gateway/web/freenode/ip.172.58.99.12] has joined #bitcoin-core-dev 01:49 -!- Wilmar [ac3a630c@gateway/web/freenode/ip.172.58.99.12] has quit [Client Quit] 01:52 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 01:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:53 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 01:53 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 01:56 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 01:58 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 01:58 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 02:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:28 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 02:52 < promag> wumpus: pushKV should assert(key not exist) 02:52 < promag> it checks for duplicate but overwrites 02:53 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:53 < promag> I don't think that's our use case (from API point of view) 02:58 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 02:58 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:00 < hebasto> wumpus: hi, mind reviewing #14250? 03:00 < gribble> https://github.com/bitcoin/bitcoin/issues/14250 | qt: Remove redundant stopThread() and stopExecutor() signals by hebasto · Pull Request #14250 · bitcoin/bitcoin · GitHub 03:03 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 03:03 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:08 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 03:08 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:13 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 03:13 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:14 -!- rex4539 [~rex4539@ppp079166016107.access.hol.gr] has joined #bitcoin-core-dev 03:16 -!- rex4539 [~rex4539@ppp079166016107.access.hol.gr] has quit [Client Quit] 03:21 -!- laurentmt [~Thunderbi@194.59.249.21] has joined #bitcoin-core-dev 03:30 -!- laurentmt [~Thunderbi@194.59.249.21] has quit [Quit: laurentmt] 03:33 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 03:33 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:38 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 03:38 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 03:45 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 268 seconds] 03:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:53 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:03 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 04:03 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 04:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 04:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:13 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 04:13 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 04:18 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 04:27 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 240 seconds] 04:29 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 04:30 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 04:32 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 04:32 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 04:32 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 04:33 < wumpus> promag: from the point of view of our API that's true, though on the other hand there's nothing in JSON that disallows multiple values per key 04:33 < wumpus> hebasto: sure 04:35 < wumpus> promag: and checking that *efficiently* would involve adding a set to the Univalue type; not instead, but in addition to the vector because we want to preserve order as well 04:35 < promag> true, univalue is generic and that's fine. just think it could have more specialized mutations. for instance, pushKV should be setKV ? 04:35 < wumpus> (also asserting is really dangerous here; it can turn a mild asthetic issue into a crash) 04:36 < promag> wumpus: that should be fine, we don't use user keys 04:36 < wumpus> (say, REST returns some JSON structure and the code can be manipulated to add the same field twice, somehow, whoopsie instant DoS - a better solution would be to replace the value for the existing key) 04:37 < wumpus> that'd also be "javascript semantics" FWIW, in any case there's no need to overreact to this case 04:38 -!- farmerwampum__ [~farmerwam@104.129.29.34] has joined #bitcoin-core-dev 04:38 < promag> wumpus: look #14984 for instance 04:38 < gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub 04:38 < wumpus> if there's anything to worry that would be that this should have been caught at *review time* :) 04:39 < promag> I'm not arguing it shouldn't be caught at review time 04:40 < wumpus> I know, but I mean *if* this should trigger any kind of discussion it's that; the end result of a key appearing twice on the API is hardly a problem, the only worry (if this was, say, a silent merge issue) is that it could have been worse 04:41 < wumpus> *silent merge conflict* 04:41 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Ping timeout: 258 seconds] 04:41 -!- farmerwampum_ [~wampum@162.219.178.10] has quit [Ping timeout: 258 seconds] 04:42 -!- farmerwampum [~wampum@104.129.29.34] has joined #bitcoin-core-dev 04:46 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 04:47 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 04:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:54 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev 04:59 -!- mistergold [~mistergol@77.243.30.26] has joined #bitcoin-core-dev 05:16 -!- schnerch_ [~schnerchi@p54A7947D.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 05:17 -!- schnerchi [~schnerchi@p54A7947D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:22 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:23 < fanquake> wumpus how often do you use the mallocinfo mode for getmemoryinfo ? 05:24 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:28 -!- farmerwampum__ [~farmerwam@104.129.29.34] has quit [Quit: farmerwampum__] 05:29 -!- farmerwampum_ [~farmerwam@104.129.29.34] has joined #bitcoin-core-dev 05:31 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 05:32 -!- TheRec_ [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:32 -!- TheRec_ [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:32 -!- TheRec_ [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:33 -!- farmerwampum_ [~farmerwam@104.129.29.34] has quit [Client Quit] 05:33 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 272 seconds] 05:33 -!- TheRec_ [toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 05:34 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:34 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:34 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:34 -!- Sunil_ [1b3d9101@gateway/web/freenode/ip.27.61.145.1] has joined #bitcoin-core-dev 05:35 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 05:35 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:35 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:35 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:36 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 05:36 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 05:38 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:38 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:38 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:39 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 05:40 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:40 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:40 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:40 -!- Sunil_ [1b3d9101@gateway/web/freenode/ip.27.61.145.1] has quit [Quit: Page closed] 05:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gufdcmnybphqrgil] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fcb6694a9945...7ee604487f54 05:41 < bitcoin-git> bitcoin/master 1c0e0a5 Hennadii Stepanov: Remove redundant stopThread() signal 05:41 < bitcoin-git> bitcoin/master 24313fb Hennadii Stepanov: Remove redundant stopExecutor() signal 05:41 < bitcoin-git> bitcoin/master 7ee6044 Wladimir J. van der Laan: Merge #14250: qt: Remove redundant stopThread() and stopExecutor() signals... 05:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gufdcmnybphqrgil] has left #bitcoin-core-dev [] 05:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-myueoxdzmakxjmxc] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] laanwj closed pull request #14250: qt: Remove redundant stopThread() and stopExecutor() signals (master...stopthread-signal) https://github.com/bitcoin/bitcoin/pull/14250 05:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-myueoxdzmakxjmxc] has left #bitcoin-core-dev [] 05:44 -!- mistergold [~mistergol@77.243.30.26] has quit [Read error: Connection reset by peer] 05:44 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Ping timeout: 245 seconds] 05:51 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 05:51 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 268 seconds] 05:51 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:51 -!- TheRec [toto@84-75-224-81.dclient.hispeed.ch] has quit [Changing host] 05:51 -!- TheRec [toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:54 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 05:56 -!- TheRec [toto@drupal.org/user/146860/view] has quit [Ping timeout: 245 seconds] 06:01 < wumpus> fanquake: not often, why? 06:01 -!- TheRec_ [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 268 seconds] 06:03 < fanquake> wumpus just curious, don't see it mentioned often, and had just about forgotten it was a thing, but am writing RPC wrappers. Can't use it on macOS anyways. 06:05 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 06:06 < wumpus> it's mostly useful for developers when diagnosing some kinds of allocation behavior 06:14 -!- laurentmt [~Thunderbi@194.59.249.21] has joined #bitcoin-core-dev 06:19 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 06:23 -!- guga [~guga@i59F4D7C3.versanet.de] has joined #bitcoin-core-dev 06:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:28 < dongcarl> luke-jr: how does OpenRC work with env vars? How are they passed to the service? 06:29 < dongcarl> I can do the same for #12255, which means the user can override env vars in their systemd unit 06:29 < gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub 06:31 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 06:31 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Client Quit] 06:32 -!- laurentmt [~Thunderbi@194.59.249.21] has quit [Quit: laurentmt] 06:33 -!- cluelessperson_ [~cluelessp@2604:4080:1326:83c5:604f:2ff:fe8e:c545] has joined #bitcoin-core-dev 06:34 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 06:34 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 06:34 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 06:36 < gkrizek> wumpus thanks for the explanation on the encoding arg. So is there a work around for 3.4? That arg wasn’t introduced until 3.6. 06:37 -!- cluelessperson_ [~cluelessp@2604:4080:1326:83c5:604f:2ff:fe8e:c545] has quit [Remote host closed the connection] 06:37 -!- cluelessperson_ [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev 06:37 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 06:38 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:38 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 06:39 -!- setpill [~setpill@unaffiliated/setpill] has quit [Read error: Connection reset by peer] 06:39 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 06:51 < wumpus> gkrizek: I don't know if there's a workaround for earlier versions :/ 06:52 < wumpus> well, one way would be to read *bytes* from the pipe and convert it to utf-8 using an encoder 06:52 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 06:52 < wumpus> I think I did this in the github-merge script 06:54 < wumpus> can't wait until we can support 3.6 as minimum python version tbh, this keeps coming up 06:56 -!- m8tion [~user@88.190.249.49] has quit [Ping timeout: 245 seconds] 06:56 < gkrizek> Ha, I agree. Ok I’ll try to look around and find some other scripts to see how they do it 07:01 < wumpus> yes see contrib/devtools/github-merge.py 07:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbdhkeotrdticbov] has joined #bitcoin-core-dev 07:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee604487f54...003a47f804b1 07:04 < bitcoin-git> bitcoin/master 31097b7 benthecarman: docs: Spelling error fix on fuzzing.md 07:04 < bitcoin-git> bitcoin/master 003a47f MarcoFalke: Merge #15185: docs: Spelling error fix on fuzzing.md... 07:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbdhkeotrdticbov] has left #bitcoin-core-dev [] 07:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-unnlydcnbrckycvh] has joined #bitcoin-core-dev 07:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185 07:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-unnlydcnbrckycvh] has left #bitcoin-core-dev [] 07:10 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 245 seconds] 07:10 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving] 07:11 -!- farmerwampum_ [~wampum@184.75.220.106] has joined #bitcoin-core-dev 07:13 -!- farmerwampum [~wampum@104.129.29.34] has quit [Ping timeout: 246 seconds] 07:14 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:15 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:22 -!- laurentmt [~Thunderbi@194.59.249.21] has joined #bitcoin-core-dev 07:23 < fanquake> Looks like configuring with zmq on macOS is broken after brew bumped to 4.3.1 :( 07:24 < wumpus> hmm 07:26 < fanquake> Some discussion here: https://github.com/Homebrew/homebrew-core/pull/35940#issuecomment-454177261 07:27 -!- laurentmt [~Thunderbi@194.59.249.21] has quit [Client Quit] 07:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjfqewshtlfxjyeg] has joined #bitcoin-core-dev 07:27 < bitcoin-git> [bitcoin] practicalswift opened pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187 07:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjfqewshtlfxjyeg] has left #bitcoin-core-dev [] 07:32 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 07:32 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-cxgdurlwgirtfgwf] has quit [Ping timeout: 260 seconds] 07:33 -!- savil [savilmatri@gateway/shell/matrix.org/x-bzphonelnclapblc] has quit [Ping timeout: 260 seconds] 07:33 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-iwrvtydtsirertlc] has quit [Ping timeout: 252 seconds] 07:33 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-ocyewfsduiqzmcwg] has quit [Ping timeout: 252 seconds] 07:33 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 07:33 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-gdqwdpsjrmdmlnow] has joined #bitcoin-core-dev 07:34 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 07:34 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 07:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:36 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-deebqwmpdnzmkire] has joined #bitcoin-core-dev 07:38 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 07:39 -!- Bilith_ [17fa7d83@gateway/web/freenode/ip.23.250.125.131] has joined #bitcoin-core-dev 07:39 -!- savil [savilmatri@gateway/shell/matrix.org/x-hexmgyhwerhbdauc] has joined #bitcoin-core-dev 07:42 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 07:43 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-uiwhflvpjsxxcvvm] has joined #bitcoin-core-dev 07:43 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:45 -!- mistergold [~mistergol@77.243.28.231] has joined #bitcoin-core-dev 07:56 < wumpus> fanquake: so it might be a bug in their packaging of the new version, instead of the code itself? 07:56 -!- dabedoc [cc2c7075@gateway/web/freenode/ip.204.44.112.117] has joined #bitcoin-core-dev 07:56 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 07:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gdvchykyfucghuzj] has joined #bitcoin-core-dev 07:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/003a47f804b1...12b30105fc59 07:58 < bitcoin-git> bitcoin/master 638e53b practicalswift: Pin shellcheck version to v0.6.0 07:58 < bitcoin-git> bitcoin/master 07a53dc practicalswift: Remove repeated suppression. Fix indentation. 07:58 < bitcoin-git> bitcoin/master 0b7196e practicalswift: Fix warnings introduced in shellcheck v0.6.0 07:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gdvchykyfucghuzj] has left #bitcoin-core-dev [] 07:58 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Quit: farmerwampum] 07:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tbksiqzrkidjxxqt] has joined #bitcoin-core-dev 07:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15166: qa: Pin shellcheck version (master...opt-out-of-new-shellcheck-warnings) https://github.com/bitcoin/bitcoin/pull/15166 07:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tbksiqzrkidjxxqt] has left #bitcoin-core-dev [] 07:58 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 08:03 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Client Quit] 08:03 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 08:05 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 08:09 < hebasto_> provoostenator: thanks 08:11 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev 08:12 -!- dabedoc [cc2c7075@gateway/web/freenode/ip.204.44.112.117] has quit [Ping timeout: 256 seconds] 08:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 08:18 -!- guga [~guga@i59F4D7C3.versanet.de] has quit [Quit: Leaving] 08:19 -!- Bilith_ [17fa7d83@gateway/web/freenode/ip.23.250.125.131] has quit [Ping timeout: 256 seconds] 08:20 -!- mistergold [~mistergol@77.243.28.231] has quit [Read error: Connection reset by peer] 08:20 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:25 < jnewbery> promag: I've lost the thread a bit on where we are with #13100. Is there a path to getting all the load/unload/create wallet functionality into the GUI for v0.18? 08:25 < gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub 08:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qqhywbtdwmutzsmk] has joined #bitcoin-core-dev 08:26 < bitcoin-git> [bitcoin] rex4539 opened pull request #15188: Update zmq to 4.3.1 (master...update-zmq) https://github.com/bitcoin/bitcoin/pull/15188 08:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qqhywbtdwmutzsmk] has left #bitcoin-core-dev [] 08:33 < luke-jr> dongcarl: /etc/conf.d/ sets them, and they're in the environment for the init script 08:33 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Quit: farmerwampum] 08:33 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 08:34 < dongcarl> I see... I think I'll make it easy to override for systemd as well then. Thanks! 08:43 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Quit: farmerwampum] 08:44 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 240 seconds] 08:46 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 08:46 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 08:53 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds] 08:57 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 08:59 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:59 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Quit: farmerwampum] 09:01 -!- farmerwampum_ [~wampum@184.75.220.106] has quit [Read error: Connection reset by peer] 09:01 -!- farmerwampum [~wampum@184.75.220.106] has joined #bitcoin-core-dev 09:08 -!- shesek [~shesek@141.226.144.195] has joined #bitcoin-core-dev 09:08 -!- shesek [~shesek@141.226.144.195] has quit [Changing host] 09:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 09:11 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:15 -!- farmerwampum [~wampum@184.75.220.106] has quit [Remote host closed the connection] 09:15 -!- farmerwampum [~wampum@184.75.220.106] has joined #bitcoin-core-dev 09:18 -!- farmerwampum [~wampum@184.75.220.106] has quit [Remote host closed the connection] 09:20 < wumpus> ryanofsky: thanks for the extensive reviews on various PRs by the way 09:25 -!- promag [~promag@46.50.2.88] has joined #bitcoin-core-dev 09:29 < promag> could #15101 be merged? 09:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub 09:40 < wumpus> promag: it's quite a large chance to the gui, would be nice if jonasschnelli could at least take a look at it 09:40 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jcalcczeksobmhrn] has joined #bitcoin-core-dev 09:43 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Quit: WeeChat 2.2] 09:43 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev 09:44 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 09:44 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 09:45 -!- farmerwampum [~farmerwam@184.75.220.106] has left #bitcoin-core-dev [] 09:48 -!- riemann [~riemann@217.96.175.73.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 09:51 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:59 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 10:03 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Client Quit] 10:03 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 10:05 -!- davec_ [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 10:07 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 10:10 -!- promag [~promag@46.50.2.88] has quit [Remote host closed the connection] 10:13 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:15 -!- mistergold [~mistergol@185.37.26.7] has joined #bitcoin-core-dev 10:18 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Quit: farmerwampum] 10:22 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 10:23 -!- farmerwampum [~farmerwam@184.75.220.106] has quit [Client Quit] 10:29 -!- Ghost-Coder0101 [~ghost-cod@31.13.191.81] has joined #bitcoin-core-dev 10:34 -!- Ghost-Coder0101 [~ghost-cod@31.13.191.81] has quit [Quit: Mutter: www.mutterirc.com] 10:43 -!- laurentmt [~Thunderbi@194.59.249.21] has joined #bitcoin-core-dev 10:53 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 10:55 < jonasschnelli> I'll take a closer look 10:59 < wumpus> jonasschnelli: thank you! 11:00 < luke-jr> hi 11:00 < jonasschnelli> hi 11:00 < gleb> hi 11:00 < promag> hi 11:00 < promag> jonasschnelli: ty 11:01 < wumpus> #startmeeting 11:01 < lightningbot> Meeting started Thu Jan 17 19:01:06 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:01 < achow101> hi 11:01 < sipa> hi, will have to run in 5-10 minutes 11:01 < jamesob> hi 11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 11:02 < instagibbs> sup 11:02 < wumpus> any topics? 11:02 < wumpus> (nothing scheduled in moneyball's list) 11:03 < kanzure> hi. 11:03 < gleb> I would appreciate if we prioritize 14897 because a) I know someone stacks new changes on top of it and b) people on twitter are really exciting about replicating the topology inference through this vuln. on mainnet :) 11:03 < jonasschnelli> #14897 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub 11:03 < wumpus> #topic high priority for review 11:04 < meshcollider> hi 11:04 < wumpus> gleb: ok added 11:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11:05 < gleb> wumpus: thanks! 11:05 -!- laurentmt [~Thunderbi@194.59.249.21] has quit [Quit: laurentmt] 11:06 < wumpus> anyone wants anything to be added and/or removed otherwise? 7 is quite a lot of things to have in the list, in any case 11:06 < wumpus> anything nearing ready for merge? 11:07 < sipa> i'll go through them soon 11:07 < luke-jr> it seems 14897 was rewritten to do some refactoring too 11:07 < sipa> #14897 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub 11:07 < luke-jr> I would think it'd be nice to get a minimal implementation of the change reviewed and merged, and THEN do the refactoring 11:07 < luke-jr> that way the former can be backported easier 11:07 < wumpus> looks like meshcollider could take over jnewbery's branch in #14491 to make it pass travis again 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 11:07 < meshcollider> Yep I'll do that shortly 11:08 < sipa> luke-jr: i'm not sure that's possible; do you see anything obvious that could be left out? 11:08 < sipa> or gleb ? 11:09 < luke-jr> sipa: well, the original PR was apparently 60 LOC changed, and it got revised by request? 11:09 < gleb> Half of the new LOC is a comment :) 11:10 < gleb> Most of the comments on the original work were about *significant* refactoring (move from net to net_processing), which I did 11:11 < luke-jr> you mean insignificant? 11:11 < wumpus> if you got those comments and implemented them I think it's unfair to complain about it now 11:11 < luke-jr> I'm not sure I have the original code to compare 11:12 < luke-jr> if it was just a code move, no worries 11:12 < luke-jr> gmaxwell's suggestion sounded more in depth than that though 11:13 < achow101> luke-jr: github shows the diffs between force pushes now 11:13 < luke-jr> achow101: how? 11:13 < luke-jr> ooh, neat 11:13 < wumpus> ok, any other topics? 11:13 < luke-jr> rebasing seems to break it though 11:14 < meshcollider> achow101: only in a nice way if it was a commit amendment, rebases are impossible to read 11:14 < gleb> luke-jr: Well, I first did what gmaxwell suggested (before other reviews), THEN received refactoring comments, and then we moved code. Not sure which step was wrong and what I should've done better :) 11:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oehsnxbsdfcyhesl] has joined #bitcoin-core-dev 11:14 < bitcoin-git> [bitcoin] practicalswift closed pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187 11:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oehsnxbsdfcyhesl] has left #bitcoin-core-dev [] 11:15 < luke-jr> gleb: I'm not saying any of it was wrong, just that doing it in two separate steps/PRs would make it easier to backport ONLY the fix part 11:15 < wumpus> if people deem the refactor a necessary part of this, then that should be backported too 11:15 < sipa> mostly afk, but will check occasionally if someone pings me 11:17 < wumpus> but sure if it's possible to do a minimal fix for the 0.17 branch that might be less risky, if this is a risky refactor, but if it's move-only I don't think that's the case 11:17 < wumpus> for master this is fine anyhow 11:17 < wumpus> any other topics? 11:20 < wumpus> apparently not! that's a short meeting then 11:21 < wumpus> #endmeeting 11:21 < lightningbot> Meeting ended Thu Jan 17 19:21:25 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:21 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.html 11:21 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.txt 11:21 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.log.html 11:24 < sipa> sorry, seems i killed the party :) 11:25 < wumpus> are people traveling or is something going on? 11:26 < jonasschnelli> The usual january-downer probably. :) 11:26 < wumpus> ahh :) 11:27 < sipa> i'm about to fly to boston for the mystery hunt 11:28 < jonasschnelli> promag: with 15101, does that mean we would no longer instantiate the WalletModels at startup? (ref: with getOrCreateModel()) 11:31 -!- air_willy [~air@179-242-59-23.3g.claro.net.br] has joined #bitcoin-core-dev 11:31 < promag> WalletController construtor queries interfaces::Node for all current wallets and instantiates respective WalletModel's 11:31 < promag> jonasschnelli: ^ 11:34 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 250 seconds] 11:35 < jonasschnelli> promag: your pull makes first use of QMutexLocker? Would it be terrible wrong to use the core class synchronisation stuff? 11:35 < jonasschnelli> But its probably a non issue 11:35 < jonasschnelli> (to use QMutexLocker) 11:36 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev 11:37 < promag> jonasschnelli: that's true 11:38 < promag> jonasschnelli: I can replace 11:39 < jonasschnelli> I'm not sure if it makes a difference... so I'll leave it up to you. Was just a thought 11:39 < jonasschnelli> But most places in the GUI code we just use our marcos (LOCK/LOCK2) 11:39 < jonasschnelli> *macros 11:40 < wumpus> if the lock is not shared with the core code, I think it's fine to use qt primitives 11:40 < wumpus> we also use qt's threading primitives in the qt code 11:41 < luke-jr> it may actually be safer to use Qt mutexes with Qt threading 11:41 < jonasschnelli> Yeah. I agree. I only thought: "what if we port the code to the Core layer"... but I guess that never happens. 11:41 < luke-jr> well, porting implies changing that then :p 11:41 < jonasschnelli> that *will* never happen 11:41 -!- Krellan [~Krellan@2601:640:4000:a876:8d86:bfca:9fe:7bd3] has quit [Remote host closed the connection] 11:41 < jonasschnelli> expect we'r writing a curses-like terminal UI. 11:42 -!- np [ac7736ba@gateway/web/freenode/ip.172.119.54.186] has joined #bitcoin-core-dev 11:42 < jonasschnelli> I agree with luke-jr, wumpus . Lets keep using QMutexLocker with QThread 11:44 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 11:45 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 11:47 -!- np [ac7736ba@gateway/web/freenode/ip.172.119.54.186] has quit [Client Quit] 11:49 -!- Chuck_ [c43414d4@gateway/web/freenode/ip.196.52.20.212] has joined #bitcoin-core-dev 11:53 < promag> ok, I won't change :P 11:55 < wumpus> ok 11:55 -!- air_willy [~air@179-242-59-23.3g.claro.net.br] has quit [Remote host closed the connection] 12:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-exgnjwqzizbvrotz] has joined #bitcoin-core-dev 12:01 < bitcoin-git> [bitcoin] practicalswift opened pull request #15189: validation: Add missing cs_nBlockSequenceId lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189 12:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-exgnjwqzizbvrotz] has left #bitcoin-core-dev [] 12:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds] 12:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ndkrvwcmsrpvkbmm] has joined #bitcoin-core-dev 12:09 < bitcoin-git> [bitcoin] LifeIsPizza opened pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190 12:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ndkrvwcmsrpvkbmm] has left #bitcoin-core-dev [] 12:10 < luke-jr> ^ here we go.. 12:12 < sipa> every year :p 12:13 < gwillen> can we like, spent a few bucks to get a legal opinion that says you don't have to have the year in every file for it to count? :-P 12:13 < gwillen> I know that many projects do not do this anymore 12:13 < gwillen> spend* 12:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nqdsuxwiforhzdww] has joined #bitcoin-core-dev 12:13 < bitcoin-git> [bitcoin] LifeIsPizza closed pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190 12:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nqdsuxwiforhzdww] has left #bitcoin-core-dev [] 12:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:16 < sipa> gwillen: IANAL but i believe those copyright statements per file (and much less the year indications) are almost certainly worthless, especially when attributing to "The Bitcoin Core developers", which is not a legal entity 12:16 < wumpus> it wouldn't prevent people from opening such PRs anyway 12:16 < wumpus> and just posting 'we do this at the end of the year' then closing isn't exactly that much work 12:16 < gwillen> sipa: I am in total agreement with you on this 12:17 < gwillen> right, but we do still actually do it, right? 12:17 < wumpus> yes, once per year with an automated script 12:17 < gwillen> ahh, *nods* 12:18 < gwillen> removing all the years would prevent the PRs and having to run the script, but if it's fully automated I guess it could be worse. 12:18 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 12:18 < wumpus> hah yes, that's true, removing the years would make it impossible for people to make PR changing them 12:20 < gwillen> also like, when I made a new file that was largely code copied from another file, I spent some time contemplating what exactly I should do for the copyright header 12:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jqjvgklfimxvkmwd] has joined #bitcoin-core-dev 12:21 < bitcoin-git> [bitcoin] practicalswift opened pull request #15191: validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191 12:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jqjvgklfimxvkmwd] has left #bitcoin-core-dev [] 12:21 < gwillen> which would be fixed by having a generic invariant one. 12:22 < luke-jr> gwillen: copyright counts even if there's no copyright notice at all 12:22 < luke-jr> IANAL also btw 12:23 < gwillen> yeah, this is true. I was going to say that a written copyright notice still does something, but after quickly reading the wikipedia article on copyright notices to refresh my memory... it's not actually clear that they have any practical effect here 12:24 < [\\\]> According to copyright.gov, "Copyright notice is optional for works published on or after March 1, 1989, unpublished works, and foreign works; however, there are legal benefits for including notice on your work." 12:24 < [\\\]> https://www.copyright.gov/circs/circ03.pdf 12:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:25 < gwillen> the strongest benefit that Wikipedia lists is that it prevents an infringer from claiming ignorance as a defense, which would reduce statutory penalties 12:25 < wumpus> also mind that this is an international project, not only US law counts 12:25 < gwillen> anyway I'm not advocating removing the notice 12:25 < luke-jr> arguably, we can't remove it entirely due to the MIT license and Satoshi's notices 12:26 < gwillen> just replacing it with some kind of simple fixed notice with a pointer to the COPYING file, without varying years or names other than "the Bitcoin developers" or what have you 12:26 < wumpus> IIRC the idea was to remove the years, not the entire notice 12:26 < gwillen> yeah, I would advocate for removing anything that changes between files 12:26 < luke-jr> fwiw, from me, ACK removing years 12:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fbdjrsujuxferdsw] has joined #bitcoin-core-dev 12:26 < bitcoin-git> [bitcoin] practicalswift closed pull request #15189: validation: Add missing lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189 12:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fbdjrsujuxferdsw] has left #bitcoin-core-dev [] 12:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 12:31 < wumpus> how does the "Needs gitian build" label work? I've added it to #15188, does this mean it will automatically pick it up? 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/15188 | Update zmq to 4.3.1 by rex4539 · Pull Request #15188 · bitcoin/bitcoin · GitHub 12:33 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 12:37 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 12:44 -!- promag [~promag@2.83.246.44] has joined #bitcoin-core-dev 12:44 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev 12:45 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-kwdkgdsfuwizoile] has quit [Quit: Connection closed for inactivity] 12:45 -!- promag [~promag@2.83.246.44] has quit [Remote host closed the connection] 12:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 12:57 < luke-jr> wumpus: fwiw, it's not exactly pretty, but I haven't had any problem reports from https://github.com/bitcoinknots/bitcoin/commit/8261704f7fec4e3879f2b018fc27eb8834e698a6 so far 13:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:04 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:04 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 13:06 -!- Chuck_ [c43414d4@gateway/web/freenode/ip.196.52.20.212] has quit [Quit: Page closed] 13:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 13:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cjqwhhdimfeviika] has joined #bitcoin-core-dev 13:17 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12b30105fc59...cd42553b1178 13:17 < bitcoin-git> bitcoin/master 7c572c4 Hennadii Stepanov: Add workaround for QProgressDialog bug on macOS... 13:17 < bitcoin-git> bitcoin/master cd42553 Jonas Schnelli: Merge #15040: qt: Add workaround for QProgressDialog bug on macOS... 13:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cjqwhhdimfeviika] has left #bitcoin-core-dev [] 13:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbgbfaqlbkxpsegi] has joined #bitcoin-core-dev 13:18 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #15040: qt: Add workaround for QProgressDialog bug on macOS (master...20181226-fix-macos-qprogressdialog) https://github.com/bitcoin/bitcoin/pull/15040 13:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbgbfaqlbkxpsegi] has left #bitcoin-core-dev [] 13:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 13:24 < jonasschnelli> This is eventually ready #14353 (maybe another review)? 13:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub 13:28 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 13:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzzmatqdpjqbpyua] has joined #bitcoin-core-dev 13:29 < bitcoin-git> [bitcoin] practicalswift opened pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache() and benchmarks/tests. Add annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192 13:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzzmatqdpjqbpyua] has left #bitcoin-core-dev [] 13:31 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 13:32 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-okfffhlystfsnjrn] has joined #bitcoin-core-dev 13:32 < bitcoin-git> [bitcoin] practicalswift closed pull request #11652: Add missing locks: validation.cpp + related (master...init-and-validation-locks) https://github.com/bitcoin/bitcoin/pull/11652 13:32 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-okfffhlystfsnjrn] has left #bitcoin-core-dev [] 13:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:39 -!- AJ__ [43fbc19a@gateway/web/freenode/ip.67.251.193.154] has joined #bitcoin-core-dev 13:40 -!- AJ__ [43fbc19a@gateway/web/freenode/ip.67.251.193.154] has quit [Client Quit] 13:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 13:47 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 13:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ifvygthbahdzqfgv] has joined #bitcoin-core-dev 13:55 < bitcoin-git> [bitcoin] sdaftuar opened pull request #15193: Default -whitelistforcelay to off (master...2019-01-forcerelayoff) https://github.com/bitcoin/bitcoin/pull/15193 13:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ifvygthbahdzqfgv] has left #bitcoin-core-dev [] 14:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 14:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:06 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 14:13 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:32 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 14:49 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 15:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:04 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [] 15:05 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com] 15:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:17 < dongcarl> Any further review on https://github.com/bitcoin/bitcoin/pull/14605 ? 15:29 -!- gatangan36 [ac3a4bdb@gateway/web/freenode/ip.172.58.75.219] has joined #bitcoin-core-dev 15:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ozmisdxenlgbwiye] has joined #bitcoin-core-dev 15:29 < bitcoin-git> [bitcoin] dongcarl opened pull request #15194: Add comment describing fDisconnect behavior (master...2019-01-add-fDisconnect-comment) https://github.com/bitcoin/bitcoin/pull/15194 15:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ozmisdxenlgbwiye] has left #bitcoin-core-dev [] 15:29 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 15:30 -!- gatangan36 [ac3a4bdb@gateway/web/freenode/ip.172.58.75.219] has quit [Client Quit] 15:33 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.3] 15:34 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 15:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:35 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 15:38 < fanquake> wumpus looks like that might be the case 15:38 < fanquake> dongcarl congrats on the Chaincode hire 15:39 < dongcarl> Haha thank you thank you :-) 15:40 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 15:46 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 15:47 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 16:15 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds] 16:16 -!- xor216 [~a1@ip-94-113-168-42.net.upcbroadband.cz] has joined #bitcoin-core-dev 16:36 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:36 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 245 seconds] 16:39 -!- riemann_ [~riemann@217.96.166.17.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 16:41 -!- riemann [~riemann@217.96.175.73.ipv4.supernova.orange.pl] has quit [Ping timeout: 240 seconds] 16:43 < promag> dongcarl: sorry didn't complete the review 16:43 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has quit [Ping timeout: 245 seconds] 16:44 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has quit [Ping timeout: 245 seconds] 16:44 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 16:45 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jcalcczeksobmhrn] has quit [Quit: Connection closed for inactivity] 16:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xdbbdskbszeqecvz] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] promag opened pull request #15195: gui: Add close wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195 16:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xdbbdskbszeqecvz] has left #bitcoin-core-dev [] 16:47 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 17:09 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 17:25 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:33 -!- xor216 [~a1@ip-94-113-168-42.net.upcbroadband.cz] has left #bitcoin-core-dev [] 17:35 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:37 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 17:40 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 17:45 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 17:50 -!- brianhoffman_ [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev 17:51 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 17:51 -!- riemann [~riemann@217.96.166.17.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 17:52 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 17:52 -!- TheRec_ [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 17:52 -!- TheRec_ [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 17:52 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 17:53 -!- StopAndDecrypt_ [~StopAndDe@pool-141-155-179-159.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 17:55 -!- IGHOR_ [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:55 -!- achow101_ [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 17:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 17:56 -!- asoltys_ [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 17:57 -!- mistergold [~mistergol@185.37.26.7] has quit [Quit: leaving] 17:58 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Disconnected by services] 17:58 -!- achow101_ is now known as achow101 17:59 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 18:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:00 -!- Netsplit *.net <-> *.split quits: rafalcpp_, Bullit, TheRec, IGHOR, StopAndDecrypt, schmidty, brianhoffman, asoltys, riemann_, rh0nj, (+1 more, use /NETSPLIT to show all of them) 18:00 -!- brianhoffman_ is now known as brianhoffman 18:01 -!- Netsplit over, joins: rh0nj 18:02 -!- Pasha is now known as Cory 18:17 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 18:25 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:28 -!- m8tion [~user@88.190.249.49] has quit [Remote host closed the connection] 18:40 -!- jarthur [~jarthur@207.114.244.5] has quit [] 18:45 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 18:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 19:04 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 19:04 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:05 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:23 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 245 seconds] 19:24 -!- arshbot [~harshagol@104.222.154.114] has joined #bitcoin-core-dev 19:26 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:50 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 19:51 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:52 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 19:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:56 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:00 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:03 -!- schnerch_ [~schnerchi@p54A797A2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:06 -!- schnerchi [~schnerchi@p54A7947D.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 20:07 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:09 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:11 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Remote host closed the connection] 20:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 20:13 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 20:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds] 20:30 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:41 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 20:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jtvyogpbkzzqmszv] has joined #bitcoin-core-dev 20:54 < bitcoin-git> [bitcoin] gkrizek opened pull request #15196: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196 20:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jtvyogpbkzzqmszv] has left #bitcoin-core-dev [] 20:56 < gkrizek> wumpus: ^ 21:11 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 245 seconds] 21:15 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-vmnsrfpxkgmousjy] has joined #bitcoin-core-dev 21:17 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:25 -!- Mutter [~Mutter@88.202.183.119] has joined #bitcoin-core-dev 21:26 -!- Mutter_ [~Mutter@92.40.248.115.threembb.co.uk] has joined #bitcoin-core-dev 21:27 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds] 21:30 -!- Mutter [~Mutter@88.202.183.119] has quit [Ping timeout: 240 seconds] 21:30 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 21:38 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:39 -!- Mutter_ [~Mutter@92.40.248.115.threembb.co.uk] has quit [Quit: Mutter: www.mutterirc.com] 22:02 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 22:03 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 22:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 22:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 22:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 22:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds] 22:23 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 22:26 -!- Alixe [310e9c8b@gateway/web/freenode/ip.49.14.156.139] has joined #bitcoin-core-dev 22:27 < Alixe> Hello 22:27 < Alixe> Can I ask questions here regarding full node? 22:29 < arshbot> shoot 22:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 22:31 < Alixe> So I think mining hash power can't do anything because full nodes enforce consensus rules. But some people think governments or corporates can buy a lot of nodes to affect Bitcoin with having majority of full nodes. Is it possible? 22:32 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:32 < sipa> #bitcoin 22:33 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds] 22:40 < Alixe> I really want to know devs opinion on this 22:41 < luke-jr> Alixe: this is not "talk to devs", it is "talk about development", and your question is not about development. some of us are in #bitcoin too 22:41 -!- arshbot [~harshagol@104.222.154.114] has quit [Ping timeout: 272 seconds] 22:42 -!- farmerwampum [~farmerwam@184.75.220.106] has joined #bitcoin-core-dev 22:43 -!- farmerwampum [~farmerwam@184.75.220.106] has left #bitcoin-core-dev [] 22:51 < Alixe> I guess everyone is busy 22:51 < Alixe> Will ask on slack maybe 22:51 -!- Alixe [310e9c8b@gateway/web/freenode/ip.49.14.156.139] has quit [Quit: Page closed] 23:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbuklxvdezqbzryx] has joined #bitcoin-core-dev 23:04 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197 23:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbuklxvdezqbzryx] has left #bitcoin-core-dev [] 23:07 < wumpus> gkrizek: thanks! 23:08 < gkrizek> No problem! 23:28 -!- guga [~guga@i59F4D7C3.versanet.de] has joined #bitcoin-core-dev 23:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:31 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 23:33 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:34 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 23:40 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:52 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 23:55 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:57 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 252 seconds] 23:57 -!- guga [~guga@i59F4D7C3.versanet.de] has quit [Read error: Connection reset by peer] 23:57 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer] 23:58 -!- guga [~guga@i59F4D7C3.versanet.de] has joined #bitcoin-core-dev 23:58 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:58 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev --- Log closed Fri Jan 18 00:00:24 2019