--- Log opened Thu Jan 31 00:00:36 2019
00:22 -!- ChA1NsAw [~ChA1NsAw@ptr-bwwzb6md6n3dwrdrqou.18120a2.ip6.access.telenet.be] has joined #bitcoin-core-dev
01:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:34 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:39 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
01:48 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:51 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cb77dc820f1b...37d09b251cd7
01:51 < bitcoin-git> bitcoin/master a6cd50d Hennadii Stepanov: Add gitian PGP key for hebasto
01:51 < bitcoin-git> bitcoin/master 37d09b2 Wladimir J. van der Laan: Merge #15275: Add gitian PGP key for hebasto
01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:51 < bitcoin-git> [bitcoin] laanwj merged pull request #15275: Add gitian PGP key for hebasto (master...0190128-gitian-key) https://github.com/bitcoin/bitcoin/pull/15275
01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:58 -!- awanacoin [~awanacoin@2a02:a452:d14a:1:74e0:9a87:6a98:adf2] has joined #bitcoin-core-dev
01:59 -!- rex4539 [~rex4539@ppp-2-86-202-147.home.otenet.gr] has quit [Quit: rex4539]
02:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds]
02:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
02:27 -!- awanacoin [~awanacoin@2a02:a452:d14a:1:74e0:9a87:6a98:adf2] has quit [Quit: Leaving]
02:30 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 244 seconds]
02:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
02:41 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev
02:41 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:51 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
02:53 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
02:57 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev
02:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
03:09 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:13 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
03:14 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
03:16 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
03:20 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
03:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:41 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
03:42 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
03:42 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
03:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
03:48 -!- anome [~anome@unaffiliated/anome] has quit []
03:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
03:55 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
04:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
04:18 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev
04:20 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds]
04:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:22 < bitcoin-git> [bitcoin] instagibbs closed pull request #15283: log: Fix UB with bench on genesis block (master...ub_genesis_bench) https://github.com/bitcoin/bitcoin/pull/15283
04:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:22 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
04:22 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
04:24 < fanquake> the bot is back
04:24 < wumpus> yess
04:27 < wumpus> it's working great now!
04:29 -!- anome [~anome@unaffiliated/anome] has quit []
04:29 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev
04:30 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
04:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37d09b251cd7...b9d3df8bcd0e
04:33 < bitcoin-git> bitcoin/master f24ed6d Martin Erlandsson: Delete README_osx.md and move its contents into build-osx.md
04:33 < bitcoin-git> bitcoin/master b9d3df8 Wladimir J. van der Laan: Merge #15176: docs: Get rid of badly named readme
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] laanwj merged pull request #15176: docs: Get rid of badly named readme (master...rename-osx-readme) https://github.com/bitcoin/bitcoin/pull/15176
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:35 < fanquake> wumpus #15272 probably mergable
04:35 < gribble> https://github.com/bitcoin/bitcoin/issues/15272 | doc: correct logging return type and RPC example by fanquake · Pull Request #15272 · bitcoin/bitcoin · GitHub
04:35 < wumpus> fanquake: will take a look thanks
04:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:38 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9d3df8bcd0e...a0d657bd311e
04:38 < bitcoin-git> bitcoin/master e1c27da fanquake: doc: correct logging rpc return type and example
04:38 < bitcoin-git> bitcoin/master a0d657b Wladimir J. van der Laan: Merge #15272: doc: correct logging return type and RPC example
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:39 < bitcoin-git> [bitcoin] laanwj merged pull request #15272: doc: correct logging return type and RPC example (master...rpc-logging-return-example) https://github.com/bitcoin/bitcoin/pull/15272
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
04:42 < wumpus> fanquake: i think the comment to add a test makes sense, but also think it's out of scope for the PR which is a documentation fix
04:43 < fanquake> wumpus No worries, I can follow up with a test.
04:44 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 240 seconds]
04:45 -!- anome [~anome@unaffiliated/anome] has quit []
04:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
04:47 < wumpus> fanquake: sure, if you want!
04:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
05:02 -!- cia [67f0a95b@gateway/web/freenode/ip.103.240.169.91] has joined #bitcoin-core-dev
05:03 -!- cia is now known as Guest84790
05:03 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev
05:04 -!- Guest84790 [67f0a95b@gateway/web/freenode/ip.103.240.169.91] has quit [Client Quit]
05:05 -!- adamantines3 [31f81daa@gateway/web/freenode/ip.49.248.29.170] has joined #bitcoin-core-dev
05:06 -!- adamantines3 [31f81daa@gateway/web/freenode/ip.49.248.29.170] has quit [Client Quit]
05:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
05:15 < wumpus> gah what is it with github and losing comments
05:15 < wumpus> sometimes it feels like I have to make the same review comment at least three times
05:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
05:16 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
05:17 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
05:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
05:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
05:24 -!- anome [~anome@unaffiliated/anome] has quit []
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0d657bd311e...36aeb43c01d2
05:26 < bitcoin-git> bitcoin/master fa3745b MarcoFalke: qa: Add tests for invalid message headers
05:26 < bitcoin-git> bitcoin/master 36aeb43 Wladimir J. van der Laan: Merge #15246: qa: Add tests for invalid message headers
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] laanwj merged pull request #15246: qa: Add tests for invalid message headers (master...Mf1901-qaMsgHeader) https://github.com/bitcoin/bitcoin/pull/15246
05:26 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- anome [~anome@unaffiliated/anome] has quit [Client Quit]
05:29 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has joined #bitcoin-core-dev
05:29 < promag> jnewbery: could you add #15297 to the multi wallet issue?
05:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
05:34 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
05:40 -!- thedevworks_ [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
05:40 -!- thedevworks_ [~thedevwor@185.49.169.22] has quit [Client Quit]
05:40 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Quit: Leaving]
05:40 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
05:41 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has quit [Remote host closed the connection]
05:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
05:48 < thedevworks> Hey All - New here - Let me know if theres any 'Good First Issues' come up! 
05:50 < gkrizek> thedevworks The best place to look is in the GitHub repo. If you look in the Issues list there are some with a label of “Good First Issue”
05:52 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:52 < wumpus> yeh https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
05:53 < thedevworks> Thanks! 
05:53 < thedevworks> Makes sense ;) 
05:53 < wumpus> welcome btw !
05:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
05:56 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has joined #bitcoin-core-dev
05:59 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has quit [Remote host closed the connection]
06:00 < thedevworks> Thanks! 
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:11 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/36aeb43c01d2...7c09e209ef31
06:11 < bitcoin-git> bitcoin/master 14bcdbe Andrew Chow: Check for more than private keys disabled to show receive button
06:11 < bitcoin-git> bitcoin/master 2bc4c3e Andrew Chow: Notify the GUI that the keypool has changed to set the receive button
06:11 < bitcoin-git> bitcoin/master 7c09e20 Wladimir J. van der Laan: Merge #15225: GUI: Change the receive button to respond to keypool state c...
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:12 -!- thedevworks_ [~thedevwor@185.183.107.217] has joined #bitcoin-core-dev
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:12 < bitcoin-git> [bitcoin] laanwj merged pull request #15225: GUI: Change the receive button to respond to keypool state changing (master...receive-button) https://github.com/bitcoin/bitcoin/pull/15225
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:14 -!- thedevworks_ [~thedevwor@185.183.107.217] has quit [Client Quit]
06:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
06:14 -!- thedevworks_ [~thedevwor@185.183.107.217] has joined #bitcoin-core-dev
06:15 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 246 seconds]
06:17 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
06:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
06:18 -!- thedevworks_ is now known as thedevworks
06:21 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
06:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
06:23 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:30 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7c09e209ef31...4d661baf1aca
06:30 < bitcoin-git> bitcoin/master f96dbd1 Gregory Sanders: gdb attaching to process during tests has non-sudo solution
06:30 < bitcoin-git> bitcoin/master 4d661ba Wladimir J. van der Laan: Merge #15244: gdb attaching to process during tests has non-sudo solution
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:30 < bitcoin-git> [bitcoin] laanwj merged pull request #15244: gdb attaching to process during tests has non-sudo solution (master...gdb_ptrace) https://github.com/bitcoin/bitcoin/pull/15244
06:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to .17: https://github.com/bitcoin/bitcoin/compare/09a9238c0456...30db5cc6418a
06:35 < bitcoin-git> bitcoin/.17 0cd9ad2 João Barbosa: rpc: Make unloadwallet wait for complete wallet unload
06:35 < bitcoin-git> bitcoin/.17 30db5cc Wladimir J. van der Laan: Merge #15002: 0.17: Backport #14941
06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:36 < bitcoin-git> [bitcoin] laanwj merged pull request #15002: 0.17: Backport #14941 (.17...018-12-backport-14941) https://github.com/bitcoin/bitcoin/pull/15002
06:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:38 -!- laurentmt [~Thunderbi@94.242.228.173] has joined #bitcoin-core-dev
06:39 < hebasto> wumpus: regarding your comment on #15278 - what kind of services are counting on the PID file?
06:39 < gribble> https://github.com/bitcoin/bitcoin/issues/15278 | Improve pidfile logging by hebasto · Pull Request #15278 · bitcoin/bitcoin · GitHub
06:40 -!- laurentmt [~Thunderbi@94.242.228.173] has quit [Client Quit]
06:40 < wumpus> I'm not sure I understand your question
06:41 < wumpus> I mean the obvious answer would be "services that need to know running bitcoind's process id"
06:41 < hebasto> wumpus: why do you suppose that not being able to create the PID file should be fatal?
06:41 < wumpus> because it would be deterministic?
06:41 < hebasto> aah, I see.
06:41 < wumpus> either you make sure the PID file exists when the process is running
06:41 < wumpus> or you don't create one in the first place
06:42 < wumpus> I don't see the intermediate 'launch the process but don't create a PID file' as useful
06:42 < wumpus> but that might be just me :)
06:42 < sdaftuar> wumpus: i concur :)
06:43 < hebasto> wumpus: sdaftuar: thanks
06:44 < wumpus> this is doubly important imo when providing an alternative pid file path with `-pid=...`, because unlike the data directory it might not be a guaranteed-writable location so the user could have made a mistake with permissions
06:46 < wumpus> hebasto: anyhow it's perfectly fine if you think that's out of scope for #15278, it just surprised me
06:46 < gribble> https://github.com/bitcoin/bitcoin/issues/15278 | Improve pidfile logging by hebasto · Pull Request #15278 · bitcoin/bitcoin · GitHub
06:46 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
06:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
06:48 < hebasto> wumpus: initially, I thought that behavior was intended. Now I am going to improve PR adding fail condition, if you don't mind.
06:49 < wumpus> hebasto: thanks!
06:51 -!- laurentmt [~Thunderbi@94.242.228.173] has joined #bitcoin-core-dev
06:53 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 246 seconds]
06:54 -!- laurentmt [~Thunderbi@94.242.228.173] has quit [Client Quit]
06:55 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:02 < bitcoin-git> [bitcoin] promag opened pull request #15299: Fix assertion in CKey::SignCompact (master...019-01-ckey-signcompact) https://github.com/bitcoin/bitcoin/pull/15299
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:13 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
07:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
07:26 < sipa> 4~
07:27 < provoostenator> wumpus: I can't remember having lost a github comment recently. It gets a little iffy when opening the same PR in two tabs though.
07:28 < wumpus> provoostenator: ooh that might be part of the issue then
07:29 < fanquake> GH probably just collapsing more comments into uselessness
07:29 < wumpus> and that ^^
07:30 < provoostenator> Yeah the collapsing thing is different. That happens because we force-push and rebase a lot.
07:31 < provoostenator> I sometimes have two tabs open because I want to review commit by commit, and when I switch back to the main comment thread it forgets which commit I was looking at.
07:31 < fanquake> also collapsing on similar comments. i.e 2-3 "utACK commit_hash" comments in a row, the last two may get hidden as "similar comments".
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] achow101 opened pull request #15301: tests: When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists (master...fix-tests-cli-args) https://github.com/bitcoin/bitcoin/pull/15301
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:40 -!- promag [~promag@83.223.235.98] has quit [Remote host closed the connection]
07:42 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 268 seconds]
07:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
07:47 < wumpus> fanquake: I've seen that as well :(
07:48 < cjd> lol microsoft, 1 job
07:53 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:53 < fanquake> When throwing RPC_DESERIALIZATION_ERROR, for ex when deserializing a tx, is "TX decode failed" or more verbosity preferred, i.e "TX decode failed CDataStream::read(): end of data: unspecified iostream_category error"?
07:53 < fanquake> RPCs currently use a mix of the two.
07:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
07:54 < wumpus> fanquake: I personally prefer more detailed error messages where possible
07:55 < wumpus> (though something can be said for the opposite as well, as in "don't leak implementation details")
08:00 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4d661baf1aca...252fd15addf1
08:10 < bitcoin-git> bitcoin/master 49d2374 Jonas Schnelli: [tools] Add wallet inspection and modification tool
08:10 < bitcoin-git> bitcoin/master 3c3e31c João Barbosa: [tests] Add wallet-tool test
08:10 < bitcoin-git> bitcoin/master 252fd15 MarcoFalke: Merge #13926: [Tools] bitcoin-wallet - a tool for creating and managing wa...
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #13926: [Tools] bitcoin-wallet - a tool for creating and managing wallets offline (master...wallet_tool) https://github.com/bitcoin/bitcoin/pull/13926
08:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:14 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
08:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
08:18 < provoostenator> p2p_invalid_messages.py seems to fail more than average... https://travis-ci.org/bitcoin/bitcoin/jobs/486996280
08:21 < provoostenator> Not sure if that was before or after #15246, so maybe just ignore it...
08:21 < gribble> https://github.com/bitcoin/bitcoin/issues/15246 | qa: Add tests for invalid message headers by MarcoFalke · Pull Request #15246 · bitcoin/bitcoin · GitHub
08:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
08:23 -!- thedevworks_ [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
08:26 -!- thedevworks [~thedevwor@185.183.107.217] has quit [Ping timeout: 250 seconds]
08:28 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:29 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
08:30 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
08:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:34 -!- promag [~promag@83.223.235.98] has quit [Ping timeout: 240 seconds]
08:44 -!- kexkey [~kexkey@37.120.130.20] has joined #bitcoin-core-dev
08:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
08:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
08:55 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds]
08:57 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:01 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:05 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/252fd15addf1...efb6ddef9cb3
09:05 < bitcoin-git> bitcoin/master f1f4bb7 Russell Yanofsky: Free BerkeleyEnvironment instances when not in use
09:05 < bitcoin-git> bitcoin/master 88b1d95 Pierre Rochard: Tests: add unit tests for GetWalletEnv
09:05 < bitcoin-git> bitcoin/master 14bc2a1 Pierre Rochard: Trivial: add doxygen-compatible comments relating to BerkeleyEnvironment
09:06 -!- promag [~promag@83.223.235.98] has quit [Ping timeout: 244 seconds]
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:06 < bitcoin-git> [bitcoin] laanwj merged pull request #11911: Free BerkeleyEnvironment instances when not in use (master...pr/countenv) https://github.com/bitcoin/bitcoin/pull/11911
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG (master...Mf1901-travisFun) https://github.com/bitcoin/bitcoin/pull/15303
09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:16 -!- thedevworks_ [~thedevwor@185.49.169.22] has quit [Quit: Leaving]
09:22 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
09:27 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
09:28 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
09:29 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
09:31 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
09:32 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
09:38 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
09:39 -!- harding [~quassel@li1228-87.members.linode.com] has quit [Remote host closed the connection]
09:42 -!- promag [~promag@83.223.235.98] has quit [Remote host closed the connection]
09:52 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
09:56 -!- harding [~quassel@li1258-130.members.linode.com] has joined #bitcoin-core-dev
10:02 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:14 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efb6ddef9cb3...4b6673d38261
10:14 < bitcoin-git> bitcoin/master 3617f11 João Barbosa: Fix assertion in CKey::SignCompact
10:14 < bitcoin-git> bitcoin/master 4b6673d Wladimir J. van der Laan: Merge #15299: Fix assertion in CKey::SignCompact
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:15 < bitcoin-git> [bitcoin] laanwj merged pull request #15299: Fix assertion in CKey::SignCompact (master...019-01-ckey-signcompact) https://github.com/bitcoin/bitcoin/pull/15299
10:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:22 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
10:28 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 240 seconds]
10:29 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
10:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:51 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
10:54 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
10:55 < promag> meeting in 5?
10:55 < wumpus> yes
10:56 < jamesob> oh man it's already thursday
10:58 < wumpus> yess
10:59 < sdaftuar> hi
10:59 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has joined #bitcoin-core-dev
11:00 < jamesob> hi
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Jan 31 19:00:06 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < achow101> hi
11:00 < jnewbery> hi
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
11:00 < dongcarl> hi
11:00 < meshcollider> hi
11:00 < instagibbs> hola
11:00 < wumpus> topics?
11:01 < jonasschnelli> hi
11:01 < promag> hi
11:01 < gwillen> buenos dias
11:01 < luke-jr> I want to suggest we change rebasing policy/expectations
11:01 < promag> boa noite
11:01 < sipa> hello, half here
11:01 < wumpus> #topic High priority for review
11:02 < wumpus> https://github.com/bitcoin/bitcoin/projects/8
11:02 < provoostenator> hi
11:02 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
11:02 < wumpus> still 7 PRs left, don't think we should add anything
11:03 < wumpus> but open to suggestions if there's replacements etc that need to be made
11:03 < promag> would appreciate some more feedback on #15153 (and it's dependency)
11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
11:04 < wumpus> note that tomorrow is strings freeze for 0.18
11:04 < jnewbery> promag: I'm going to try to look at that today
11:04 < wumpus> and in two weeks the feature freeze
11:05 < promag> jnewbery: maybe we should postpone multiwallet gui for 0.19? and maybe backport to 0.18.1?
11:05 < sdaftuar> i would like to review beg for #14897 -- in addition to being a useful feature in its own right, it paves the way for several simple transaction download improvements (some of which i'm hoping could land in 0.18)
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
11:05 < jamesob> will take a look today (fwiw)
11:05 < wumpus> sdaftuar: that one is already in high prio I think?
11:05 < sdaftuar> wumpus: yep
11:06 < sdaftuar> i think it's nearly ready (the nits i left on the PR could be dealt with later)
11:06 < sdaftuar> but needs more review
11:06 < wumpus> okay, great!
11:06 < jnewbery> #11082 has required rebase for 10 days and has outstanding review comments from December. Should it be removed from high priority?
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
11:07 < provoostenator> jnewbery: I don't think it's a good idea to merge that so close to release, as much as I'd like to have it
11:07 < provoostenator> Also it doesn't really do anything on its own afaik, and the stuff on top of it isn't ready.
11:07 < wumpus> I tend to agree
11:07 < wumpus> okay, going to remove it
11:08 < provoostenator> As for multiwallet: it would be nice to get opening a wallet in
11:08 -!- Krellan [~Krellan@2601:640:4000:a876:ac5e:6dfa:8077:7ec1] has quit [Remote host closed the connection]
11:08 < provoostenator> But not end of the world if not.
11:08 < jnewbery> I agree with trying to get multiwallet open into v0.18
11:08 < jonasschnelli> Agree. Open wallet would be nice.
11:08 < promag> I know I have one HP PR, but it depends on #15280 so if you don't mind that could be in the list too
11:08 < wumpus> #15153 is on the high prio list
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15280 | gui: Fix shutdown order by promag · Pull Request #15280 · bitcoin/bitcoin · GitHub
11:08 < sdaftuar> if we're thinking about pruning from the high priority list to focus on 0.18, then i think #15141 could be removed as well.  it's ready for review but not essential for 0.18 IMO (and maybe we'd want it to simmer in master for longer before a release anyway)
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
11:09 < jamesob> likewise for #15118 if 0.18 is the focus
11:09 < provoostenator> wumpus: regarding strings, if some GUI changes misses the string deadline, then that part is just English-only, right?
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/15118 | Refactor block file logic by jimpo · Pull Request #15118 · bitcoin/bitcoin · GitHub
11:09 < wumpus> sdaftuar: nah not necessarily! it's just that if PRs have outstanding comments for a long time, and are not being updated, there's not that much urgency apparently
11:09 < provoostenator> Or does it explode?
11:10 < wumpus> provoostenator: idieally it would be avoided completely, but yes that's the effect
11:10 < wumpus> provoostenator: I'm okay with *adding* strings after that if we can't avoid it, but not changing them
11:11 < sdaftuar> wumpus: ok happy to keep it on there too, it's holding up other work i have going on!  we can revisit as we get closer to feature freeze i guess
11:11 < wumpus> (e.g. no "improve wording" PRs)
11:11 < wumpus> but yeah it's good to give the translators some time
11:13 < wumpus> ok, that concludes the topic I think
11:14 < wumpus> #topic rebasing policy/expectations (luke-jr)
11:14 < promag> we don't require rebase do we?
11:14 < luke-jr> a lot of time seems wasted on rebasing needlessly; I'd like to suggest we only expect rebasing when there's a major conflict, or the PR is literally about to be merged
11:15 < luke-jr> promag: apparently some people consider it a show-stopper on progress for PRs if it "needs" rebase
11:16 < wumpus> people usually want to test PRs on top of master, which is not straightforward if they need rebase, but yea for review it shouldn't strictly be necessary
11:16 < wumpus> it's up to you really
11:16 < promag> I think that's "requested" after trivial review
11:17 < meshcollider> Rebase can often partially invalidate reviews anyway unless its trivial in which case theres no point not doing it
11:17 < provoostenator> Lack of rebase normally won't stop me from reviewing, unless I expect a problem. 
11:17 < wumpus> though everything that makes people more willing to review your PR might be welcome given how many there are ...
11:17 < provoostenator> Maybe though we need additional tag "Really Needs Rebase"
11:17 < wumpus> I had it under 242 some weeks ago but ugh
11:17 < luke-jr> well, we have a bot more recently that closes stuff and nags over even trivial rebases
11:18 < provoostenator> Ah that's a good point, maybe Drahtbot should be less aggressive in that regard.
11:18 < provoostenator> Only close if Really Needs Rebase is set? :-)
11:18 < wumpus> drahtbot doesn't close PRs
11:18 < jnewbery> I think Drahtbot only closes if a PR has needed rebase for a _really_ long time
11:19 < achow101> drahtbot will close and reopen PRs to retrigger travis
11:19 < wumpus> it only adds a label "needs rebase" and posts a message in that regard
11:19 < jamesob> doesn't drahtbot only ask for a rebase if there are conflicts?
11:19 < meshcollider> It does after like a very long time and tags it with up for grabs
11:19 < meshcollider> Close PRs ^
11:19 < wumpus> meshcollider: I don't think it does so automatically 
11:19 < wumpus> or at least I've never noticed
11:20 < jamesob> drahtbot does close and mark up-for-grabs, e.g. #13200
11:20 < jnewbery> example: https://github.com/bitcoin/bitcoin/pull/12965#issuecomment-423611058
11:20 < luke-jr> part of my motivation for bringing this up, is that (without naming names) we've apparently lost devs in part over the constant rebasing
11:20 < gribble> https://github.com/bitcoin/bitcoin/issues/13200 | Process logs in a separate thread by jamesob · Pull Request #13200 · bitcoin/bitcoin · GitHub
11:20 < promag> FWIW I don't mind rebasing
11:20 < meshcollider> Marco runs an extra script occasionally I think
11:20 < wumpus> though if it's after a very long time I don't mind ...
11:20 < provoostenator> I've seen it happen a few times as well
11:20 < wumpus> there's probaly quite a few PRs that could be closed
11:20 < provoostenator> But often the problem isn't a lack of rebase, it's either a lack of feedback or a lack of addressing feedback.
11:20 < wumpus> sometimes I just want to close them all and start anew xD
11:21 < sdaftuar> luke-jr: i agree with the sentiment you bring up, but its unclear to me how much of the irritation is from being nagged about rebasing, versus the repo activity that is requiring so many rebases in the first place
11:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
11:21 < jnewbery> wumpus: I agree. If something's needed rebase for > 6 months then it's clearly not a priority for the contributor. It can always be re-opened if it becames a priority
11:21 < jonasschnelli> also,... there are some PR not meant to be merged (WIP / Experimental)
11:21 < wumpus> jonasschnelli: I think that's great
11:21 < provoostenator> jnewbery: not necessarily, there's no point in rebasing if you're not getting enough concept ACK and agreement on technical direction
11:21 < wumpus> (if they're clearly marked as that)
11:22 < jonasschnelli> Yes. Some PR are to attract developers and spun up new ideas
11:22 < provoostenator> So it could be a priority for the developer, just not for the reviewers.
11:22 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
11:23 < jnewbery> provoostenator: I think Draht only closes if there's been no activity at all. If you're not getting _any_ interaction from other contributors then again, it's probably not a priority for anyone
11:23 < wumpus> so it's a pretty busy repository and a lot of changes are happening, there's nothing to be done about that, it's the same for other popular open source projects
11:23 -!- myquidproquo [55f54f2e@gateway/web/freenode/ip.85.245.79.46] has joined #bitcoin-core-dev
11:23 < provoostenator> Ok, if _any_ activity is fine, then it's not unreasonable to expect e.g. the contributor themselves to give a quick "anybody out there?" update.
11:24 < luke-jr> wumpus: I think it would help, if maintainers indicated they're prepared to merge a PR, and it got rebased specifically for the merge. (assuming reviewers continue to review despite trivial rebases)
11:24 < wumpus> provoostenator: yes, that's fine!
11:24 < achow101> the only issue i have with rebases is that someone would comment "needs rebase", the author rebases, and then receives no reviews until the next "needs rebase" comment from someone
11:24 < wumpus> it's *really* common for a PR to be waiting for *any* response from the author to comments
11:24 < wumpus> even if that's "I prefer not to address this as it's out of scope"
11:24 < wumpus> but you need to reply to comments
11:24 < provoostenator> Yes, one thing that might help is if people are less shy to just take over PRs.
11:25 < provoostenator> achow101 took one over from me pretty quickly, changing it somewhat, which is great, saves me work.
11:25 < wumpus> no one is going to merge a PR with un-addressed comments
11:26 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
11:26 < wumpus> I mean we can prod people to review all we want, if reviews just go ignored there's no point
11:26 < provoostenator> A slightly less drastic alternative to opening an alternative PR is to link to a branch in the comments, but branches are not easy to review.
11:27 < provoostenator> Github, if you're listening, you should add a PR fork feature :-)
11:27 < wumpus> heh
11:27 < luke-jr> it'd be nice if the PR # could stay the same with multiple contributors :P
11:27 < jnewbery> Speaking from personal experience, I've never had much of an issue with rebases. I only ever have a handful of PRs open at maximum, so rebasing isn't too onerous. I think it only becomes a problem if you have a lot of open PRs
11:28 -!- myquidproquo [55f54f2e@gateway/web/freenode/ip.85.245.79.46] has quit [Ping timeout: 256 seconds]
11:28 < jamesob> rebasing should be MORE onerous ;)
11:28 < wumpus> it also depends on the kind of PR, if you only have localized changes it's not too bad
11:28 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
11:28 < sdaftuar> some PRs are definitely a pain to rebase
11:28 < provoostenator> It gets exponentially bad if you build multiple PRs on top of each other.
11:28 < wumpus> also means you need to rebase less often because there's less chance of it colliding with other changes
11:29 < wumpus> avoid change-all-over-the-place PRs
11:29 < jnewbery> provoostenator - shouldn't be exponential. In my experience it's sub-linear if the PRs are a series because rebasing the first is often the only actual work.
11:30 < jnewbery> (again, just personal experience. Yours may vary!)
11:30 < luke-jr> I think I have a tendency to rebase once per release, and on the rare occasion someone pings me for a merge
11:31 < jonasschnelli> A rebase quick before a merge is dangerous IMO...
11:31 < MarcoFalke> I agree with what meshcollider said earlier: [14:17] <meshcollider> Rebase can often partially invalidate reviews anyway unless its trivial in which case theres no point not doing it
11:31 < jonasschnelli> we had this in the past
11:31 < provoostenator> It might just be my lacking git skills, still haven't found an optimal way to say "start with master, add branch X, then branch Y, then rebase the new stuff on the current branch"
11:32 < jnewbery> I don't think this is actually a project-wide policy. I personally tend not to review PRs that have needed rebase for a long time because: - it signals that the contributor may not actively be working on the PR; - my review will be invalidated by the rebase anyway.
11:32 < jonasschnelli> Constant rebasing is part of QA (rebased versions gets reviews)... and a sadly necessary IMO
11:32 < MarcoFalke> Indeed, rebases often go wrong (as in the conflict is solved in the wrong way)
11:33 < provoostenator> I often check rebases with:  PREV=... N=... && git range-diff `git merge-base --all HEAD $PREV`...$PREV HEAD~$N...HEAD
11:33 < provoostenator> Where PREV is the last thing I acked, and N is the number of commits in the branch
11:33 < jonasschnelli> Also, constant rebasing makes you also up do date with changes around your code (which you otherwise would miss) *duck*
11:33 < wumpus> jnewbery: I agree
11:34 < wumpus> and yes, this isn't a project-wide policy, but one that every reviewer determines for themselves, how do you consider what to review?
11:34 < provoostenator> Drahtbot might be able to help verify that a straight rebase is just that, maybe saying something like "existing ACK ... is the same as [new hash] rebased" 
11:35 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:35 < wumpus> I don' think we can make much progress here, besides knowing each other's perspective
11:35 < MarcoFalke> Also, DrahtBot will list all conflicts with other pull requests, so it should give some idea what best to review first or what to prioritize (or for the author) if it might help to split up the pull request into smaller changes
11:35 < luke-jr> provoostenator: that's trusting the bot a bit too much
11:36 < MarcoFalke> provoostenator: We don't need a rebase if it is a effective "fast forward"
11:36 < provoostenator> I didn't say "trust the bot"
11:36 < MarcoFalke> Either the bot tracks it as conflict or it doesn't need rebase
11:36  * sipa has little opinion
11:37 < wumpus> we don't have any other topics do we :<
11:37 < gwillen> provoostenator: I can probably answer git questions on "how to convince it to do X", given some details
11:37 < jnewbery> I'd like to quickly mention the residency again, but only at the end if we don't have other topics
11:37 < wumpus> PSA: release schedule for 0.18.0: https://github.com/bitcoin/bitcoin/issues/14438
11:38 < promag> even a straight rebase can result in broken travis
11:38 < wumpus> feature freeze is in roughly two weeks! hurry up :<
11:38  * sdaftuar types faster
11:38 < wumpus> hehe
11:38 < wumpus> March 1 is planned branch split-off
11:40 < wumpus> #topic Chaincode residency (jnewbery)
11:40 < jnewbery> Thanks wumpus. A couple of things: 1. I emailed a bunch of you to ask about mentorship. Thank you to everyone who replied!
11:41 < jnewbery> 2. we officially announced the residency today. We're still looking for great engineers who want to spend summer working on Bitcoin or Lightning with us. If you know anyone who might be appropriate, please send them our way at https://residency.chaincode.com/#apply
11:41 < jnewbery> (endtopic)
11:42 < wumpus> thanks!
11:43 < wumpus> anyone with other topics ?
11:45 < wumpus> #endmeeting
11:45 < lightningbot> Meeting ended Thu Jan 31 19:45:29 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:45 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-31-19.00.html
11:45 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-31-19.00.txt
11:45 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-31-19.00.log.html
11:47 < gwillen> provoostenator: although I guess specifically for what you're asking, I don't know of a better way than two rebases (first rebase X onto current, then rebase Y onto current) if I'm correly understanding 
11:47 < gwillen> correctly*
11:48 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
11:48 < provoostenator> gwillen: this incantation works for me:  PREV=... N=... && git range-diff `git merge-base --all HEAD $PREV`...$PREV HEAD~$N...HEAD
11:48 < provoostenator> It's ugly
11:49 < gwillen> heh, my git does not even have "range-diff"
11:49 < provoostenator> It's pretty new
11:49 < provoostenator> And very colorful.
11:49 < provoostenator> It shows stuff that's been added on top of what was added last time, etc
11:50 < gwillen> right, like the gitlab "changes to this PR since last force-push" feature
11:50 < gwillen> which I forget whether github has
11:52 < jnewbery> provoostenator: I not sure of exactly the scenario you're talking about. If you mean "I have PR X, and PR Y which builds on X, and X needs rebase", then I'd say don't bother updating Y at all. X needs to be merged before anyone should review Y. Once X is merged, reset Y onto master, then cherry-pick the Y commits, resolving conflicts as you go.
11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4b6673d38261...3b19d8e341a5
11:55 < bitcoin-git> bitcoin/master 5209106 Chun Kuan Lee: msvc: build secp256k1 locally
11:55 < bitcoin-git> bitcoin/master 82dcacb Chun Kuan Lee: msvc: build leveldb locally
11:55 < bitcoin-git> bitcoin/master 3b19d8e MarcoFalke: Merge #14372: msvc: build secp256k1 and leveldb locally
11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:55 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14372:  msvc: build secp256k1 and leveldb locally (master...018-10-02-msvc-code) https://github.com/bitcoin/bitcoin/pull/14372
11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:57 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:59 < provoostenator> jnewbery: oh wait, I was talking about the simpler task, during review, of checking what changed since the last rebase. That's what that incantation does.
12:00 < provoostenator> As for the scenario you refer to, the reason I would rebase is so I can keep working on it
12:00 < provoostenator> Usually the issue is that a new version of X fixes something that I need to continue working on Y.
12:00 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:01 < provoostenator> Another scenario is rebasing on master, when conflicts arise in X. In that case I usually just wait for the author of X do to the rebase, but then I get back to the above problem.
12:01 < jnewbery> ah ok, sorry. Thought you were still talking about the exponentially bad rebase problem!
12:01 < provoostenator> I think I need to use interactive rebase and then swap out commits with pick.
12:03 -!- harding [~quassel@li1258-130.members.linode.com] has quit [Remote host closed the connection]
12:03 -!- harding [~quassel@li1258-130.members.linode.com] has joined #bitcoin-core-dev
12:04 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
12:05 -!- dermoth_ [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
12:05 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Disconnected by services]
12:05 -!- dermoth_ is now known as dermoth
12:05 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
12:06 < jnewbery> my solution (and this isn't to say anyone else should do this): if I'm running too far ahead of review (too many PRs open, my PRs queued up behind other people's PRs, etc), then I switch focus to reviewing other people's PRs rather than continue writing code that no-one's going to review for the time being.
12:10 < promag> jnewbery: +1, I also pick a couple of issues I'm comfortable with and try to push a fix
12:11 < jonasschnelli> wumpus: would be nice if you could review #15091 since you commented on it.
12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/15091 | GUI: fix model overlay header sync by jonasschnelli · Pull Request #15091 · bitcoin/bitcoin · GitHub
12:11 < jonasschnelli> Its a bug fix and I think it should go into 0.18
12:11 < jonasschnelli> (no hurry though as not affected by the freeze)
12:14 -!- booyah [~bb@193.25.1.157] has quit [Quit: Konversation terminated!]
12:15 -!- promag [~promag@83.223.235.98] has quit [Remote host closed the connection]
12:16 < wumpus> jonasschnelli: sure !
12:16 < jonasschnelli> thanks
12:19 < provoostenator> jnewbery: I go back and forth between writing code in similar ways, though it also depends on my mood :-) 
12:19 < provoostenator> *between writing code and review
12:24 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
12:28 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
12:33 -!- spinza [~spin@155.93.246.187] has quit [Excess Flood]
12:35 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
12:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:47 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 250 seconds]
12:49 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
12:52 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:55 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev
13:03 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
13:11 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
13:13 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:15 < bitcoin-git> [bitcoin] sdaftuar opened pull request #15305: [validation] Crash if disconnecting a block fails (master...019-01-disconnect-failure-shutdown) https://github.com/bitcoin/bitcoin/pull/15305
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:19 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
13:35 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
13:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
13:43 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
13:58 -!- promag [~promag@83.223.235.98] has joined #bitcoin-core-dev
14:07 -!- Murch [~murch@172.56.39.247] has joined #bitcoin-core-dev
14:11 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
14:19 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
14:20 -!- Murch [~murch@172.56.39.247] has quit [Quit: Snoozing.]
14:21 -!- promag [~promag@83.223.235.98] has quit [Remote host closed the connection]
14:23 -!- promag_ [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
14:24 < jnewbery> Using the `--usecli` option makes tests run extremely slowly. See the `--usecli` tests here: https://travis-ci.org/bitcoin/bitcoin/jobs/487152891 for example. Reproduces locally for me.
14:24 < jnewbery> is this a known issue? I don't think this used to be the case
14:28 -!- promag_ [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3b19d8e341a5...cb35f1d305d8
14:32 < bitcoin-git> bitcoin/master 2e02341 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
14:32 < bitcoin-git> bitcoin/master cb35f1d MarcoFalke: Merge #15301: tests: When testing with --usecli, unify RPC arg to cli arg ...
14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15301: tests: When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists (master...fix-tests-cli-args) https://github.com/bitcoin/bitcoin/pull/15301
14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:34 < bitcoin-git> [bitcoin] jnewbery opened pull request #15307: [WIP] [tool] Add salvage and zaptxs commands to bitcoin-wallet (master...wallet_tool_zaptxs_salvage) https://github.com/bitcoin/bitcoin/pull/15307
14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:36 < bitcoin-git> [bitcoin] Empact closed pull request #14998: Run CI against ubuntu 14.04 (master...qt52) https://github.com/bitcoin/bitcoin/pull/14998
14:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:36 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
14:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:41 < bitcoin-git> [bitcoin] Empact opened pull request #15308: ci: Build and test Trusty against system libraries, fix incompatibilities (master...trusty-no-depends) https://github.com/bitcoin/bitcoin/pull/15308
14:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:58 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:00 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
15:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
15:18 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:24 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
15:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
15:38 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 245 seconds]
15:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:45 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:51 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
15:51 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:52 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
15:52 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
15:55 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
15:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
16:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
16:12 -!- ChA1NsAw [~ChA1NsAw@ptr-bwwzb6md6n3dwrdrqou.18120a2.ip6.access.telenet.be] has quit [Remote host closed the connection]
16:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
16:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Excess Flood]
16:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
16:31 < aj> jnewbery: yeah, wallet_multiwallet --usecli takes forever for me fwiw
16:32 < aj> jnewbery: like 5x as long as without --usecli
16:49 < sipa> could this be since RNG changes?
16:50 < gmaxwell> considering the rdrand and strenghtening fixes haven't been merged, I'd be surprised.
16:53 < aj> i'd seen it in december, as at cb52cee2 fwiw
17:01 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:03 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds]
17:15 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:34 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
17:34 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
17:38 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
17:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
17:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
18:08 -!- pinheadmz [~matthewzi@208.69.41.104] has joined #bitcoin-core-dev
18:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
18:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
18:22 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
18:32 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Read error: Connection reset by peer]
18:37 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving]
18:40 -!- pinheadmz [~matthewzi@208.69.41.104] has quit [Quit: pinheadmz]
18:45 -!- pinheadmz [~matthewzi@208.69.41.104] has joined #bitcoin-core-dev
18:56 -!- pinheadmz [~matthewzi@208.69.41.104] has quit [Quit: pinheadmz]
19:06 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
19:11 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
19:26 -!- pinheadmz [~matthewzi@208.69.41.104] has joined #bitcoin-core-dev
19:32 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
19:36 -!- pinheadmz [~matthewzi@208.69.41.104] has quit [Quit: pinheadmz]
19:43 < fanquake> aj I see the same, created #15309
19:43 < gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
20:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
20:13 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev
20:15 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds]
20:17 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
20:18 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:47 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
20:51 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
21:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:26 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
21:26 -!- profmac [~ProfMac@2001:470:1f0f:226:e5c2:9792:1f0f:4ded] has quit [Ping timeout: 240 seconds]
21:28 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
21:29 -!- profmac [~ProfMac@2001:470:1f0f:226:1dc8:6196:94ca:66d1] has joined #bitcoin-core-dev
21:29 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
21:30 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
21:31 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 245 seconds]
21:31 -!- harrymm [~harrymm@69.161.195.103] has quit []
21:32 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
21:34 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 244 seconds]
22:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
22:35 -!- andrewbenson [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has joined #bitcoin-core-dev
22:41 -!- leishman [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has joined #bitcoin-core-dev
22:44 -!- leishman [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has quit [Client Quit]
22:45 -!- leishman [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has joined #bitcoin-core-dev
22:48 -!- leishman [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has quit [Client Quit]
22:55 -!- andrewbenson [~Mutter@rrcs-50-74-174-227.nyc.biz.rr.com] has quit [Quit: Mutter: www.mutterirc.com]
23:02 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:05 -!- fanquake_ [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
23:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 250 seconds]
23:30 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
23:38 -!- fanquake_ [~fanquake@unaffiliated/fanquake] has quit []
23:46 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
23:53 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
23:58 -!- hashistnd [~hashist@157.157.113.86] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Feb 01 00:00:37 2019