--- Log opened Fri Feb 01 00:00:38 2019
00:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
00:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
00:31 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Ping timeout: 240 seconds]
00:37 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:38 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
00:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
00:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
00:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
01:01 -!- hashist [~hashist@157.157.113.86] has joined #bitcoin-core-dev
01:02 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]
01:28 -!- mistergold [~mistergol@185.37.27.207] has joined #bitcoin-core-dev
01:39 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Ping timeout: 268 seconds]
02:03 -!- kexkey [~kexkey@37.120.130.20] has quit [Read error: Connection reset by peer]
02:07 -!- promag [~promag@193.126.224.118] has joined #bitcoin-core-dev
02:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:11 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:14 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
02:15 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
02:40 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:51 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
03:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:59 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539]
04:00 -!- promag [~promag@193.126.224.118] has quit [Remote host closed the connection]
04:13 -!- mistergold [~mistergol@185.37.27.207] has quit [Read error: Connection reset by peer]
04:14 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
04:18 -!- mistergold [~mistergol@77.243.31.101] has joined #bitcoin-core-dev
04:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds]
04:35 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:43 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev
04:49 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev
04:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
04:56 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.3]
05:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:02 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cb35f1d305d8...3e38d4087379
05:02 < bitcoin-git> bitcoin/master 1f77f67 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
05:02 < bitcoin-git> bitcoin/master b5c5021 Andrew Chow: Refactor importwallet to extract data from the file and then import
05:02 < bitcoin-git> bitcoin/master e6c58d3 Andrew Chow: Do not import private keys to wallets with private keys disabled
05:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:02 < bitcoin-git> [bitcoin] laanwj merged pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
05:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:07 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Quit: Soligor]
05:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
05:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
05:32 -!- shesek [~shesek@141.226.218.90] has joined #bitcoin-core-dev
05:32 -!- shesek [~shesek@141.226.218.90] has quit [Changing host]
05:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:34 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:43 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Disconnected by services]
05:43 -!- dermoth_ [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
05:44 -!- dermoth_ is now known as dermoth
05:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds]
05:59 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
06:02 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
06:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds]
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:12 < bitcoin-git> [bitcoin] harding opened pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
06:14 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
06:16 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
06:19 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:20 < bitcoin-git> [bitcoin] harding opened pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:20 -!- promag [~promag@83.223.234.97] has joined #bitcoin-core-dev
06:25 -!- promag_ [~promag@83.223.233.37] has joined #bitcoin-core-dev
06:25 -!- promag [~promag@83.223.234.97] has quit [Ping timeout: 250 seconds]
06:27 -!- andrewbenson [~andrewben@rrcs-50-74-174-227.nyc.biz.rr.com] has joined #bitcoin-core-dev
06:30 -!- andrewbenson [~andrewben@rrcs-50-74-174-227.nyc.biz.rr.com] has quit [Client Quit]
06:31 < promag_> jnewbery: #15297 could be in https://github.com/bitcoin/bitcoin/projects/2
06:31 < gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
06:31 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e38d4087379...5c99bb004700
06:37 < bitcoin-git> bitcoin/master fa21983 MarcoFalke: qa: Style-only fixes in touched files
06:37 < bitcoin-git> bitcoin/master fa5278a MarcoFalke: qa: Use wallet to retrieve raw transactions
06:37 < bitcoin-git> bitcoin/master 5c99bb0 MarcoFalke: Merge #15247: qa: Use wallet to retrieve raw transactions
06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:40 -!- promag_ [~promag@83.223.233.37] has quit [Remote host closed the connection]
06:46 < dongcarl> Hi all, if anyone can add https://github.com/bitcoin/bitcoin/pull/14856 to the "P2P refactor" board that'd be great. Also, could I get permissions to modify that board?
06:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:52 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
06:57 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds]
07:02 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
07:02 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
07:02 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
07:12 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
07:12 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
07:25 < dongcarl> Do people think that future consensus meanings of the witness reserved value will most likely be in the form of a sha256d commitment?
07:36 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:39 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
07:55 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
08:06 < rex4539> On master HEAD, I have few tests failing reliably. It's an old, slow machine with 4GB RAM so slowness could definitely be a factor here.
08:06 < rex4539> https://paste.fedoraproject.org/paste/rY-48P5ypXZZXBdw03BEeg
08:06 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
08:11 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:11 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds]
08:21 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
08:21 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
08:21 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
08:39 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:40 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
08:41 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
08:54 -!- mistergold [~mistergol@77.243.31.101] has quit [Ping timeout: 244 seconds]
08:57 < provoostenator> I'm trying to build a Descriptor composer. It should allow something like auto desc =  PKHDescriptor(myCPubKey);
08:57 -!- jarthur [~jarthur@207.114.244.5] has quit []
08:57 < provoostenator> Not sure what the right approach is, and the abstract class stuff is a bit over my head.
08:57 < sipa> provoostenator: oh, i was thinking about that
08:58 < sipa> i'll pr it
08:58 < provoostenator> The end goal is that I want to generate a descriptor like wpkh([000000/84'/0'/0']xpub.../0/*) without weird string concatenation.
08:58 < provoostenator> sipa: awesome that would help!
08:59 < provoostenator> Once that works, I would like to introduce descriptor-requests somehow. The same, but with xpub missing. The point of that is to ask a signer to fill in that part. 
09:00 < provoostenator> With that I can significantly reduce the amount of spaghetti in my hardware wallet integration WIP PR :-)
09:01 < provoostenator> I suppose the lazy solution is just an all 0 public key.
09:01 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has joined #bitcoin-core-dev
09:06 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has quit [Ping timeout: 268 seconds]
09:11 < wumpus> rex4539: by default it runs four tests at the same time which is too much for slower systems, certainly with little memory; it might help if you set -j1 on test runner?
09:13 < rex4539> Running them individually it's the same failure.
09:17 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #bitcoin-core-dev
09:19 < wumpus> definitely looks like a test that takes much longer than expected and hits the timeout
09:22 < wumpus> you might be able to make it pass by increasing the timeout value in the source
09:23 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
09:31 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection]
09:36 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Read error: Connection reset by peer]
09:38 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
09:45 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:53 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
09:53 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
09:57 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:57 -!- andrewbenson [~textual@rrcs-50-74-174-227.nyc.biz.rr.com] has joined #bitcoin-core-dev
10:03 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds]
10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5c99bb004700...2c0867a1811b
10:08 < bitcoin-git> bitcoin/master 1971f5b Ben Woosley: Piecewise construct to avoid invalid construction
10:08 < bitcoin-git> bitcoin/master 267eac0 Ben Woosley: Prefer boost::optional#get_value_or over #value_or
10:08 < bitcoin-git> bitcoin/master 64f2854 Ben Woosley: Revert "travis: Compile trusty with depends for now"
10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15308: build: Restore compatibility with older boost (master...trusty-no-depends) https://github.com/bitcoin/bitcoin/pull/15308
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
10:11 -!- jungly [~quassel@79.8.200.97] has quit [Read error: Connection reset by peer]
10:14 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
10:16 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
10:21 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:21 < bitcoin-git> [bitcoin] Sjors opened pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:21 < provoostenator> (guess I could have done that on my own fork, anyway...)
10:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:29 < MarcoFalke> provoostenator: The issue was closed accidentally because the description in #15308 was not updated to reflect the latest status of the pull
10:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15308 | build: Restore compatibility with older boost by Empact · Pull Request #15308 · bitcoin/bitcoin · GitHub
10:31 -!- andrewbenson [~textual@rrcs-50-74-174-227.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:41 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
11:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:06 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
12:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:12 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
12:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:14 < bitcoin-git> [bitcoin] practicalswift closed pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
12:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:26 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
12:28 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 246 seconds]
12:31 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
12:34 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
12:39 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has joined #bitcoin-core-dev
12:44 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:48 < dongcarl> ryanofsky: 
12:48 < dongcarl> ryanofsky: Could you see if the wording I just pushed makes sense?
12:49 < dongcarl> Or should we explicitly mention that out of the box you can't override datadir?
12:49 < dongcarl> talking about #12255 ofc
12:49 < gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
12:54 < ryanofsky> previous ca07fa88c82 seems better than current 9c8d535211d. new wording is ok but less clear
12:56 -!- quangthong81 [70c52b69@gateway/web/freenode/ip.112.197.43.105] has joined #bitcoin-core-dev
12:58 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:59 -!- quangthong81 [70c52b69@gateway/web/freenode/ip.112.197.43.105] has quit [Client Quit]
13:08 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
13:10 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
13:11 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
13:12 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:14 < bitcoin-git> [bitcoin] promag opened pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:15 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Ping timeout: 256 seconds]
13:15 < dongcarl> ryanofsky: Okay I'll revert then
13:16 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:16 < promag> http://releases.llvm.org/5.0.2/tools/clang/docs/ThreadSafetyAnalysis.html#no-checking-inside-constructors-and-destructors
13:17 < promag> was this mentioned in the past? I wasn't aware :/
13:20 < sipa> promag: what are you referring to?
13:21 < promag> no thread safety analysis on constructors and destructors
13:24 < sipa> yes, i can read
13:24 < sipa> i don't know what you want to convey
13:29 < promag> see #15322, initially I couldn't understand who held the lock when ~BerkeleyEnvironment, then I realized there was no checking at destructors
13:29 < gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
13:29 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:30 < sipa> ah
13:30 < promag> so I wonder if there are more cases like that
13:30 < sipa> sorry, i thought you were trying to say we should use something mentioned in that document, and i couldn't figure out what
13:30 < promag> no problem
13:31 < promag> I think this is tricky because we may be missing some important locks and we think it's all good because annotations "protect" us
13:35 < gmaxwell> I hope people aren't relying on those annotations instead of actually reviewing...
13:43 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
13:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
14:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
14:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
14:08 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection]
14:12 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
14:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:14 < bitcoin-git> [bitcoin] Empact opened pull request #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo (master...load-mempool-race) https://github.com/bitcoin/bitcoin/pull/15323
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:21 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c0867a1811b...b3a715301a0f
14:25 < bitcoin-git> bitcoin/master faee6c9 MarcoFalke: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
14:25 < bitcoin-git> bitcoin/master facaae4 MarcoFalke: travis: Save cache when compilation took very long
14:25 < bitcoin-git> bitcoin/master b3a7153 MarcoFalke: Merge #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG (master...Mf1901-travisFun) https://github.com/bitcoin/bitcoin/pull/15303
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:28 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
14:30 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has joined #bitcoin-core-dev
14:31 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:52 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
15:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
15:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
15:19 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
15:34 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 268 seconds]
15:55 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev
15:58 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 246 seconds]
16:05 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
16:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:16 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev
16:18 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
16:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:31 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
16:33 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:34 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test]
16:36 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 244 seconds]
16:37 -!- mistergold [~mistergol@77.243.30.80] has joined #bitcoin-core-dev
16:37 -!- mistergold [~mistergol@77.243.30.80] has quit [Read error: Connection reset by peer]
16:52 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
17:11 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
17:21 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
17:34 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
17:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:36 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 250 seconds]
17:53 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
17:54 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
17:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
17:57 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
18:01 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
18:04 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
18:23 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
18:26 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:48 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
19:10 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
19:39 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:51 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 245 seconds]
20:04 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
20:52 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:07 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:19 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:20 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
21:21 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:37 -!- profmac [~ProfMac@2001:470:1f0f:226:1dc8:6196:94ca:66d1] has quit [Ping timeout: 240 seconds]
21:39 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
21:43 -!- profmac [~ProfMac@2001:470:1f0f:226:b0db:1aac:d42e:d8b2] has joined #bitcoin-core-dev
21:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
21:52 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
21:55 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:58 -!- Krellan [~Krellan@2601:640:4000:a876:1cb0:8c81:741d:249e] has joined #bitcoin-core-dev
21:59 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
22:01 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev
22:03 -!- Krellan [~Krellan@2601:640:4000:a876:1cb0:8c81:741d:249e] has quit [Ping timeout: 268 seconds]
22:25 -!- Krellan [~Krellan@2601:640:4000:a876:ac59:72ec:ed9b:59af] has joined #bitcoin-core-dev
22:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:34 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
22:34 -!- profmac [~ProfMac@2001:470:1f0f:226:b0db:1aac:d42e:d8b2] has quit [Ping timeout: 240 seconds]
22:44 -!- profmac [~ProfMac@2001:470:1f0f:226:b0db:1aac:d42e:d8b2] has joined #bitcoin-core-dev
22:49 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
23:05 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539]
23:23 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
23:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
23:45 -!- spinza [~spin@155.93.246.187] has quit [Remote host closed the connection]
23:49 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
--- Log closed Sat Feb 02 00:00:38 2019