--- Log opened Sat Feb 02 00:00:38 2019
00:05 -!- rex4539 [~rex4539@ppp-2-86-201-92.home.otenet.gr] has joined #bitcoin-core-dev
00:06 -!- deadlysin [~deadlysin@unaffiliated/deadlysin] has joined #bitcoin-core-dev
00:09 -!- deadlysin [~deadlysin@unaffiliated/deadlysin] has quit [Client Quit]
00:11 -!- rex4539 [~rex4539@ppp-2-86-201-92.home.otenet.gr] has quit [Quit: rex4539]
00:21 -!- rex4539 [~rex4539@ppp-2-86-201-92.home.otenet.gr] has joined #bitcoin-core-dev
00:22 -!- rex4539 [~rex4539@ppp-2-86-201-92.home.otenet.gr] has quit [Client Quit]
00:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
00:41 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 245 seconds]
01:09 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection]
01:19 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 245 seconds]
01:21 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
01:28 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
01:34 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
01:43 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection]
01:44 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
01:55 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
02:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
02:29 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:29 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving]
02:33 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:58 < fanquake> wumpus #15315 can go in
02:58 < gribble> https://github.com/bitcoin/bitcoin/issues/15315 | [0.17] [Doc] Backport release note about PSBT doc by harding · Pull Request #15315 · bitcoin/bitcoin · GitHub
03:03 < wumpus> loooooks like travis is acting up again (in #15324 at least): /home/travis/.travis/job_stages: line 104: .travis/test_06_script.sh: No such file or directory
03:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15324 | test: Make bloom tests deterministic by MarcoFalke · Pull Request #15324 · bitcoin/bitcoin · GitHub
03:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
03:10 < fanquake> wumpus Looks like it needs rebasing on master after #15303, which split test_06_script.sh into two files
03:10 < gribble> https://github.com/bitcoin/bitcoin/issues/15303 | travis: Remove unused FUNCTIONAL_TESTS_CONFIG by MarcoFalke · Pull Request #15303 · bitcoin/bitcoin · GitHub
03:20 < fanquake> Looks like now all PRs prior to the one, will need rebasing on master, otherwise Travis will fail same as in #15324
03:20 < gribble> https://github.com/bitcoin/bitcoin/issues/15324 | test: Make bloom tests deterministic by MarcoFalke · Pull Request #15324 · bitcoin/bitcoin · GitHub
03:21 < wumpus> fanquake: right, was about to say, "it doesn't touch that"! but yea if it applies to all PRs that's it then
03:23  * fanquake rebases all 262 PRs
03:31 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 246 seconds]
03:31 < wumpus> :-(
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:31 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to .17: https://github.com/bitcoin/bitcoin/compare/30db5cc6418a...392d1382c1b1
03:31 < bitcoin-git> bitcoin/.17 807add9 David A. Harding: [0.17] [Doc] Backport release note about PSBT doc
03:31 < bitcoin-git> bitcoin/.17 392d138 Wladimir J. van der Laan: Merge #15315: [0.17] [Doc] Backport release note about PSBT doc
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:31 < bitcoin-git> [bitcoin] laanwj merged pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:36 < wumpus> gkrizek: "[bitcoin] ... (.17...019-02-backport-release-notes)" looks like the first letter of the branch names is missing ! :)
03:56 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 246 seconds]
04:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
05:22 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 246 seconds]
05:33 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:50 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:53 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
05:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 245 seconds]
05:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
05:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
05:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:14 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
06:24 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
06:31 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
06:42 < gkrizek> Yeah I noticed that. I think it only happens on the branch names with ‘0.X’.  I’ll look into it
06:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 244 seconds]
07:16 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
07:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
07:30 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
07:31 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
07:50 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #bitcoin-core-dev
07:57 -!- kexkey [~kexkey@87.101.92.80] has joined #bitcoin-core-dev
08:08 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev
08:13 < wumpus> gkrizek: maybe always when it starts with a number
08:13 < wumpus> the 019-02... one looks cut-off too
08:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
08:27 -!- hashist [~hashist@157.157.113.86] has quit [Ping timeout: 246 seconds]
08:35 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:39 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
08:47 < gkrizek> Ah, could be!
08:52 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 246 seconds]
08:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
08:55 -!- fleshwounded [~flesh@2604:3d09:137f:d400:40a1:64ab:4d35:9670] has joined #bitcoin-core-dev
08:57 < fleshwounded> woot woot found the @wumpus
08:57 < fleshwounded> you really dont leave the irc do you lol?
09:07 < fleshwounded> hope that router is doing some fancy stuff now? you plug an pcie in? or what was is again msata I forget lol... been eye humping those routers ever since we talked lol
09:08 < fleshwounded> I wanna do the satellite node now...
09:10 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
09:17 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
09:32 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has quit [Remote host closed the connection]
09:44 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:46 -!- DougieBot5000_ is now known as DougieBot5000
09:59 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
10:11 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
10:12 < wumpus> fleshwounded: my IRC runs on a server that's always on (weechat on tmux right now), this is useful to not miss backlog
10:14 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
10:17 < wumpus> fleshwounded: and feel free to PM me about the other things, this is off topic for the channel
10:18 -!- kexkey_ [~kexkey@172.98.82.16] has joined #bitcoin-core-dev
10:18 -!- kexkey [~kexkey@87.101.92.80] has quit [Ping timeout: 244 seconds]
10:21 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 240 seconds]
10:22 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
10:29 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has joined #bitcoin-core-dev
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:35 < bitcoin-git> [bitcoin] practicalswift opened pull request #15327: tests: Make tests updatecoins_simulation_test and knapsack_solver_test deterministic (master...SeedInsecureRand(true);) https://github.com/bitcoin/bitcoin/pull/15327
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:41 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:43 < fleshwounded> I just wasnt sure if I was in the right place or not @wumpus not a problem lol
10:46 < wumpus> ok !
11:00 -!- andrewbenson [~textual@2604:2000:1405:c33c:c041:ce77:38d7:e6ea] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:01 < MarcoFalke> re travis failures: Not all pull requests need rebase (only those that failed prior to now and need to be run again). A force push or push should also suffice, though.
11:03 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
11:22 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 272 seconds]
11:27 -!- andrewbenson [~textual@2600:380:5937:e3f9:d0f9:30ee:6220:7399] has joined #bitcoin-core-dev
11:27 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
11:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:37 -!- andrewbenson [~textual@2600:380:5937:e3f9:d0f9:30ee:6220:7399] has quit [Quit: Textual IRC Client: www.textualapp.com]
11:41 < provoostenator> Any idea what I should cherry-pick to prevent "Assertion failed: (!m_result.empty()), function RPCResult, file ./rpc/util.h, line 118." ?
11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328
11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:44 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
11:48 < MarcoFalke> provoostenator: It tells you to not pass in an m_result that is empty
11:48 < MarcoFalke> All rpc have a result (even if it is Null)
11:53 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Ping timeout: 256 seconds]
11:54 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
12:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
12:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
12:13 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has joined #bitcoin-core-dev
12:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:24 < provoostenator> It crashes for src/bitcoin-cli help
12:25 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: No route to host]
12:25 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
12:25 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
12:30 < provoostenator> During the block rewind phase "bitcoin-cli help" complains as usualy that it's still rewinding. After that it crashes. Same if I use the console in QT.
12:30 < provoostenator> If nothing comes to mind though, I'm just going to go through the misery of rebasing and see if that magically helps :-)
12:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:50 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
13:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds]
13:11 < provoostenator> achow101 / meshcollider: if you get a chance to rebase #14491 that would be quite helpful. I can't figure it out.
13:12 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:14 < bitcoin-git> [bitcoin] hebasto opened pull request #15329: [WIP] Fix InitError() and InitWarning() content (master...0190202-initerror) https://github.com/bitcoin/bitcoin/pull/15329
13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
13:17 -!- shesek [~shesek@141.226.217.238] has joined #bitcoin-core-dev
13:17 -!- shesek [~shesek@141.226.217.238] has quit [Changing host]
13:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:30 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
13:30 < meshcollider> provoostenator: yep I'll rebase but it can't be fixed til #15263
13:30 < gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub
13:31 < meshcollider> So I'd prefer to just wait for that
13:31 < provoostenator> Some WIP on top of that would be quite useful though
13:32 < meshcollider> Stacked PRs again 🙃
13:32 < provoostenator> Oh yes...
13:32 < provoostenator> I either need to solve a mysterious crash or figure out how to rebase this thing. Neither feels appealing.
13:33 < meshcollider> Is it the rebase or the existing bug that's causing the issue?
13:33 < provoostenator> Both
13:33 < provoostenator> And maybe even a local machine issue, who knows.
13:34 < provoostenator> It's quite weird though: I can run the functional tests fine, but using the RPC crashes.
13:34 < meshcollider> That's very weird, using the same input?
13:34 < provoostenator> And I'm pretty sure it worked earlier today with the exact same commit.
13:34 < provoostenator> #14912
13:34 < gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
13:34 < provoostenator> "bitcoin-cli help" causes a reliable crash
13:35 < provoostenator> But not on master
13:35 < provoostenator> So I figured that I probably created too much of a nested PR mess and need to start again from master, but that's not an option pending that rebase.
13:36 < meshcollider> So somewhere in those 36 commits theres a bug, yay!
13:36 < provoostenator> Maybe, and it's possible I didn't notice it earlier today because some cached thing saved me.
13:36 < meshcollider> Ok I'll try and get it done today or tomorrow at the latest but like you say, its a bit of a headache to rebase this one
13:37 < provoostenator> Meanwhile I'll try nuking some things on my end to see if I can get things to compile
13:37 < meshcollider> I'll have to base it on top of sipas PR so then we have yet another PR in the tower
13:39 < provoostenator> It'd say the descriptor import PR is the scariest thing in the tower. Should be smooth sailing once that's merged...
13:39 < provoostenator> Because it's both a big refactor and adding new functionality. 
13:40 < provoostenator> And every time we find a problem, we've been adding some parallel PR to deal with that.
13:41 < provoostenator> I'd also love to move most of that stuff out of the RPC codebase and into a place where it can also be used by the GUI, but let's not for now :-)
13:43 < meshcollider> yep lets do a move PR after the water clears a bit :)
13:44 < provoostenator> #14978 is a good example of moving stuff out of RPC codebase
13:44 < gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
13:48 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 244 seconds]
13:48 < meshcollider> actually is anyone around e.g. jnewbery that could quickly review #15263
13:48 < gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub
13:48 < meshcollider> its pretty much RTM
13:49 < provoostenator> Indeed
13:49 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev
13:50 < MarcoFalke> provoostenator: https://github.com/bitcoin/bitcoin/pull/14912/files#r253279565
13:51 < provoostenator> Oh, that RPCResult stuff is called runtime?
13:51 < provoostenator> I thought it was some compiler magick.
13:52 < MarcoFalke> std::string is not constexpr
13:52 < MarcoFalke> And in any case RPCResult should be moved away from strings to types (just like RPCArg)
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3a715301a0f...6e6b859f85a8
13:53 < provoostenator> So I need to do RPCResult{"null"} for entries without no result doc?
13:53 < bitcoin-git> bitcoin/master 11e0fd8 Pieter Wuille: Descriptor expansions only need pubkey entries for PKH/WPKH
13:53 < bitcoin-git> bitcoin/master 6e6b859 MeshCollider: Merge #15263: Descriptor expansions only need pubkey entries for PKH/WPKH
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] MeshCollider merged pull request #15263: Descriptor expansions only need pubkey entries for PKH/WPKH (master...01901_flatprovider_pkh) https://github.com/bitcoin/bitcoin/pull/15263
13:54 < MarcoFalke> Yes, I believe we should document that the return value is json-null instead of ommiting it
13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:54 < MarcoFalke> * omitting
13:56 < provoostenator> MarcoFalke: same for RPCExamples?
13:57 < MarcoFalke> Not required, up to you to provide examples
13:59 < provoostenator> Crash gone! Thanks.
14:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:02 < meshcollider> \o/
14:03 < provoostenator> meshcollider: I see you merged it :-) Maybe add my "Test importing of a P2PKH address via descriptor" when you rebase?
14:03 < meshcollider> provoostenator: will do, thanks
14:04 < provoostenator> No rush though, with the crash out of the way at least I'm not stuck. Though I'd still like to get that the descriptor import multi PR merged, to pave the way to get achow101's PR's merged.
14:04 < meshcollider> yeah I agree
14:04 < meshcollider> these stacked PRs make things so much harder 
14:04 < provoostenator> With a bit of luck we'll have everything to use HWI Python scripts in standalone mode before 0.18
14:06 < hebasto> wumpus: regarding #15329; what about translation of errors related to wallets or invalid option values?
14:06 < gribble> https://github.com/bitcoin/bitcoin/issues/15329 | Fix InitError() and InitWarning() content by hebasto · Pull Request #15329 · bitcoin/bitcoin · GitHub
14:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:15 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:20 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
14:26 < wumpus> hebasto: I don't know, don't have a strong opinion on it; but note that we also don't translate option help
14:28 < wumpus> hebasto: in any case I think the criterion for translation should be "does this message make sense to a user/translator", you can assume knowledge of bitcoin terminology such as blocks, transactions, wallets, etc, but not internals of the software
14:29 < wumpus> so for the wallet messages it makes more sense to translate I guess
14:29 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
14:29 < hebasto> ^^ that was my initial intention
14:30 < wumpus> somthing like "wallet cannot be loaded" is very translatable
14:30 < gmaxwell> Doesn't translation of errors make googling for help impossible?
14:30 < wumpus> but something highly technical, like, "wallet premature EOF truncated key" you'd certainly not want to translate
14:31 < wumpus> gmaxwell: yes that was exactly my point in  #15329
14:31 < gribble> https://github.com/bitcoin/bitcoin/issues/15329 | [WIP] Fix InitError() and InitWarning() content by hebasto · Pull Request #15329 · bitcoin/bitcoin · GitHub
14:32 < wumpus> I mean you could also say "don't translate any errors at all" but that'd be a new policy, in fact some InitError and InitWarning are translated at the moment
14:32 < wumpus> it's fine with me though ...
14:34 < gmaxwell> It might be more useful to show both the translated and english error, but I dunno if the translation infrastructure makes that possible
14:35 < gmaxwell> otherwise I think we're stuck wondering if the error is user actionable ("wallet file not found") vs not ("hyperspatial cascade failure in wallet")
14:35 < wumpus> yes
14:35 < hebasto> for future maintenance purpose is it good to explicitly comment untranslated errors?
14:36 < wumpus> so I think the first point here should be: do we actually have a problem? is this a serious issue?
14:36 < gmaxwell> hebasto: I think most errors outside of UI components are intentionally not translated.
14:36 < wumpus> gmaxwell: yes
14:36 < wumpus> it's only the UI that does translation, in any case
14:37 < hebasto> InitError() presents error via UI
14:38 < echeveria> I've seen users turn up with translated error messages before. it wasn't useful to me as someone who does not know russian, and they being bilingual and having to translate it back for me.
14:38 < wumpus> It might be more useful to show both the translated and english error -> this is not possible at the moment, would be possible to create a _() alternative that returns both the original string and the transalation I guess, but that'd need changes to a few scripts
14:39 < wumpus> (e.g. gettext needs to pick it up)
14:39 < wumpus> echeveria: yeah... it's terrible
14:39 < gmaxwell> I would guess that this is one reason that some commercial packages have numbered error messages.
14:41 < wumpus> numbering errors makes sense
14:43 < sipa> SHA256("english error") % 2^32
14:43 < sipa> very likely to be unique
14:43 < echeveria> PATCH: fix typo in error text 
14:43 < sipa> haha
14:44 < echeveria> I jest. 
14:47 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
14:48 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
14:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15330: test: Fix race in p2p_invalid_messages (master...Mf1902-qaRaceMagic) https://github.com/bitcoin/bitcoin/pull/15330
14:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:49 < wumpus> that works :) though the usual way is to make errors an enum, per subsystem, e.g. 1xxx is block chain error, 2xxx wallet error and so on, this way having the error strings in the code can be avoided completely, they can be in some text/database file including translations ...
14:51 < gmaxwell> [SHA256] PATCH: adjust round constants to preserve E1132 with new text.
14:53 < wumpus> hehe
14:54 < gmaxwell> lets just make _() steg encode the line number into case alterations in the text...  "A légpáRnásOM tELe vaN anGolnákKal."
14:54 < wumpus> or add random data to the end of the error message and grind
14:54  * sipa writes gramtropy grammar
14:54 < gmaxwell> oh bitcoin error messages grammar.
14:54 < wumpus> or that
15:06 < sipa> gmaxwell: among degree 7, length 32767, distance 4 codes there exist only 1800 unique ones; among those, there is one with length 172 distance distance 5
15:09 < gmaxwell> sipa: sadly not long enough for the 'P2WSH 2-of-3 multisig' example in the descriptors docs.
15:09 < sipa> yup
15:09 < sipa> i can look at 8 character codes
15:10 < gmaxwell> Worth taking a look.
15:12 < gmaxwell> 5 up to 172 is still better than just distance 4... though I'd be particularly satisfied if it was long enough for 2 of 3 with hex pubkeys. (about 221-ish?) 
15:13 < sipa> 209
15:13 < gmaxwell> 209 is without wsh() and without the checkvalue itself.
15:13 < sipa> though 280 if we have 3-to-4 expansion for the character classes inline
15:13 < sipa> ah yes!
15:15 < gmaxwell> if we have 3-to-4 characters there will be a base-58 check though.
15:16 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
15:17 < sipa> we can also have all character class 'symbols' first and then all the individual character symbols, in which case the length only applies whenever errors within the class are made (which is very likely for the multisig with hex pubkeys example; it only excludes errors in the wsh/multi keywords)
15:17 < gmaxwell> jinx I was just thinking about that. 
15:18 < gmaxwell> But it wasn't completely clear to me if it was possible without having placeholder characters.
15:18 < gmaxwell> or without a weird integration with parsing.
15:19 < sipa> there are 94 printable ascii characters, so you only need 3 character classes
15:19 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
15:19 < gmaxwell> like... would you process this by parsing to strip all the base-58 parts then check them then apply the checksum to the base58parts then the stripped part?
15:20 < sipa> no, with every character you assign a character class and a 5-bit position within that class; and then you transform every 3 characters into 4 symbols, where the first symbol is cls1*9+cls2*3+cls3, and the other 3 are the individual positions of the 3 characters in their class
15:20 < sipa> ah i see what you're getting at
15:20 < sipa> you could actually sort all index positions based on their class
15:22 < sipa> so then as long as all errors are within the same class, the distance is excluding any intermediary characters in other classes
15:23 < gmaxwell> but an error that changes a base58 character to non-base58 than shifts all the non-base58 characters.
15:23 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
15:23 < gmaxwell> e.g. a one character error could be undetected.
15:23 < sipa> ah yes
15:23 < sipa> that would be unfortunate
15:24 < gmaxwell> thats why I was musing about parsing to split.
15:24 < sipa> let's see what distance we can do with degree 8
15:24 < sipa> eh, what length
15:24 < gmaxwell> yep sounds good.
15:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Excess Flood]
15:38 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:38 < bitcoin-git> [bitcoin] laanwj closed pull request #14872: contrib: Adding -daemon default option to bitcoind.init (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14872
15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:39 < phantomcircuit> gmaxwell, we could include an error code which is just a hash of the english version
15:39 < phantomcircuit> wait sipa already said that
15:39 < phantomcircuit> nvm
15:40 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:41 < wumpus> please don't actually do that
15:45 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:50 < sipa> gmaxwell: i've already found some degree 8 codes with distance 5 up to length 800
15:51 < gmaxwell> oh sweet. any have distance 6 at 221? :P
15:51 < gmaxwell> er 222
15:54 < sipa> that'll take much more time to say for certain, but based on results so far, i'd say it's unlikely
15:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds]
16:01 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:08 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
16:17 < sipa> gmaxwell: exactly 37000 degree8 len32767+len33825 hd4 codes
16:17 < sipa> always surprising to see these large powers of 10 as factor appear
16:18 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
16:21 < sipa> around 10% of those are len512 hd5
16:21 < sipa> so the next question is how to prioritize hd5 length vs hd6 length
16:22 < sipa> without ability to reach hd6 len222 at all, we should probably just maximize hd5 length
16:27 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:28 < gmaxwell> Agreed.
16:28 < gmaxwell> It might be interesting to see what we end up with under each criteria?  what do we get prioritizing hd6 length, then hd5 lenght, what do we get prioriting hd6 length then hd5 lenght?
16:29 < sipa> yup
16:54 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
17:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e6b859f85a8...2fbf6a57d282
17:05 < bitcoin-git> bitcoin/master fac3a05 MarcoFalke: test: Fix race in p2p_invalid_messages
17:05 < bitcoin-git> bitcoin/master 2fbf6a5 MarcoFalke: Merge #15330: test: Fix race in p2p_invalid_messages
17:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15330: test: Fix race in p2p_invalid_messages (master...Mf1902-qaRaceMagic) https://github.com/bitcoin/bitcoin/pull/15330
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:06 -!- fleshwounded [~flesh@2604:3d09:137f:d400:40a1:64ab:4d35:9670] has quit [Quit: Leaving]
17:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
17:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
17:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:48 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #15332: [Docs] Small updates to getrawtransaction description (master...get_transaction_docs) https://github.com/bitcoin/bitcoin/pull/15332
17:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:01 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:03 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
18:06 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:07 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
18:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds]
18:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]
18:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
18:41 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds]
18:43 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds]
18:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
18:48 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
19:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
19:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:14 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
19:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
19:17 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 244 seconds]
19:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
19:55 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
20:06 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
20:22 < sipa> gmaxwell: longest hd6 is len131
20:23 < sipa> not enough for 2 public keys even
20:24 < sipa> that one is len788 hd5
20:24 < phantomcircuit> wumpus, enums for error codes is definitely the way to go
20:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
20:30 < sipa> gmaxwell: longest hd5 is len1318
20:33 < sipa> which is only len22 hd6
20:36 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
20:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15206: Immediately disconnect on invalid net message checksum (master...019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
20:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:50 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15206: Immediately disconnect on invalid net message checksum (master...019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
20:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
21:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
22:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
22:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:49 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
22:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
22:59 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
23:04 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
23:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:57 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
--- Log closed Sun Feb 03 00:00:39 2019