--- Log opened Fri Feb 08 00:00:43 2019
00:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
00:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
00:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
00:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
00:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
01:12 -!- volkov [~volkov@gateway/tor-sasl/volkov] has joined #bitcoin-core-dev
01:13 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:17 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:27 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
01:32 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
01:33 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds]
01:34 < promag> fanquanke: I prefer to rebase after merge, otherwise I'll have to rebase again
01:34 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
01:37 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:41 < provoostenator> promag: I can't reason about the things that might go wrong when a wallet keeps rescanning after a user cancels the load action.
01:41 < provoostenator> Can it lead to data loss? Crashes?
01:41 < provoostenator> I fully expect users to just keep trying to open the same wallet, while that rescan is still going.
01:42 -!- timothy [~tredaelli@redhat/timothy] has quit [Read error: Connection reset by peer]
01:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:46 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:52 -!- rockhouse4 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
01:53 -!- victorSN1 [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
01:57 -!- victorSN1 [~victorSN@unaffiliated/victorsn] has quit [Client Quit]
01:59 -!- rockhouse4 [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection]
02:05 -!- volkov [~volkov@gateway/tor-sasl/volkov] has quit [Ping timeout: 256 seconds]
02:05 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
02:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:16 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
02:21 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev
02:31 -!- sakalli_ [~Mutter@mobile-access-5d6af3-169.dhcp.inet.fi] has joined #bitcoin-core-dev
02:33 -!- sakalli_ [~Mutter@mobile-access-5d6af3-169.dhcp.inet.fi] has quit [Client Quit]
02:36 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:41 -!- sakalli_ [~Mutter@mobile-access-5d6af3-169.dhcp.inet.fi] has joined #bitcoin-core-dev
02:43 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:47 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.3]
02:49 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
02:49 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:50 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
02:51 -!- sakalli_ [~Mutter@mobile-access-5d6af3-169.dhcp.inet.fi] has quit [Quit: Mutter: www.mutterirc.com]
02:53 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:31 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9b26d9c3615...6fc656a410b6
03:31 < bitcoin-git> bitcoin/master d855e4c practicalswift: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an in...
03:31 < bitcoin-git> bitcoin/master 6fc656a Wladimir J. van der Laan: Merge #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0...
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:31 < bitcoin-git> [bitcoin] laanwj merged pull request #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (master...ub-in-DecodeSecret) https://github.com/bitcoin/bitcoin/pull/14242
03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:53 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 245 seconds]
03:59 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
04:21 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev
04:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
04:36 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
04:56 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
04:57 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
05:15 -!- mn9495883 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
05:18 -!- BGL [~BGLWrK@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds]
05:18 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds]
05:18 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Ping timeout: 246 seconds]
05:18 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 250 seconds]
05:19 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev
05:19 -!- echeveria [~echeveria@unaffiliated/echeveria] has quit [Ping timeout: 272 seconds]
05:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
05:26 -!- m8tion [~user@88.190.249.49] has quit [Quit: Leaving]
05:26 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
05:26 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev
05:28 -!- echeveria [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev
05:29 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Leaving ... but you never know maybe I come back!]
05:29 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Quit: Leaving ... but you never know maybe I come back!]
05:30 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds]
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:31 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
05:31 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
05:33 -!- m8tion [~user@88.190.249.49] has quit [Quit: Leaving]
05:38 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 250 seconds]
05:38 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 250 seconds]
05:43 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev
05:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds]
05:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
05:49 < fanquake> promag fair enough, I'll review post rebase
05:50 -!- m8tion_ [~m8tion@88.190.249.49] has joined #bitcoin-core-dev
05:50 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds]
05:54 -!- darosior [86d6d6ea@gateway/web/freenode/ip.134.214.214.234] has joined #bitcoin-core-dev
05:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:00 -!- m8tion_ [~m8tion@88.190.249.49] has quit [Quit: Quitte]
06:01 -!- m8tion [~user@88.190.249.49] has quit [Quit: Leaving]
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fc656a410b6...30495d1e756c
06:01 < bitcoin-git> bitcoin/master eea02be practicalswift: Add locking annotation for vNodes. vNodes is guarded by cs_vNodes.
06:01 < bitcoin-git> bitcoin/master 30495d1 MarcoFalke: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is gu...
06:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:03 -!- m8tion [~m8tion@88.190.249.49] has joined #bitcoin-core-dev
06:03 -!- m8tion [~m8tion@88.190.249.49] has quit [Remote host closed the connection]
06:07 -!- promag [~promag@83.223.232.59] has joined #bitcoin-core-dev
06:09 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
06:09 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev
06:10 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
06:12 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
06:15 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Ping timeout: 245 seconds]
06:24 -!- benthecarman [~benthecar@ics133-248.icsincorporated.com] has joined #bitcoin-core-dev
06:25 < benthecarman> Is there a better way for checking the address format than just seeing what the address starts with
06:25 -!- BGL [fifty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
06:31 < promag> benthecarman: not that I'm aware of, why?
06:32 < benthecarman> promag: just making sure I am doing something correctly
06:33 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
06:50 -!- promag [~promag@83.223.232.59] has quit [Remote host closed the connection]
06:53 -!- darosior [86d6d6ea@gateway/web/freenode/ip.134.214.214.234] has quit [Ping timeout: 256 seconds]
07:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
07:14 -!- darosior [86d6d6e5@gateway/web/freenode/ip.134.214.214.229] has joined #bitcoin-core-dev
07:16 -!- goatpig [56f74da0@gateway/web/freenode/ip.86.247.77.160] has quit [Ping timeout: 256 seconds]
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:20 < bitcoin-git> [bitcoin] benthecarman opened pull request #15371: gui: Optimization for bech32 qr codes (master...gui_bech_32_optimized_qr_codes) https://github.com/bitcoin/bitcoin/pull/15371
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:20 -!- benthecarman [~benthecar@ics133-248.icsincorporated.com] has quit [Quit: Leaving]
07:21 -!- benthecarman [~benthecar@ics133-248.icsincorporated.com] has joined #bitcoin-core-dev
07:34 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
07:38 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:38 -!- benthecarman [~benthecar@ics133-248.icsincorporated.com] has quit [Remote host closed the connection]
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30495d1e756c...020695660859
07:39 < bitcoin-git> bitcoin/master faa4647 MarcoFalke: wallet: Add lock annotation for mapAddressBook
07:39 < bitcoin-git> bitcoin/master 0206956 MarcoFalke: Merge #15365: wallet: Add lock annotation for mapAddressBook
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365
07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/020695660859...1477933f289e
07:44 < bitcoin-git> bitcoin/master faf3d22 MarcoFalke: test_runner: Remove unused --force option
07:44 < bitcoin-git> bitcoin/master fae8b8b MarcoFalke: qa: Add tool-prefix to functional test readme
07:44 < bitcoin-git> bitcoin/master 1477933 MarcoFalke: Merge #15370: test_runner: Remove unused --force option
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:52 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Quit: Leaving]
07:52 -!- ap4lmtree- [~ap4lmtree@47.148.73.98] has joined #bitcoin-core-dev
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:53 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15364: qa: Fix race in feature_notifications (master...Mf1902-qaNotifRace) https://github.com/bitcoin/bitcoin/pull/15364
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:53 -!- ap4lmtree- [~ap4lmtree@47.148.73.98] has quit [Client Quit]
07:54 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
07:54 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
07:56 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
08:02 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
08:04 -!- darosior [86d6d6e5@gateway/web/freenode/ip.134.214.214.229] has quit [Ping timeout: 256 seconds]
08:07 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Read error: Connection reset by peer]
08:08 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
08:11 -!- benthecarman [~benthecar@2610:130:110:1527:5811:6562:439e:368d] has joined #bitcoin-core-dev
08:13 -!- benthecarman [~benthecar@2610:130:110:1527:5811:6562:439e:368d] has quit [Client Quit]
08:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
08:24 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
08:26 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
08:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:41 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:00 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:01 -!- benthecarman [~benthecar@2610:130:110:1401:1097:113a:d2bd:d73b] has joined #bitcoin-core-dev
09:19 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
09:21 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
09:24 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:41 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
09:41 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 250 seconds]
09:41 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:47 -!- justan0theruser is now known as justanotheruser
09:48 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1477933f289e...d5dbb45bdf7d
09:49 < bitcoin-git> bitcoin/master 9ad5ca1 David A. Harding: Release notes: integrate detached & rm backports
09:49 < bitcoin-git> bitcoin/master 5d35d43 David A. Harding: Update release notes through to cb35f1d3
09:49 < bitcoin-git> bitcoin/master d5dbb45 MarcoFalke: Merge #15314: [Doc] update release notes for changes up to cb35f1d
09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...2019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
09:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:53 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 245 seconds]
09:56 -!- benthecarman [~benthecar@2610:130:110:1401:1097:113a:d2bd:d73b] has quit [Quit: Leaving]
10:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
10:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:30 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
10:31 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
10:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
10:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:36 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:40 < achow101> there's a wallet meeting today, right?
10:40 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
10:42 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
10:44 < gwillen> achow101: as far as I know, in 15 minutes
10:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
10:46 < sipa> yup, will be there
10:48 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
10:52 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:53 < meshcollider> Yep
11:00 < meshcollider> #startmeeting
11:00 < lightningbot> Meeting started Fri Feb  8 19:00:32 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
11:01 < achow101> only half here
11:01 < sipa> here
11:01 < promag> hi
11:01 < meshcollider> Ok, topics?
11:01 < meshcollider> I guess we should start with discussing what wallet PRs we can aim to get into 0.18
11:02 < jnewbery> hi
11:03 < meshcollider> https://github.com/bitcoin/bitcoin/milestone/35
11:03 < gwillen> yes hello
11:04 < gwillen> I am pestering for people to go review #13932
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
11:04 < sipa> will do
11:04 < jnewbery> https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+milestone%3A0.18.0+label%3AWallet
11:04 < achow101> also review #15226 pls
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
11:05 < jnewbery> only wallet PRs ^
11:06 < achow101> #14075 and #14021 would be nice, but they're a bit more involved
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
11:06 < meshcollider> Yes, I put them on the milestone but not sure they'll be ready in time
11:07 < achow101> there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in
11:08 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
11:09 < meshcollider> I would really like at least #14021 but we'll see I guess
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
11:09 < meshcollider> achow101: Is 15226 your highest priority one
11:10 < jnewbery> I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18
11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
11:10 < kanzure> hi.
11:10 < jnewbery> it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits
11:10 < meshcollider> jnewbery: yeah I think after 0.18 is better, but I agree
11:10 < achow101> currently 14021 is my highest priority
11:11 < achow101> (since 14491 is merged now)
11:12 < jnewbery> achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master?
11:12 < jnewbery> instagibbs: or you if you're around ^
11:12 < meshcollider> I think #14912 is tracking
11:13 < gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
11:13 < achow101> hwi has all basic functionality completed for the 5 common hardware wallets
11:13 < achow101> provoostenator has a branch for calling it from core
11:14 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
11:14 < achow101> we would need that and 14021 and 14075 for hwi to work.
11:15 < achow101> (gtg, have to take a quiz now)
11:15 < meshcollider> Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
11:16 < meshcollider> Quite a small PR to review 
11:16 < sipa> meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors
11:16 < sipa> as listunspent gives the descriptors already
11:17 < sipa> (not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient)
11:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:19 < meshcollider> sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change
11:19 < meshcollider> But we can't aim for that in 0.18
11:20 < sipa> agree
11:21 < meshcollider> Does anyone have any other topics for the meeting?
11:21 < meshcollider> sipa: how's the checksum search coming
11:22 < sipa> meshcollider: #15368
11:22 < gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
11:22 < sipa> i'll add documentation and release notes today
11:24 < meshcollider> Ok
11:24 < meshcollider> Looks like there's nothing else to discuss this week
11:25 < meshcollider> #endmeeting
11:25 < lightningbot> Meeting ended Fri Feb  8 19:25:13 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:25 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.html
11:25 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.txt
11:25 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.log.html
11:25 < meshcollider> Thanks everyone
11:25 < promag> jnewbery: do you think I should fix your case in the open wallet pr?
11:26 < jnewbery> I think so, unless you can explain why it isn't a problem
11:26 < jnewbery> is there a reason you wouldn't want the file checking in the LoadWallet() function?
11:27 < promag> I don't think I thought of that, it was just a small step towards minimizing code duplication
11:28 < promag> long term I'd like to break CreateWalletFromFile so that the UI can have the wallet interface asap
11:29 < promag> I'll update the branch then
11:37 < jnewbery> thanks!
11:41 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
11:43 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5dbb45bdf7d...294549242493
11:44 < bitcoin-git> bitcoin/master dfbf117 Jordan Baczuk: Move maxTxFee initialization to init.cpp
11:44 < bitcoin-git> bitcoin/master 2945492 MarcoFalke: Merge #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
11:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:46 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
11:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:51 < bitcoin-git> [bitcoin] sdaftuar closed pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
11:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:54 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev
11:55 < promag> forgot to mention #15341 on the meeting.. is it worth?
11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/15341 | rpc: Support specifying change address in bumpfee by promag · Pull Request #15341 · bitcoin/bitcoin · GitHub
12:13 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds]
12:14 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
12:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:41 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Read error: Connection reset by peer]
12:45 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
12:46 -!- nehan_ [~nehan@14.80.229.35.bc.googleusercontent.com] has quit [Ping timeout: 272 seconds]
12:46 -!- woody1345 [488b6e72@gateway/web/freenode/ip.72.139.110.114] has joined #bitcoin-core-dev
12:47 -!- woody1345 [488b6e72@gateway/web/freenode/ip.72.139.110.114] has quit [Client Quit]
12:47 -!- nehan [~nehan@14.80.229.35.bc.googleusercontent.com] has quit [Ping timeout: 272 seconds]
12:50 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
12:51 -!- nehan [~nehan@14.80.229.35.bc.googleusercontent.com] has joined #bitcoin-core-dev
12:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds]
12:54 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
13:02 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
13:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
13:19 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 250 seconds]
13:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
13:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:25 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
13:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
13:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 250 seconds]
13:31 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
13:34 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
13:38 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds]
13:41 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
13:44 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev
13:46 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
13:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
13:59 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Read error: Connection reset by peer]
14:06 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
14:10 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 246 seconds]
14:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
14:12 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
14:14 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
14:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:31 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373
14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:34 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
14:36 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
14:37 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
14:37 -!- anonymous_ [~anonymous@47.148.73.98] has joined #bitcoin-core-dev
14:37 -!- anonymous_ [~anonymous@47.148.73.98] has quit [Remote host closed the connection]
14:38 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
14:38 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
14:39 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
14:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
14:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
14:43 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
14:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
15:08 -!- bitconner [~root@138.68.244.82] has joined #bitcoin-core-dev
15:22 -!- CryptoKingNeedsH [438108c2@gateway/web/freenode/ip.67.129.8.194] has joined #bitcoin-core-dev
15:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
15:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:43 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: No Ping reply in 180 seconds.]
15:44 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
15:55 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 245 seconds]
15:56 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
16:51 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
16:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:57 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:01 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
17:07 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
17:08 -!- CryptoKingNeedsH [438108c2@gateway/web/freenode/ip.67.129.8.194] has quit [Quit: Page closed]
17:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:14 < bitcoin-git> [bitcoin] Csi18nAlistairMann opened pull request #15374: Trivial: conf file changes involving sections (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15374
17:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:18 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:46 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
17:47 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
17:57 -!- jarthur [~jarthur@207.114.244.5] has quit []
17:58 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
17:59 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
17:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
17:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Excess Flood]
18:01 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
18:27 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection]
18:28 -!- StopAndDecrypt [~StopAndDe@pool-141-155-179-159.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:28 -!- StopAndDecrypt [~StopAndDe@pool-141-155-179-159.nycmny.fios.verizon.net] has quit [Changing host]
18:28 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
18:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
18:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:45 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:46 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
18:54 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 268 seconds]
19:07 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
20:03 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
20:17 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 240 seconds]
21:05 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 245 seconds]
21:08 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
21:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
21:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
22:49 -!- gimmick122 [~gimmick12@2601:646:101:a074:80e8:a5a0:68a:4087] has joined #bitcoin-core-dev
23:10 -!- gimmick122 [~gimmick12@2601:646:101:a074:80e8:a5a0:68a:4087] has quit []
23:22 -!- trillhc [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer]
23:25 -!- gaoming [~gaoming@113.140.250.186] has joined #bitcoin-core-dev
23:41 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Quit: No Ping reply in 180 seconds.]
23:42 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
--- Log closed Sat Feb 09 00:00:45 2019