--- Log opened Tue Feb 12 00:00:47 2019
00:01 < wumpus> do we have any code-wide preference for the order of input versus output arguments?
00:01 < wumpus> I don't *think* so, but we probably should
00:01 < wumpus> (this is something I realized while reviewing #13932)
00:01 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
00:02 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
00:05 < sipa> i don't think we do
00:06 < provoostenator> wumpus: I also noticed it. Initially I was confused, but then found some reasonable arguments in favor of putting outputs first, because the number of input arguments tends to grow over time.
00:06 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
00:06 < provoostenator> But I don't think it's worth making rules around that.
00:06 < wumpus> at the least, I think having methods with different orderings on the same class is confusing
00:06 < gmaxwell> outputs first looks like assignment,  output = input. :)
00:06 < wumpus> I don't have any particular preference I just like consistency
00:07 < sipa> libsecp256k1 has a strict ordering of output first, then inputs, and within each ordered from most-recently-computed to oldest
00:07 < provoostenator> Although in general I often find it hard to tell when I see methods get called. It's more clear in the method definitions.
00:07 < sipa> but imposing such rules on an existing project sounds much more burden than it's worth
00:07 < wumpus> would be better to simply return output arguments, too bad we can't use std::optional 
00:07 < provoostenator> Especially with all the references it gets confusing fast.
00:08 < wumpus> sipa: I agree but what about new code?
00:08 < gmaxwell> (also it's a common convention in libc, e.g. memcpy(dest,src,...))
00:08 < provoostenator> std::optional sounds great. Part of c++17 so looking forward to using that in 2023
00:08 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection]
00:08 < sipa> c++ stl usually has inputs first, outputs last
00:09 < sipa> (different from libc)
00:09 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
00:09 < wumpus> yes
00:09 < gmaxwell> (sprintf(buf, fmt, vaargs)...)
00:09 < wumpus> I don't think c++'s reference syntax made output arguments particularly clearer
00:10 < wumpus> at least in C it's usually recognizable because the caller has to take a pointer
00:10 < gmaxwell> (to be clear, I don't particularly care, I have a preference for dest first in C, but C++ is already crazy regardless of the order. :P )
00:10 < sipa> google c++ only lets you pass const references; if you want something mutable, it needs to be a pointer
00:10 < wumpus> in C++ it's sometimes magic 'oh, so this value gets changed'
00:11 < wumpus> sipa: I like that
00:11 < sipa> (which makes sense syntactically, but semantically is somewhat ridiculous... modern c++ shouldn't need to deal with raw pointers pretty much ever)
00:12 < sipa> that was also pre-c++11, i don't know what changed
00:12 < sipa> ideally output arguments are actual outputs, and with std::pair/tuple and move semantics that became a lot more reasonable
00:12 < wumpus> yea, I don't mean we should do that, but I like that some people thought about this and came to a similar conclusion as me
00:13 < sipa> c++17 structured bindings are even nicer
00:13 < sipa> auto [a,b,c] = function_returning_3tuple()
00:13 < wumpus> yes, nice
00:14  * sipa patiently awaits RHEL to adopt GCC 8
00:15 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
00:20 < wumpus> ideally "output" arguments would only be necessary for "inout" arguments that get modified in place
00:20 < wumpus> not for anything that is created anew
00:21 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has joined #bitcoin-core-dev
00:21 < wumpus> GCC 8 ? that's going to be a long wait I'm afraid
00:23 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
00:23 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
00:25 < sipa> most of it is in gcc 7
00:26 < wumpus> gcc 7 is in ubuntu 18.04 LTS that's good at least
00:32 < sipa> gcc 8.2 is in bionic too, it seems: https://packages.ubuntu.com/bionic/gcc-8
00:32 < sipa> oh, not sure if that's gcc 8.1 or 8.2
00:33 -!- csknk [~csknk@unaffiliated/csknk] has left #bitcoin-core-dev []
00:33 < sipa> yeah, 8.2
00:33 < wumpus> it's possible to install the alternative gcc but I think it is installed next to the normal one
00:34 < sipa> yes
00:34 < wumpus> which is somewhat annoying to work with with build systems and such, remember having some trouble with this at some point
00:44 -!- JackH [~laptop@host86-134-40-210.range86-134.btcentralplus.com] has quit [Ping timeout: 240 seconds]
01:00 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
01:00 < wumpus> dang I had forgot we have our own Optional<> type wrapping boosts', have suggested using that to avoid this discussion
01:01 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
01:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:09 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev
01:12 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:31 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev
01:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:50 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
02:00 -!- prometheus_falli [~prometheu@185.213.152.163] has joined #bitcoin-core-dev
02:03 -!- kexkey [~kexkey@173.209.48.156] has quit [Read error: Connection reset by peer]
02:04 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:05 -!- Kevin [aecf3529@gateway/web/freenode/ip.174.207.53.41] has joined #bitcoin-core-dev
02:06 -!- prometheus_falli [~prometheu@185.213.152.163] has quit [Remote host closed the connection]
02:06 -!- Kevin [aecf3529@gateway/web/freenode/ip.174.207.53.41] has quit [Client Quit]
02:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds]
02:15 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
02:17 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
02:19 < wumpus> many translators get confused on the " Config setting for %s only applied on %s network when in [%s] section." message
02:19 < wumpus> it's unfortunate that we can't use named substitutions like in python
02:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:26 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
03:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:27 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Remote host closed the connection]
03:27 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
03:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
03:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
03:51 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Read error: Connection reset by peer]
03:52 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
03:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
04:05 -!- siom [~siom@185.216.35.120] has joined #bitcoin-core-dev
04:14 -!- rockhouse1 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
04:14 -!- victorSN9 [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
04:18 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vdyfomgoavmtovtu] has joined #bitcoin-core-dev
04:29 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection]
04:45 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has quit [Quit: rex4539]
04:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vdyfomgoavmtovtu] has quit []
05:17 < rafalcpp> LXC vulnerability (used in Gitian).   CVE-2019-5736: runc container breakout   (all versions) https://seclists.org/oss-sec/2019/q1/119
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:17 < bitcoin-git> [bitcoin] laanwj closed pull request #15155: test: Support -cli tests using external bitcoin-cli (master...test_external_bcli) https://github.com/bitcoin/bitcoin/pull/15155
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:17 < rafalcpp> probably not a concern since we run known code inside Gitian LXC container
05:18 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
05:18 < wumpus> not a concern for gitian but still good to know, thanks
05:18 < rafalcpp> unless, someone would trick a person to build for him his PR in Gitian just to test things, and take over account of e.g. a developer
05:19 < rafalcpp> wumpus: Gitian is known to not be affected by this?
05:22 -!- Karyon_ [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
05:23 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 240 seconds]
05:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:31 < wumpus> I don't think the gitian system is otherwise hardened against, say, malicious descriptors
05:31 < wumpus> so I don't think a possible escape changes much
05:32 < wumpus> but anyhow, upgrade if you can
05:33 < rafalcpp> before distros are fully update, it is probably good if main developers would run Gitian on separate machine, and sign results on another. Sorry to be pedantic, but it's BTC... :)
05:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds]
05:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:38 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev
05:38 < wumpus> FWIW I've always done that
05:39 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
05:43 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
05:45 -!- math_ [~mario@p57BDA5AC.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
05:50 < luke-jr> rafalcpp: it's a concern for anyone who does gitian builds of arbitrary repos
05:51 < luke-jr> and yes, my gitian sign script is `true` :P
05:51 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has joined #bitcoin-core-dev
05:55 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
05:56 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
05:56 < wumpus> right, that ^^ if anyone would be able to sneak a VM escape into the gitian descriptors in one of our main branches things would be really bad
05:57 -!- shesek` [~shesek@141.226.146.222] has joined #bitcoin-core-dev
05:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds]
06:00 -!- Karyon_ [~karyon@unaffiliated/karyon] has quit [Remote host closed the connection]
06:01 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
06:15 -!- Karyon_ [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
06:17 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 240 seconds]
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:28 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bc149d05b09...65435701efda
06:28 < bitcoin-git> bitcoin/master a99999c MarcoFalke: util: Add SetupHelpOptions()
06:28 < bitcoin-git> bitcoin/master 6543570 Wladimir J. van der Laan: Merge #15358: util: Add SetupHelpOptions()
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] laanwj merged pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
06:55 -!- Karyon_ [~karyon@unaffiliated/karyon] has quit [Ping timeout: 240 seconds]
07:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
07:14 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:19 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
07:20 -!- promag [~promag@83.223.251.47] has joined #bitcoin-core-dev
07:23 -!- Klox [~Klox@c-73-22-66-195.hsd1.il.comcast.net] has quit [Ping timeout: 246 seconds]
07:25 -!- Klox [~Klox@c-73-22-66-195.hsd1.il.comcast.net] has joined #bitcoin-core-dev
07:29 < provoostenator> Any idea why "make src/bitcoin-tx" works, but "make src/bitcoin-wallet" returns "No rule to make target"?
07:29 < provoostenator> I can't see any obvious differences in Makefile.am
07:31 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:32 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:33 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has quit [Ping timeout: 245 seconds]
07:36 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has joined #bitcoin-core-dev
07:38 < luke-jr> provoostenator: I don't see it in Makefile.am at all?
07:38 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
07:39 < luke-jr> note the relevant Makefile.am is NOT the one in src/
07:41 < provoostenator> luke-jr: how so? "bin_PROGRAMS += bitcoin-tx" is in src/Makefile.am too
07:42 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:42 < provoostenator> Ah but there's no BITCOIN_WALLET_BIN in /Makefile.am, like there is a BITCOIN_TX_BIN
07:43 < provoostenator> So there's something missing...
07:43 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
07:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:46 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:47 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has quit [Quit: rex4539]
07:48 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:48 -!- promag [~promag@83.223.251.47] has quit [Remote host closed the connection]
07:49 < wumpus> I don't get why this code does (Network)1 (Network)2 instead of directly using the NET_* constants: https://github.com/bitcoin/bitcoin/blob/master/src/qt/clientmodel.cpp#L279
07:50 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
07:51 < wumpus> provoostenator: yea there needs to be a rule $(BITCOIN_TX_BIN): FORCE
07:51 < wumpus>         $(MAKE) -C src $(@F)
07:52 < provoostenator> I'll make a PR...
07:52 < wumpus> for the wallet tool
07:53 < provoostenator> It's either a subset of, or detour from, the headache I'm getting in #15382 because I added a UniValue dependency to system.{h,cpp} 
07:53 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
07:54 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:58 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 240 seconds]
07:58 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
08:00 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:03 < bitcoin-git> [bitcoin] Sjors opened pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:08 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
08:09 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
08:10 < wumpus> this is really weird code too "(strProxy == strDefaultProxyGUI.toStdString()) ? ui->proxyReachIPv4->setChecked(true) : ui->proxyReachIPv4->setChecked(false);"   I've never seen a tertiary operator used to switch between imperative statements
08:11 < wumpus> (which return void)
08:12 < wumpus> especially as they could have simply used ui->proxyReachIPv4->setChecked(strProxy == strDefaultProxyGUI.toStdString()) ?
08:13 < luke-jr> wumpus: IIRC, it was contributed by a new dev at the time
08:13 < luke-jr> so I wouldn't assume there are good reasons
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65435701efda...03732f8644a4
08:13 < wumpus> ok-I'm slightly about about the lack of review then :)
08:13 < bitcoin-git> bitcoin/master 1cdb9bb Gregory Sanders: minor p2p_sendheaders fix of height in coinbase
08:13 < bitcoin-git> bitcoin/master 03732f8 MarcoFalke: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:14 < luke-jr> #11491
08:14 < gribble> https://github.com/bitcoin/bitcoin/issues/11491 | [gui] Add proxy icon in statusbar by mess110 · Pull Request #11491 · bitcoin/bitcoin · GitHub
08:15 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
08:15 < luke-jr> > Note that the network ids aren't just arbitrary numbers - they have meanings (defined in netaddress.h). -myself :P
08:16 < wumpus> heh
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03732f8644a4...d8794a78a887
08:18 < bitcoin-git> bitcoin/master ae892ad Chun Kuan Lee: tests: accept unicode characters on Windows
08:18 < bitcoin-git> bitcoin/master 15b3103 Chun Kuan Lee: appveyor: Remove outdated libraries
08:18 < bitcoin-git> bitcoin/master d8794a7 MarcoFalke: Merge #13787: Test for Windows encoding issue
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #13787: Test for Windows encoding issue (master...test_u8path) https://github.com/bitcoin/bitcoin/pull/13787
08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:30 -!- JackH [~laptop@62.232.170.181] has quit [Ping timeout: 250 seconds]
08:34 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ixfdpksazowvorpq] has joined #bitcoin-core-dev
08:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds]
08:45 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:46 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
08:47 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection]
08:51 < wumpus> this is why I sometimes ask in PRs wether all people think their comments were addressed, it can be hard to track
09:00 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
09:05 -!- JackH [~laptop@host86-134-40-210.range86-134.btcentralplus.com] has joined #bitcoin-core-dev
09:08 -!- siom [~siom@185.216.35.120] has quit [Remote host closed the connection]
09:12 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
09:17 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:26 < bitcoin-git> [bitcoin] scravy opened pull request #15389: Remove unnecessary const_cast (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15389
09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:27 -!- promag [~promag@83.223.251.47] has joined #bitcoin-core-dev
09:28 < promag> jnewbery: please see my comment in #15153
09:28 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
09:32 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 246 seconds]
09:38 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
09:40 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
09:44 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
09:47 < promag> provoostenator: why cpp-subprocess instead of boost::process?
09:50 < promag> provoostenator: just saw the comments in the other issue
09:51 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
09:56 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:57 < bitcoin-git> [bitcoin] jnewbery opened pull request #15390: [wallet] Close bdb when flushing wallet. (master...wallet_flush) https://github.com/bitcoin/bitcoin/pull/15390
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:03 < bitcoin-git> [bitcoin] practicalswift opened pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
10:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:06 < promag> could we just enable #13339 for non-win builds for 0.18?
10:06 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
10:06 -!- Aaronvan_ is now known as AaronvanW
10:10 -!- promag [~promag@83.223.251.47] has quit [Remote host closed the connection]
10:20  * instagibbs just learned about --pdbonfailure, my life is a lie
10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:21 < bitcoin-git> [bitcoin] jonasschnelli pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/d8794a78a887...7d3f255316fc
10:21 < bitcoin-git> bitcoin/master 17abc0f João Barbosa: wallet: Factor out LoadWallet
10:21 < bitcoin-git> bitcoin/master ab288b4 João Barbosa: interfaces: Add loadWallet to Node
10:21 < bitcoin-git> bitcoin/master 32a8c6a João Barbosa: gui: Add openWallet and getWalletsAvailableToOpen to WalletController
10:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:22 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15153: gui: Add Open Wallet menu (master...2019-01-openwallet) https://github.com/bitcoin/bitcoin/pull/15153
10:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:22 < provoostenator> promag: the author of cpp-subprocess said he found boost::process implementation unpretty. I haven't studied it in enough detail yet to have a strong opinion. But aren't we trying to nuke Boost?
10:29 < luke-jr> provoostenator: we're trying to migrate from boost to C++11; if C++11 doesn't provide it, no reason to avoid boost for it
10:29 < luke-jr> (I'm not sure there's much left to migrate at this point either?)
10:30 < provoostenator> Ok, sounds like I'll have to study both implementations then :-)
10:30 < provoostenator> Assuming Boost does work with Windows that would be a good argument for it.
10:32 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:32 -!- sakalli_ [~Mutter@mobile-access-5d6a41-47.dhcp.inet.fi] has joined #bitcoin-core-dev
10:34 < jnewbery> Great to see #15153 merged. I think it could do with a bit more review (I plan to when I get a chance)
10:34 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
10:35 -!- sakalli_ [~Mutter@mobile-access-5d6a41-47.dhcp.inet.fi] has quit [Client Quit]
10:43 < luke-jr> has there been any discussion previously about the binary name for bitcoin-wallet? seems strange to me.
10:44 -!- promag [~promag@83.223.251.47] has joined #bitcoin-core-dev
10:44 -!- promag [~promag@83.223.251.47] has quit [Read error: Connection reset by peer]
10:45 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:46 < promag> provoostenator: what luke-jr said. anyway, I don't have experience with boost::process, just think it's nice by reading the docs.
10:48 < provoostenator> luke-jr jnewbery: I was thoroughly confused by this naming today while debugging the Makefile, because that actualy contains "bitcoin-wallet" as an intermediate stage for the wallet itself.
10:49 < provoostenator> Might be better to call it wallet-tool
10:49 < jnewbery> Was changed from bitcoin-wallet-tool after discussion here: https://github.com/bitcoin/bitcoin/pull/13926#issuecomment-423326338
10:50 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
10:50 < provoostenator> In this case I actually thing the -tool suffix makes sense, to distinguish it from a live wallet.
10:50 < luke-jr> when we split the actual wallet out from the main code, what will we call its binary? :P
10:50 < provoostenator> Though I might be suffering from cognitive bias :-)
10:51 < provoostenator> luke-jr in #10102 that new binary is called bitcoin-wallet
10:51 < gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
10:51 < luke-jr> …but…
10:53 < provoostenator> So wallet-tool makes sense for this tool. Or even offline-wallet or something. The live wallet in a split code base, which connects to a node, could then be called bitcoin-wallet. 
10:54 < jnewbery> ryanofsky: thoughts ^ ?
10:54 < provoostenator> Ironically bitcoin-wallet was ryanofsky's idea in that comment :-)
10:55 < jnewbery> I currently have no strong opinion one way or the other (but think we should make a decision before 0.18 freeze)
10:55 < ryanofsky> i was just thinking that you have one binary called bitcoin-wallet that you use for all wallet stuff
10:55 < ryanofsky> not sure what advantage there would be to having separate bitcoin-wallet and bitcoin-wallet-tool binaries
10:56 < jnewbery> That seems like a reasonable suggestion to me. Merge wallet tool functionality into the new new bitcoin-wallet when it happens
10:56 < ryanofsky> yeah, i already implemented that (though can't remember if i pushed it to 10102 yet)
10:57 < provoostenator> Any volunteers for bumping QT to 5.5 as per #13478?
10:57 < gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
10:57 < jnewbery> so for now, keep the wallet tool as bitcoin-wallet, and when the separated bitcoin-wallet happens the tool commands will continue to work as expected?
10:58 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has joined #bitcoin-core-dev
10:59 < provoostenator> ryanofsky: that works for me as well. If the Makefile confuses someone again, we can also rename the intermediate bitcoin_wallet step.
11:02 < gmaxwell> FWIW, I actually misread PRs related to the wallet tool and thought it was named bitcoin-wallet-tool
11:03 < provoostenator> I think appveyor is on strike by the way.
11:04 < provoostenator> gmaxwell: it was renamed from bitcoin-wallet-tool to bitcoin-wallet along the way.
11:04 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev
11:04 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds]
11:04 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 240 seconds]
11:04 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 240 seconds]
11:04 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 240 seconds]
11:04 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 240 seconds]
11:04 -!- profmac [~ProfMac@2001:470:1f0f:226:21cb:a56c:746:977f] has quit [Ping timeout: 240 seconds]
11:04 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds]
11:04 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds]
11:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]
11:04 -!- ccook [sid271969@gateway/web/irccloud.com/x-jemnfnpqzqhzvvch] has quit [Ping timeout: 240 seconds]
11:04 -!- ccook_ [sid271969@gateway/web/irccloud.com/x-pieobunsxejrhoqd] has joined #bitcoin-core-dev
11:04 -!- profmac [~ProfMac@2001:470:1f0f:226:b003:d1c5:b7c:b4ba] has joined #bitcoin-core-dev
11:05 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
11:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
11:05 -!- Apocalyptic_ [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev
11:05 -!- Apocalyptic_ is now known as Apocalyptic
11:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
11:05 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
11:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
11:05 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
11:10 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
11:14 -!- sakalli_ [~Mutter@91-155-115-184.elisa-laajakaista.fi] has joined #bitcoin-core-dev
11:16 -!- sakalli_ [~Mutter@91-155-115-184.elisa-laajakaista.fi] has quit [Client Quit]
11:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
11:25 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] Sjors opened pull request #15393: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:39 -!- protomar [~protomar@213.152.161.181] has joined #bitcoin-core-dev
11:47 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
11:49 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
11:59 -!- protomar [~protomar@213.152.161.181] has quit [Quit: Leaving]
12:03 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
12:07 -!- shesek`` [~shesek@188.120.132.194] has joined #bitcoin-core-dev
12:08 -!- shesek` [~shesek@141.226.146.222] has quit [Ping timeout: 245 seconds]
12:20 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev
12:20 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d3f255316fc...ea022d9fd047
12:30 < bitcoin-git> bitcoin/master dc3b2cc Ben Carman: tests: Added missing tests for RPC wallet errors
12:30 < bitcoin-git> bitcoin/master ea022d9 MarcoFalke: Merge #15378: tests: Added missing tests for RPC wallet errors
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15378: tests: Added missing tests for RPC wallet errors (master...tests_missing_tests) https://github.com/bitcoin/bitcoin/pull/15378
12:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:37 -!- michael__ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
12:40 -!- shesek`` [~shesek@188.120.132.194] has quit [Ping timeout: 245 seconds]
12:40 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Ping timeout: 245 seconds]
12:50 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
13:00 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
13:06 -!- profmac [~ProfMac@2001:470:1f0f:226:b003:d1c5:b7c:b4ba] has quit [Ping timeout: 240 seconds]
13:07 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
13:07 -!- profmac [~ProfMac@2001:470:1f0f:226:b003:d1c5:b7c:b4ba] has joined #bitcoin-core-dev
13:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
13:39 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 250 seconds]
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea022d9fd047...d73918447faf
13:42 < bitcoin-git> bitcoin/master 8c9b8a3 Hennadii Stepanov: Replace script name with special parameter
13:42 < bitcoin-git> bitcoin/master d739184 MarcoFalke: Merge #15216: Scripts and tools: Replace script name with a special parame...
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:51 < promag> rpc_psbt.py failed https://travis-ci.org/bitcoin/bitcoin/jobs/492345001#L2938
13:51 < promag> is this flacky?
13:53 < luke-jr> provoostenator: did you make a decision for subprocess mgmt?
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d73918447faf...029d28a7aa56
13:55 < bitcoin-git> bitcoin/master 1e7f741 Gregory Sanders: remove some magic mining constants in functional tests
13:55 < bitcoin-git> bitcoin/master b651ef7 Gregory Sanders: submitheader: more directly test missing prev block header
13:55 < bitcoin-git> bitcoin/master 029d28a MarcoFalke: Merge #15238: [QA] remove some magic mining constants in functional tests
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15238: [QA] remove some magic mining constants in functional tests (master...magic_miner) https://github.com/bitcoin/bitcoin/pull/15238
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:12 -!- shesek`` [~shesek@141.226.152.217] has joined #bitcoin-core-dev
14:25 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ixfdpksazowvorpq] has quit [Quit: Connection closed for inactivity]
14:31 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
14:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
14:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:42 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
14:42 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
14:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
14:45 < hebasto> promag: hi! how can I push commit with fixed commit message only? -f does not work.
14:46 < promag> hebasto: really?
14:46 < dongcarl> hebasto: is the remote correct?
14:47 < promag> usually I commit --amend and then push -f
14:47 < promag> it works :/ maybe it's what dongcarl asked
14:47 < dongcarl> Like check what is considered your upstream, as that is what `push -f` tries to push to
14:48 < hebasto> my bad. it's ok now. thank you.
14:49 < dongcarl> :-)
14:51 < promag> hebasto: please fix pr title too
14:53 < hebasto> promag: is it ok now?
14:53 < promag> lgtm
14:54 < hebasto> thanks
14:55 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:56 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:15 -!- michael__ [~michaelsd@38.126.31.226] has quit [Read error: Connection reset by peer]
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:15 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15395: test: Remove TODO comments to remove -txindex option (master...Mf1902-qaNoTodo) https://github.com/bitcoin/bitcoin/pull/15395
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:19 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
15:29 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
15:42 -!- jimmysong_ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
15:42 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
15:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/029d28a7aa56...0d1160e42185
15:46 < bitcoin-git> bitcoin/master fa0ad4e MarcoFalke: RPCHelpMan: Check default values are given at compile-time
15:46 < bitcoin-git> bitcoin/master 0d1160e MarcoFalke: Merge #14918: RPCHelpMan: Check default values are given at compile-time
15:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14918: RPCHelpMan: Check default values are given at compile-time (master...Mf1812-rpcOptionalCompile) https://github.com/bitcoin/bitcoin/pull/14918
15:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:48 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:49 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
16:05 < moneyball> does anyone know how to find all open PRs that modify a particular file (ie validation.cpp)?
16:06 < pinheadmz> github you can view history of a single file
16:06 < pinheadmz> or check the "blame"
16:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:32 -!- booyah_ [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
16:33 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-fjxnreflsvicxwrw] has joined #bitcoin-core-dev
16:33 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
16:34 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-fjxnreflsvicxwrw] has quit [Client Quit]
16:34 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-ljeqasomrqxnlcqd] has joined #bitcoin-core-dev
16:35 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-ljeqasomrqxnlcqd] has quit [Client Quit]
16:35 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 250 seconds]
16:36 -!- rhavar [uid237883@gateway/web/irccloud.com/x-vnmvhcjasgoekejs] has joined #bitcoin-core-dev
16:38 -!- booyah_ [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
16:39 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
16:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
16:42 < moneyball> pinheadmz thanks but that only shows history/merged PRs and not open PRs, right?
16:44 < booyah_> why bitcoin uses ECDSA on secp256k1 instead of Ed25519, any arguments for/against?
16:47 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
16:48 < sipa> booyah_: ask satoshi
16:49 < sipa> as for why it hasn't changed since: they're similar in performance, changing is hard, ed25519's cofactors are annoying to build more complex constructions on
16:50 < sipa> (and probably more on topic in #bitcoin-wizards)
16:53 < booyah_> sipa: ok then implementation question, secp256k1 support is home-made and probably will remain so, as opposed to eg using a general library like nacl/sodium?
16:54 < sipa> i don't see good reasons to change it
16:54 < MarcoFalke> moneyball: could be an idea for bitcoinacks by pierre_rochard
16:54 < sipa> booyah_: it would be slower, introduce new review burden, and any change of that kind is risky
16:54 < gmaxwell> ed25519 is unambigiously less secure too, though not in an amount that would matter.
16:55 < sipa> by about 1-1.5 bits or so, yeah
16:55 < gmaxwell> and re cofactor, several cryptocurrencies have had serious vulnerabilities due to using ed25519.
16:56 < gmaxwell> E.g. monero/cryptonote/etc. had an unbounded inflation bug due to cofactor handling.
16:58 < gmaxwell> basically, the ed25519 stuff in general is okay, it makes its own tradeoffs, but it extremely overhyped with a lot of misleading marketing.
16:58 < sipa> https://twitter.com/hdevalence/status/1093684731500146688
16:59 < booyah_> gmaxwell: which attack works on ed25519 but not on secp?
16:59 < sipa> booyah_: i would hope none!
17:00 < sipa> it's just harder to get complex protocols on top right
17:00 < gmaxwell> booyah_: cofactor attacks, as I mentioned.
17:00 < sipa> ed25519 is a digital signature system, and when used as just that - it's perfectly fine
17:01 < sipa> but something like bip32 is already somewhat harder to do for ed25519
17:02 < gmaxwell> and ... has been done wrong multiple times.
17:05 -!- booyah_ is now known as booyah
17:12 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
17:15 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:17 < echeveria> people generally misunderstand that ed25519 is not a single show signature, due to the marketing.
17:18 < echeveria> this has resulted in vulnerabilities as well. it’s deterministic as secp256k1 is, with rfc6979, but this is not a method of making signatures single show.
17:18 < sipa> i think you mean "unique" instead of "single show"
17:18 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 268 seconds]
17:20 < booyah> what is single show signature?
17:20 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
17:20 < sipa> a signature that leaks the private key as soon as you sign two different messages with the same key
17:21 < echeveria> sipa: yeah, wrong terminology I think.
17:21 < sipa> a unique signature is one where every message/pubkey pair has exactly one valid signature
17:22 < booyah> hmm?? ed25519 (nor secp256k1) are not single-show right? lamport is
17:22 < sipa> correct
17:23 < sipa> which is why i think echeveria meant unique signature, not single show
17:23 < echeveria> booyah: right. a well known altcoins uses this “property” of ed25519 to protect against stake grinding attacks. their misunderstanding of the description of ed25519 make them believe the output was unique, where the text suggested the outputs were deterministic.
17:23 < sipa> (neither ed25519 nor secp256k1 are unique, but due to the deterministic signing constructing in ed25519 people sometimes think it is - but it's no different than using rfc6979 with secp256k1)
17:25 < echeveria> yes. the text just meant the reference library was 6979 by default. bizarrely a lot of ecdsa libraries still aren’t.
17:27 < booyah> what would be signature being unique, and being deterministic, in this context?
17:27 < booyah> deterministic = for same cleartext, and same privkey, it produces identical signature?
17:27 < sipa> deterministic is a property of a signing implementation, not a property of the signature scheme
17:27 < sipa> unique means that the only possible implementation is deterministic
17:28 < sipa> BLS for example is unique
17:28 < echeveria> in the context of the signer, they choose their nonce based on the H(message + privkey) rather than choosing random bytes. it is impossible to prove this happened to an untrusted observer. 
17:29 < sipa> wellll.... (/me wonders off into ZKP land)
17:29 < booyah> echeveria: neat. makes sense
17:32 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
17:35 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
17:45 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 264 seconds]
17:50 -!- twistedline_ [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 252 seconds]
17:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
18:15 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:33 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev
18:34 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Remote host closed the connection]
18:47 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
18:58 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:21 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:22 -!- jasonzhouu [~root@101.132.74.90] has quit [Ping timeout: 250 seconds]
19:24 -!- jasonzhouu [~root@101.132.74.90] has joined #bitcoin-core-dev
19:36 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:41 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
19:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:51 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
19:57 -!- sakalli_ [~Mutter@91-155-115-184.elisa-laajakaista.fi] has joined #bitcoin-core-dev
19:59 -!- sakalli_ [~Mutter@91-155-115-184.elisa-laajakaista.fi] has quit [Client Quit]
20:00 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev
20:00 -!- jimmysong_ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev
20:00 -!- jimmysong_ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Client Quit]
20:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
20:14 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
20:17 -!- shesek`` [~shesek@141.226.152.217] has quit [Ping timeout: 245 seconds]
20:34 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
20:45 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:03 -!- shesek`` [~shesek@141.226.217.238] has joined #bitcoin-core-dev
21:06 -!- sakalli_ [~Mutter@mobile-access-5d6a41-47.dhcp.inet.fi] has joined #bitcoin-core-dev
21:08 -!- sakalli_ [~Mutter@mobile-access-5d6a41-47.dhcp.inet.fi] has quit [Client Quit]
21:26 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds]
21:45 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:52 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Read error: Connection reset by peer]
22:06 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
22:10 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 258 seconds]
22:18 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:33 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds]
22:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
22:41 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:55 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has quit [Quit: rex4539]
22:56 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
22:57 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: Leaving]
23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:38 < bitcoin-git> [bitcoin] yunchiri opened pull request #15396: Update build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15396
23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:42 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:44 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
23:46 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Ping timeout: 259 seconds]
23:48 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev
23:57 < provoostenator> luke-jr: I'm still open to either cpp-subprocess or boost::process or something else; need to study them more. It shouldn't be too hard to swap them in my PR.
--- Log closed Wed Feb 13 00:00:48 2019