--- Log opened Mon Mar 04 00:00:06 2019 00:04 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:10 -!- _Sam-- [greybits@gateway/vpn/privateinternetaccess/sam--/x-37783179] has quit [Ping timeout: 250 seconds] 00:12 -!- mariusz18 [~mariusz@2804:2728:101:5b9:5077:ee81:c646:5b6] has joined #bitcoin-core-dev 00:17 -!- mariusz18 [~mariusz@2804:2728:101:5b9:5077:ee81:c646:5b6] has quit [Ping timeout: 264 seconds] 00:17 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 250 seconds] 00:20 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:32 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer] 00:37 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 00:39 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 01:05 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection] 01:05 -!- mn949588 [~nodebot@67.243.201.127] has joined #bitcoin-core-dev 01:06 -!- rex4539 [~rex4539@ppp-2-84-160-62.home.otenet.gr] has quit [Quit: rex4539] 01:21 -!- rex4539 [~rex4539@ppp-2-84-160-62.home.otenet.gr] has joined #bitcoin-core-dev 01:23 -!- rex4539 [~rex4539@ppp-2-84-160-62.home.otenet.gr] has quit [Client Quit] 01:37 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:38 -!- gvhoecke_26 [~gvhoecke_@117.196.235.193] has joined #bitcoin-core-dev 01:43 -!- gvhoecke_26 [~gvhoecke_@117.196.235.193] has quit [Ping timeout: 255 seconds] 01:46 -!- ansabr28 [~ansabr@121.135.69.74] has joined #bitcoin-core-dev 01:46 -!- ansabr28 [~ansabr@121.135.69.74] has quit [Remote host closed the connection] 01:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 01:52 -!- TWE76fYU [~v8C16x3R@178.138.32.232] has quit [Remote host closed the connection] 02:04 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@68.168.122.228] has quit [Ping timeout: 245 seconds] 02:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:08 -!- bhaak17 [~bhaak@c-24-127-124-83.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 02:08 -!- bhaak17 [~bhaak@c-24-127-124-83.hsd1.mi.comcast.net] has quit [Remote host closed the connection] 02:09 -!- House [~House@2804:2728:100:1a8:b867:c53a:b03d:20cb] has joined #bitcoin-core-dev 02:13 -!- BruceS [~BruceS@2804:2728:101:9b0:b9d9:7b4a:1dae:275d] has joined #bitcoin-core-dev 02:13 -!- House [~House@2804:2728:100:1a8:b867:c53a:b03d:20cb] has quit [Ping timeout: 252 seconds] 02:16 -!- mavhq29 [~mavhq@27.19.144.66] has joined #bitcoin-core-dev 02:18 -!- Lymia28 [~Lymia@74-21-191-213.fttb.ur.ru] has joined #bitcoin-core-dev 02:18 -!- BruceS [~BruceS@2804:2728:101:9b0:b9d9:7b4a:1dae:275d] has quit [Ping timeout: 252 seconds] 02:18 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 02:18 -!- Lymia28 [~Lymia@74-21-191-213.fttb.ur.ru] has quit [Remote host closed the connection] 02:19 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 244 seconds] 02:19 -!- mavhq29 [~mavhq@27.19.144.66] has quit [Remote host closed the connection] 02:23 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 02:29 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Quit: Leaving] 02:30 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 02:33 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 02:39 -!- axhanul [~axhanul@2a03:f680:fff2::13b] has joined #bitcoin-core-dev 02:41 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection] 02:41 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 02:44 -!- axhanul [~axhanul@2a03:f680:fff2::13b] has quit [Ping timeout: 258 seconds] 02:48 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:49 -!- Guest13633 [~blue@110.90.142.176] has joined #bitcoin-core-dev 02:51 -!- Guest13633 [~blue@110.90.142.176] has quit [Remote host closed the connection] 02:55 -!- philroche5 [~philroche@2001:1670:8:8000:2472:73c:a8b:7277] has joined #bitcoin-core-dev 02:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 02:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 02:56 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:00 -!- philroche5 [~philroche@2001:1670:8:8000:2472:73c:a8b:7277] has quit [Ping timeout: 252 seconds] 03:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds] 03:06 -!- Daedbffe25 [~Daedbffe@124.228.239.173] has joined #bitcoin-core-dev 03:11 -!- Daedbffe25 [~Daedbffe@124.228.239.173] has quit [Ping timeout: 250 seconds] 03:12 -!- bamvor5 [~bamvor@2804:2728:102:94f:5c74:418f:84f7:7c16] has joined #bitcoin-core-dev 03:14 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection] 03:14 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 03:16 -!- bamvor5 [~bamvor@2804:2728:102:94f:5c74:418f:84f7:7c16] has quit [Read error: Connection reset by peer] 03:20 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has joined #bitcoin-core-dev 03:21 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has quit [Client Quit] 03:25 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:26 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection] 03:26 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 03:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:29 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 03:33 -!- HeathHayle3 [~HeathHayl@62.149.92.2] has joined #bitcoin-core-dev 03:34 -!- roflin19 [~roflin@183.157.174.152] has joined #bitcoin-core-dev 03:37 -!- HeathHayle3 [~HeathHayl@62.149.92.2] has quit [Ping timeout: 255 seconds] 03:39 -!- roflin19 [~roflin@183.157.174.152] has quit [Ping timeout: 255 seconds] 03:44 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 03:58 < wumpus> i think it's time to do a 0.18.0rc1 soon 03:58 < jonasschnelli> In IBD we account the maxmempool to the dbache, though, I fail to find the codepart that makes sure we flush the database once in sync with a db-cache not adding the maxmempool 03:58 < jonasschnelli> wumpus: ack 04:01 < wumpus> PSA: please don't assign anything to 0.18.0 anymore unless it's a regression that needs to be fixed in a RC, thanks 04:02 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 04:05 < wumpus> so is there anything in https://github.com/bitcoin/bitcoin/milestones/0.18.0 that blocks rc1? 04:07 -!- TMA26 [~TMA@2001:8003:70d6:ba01::1] has joined #bitcoin-core-dev 04:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:10 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d46f1be0c3c...57acfcb9fd05 04:10 < bitcoin-git> bitcoin/master fa3148a MarcoFalke: doc: Remove ppa from linux build instructions 04:10 < bitcoin-git> bitcoin/master 57acfcb Wladimir J. van der Laan: Merge #15518: doc: Remove ppa from linux build instructions 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:11 < bitcoin-git> [bitcoin] laanwj merged pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518 04:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds] 04:12 -!- TMA26 [~TMA@2001:8003:70d6:ba01::1] has quit [Ping timeout: 264 seconds] 04:13 < wumpus> backporting #15463 seems a bit premature as it's not merged to master yet; let's wait for the final version to do that-#15486 still has ongoing discussion and review-same for #15402 04:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub 04:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub 04:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub 04:20 < wumpus> so I'm not sure there's anything that should block tagging rc1, say, right now, and getting it out and getting some testing; as for any major release it's extremely likely at least a few RCs will be needed to fix problems that people find along the way 04:25 < wumpus> should we put the preliminary release notes in the wiki again? I think that worked quite well with earlier major releases? 04:25 -!- m8tion [~user@2a01:e35:8bef:9310:449b:38a4:5130:c201] has joined #bitcoin-core-dev 04:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 04:36 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 04:36 < fanquake> wumpus ack tagging an rc1 04:36 < fanquake> also ack using the wiki, worked alright 04:37 < wumpus> yep first need to merge the release note fragments I see 04:41 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 04:43 < wumpus> will do that and then put the release notes on the wiki and tag RC1 04:43 < fanquake> \o/ 04:44 < fanquake> 0.18.0 release schedule running on time 04:45 < wumpus> :D 04:46 < wumpus> "the chainstate database for this release is not compatible with previous releases" this isn't true for 0.18 is it? 04:46 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds] 04:46 < fanquake> off the top of my head, I don't think so 04:47 < fanquake> if there's anything about Windows XP it can probably also be removed 04:47 < rafalcpp> is anyone working on extracting boost::process to standalone library to be included and provided for platforms where system's libboost lacks ::process ? 04:47 < wumpus> I know the format changed with 0.15, I don't think we need to mention downgrading to that 04:47 < wumpus> will keep the upgrade notice for the first time running 0.15 or newer 04:48 < wumpus> rafalcpp: not that I know of 04:49 < fanquake> rafalcpp some boost:process related discussion in 15421 and 15382 04:58 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 05:18 < rafalcpp> actually, why not just build boost from source code, on platforms where it is older than 1.64 05:18 < rafalcpp> just compilation time is the concern? 05:18 < wumpus> convenience of building as well 05:19 < rafalcpp> wumpus: but the alternative, of using extracted boost::process, will it be much better? 05:19 < wumpus> the depends system is nice but doesn't really work on every platform (say, BSDs etc) 05:20 < wumpus> better in what regard? 05:20 < wumpus> from what I heard boost::process used to be a separate library in the first place 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:21 < bitcoin-git> [bitcoin] practicalswift opened pull request #15522: Document sizeof(size_t) assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:25 < rafalcpp> wumpus: what do you mean it does not work on BSD? I think the process would be like (I assume) Gitian does it inside: git clone main boost, then checkout few of submodules (::process and its deps) then b2, make/make install to prefix, and tell autotools to puck that up 05:28 -!- m8tion_ [~user@167.88.108.151] has joined #bitcoin-core-dev 05:29 < wumpus> there's no reason it wouldn't theoretically work, but just try it out, go to depends and do `make` (excluding qt) on say, OpenBSD, I think it fails somewhere along the way 05:30 < wumpus> you're welcome to fix that of course! but until we can be *sure* that the depends build works on all the platforms that bitcoind builds on, "just use depends" is not a valid requirement 05:31 < wumpus> this is why something that builds as part of our own tree is likely a more feasible approach 05:31 -!- m8tion [~user@2a01:e35:8bef:9310:449b:38a4:5130:c201] has quit [Ping timeout: 257 seconds] 05:31 -!- shesek [~shesek@141.226.146.161] has joined #bitcoin-core-dev 05:31 -!- shesek [~shesek@141.226.146.161] has quit [Changing host] 05:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:31 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 05:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 05:32 < wumpus> it wouldn't be as much of an issue if 1.64 wasn't so recent making it an unreasonable minimum requirement. Though it might be fine if it's only used for optional functionality (e.g. as detected in configure). 05:36 < fanquake> wumpus indeed https://gist.github.com/fanquake/3c01f28491417c8b7fa0a18442034b21 05:36 <@luke-jr> "just use depends" is never a valid requirement (outside of obsolete versions) -.- 05:37 < wumpus> luke-jr: boost 1.64 is thus uncommon it would effectively be the case 05:37 < rafalcpp> I'm not sure what do you mean by that depends - is this your custom script that downloads some dependencies (curl instead git submodule btw) and builds them? (from ./depends/) 05:37 <@luke-jr> wumpus: but it's optional, right? 05:37 < wumpus> fanquake: right, that 05:38 < wumpus> rafalcpp: yes 05:38 < rafalcpp> but the problem is that this depends/ method anyway is not working, independant of boost::process 05:38 < rafalcpp> (*on bsd) 05:38 < wumpus> that's not a problem at the moment because the version of boost (as well as other dependencies) on various BSDs is recent enough to build bitcoind 05:39 < rafalcpp> I could make another small script to grab + build enough of boost to have boost::process for Bitcoin 05:39 < wumpus> sorry if there's anything we don't want, imo it's another dependency-downloading and building script 05:39 < rafalcpp> ok then what sollution is acceptable? 05:40 < wumpus> make only *optional* functionality depend on boost 1.64 05:40 < wumpus> that would be the first step 05:40 < wumpus> if someone decides to backport boost::process functionality later or something like thta, that'd be great, but it can all start with that 05:41 < rafalcpp> by backporting you mean OS distros doing that? I wouldn't count too much on that happening 05:42 -!- m8tion_ [~user@167.88.108.151] has quit [Quit: Leaving] 05:42 < wumpus> no, I mean extracting and backporting it, as you were suggesting only a few messages ago 05:43 <@luke-jr> rafalcpp: include a copy of just boost::process in the Bitcoin source code, used when the system lacks it 05:43 < rafalcpp> btw, the script is probably git clone && b2 && make install and telling automate to use it and that is all 05:43 < wumpus> this just keeps going back and forth, we already discussed this at one of the meetings too: I'd say just go ahead with whatever requires boost 1.64 and make it optional functionality 05:45 < wumpus> a lot of people don't build with the wallet, so if say, the new external signing support requires that library then it would be outrageous to require boost 1.64 in all cases 05:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:07 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 244 seconds] 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:08 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:12 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 06:14 -!- rasca [~rasca@2804:2728:101:602:bdf2:eafd:abb9:78d9] has joined #bitcoin-core-dev 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:17 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/742f7dd972fc...b702e3757e1d 06:17 < bitcoin-git> bitcoin/0.18 b702e37 Wladimir J. van der Laan: doc: Merge release notes fragments 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:19 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds] 06:19 -!- rasca [~rasca@2804:2728:101:602:bdf2:eafd:abb9:78d9] has quit [Ping timeout: 258 seconds] 06:22 < wumpus> 0.18.0 release notes draft up on the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:28 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/b702e3757e1d...7630301c1628 06:28 < bitcoin-git> bitcoin/0.18 fa3148a MarcoFalke: doc: Remove ppa from linux build instructions 06:28 < bitcoin-git> bitcoin/0.18 7630301 Wladimir J. van der Laan: Merge #15524: [0.18] doc: Remove ppa from linux build instructions 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:28 < bitcoin-git> [bitcoin] laanwj merged pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:29 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 06:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 06:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:39 -!- bjorn3 [~bjorn@2804:2728:102:1bc:b113:9e87:b52c:6fa5] has joined #bitcoin-core-dev 06:40 -!- someara19 [~someara@2804:2728:102:16f:4cba:c2df:8e2b:77d9] has joined #bitcoin-core-dev 06:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:44 -!- bjorn3 [~bjorn@2804:2728:102:1bc:b113:9e87:b52c:6fa5] has quit [Ping timeout: 258 seconds] 06:45 -!- someara19 [~someara@2804:2728:102:16f:4cba:c2df:8e2b:77d9] has quit [Ping timeout: 264 seconds] 06:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 1.9.1] 06:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:52 < wumpus> ^^ 06:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Client Quit] 06:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:54 -!- kexkey [~kexkey@68.168.122.228] has joined #bitcoin-core-dev 06:55 < wumpus> oh crap 06:55 < wumpus> please hold off building rc1 06:55 < achow101> was something forgotten? 06:56 < wumpus> yes we need to set _CLIENT_VERSION_RC now 06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:56 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/7630301c1628...6a178e52618d 06:56 < bitcoin-git> bitcoin/0.18 6a178e5 Wladimir J. van der Laan: build: set RC1 06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:57 < bitcoin-git> [bitcoin] laanwj deleted tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/329381d6ae9a...000000000000 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:58 < bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1 06:58 < wumpus> ok all good now 06:58 < achow101> \o/ 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:59 < mmgen> wumpus: you should make a release checklist, to avoid relying on memory for stuff like that every release 06:59 < wumpus> if you alrady fetched the tag do: git branch -d v0.18.0rc1 && git fetch origin v0.18.0rc1 07:00 < achow101> mmgen: there is. see doc/release-process.md 07:00 < wumpus> mmgen: this is on the check list IIRC 07:00 < wumpus> it's a new step though for this version 07:01 < wumpus> happy I realized it so soon at least 07:02 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kjhlhgjsqypzidhf] has joined #bitcoin-core-dev 07:05 < mmgen> wumpus: ahh, now I see: setting CLIENT_VERSION_RC was added only recently 07:07 < wumpus> yes, and ==0 happens to be 'final release' so that would be unfortunate 07:07 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 07:07 < mmgen> mmgen: indeed! 07:08 -!- Ta1}s0n [~Ta1}s0n@1.214.88.253] has joined #bitcoin-core-dev 07:09 -!- Ta1}s0n [~Ta1}s0n@1.214.88.253] has quit [Read error: Connection reset by peer] 07:09 < mmgen> Sorry, s/mmgen:/wumpus:/ 07:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Quit: Leaving] 07:20 -!- shesek [~shesek@141.226.146.161] has joined #bitcoin-core-dev 07:20 -!- shesek [~shesek@141.226.146.161] has quit [Changing host] 07:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:20 < dongcarl> Wondering why all the release schedule issues are marked "good first issue" 07:20 < wumpus> basically to make it something people stumble over immediately when looking for good first issues 07:21 -!- mode/#bitcoin-core-dev [-q $~a] by luke-jr 07:21 -!- mode/#bitcoin-core-dev [-o luke-jr] by luke-jr 07:21 < luke-jr> (spambots seem to have stopped for a while now) 07:21 < wumpus> and no one can pretend not to be aware of the release schedule :) 07:21 < dongcarl> Ah I see 07:22 < wumpus> I guess it's somewhat less relevant now that "pinned issues" exist, but it predates that functionality by far 07:28 -!- Guest3042 [~Miron@2804:2728:101:45e:f8be:34d3:cab0:c567] has joined #bitcoin-core-dev 07:32 -!- Guest3042 [~Miron@2804:2728:101:45e:f8be:34d3:cab0:c567] has quit [Ping timeout: 240 seconds] 07:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:35 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 07:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit] 07:44 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 07:47 -!- wuseman22 [~wuseman@2001:1670:8:8000:44be:43cf:d0e7:2984] has joined #bitcoin-core-dev 07:51 -!- wuseman22 [~wuseman@2001:1670:8:8000:44be:43cf:d0e7:2984] has quit [Ping timeout: 240 seconds] 07:55 < sipa> wumpus: no the latest database change iirc was the txindex in 0.17, and that one is backward compatible even (old nodes just won't see the index created by new nodes) 07:56 < wumpus> sipa: thanks for confirming 07:59 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 256 seconds] 07:59 -!- SFaulken24 [~SFaulken@182-155-156-147.veetime.com] has joined #bitcoin-core-dev 08:00 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 08:02 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.4] 08:04 -!- SFaulken24 [~SFaulken@182-155-156-147.veetime.com] has quit [Ping timeout: 255 seconds] 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:17 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 08:17 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 08:19 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev 08:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 08:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds] 08:39 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 08:41 -!- harding [~quassel@li1258-130.members.linode.com] has quit [Ping timeout: 245 seconds] 08:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 08:43 -!- harding [~quassel@li1258-130.members.linode.com] has joined #bitcoin-core-dev 08:43 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 08:43 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host] 08:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 08:49 -!- paranoid20 [~paranoid@112-104-36-214.adsl.dynamic.seed.net.tw] has joined #bitcoin-core-dev 08:50 -!- paranoid20 [~paranoid@112-104-36-214.adsl.dynamic.seed.net.tw] has quit [Remote host closed the connection] 08:52 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 08:53 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev 08:54 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection] 08:54 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4] 08:54 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev 09:00 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:01 -!- sXpher29 [~sXpher@p5B355AE2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:01 -!- sXpher29 [~sXpher@p5B355AE2.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 09:06 -!- gab3781a [ac3a48d3@gateway/web/freenode/ip.172.58.72.211] has joined #bitcoin-core-dev 09:06 -!- gab3781a [ac3a48d3@gateway/web/freenode/ip.172.58.72.211] has quit [Client Quit] 09:27 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 09:27 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:31 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 09:42 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:44 -!- lorko123 [4c635ff2@gateway/web/freenode/ip.76.99.95.242] has joined #bitcoin-core-dev 09:44 < lorko123> anyone know how to mine bitcoin directly with bitcoin core 09:45 < lorko123> can i point my asics at my core address to mine for me 09:46 -!- Dizzle [~dizzle@unaffiliated/dizzle] has joined #bitcoin-core-dev 09:46 < Dizzle> lorko123: let's take this to #bitcoin 09:52 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 09:56 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 09:59 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 10:01 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 10:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/57acfcb9fd05...45f434f44d0b 10:15 < bitcoin-git> bitcoin/master 80f52a2 Russell Yanofsky: Remove uses of CheckFinalTx in wallet code 10:15 < bitcoin-git> bitcoin/master bdc6628 Russell Yanofsky: Remove use of IsRBFOptIn in wallet code 10:15 < bitcoin-git> bitcoin/master 291276f Russell Yanofsky: Remove use of GetCountWithDescendants in wallet code 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15288: Remove wallet -> node global function calls (master...pr/wchain3) https://github.com/bitcoin/bitcoin/pull/15288 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:18 < dongcarl> wumpus: Wondering what should be done about https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes/release-notes-pr12255.md ? It seems that at least it should go in the release notes for 0.18, and perhaps removed from the tree? 10:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 10:21 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:22 < MarcoFalke> wumpus: Are you going to create the "release schedule for 0.19.0"-issue? :) 10:24 < wumpus> MarcoFalke: yes, though I think doing so now is overly optimistic :) let's wait for 0.18 to be -final before scheduling it 10:25 < MarcoFalke> Ah, makes sense 10:25 < wumpus> dongcarl: huh did I forget one? 10:25 < wumpus> dongcarl: I don't see it 10:26 < wumpus> oh, they placed it into the historical release notes directory? what??? 10:26 < MarcoFalke> whoopsie 10:26 < MarcoFalke> wrong dir 10:26 < dongcarl> lol 10:26 < MarcoFalke> dongcarl: blame youself 10:27 < MarcoFalke> . s/youself/yourself/ 10:27 < wumpus> anyhow: release notes are on the wiki now, please edit them there 10:27 * dongcarl git blame self 10:27 < dongcarl> Okay, so I'll add it, and PR to remove the file? 10:27 < wumpus> yes, thank you 10:28 < dongcarl> gotcha 10:28 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 10:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 10:33 < sipa> wumpus: doc/psbt.md is not new in 0.18 (and it's been hardly touched for 0.18 so far, though i think we need to add deriveaddresses/importmulti/getdescriptorinfo to it before release 10:33 < sipa> eh 10:33 < sipa> i'm confusing psbt with descriptors 10:33 < sipa> we need to add analysepsbt/mergepsbts/utxoupdatepsbt 10:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds] 10:39 < wumpus> sometimes, things that have been backported to minor releases stick around in the release notes for the major one, but I don't think that's the case here 10:40 < sipa> wumpus: just pointing out that the release notes wiki now says that doc/psbt.md is new while it's been there since 0.17; i'll improve the text 10:40 < wumpus> sipa: yes that seems wrong, thanks 10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45f434f44d0b...14023c966c51 10:41 < bitcoin-git> bitcoin/master fa45123 MarcoFalke: test: Add .style.yapf 10:41 < bitcoin-git> bitcoin/master 14023c9 MarcoFalke: Merge #15479: test: Add .style.yapf 10:41 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:44 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 10:51 < sipa> wumpus: added some todos to the wiki; i'll address them myself when i find the time, if someone doesn't beat me 11:01 < dongcarl> Anyone know how to push to the wiki? I've got `git@github.com:bitcoin-core/bitcoin-devwiki.wiki.git` as my remote and git tells me permission denied 11:02 < harding> sipa: the PSBT doc was backported to the 0.17 branch but was not released in 0.17.1 (and there's no 0.17.2 yet). See MarcoFalke and my discussion about it here: https://github.com/bitcoin/bitcoin/pull/15314#issuecomment-459740847 11:05 < sipa> harding: what? how did we miss that 11:05 < sipa> i remember writing that doc for 0.17 11:05 < sipa> in any case, looks like you're right 11:07 < sipa> oh, that writeup was in the release notes of 0.17, and was only turned into a separate doc afterwards 11:07 < sipa> thanks for getting my memory straight 11:09 < harding> sipa: np. You did catch a problem in my first release note edits where I didn't catch some backports, which probably helped confuse you. That was corrected, and I've tried to be more careful since. 11:09 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:09 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15527: doc: Remove pr release notes file in wrong dir (master...1903-docRelPr) https://github.com/bitcoin/bitcoin/pull/15527 11:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:10 < harding> dongcarl: can you edit in the web interface? 11:10 < dongcarl> harding: it allows me to open web interface editor, haven't tried submitting change tho. 11:10 < dongcarl> But I'd obviously like to edit in my comfy editor 11:11 -!- lorko123 [4c635ff2@gateway/web/freenode/ip.76.99.95.242] has quit [Quit: Page closed] 11:11 < harding> dongcarl: maybe try a one-character edit in the web interface to see if it throws some useful error (and then undo your edit). 11:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds] 11:14 < dongcarl> That worked... 11:14 < dongcarl> Weird 11:14 < dongcarl> Anyways, I'll just do it on the web then... 11:17 < MarcoFalke> dongcarl: Sorry, I already submitted that hunk 11:17 < MarcoFalke> see link in #15527 11:18 < gribble> https://github.com/bitcoin/bitcoin/issues/15527 | doc: Remove pr release notes file in wrong dir by MarcoFalke · Pull Request #15527 · bitcoin/bitcoin · GitHub 11:26 < harding> dongcarl: I just tried and it lets me edit via the web interface but git push for the exact same change gives me: remote: Permission to bitcoin-core/bitcoin-devwiki.wiki.git denied to harding. 11:27 < dongcarl> Hmm... I'm a little confused why we're using the wiki page of an empty repository instead of just a repository... 11:27 < dongcarl> harding: seems like a bug to me 11:27 < wumpus> because it works... 11:28 < wumpus> people can edit it and that seems to work pretty well, no PR overhead 11:29 < dongcarl> Ah I see, PR overhead 11:29 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: BRB] 11:29 -!- Dizzle [~dizzle@unaffiliated/dizzle] has quit [Quit: Leaving...] 11:29 < wumpus> the wiki UI is also slightly more user friendly than editing files in a repository, of course, that doesn't matter if you only want to check it out locally 11:32 < wumpus> it's an empty repository because that's the only way github will let you set different permissions... 11:33 < jonasschnelli> gmaxwell: remember when we talked about the 3 rounds of chacha20 required for encrypted messages with less then 64 bytes? 11:33 < jonasschnelli> you mentioned that reducing it to two may be possible since the first round derives the Poly1305 key and wastes 32bytes of that round 11:34 < jonasschnelli> But the ChaCha20Poly1305@openssh construct uses two independent keyed cipher instances (main and header) 11:35 < jonasschnelli> The header-instance encrypts only the packet length.. 11:35 < jonasschnelli> I think by reducing it two minimum two rounds of ChaCha20 (one for the poly1305 key, one for the actual message), we break the following property: 11:35 < jonasschnelli> "By using an independently-keyed cipher instance to encrypt the length, an active attacker seeking to exploit the packet input handling as a decryption oracle can learn nothing about the payload contents or its MAC" 11:43 < gmaxwell> we talked about this in here before. 11:44 < gmaxwell> the mac setup run has extra data in the output, so there is no length overlapping. 11:44 < sipa> i don't follow; where do the 3 rounds come from? 11:45 < sipa> oh, one for length, one for data, one for mac 11:45 -!- jcorgan_ [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev 11:45 < gmaxwell> and the mac run has 32 extra bytes that are just thrown away. 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:46 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:47 < gmaxwell> there was also a mailing list discussion about this, and the way it was done this way IIRC from it was because openssl didn't provide access to the extra bytes. 11:47 < gmaxwell> e.g. pure compatibility hack. 11:47 < gmaxwell> no cryptographic justification for that redundancy. 11:48 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Ping timeout: 250 seconds] 11:50 < jonasschnelli> gmaxwell: but what about the two independently-keyed cipher instance? 11:51 < jonasschnelli> We could drop that and just use a single key with a single ChaCha2 cipher instance and reduce it two minimum two rounds 11:52 < jonasschnelli> But I'm unsure if this brings disadvantages when the AAD (the length) is encrypted with the same key than the actual payload 11:53 < jonasschnelli> The current BIP151 way is ECDH_SECRET->HKDF->k1 for AAD encryption, ECDH->HKDF->k2 for the payload encryption 11:54 < sipa> i think the idea is that there are two independently-keyed chacha20 instances; one for the AAD, and one for the payload, but that the first 32 bytes of the payload one are used for the poly1305 key, instead of using the first 64 bytes (and throwing away the last 32) 11:55 < jonasschnelli> I see... 11:56 < jonasschnelli> openssh ChaChaPoly does: instanceA -> poly1305 key, instanceB -> AAD encryption, instanceA -> payload encryption 11:56 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...] 11:57 < jonasschnelli> we could do: instanceB->poly1305 key & AAD encryption, instanceA->payload encryption 11:57 < sipa> which means you need one invocation of the AAD instance every 16 messages or so (as you only need 4 bytes from the AAD cipher output for each), and one invocation of the payload instance for every 64 bytes of data (offset by 32 bytes) 11:57 -!- mn949588 [~nodebot@67.243.201.127] has quit [Ping timeout: 255 seconds] 11:59 < jonasschnelli> sipa: we do derive a poly1305 key per message though 11:59 < sipa> that seems wasteful 11:59 < jonasschnelli> well,.. I feel unconfirtable altering the AEAD construct further more 12:00 < sipa> how fast is out chacha20 code? 12:00 < sipa> *our 12:01 < jonasschnelli> Not very optimized,.. I have benchs for the AEAD but not for ChaCha alone 12:01 < jonasschnelli> # Benchmark, evals, iterations, total, min, max, median 12:01 < jonasschnelli> CHACHA20POLY1305AEAD_BIG, 5, 340, 3.68279, 0.00215035, 0.00219169, 0.00216025 12:01 < jonasschnelli> CHACHA20POLY1305AEAD_SMALL, 5, 250000, 1.08673, 8.51516e-07, 8.93585e-07, 8.61119e-07 12:01 < jonasschnelli> HASH256_BIG, 5, 340, 3.81384, 0.00222589, 0.00226436, 0.00224086 12:01 < jonasschnelli> HASH256_SMALL, 5, 250000, 1.1305, 8.96669e-07, 9.15482e-07, 9.03866e-07 12:02 < sipa> what are big and small? 12:02 < jonasschnelli> 1MB / 256bytes 12:02 < jonasschnelli> I should have done <64 though for small 12:03 < sipa> so this means 500 MB/s, or over 1M 256-byte messages per second 12:03 < jonasschnelli> And thats for the 3-rounds @openssh version with no asm optimisation 12:04 < jonasschnelli> I think aprox. the same performance as the current 4byte sha256 checksum 12:04 < sipa> how much of this is due to the poly1305? 12:04 < jonasschnelli> I just asked that myself... 12:04 < sipa> can you run the benchmark with the poly1305 code commented out or so 12:04 < jonasschnelli> I can add a bench for that though 12:05 < jonasschnelli> I'll do that.. but need to fix the current working-tree first 12:05 < jonasschnelli> sipa: but we would drift away from a poly key per message, wouldn't that mean a single message can't be authenticated by itself? 12:06 < sipa> jonasschnelli: no 12:06 < sipa> you just cache the output of the aad cipher 12:07 < sipa> oh, i'm confusing myself 12:07 < jonasschnelli> doesn't that result in eventually waiting for additional messages in order to check the MAC? 12:07 < sipa> no 12:07 < sipa> you can compute the chacha20 cipher output as far ahead as you want, there is never a need to wait for anything 12:08 -!- kanzure [~kanzure@unaffiliated/kanzure] has quit [Ping timeout: 246 seconds] 12:08 < sipa> poly1305 needs a 32 byte key; right now you generate a per-message (64 + N) byte output, and use the first 32 bytes as poly1305 key, throw away 32 bytes, and use the rest for the payload 12:09 < sipa> the idea is that you just don't throw away those 32 bytes 12:09 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:09 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 12:09 < jonasschnelli> Yes. I see that... but I don't see how more then the 3 bytes for the AAD (the packet length) could be used 12:09 < sipa> likewise, you're now generating 64 bytes from the AAD cipher for encrypting the length, but only using the first 4; the idea is to just not throw away the rest 12:10 < sipa> or the first 3 12:10 < sipa> jonasschnelli: there's nothing special about the message counter 12:10 < sipa> chacha20 is just a giant stream of bytes 12:11 < sipa> where we use output of position (2^64*message + bytepos) 12:11 < jonasschnelli> aha.. I think I know what you mean now 12:11 < sipa> now, depending on the speed of things... this may all be overkill 12:11 < sipa> so i'd like to know how fast poly1305 is 12:12 < jonasschnelli> So 64 bytes from the ChaCha round that does the Poly-key/AAD output, use 32for the poly-key, 3 for the length, remains 30.... so we need to kick a round for the next poly key,... 12:12 < sipa> if most of our time is spent in poly1305, then squeezing out extra chacha20 performance isn't really going to matter much 12:12 < jonasschnelli> maybe it's on over-optimization 12:12 < sipa> no no no 12:12 * jonasschnelli listening 12:12 < sipa> don't mix the aad and the payload 12:13 < jonasschnelli> I don't 12:13 < jonasschnelli> I just have problems processing your: 12:13 < jonasschnelli> which means you need one invocation of the AAD instance every 16 messages or so (as you only need 4 bytes from the AAD cipher output for each), and one invocation of the payload instance for every 64 bytes of data (offset by 32 bytes) 12:13 < sipa> generate 64 bytes from the AAD cipher every 21 messages, and cache them. this output will be used to encrypt the lengths of the coming 21 messages 12:14 < sipa> that's all you ever do with the AAD cipher 12:14 < jonasschnelli> ah.. shit. right 12:14 < jonasschnelli> I confused myself by deriving the polykey from the AAD instance 12:14 < jonasschnelli> yes, yes. I see 12:14 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 12:14 < sipa> then you generate 32+N bytes from the payload cipher for every message (with incrementing message counter), the first 32 of which you use for the poly1305 cipher, the rest for the payload 12:14 < jonasschnelli> so the special length encryption property could come at very limited processing time 12:15 < sipa> yes 12:15 < jonasschnelli> this means we always do two rounds for an message >32 bytes... but the AAD chacha round runds only every 16 message 12:16 < jonasschnelli> or 21 with 3 bytes length 12:17 < sipa> yes 12:17 < jonasschnelli> Cool... let me bench and specify this 12:18 < jonasschnelli> Also wonder how much it would be possible to gain by using the optimized code from Zinc (Wireguard) which seems to evetually get merged to the linux kernel 12:18 < jonasschnelli> https://git.zx2c4.com/WireGuard/tree/src/crypto/zinc/chacha20 12:19 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 12:22 < gmaxwell> re benchmarking, benchmark target should be arm. if what we cared about was x86_64 we should be using AES-GCM. :) 12:23 < gmaxwell> which is basically better in every dimension except being really slow on arm without hardware AES. 12:23 < gmaxwell> (simpler to integrate, much more widely used, much lower power consuming (on x86_64), slightly faster) 12:24 < jonasschnelli> gmaxwell: can't we expect ARM to support AES NI,.. I guess ARMv8-A has AES native instructions? 12:25 < gmaxwell> someday. maybe. they made it optional, again. IIRC 12:26 < gmaxwell> (of course, its optional on x86_64 too, but every modern chip provides it... arm has a long long history of optional features that are not proided. :() 12:27 < sipa> x86 in practice only has two manufacturers :) 12:28 < gmaxwell> (to be clear, that chacha20/poly and AES are generally close in performance on x86_64 ... so its not awful to not use AES. and AES-GCM is pretty bad compared to chacha20 on devices without hardware AES&CLMUL) 12:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:28 < bitcoin-git> [bitcoin] sipsorcery opened pull request #15529: WIP: Add Qt programs to msvc build (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529 12:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:29 < gmaxwell> So I certantly still support using the chacha20, but just saying, that the performance driver here should be lower end node hardware, not desktops that decrypt at gigabits/s. :P ) 12:29 < sipa> fair point 12:31 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.4] 12:37 < gmaxwell> Also, since most of our messages are small.. it seems likely that optimizing this will be a fairly large percentage speedup. 12:37 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 12:37 < gmaxwell> (might be useful to get a histogram of a ordinary nodes send and recieved message sizes) 12:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:49 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 12:56 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530 13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:19 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds] 13:22 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:23 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:31 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15531: Suggested interfaces::Chain cleanups from #15288 (master...pr/wclean2) https://github.com/bitcoin/bitcoin/pull/15531 13:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:36 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 13:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kjhlhgjsqypzidhf] has quit [Quit: Connection closed for inactivity] 13:42 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds] 13:49 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 13:50 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 13:50 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532 13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:51 -!- MarcoFalke_ [~none@198.12.116.246] has joined #bitcoin-core-dev 13:52 -!- Eliel [~jojkaart@163.172.153.251] has joined #bitcoin-core-dev 13:53 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 272 seconds] 13:53 -!- MarcoFalke_ is now known as MarcoFalke 13:53 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has quit [Ping timeout: 272 seconds] 13:58 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has joined #bitcoin-core-dev 14:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds] 14:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 14:09 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 14:11 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 14:11 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 14:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:32 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:42 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:48 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 15:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds] 15:11 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds] 15:13 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 15:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 15:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 15:26 -!- Cory [Cory@unaffiliated/cory] has quit [Ping timeout: 250 seconds] 15:28 < gmaxwell> Does anyone in here have a host with clang8? looks like fedora29 is using clang7. ISTM its assembly is broken: https://github.com/bitcoin-core/secp256k1/issues/594 15:31 -!- Pasha [Cory@unaffiliated/cory] has joined #bitcoin-core-dev 15:33 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Ping timeout: 258 seconds] 15:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:34 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15533: test: .style.yapf: Set column_limit=160 (master...1903-testNoPep8Collim) https://github.com/bitcoin/bitcoin/pull/15533 15:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:35 -!- Pasha is now known as Cory 15:38 -!- TX1683 [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev 15:45 -!- Zanthir [~Mutter@107.242.120.91] has joined #bitcoin-core-dev 15:49 -!- Zanthir [~Mutter@107.242.120.91] has quit [Remote host closed the connection] 16:06 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection] 16:07 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev 16:10 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Ping timeout: 252 seconds] 16:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 16:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:12 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev 16:24 < fanquake> Need someone to tiebreak the non-determinism in the aarch64 and riscv64 rc1 gitian builds 16:26 -!- makey40 [~jodie@24.215.123.241] has joined #bitcoin-core-dev 16:29 < achow101> oh noes non-determinism :( 16:31 < gmaxwell> fanquake: have you looked to see what is different in the build products? 16:31 * sipa feels like tiebreaking will not help nondeterminism 16:32 < fanquake> gmaxwell not yet, just going to wait for my own builds to finish 16:36 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 16:38 -!- cluelessperson_ [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev 16:39 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 245 seconds] 16:39 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 258 seconds] 16:56 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:59 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:03 < achow101> my gitian build results are available at https://github.com/achow101/bitcoin/releases/tag/v0.18.0rc1 if you need them 17:08 < fanquake> achow101 Looks like my builds match with yours 17:09 < fanquake> Maybe it's a reoccurrence of something like https://github.com/fanquake/core-review/blob/master/determinism.md#ld64-threading heh 17:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 17:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:14 < bitcoin-git> [bitcoin] gwillen opened pull request #15534: In lint-format-strings, open files sequentially (fix for OS X failure) (master...feature-fix-lint-osx) https://github.com/bitcoin/bitcoin/pull/15534 17:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:14 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:33 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:35 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:46 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection] 17:47 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev 17:52 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 255 seconds] 18:19 -!- zhangzf [~zhangzf@106.38.157.147] has joined #bitcoin-core-dev 18:20 < zhangzf> hello, Who have testnet bitcoin? Can you give me some, I want to test code. My address is mgSRBDvv9h2bRgZHGWLo4xQU9PLvssK6Yi 18:28 < aj> zhangzf: google "testnet faucet" 18:31 < zhangzf> aj: Thank you, I will try it. 18:33 < zhangzf> aj: "bitcoinfaucet.uo1.net is currently unable to handle this request" 18:33 < zhangzf> aj: The web page is right? 18:40 < achow101> zhangzf: there's lots of different testnet faucets. if one is down, try another 18:43 < zhangzf> achow101: Ok. I see I have recevied 3 BTC. I guess someone sended to me. 18:47 <@gwillen> sipa: do you have thoughts on how to handle the dependency issue I have run into 18:47 <@gwillen> I am trying moving tx_verify into common 18:48 <@gwillen> but it's going to be awhile before I find out whether it worked, because building in a linux VM is very slow 18:48 <@gwillen> I don't really understand why it doesn't break under clang/OS X 18:52 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 255 seconds] 18:52 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 18:55 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 255 seconds] 18:57 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 18:57 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 250 seconds] 18:59 < sipa> gwillen: i think osx linker probably discards unused function symbols 18:59 < sipa> so if you're not using any of the functions that have unresolved dependencies, it doesn't error 19:00 < sipa> which is pretty fragile, but shows that there must exist a solution :) 19:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:27 <@gwillen> ohhhh, heh, that makes sense 19:30 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:44 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 255 seconds] 19:45 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 20:00 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 20:09 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection] 20:09 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 20:14 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 20:17 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 258 seconds] 20:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 20:26 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 20:26 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 20:30 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds] 20:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 20:41 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 20:45 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 21:03 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 21:05 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 21:08 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 21:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:25 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 21:29 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 21:59 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 22:03 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds] 22:23 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 22:42 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 22:46 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 22:53 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 22:57 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Quit: Leaving] 22:58 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 240 seconds] 23:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:19 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 23:19 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host] 23:19 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 23:20 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds] 23:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 23:23 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 23:27 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds] 23:45 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 23:50 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] --- Log closed Tue Mar 05 00:00:07 2019