--- Log opened Wed Mar 27 00:00:27 2019
00:26 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
00:48 -!- Krellan [~Krellan@2601:640:4000:a876:f9ff:76cc:8fb3:d1ee] has joined #bitcoin-core-dev
01:04 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
01:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
01:05 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
01:09 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds]
01:10 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
01:34 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
01:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:50 < jonasschnelli> Whats up with travis?
01:50 < jonasschnelli> "Travis early exit to cache current state"
01:54 < luke-jr> I think we're supposed to just restart it when that happens
01:58 < aj> jonasschnelli: "downloading/compiling took too long for tests to succeed, but if we timeout it won't cache and retry will fail in the same way, but if we fail deliberately it'll cache and next time might work" aiui
01:59 < jonasschnelli> hmm...
01:59 < jonasschnelli> So should I just restart the job until it succeeds within time?
01:59 < jonasschnelli> what luke-jr said
01:59 < aj> or fails for a real reason, yeah, i think so
01:59 < jonasschnelli> grml
02:00 -!- jonatack [~Mutter@2a01:e35:8aba:8220:dcdb:ab92:9311:e420] has joined #bitcoin-core-dev
02:03 -!- jonatack [~Mutter@2a01:e35:8aba:8220:dcdb:ab92:9311:e420] has quit [Client Quit]
02:03 -!- jonatack [~Mutter@2a01:e35:8aba:8220:dcdb:ab92:9311:e420] has joined #bitcoin-core-dev
02:05 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has joined #bitcoin-core-dev
02:06 -!- jonatack [~Mutter@2a01:e35:8aba:8220:dcdb:ab92:9311:e420] has quit [Client Quit]
02:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
02:32 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:50 -!- Victor_sueca is now known as Victorsueca
02:56 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
02:56 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:56 -!- mn94958854 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:57 -!- mn94958850 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds]
03:02 -!- Krellan [~Krellan@2601:640:4000:a876:f9ff:76cc:8fb3:d1ee] has quit [Quit: Leaving...]
03:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:11 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Ping timeout: 258 seconds]
03:12 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
03:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
03:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
03:23 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
03:38 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:48 -!- zhangzf [~zhangzf@106.38.157.147] has quit [Remote host closed the connection]
03:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:53 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e14cd04abbb5...208406038c12
03:53 < bitcoin-git> bitcoin/master 03be7f4 Jonas Schnelli: Add Poly1305 implementation
03:53 < bitcoin-git> bitcoin/master b34bf30 Jonas Schnelli: Add Poly1305 bench
03:53 < bitcoin-git> bitcoin/master e9d5e97 Jonas Schnelli: Poly1305: tolerate the intentional unsigned wraparound in poly1305.cpp
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:54 < bitcoin-git> [bitcoin] laanwj merged pull request #15519: Add Poly1305 implementation (master...2019/03/poly1305) https://github.com/bitcoin/bitcoin/pull/15519
03:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:55 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/208406038c12...848ec5603f72
03:55 < bitcoin-git> bitcoin/master fa1c073 MarcoFalke: contrib: gh-merge: Include review comments in merge commit
03:55 < bitcoin-git> bitcoin/master 848ec56 Wladimir J. van der Laan: Merge #15643: contrib: gh-merge: Include ACKs in merge commit
03:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:56 < bitcoin-git> [bitcoin] laanwj merged pull request #15643: contrib: gh-merge: Include ACKs in merge commit (master...1903-ghMergeAck) https://github.com/bitcoin/bitcoin/pull/15643
03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:03 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has joined #bitcoin-core-dev
04:16 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has quit [Quit: WeeChat 2.4]
04:28 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds]
04:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:54 -!- zhangzf [~zhangzf@120.244.112.8] has joined #bitcoin-core-dev
04:57 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
05:02 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has joined #bitcoin-core-dev
05:14 -!- zhangzf_ [~zhangzf@223.72.55.93] has joined #bitcoin-core-dev
05:15 < wumpus> luke-jr: that's ... terrible "this automation takes too long so we've implemented manual button-clicking labor for the users !"
05:16 -!- zhangzf [~zhangzf@120.244.112.8] has quit [Ping timeout: 245 seconds]
05:16 < wumpus> I guess the build/testing times are really getting out of hand
05:32 -!- jhfrontz [~Adium@ip-173-152-146-53.ekrgmd.spcsdns.net] has joined #bitcoin-core-dev
05:44 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 250 seconds]
06:02 < Sentineo> will there be an rc3? Where can I track it? I mean I want to help with gitian build when needed, just do not have time to read everything on irc, so I do not want to miss when a build is needed.
06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/848ec5603f72...656a15e5394d
06:03 < bitcoin-git> bitcoin/master fa965e0 MarcoFalke: rpc: Use IsValidNumArgs over hardcoded size checks
06:03 < bitcoin-git> bitcoin/master fa96d76 MarcoFalke: rpc: Uncouple rpcs from maxTxFee global
06:03 < bitcoin-git> bitcoin/master fa1ad20 MarcoFalke: doc: Add release notes for 15620
06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15620: rpc: Uncouple non-wallet rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:18 -!- jonatack_ [~Mutter@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
06:20 -!- jonatack_ [~Mutter@54.76.13.109.rev.sfr.net] has quit [Client Quit]
06:23 -!- jonatack_ [~Mutter@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
06:26 -!- jonatack_ [~Mutter@54.76.13.109.rev.sfr.net] has quit [Client Quit]
06:29 -!- jhfrontz [~Adium@ip-173-152-146-53.ekrgmd.spcsdns.net] has quit [Quit: Leaving.]
06:29 -!- jhfrontz [~Adium@ip-173-152-146-53.ekrgmd.spcsdns.net] has joined #bitcoin-core-dev
06:34 -!- jhfrontz [~Adium@ip-173-152-146-53.ekrgmd.spcsdns.net] has quit [Ping timeout: 250 seconds]
06:43 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
06:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
06:57 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has quit [Ping timeout: 256 seconds]
06:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds]
07:01 -!- harrymm [~harrymm@104.128.136.116] has joined #bitcoin-core-dev
07:09 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
07:10 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
07:14 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 250 seconds]
07:18 < jamesob> at what point does a move-only commit stop being move-only? i.e. if I move the declaration of a class from foo.cpp -> foo.h, but then have to add a single line in order to fix a resulting linker error, is the commit still move-only?
07:22 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has joined #bitcoin-core-dev
07:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
07:36 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
07:38 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev
07:41 -!- jhfrontz [~Adium@38.140.34.34] has joined #bitcoin-core-dev
07:45 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds]
07:51 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4]
07:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:54 < bitcoin-git> [bitcoin] HashUnlimited opened pull request #15676: [doc] [trivial] fix grammar (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15676
07:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:55 -!- jhfrontz [~Adium@38.140.34.34] has quit [Quit: Leaving.]
08:00 -!- jhfrontz [~Adium@38.140.34.34] has joined #bitcoin-core-dev
08:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
08:09 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
08:09 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:26 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
08:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:46 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15676: [doc] [trivial] fix grammar (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15676
08:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:57 < promag> ryanofsky: why UpdatedBlockTip isn't in interfaces::Chain::Notifications?
08:58 < ryanofsky> i don't know any reason, probably should add it if useful
08:59 < promag> regarding #15632
08:59 < gribble> https://github.com/bitcoin/bitcoin/issues/15632 | Remove ResendWalletTransactions from the Validation Interface by jnewbery · Pull Request #15632 · bitcoin/bitcoin · GitHub
08:59 < promag> instead of period checking, could use that signal?
09:00 < ryanofsky> sure
09:00 < promag> not sure if jnewbery wants to do that there, or in another
09:01 -!- hhi [c8cf9552@gateway/web/freenode/ip.200.207.149.82] has joined #bitcoin-core-dev
09:02 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Ping timeout: 250 seconds]
09:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:10 -!- kmls [~carlos@2803:7000:6000:1cd6:1cac:2754:b362:eb8a] has quit [Ping timeout: 264 seconds]
09:11 -!- hhi [c8cf9552@gateway/web/freenode/ip.200.207.149.82] has quit [Quit: Page closed]
09:17 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]
09:23 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:31 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Remote host closed the connection]
09:43 -!- zhangzf_ [~zhangzf@223.72.55.93] has quit [Remote host closed the connection]
09:46 -!- obsrver [~quassel@p5DE862FC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:48 -!- obsrver [~quassel@p5DE862FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
09:48 -!- obsrver [~quassel@p5DE862FC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:58 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev
10:14 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
10:15 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
10:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
10:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:26 < jnewbery> promag: I just responded to your question about using UpdatedBlockTip as a trigger for resending wallet txs. I think it's bad for privacy.
10:41 < gmaxwell> whats going on there? the existing behavior is that the resends are on a random timer that is gated by the tip changing, so you don't get things like handing the node a block and then see it send transactions... but also so it avoids resending when the situation is no different...  we should probably be more intelligent and only resend if the transaction was in the top block worth of our 
10:41 < gmaxwell> mempool before the last block (otherwise, why would we expect it to have been mined)
10:44 < jnewbery> right, that's the existing behaviour, and my PR would keep that behaviour
10:44 < jnewbery> promag suggested a simplification to my pr #15632 which if I'm understanding would change the behaviour to only resend immediately following a tip update
10:45 < gribble> https://github.com/bitcoin/bitcoin/issues/15632 | Remove ResendWalletTransactions from the Validation Interface by jnewbery · Pull Request #15632 · bitcoin/bitcoin · GitHub
10:45 < jnewbery> which I'm saying would make rebroadcasts more obvious
10:46 < gmaxwell> K. agreed, thats the opposite direction we need to go, right now we make many unnecessary rebroadcasts and they're REALLY identifying.
10:47 < jnewbery> I don't understand "only resend if the transaction was in the top block worth of our mempool before the last block (otherwise, why would we expect it to have been mined)"
10:50 < dongcarl> sipa: Looking at your original PR that added support for onion addresses... 70f7f0038592a28e846f02d084f0119fc34eb52f. Any particular reason we used onioncat's range and encoding or was it just a choice?
10:51 < sipa> dongcarl: schelling point; if you'd use something else, what would you pick?
10:52 < gmaxwell> picking something else would risk colliding with some other uses, better to reuse an existing space-squat.
10:53 < gmaxwell> jnewbery: the idea behind the current rebroadcast behavior is that unless the tip has changed we don't have any reason to expect our transaction to have been mined, so the rebroadcast is pointless, since the txn might just be sitting waiting to be mined and all the rebroadcasts in the world won't speed that up.
10:53 < dongcarl> Makes sense. No particular opinion, just wanted to make sure I wasn't missing any context as I'm adding documentation to net
10:53 < gmaxwell> (I mean the idea behind why it watches the tip)
10:54 < gmaxwell> jnewbery: But thats still too rebroadcast heavy. If the tip changed but at our transaction wasn't near the top of our mempool, well it shouldn't have been mined then either.
10:55 < gmaxwell> jnewbery: so right now if you make a txn that won't get mined for 12 blocks, you'll end up potentially rebroadcasting 12 times, even though it was in miners mempools the whole time. I've also seen network spies that appear to be attempting to exploit the rebroadcasting.
10:57 < gmaxwell> So ideally we'd suppress rebroadcasting during periods when the txn is nowhere near the top. Rebroadcasting then is pointless and only serves to deanon us.
10:59 < jnewbery> Makes sense. Thanks
10:59 -!- jhfrontz [~Adium@38.140.34.34] has quit [Quit: Leaving.]
11:14 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
11:14 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
11:29 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/656a15e5394d...3702e1c17b6c
11:34 < bitcoin-git> bitcoin/master 529c1ae John Newbery: [tests] Add test for wallet rebroadcasts
11:34 < bitcoin-git> bitcoin/master 3702e1c MarcoFalke: Merge #15646: [tests] Add test for wallet rebroadcasts
11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15646: [tests] Add test for wallet rebroadcasts (master...2019_03_wallet_rebroadcasat_test) https://github.com/bitcoin/bitcoin/pull/15646
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:51 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
11:53 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
11:54 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
11:54 -!- Isthmus_ [sid302307@gateway/web/irccloud.com/x-xxahormpzuucsbpl] has quit [Quit: Updating details, brb]
11:55 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-mevantlxtgbhlzak] has joined #bitcoin-core-dev
11:59 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
12:05 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:11 < bitcoin-git> [bitcoin] goldenglorys opened pull request #15678: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/15678
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:16 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
12:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:17 < bitcoin-git> [bitcoin] sipa closed pull request #15678: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/15678
12:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:35 -!- jonatack [58aba822@gateway/web/freenode/ip.88.171.168.34] has joined #bitcoin-core-dev
12:37 -!- jonatack [58aba822@gateway/web/freenode/ip.88.171.168.34] has quit [Client Quit]
12:39 -!- obsrver [~quassel@p5DE862FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
13:16 < dongcarl> sipa: We don't exactly care about the socktype and protocol here, correct? As this function seems to not care about the service level and only care about resolving names? https://github.com/bitcoin/bitcoin/blob/3702e1c17b6ccb01de2c0cde66dac26bd05e3183/src/netbase.cpp#L80
13:17 < sipa> dongcarl: i suspect getaddrinfo ignores them
13:17 < dongcarl> sipa: thanks
13:20 < gmaxwell> [largey offtopic] Gemini can send to bc1 addresses now: https://np.reddit.com/r/Bitcoin/comments/b66n0v/psa_gemini_is_full_on_with_native_segwit_and_uses/
13:23 < sipa> gmaxwell: not just send; their new receive addresses are bech32 by default
13:23 < gmaxwell> oh really?  (the image on reddit showed a prev-to as a 3xxx address)
13:24 < sipa> they don't generate a new address by default, but the first time you click on generate new address, it'll be a bc1 one
13:25 < gmaxwell> cool
13:26 < sipa> (verified it myself, btw)
13:28 < gmaxwell> sipa: re: https://twitter.com/Dranithix/status/1110512014000939008 you might want to point to bip152.
13:54 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
13:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:21 -!- afk11- [~afk11@79.97.107.223] has joined #bitcoin-core-dev
14:23 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Ping timeout: 250 seconds]
14:23 -!- afk11- [~afk11@79.97.107.223] has quit [Client Quit]
14:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:28 < bitcoin-git> [bitcoin] jnewbery opened pull request #15680: Remove resendwallettransactions RPC method (master...2019_03_remove_resendwallettransactions) https://github.com/bitcoin/bitcoin/pull/15680
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:41 -!- Aaronvan_ is now known as AaronvanW
14:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
14:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
14:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:04 -!- aitorjs [~aitorjs@14.85-86-116.dynamic.clientes.euskaltel.es] has joined #bitcoin-core-dev
15:09 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
15:09 -!- aitorjs [~aitorjs@14.85-86-116.dynamic.clientes.euskaltel.es] has quit [Ping timeout: 250 seconds]
15:10 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
15:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
15:18 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
15:47 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
15:55 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
16:00 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
16:04 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
16:05 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has joined #bitcoin-core-dev
16:09 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
16:10 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
16:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
16:23 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
16:28 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Read error: Connection reset by peer]
16:28 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
16:40 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
16:46 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
16:48 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
16:48 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:49 -!- farmerwampum_ [~wampum@162.219.179.34] has quit [Remote host closed the connection]
16:49 -!- farmerwampum_ [~wampum@162.219.179.34] has joined #bitcoin-core-dev
16:50 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
16:51 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
17:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
17:16 -!- gs [4924f0fd@gateway/web/freenode/ip.73.36.240.253] has joined #bitcoin-core-dev
17:16 -!- gs [4924f0fd@gateway/web/freenode/ip.73.36.240.253] has quit [Client Quit]
17:27 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
17:27 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
17:29 -!- ctrlbreak_MAD is now known as ctrlbreak
17:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:01 < promag> could #15652 be in high priority?
18:01 < gribble> https://github.com/bitcoin/bitcoin/issues/15652 | wallet: Update transactions with current mempool after load by promag · Pull Request #15652 · bitcoin/bitcoin · GitHub
18:07 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
18:10 < gmaxwell> +1 at a minimum we must ship with a loud warning in the release notes if that isn't fixed.
18:10 < gmaxwell> as incorrect balances can cause funds loss.
18:11 < sipa> it's marked as milestone 0.17.2; i assume that implies also 0.18
18:14 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds]
18:16 -!- justan0theruser is now known as justanotheruser
18:16 -!- zhangzf [~zhangzf@106.38.157.147] has joined #bitcoin-core-dev
18:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
18:41 -!- aitorjs [~aitorjs@166.179.16.95.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds]
18:43 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
18:44 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
18:48 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 246 seconds]
18:56 -!- farmerwampum__ [~wampum@162.219.179.34] has joined #bitcoin-core-dev
18:59 -!- farmerwampum_ [~wampum@162.219.179.34] has quit [Ping timeout: 272 seconds]
19:14 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
19:16 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 250 seconds]
19:19 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
19:22 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
19:26 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
19:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]
19:59 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
19:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 255 seconds]
20:03 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
20:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:28 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #15681: [mempool] Allow one extra single-ancestor transaction per package (master...2019-03-lightning-policy) https://github.com/bitcoin/bitcoin/pull/15681
20:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:41 < cfields> wumpus: fyi, I'm deep in a quagmire of windows codesigning
20:41 < cfields> I'm not sure I'll make it in time for rc3
20:42 < cfields> We now have a valid cert, but it accidentaly went through a reseller, and I'm afraid that messed up the cert chain.
20:42 < cfields> Either that, or my win7 vm doesn't reflect the current reality of trusted root CA's.
20:42 < cfields> So I'm going to need at least another day to straighten this out :(
20:44 < cfields> If anyone has a working win10 install, it'd be helpful to test a signed helloworld.exe to see if the problem is that win7's cert store is just outdated.
20:45 < wumpus> cfields: uh oh
20:46 < cfields> tl;dr: gwillen and jonasschnelli helped to register for a new windows cert. It signs ok and gitian attaches it ok, but my win7 install doesn't like it.
20:46 < wumpus> and no, I don't have any windows (nor mac) anymore to test, but I'm sure someone here has?
20:48 < cfields> wumpus: if you'd like, I can PR the updated cert chain that _may_ work, and we can get feedback from rc3?
20:48 < wumpus> I think that'd make sense, then we can still do rc3 today
20:48 < cfields> the signer uses the .cert file in git, so it'll need to be updated either way.
20:48 < wumpus> I should at least tag it I guess :-)
20:49 < cfields> ok, will do. I think it's pretty unlikely that it'll work, but worth a shot.
20:49 < cfields> I can PR in just a min.
20:49 < wumpus> I'll then mention in the notification mail that the windows cert might have isues
20:50 < wumpus> and we need to get this sorted out for final
20:50 < kallewoof> My coworker has Win 7. Shoudl he try?
20:50 < kallewoof> Another coworker has Win 10 inside a virtual box, if that helps.
20:50 < gmaxwell> just don't sign for windows at all and see who reports it then we will have identified suckers^wtesters for future versions.
20:50 < achow101> cfields: I've got a win10
20:51 < cfields> gmaxwell: heh.
20:52 < cfields> kallewoof / achow101: a win10 test would be great. I believe the issue is that the trusted CA's were updated to cope with Comodo's recent renaming. But I'm really grasping. This is a black box :(
20:52 < kallewoof> cfields: where can I download the fiel-
20:53 < cfields> kallewoof: Since the tag is incoming, I'll just sign rc3 with the new cert. Could you test that? That avoids having random codesigned binaries hanging around.
20:53 < kallewoof> Oh, okay. Sure thing
20:54 < achow101> ok
20:54 < cfields> achow101: ^^ same to you.
21:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:02 < bitcoin-git> [bitcoin] theuni opened pull request #15682: release: Update the Windows Codesigning certificate (master...new-win-cert) https://github.com/bitcoin/bitcoin/pull/15682
21:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:05 < cfields> wumpus: sorry for leaving that inconclusive for now. I tried a million things tonight. Will have a look tomorrow with a clear head.
21:05 < cfields> kallewoof / achow101: thanks for volunteering to test :)
21:06 < wumpus> cfields: thanks for trying ! let's blame it on Microsoft for making people navigate such a maze for this
21:06 < cfields> I suspect, even if win7 doesn't have the new trusted CA, that there's a way to make a path with intermediaries. But I didn't have any luck.
21:08 < wumpus> this is at most a bypassable warning isn't it?
21:08 < cfields> Yes
21:09 < wumpus> (not that we should really be encouraging people to ignore warnings about unsigned code, but it's fine for a RC)
21:09 < cfields> But I believe that in its current state it may be no better than nothing.
21:09 < achow101> i'm pretty sure it's a scary looking warning in windows 10 though
21:09 < wumpus> yes, agreew with that, just need to know what to write inthe mail 'it probably doesn't work on w7' or 'it gives wa warning during install' so it's the latter
21:10 < cfields> Worst case I think we can buy a new cert. I believe the problem is that it went through a reseller, though I'm not 100%.
21:10 < cfields> The Comodo rename is really messing with my ability to understand wtf is going on :)
21:11 < cfields> Comodo -> Sectigo, apparently
21:11 < wumpus> did they have a breach or something :-)
21:12 < cfields> Heh, I thought Symantec's breach was bad. I assume you're right. Hard to keep up these days, I guess :)
21:13 < gwillen> I'm happy to pay to try again (and ask comodo for a refund or something) if this fails and there's a better party to buy it from that doesn't have the cert chain issue
21:14 < gwillen> (I doubt I'll get a refund but I can yell at them and it will make me feel better)
21:14 < gmaxwell> is this a case where you just have to staple the CA chain to the cert?
21:14 < cfields> gwillen: Not pinning it on you at all, sorry if it sounded that way. It's all very confusing.
21:14 < gwillen> no, not at all and no worried
21:14 < cfields> gmaxwell: Yes, and in the correct order.
21:14 < gwillen> worries*
21:16 < cfields> gmaxwell: it has to be chained together in the proper order, and it has to end in a trusted CA. And it's not clear who those trusted CA's are.
21:21 < wumpus> ahh like with TLS cert chains, that's also painful sometimes
21:24 < cfields> https://i.imgur.com/opaPhgh.png
21:25 < cfields> ^^ The issue
21:25 < cfields> wumpus: heh, yep, same as the unhelpful apache error when you get the cert order backwards.
21:40 < achow101> cfields: the cert you have is signed by the cert at http://crt.sectigo.com/SectigoRSACodeSigningCA.crt which is signed by the cert at http://crt.sectigo.com/SectigoRSACodeSigningCA.crt which in turn is signed by "http://crt.sectigo.com/SectigoRSACodeSigningCA.crt" which is a trusted root that I see in my windows 10
21:40 < achow101> AddTrust External CA Root is the final root (bad copy paste)
21:41 < cfields> achow101: ah, that seems to be missing in win7!
21:41 < cfields> So maybe it'll work for win10. Ugh, that almost seems worse.
21:43 < achow101> http://crt.usertrust.com/USERTrustRSAAddTrustCA.crt is the second intermediate
21:44 < cfields> achow101: the Sectigo CA i don't see in the certificate snap-in via mmc in win7.
21:45 < achow101> I don't see it either. so I think we will need to provide the chain for it
21:45 < achow101> I got the sectigo CA url from openssl decoding of the cert
21:46 < cfields> "http://crt.sectigo.com/SectigoRSACodeSigningCA.crt" which is a trusted root
21:46 < achow101> That was supposed to be AddTrust External CA Root. bad copy paste
21:46 < cfields> Oh, sure, but does Windows trust it?
21:47 < achow101> windows 10 trusts it
21:47 < cfields> achow101: If rc3 isn't tagged by tomorrow, I'll re-sign rc2 with this cert and we can mess around with it.
21:48 < cfields> Thanks for poking at it :)
21:48 < achow101> np
21:58 < achow101> cfields: also, that trusted root expires next May, so maybe it isn't the greatest idea to go with them? especially if we need to provide our own CA chain (dunno if we do)
22:08 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
22:11 < achow101> cfields: have you tried updating your win 7 vm? afaict windows update will update the trusted root certificates so you should have the trusted root there
22:12 < cfields> achow101: it's a 1 year cert.
22:13 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
22:14 < cfields> achow101: deliberately no. Very possible that an update may install new certs, but I'm trying to stay as worst-case-scenario for my VM as possible.
22:15 < cfields> achow101: ah, I misunderstood about the expiration. Interesting. Ours expires first, though :)
22:15 < gwillen> I get testing the worst case scenario but it seems like par for the course that a non-updated install would have certificate problems
22:16 < gwillen> especially given the rerooting of comodo
22:18 < achow101> ah, I hadn't checked the expiry of our cert
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:33 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/7eab2db849d9...f14a0aa99b84
22:33 < bitcoin-git> bitcoin/0.18 09a05e8 Wladimir J. van der Laan: qt: Translations update pre-rc3
22:33 < bitcoin-git> bitcoin/0.18 f14a0aa Wladimir J. van der Laan: build: Bump to rc3
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:33 < wumpus> running bitcoin on an unupdated w7 ouch :)
22:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:38 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3702e1c17b6c...edb8df4fea13
22:38 < bitcoin-git> bitcoin/master 43ae1e9 Cory Fields: release: Update the Windows Codesigning certificate
22:38 < bitcoin-git> bitcoin/master edb8df4 Wladimir J. van der Laan: Merge #15682: release: Update the Windows Codesigning certificate
22:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:39 < bitcoin-git> [bitcoin] laanwj merged pull request #15682: release: Update the Windows Codesigning certificate (master...new-win-cert) https://github.com/bitcoin/bitcoin/pull/15682
22:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:41 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/f14a0aa99b84...dcd96b84cf82
22:41 < bitcoin-git> bitcoin/0.18 dcd96b8 Cory Fields: release: Update the Windows Codesigning certificate
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:42 < wumpus> ok, ready to tag rc3 I think?
22:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:43 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/dcd96b84cf82...7bcf90cb01aa
22:43 < bitcoin-git> bitcoin/0.18 7bcf90c Wladimir J. van der Laan: doc: Update manpages for changes since rc2
22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:09 < bitcoin-git> [bitcoin] murrayn closed pull request #15500: Support for a bitcoind 'ready' file to indicate startup is complete. (master...ready_file) https://github.com/bitcoin/bitcoin/pull/15500
23:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Thu Mar 28 00:00:29 2019