--- Log opened Wed Apr 24 00:00:53 2019 00:07 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 00:14 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 00:20 -!- ccdle12 [~ccdle12@210.160.37.171] has quit [Remote host closed the connection] 00:36 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 00:40 < jonasschnelli> I think wallet notify should finally be replaced with something more flexible... 00:40 < jonasschnelli> #13262 was my attempt 00:40 < gribble> https://github.com/bitcoin/bitcoin/issues/13262 | Wallet/RPC: Add listsincetx method with a stateless (server-side) long polling option by jonasschnelli · Pull Request #13262 · bitcoin/bitcoin · GitHub 00:41 < jonasschnelli> That PR includes a python scripts that demonstrate the push function 00:41 < jonasschnelli> (with pure RPC usage) 00:42 < jonasschnelli> Since its stateless and similar to "listsinceblock",... missing transactions is really hard 01:21 < ElePHPhant> jonasschnelli: Well, I use the notify things purely to know *when* to immediately do the normal polling of data from the API. 01:21 < ElePHPhant> jonasschnelli: It's done regularly anyway. 01:21 < ElePHPhant> jonasschnelli: But those *notify things make it much snappier. 01:22 < ElePHPhant> Must take a walk to avoid going insane. 01:22 < ElePHPhant> Will come back soon. 01:22 -!- ElePHPhant [~ElePHPhan@104.244.159.151] has quit [Quit: ElePHPhant] 01:31 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-acwcuzkbwuvmiyhx] has joined #bitcoin-core-dev 01:38 < provoostenator> ElePHPhant jonasschnelli: related #15382 adds boost process as a dependency, which gives us more flexility on how to execute commands. 01:38 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub 01:39 < provoostenator> The PR lists some alternative dependencies too. Maybe that can solve the Windows thing, but I have no idea. 01:39 < provoostenator> (I solved all my Windows problems 10+ years ago) 01:43 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:44 < sipa> provoostenator: by not using it anymore? 01:44 -!- ElePHPhant [~ElePHPhan@45.32.169.232] has joined #bitcoin-core-dev 01:49 < ElePHPhant> Back. 01:50 < ElePHPhant> jonasschnelli: What happened to your suggestion? 01:50 < ElePHPhant> jonasschnelli: And will my bug be officially filed somehow now that I've reported it? 01:50 < sipa> ElePHPhant: not if you don't file it 01:51 < sipa> https://github.com/bitcoin/bitcoin/issues 01:54 < sipa> seems there is a fix in that stackexchange answer too; seems like a no-brainer to apply it, but it'll need developing on windows to champion it 01:54 < sipa> (even if just to know that it works) 02:00 -!- armin76 [~armin76@89.238.178.75] has quit [] 02:04 -!- fnichol [~fnichol@84.39.117.57] has joined #bitcoin-core-dev 02:15 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 02:17 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:20 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 250 seconds] 02:21 < ElePHPhant> sipa: Any chance you could file the issue for me? So it's done right? 02:38 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 258 seconds] 02:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 02:39 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 250 seconds] 02:39 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:51 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:52 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 02:56 -!- meshcoll- [meshcollid@gateway/shell/elitebnc/x-ibvklufofrwgrkpa] has quit [Quit: ZNC 1.6.5-elitebnc:7 - http://elitebnc.org] 02:56 -!- meshcollider [meshcollid@gateway/shell/elitebnc/x-eljktkufsrujivha] has joined #bitcoin-core-dev 02:59 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:59 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds] 03:05 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...] 03:05 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 03:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 03:28 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:32 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 03:45 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 04:01 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:07 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has joined #bitcoin-core-dev 04:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:53 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Quit: gone] 04:55 -!- needhelpplz [026c85da@gateway/web/freenode/ip.2.108.133.218] has joined #bitcoin-core-dev 04:59 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:00 -!- fnichol [~fnichol@84.39.117.57] has quit [] 05:02 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:03 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:05 -!- MarconM [~MarconM@89.238.178.75] has joined #bitcoin-core-dev 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15868: rpc: Add have_pruned to getblockchaininfo (master...1904-rpcPruned) https://github.com/bitcoin/bitcoin/pull/15868 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:05 < ElePHPhant> Sigh... I guess not... 05:14 < ElePHPhant> I created an issue myself now... 05:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:35 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 05:39 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 05:40 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 05:45 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev 06:01 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has joined #bitcoin-core-dev 06:06 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has quit [Ping timeout: 258 seconds] 06:25 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 06:29 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 06:46 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 06:48 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 06:48 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 06:48 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 06:50 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 06:53 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 06:53 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 06:54 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 07:10 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Remote host closed the connection] 07:17 < waxwing> can i ask what the "traditional partial signatures format" referred to on this line is? https://github.com/bitcoin/bitcoin/blob/master/src/script/sign.h#L131 07:19 -!- promag [~promag@83.223.235.50] has joined #bitcoin-core-dev 07:19 -!- promag_ [~promag@a89-154-165-115.cpe.netcabo.pt] has joined #bitcoin-core-dev 07:22 -!- promag [~promag@83.223.235.50] has quit [Remote host closed the connection] 07:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 07:22 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:22 -!- promag [~promag@83.223.235.50] has joined #bitcoin-core-dev 07:25 -!- bralyclow [~bralyclow@193.36.117.238] has joined #bitcoin-core-dev 07:25 -!- promag [~promag@83.223.235.50] has quit [Remote host closed the connection] 07:26 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 07:27 -!- lukedashjr is now known as luke-jr 07:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:34 -!- promag [~promag@83.223.235.50] has joined #bitcoin-core-dev 07:36 -!- promag [~promag@83.223.235.50] has quit [Remote host closed the connection] 07:37 -!- ElePHPhant [~ElePHPhan@45.32.169.232] has quit [Ping timeout: 255 seconds] 07:40 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 07:40 < cfields> wumpus: fyi, I'll be away and unable to sign releases Friday-Tuesday. Headed to Boston to sign the docs for our new place there :) 07:42 < instagibbs> anyone know why data carrier outputs have to be push-only in relay policy? 07:43 -!- bralyclow [~bralyclow@193.36.117.238] has quit [] 07:43 < instagibbs> seems wasteful for no reason 07:43 < harding> waxwing: I think it's just talking about when you have fewer than the needed number of signatures. E.g., you need 2 signatures but you call signrawtransactionwithprivatekey (or whatever untweetable name it has) with only one key. You'll get your input transaction returned back to you with the push of just that single signature in it and an "incomplete" flag in a separate field. 07:44 < harding> waxwing: I don't think it means partial in the sense of less-than-one signatures. 07:47 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 07:48 < harding> instagibbs: maybe to avoid people putting CHECKSIG-type opcodes in there that would count towards the block's sigop limit even though we know they'd never be evaluated (and that counting sigops in scriptPubKeys is wrong)? 07:49 < instagibbs> harding, ehhh just count those then :) (good point regardless) 07:49 < instagibbs> it would also mess with the "virtual size" right? 07:51 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:53 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds] 07:55 -!- lukedashjr is now known as luke-jr 07:58 < waxwing> harding, makes sense thanks. i always end up looking up the difference between witnessscript and scriptwitness hence i end up there, the question was only tangential :) 07:58 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 07:59 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 08:00 -!- MarconM [~MarconM@89.238.178.75] has quit [] 08:00 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 08:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:03 -!- kees1 [~kees@89.238.178.75] has joined #bitcoin-core-dev 08:04 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 08:06 -!- promag_ [~promag@a89-154-165-115.cpe.netcabo.pt] has quit [Remote host closed the connection] 08:16 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:20 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15858: Faster tests with topological mempool rpc sync 🚀 (master...1904-qaSync) https://github.com/bitcoin/bitcoin/pull/15858 08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 08:26 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:27 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 08:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 255 seconds] 08:38 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 08:48 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:52 -!- jarthur [~jarthur@2605:6000:1019:41ab:3d36:7eb4:f73:d013] has joined #bitcoin-core-dev 08:52 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 08:56 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 08:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:59 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:14 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has quit [Remote host closed the connection] 09:16 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has joined #bitcoin-core-dev 09:21 -!- jarthur [~jarthur@2605:6000:1019:41ab:3d36:7eb4:f73:d013] has quit [Remote host closed the connection] 09:21 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has quit [Ping timeout: 244 seconds] 09:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:27 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 09:28 -!- jarthur [~jarthur@2605:6000:1019:41ab:3d36:7eb4:f73:d013] has joined #bitcoin-core-dev 09:32 -!- jarthur [~jarthur@2605:6000:1019:41ab:3d36:7eb4:f73:d013] has quit [Ping timeout: 276 seconds] 09:35 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 09:44 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:45 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:48 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 09:51 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:52 -!- brianhoffman_ [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:55 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Ping timeout: 268 seconds] 09:55 -!- brianhoffman_ is now known as brianhoffman 09:56 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 09:57 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 09:58 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 10:01 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 10:03 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 10:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 10:11 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:18 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 10:24 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:25 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-acwcuzkbwuvmiyhx] has quit [Quit: Connection closed for inactivity] 10:28 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 10:30 < dongcarl> w/re #15717, I wish to stop confusing the poor man. I think we should make it a shared library dependency just as we do with `miniupnp`, in that case, we should not submit any more reviews on the subtree-d code which should be removed and make it clear that we really need is another depends package. 10:30 < gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub 10:32 < dongcarl> My reading of #11902 was that we'll keep uPNP as an option that's off by default, and introduce NAT-PMP as ON by default, which I'm not sure how I feel about. wumpus perhaps you can enlighten me? 10:32 < gribble> https://github.com/bitcoin/bitcoin/issues/11902 | NAT-PMP port forwarding support · Issue #11902 · bitcoin/bitcoin · GitHub 10:35 < gmaxwell> dongcarl: do you think wumpus is your shrink? you appear to be asking him to advise you on your feelings. :) 10:36 < dongcarl> Hahahaha well... I guess more concretely I'm asking for any info I might be missing :-) 10:36 < gmaxwell> miniupnp library is a security disaster-- adhoc xml parsing using lulzical pointer frobbing, nothing has changed about that AFAIK. 10:37 * dongcarl adds lulzical pointer frobber to his list of insults 10:38 < gmaxwell> And thats pretty bad since by its very nature its exposed to untrustworthy network inputs ... So we're unwilling to enable it by default because it continues to look like a timebomb. 10:38 < dongcarl> that makes sense for sure 10:39 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:40 < gmaxwell> (Ideally we'd replace the library with something that isn't so terror inducing, but at least when we looked before there wasn't anything.. in part because upnp is an awful spec...) 10:40 < dongcarl> So given that NAT-PMP is a much simpler protocol that's harder to footgun, we can enable it by default, because if someone's got a NAT-PMP server on their gateway they're most likely okay with auto-port forwarding? 10:43 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 10:46 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 10:51 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 10:58 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 11:00 -!- kees1 [~kees@89.238.178.75] has quit [] 11:04 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 11:05 < gmaxwell> dongcarl: the on/off by default dosn't have anything to do with being okay with port forwarding. 11:05 < gmaxwell> It's entirely because of the multiple past RCE bugs in that particular library and the codebase that looks like it'll have more in the future. 11:07 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:08 -!- kerbyu [~kerbyu@185.178.49.150] has joined #bitcoin-core-dev 11:09 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:09 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:14 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 11:29 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 11:32 -!- BlueMatt [~matt@unaffiliated/bluematt] has joined #bitcoin-core-dev 11:34 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 11:39 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 11:40 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:43 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 11:43 -!- dbcx [4fe20991@gateway/web/freenode/ip.79.226.9.145] has joined #bitcoin-core-dev 11:43 -!- dbcx [4fe20991@gateway/web/freenode/ip.79.226.9.145] has quit [Client Quit] 11:45 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 11:54 -!- needhelpplz [026c85da@gateway/web/freenode/ip.2.108.133.218] has quit [Quit: Page closed] 12:02 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 12:24 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:36 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 12:37 < dongcarl> gmaxwell: Okay, so should NAT-PMP be on by default or no? 13:10 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:13 -!- BlueMatt [~matt@unaffiliated/bluematt] has quit [Quit: Ex-Chat] 13:14 < gmaxwell> Yes 13:15 < gmaxwell> dongcarl: it should be on by default, unless turned off-- and solf-set off by discover being off (either directly off, or indirectly off via listen off) 13:15 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 13:25 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 13:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:29 < dongcarl> gmaxwell: Roger 13:29 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 13:30 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:32 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:35 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:35 < gmaxwell> soft* 13:37 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer] 13:40 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 276 seconds] 13:41 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:43 -!- jaybny [~jaybny@50-0-50-76.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 13:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:45 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:49 < bitcoin-git> [bitcoin] hebasto opened pull request #15886: qt, wallet: Revamp SendConfirmationDialog (master...20190424-send-confirmation-dialog) https://github.com/bitcoin/bitcoin/pull/15886 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:49 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:53 -!- jaybny [~jaybny@50-0-50-76.dsl.dynamic.fusionbroadband.com] has left #bitcoin-core-dev ["Leaving"] 13:53 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 13:56 -!- jaybny [~jaybny@50-0-50-76.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 13:58 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:00 -!- kerbyu [~kerbyu@185.178.49.150] has quit [] 14:02 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 14:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 14:11 -!- UltimateNate [~UltimateN@185.178.49.150] has joined #bitcoin-core-dev 14:22 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:24 < bitcoin-git> [bitcoin] hebasto opened pull request #15887: docs: Align code example style with clang-format (master...20190424-coding-style) https://github.com/bitcoin/bitcoin/pull/15887 14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:34 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:35 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:39 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 14:39 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 14:59 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 276 seconds] 15:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:01 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 244 seconds] 15:07 -!- cazyjoker96 [02e29eed@gateway/web/freenode/ip.2.226.158.237] has joined #bitcoin-core-dev 15:07 -!- cazyjoker96 [02e29eed@gateway/web/freenode/ip.2.226.158.237] has quit [Client Quit] 15:13 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 15:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 15:19 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 15:20 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:21 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 15:27 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:28 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 15:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 15:42 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 15:58 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 15:58 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 16:00 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 16:33 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 276 seconds] 16:34 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 16:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 258 seconds] 16:38 -!- afk11 [~afk11@79.97.107.223] has joined #bitcoin-core-dev 16:39 -!- afk11 [~afk11@79.97.107.223] has quit [Changing host] 16:39 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 16:42 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Client Quit] 16:50 -!- shesek [~shesek@5.22.134.182] has joined #bitcoin-core-dev 16:50 -!- shesek [~shesek@5.22.134.182] has quit [Changing host] 16:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:58 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 16:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 276 seconds] 17:00 -!- UltimateNate [~UltimateN@185.178.49.150] has quit [] 17:04 -!- chaosagent [~chaosagen@185.178.49.150] has joined #bitcoin-core-dev 17:09 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has joined #bitcoin-core-dev 17:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 17:12 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has quit [Ping timeout: 264 seconds] 17:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 17:15 -!- shesek [~shesek@5.22.134.182] has joined #bitcoin-core-dev 17:15 -!- shesek [~shesek@5.22.134.182] has quit [Changing host] 17:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 17:17 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds] 17:27 -!- diego1 [~diego@177.34.230.167] has joined #bitcoin-core-dev 17:30 -!- diego1 [~diego@177.34.230.167] has left #bitcoin-core-dev [] 17:30 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 17:31 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 17:32 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 17:38 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 276 seconds] 17:39 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 17:44 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:45 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 17:48 < jeremyrubin> Does anyone have any references on SIGHASH_NOINPUT + Schnorr and not enabling pubkey recovery? (I understand why it doesn't enable it, but I don't understand why we aren't adding a flag like SIGHASH_SIGNINGKEY). That or alternatives like OP_CHECKSIGFROMSTACK or OP_PUSHXDATA. Trying to get a general sense of the roadmap on these features and what's a solved problem or what's open design space still. 17:49 < jeremyrubin> sipa: ^ 17:49 < jeremyrubin> jl2012: ^ 17:50 < luke-jr> jeremyrubin: pubkey recovery is arguably an implementation detail 17:50 < sipa> pubkey recovery is not compatible with batch validation 17:51 < sipa> plus key/signature aggregation generally achieve the same bandwidth savings in a more generic fashion 17:51 < sipa> i'm not sure what sighash_signingkey would mean 17:51 < luke-jr> (aside from sipa's point) an implementation could already strip pubkeys from scripts and do recovery instead 17:51 < jeremyrubin> not interested in the bandwidth savings aspect 17:52 < jeremyrubin> More useful is the vault-like aspects 17:52 < jeremyrubin> (e.g., for very simple covenants) 17:52 < sipa> i don't see any problem with OP_CHECKSIGFROMSTACK 17:53 < gmaxwell> jeremyrubin: the recovery is signficantly slower to validate even ignoring the batch validation which it breaks. There is also a specific patent encumberance concern. 17:57 < sipa> as far as covenants go, if there is an actual desire for those, they should be supported in a first-class fashion (by having opcodes that make assertions on the spending tx), not only through a hacky pubkey recovery construction imho 17:57 < jeremyrubin> Ok, so if there were a feature which would be implementable as either a one-off feature, or via something that requires SIGHASH_NOINPUT & something which enables PubkeyRecovery (and excludes batching) that would be maybe an OK path? 17:58 < sipa> i don't see why you'd want that 17:58 < sipa> compared to alternative 17:58 < jeremyrubin> A one-off feature refers to what you said (first class feature) 18:00 < jeremyrubin> Do you have a sense or feeling about enabling somewhat generic covenant capabilities, or making an opcode that pretty tightly only enables one specific new feature? 18:00 < sipa> (to be clear: i'm giving my personal opinion on these things here, and not trying to predict what the developer ecosystem at large would think of such a hypothetical proposal; i can tell you i'm not personally interested in working on those things, though) 18:00 < jeremyrubin> That's fine, I'm just straw polling 18:00 < sipa> i suspect that to be a contentious question 18:01 < jeremyrubin> I would agree -- I think from a security perspective enabling the minimum new behavior is probably best 18:01 < jeremyrubin> but it feels similar to the MAST debacle 18:01 < gmaxwell> jeremyrubin: depends, like some generic thing that is inelegant is harder to justify than a specific thing, unless its really clear that the genericism is useful--- that it results in multiple interesting reasonably efficient things. 18:02 < sipa> jeremyrubin: generally my opinion is that for production usage, anything but the most efficient way of enabling a feature is not interesting 18:02 < gmaxwell> If the genericism is clean, doesn't result in difficult to analyize implications, and is clearly the compariable to the most efficient way to implement multiple interesting things, then that would be a case for it. 18:02 < jeremyrubin> Efficient is an interesting term... 18:02 < sipa> for experimentation purposes having generic opcodes that let you encode features at a low level are useful, but they're not really needed on mainnet to enable experimentation 18:04 < jeremyrubin> Gotcha. 18:04 < gmaxwell> sipa: a reasonable argument can be made that the highest efficiency isn't quite as important if the usage would be something like a taproot fallback case-- there more as a threat than anything else. 18:04 < luke-jr> gmaxwell: I thought the patent expired? 18:04 < sipa> jeremyrubin: to be clear, that latter statement is very much my own opinion, and i suspect it is not a majority view 18:05 < gmaxwell> luke-jr: no, not for a long time. (it might not be a _valid_ patent for various reasons, it also might not be applicable to any particular implementation, but my prior analysis was that it was enough of a concern that I wouldn't want to use it without a very careful analysis) 18:05 < jeremyrubin> Are there any backreferences on something like OP_GETOUTPUTHASH (or OP_CHECKOUTPUTHASHVERIFY) which takes an index and queries an output in the txn? 18:06 < sipa> gmaxwell: yeah, though orders of magnitude matter... if we'd have bignum arithmetic available you'd still not want to implement SNARK verification in bitcoin script :) 18:06 < gmaxwell> sipa: I agree with that view with the 'threat cases can be less efficient' priviso. 18:06 < sipa> i agree my "most efificent" is an exaggeration 18:06 < gmaxwell> jeremyrubin: some of the challenge there is that you probably want to be able to carry a small amount of data forward in the output, rather than just fixing it exactly. 18:07 < jeremyrubin> Well, for a more generic solution, perhaps. 18:07 < sipa> jeremyrubin: i have thought very vaguely about having some sort of tree matching construction that you can apply against the spending tx 18:07 < jeremyrubin> But if theres a motivating use case which has no 'data hazard' it's useful 18:08 < jeremyrubin> sipa: I've been working on this for like 2 years a little bit ;) 18:08 < jeremyrubin> there are some pretty interesting use cases for something like this IMO 18:09 < sipa> i suspect there are indeed 18:09 < jeremyrubin> gmaxwell: the way to carry data forward if needed would be to have a script which has branches and you pre-commit to all possible data values 18:09 < sipa> though i haven't seen much concretely beyond vaults 18:09 < jeremyrubin> but that's a bit messy 18:10 < jeremyrubin> sipa: I'm happy to share some of my research in a more limited setting as I want to make sure my proposal is more polished before spreading such ideas 18:11 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:11 < sipa> well i have no intention of working on these things myself... already buried in too many other work 18:11 < jeremyrubin> fair 18:11 < jeremyrubin> another possible implementation of this would be a segwit version which just commits to a set of outputs being created but has no scripting capabilities 18:13 < jeremyrubin> This sort of design ensures that there is *no* ability to branch on which UTXO gets created. This is good on the 'limited simplest implementation' front and easies to analyze, but I suspect people would want more. 18:14 < sipa> it would badly break fungbility if you need to announce in the output whether it falls under scripts or nonscript rules 18:15 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 258 seconds] 18:15 < jeremyrubin> fungibility in terms of like a chain analysis tool? 18:16 < jeremyrubin> Ah -- I need to run to walk the dog before sundown, but will have a few other questions on this. Thanks for the input thus far!! 18:17 < sipa> jeremyrubin: i think it is generally advisable you can't distinguish different outputs tyoes (and to the extent possible, also when spending) 18:17 < sipa> that's the goal of taproot to a large extent 18:17 < sipa> avoiding revealing your policy to the world 18:22 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:29 -!- roconnor [~roconnor@host-104-157-228-210.dyn.295.ca] has joined #bitcoin-core-dev 18:31 < roconnor> #bitmetas 18:32 < roconnor> @jeremyrubin I had a chat with Bob McElrath about using SIGHASH_NOINPUT for a weak form of covenants. 18:36 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:40 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 18:41 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:45 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 250 seconds] 18:45 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 245 seconds] 18:45 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 19:01 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:11 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 19:11 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 19:17 -!- DougieBot5000_ is now known as DougieBot5000 19:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 19:31 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 19:33 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:46 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 19:50 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 19:55 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:00 -!- chaosagent [~chaosagen@185.178.49.150] has quit [] 20:06 -!- ccdle12 [~ccdle12@i114-189-73-160.s41.a038.ap.plala.or.jp] has quit [Remote host closed the connection] 20:10 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 20:14 < luke-jr> why is feature_segwit testing that one can explicitly generate a legacy address, take its pubkey, turn it into segwit, and send to that? 20:14 < luke-jr> I get that this works currently, but isn't that a behaviour we *don't* want? 20:16 < sipa> luke-jr: wellit's testing currently implemented functionality - even if that functionality is undesirable, it is currently intentional 20:17 < luke-jr> looking at the git history, it looks semi-accidental here at least 20:17 < luke-jr> it used to addwitnessaddress explicitly, but that got removed 20:20 < sipa> yeah, it's posaible the test can be rewritten in a way that matches expected workflows more 20:37 -!- kierra [~kierra@185.204.1.185] has joined #bitcoin-core-dev 20:37 -!- kierra is now known as Guest84953 20:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:45 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has joined #bitcoin-core-dev 20:46 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 20:50 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has quit [Ping timeout: 245 seconds] 21:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:47 -!- Guest84953 [~kierra@185.204.1.185] has quit [Ping timeout: 258 seconds] 21:56 -!- ppisati [~ppisati@net-37-182-11-27.cust.vodafonedsl.it] has quit [Quit: leaving] 21:59 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:02 -!- ppisati [~ppisati@net-31-27-146-135.cust.vodafonedsl.it] has joined #bitcoin-core-dev 22:04 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit] 22:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 22:04 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:07 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Ping timeout: 240 seconds] 22:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 22:10 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev 22:10 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 22:13 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 22:17 -!- gribble1 [~gribble@185.178.49.150] has joined #bitcoin-core-dev 22:17 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 250 seconds] 22:19 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 22:19 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 258 seconds] 22:32 -!- qrest [~qrestlove@2601:446:c201:f560:c94f:3d49:ad97:83e7] has quit [Ping timeout: 264 seconds] 22:43 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 22:47 < luke-jr> hrm, trying to write an explicit test for implicit segwit stuff, and it's failing :/ 22:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 22:57 -!- ElePHPhant [~ElePHPhan@104.244.159.151] has joined #bitcoin-core-dev 23:00 -!- gribble1 [~gribble@185.178.49.150] has quit [] 23:04 -!- Phong_1 [~Phong_@89.238.178.75] has joined #bitcoin-core-dev 23:07 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 245 seconds] 23:17 < luke-jr> is it supposed to ONLY be implicit after a restart? 23:22 < sipa> no 23:23 < sipa> luke-jr: what are you trying exactly? 23:26 < luke-jr> sipa: I made a new address with getnewaddress, getaddressinfo to find the pubkey, convert that to each address type, send to them all, then make sure it shows a receive in listtransactions 23:27 < luke-jr> after a restart, legacy => others seems to work 23:31 < luke-jr> http://dpaste.com/2JEX4PS 23:31 < luke-jr> weird, even w/o the restart the second check works 23:34 < luke-jr> ugh, adding a sleep makes it work in the first loo 23:34 < luke-jr> self.sync_all() is helpful >_< 23:46 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 23:48 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 23:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev --- Log closed Thu Apr 25 00:00:54 2019