--- Log opened Tue Apr 30 00:00:59 2019 00:01 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 00:31 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 00:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:56 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:03 < wumpus> re: #15141 "ValidationInvalidReason::TX_PREMATURE_SPEND is non-standard in AcceptToMemoryPoolWorker (two occurences) but invalid in Consensus::CheckTxInputs" this one is pretty weird isn't it? 01:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub 01:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:11 -!- laptop500 [~laptop@host81-155-233-70.range81-155.btcentralplus.com] has joined #bitcoin-core-dev 01:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 01:19 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 01:32 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:34 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:59 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 260 seconds] 02:00 -!- Cotillion [~Cotillion@192.145.126.244] has quit [] 02:04 -!- wgolden [~wgolden@84.39.117.57] has joined #bitcoin-core-dev 02:20 -!- promag_ [~promag@82.155.24.70] has joined #bitcoin-core-dev 02:21 -!- promag_ [~promag@82.155.24.70] has quit [Remote host closed the connection] 02:23 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:24 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4] 02:34 < wumpus> how are things looking for 0.18.0 final today? 02:37 < fanquake> wumpus Looking ok. Discussion in #15555 has dried up a bit. #15665 is still open, but no more reports of it occurring. 02:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15555 | v0.18.0 testing · Issue #15555 · bitcoin/bitcoin · GitHub 02:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15665 | 0.18.0 rc2 CPU spike in thread bitcoin-opencon · Issue #15665 · bitcoin/bitcoin · GitHub 02:38 < fanquake> Release is currently only 1 month "overdue" according to #14438 :p 02:38 < gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub 02:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bmxoxiigbgqosiwv] has joined #bitcoin-core-dev 02:38 -!- kljasdfvv [~flack@p200300D46F0FA5004D94572F20ED0E8B.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:51 -!- vab [736febd2@gateway/web/freenode/ip.115.111.235.210] has joined #bitcoin-core-dev 02:58 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 03:02 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 258 seconds] 03:04 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:08 -!- Guest42 [~textual@n11211983102.netvigator.com] has joined #bitcoin-core-dev 03:10 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 03:10 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:10 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:15 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:20 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 03:24 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:36 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:38 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:42 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 03:54 -!- blockguru [31cf36e6@gateway/web/freenode/ip.49.207.54.230] has quit [Ping timeout: 256 seconds] 04:09 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:14 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:15 -!- dcousens [~dcousens@124.182.32.196] has joined #bitcoin-core-dev 04:26 < jamesob> fanquake: thanks! 04:27 < fanquake> jamesob np 04:27 -!- dcousens [~dcousens@124.182.32.196] has quit [Quit: The Lounge - https://thelounge.github.io] 04:28 -!- dcousens [~dcousens@124.182.32.196] has joined #bitcoin-core-dev 04:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:34 -!- dcousens [~dcousens@124.182.32.196] has quit [Quit: The Lounge - https://thelounge.github.io] 04:34 -!- dcousens [~dcousens@124.182.32.196] has joined #bitcoin-core-dev 04:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:41 -!- dcousens [~dcousens@124.182.32.196] has quit [Quit: The Lounge - https://thelounge.github.io] 04:47 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 245 seconds] 04:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 04:51 < wumpus> fanquake: looks like the release notes issues were also fixed, time to tag then ! 04:52 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 04:55 < fanquake> wumpus \o/ 04:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:00 -!- wgolden [~wgolden@84.39.117.57] has quit [] 05:11 -!- kireguy [~kireguy@89.238.178.75] has joined #bitcoin-core-dev 05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:12 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/825ecb5758f6...2472733a24a9 05:12 < bitcoin-git> bitcoin/0.18 2472733 Wladimir J. van der Laan: build: Bump version to -final 05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:14 < bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0: https://github.com/bitcoin/bitcoin/compare/v0.18.0 05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:24 -!- vab [736febd2@gateway/web/freenode/ip.115.111.235.210] has quit [Quit: Page closed] 05:26 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:26 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:30 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:36 -!- dcousens [~dcousens@124.189.34.146] has joined #bitcoin-core-dev 06:05 -!- Dukew [ac3a5e83@gateway/web/freenode/ip.172.58.94.131] has joined #bitcoin-core-dev 06:09 -!- Dukew [ac3a5e83@gateway/web/freenode/ip.172.58.94.131] has quit [Ping timeout: 256 seconds] 06:12 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 06:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 06:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 06:29 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 06:30 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:34 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 06:47 -!- Aaronvan_ is now known as AaronvanW 07:09 -!- spaced0ut_ [~spaced0ut@198.211.112.88] has joined #bitcoin-core-dev 07:11 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 268 seconds] 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ce6762030f81...45d8b7177851 07:12 < bitcoin-git> bitcoin/master 8728a66 John Newbery: [tests] fix block time in feature_pruning.py 07:12 < bitcoin-git> bitcoin/master fafb55e MarcoFalke: [qa] test_runner: Move feature_pruning to base tests 07:12 < bitcoin-git> bitcoin/master 45d8b71 MarcoFalke: Merge #15696: [qa] test_runner: Move feature_pruning to base tests 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15696: [qa] test_runner: Move feature_pruning to base tests (master...1904-qaPruning) https://github.com/bitcoin/bitcoin/pull/15696 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 246 seconds] 07:39 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 07:48 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 07:50 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 07:51 -!- MrPaz [~MrPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 08:00 -!- kireguy [~kireguy@89.238.178.75] has quit [] 08:06 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 08:08 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 08:10 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 08:10 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:11 -!- pleia21 [~pleia2@165.84.231.15] has joined #bitcoin-core-dev 08:27 -!- cubancorona2 [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 08:27 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 08:27 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 08:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Ping timeout: 246 seconds] 08:32 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Read error: Connection reset by peer] 08:33 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 08:33 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 08:33 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 08:34 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 08:35 -!- davterra [~none@178.128.106.205] has quit [Ping timeout: 246 seconds] 08:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer] 08:38 -!- profmac [~ProfMac@2001:470:1f0f:226:eddf:45cb:e1e7:6f4] has quit [Ping timeout: 252 seconds] 08:39 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 08:39 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 08:45 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 08:47 -!- davterra [~none@94.100.23.163] has joined #bitcoin-core-dev 08:49 -!- Guest42 [~textual@n11211983102.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:04 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:04 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:04 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 09:04 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:08 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45d8b7177851...10ed4dff2447 09:15 < bitcoin-git> bitcoin/master 151f3e9 Russell Yanofsky: Add settings merge test to prevent regresssions 09:15 < bitcoin-git> bitcoin/master 10ed4df MarcoFalke: Merge #15869: Add settings merge test to prevent regresssions 09:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15869: Add settings merge test to prevent regresssions (master...pr/testset) https://github.com/bitcoin/bitcoin/pull/15869 09:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:27 -!- cubancorona2 [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 09:31 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:33 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit] 09:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Ping timeout: 250 seconds] 09:36 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 09:36 -!- omonk [~omonk@unaffiliated/omonk] has quit [Client Quit] 09:44 -!- promag_ [~promag@46.50.2.30] has joined #bitcoin-core-dev 09:47 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:54 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:54 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:55 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:15 -!- promag_ [~promag@46.50.2.30] has quit [Remote host closed the connection] 10:24 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:25 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 10:32 -!- FredHampton [4b466c0b@gateway/web/freenode/ip.75.70.108.11] has joined #bitcoin-core-dev 10:32 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 10:33 -!- FredHampton [4b466c0b@gateway/web/freenode/ip.75.70.108.11] has left #bitcoin-core-dev [] 10:40 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:42 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 10:44 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 10:55 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:00 -!- pleia21 [~pleia2@165.84.231.15] has quit [] 11:00 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15926: tinyformat: Add format_no_throw (master...1904-tinyformatNoThrow) https://github.com/bitcoin/bitcoin/pull/15926 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:03 -!- matael1 [~matael@165.84.231.15] has joined #bitcoin-core-dev 11:12 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:17 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 276 seconds] 11:38 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:59 -!- Ga1aCt1Cz00 [~Ga1aCt1Cz@p2003005F6E05C023F8DFB7926E7F2410.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 12:09 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 12:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 12:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 256 seconds] 12:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 12:11 -!- spaced0ut_ [~spaced0ut@198.211.112.88] has quit [Quit: Leaving] 12:11 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 12:12 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 12:19 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:20 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:22 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 12:22 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 12:25 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/10ed4dff2447...2c35fe623813 12:27 < bitcoin-git> bitcoin/master 188ca75 James O'Beirne: disable HAVE_THREAD_LOCAL on unreliable platforms 12:27 < bitcoin-git> bitcoin/master ae5f2b6 James O'Beirne: threads: introduce util/threadnames, refactor thread naming 12:27 < bitcoin-git> bitcoin/master ddd95cc James O'Beirne: tests: add threadutil tests 12:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15849: Thread names in logs and deadlock debug tools (master...2018-05-threadnames-take-2) https://github.com/bitcoin/bitcoin/pull/15849 12:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:35 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 12:36 -!- Tralfaz [~none@178.128.106.205] has joined #bitcoin-core-dev 12:38 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 12:39 -!- davterra [~none@94.100.23.163] has quit [Ping timeout: 246 seconds] 12:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:48 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:51 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 12:53 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 12:54 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:54 < instagibbs> MarcoFalke, re 15881 what about having it set via parameter, and specific build in CI runs with it as mainnet default? 12:55 < instagibbs> I realize there are alrady too many cooks 12:56 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 12:58 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 13:02 -!- berndj-blackout [~berndj@azna.co.za] has joined #bitcoin-core-dev 13:03 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 264 seconds] 13:04 -!- berndj-blackout is now known as berndj 13:06 -!- blockguru [31cf36e6@gateway/web/freenode/ip.49.207.54.230] has joined #bitcoin-core-dev 13:08 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:08 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:08 -!- cj_ [d433929f@gateway/web/freenode/ip.212.51.146.159] has joined #bitcoin-core-dev 13:08 -!- dermoth_ [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 13:08 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Disconnected by services] 13:08 -!- dermoth_ is now known as dermoth 13:08 -!- cj_ [d433929f@gateway/web/freenode/ip.212.51.146.159] has quit [Client Quit] 13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:15 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15858: Faster tests with topological mempool rpc sync 🚀 (master...1904-qaSync) https://github.com/bitcoin/bitcoin/pull/15858 13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:18 < wumpus> what was wrong with the #15858 approach? I liked keeping the change contained to the tests only 13:18 < gribble> https://github.com/bitcoin/bitcoin/issues/15858 | Faster tests with topological mempool rpc sync 🚀 by MarcoFalke · Pull Request #15858 · bitcoin/bitcoin · GitHub 13:20 < wumpus> confused why it got closed 13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:20 < bitcoin-git> [bitcoin] jnewbery opened pull request #15927: [tests] log thread names by default in functional tests (master...2019-04-log-threads-tests) https://github.com/bitcoin/bitcoin/pull/15927 13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:30 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 13:30 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:31 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:35 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 13:38 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:38 < jnewbery> wumpus: I prefer 15881 since it's a smaller deviation from what happens for tx propogation on mainnet 13:42 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 13:42 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:47 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:51 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:54 < luke-jr> #define stacktop(i) (stack.at(stack.size()+(i))) 13:55 < luke-jr> LLVM likes to cast i to unsigned and do the addition with an overflow :/ 13:55 < luke-jr> should we just cast stack.size() to ssize_t or something else? 13:57 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:57 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:58 < harding> wumpus: FYI, 0.18.0 release PR for BitcoinCore.org is here: https://github.com/bitcoin-core/bitcoincore.org/pull/649 13:59 < gwillen> it's not really up to LLVM, the C integer promotion rules are fixed 13:59 < gwillen> it should depend only on the integer types involved 14:00 -!- matael1 [~matael@165.84.231.15] has quit [] 14:00 < gwillen> unfortunately they are extremely arcane 14:00 < sipa> can we do a search replace stacktop(-i) -> stacktop(i) and then use (stack.at(stack.size()-(i))) 14:01 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 14:02 < gwillen> it seems like the offending rule is "If the operand that has unsigned integer type has rank greater than or equal to the rank of the type of the other operand, the operand with signed integer type is converted to the type of the operand with unsigned integer type." 14:03 < gwillen> so if you do math with a size_t (64 bit unsigned) and an int (32-bit signed) you get flattened 14:03 < luke-jr> sipa: if we do that, let's rename stacktop 14:03 < gwillen> it's a weird rule. 14:03 < gwillen> but casting to ssize_t should solve it? 14:03 < sipa> *(stack.rbegin() + i) also works :p 14:04 < luke-jr> + -i ? 14:04 < sipa> with positive i, i mean 14:04 < sipa> oh, no; *(stack.rbegin() + (i - 1)) 14:04 -!- ilovezfs [~ilovezfs@173.209.57.12] has joined #bitcoin-core-dev 14:04 < luke-jr> positive i is a hazard 14:05 < sipa> why? 14:05 < luke-jr> too easy to accidentally merge or backport with an invisible error 14:05 < sipa> that's fair 14:05 < gwillen> this seems like something you could check statically, if it's generally a constant 14:05 < luke-jr> gwillen: it's not always a constant 14:06 -!- Kevin__6 [~quassel@2a01:4b00:898a:4300:48f7:e011:bad9:9224] has joined #bitcoin-core-dev 14:06 < luke-jr> anyway, keeping the negative i should be harmless 14:10 -!- profmac [~ProfMac@2001:470:1f0f:226:64a7:a315:c66e:6225] has joined #bitcoin-core-dev 14:13 < gwillen> luke-jr: how did it come to pass that this is coming up -- did core change, or did LLVM change? 14:13 < luke-jr> gwillen: -fsanitize=undefined 14:14 < luke-jr> (apparently while we have a Travis job for it, we also have a suppressions file to hide all our existing issues!) 14:14 < gwillen> that's odd... there shouldn't be anything undefined about that, should there? Does it cite chapter and verse? 14:14 < gwillen> I can imagine it getting the wrong answer, but not being undefined 14:15 < gwillen> and it sounds like it's not in fact getting the wrong answer in practice or we'd have hit this before? 14:15 < luke-jr> gwillen: overflows are undefined behaviour 14:15 < gwillen> not unsigned overflows 14:15 < gwillen> only signed 14:15 < gwillen> if it gets converted to unsigned first it should be well-defined 14:15 < luke-jr> UBSan says unsigned are undefined too <.< 14:16 < gwillen> maybe that's why it was suppressed... 14:17 < gwillen> see e.g. https://stackoverflow.com/questions/18195715/why-is-unsigned-integer-overflow-defined-behavior-but-signed-integer-overflow-is 14:17 < gwillen> can you pastebin the ubsan complaint? 14:18 < sipa> luke-jr: by default ubsan does not warn on unsigned overflow, but there is an optional flag to enable them 14:18 < sipa> they're not undefined behavior, but a common red flag 14:19 < luke-jr> gwillen: it scrolled out of my terminal - and I'm not entirely sure how I triggered it, since I wasn't running on mainnet ☺ 14:19 < luke-jr> sipa: odd, I didn't explicitly set any flag 14:19 < sipa> the core build system enables it afaik 14:19 < luke-jr> ah 14:20 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 14:20 < luke-jr> is the cast from negative to unsigned also well-defined? 14:20 < luke-jr> script/interpreter.cpp:922:42: runtime error: unsigned integer overflow: 2 + 18446744073709551615 cannot be represented in type 'unsigned long' 14:20 < luke-jr> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior script/interpreter.cpp:922:42 in 14:20 < luke-jr> gwillen: ^ 14:22 < sipa> luke-jr: cast from signed to unsigned is well defined 14:22 < sipa> the other way isn't afaik 14:22 * luke-jr typically avoids answering these questions by being explicit on anything that could reasonably be undefined :p 14:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 14:25 < gwillen> yeah so it seems like we are in one of the corners of integer promotion that is weird but not bad 14:26 < gwillen> wherein C promotes from signed to unsigned in a way that creates apparent integer overflow that actually gives the correct answer consistently 14:26 < gwillen> casting to ssize_t will probably get rid of the weirdness but will cause undefined behavior (I think) if the stack has more than 2 billion elements, which I expect is not a concern 14:27 < gwillen> actually if size_t is 64 bit it would need to be a lot more than that 14:29 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:35 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bmxoxiigbgqosiwv] has quit [Quit: Connection closed for inactivity] 14:36 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:43 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Read error: Connection reset by peer] 14:43 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:45 < luke-jr> gwillen: ssize_t isn't guaranteed to be large enough for all sizes? 14:48 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 14:53 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 15:09 < gmaxwell> gwillen: we are misusing sanitization tools 15:09 < gmaxwell> and using suppression files to cover up the misuse 15:10 < gmaxwell> and then probably just giving up on making useful changes, to cover up the difficulty of updating the suppressions. 15:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 15:13 < gmaxwell> there are a ton of sanitizers which are available which trigger on behavior that is sometimes (even only rarely) a mistake, and turning them on means either (1) you leave them producing false positives which you ignore, causing you to miss real reports, (2) go change the code in ways that silence them, often lowering code quality or even adding bugs, (3) suppress them, and then deal with the 15:13 < gmaxwell> returning every time you add a new instance of the same idiom or refactor something 15:14 < gmaxwell> In commercial tools like coverity these concerns are addressed by not emitting warnings for anything that has a high false positive rate (even if that misses some true positives), and by havinga nice database that lets you track suppressions, keep notes on them, and which manages to survive refactoring most of the time. 15:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 15:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:31 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 15:34 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:37 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:39 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:40 -!- Guest42 [~textual@n11211983102.netvigator.com] has joined #bitcoin-core-dev 15:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:49 -!- davterra [~none@94.100.23.163] has joined #bitcoin-core-dev 15:50 -!- Tralfaz [~none@178.128.106.205] has quit [Ping timeout: 245 seconds] 15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:55 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15881: net: Send txs without delay on regtest (master...1904-txRelayRegtest) https://github.com/bitcoin/bitcoin/pull/15881 15:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 16:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 16:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:13 -!- laptop500 [~laptop@host81-155-233-70.range81-155.btcentralplus.com] has quit [Ping timeout: 276 seconds] 16:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 16:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 16:23 < gwillen> gmaxwell: *nod*, that all makes sense 16:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:47 -!- scoop [~scoop@2601:240:d700:b3a:d9dd:fd0:3385:fbc4] has joined #bitcoin-core-dev 16:53 -!- scoop [~scoop@2601:240:d700:b3a:d9dd:fd0:3385:fbc4] has quit [Remote host closed the connection] 16:59 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:00 -!- ilovezfs [~ilovezfs@173.209.57.12] has quit [] 17:01 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 250 seconds] 17:04 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 17:04 -!- Arthimus [~Arthimus@185.204.1.185] has joined #bitcoin-core-dev 17:06 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds] 17:10 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:25 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 17:37 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Quit: Leaving] 17:37 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev 17:42 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 17:43 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 17:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 18:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 18:22 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Read error: Connection reset by peer] 18:23 -!- murrayn [~murrayn@71.19.251.147] has joined #bitcoin-core-dev 18:23 -!- murrayn [~murrayn@71.19.251.147] has quit [Changing host] 18:23 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 18:52 -!- scoop [~scoop@2601:240:d700:b3a:d9dd:fd0:3385:fbc4] has joined #bitcoin-core-dev 18:57 -!- ccdle12 [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:01 -!- ccdle12 [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:01 -!- ccdle12 [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:07 -!- ccdle12_ [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:07 -!- ccdle12 [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:13 -!- ccdle12_ [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:14 -!- ccdle12 [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:15 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 19:15 -!- roconnor [~roconnor@2600:1700:4570:fe1:35b7:caff:9006:d195] has joined #bitcoin-core-dev 19:18 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E05C04609DCCF7D455B97C9.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 19:18 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 250 seconds] 19:20 -!- ccdle12_ [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:20 -!- ccdle12 [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:21 -!- Ga1aCt1Cz00 [~Ga1aCt1Cz@p2003005F6E05C023F8DFB7926E7F2410.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 19:26 -!- ccdle12 [~ccdle12@101.102.202.82] has joined #bitcoin-core-dev 19:26 -!- ccdle12_ [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:29 -!- scoop [~scoop@2601:240:d700:b3a:d9dd:fd0:3385:fbc4] has quit [Remote host closed the connection] 19:30 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 19:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 19:33 -!- ccdle12 [~ccdle12@101.102.202.82] has quit [Read error: Connection reset by peer] 19:46 -!- roconnor [~roconnor@2600:1700:4570:fe1:35b7:caff:9006:d195] has quit [Quit: Konversation terminated!] 19:56 -!- roconnor [~roconnor@2600:1700:4570:fe1:35b7:caff:9006:d195] has joined #bitcoin-core-dev 20:00 -!- Arthimus [~Arthimus@185.204.1.185] has quit [] 20:06 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E05C04609DCCF7D455B97C9.dip0.t-ipconnect.de] has left #bitcoin-core-dev [] 20:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:14 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 20:18 -!- Gohla1 [~Gohla@84.39.117.57] has joined #bitcoin-core-dev 20:34 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 20:39 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 20:50 -!- billgates [408d5642@gateway/web/freenode/ip.64.141.86.66] has joined #bitcoin-core-dev 20:51 -!- billgates is now known as Guest1018 20:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:58 -!- pinheadmz [~matthewzi@c-76-102-241-10.hsd1.ca.comcast.net] has quit [Ping timeout: 250 seconds] 21:14 -!- Guest1018 [408d5642@gateway/web/freenode/ip.64.141.86.66] has quit [Ping timeout: 256 seconds] 21:17 -!- jhfrontz1 [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Ping timeout: 246 seconds] 21:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds] 21:40 -!- davterra [~none@94.100.23.163] has quit [Remote host closed the connection] 21:44 -!- pinheadmz [~matthewzi@c-76-102-241-78.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:45 -!- davterra [~none@94.100.23.163] has joined #bitcoin-core-dev 21:50 -!- Guest42 [~textual@n11211983102.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:08 -!- roconnor [~roconnor@2600:1700:4570:fe1:35b7:caff:9006:d195] has quit [Quit: Konversation terminated!] 22:11 -!- kljasdfvv [~flack@p200300D46F0FA5004D94572F20ED0E8B.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 22:11 -!- kljasdfvv [~flack@p200300D46F0FA500152AE0E05CD205C7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 22:15 -!- Guest42 [~textual@n11211983102.netvigator.com] has joined #bitcoin-core-dev 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:21 < bitcoin-git> [bitcoin] luke-jr opened pull request #15928: GUI: Move QRImageWidget to its own qrencoder file-pair (master...split_qrencoder) https://github.com/bitcoin/bitcoin/pull/15928 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:24 -!- pinheadmz [~matthewzi@c-76-102-241-78.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 22:28 -!- pinheadmz [~matthewzi@c-76-102-241-78.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:00 -!- Gohla1 [~Gohla@84.39.117.57] has quit [] 23:03 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 23:04 -!- kreative [~kreative@192.145.126.244] has joined #bitcoin-core-dev 23:06 < michagogo> Was there a depends bump from rc4 to final? o_O 23:06 < michagogo> Not seeing anything like that in `git diff`, but it’s rebuilding Qt… 23:19 -!- blockguru [31cf36e6@gateway/web/freenode/ip.49.207.54.230] has quit [Quit: Page closed] 23:26 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Ping timeout: 246 seconds] 23:30 -!- scoop [~scoop@c-76-16-96-3.hsd1.il.comcast.net] has joined #bitcoin-core-dev 23:33 < gwillen> achow101: I couldn't help but notice 1ac17cab41...9c4a76e952 wallet-of-the-glorious-future -> achow/wallet-of-the-glorious-future (forced update) 23:33 < gwillen> I hope the branch lives up to its name ;-) 23:34 -!- liquidso [4c5f855c@gateway/web/freenode/ip.76.95.133.92] has joined #bitcoin-core-dev 23:35 -!- scoop [~scoop@c-76-16-96-3.hsd1.il.comcast.net] has quit [Ping timeout: 255 seconds] 23:45 < wumpus> michagogo: no, there was no other change than a configure.ac bump from rc4 to final 23:46 < michagogo> That’s what I saw as well 23:46 < michagogo> But now I’m wondering why it’s apparently rebuilding depends 23:46 < michagogo> My last build on that machine was definitely rc4 23:48 < wumpus> that's strange, really don't know, afaik it also doesn't log why it decides to rebuild the depends 23:49 < wumpus> harding: thanks! 23:52 -!- pinheadmz [~matthewzi@c-76-102-241-78.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 23:52 < luke-jr> gwillen: lol 23:52 < wumpus> jnewbery: fair enough, though, I still think adding all kinds of test-specific flags to bitcoind is not that great 23:52 < luke-jr> gwillen: I notice it's the future that is glorious, not the wallet XD 23:56 -!- pinheadmz [~matthewzi@c-76-102-241-78.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:59 -!- liquidso [4c5f855c@gateway/web/freenode/ip.76.95.133.92] has quit [Ping timeout: 256 seconds] --- Log closed Wed May 01 00:00:00 2019