--- Log opened Tue May 07 00:00:05 2019 00:00 < gmaxwell> more likely would be a particular opcode that doesn't access the annex data directly but checks an annex controlled property. 00:00 < jeremyrubin> Oh I do! We could enforce that if a txn is signed with an innacurate annex-as-a-validation-cost-hint it becomes anyone can spend 00:01 < jeremyrubin> Yeah exactly 00:01 < gmaxwell> like CSV doesn't directly muck about bits of the transactions serialization, it just imposes constraints on the locktime. 00:01 < jeremyrubin> Some sort of use case around being able to ensure that if a branch is taken, the proper annex is set 00:01 < jeremyrubin> (either with anyonecan spend teeth or just invalid is fine too ;) ) 00:02 < gmaxwell> that sounds like a great way to steal a hardware wallet's coins... 00:02 < gmaxwell> the idea behind annex based costs is that they'd be required to be accurate (or at least greater) than the actual cost. 00:03 < gmaxwell> (and you could drop peers that give you junk) 00:06 < jeremyrubin> I guess one issue with an annex like thing is that if it's being used to do a p2sh like thing in the future as a hacky graftroot delegation scheme, we really can't pass data to it 00:07 < gmaxwell> there shouldn't be any reason to do that. 00:09 < jeremyrubin> I guess to make my point more succinctly, the encoding scheme for detecting tapscript spends and annexes feels kinda hacky 00:10 < jeremyrubin> We're limited by the 520 byte limit, but I wonder if we'd be better off encoding all this info into a serialized struct rather than something that has witness program semantics 00:13 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 00:13 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 00:15 < jeremyrubin> Anyways, headed to sleep. will continue pondering 00:20 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 00:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:25 -!- mryandao_ is now known as mryandao 00:48 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 00:54 -!- rex4539 [~rex4539@ppp-94-66-20-149.home.otenet.gr] has quit [Quit: rex4539] 01:05 -!- rex4539 [~rex4539@opjumq.static.otenet.gr] has joined #bitcoin-core-dev 01:30 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood] 01:31 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:40 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 02:00 -!- Guest44098 [~ericb2@84.39.117.57] has quit [] 02:04 -!- beaups1 [~beaups@89.238.178.75] has joined #bitcoin-core-dev 02:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:05 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 02:06 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 252 seconds] 02:07 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 02:10 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 02:12 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 02:25 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-qyucheftvkhqqsim] has joined #bitcoin-core-dev 02:28 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 02:32 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:33 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:37 < bitcoin-git> [bitcoin] practicalswift opened pull request #15971: validation: Add compile-time checking for negative locking requirements in LimitValidationInterfaceQueue (master...negative-locks) https://github.com/bitcoin/bitcoin/pull/15971 02:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 258 seconds] 02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 02:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:56 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:57 < promag> MarcoFalke: do you mind reviewing #14984? 02:57 < gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub 03:00 -!- shesek [~shesek@5.22.134.182] has joined #bitcoin-core-dev 03:01 -!- shesek [~shesek@5.22.134.182] has quit [Changing host] 03:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:05 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 03:07 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has joined #bitcoin-core-dev 03:07 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:11 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds] 03:17 < fanquake> promag I will try and review tonight. Had been meaning to review and benchmark. 03:35 -!- stfn_ [54827ad0@gateway/web/freenode/ip.84.130.122.208] has joined #bitcoin-core-dev 03:35 -!- rex4539 [~rex4539@opjumq.static.otenet.gr] has quit [Quit: rex4539] 03:36 -!- rex4539 [~rex4539@opjumq.static.otenet.gr] has joined #bitcoin-core-dev 03:39 -!- stfn_ [54827ad0@gateway/web/freenode/ip.84.130.122.208] has quit [Ping timeout: 256 seconds] 03:42 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 03:42 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:43 < promag> fanquake: thanks 03:43 * luke-jr wonders if two extra simple-wrapper abstraction layers is really necessary :x 03:48 -!- chu-ken [cad73b7b@gateway/web/freenode/ip.202.215.59.123] has joined #bitcoin-core-dev 03:52 -!- chu-ken [cad73b7b@gateway/web/freenode/ip.202.215.59.123] has quit [Ping timeout: 256 seconds] 03:58 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has quit [Quit: WeeChat 2.4] 03:58 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 04:01 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds] 04:02 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 04:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:04 -!- Sayoo [cff67a0d@gateway/web/freenode/ip.207.246.122.13] has joined #bitcoin-core-dev 04:10 -!- jonatack [58aba822@gateway/web/freenode/ip.88.171.168.34] has quit [Ping timeout: 256 seconds] 04:11 -!- Sayoo [cff67a0d@gateway/web/freenode/ip.207.246.122.13] has quit [Ping timeout: 256 seconds] 04:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:13 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:15 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 04:19 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:27 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4] 04:31 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 04:31 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:38 -!- hebasto [c22c27d1@gateway/web/freenode/ip.194.44.39.209] has joined #bitcoin-core-dev 04:40 < hebasto> MarcoFalke: hi! are you around? 04:42 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 04:47 < hebasto> Can we make a trusty build on Travis w/ depends? (refs #15276, #15308) 04:47 < gribble> https://github.com/bitcoin/bitcoin/issues/15276 | travis: Compile once on trusty by MarcoFalke · Pull Request #15276 · bitcoin/bitcoin · GitHub 04:47 < gribble> https://github.com/bitcoin/bitcoin/issues/15308 | build: Restore compatibility with older boost by Empact · Pull Request #15308 · bitcoin/bitcoin · GitHub 04:49 < hebasto> Is there any reason against it? 04:51 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:00 -!- beaups1 [~beaups@89.238.178.75] has quit [] 05:01 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:01 -!- lipsch_hth [ac6857e2@gateway/web/freenode/ip.172.104.87.226] has joined #bitcoin-core-dev 05:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:13 -!- lipsch_hth [ac6857e2@gateway/web/freenode/ip.172.104.87.226] has quit [Ping timeout: 256 seconds] 05:18 < luke-jr> hebasto: is there a reason for it? 05:18 < luke-jr> default reason against => adds to CI time 05:20 -!- dermoth_ [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 05:20 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Disconnected by services] 05:20 -!- dermoth_ is now known as dermoth 05:21 < hebasto> luke-jr: trusty uses miniupnpc 1.6 which is outdated and I'm going to clean codebase. 05:22 < hebasto> Is trusty build with NO_UPNP=1 a right way? 05:22 < luke-jr> hebasto: removing support for older libraries doesn't seem productive. 05:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 05:23 < hebasto> miniupnpc 1.6 is also unsafe. 05:25 < luke-jr> I suppose that's a good reason ☺ 05:25 < luke-jr> NO_UPNP sounds like a good solution then 05:25 < luke-jr> maybe move it from the existing NO_UPNP build 05:26 < hebasto> luke-jr: thank you 05:33 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:b10a:3b77:74b2:4cb] has joined #bitcoin-core-dev 05:46 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 06:01 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:10 * luke-jr wonders if we should drop WalletModel now that we have interfaces::Wallet <.< 06:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:20 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 06:26 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 06:33 -!- laptop500 [~laptop@host86-128-184-5.range86-128.btcentralplus.com] has joined #bitcoin-core-dev 06:34 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 06:35 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:40 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 06:40 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:40 -!- goatpig [53724877@gateway/web/freenode/ip.83.114.72.119] has joined #bitcoin-core-dev 06:48 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 07:06 -!- davterra [~tralfaz@178.128.106.205] has quit [Quit: Leaving] 07:07 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 07:11 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 07:11 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 07:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.4] 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:16 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13204: Faster sigcache nonce (master...faster-sigcache-nonce) https://github.com/bitcoin/bitcoin/pull/13204 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:18 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:20 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 07:23 -!- Barras2 [~Barras2@84.39.117.57] has joined #bitcoin-core-dev 07:25 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:b10a:3b77:74b2:4cb] has quit [Ping timeout: 258 seconds] 07:25 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:39 < bitcoin-git> [bitcoin] HenryYoung42 opened pull request #15973: Trivial: Add explicit [[fallthrough]] to switch statement (master...master) https://github.com/bitcoin/bitcoin/pull/15973 07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:45 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 07:58 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:00 -!- Barras2 [~Barras2@84.39.117.57] has quit [] 08:02 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 08:04 -!- AimHere1 [~AimHere@185.204.1.185] has joined #bitcoin-core-dev 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15973: Trivial: Add explicit [[fallthrough]] to switch statement (master...master) https://github.com/bitcoin/bitcoin/pull/15973 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:08 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:12 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds] 08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:18 < bitcoin-git> [bitcoin] promag opened pull request #15974: refactor: Avoid UniValue copy constructor (master...2019-05-copy-univalue) https://github.com/bitcoin/bitcoin/pull/15974 08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- jamesob [sid180710@gateway/web/irccloud.com/x-opcqoiumxzyawxdx] has quit [Ping timeout: 264 seconds] 08:22 -!- jamesob [sid180710@gateway/web/irccloud.com/x-bsdeuuxzpeymdors] has joined #bitcoin-core-dev 08:24 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:24 -!- kexkey [~kexkey@5.181.233.22] has joined #bitcoin-core-dev 08:24 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 08:30 -!- rex4539 [~rex4539@opjumq.static.otenet.gr] has quit [Quit: rex4539] 08:31 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 08:33 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:38 < bitcoin-git> [bitcoin] promag opened pull request #15975: univalue: Drop overloaded members (master...2019-05-drop-univalue-overloads) https://github.com/bitcoin/bitcoin/pull/15975 08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:39 -!- hebasto [c22c27d1@gateway/web/freenode/ip.194.44.39.209] has quit [Quit: Page closed] 08:39 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:45 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 08:47 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Disconnected by services] 08:51 -!- cryptokev [25319b5a@gateway/web/freenode/ip.37.49.155.90] has joined #bitcoin-core-dev 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3632143ebbfd...b2a6b0216192 08:53 < bitcoin-git> bitcoin/master 1b6e6fc James O'Beirne: rename: CChainState.chainActive -> m_chain 08:53 < bitcoin-git> bitcoin/master a3a6090 James O'Beirne: refactoring: introduce unused ChainActive() 08:53 < bitcoin-git> bitcoin/master 631940a James O'Beirne: scripted-diff: replace chainActive -> ::ChainActive() 08:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:53 -!- qrestlove [~qrestlove@2601:446:c201:f560:c0c3:719d:1cdc:f73d] has quit [Ping timeout: 276 seconds] 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15948: refactor: rename chainActive (master...2019-05-au-chainactive) https://github.com/bitcoin/bitcoin/pull/15948 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:00 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:01 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:03 -!- qrestlove [~qrestlove@2601:446:c201:f560:bdac:d901:e643:debb] has joined #bitcoin-core-dev 09:05 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 09:09 -!- cryptokev [25319b5a@gateway/web/freenode/ip.37.49.155.90] has quit [Ping timeout: 256 seconds] 09:10 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:11 < bitcoin-git> [bitcoin] joemphilips closed pull request #11770: [REST] add a rest endpoint for estimatesmartfee, docs, and test (master...rest_fee) https://github.com/bitcoin/bitcoin/pull/11770 09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:12 < bitcoin-git> [bitcoin] instagibbs closed pull request #13045: [p2p] getblock for 1-block reorgs in response to compact block message (master...cmpcttie) https://github.com/bitcoin/bitcoin/pull/13045 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:13 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 09:15 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:21 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 09:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045 09:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:34 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045 09:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:35 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds] 09:36 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:37 < bitcoin-git> [bitcoin] practicalswift closed pull request #15721: validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld) (master...negative-locking-annotations) https://github.com/bitcoin/bitcoin/pull/15721 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:38 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 09:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: Connection reset by peer] 09:41 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:45 -!- davterra [~tralfaz@178.128.106.205] has joined #bitcoin-core-dev 10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:06 < bitcoin-git> [bitcoin] DrahtBot closed pull request #14245: Minimize vfExec counting in script handling (master...fexec) https://github.com/bitcoin/bitcoin/pull/14245 10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:06 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #14245: Minimize vfExec counting in script handling (master...fexec) https://github.com/bitcoin/bitcoin/pull/14245 10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] DrahtBot closed pull request #14125: Add testcase to simulate bitcoin schema in leveldb (master...master) https://github.com/bitcoin/bitcoin/pull/14125 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:07 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #14125: Add testcase to simulate bitcoin schema in leveldb (master...master) https://github.com/bitcoin/bitcoin/pull/14125 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] DrahtBot closed pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079 10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:08 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:08 < bitcoin-git> [bitcoin] DrahtBot closed pull request #14049: Enable libsecp256k1 ecdh module, add ECDH function to CKey (master...2018/08/bip151_ecdh) https://github.com/bitcoin/bitcoin/pull/14049 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:08 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #14049: Enable libsecp256k1 ecdh module, add ECDH function to CKey (master...2018/08/bip151_ecdh) https://github.com/bitcoin/bitcoin/pull/14049 10:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] DrahtBot closed pull request #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (master...nVersion-checks) https://github.com/bitcoin/bitcoin/pull/14033 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #14033: p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (master...nVersion-checks) https://github.com/bitcoin/bitcoin/pull/14033 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] DrahtBot closed pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:10 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:10 < bitcoin-git> [bitcoin] DrahtBot closed pull request #13472: [devtools translations] catch invalid specifiers (master...HashUnlimited-translate-1) https://github.com/bitcoin/bitcoin/pull/13472 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:10 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #13472: [devtools translations] catch invalid specifiers (master...HashUnlimited-translate-1) https://github.com/bitcoin/bitcoin/pull/13472 10:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:11 < bitcoin-git> [bitcoin] DrahtBot closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:11 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:11 < bitcoin-git> [bitcoin] DrahtBot closed pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578 10:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:12 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #12578: gui: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578 10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 10:30 -!- rex4539 [~rex4539@2a02:587:3511:5a00:429:ba08:bba6:fab9] has joined #bitcoin-core-dev 10:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 255 seconds] 10:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 10:45 < wumpus> wow what's drahtbot doing 10:45 < gwillen> I have been told that it periodically closes and reopens old PRs to get travis to re-run 10:45 < gwillen> although I feel like I don't remember seeing it do this before recently 10:45 < gwillen> perhaps the git integration could be taught to suppress those 10:47 < wumpus> it does, it's just that it goes kind of wild now 10:49 < wumpus> hmm maybe, some kind of debouncing, if a PR is reopened within N seconds of it being closed, ignore the event 10:51 < gwillen> that would work, it looks like it takes about 20 seconds 10:52 < gwillen> if you're already keeping state for that, you could also buffer events until it's been ~60 or 90 seconds without one, before you connect to IRC and send them all 10:52 < gwillen> to reduce the joins and parts 10:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:53 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 245 seconds] 10:54 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 11:00 -!- AimHere1 [~AimHere@185.204.1.185] has quit [] 11:00 < wumpus> right 11:04 -!- Gaz [~Gaz@84.39.117.57] has joined #bitcoin-core-dev 11:05 -!- Guest24808 [sid299882@gateway/web/irccloud.com/x-nwqumjratirxlbka] has quit [] 11:06 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-qbqcqqofdahwtgeg] has joined #bitcoin-core-dev 11:06 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:13 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:18 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 11:31 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:50 < bitcoin-git> [bitcoin] jamesob opened pull request #15976: refactor: move methods under CChainState (pt. 1) (master...2019-05-au-cchainstate) https://github.com/bitcoin/bitcoin/pull/15976 11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:09 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:10 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 12:16 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 12:17 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 12:20 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 12:26 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:29 < provoostenator> (I shadowbanned myself again, really need to fix my bouncer setup) 12:29 < sipa> ? 12:30 -!- juscamarena2 [2f94aac8@gateway/web/freenode/ip.47.148.170.200] has joined #bitcoin-core-dev 12:30 < provoostenator> Basically my IRC client shows my messages in the channel, but they don't actually show up. 12:30 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 12:30 < provoostenator> Until I do an /identify 12:30 < provoostenator> Whereas DMs work fine. 12:31 < provoostenator> This started happening on and off a weeks ago, so it's probably a useful security feature, just lack of error handling in client (Textual) 12:31 < sipa> sounds like you need a better irc client 12:32 < provoostenator> Indeed 12:32 < provoostenator> sipa: can you make a pull request to yourself with the "tapoot" brach, or a Draft pull request to Bitcoin Core? I find that easier to review than just a branch. 12:32 < provoostenator> PR description is also a nice place for "try these steps to test this" 12:32 < sipa> provoostenator: no, i think it's far too early for that 12:33 < provoostenator> Isn't that what the Draft feature is for? 12:33 < sipa> the code is there for demonstration, to see what kind of complexity is involved, but review at this point should be on the bip 12:33 < provoostenator> Right, it's tempting to review in too much detail, that makes sense. 12:44 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-qyucheftvkhqqsim] has quit [Quit: Connection closed for inactivity] 12:49 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 13:09 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 13:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 13:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 13:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 13:18 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 13:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:22 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13204: Faster sigcache nonce (master...faster-sigcache-nonce) https://github.com/bitcoin/bitcoin/pull/13204 13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:22 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 13:53 < jeremyrubin> jamesob: is there a tool you're using to auto-run those benchmarks? 13:53 < jamesob> jeremyrubin: a yet-to-be-release branch of https://github.com/chaincodelabs/bitcoinperf 13:54 < jamesob> going to package it up in the next few days (hopefully) 13:54 < jamesob> and then at some point maybe we'll have a service that'll autorun it based on presence of tag or something 13:55 < jeremyrubin> that is dope, good work! 13:55 < jamesob> jeremyrubin: thanks man! if you wanna fool around the branch is here: https://github.com/chaincodelabs/bitcoinperf/tree/ibd-improvements 14:00 -!- Gaz [~Gaz@84.39.117.57] has quit [] 14:04 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 14:04 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:05 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:05 -!- feedoo1 [~feedoo@185.178.49.150] has joined #bitcoin-core-dev 14:09 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 14:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 14:26 < gmaxwell> the drahbot thing makes ordering prs by activity suck, btw. 14:29 < luke-jr> :< 14:29 < luke-jr> why can't it just trigger Travis restarts directly? 14:35 < gmaxwell> jamesob: thansk for benchmarking that PR. It'll be interesting if its not actually faster (as that woudl imply copying a hasher is slower than creating one plus one compression run ... which if its true suggests something else needs to be fixed). This is why we test, of course. 14:36 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 14:37 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 14:38 -!- BGL [thirty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 258 seconds] 14:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:41 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 14:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:43 -!- rex4539 [~rex4539@2a02:587:3511:5a00:429:ba08:bba6:fab9] has quit [Quit: rex4539] 14:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:43 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 244 seconds] 14:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 14:51 -!- kexkey [~kexkey@5.181.233.22] has quit [Ping timeout: 246 seconds] 14:51 < achow101> luke-jr: how would it? 14:52 < achow101> i don't think you can have travis start a build on a pr as if a new commit was pushed. iirc the point of closing and reopening triggers travis to do a new build which means it will use the merge commit with the current master which is what we want 14:56 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 14:56 -!- Aaronvan_ is now known as AaronvanW 15:07 < jamesob> gmaxwell: sure thing. Left another bench running against the rebase, but afk. Will report back 15:15 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 15:16 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:29 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 15:38 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:46 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:52 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 15:53 -!- boipiecer [55d377ca@gateway/web/freenode/ip.85.211.119.202] has joined #bitcoin-core-dev 15:54 -!- boipiecer [55d377ca@gateway/web/freenode/ip.85.211.119.202] has quit [Client Quit] 15:56 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 16:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:13 -!- BGL [eighty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:17 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 16:19 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 16:20 < fanquake> Surely we'd be able to use something like https://docs.travis-ci.com/user/triggering-builds/ ? 16:26 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.] 16:34 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 16:38 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 16:39 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 16:42 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 16:44 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 250 seconds] 16:51 -!- juscamarena2 [2f94aac8@gateway/web/freenode/ip.47.148.170.200] has quit [Ping timeout: 256 seconds] 16:55 -!- laptop500 [~laptop@host86-128-184-5.range86-128.btcentralplus.com] has quit [Ping timeout: 268 seconds] 16:55 -!- scoop [~scoop@2601:240:d700:b3a:15b5:ec97:289c:b060] has joined #bitcoin-core-dev 16:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:58 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 17:00 -!- scoop [~scoop@2601:240:d700:b3a:15b5:ec97:289c:b060] has quit [Ping timeout: 252 seconds] 17:00 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds] 17:00 -!- feedoo1 [~feedoo@185.178.49.150] has quit [] 17:17 -!- rlaager1 [~rlaager@184.75.223.195] has joined #bitcoin-core-dev 17:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:24 -!- chriswang2019 [~Mutter@2409:8954:688:6051:f8df:505b:f0c:688f] has joined #bitcoin-core-dev 17:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 17:35 -!- chriswang2019 [~Mutter@2409:8954:688:6051:f8df:505b:f0c:688f] has quit [Ping timeout: 252 seconds] 17:55 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 17:57 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 17:59 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:01 -!- side^effects [~al|iss@gateway/tor-sasl/aliss/x-63218493] has quit [Remote host closed the connection] 18:05 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 18:06 < promag> an alternative to force the build is to redeliver the webhook, however there's no official API for this. But I think it should be possible by using GET https://github.com/hooks/$HOOK_ID/deliveries and POST https://github.com/hooks/$HOOK_ID/deliveries/$DELIVERY_ID/redeliver with the right headers 18:07 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 18:07 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 18:07 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:28 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev 18:30 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 18:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:33 < bitcoin-git> [bitcoin] dongcarl opened pull request #15978: .gitignore: Don't ignore depends patches (master...2019-05-no-ignore-depends-patches) https://github.com/bitcoin/bitcoin/pull/15978 18:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:33 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 18:34 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 18:35 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 18:36 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 18:36 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:59 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 19:06 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 19:43 < luke-jr> achow101: the travis restart thing won't? 19:45 < achow101> restarting a job will just use the same commit for that job 19:45 < achow101> you'd need to trigger a new build for the pr, which isn't possible at least from the web ui 19:46 < luke-jr> what if we modify our travis scripts to fetch master explicitly? 19:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 20:00 -!- rlaager1 [~rlaager@184.75.223.195] has quit [] 20:05 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 20:18 -!- aowi [~aowi@184.75.223.195] has joined #bitcoin-core-dev 20:29 < gmaxwell> luke-jr: re your list post, "If that is inacceptable, pick as internal key a point with unknown discrete logarithm." there is no reason your forced to have a everyone agress bypass. 21:20 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 21:58 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:58 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 22:29 -!- murchandamus [murch@sf1.hashbang.sh] has left #bitcoin-core-dev [] 22:32 -!- murch [murch@sf1.hashbang.sh] has joined #bitcoin-core-dev 22:32 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 22:33 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds] 22:36 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 22:42 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 22:49 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:00 -!- aowi [~aowi@184.75.223.195] has quit [] 23:04 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 23:20 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:22 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:22 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:23 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:23 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:24 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:25 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 252 seconds] 23:25 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:26 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:26 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:27 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:28 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:29 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:29 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:30 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:31 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:32 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:32 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has joined #bitcoin-core-dev 23:33 < tryphe> i noticed there's not a lot of usage of 'const' in a lot of bitcoin code where there could be. is this for readability purposes, or are changes welcome? 23:34 -!- hyperwang [~hyper@98.142.137.78.16clouds.com] has quit [Remote host closed the connection] 23:35 -!- feth1 [~feth@84.39.117.57] has joined #bitcoin-core-dev 23:36 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:36 < sipa> tryphe: we reject patches that only improve coding stylr 23:36 < sipa> *style 23:37 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:37 < tryphe> sipa, i was thinking of an improvement like so: say you pass a pointer to a thread, and you expect the pointer to be accessed non-const but the address value to not be modified. now you could enforce that with coverage tests and stuff. 23:38 < tryphe> gah, thread/function* 23:38 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:38 < tryphe> whereas if you don't enforce it, you won't know if you accidentally modified a value 23:39 < sipa> yes, improving that is great, but it is very low priority noise compared to other potential changes 23:39 < sipa> and review time is limited and precious 23:39 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 252 seconds] 23:39 < tryphe> true, but in terms of undefined behavior i think it could be helpful 23:40 < gwillen> adding "const" feels like it should be slightly different from "mere style" changes, since it's functional rather than aesthetic, and any instance the compiler accepts is almost surely correct 23:40 < gwillen> (so review effort ought to be limited) 23:40 < sipa> if you actually find an issue, for example by adding const where you expect it to work and it doesn't, it is different 23:40 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 23:40 < tryphe> (i realized it's impractical to change this though, there's a crapload of changes that would need be done to enforce this example above) 23:40 < gwillen> *nods* 23:41 < sipa> but adding const in places where the code already works has no effect except add assurances 23:41 < tryphe> alright, that makes sense. i guess there's enough tests anyways to catch most issues. 23:42 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:42 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:43 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:43 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 23:44 < gmaxwell> you can also introduce bugs by peppering around const, so it's not like those changes are free to review, even ignoring the effect on change flow. 23:44 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:45 < sipa> in general adding const can't have too much effect if the code works both before and after... but there are some 23:45 < sipa> for example moving a const argument will silently introduce a (deep) copy of certain objects, where a move was expected 23:45 < tryphe> yeah, the problem is knowing the intent of the code you are modifying 23:45 < sipa> tryphe: exactly! 23:46 < sipa> adding such things where they are intended is great, but adding them mechanically is mostly useless without careful review of every individual case 23:47 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:48 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:48 < gmaxwell> That is also a general problem with broad 'cleanup' changes, they're done without much understanding or care about the code they're changing. 23:49 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:50 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:51 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:51 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:52 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:53 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:54 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:55 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:56 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:56 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:57 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:58 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev 23:58 -!- blkwolf [47ea67fc@gateway/web/freenode/ip.71.234.103.252] has joined #bitcoin-core-dev 23:59 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has quit [Remote host closed the connection] 23:59 -!- hyperwang [~hyper@98.142.141.216.16clouds.com] has joined #bitcoin-core-dev --- Log closed Wed May 08 00:00:06 2019