--- Log opened Thu May 09 00:00:07 2019 00:01 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 00:02 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 00:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 00:19 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 00:31 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 00:32 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:47 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Remote host closed the connection] 00:48 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 00:49 -!- ccdle12 [~ccdle12@103.5.140.189] has joined #bitcoin-core-dev 00:53 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Remote host closed the connection] 00:56 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 00:59 -!- knight__ [uid365001@gateway/web/irccloud.com/x-rlmrobvmbcwpedll] has joined #bitcoin-core-dev 00:59 -!- ccdle12 [~ccdle12@103.5.140.189] has quit [Ping timeout: 248 seconds] 00:59 -!- ccdle12 [~ccdle12@103.5.140.189] has joined #bitcoin-core-dev 01:00 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 01:01 -!- laptop500 [~laptop@host86-128-184-5.range86-128.btcentralplus.com] has joined #bitcoin-core-dev 01:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:14 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Read error: Connection reset by peer] 01:18 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:39 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 01:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 01:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 01:50 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:52 -!- ccdle12_ [~ccdle12@103.5.140.189] has joined #bitcoin-core-dev 01:52 -!- ccdle12 [~ccdle12@103.5.140.189] has quit [Read error: Connection reset by peer] 01:55 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 02:00 -!- jungnam [~jungnam@84.39.117.57] has quit [] 02:03 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 02:05 -!- hashist [~hashist@157.157.113.175] has quit [Quit: Defaultly Leaving] 02:12 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 248 seconds] 02:19 < booyah> perhaps tests should be run few times, for normal build, for ASAN, for UBSAN+TSAN 02:22 -!- jpthor [~jpthor@144.132.69.213] has joined #bitcoin-core-dev 02:28 -!- ccdle12_ [~ccdle12@103.5.140.189] has quit [Remote host closed the connection] 02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:31 -!- sunetoft [~sunetoft@89.238.178.75] has joined #bitcoin-core-dev 02:38 -!- jpthor [~jpthor@144.132.69.213] has quit [] 02:39 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 02:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:53 < gmaxwell> sipa: fun fact, buggy cpus exist where rdrand actually returns an error https://github.com/systemd/systemd/issues/11810#issuecomment-490165413 (also fun fact, systemd apparently iplements is own 'rng' call that uses rdrand only when available, and is caused to fail by this) 02:55 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 02:59 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 03:10 -!- sunetoft [~sunetoft@89.238.178.75] has quit [Remote host closed the connection] 03:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:14 -!- aljungberg [~aljungber@173.209.57.12] has joined #bitcoin-core-dev 03:16 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 03:16 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 03:19 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Read error: Connection reset by peer] 03:19 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 03:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:22 < wumpus> this was just a matter of time, using RDRAND only always was a bad idea 03:24 < wumpus> good for them the chip start returnsing an error instead of just predictable data 03:24 < wumpus> that would have been a much more subtle and hard to detect scenario 03:26 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 03:26 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:cdf6:3da6:b96e:f366] has joined #bitcoin-core-dev 03:27 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 03:27 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has joined #bitcoin-core-dev 03:29 < gmaxwell> yeah, it returns an error, but most code doesn't check. 03:30 < gmaxwell> We recently added checks for the error condition because I went and read the intel docs, previously the code was just modeled after code sipa read elsewhere. (for our use, it's less critical to do any error handling) 03:31 < wumpus> right, failing to check is a less serious issue if it's only one of many randomness sources used, although you'd still want to detect "all random sources failed" 03:31 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Ping timeout: 245 seconds] 03:34 < gmaxwell> unfortunately some sources are "cannot ever fail" which of course means there is no way to tell if they failed. :P 03:34 < wumpus> https://software.intel.com/en-us/blogs/2014/01/13/rdrand-do-i-need-to-check-the-carry-flag-or-can-i-just-check-for-zero this makes my head hurt, apparently early RDRAND implementations could not return 0 as an actual random value 03:35 < gmaxwell> yep. 03:35 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:35 < gmaxwell> which is obnoxious when you really want actually uniform randomness, not close but no cigar uniformity. 03:35 < wumpus> at least it's 64 bit so a value of 0 is *very* unlikely, this is much worse for 32 bit APIs (where I've seen this too), but it's a stupid kind of bias 03:36 < wumpus> yes 03:40 < gmaxwell> the stm32 stuff seemed moderately concerning to me. (stuff in the trezor) 03:41 < gmaxwell> with weird rules about not using the first value out, and strange comments refreencing a LFSR... 03:44 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has quit [Quit: WeeChat 2.4] 03:44 < wumpus> ouch 03:49 < wumpus> you can generally trust hardware vendors to do the cheapest thing possible that they can get away with for ancillary functions like hw rng, in any case it's a black box, the most surprising thing is a way-too-common assumption "it's hardware randomness so it must be good!" 03:52 < wumpus> having some unlocked PLL feed into a LFSR sounds like a nice and cheap solution to get some random-ish output 04:05 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 04:10 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 252 seconds] 04:27 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 04:27 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:30 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15988: Add test for ArgsManager::GetChainName (master...pr/testset2) https://github.com/bitcoin/bitcoin/pull/15988 04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:33 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 04:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 04:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:57 < fanquake> hey wumpus. 15766, 15794 & 15452 probably mergable 05:00 -!- aljungberg [~aljungber@173.209.57.12] has quit [] 05:02 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 05:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:06 -!- quaid1 [~quaid@184.75.223.195] has joined #bitcoin-core-dev 05:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 05:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:24 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:cdf6:3da6:b96e:f366] has quit [Quit: Sleep mode] 05:29 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:cdf6:3da6:b96e:f366] has joined #bitcoin-core-dev 05:40 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 05:43 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has joined #bitcoin-core-dev 05:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:50 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has quit [Ping timeout: 256 seconds] 05:51 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 05:52 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Read error: Connection reset by peer] 05:53 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 05:59 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 06:00 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:1cdd:e45c:1701:46c0] has joined #bitcoin-core-dev 06:00 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 06:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:19 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:19 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has joined #bitcoin-core-dev 06:20 -!- ExEric3 [~exeric3@45.67.159.11] has quit [Ping timeout: 246 seconds] 06:23 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 06:56 -!- ccdle12_ [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 06:57 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Read error: Connection reset by peer] 06:58 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 06:59 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:1cdd:e45c:1701:46c0] has quit [Ping timeout: 252 seconds] 07:10 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:16 < bitcoin-git> [bitcoin] hebasto opened pull request #15989: RPC: Do not use cookie auth if -rpcauth set (master...20190509-rpcauth) https://github.com/bitcoin/bitcoin/pull/15989 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:28 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has quit [Ping timeout: 256 seconds] 07:30 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15990: Add tests and documentation for blocksonly (master...1905-docTestBlocksOnly) https://github.com/bitcoin/bitcoin/pull/15990 07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:40 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:42 -!- ccdle12_ [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Remote host closed the connection] 07:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:53 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 07:54 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 08:00 -!- quaid1 [~quaid@184.75.223.195] has quit [] 08:04 -!- quaid1 [~quaid@184.75.223.195] has joined #bitcoin-core-dev 08:08 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 08:11 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 08:11 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 08:12 -!- kevinrya_ [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 08:12 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Read error: Connection reset by peer] 08:17 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Remote host closed the connection] 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:30 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/08788ce1701a...a65fd92f7b8e 08:30 < bitcoin-git> bitcoin/master beda0da Hennadii Stepanov: Upgrade gitian image before signing 08:30 < bitcoin-git> bitcoin/master a65fd92 Wladimir J. van der Laan: Merge #15766: scripts and tools: Upgrade gitian image before signing 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:31 < bitcoin-git> [bitcoin] laanwj merged pull request #15766: scripts and tools: Upgrade gitian image before signing (master...20190407-gitian-upgrade-image) https://github.com/bitcoin/bitcoin/pull/15766 08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:35 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 08:36 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:36 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:38 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15991: Bugfix: fix pruneblockchain returned prune height (master...2019/05/pruning_test) https://github.com/bitcoin/bitcoin/pull/15991 08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:40 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: leaving] 08:47 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:04 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a65fd92f7b8e...aebe990dfeb4 09:04 < bitcoin-git> bitcoin/master f4a230b Carl Dong: docs: Clarify PR guidelines w/re documentation 09:04 < bitcoin-git> bitcoin/master aebe990 Wladimir J. van der Laan: Merge #15794: docs: Clarify PR guidelines w/re documentation 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:05 < bitcoin-git> [bitcoin] laanwj merged pull request #15794: docs: Clarify PR guidelines w/re documentation (master...2019-04-doc-doc) https://github.com/bitcoin/bitcoin/pull/15794 09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:11 -!- kevinrya_ [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Remote host closed the connection] 09:13 -!- WalkingCoin [276dd379@gateway/web/freenode/ip.39.109.211.121] has joined #bitcoin-core-dev 09:14 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has joined #bitcoin-core-dev 09:18 -!- kevinryan [~kevinryan@hellofresh-gw.bsa1-r1.syseleven.net] has quit [Ping timeout: 258 seconds] 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:27 < bitcoin-git> [bitcoin] Empact opened pull request #15992: Refactor (master...relay-inventory) https://github.com/bitcoin/bitcoin/pull/15992 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:28 -!- promag_ [~promag@83.223.250.190] has joined #bitcoin-core-dev 09:31 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 09:40 -!- WalkingCoin [276dd379@gateway/web/freenode/ip.39.109.211.121] has quit [Ping timeout: 256 seconds] 09:41 < hebasto> promag: hi, could you elaborate your latest comment in #15684? 09:41 < gribble> https://github.com/bitcoin/bitcoin/issues/15684 | doc/dependencies: Fix typo libsrvg->librsvg by luke-jr · Pull Request #15684 · bitcoin/bitcoin · GitHub 09:42 < hebasto> The main purpose of GetDataDir() is to create the datadir, right? 09:43 < hebasto> promag: #15864 not 15684 09:43 < gribble> https://github.com/bitcoin/bitcoin/issues/15864 | Fix datadir handling by hebasto · Pull Request #15864 · bitcoin/bitcoin · GitHub 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] hebasto opened pull request #15993: net: Drop the ancient miniUPnPc API version support (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:50 -!- roconnor [~roconnor@host-184-164-20-227.dyn.295.ca] has quit [Ping timeout: 248 seconds] 09:52 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds] 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:55 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/aebe990dfeb4...de5af41e3567 09:55 < bitcoin-git> bitcoin/master 70946e7 Gregory Sanders: Replace CScriptID and CKeyID in CTxDestination with dedicated types 09:55 < bitcoin-git> bitcoin/master 78e407a Gregory Sanders: GetKeyBirthTimes should return key ids, not destinations 09:55 < bitcoin-git> bitcoin/master de5af41 Wladimir J. van der Laan: Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicate... 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:55 < bitcoin-git> [bitcoin] laanwj merged pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:01 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:05 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:14 -!- roconnor [~roconnor@host-184-164-20-227.dyn.295.ca] has joined #bitcoin-core-dev 10:14 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:cdf6:3da6:b96e:f366] has quit [Quit: Sleep mode] 10:21 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:24 -!- Flatbyte [Flatbeat@lns-bzn-46-82-253-245-169.adsl.proxad.net] has joined #bitcoin-core-dev 10:25 -!- promag_ [~promag@83.223.250.190] has quit [Remote host closed the connection] 10:26 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 10:26 -!- promag_ [~promag@83.223.250.190] has joined #bitcoin-core-dev 10:30 -!- Flatbyte [Flatbeat@lns-bzn-46-82-253-245-169.adsl.proxad.net] has quit [] 10:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 10:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:37 -!- promag_ [~promag@83.223.250.190] has quit [Remote host closed the connection] 10:38 -!- ExEric3 [~exeric3@45.67.159.11] has joined #bitcoin-core-dev 10:40 -!- Flatbyte [flatbyte@lns-bzn-46-82-253-245-169.adsl.proxad.net] has joined #bitcoin-core-dev 10:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 10:59 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 11:00 -!- quaid1 [~quaid@184.75.223.195] has quit [] 11:11 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 11:14 < harding> sipa: will OP_CLTV and OP_CSV still require OP_DROP in tapscript? If so, it seems a tiny bit unfair counting that as two opcodes towards the opcode limit (although that seems like a very minor unfairness). 11:15 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 11:22 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:26 -!- roconnor [~roconnor@host-184-164-20-227.dyn.295.ca] has quit [Ping timeout: 245 seconds] 11:27 -!- scoop [~scoop@50-77-133-26-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 11:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 11:32 -!- gdude2002 [~gdude2002@184.75.223.195] has joined #bitcoin-core-dev 11:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 11:34 < sipa> harding: yes 11:39 -!- hashist [~hashist@157.157.113.89] has joined #bitcoin-core-dev 11:39 -!- hashist [~hashist@157.157.113.89] has left #bitcoin-core-dev [] 11:39 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds] 11:46 -!- Flatbyte [flatbyte@lns-bzn-46-82-253-245-169.adsl.proxad.net] has quit [] 11:46 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev 11:56 < moneyball> wumpus: fyi one topic was proposed the past week ... topic proposed by MarcoFalke: windows 32 bit 11:57 < wumpus> ok 11:57 < wumpus> thanks ! 11:57 < sipa> harding: there are many 'unfair' things in the scripting language i'm sure and nits to improve, but i fear a bikeshedding fest if we go into those 11:58 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:59 -!- nkohen [~nkohen@2603:300b:50b:7300:e9ba:82c2:a584:c735] has joined #bitcoin-core-dev 12:00 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 255 seconds] 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu May 9 19:01:18 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < jonasschnelli> hi 12:02 < sipa> hi 12:02 < achow101> hi 12:02 < luke-jr> hello there 12:02 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral 12:02 < Chris_Stewart_5> hello 12:02 < meshcollider> hi 12:03 < wumpus> any proposed topics? 12:03 < wumpus> (besides moneyball's) 12:03 < MarcoFalke> hi 12:03 < luke-jr> MarcoFalke's* 12:04 < kanzure> hi 12:04 < kanzure> i have a small topic later about topics 12:04 < luke-jr> ._. 12:04 < kanzure> it's just topic collection for upcoming physical meeting. 12:04 < wumpus> #topic high priority for review 12:05 < wumpus> currently: #15427 #15024 #15006 #15512 #15870 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15870 | wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke · Pull Request #15870 · bitcoin/bitcoin · GitHub 12:06 < wumpus> anything to add/remove/remark? 12:06 < instagibbs> hi 12:06 < sipa> looks good to me, i'll try to go through those soon 12:06 < wumpus> thanks 12:08 < wumpus> that's all about this topic, I guess 12:08 < wumpus> please help review those ^^ 12:08 < wumpus> #topic windows 32 bit (MarcoFalke) 12:09 < MarcoFalke> There has been at least one user who is running Bitcoin Core on windows 32 bit 12:09 < wumpus> #15939 12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/15939 | gitian: Remove Windows 32 bit build by MarcoFalke · Pull Request #15939 · bitcoin/bitcoin · GitHub 12:09 < MarcoFalke> I didn't expect that initially 12:09 -!- _jnewbery [b84af09c@gateway/web/freenode/ip.184.74.240.156] has joined #bitcoin-core-dev 12:09 < wumpus> I've said what I wanted to say here: https://github.com/bitcoin/bitcoin/pull/15939#issuecomment-489568065 12:09 < luke-jr> MarcoFalke: does Windows still support 32-bit only? 12:10 < MarcoFalke> Windows 10 can be installed as 32 bit 12:10 < luke-jr> on 32-bit only CPUs? 12:10 < wumpus> e.g. there's good reason to only support MacOS and Windows on one architecture 12:11 < jonasschnelli> Yes 12:11 < MarcoFalke> So we ask users to upgrade their windows to 64 bit or buy new hardware? 12:11 < jonasschnelli> Also,... do we care about that "one" user? 12:11 < wumpus> that there's one windows 32 user left, well, I'm sorry for them :( 12:11 < MarcoFalke> A lot might be shy to report 12:12 < wumpus> come on, the last x86 hardware that didn't support 64 bit is from 2005 or so? 12:12 < wumpus> you can buy a raspberry pi 3 for <$100 and have faster hardware 12:12 -!- roconnor [~roconnor@host-184-164-20-227.dyn.295.ca] has joined #bitcoin-core-dev 12:12 < wumpus> and 64 bit ARM, at that 12:13 < MarcoFalke> Yeah 12:13 < wumpus> so, yeah, let's drop it 12:13 < booyah> why not support, is it about resources to gitian build? 12:13 < MarcoFalke> Enough for this topic 12:13 < wumpus> no, read my post 12:13 < MarcoFalke> booyah: No, testing 12:13 < wumpus> computer resources don't matter 12:13 -!- esnapolinaire [6d4533b2@gateway/web/freenode/ip.109.69.51.178] has joined #bitcoin-core-dev 12:13 < sipa> in 2011 apparently the last general computing intel cpu that was 32-bit only was introduced (some atom) 12:14 < wumpus> yes... so.. next topic 12:14 < luke-jr> booyah: the question at the end of the day is, if there's a problem, is anyone willing to deal with it? 12:14 < MarcoFalke> [15:04] i have a small topic later about topics 12:14 < wumpus> #topic a topic about topics (kanzure) 12:14 < achow101> there was at least one complaint about win32 support on bitcointalk. 12:14 < ryanofsky> are there 32 bit versions of windows running on 64 bit hardware that can now no longer run bitccoin? 12:15 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 12:15 -!- esnapolinaire [6d4533b2@gateway/web/freenode/ip.109.69.51.178] has left #bitcoin-core-dev [] 12:15 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-ezvbbrgvlkmwxjmy] has joined #bitcoin-core-dev 12:15 < MarcoFalke> achow101: Link? 12:15 < luke-jr> if anyone is willing to support Win32, we should keep supporting it; if not, we can't realistically :p 12:15 < meshcollider> Presumably there'd be at least a few out there 12:16 < achow101> MarcoFalke: https://bitcointalk.org/index.php?topic=5139689.0 although I'm not sure whether the OP is just wondering why there is no win32 or whether they need win32 12:16 < wumpus> so the question is: is anyone willing to test and support windows 32, an debug problems that happen on it? 12:16 < ryanofsky> ok just responding to sipa's note about 2011 hardware, wondering if the last 32 bit windows was also released around that time or if it would matter 12:16 < wumpus> if no, it doesn't matter that 1 or 2 people are still using it 12:17 < luke-jr> I suppose there's a side question of: does testing Win32 identify any general code issues that other tests don't? 12:17 < ryanofsky> ok happy to move on 12:17 < achow101> ryanofsky: windows still makes 32 bit releases. you can download windows 10 32 bit 12:17 < wumpus> yes, let's move on 12:17 < wumpus> kanzure: you had a topic? 12:17 -!- kexkey [~kexkey@5.181.233.22] has joined #bitcoin-core-dev 12:18 < wumpus> luke-jr: not more than ARM or Linux x86 32 identifies 12:19 < sipa> arguably win64 should catch more things (it's the only 64 bit platform where a 'long' is 32 bits) 12:20 < sipa> kanzure: ^ 12:21 < luke-jr> I think he just wanted to solicit topics for Amsterdam 12:21 < MarcoFalke> close meeting? 12:21 < wumpus> #endmeeting 12:21 < lightningbot> Meeting ended Thu May 9 19:21:46 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:21 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.html 12:21 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.txt 12:21 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-09-19.01.log.html 12:21 < sipa> let's assume he does, so #action: send topics for Amsterdam to kanzure 12:21 < sipa> i like these short meetings 12:22 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 12:22 < gwillen> so in principle, people still on 32-bit windows could build it htemselves, right? 12:22 < gwillen> (except it's probably a big pain in the ass) 12:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:22 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/de5af41e3567...79046d574980 12:22 < bitcoin-git> bitcoin/master faf666f MarcoFalke: Remove Windows 32 bit build 12:22 < bitcoin-git> bitcoin/master fa193dc MarcoFalke: doc: Remove win32 from the release process 12:22 < bitcoin-git> bitcoin/master 79046d5 Wladimir J. van der Laan: Merge #15939: gitian: Remove Windows 32 bit build 12:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:23 < wumpus> gwillen: maybe? does MSVC still support 32 bit? 12:23 < MarcoFalke> msvc is only for debug builds 12:23 < gwillen> well, if they're on a 32-bit platform they probably have an old MSVC to go with it 12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:23 < bitcoin-git> [bitcoin] laanwj merged pull request #15939: gitian: Remove Windows 32 bit build (master...1904-GitianWin) https://github.com/bitcoin/bitcoin/pull/15939 12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:23 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 12:24 < kanzure> sipa: yeah that's all it was, i thought it didn't need explanation :) 12:25 < wumpus> pretty sure sipsorcery & other MSVC builders only use windows 64, too, also, anything x86 32-bit-only is going to be too slow to either compile bitcoin core or do the initial sync 12:26 < wumpus> it's just a non issue 12:28 < gmaxwell> luke-jr: are you going to provide win32 builds of knots? 12:28 < luke-jr> gmaxwell: I am presently. I might so long as they continue to build, TBD 12:29 < luke-jr> (and then just drop them when they fail to build or someone reports them broken) 12:29 < instagibbs> If I were to remove bumpfee's totalFee argument, should I put it behind deprecation for a single release? 12:29 < instagibbs> just in case someone actually uses it? 12:29 < gmaxwell> I agree with wumpus on this but I also agree that a few complaints mean that there probably are a fair number of users, it would be nice if they had options. 12:30 < luke-jr> I suppose when there's something broken, we can always revisit the topic then 12:30 -!- _jnewbery [b84af09c@gateway/web/freenode/ip.184.74.240.156] has quit [Quit: Page closed] 12:31 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 12:32 < ryanofsky> instagibbs, that seems like a good idea assuming it's not difficult to do 12:33 < wumpus> instagibbs: yes, that'd be the normal way to do it, deprecate it for one release then remove it the next 12:33 < instagibbs> is there a doc on deprecation procedure or a great example? 12:33 < instagibbs> of something in master 12:35 < luke-jr> git grep Deprec 12:36 < instagibbs> ok seems to be one example in master, thanks 12:36 < wumpus> deprecation can be as simple as mentioning it in the RPC help for the method and in the release notes 12:37 < wumpus> there's also IsDeprecatedRPCEnabled(...) but that's for deprecating entire entry points, not individual arguments 12:38 < instagibbs> looks like it's used for hiding "size" value of mempool entries under "size" label 12:39 < gwillen> luke-jr: my guess is the answer for people complaining will be "you can upgrade one final time to knots 0.18, and if you ever need 0.19 you're probably on your own" 12:40 < gwillen> and given that older versions will continue to function for a long time unless there are major forking changes in the future, and even then should somewhat function 12:40 < gwillen> this doesn't seem unreasonable 12:41 < luke-jr> I don't really expect Win32 to break unless we go out of the way to break it, anyway 12:42 < luke-jr> so it might even work with 0.19 *shrug* 12:42 < ryanofsky> i think it'd be fine to use IsDeprecatedRPCEnabled / Chain::rpcEnableDeprecated, it just needs a string describing the deprecated feature, not necessary a method name 12:44 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 12:48 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 252 seconds] 13:06 < jonasschnelli> would someone be opposed to add a generatetowallet call? 13:07 < wumpus> didn't we deprecate mining to wallet only very shortly ago? 13:07 < wumpus> (or rather, even, remove) 13:09 -!- omonk [~omonk@unaffiliated/omonk] has quit [Read error: Connection reset by peer] 13:10 < instagibbs> it was *just* removed 13:10 < instagibbs> lol 13:10 < ryanofsky> i think part of the motivation for #15492 was that non-wallet code was calling wallet code 13:10 < gribble> https://github.com/bitcoin/bitcoin/issues/15492 | [rpc] remove deprecated generate method by Sjors · Pull Request #15492 · bitcoin/bitcoin · GitHub 13:12 < ryanofsky> so if the call was handled in the wallet, maybe it would be ok? 13:12 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 13:12 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 13:14 < wumpus> generate is only used in test code isn't it? I'm not sure it warrants adding additional RPCs 13:14 < instagibbs> it's very easy to chain generatetoaddress with getnewaddress, imo 13:14 < instagibbs> functional tests implicitly do this already 13:15 < wumpus> right 13:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:37 -!- nkohen [~nkohen@2603:300b:50b:7300:e9ba:82c2:a584:c735] has quit [Quit: Leaving] 13:41 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:42 < bitcoin-git> [bitcoin] sipsorcery opened pull request #15995: systemd service script: set usable permissions on /etc/bitcoin config dir (master...systemdconfig) https://github.com/bitcoin/bitcoin/pull/15995 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:46 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:48 < bitcoin-git> [bitcoin] instagibbs opened pull request #15996: Deprecate totalfee argument in `bumpfee` (master...deprecate_totalfee) https://github.com/bitcoin/bitcoin/pull/15996 13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:55 < bitcoin-git> [bitcoin] promag opened pull request #15997: refactor: GuessVerificationProgress requires cs_main lock (master...2019-05-gvp) https://github.com/bitcoin/bitcoin/pull/15997 13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 -!- gdude2002 [~gdude2002@184.75.223.195] has quit [] 14:03 -!- KaizenNaka [~Kaizen@ip5f5bd725.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 14:12 -!- tss1 [~tss@178.162.209.171] has joined #bitcoin-core-dev 14:12 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 14:13 -!- tryphe_ is now known as tryphe 14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:30 < bitcoin-git> [bitcoin] promag opened pull request #15998: refactor: Drop trivial X macro (master...2019-05-x) https://github.com/bitcoin/bitcoin/pull/15998 14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 14:33 -!- KaizenNaka [~Kaizen@ip5f5bd725.dynamic.kabel-deutschland.de] has quit [Ping timeout: 246 seconds] 14:34 -!- bushstar [~bushstar@host109-155-240-208.range109-155.btcentralplus.com] has quit [Ping timeout: 246 seconds] 14:35 -!- Tralfaz [~androirc@104.254.90.187] has joined #bitcoin-core-dev 14:36 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 14:37 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection] 14:37 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection] 14:39 -!- Tralfaz [~androirc@104.254.90.187] has quit [Client Quit] 14:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:55 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15999: init: Remove dead code in LoadChainTip (master...1905-initNoDead) https://github.com/bitcoin/bitcoin/pull/15999 14:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:01 -!- rhavar [uid237883@gateway/web/irccloud.com/x-ggiiolrtrvgkezif] has joined #bitcoin-core-dev 15:07 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:09 -!- emzy [~quassel@unaffiliated/emzy] has quit [Ping timeout: 258 seconds] 15:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:09 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15998: refactor: Drop trivial X macro (master...2019-05-x) https://github.com/bitcoin/bitcoin/pull/15998 15:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:12 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15933: Make chain state immutable outside of validation (master...1905-immVal) https://github.com/bitcoin/bitcoin/pull/15933 15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:16 < MarcoFalke> Someone should add the `generate` method to the gui 15:16 < MarcoFalke> Would save me a lot of typing 15:18 < MarcoFalke> #16000 15:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16000 | GUI: Add generate method · Issue #16000 · bitcoin/bitcoin · GitHub 15:19 < sipa> heh? 15:20 < sipa> any reason to specifically have that in the GUI? 15:20 < sipa> seems much easier to automate through RPC 15:24 < gmaxwell> maybe you should make it run it if you click the bitcoin logo ten times in quick succession. 15:25 < MarcoFalke> Lol, I am not trolling. It was removed from the rpc 15:27 < luke-jr> what is the use case⁇? 15:27 < sipa> MarcoFalke: a bash oneliner will work fin? 15:27 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 15:28 < MarcoFalke> Excuse me? I am not using bash, that is for peasants 15:28 < sipa> lol 15:29 < MarcoFalke> I run my tests in the gui because it has autocomplete 15:30 * sipa checks if this is actually MarcoFalke 15:30 < luke-jr> >implying bash doesn't autocomplete 15:30 < luke-jr> how do you even run the tests in the GUI? 15:30 < gmaxwell> I doubt anyone has created a bash-completion module for bitcoin-cli :) 15:31 < MarcoFalke> I mean manual tests 15:31 < luke-jr> gmaxwell: it's in the git repo.. 15:31 < MarcoFalke> to run the functional tests in the gui you pass BITCOIND=bitcoin-qt 15:31 < gmaxwell> luke-jr: oh lol 15:32 < luke-jr> has been for years 15:32 < luke-jr> it just queries bitcoin-cli for the possible commands 15:32 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:35 -!- knight__ [uid365001@gateway/web/irccloud.com/x-rlmrobvmbcwpedll] has quit [Ping timeout: 258 seconds] 15:35 -!- knight__ [uid365001@gateway/web/irccloud.com/x-gbwovmvzcpppzcib] has joined #bitcoin-core-dev 15:38 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test] 15:49 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:59 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 248 seconds] 15:59 -!- bushstar [~bushstar@host109-155-240-208.range109-155.btcentralplus.com] has joined #bitcoin-core-dev 16:02 -!- laptop500 [~laptop@host86-128-184-5.range86-128.btcentralplus.com] has quit [Ping timeout: 248 seconds] 16:04 -!- bushstar [~bushstar@host109-155-240-208.range109-155.btcentralplus.com] has quit [Ping timeout: 252 seconds] 16:18 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 16:21 -!- jtash [~jtash@167.99.100.71] has joined #bitcoin-core-dev 16:21 -!- jtash [~jtash@167.99.100.71] has quit [Client Quit] 16:22 -!- jtash [~jtash@167.99.100.71] has joined #bitcoin-core-dev 16:24 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 16:26 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test] 16:35 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:81f1:489:2071:c8e1] has joined #bitcoin-core-dev 16:37 -!- jtash [~jtash@167.99.100.71] has quit [Quit: ZNC 1.7.3 - https://znc.in] 16:39 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 16:40 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 16:44 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 16:49 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds] 16:49 -!- cc [b4be2fa4@gateway/web/freenode/ip.180.190.47.164] has joined #bitcoin-core-dev 16:49 -!- cc is now known as Guest80232 16:50 -!- Guest80232 [b4be2fa4@gateway/web/freenode/ip.180.190.47.164] has quit [Client Quit] 16:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:53 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 16:59 -!- kexkey [~kexkey@5.181.233.22] has quit [Ping timeout: 258 seconds] 17:00 -!- tss1 [~tss@178.162.209.171] has quit [] 17:01 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:81f1:489:2071:c8e1] has quit [Quit: Sleep mode] 17:03 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 245 seconds] 17:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 17:05 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 17:09 -!- omonk [~omonk@unaffiliated/omonk] has quit [Read error: Connection reset by peer] 17:11 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 252 seconds] 17:15 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 17:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:19 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Remote host closed the connection] 17:24 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 17:24 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 17:24 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 17:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:28 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 17:30 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 17:33 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:43 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has joined #bitcoin-core-dev 17:47 -!- ccdle12 [~ccdle12@p1482011-ipngn9101sapodori.hokkaido.ocn.ne.jp] has quit [Ping timeout: 245 seconds] 17:55 -!- igorivachshenko [b064be8d@gateway/web/freenode/ip.176.100.190.141] has joined #bitcoin-core-dev 17:55 -!- aclark1 [~aclark@173.209.57.12] has joined #bitcoin-core-dev 18:01 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Remote host closed the connection] 18:01 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev 18:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:09 < bitcoin-git> [bitcoin] sipa opened pull request #16001: Give WalletModel::UnlockContext move semantics (master...201905_moveunlockcontext) https://github.com/bitcoin/bitcoin/pull/16001 18:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 18:13 -!- igorivachshenko [b064be8d@gateway/web/freenode/ip.176.100.190.141] has quit [Ping timeout: 256 seconds] 18:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds] 18:19 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 18:24 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 18:24 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host] 18:24 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 18:27 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:40 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 18:40 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:41 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:44 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 255 seconds] 18:45 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:45 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 18:45 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:50 -!- rhavar [uid237883@gateway/web/irccloud.com/x-ggiiolrtrvgkezif] has quit [Quit: Connection closed for inactivity] 18:53 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:59 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 18:59 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:04 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 19:04 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:12 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 19:12 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 19:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:23 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 19:32 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in] 19:33 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev 19:34 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 19:45 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Ping timeout: 248 seconds] 20:00 -!- aclark1 [~aclark@173.209.57.12] has quit [] 20:00 -!- bushstar [~bushstar@host109-155-240-208.range109-155.btcentralplus.com] has joined #bitcoin-core-dev 20:00 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 246 seconds] 20:04 -!- havenwood1 [~havenwood@84.39.117.57] has joined #bitcoin-core-dev 20:06 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 20:10 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 246 seconds] 20:14 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:15 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 268 seconds] 20:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 244 seconds] 20:27 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 20:31 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 20:40 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 20:48 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 258 seconds] 21:09 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 21:15 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 21:19 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 268 seconds] 21:23 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 21:37 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:37 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 21:39 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 21:41 -!- tryphe_ is now known as tryphe 21:44 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 258 seconds] 21:44 -!- bushstar [~bushstar@host109-155-240-208.range109-155.btcentralplus.com] has quit [Remote host closed the connection] 21:46 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 21:57 -!- ccdle12_ [~ccdle12@103.5.140.188] has joined #bitcoin-core-dev 21:58 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 252 seconds] 22:14 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 246 seconds] 22:15 -!- ccdle12_ [~ccdle12@103.5.140.188] has quit [Remote host closed the connection] 22:25 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 22:30 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 245 seconds] 22:39 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 23:00 -!- havenwood1 [~havenwood@84.39.117.57] has quit [] 23:04 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 23:05 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 23:13 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 268 seconds] 23:17 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 23:22 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds] 23:26 -!- alct [~alct@84.39.117.57] has joined #bitcoin-core-dev 23:28 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 23:29 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 23:32 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 23:44 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 23:48 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 23:50 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 23:52 -!- Chris2009 [1fd060bd@gateway/web/freenode/ip.31.208.96.189] has joined #bitcoin-core-dev 23:59 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Read error: Connection reset by peer] --- Log closed Fri May 10 00:00:09 2019