--- Log opened Tue Jun 25 00:00:52 2019
00:00 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:07 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds]
00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]
00:22 -!- hebasto [9fe07a87@159.224.122.135] has quit [Remote host closed the connection]
00:31 -!- reallll is now known as belcher
00:40 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
00:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:47 -!- ctrlbreak [~ctrlbreak@142.134.101.32] has quit [Ping timeout: 272 seconds]
00:58 -!- laptop500 [~laptop@194.33.98.165] has joined #bitcoin-core-dev
01:00 -!- jonatack [25a5605d@37.165.96.93] has quit [Remote host closed the connection]
01:07 -!- omonk [~omonk@unaffiliated/omonk] has quit [Read error: Connection reset by peer]
01:12 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev
01:13 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has joined #bitcoin-core-dev
01:14 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
01:14 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:16 < jonasschnelli> Hmm... compiling depends W64 (minGW64) on Ubuntu 18.04 fails... can't figure out why
01:16 < jonasschnelli> error: ‘mutex’ is not a member of ‘std’    <---- looks like its not compiling with c++11, I tried even to force it with "CXXFLAGS="-std=gnu++11"" ... no success
01:16 < jonasschnelli> Probably missing a package?
01:20 < jonasschnelli> selecting the posix version through sudo update-alternatives --config x86_64-w64-mingw32-g++ fixed it
01:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
01:36 < gertjaap> is there anything i should do if the DrahtBot reports a conflicting PR? Or just leave it for reviewers.
01:37 < fanquake> jonasschnelli just need to read the docs :p
01:37 < jonasschnelli> indeed... :)
01:37 < jonasschnelli> gertjaap: just informal,... no need to fix
01:37 < fanquake> gertjaap I wouldn't worry to much
01:37 < gertjaap> ok, cool
01:38 < fanquake> The conflicting PR could be quite possibly be 6 months old, need rebasing itself etc etc.
01:50 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:57 < meshcollider> I feel like the conflicting info is more useful for maintainers to decide what order to merge stuff in than it is for anyone else
02:00 -!- evanpro [~evanpro@185.204.1.185] has quit []
02:05 -!- rex4539 [~rex4539@2a02:587:3513:9600:252c:b242:a4bc:fe3] has quit [Quit: rex4539]
02:14 -!- harrigan [~harrigan@149.5.35.1] has joined #bitcoin-core-dev
02:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:29 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
02:36 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit]
02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
02:39 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev
02:40 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
02:42 -!- peterpomade [~peterpoma@195.206.169.238] has joined #bitcoin-core-dev
02:43 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
02:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:45 < bitcoin-git> [bitcoin] fanquake closed pull request #15572: Add auto select custom fee when smart fee not initialized. (master...dev) https://github.com/bitcoin/bitcoin/pull/15572
02:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:53 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
02:55 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
02:58 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:00 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
03:06 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:07 < fanquake> wumpus Would you like to take a look at #15894 ?
03:07 < gribble> https://github.com/bitcoin/bitcoin/issues/15894 | Remove duplicated "Error: " prefix in logs by hebasto · Pull Request #15894 · bitcoin/bitcoin · GitHub
03:08 -!- ctrlbreak [~ctrlbreak@142.134.84.46] has joined #bitcoin-core-dev
03:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
03:11 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:14 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:15 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc948d4cfd6d...c52776e6ff4d
03:15 < bitcoin-git> bitcoin/master fad3d2a MarcoFalke: test: Create data dir in BasicTestingSetup
03:15 < bitcoin-git> bitcoin/master fa4a04a MarcoFalke: test: use common setup in gui tests
03:15 < bitcoin-git> bitcoin/master fabc57e MarcoFalke: test: Log to debug.log in all tests
03:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:16 < bitcoin-git> [bitcoin] laanwj merged pull request #16252: test: Log to debug.log in all unit tests (master...1905-bufferLog) https://github.com/bitcoin/bitcoin/pull/16252
03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:17 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:21 < bitcoin-git> [bitcoin] fanquake reopened pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:26 -!- harrigan [~harrigan@149.5.35.1] has quit [Quit: harrigan]
03:28 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:28 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
03:32 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:32 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
03:34 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
03:38 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
03:38 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
03:39 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
03:45 -!- laptop500 [~laptop@194.33.98.165] has quit [Ping timeout: 252 seconds]
03:49 -!- harrigan [~harrigan@149.5.35.1] has joined #bitcoin-core-dev
03:53 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
03:54 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
04:00 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
04:02 < wumpus> fanquake: sure
04:07 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
04:08 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
04:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
04:14 -!- laptop500 [~laptop@194.33.98.165] has joined #bitcoin-core-dev
04:16 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
04:16 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
04:21 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Remote host closed the connection]
04:21 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
04:26 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
04:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:28 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Client Quit]
04:29 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
04:31 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c52776e6ff4d...332c6134bb15
04:33 < bitcoin-git> bitcoin/master f0641f2 Hennadii Stepanov: Prepend the error/warning prefix for GUI messages
04:33 < bitcoin-git> bitcoin/master 96fd4ee Hennadii Stepanov: Add MSG_NOPREFIX flag for user messages
04:33 < bitcoin-git> bitcoin/master f724f31 Hennadii Stepanov: Make AbortNode() aware of MSG_NOPREFIX flag
04:33 < fanquake> wumpus thanks
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] laanwj merged pull request #15894: Remove duplicated "Error: " prefix in logs (master...20190425-duplicated-error-prefix) https://github.com/bitcoin/bitcoin/pull/15894
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:36 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has quit [Remote host closed the connection]
04:37 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:40 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:51 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
04:57 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
04:57 < fanquake> wumpus I was going to ACK #16278 (no longer because it doesn't seem to compile..). Basically because it's tests only, Marco seems ok with it and it doesn't conflict with anything else that is merge ready. However, for the rest of the the 0.19.0 cycle, I feel like we're at the point where we can just start rejecting those kinds of PRs.
04:57 < gribble> https://github.com/bitcoin/bitcoin/issues/16278 | tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests by practicalswift · Pull Request #16278 · bitcoin/bitcoin · GitHub
04:57 < fanquake> I know you'd be happy to just close them all the time.
05:00 -!- peterpomade [~peterpoma@195.206.169.238] has quit []
05:00 -!- harrigan [~harrigan@149.5.35.1] has quit [Quit: harrigan]
05:00 < fanquake> hebasto (are you on IRC, different nick?) also asked how to test these kinds of PRs. I was just going to say using whichever methods wastes the least developer time. It's sort of annoying that a lot of these changes are seemingly hand-rolled, and the PR's don't actually contain any information about how they were done, or point to ways that this can just be automated away and forgotten about in future.
05:02 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
05:03 < fanquake> It's also a bit crazy that the 0.19 branch off is only 3 months away. #15940.
05:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
05:07 -!- harrigan [~harrigan@149.5.35.1] has joined #bitcoin-core-dev
05:10 -!- porygon2 [~porygon2@185.59.221.95] has joined #bitcoin-core-dev
05:14 -!- laptop500 [~laptop@194.33.98.165] has quit [Quit: Leaving]
05:22 -!- ryanofsky [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
05:24 < wumpus> fanquake: whoa yes that branch-off is pretty soon, thanks for the reminder :)
05:27 < wumpus> fanquake: I don't necessarily want to close them, but yes, messing around with includes just has the lowest priority for me
05:28 < fanquake> yes
05:28 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-uvuxbnaaomxptmcu] has joined #bitcoin-core-dev
05:29 < wumpus> although it's nice they benchmarked it and it increased the build speed, it's not really a metric we generally optimized for, but still
05:30 < fanquake> Sure. Although a bit concerning that they might push a change like that and it not even compile.
05:30 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:30 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
05:33 < wumpus> fanquake: silent merge conflict I guess?
05:34 < fanquake> wumpus yea I'd assume so. Looks like it happened right after rebasing.
05:35 < wumpus> (tbh I'm not sure 2% compile speed improvement warrants that much work; most complaints with regard to compile are about compile-time memory usage, not sure how that is affected)
05:36 < fanquake> I think there is another PR open, or possibly got closed that reduced compile time memory by 1% or so by removing a bunch of includes
05:38 < fanquake> Yea #16238. Which was a follow up to #16129 which supposedly reduced compile time memory use by 2%.
05:38 < gribble> https://github.com/bitcoin/bitcoin/issues/16238 | build: Remove unused C++ standard library includes by practicalswift · Pull Request #16238 · bitcoin/bitcoin · GitHub
05:38 < gribble> https://github.com/bitcoin/bitcoin/issues/16129 | refactor: Remove unused includes by practicalswift · Pull Request #16129 · bitcoin/bitcoin · GitHub
05:39 < fanquake> tbh I'm not sure why the later wasn't part of the former.
05:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
05:44 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
05:50 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
05:51 < jonasschnelli> wumpus: thanks for clearing up the mystery of openSSH's BE/LE code
05:52 < jonasschnelli> I think one conversion to host endianness needs to be kept:
05:52 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/commits/5aad287ef3b2c410385d6e9a898fb70526c5bd98#diff-d64c806cc86b6f80f4cf5b777238b493R126
05:53 < jonasschnelli> Since we are reading the stream (which is always LE) and give back an int
05:58 < wumpus> jonasschnelli: I'm not sure, it seems this could be done without ever relying on host endianness like openssh does
05:59 < wumpus> read the stream to integer with specified endian and write the integers with specified endian
06:00 < jonasschnelli> wumpus: hmm...
06:00 < wumpus> of course the integers will be in host endianness but you'd never rely on that fact in the code and use shifts and bitwise ANDs/ORs
06:00 < jonasschnelli> I guess we are doing that...
06:00 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/files#diff-d64c806cc86b6f80f4cf5b777238b493R121
06:00 < jonasschnelli> the byte shifts are BE/LE safe AFAIK
06:01 < jonasschnelli> so that one *len24_out = le32toh(*len24_out); is not necessary? 
06:01 < wumpus> not as long as you're using the htole64 
06:02 < wumpus> so basically you never want to cast bytes to integers and vice versa, so you don't need Xtoh or htoX
06:03 < wumpus> access bytes as bytes and integers as integers and use endian-explicit poke/peek functions where needed to convert between them
06:04 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
06:06 < jonasschnelli> wumpus: and we are using htole64 since this is network protocol serialisation... so you agree it's safe to remove that le32toh?
06:06 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
06:07 < wumpus> I'll have to review the code to be sure, but I think it's unnecessary, unless you're type-punning somethere
06:07 < wumpus> in which case that's what you'd want to avoid instead
06:08 < jonasschnelli> That part is not in the AEAD pull,... since nothing is really creating encrypted streams from internal structures (the testvectors are given)
06:09 < wumpus> jonasschnelli:yes, the " *len24_out = le32toh(*len24_out);" should be unnecessary
06:09 < jonasschnelli> So the AEAD PR tests against test vectors where the integer (there is only one for the AAD len) is encoded LE
06:09 < wumpus> "// encode to host endianness 32bit integer", it's an integer: it's always host endianness in memory, but you don't need to care, treat it as an abstract integer
06:10 < wumpus> only when you convert the integer from/to bytes, endian starts to be something you need to be concerned about
06:11 < jonasschnelli> Yes. Thanks for clearing that up...
06:11 < jonasschnelli> The current code that writes the 3 byte length field is...:
06:11 < jonasschnelli> CVectorWriter vector_writer(SER_NETWORK, INIT_PROTO_VERSION, serialized_envelope, 0, int24[0], int24[1], int24[2]);
06:14 < wumpus> right, would change that to ((int24>>16)&0xff), ((int24>>8)&0xff), (int24&0xff)  (assuming you want it BE)  instead of type-punning the int
06:14 < wumpus> (other way around if you want LE)
06:16 < jonasschnelli> if we would use a standard int32 for the size (instead of 3 bytes) we could just pass the int into CVectorWriter since it uses ser_writedata32 under the hood, right?
06:17 < wumpus> yes
06:17 < jonasschnelli> But since there is no ser_writedata24 (obviously), we need to use our own punning
06:19 < wumpus> you have to handle your own serialization / deserialization for the byte stream from/to an integer, yes
06:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
06:35 < wumpus> but not with type punning (which is explicitly defined as casting one type of pointer to another and suspicable to various kinds of UB and IBD), rather, use explicit shifts and logical operations to extract/concatentate the bytes
06:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
06:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 260 seconds]
06:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
06:41 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection]
06:42 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:53 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
06:55 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 248 seconds]
06:56 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 246 seconds]
07:08 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:11 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
07:16 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
07:17 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
07:17 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds]
07:18 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection]
07:18 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
07:18 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
07:21 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
07:21 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
07:23 -!- scoop [~scoop@207.7.99.34] has joined #bitcoin-core-dev
07:23 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
07:23 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
07:23 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
07:26 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 272 seconds]
07:28 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
07:28 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
07:28 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:29 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
07:40 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
07:51 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has joined #bitcoin-core-dev
07:53 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Ping timeout: 258 seconds]
07:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
08:00 -!- porygon2 [~porygon2@185.59.221.95] has quit []
08:01 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
08:04 -!- Inigo_Montoya [~Inigo_Mon@89.238.178.75] has joined #bitcoin-core-dev
08:11 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
08:11 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:17 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has quit [Quit: Ping timeout (120 seconds)]
08:20 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
08:21 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
08:24 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
08:28 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection]
08:49 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:51 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
08:55 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
09:00 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
09:02 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 245 seconds]
09:05 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
09:06 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
09:06 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
09:08 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
09:09 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
09:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds]
09:11 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
09:12 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 245 seconds]
09:17 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
09:18 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:19 < bitcoin-git> [bitcoin] promag opened pull request #16285: rpc: Improve scantxoutset response and help message (master...2019-06-scantxoutset-nits) https://github.com/bitcoin/bitcoin/pull/16285
09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:25 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:26 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Quit: pinheadmz]
09:32 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
09:36 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
09:42 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
09:43 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 272 seconds]
09:44 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
09:47 < wumpus> its funny that no one can answer my question in #16183
09:47 < gribble> https://github.com/bitcoin/bitcoin/issues/16183 | depends: xtrans: Configure flags cleanup. by dongcarl · Pull Request #16183 · bitcoin/bitcoin · GitHub
09:49 < gwillen> wumpus: it appears to be a library somehow involved in talking to the X windows server?
09:50 < dongcarl> wumpus: X11 needs it at build time
09:50 < gwillen> it looks like qt depends on xcb which might depend on xtrans
09:51 < gwillen> so it's a fairly deep dependency which is why nobody remembers what it does ;-)
09:51 < dongcarl> libX11*
10:00 -!- scoop [~scoop@207.7.99.34] has quit [Remote host closed the connection]
10:05 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
10:11 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
10:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
10:15 -!- harrigan [~harrigan@149.5.35.1] has quit [Quit: harrigan]
10:16 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
10:16 -!- scoop [~scoop@207.7.99.34] has joined #bitcoin-core-dev
10:18 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
10:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:23 < bitcoin-git> [bitcoin] hebasto opened pull request #16286: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
10:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:42 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
10:51 < wumpus> gwillen dongcarl: okay, thanks, makes sense, the thing that made me confused is that if it's not even a library, how do we depend on it?
10:51 < wumpus> I guess I'd still rather depend on some obscure X dep than... expat
10:51 < gwillen> .... that's a good question
10:56 -!- usahgagahb [~c@modemcable225.239-130-66.mc.videotron.ca] has joined #bitcoin-core-dev
11:00 -!- Inigo_Montoya [~Inigo_Mon@89.238.178.75] has quit []
11:00 -!- scoop [~scoop@207.7.99.34] has quit [Read error: Connection reset by peer]
11:00 -!- scoop [~scoop@207.7.99.34] has joined #bitcoin-core-dev
11:18 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
11:19 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
11:21 -!- edit_21 [~edit_21@185.59.221.95] has joined #bitcoin-core-dev
11:25 -!- scoop_ [~scoop@207.7.99.34] has joined #bitcoin-core-dev
11:25 -!- scoop [~scoop@207.7.99.34] has quit [Read error: Connection reset by peer]
11:29 -!- harrigan [~harrigan@149.5.35.1] has joined #bitcoin-core-dev
11:30 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
11:32 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
11:33 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
11:46 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit]
11:50 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode]
11:50 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
11:53 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev
11:56 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
11:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:58 -!- scoop_ [~scoop@207.7.99.34] has quit [Remote host closed the connection]
12:01 -!- lightlike [~lightlike@2001:16b8:5795:6900:b1c2:9d65:8ef8:9ec4] has joined #bitcoin-core-dev
12:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
12:08 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds]
12:09 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:11 < bitcoin-git> [bitcoin] rrybarczyk opened pull request #16287: Remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:15 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:15 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
12:18 -!- usahgagahb [~c@modemcable225.239-130-66.mc.videotron.ca] has quit [Quit: leaving]
12:18 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds]
12:26 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
12:41 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
13:02 -!- harrigan [~harrigan@149.5.35.1] has quit [Quit: harrigan]
13:03 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
13:04 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
13:10 < hebasto> Hi! Could someone point me to the adopted practice or discussion about translation of the "Bitcoin Core" brand name to other languages?
13:14 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
13:34 -!- harrigan [~harrigan@149.5.35.1] has joined #bitcoin-core-dev
13:36 -!- harrigan [~harrigan@149.5.35.1] has quit [Client Quit]
13:37 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
13:48 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 252 seconds]
14:00 -!- edit_21 [~edit_21@185.59.221.95] has quit []
14:00 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
14:01 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
14:04 -!- lightlike [~lightlike@2001:16b8:5795:6900:b1c2:9d65:8ef8:9ec4] has quit [Remote host closed the connection]
14:04 -!- lightlike [~lightlike@2001:16b8:5795:6900:b1c2:9d65:8ef8:9ec4] has joined #bitcoin-core-dev
14:04 -!- Snowstormer [~Snowstorm@185.5.172.148] has joined #bitcoin-core-dev
14:08 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:11 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 272 seconds]
14:18 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
14:19 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 260 seconds]
14:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
14:25 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds]
14:26 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
14:30 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
14:46 < ossifrage> Some how I lost 7342 blocks in an out of space shutdown
14:48 -!- hrofu [hrofu@gateway/vpn/mullvad/hrofu] has joined #bitcoin-core-dev
14:48 < ossifrage> The node had been down since jan, it synced up to the tip and then many hours later it ran out of disk.
14:49 < ossifrage> When I restarted the node the tip went from 582102 back to 574747
14:50 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Read error: Connection reset by peer]
14:50 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 246 seconds]
14:50 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Read error: Connection reset by peer]
14:50 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
14:50 -!- hrofu_ [~hrofu@unaffiliated/hrofu] has quit [Ping timeout: 245 seconds]
14:51 -!- Lauda [~quassel@95.216.196.120] has joined #bitcoin-core-dev
14:51 -!- Lauda [~quassel@95.216.196.120] has quit [Changing host]
14:51 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev
14:52 < ossifrage> 574747 was the first UpdateTip line from the previous run of bitcoin-qt, this seems like an excessive amount of state to loose
14:52 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev
14:56 -!- Jason [4b84b807@75-132-184-7.dhcp.stls.mo.charter.com] has joined #bitcoin-core-dev
14:57 -!- Jason is now known as Guest81088
15:00 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
15:12 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
15:20 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Quit: pinheadmz]
15:21 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
15:24 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
15:28 -!- ubba [c15a3d82@c823D5AC1.dhcp.as2116.net] has joined #bitcoin-core-dev
15:31 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
15:31 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Client Quit]
15:32 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:32 < achow101> is it project policy that all commits must compile and pass all tests?
15:35 -!- ubba [c15a3d82@c823D5AC1.dhcp.as2116.net] has quit [Ping timeout: 260 seconds]
15:36 < gwillen> achow101: I think it's like, polite at least?
15:36 < gwillen> I've not heard of it being enforced, I do not believe Travis checks anything but the tip
15:37 < gwillen> but I always try to preserve it, bisection is more annoying if you don't
15:37 < achow101> gwillen: my situation is either make people review a commit that's something like +/- 5000 LOC but compiles and passes tests, or break that up but none of those commits will pass tests (they should compile though)
15:37 < achow101> for my own sanity, I'm making the separate commits, but I can squash them all together if people want commits that pass tests
15:38 < gwillen> you could just disable the broken tests in the intermediate commits
15:38 < gwillen> I don't know if that's actually a good idea but it fixes the bisection issue
15:40 < achow101> .. there's a lot of broken tests. basically anything that involves the wallet
15:40 < achow101> which is almost all of them
15:44 < gwillen> *nods*
15:49 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
15:53 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
15:54 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:57 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 248 seconds]
15:58 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
16:01 -!- itsiku [~itsiku@abelohost-34.207.207.185.dedicated-ip.abelons.com] has quit [Quit: Lost terminal]
16:03 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in]
16:03 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
16:12 -!- nullptr| [~nullptr|@2001:bc8:47a4:241::1] has joined #bitcoin-core-dev
16:13 < luke-jr> bisect should only ever go inside a merge when it's related to the issue
16:15 -!- nullptr| [~nullptr|@2001:bc8:47a4:241::1] has quit [Client Quit]
16:15 -!- nullptr| [~nullptr|@2001:bc8:47a4:241::1] has joined #bitcoin-core-dev
16:32 < promag> achow101: fwiw I prefer green commits
16:34 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
16:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
16:41 < meshcollider> Squash them locally then ;)
16:47 < jb55> in general I think you should structure commits so that each one passes tests, obviously that's not always possible, but it's good practice
17:00 -!- Snowstormer [~Snowstorm@185.5.172.148] has quit []
17:03 -!- nihui [~nihui@89.238.178.75] has joined #bitcoin-core-dev
17:05 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
17:05 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds]
17:05 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds]
17:08  * luke-jr suggests "if you can articulate a good reason why, it's okay to have mid-commits fail"
17:08 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:11 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
17:12 -!- surja795 [~sourabh@76.118.169.20] has joined #bitcoin-core-dev
17:19 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
17:29 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev
17:36 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev
17:37 -!- lightlike [~lightlike@2001:16b8:5795:6900:b1c2:9d65:8ef8:9ec4] has quit [Quit: Leaving]
17:38 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Client Quit]
17:41 < achow101> meshcollider: I'm fine with doing that. The question is do *you* want to review that commit?
17:47 -!- Guest81088 [4b84b807@75-132-184-7.dhcp.stls.mo.charter.com] has quit [Remote host closed the connection]
17:50 < sipa> achow101: i think meshcollider's was suggesting that promag would squash the commits himself, before local review
17:51 < gwillen> luke-jr: do you consider "it would be a huge pain in the ass" to be a good reason
17:51 < gwillen> my sense is that's maybe the case here
17:51 < gwillen> it's probably better to avoid that case but I'm sympathetic because I've gotten into it before
17:51 < promag> sipa: is it possible to have the changes since a bdb cursor?
17:52 < luke-jr> gwillen: if it's not just laziness ;)
17:52 < luke-jr> otoh, we're making our test system more fragile, so dunno, maybe we should just ignore test failrues :/
17:53 < meshcollider> achow101: I prefer smaller commits over 1 massive one even if bisect breaks
17:53 -!- scoop [~scoop@12.35.79.25] has quit [Remote host closed the connection]
17:56 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev
17:56 < achow101> gwillen: luke-jr: it's just super hard to follow if it is one gigantic diff. I tried doing that and quickly got lost in my own changes before I even committed it.
17:56 < sipa> promag: ?
17:57 < promag> achow101: incoming refactor? be gentle :P
17:57 < sipa> achow101: that seems like a plenty strong reason to ignore the rule
17:57 < promag> sipa: scantxoutset takes a cursor then iterates it
17:57 < sipa> achow101: though even better would be small commits that don't break it :)
17:57 < promag> sipa: is is possible to to make then following scantxoutset incremental?
17:57 < gwillen> yeah I think small commits with breakage > large commits that are hard to understand, indeed
17:57 < sipa> promag: what does bdb have to do with it?
17:57 < sipa> that's a wallet thing
17:58 < sipa> scantxoutset has nothing to do with the wallet
17:58 < sipa> promag: ah, i see what you mean
17:59 < sipa> you can have an incremental scantxoutset by filtering only entries with a blockheight later than your previous scan
17:59 < achow101> sipa: I don't think it is possible to make small commits that don't break tests. all this wallet stuff is tied to each other extremely tightly
17:59 < sipa> but that wouldn't speed anything up
17:59 < sipa> achow101: yeah, i believe that
18:00 < promag> sipa: right, I thought the same
18:01 < promag> btw, scantxoutset doesn't take into account mempool, is that intended?
18:02 < sipa> we could add an option to include the mempool i guess
18:04 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev
18:05 < promag> achow101: you could add [skip ci] in the commit message, travis only reads this in the HEAD commit but we could use it in broken commits
18:05 < achow101> promag: ah, good idea
18:08 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
18:08 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit]
18:08 -!- bajdev [~bajdev3@173.94.144.126] has joined #bitcoin-core-dev
18:09 -!- bajdev [~bajdev3@173.94.144.126] has quit [Client Quit]
18:10 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
18:11 -!- bajdev [~bajdev3@173.94.144.126] has joined #bitcoin-core-dev
18:13 -!- bajdev [~bajdev3@173.94.144.126] has quit [Client Quit]
18:13 -!- bajdev [~bajdev3@173.94.144.126] has joined #bitcoin-core-dev
18:13 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
18:16 -!- bajdev [~bajdev3@173.94.144.126] has quit [Client Quit]
18:16 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 272 seconds]
18:16 -!- bajdev [~bajdev3@173.94.144.126] has joined #bitcoin-core-dev
18:20 -!- pinheadmz [~matthewzi@208.69.41.101] has joined #bitcoin-core-dev
18:22 -!- bajdev [~bajdev3@173.94.144.126] has quit [Quit: Leaving]
18:39 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
18:43 -!- scoop [~scoop@12.35.79.25] has quit [Remote host closed the connection]
18:44 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
18:50 -!- Henry151 is now known as `
18:51 -!- ` is now known as Guest92699
18:51 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in]
18:52 -!- Guest92699 is now known as Henry151
18:54 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev
18:55 -!- scoop [~scoop@intercontinental-sf.static.monkeybrains.net] has joined #bitcoin-core-dev
18:59 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
19:03 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds]
19:11 -!- PantsMcPants [~mtmoselle@66.115.169.210] has joined #bitcoin-core-dev
19:12 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:16 -!- pinheadmz [~matthewzi@208.69.41.101] has quit [Quit: pinheadmz]
19:24 -!- scoop [~scoop@intercontinental-sf.static.monkeybrains.net] has quit [Remote host closed the connection]
19:30 -!- hugohn [~textual@45.56.153.235] has joined #bitcoin-core-dev
19:33 -!- scoop [~scoop@199.116.75.130] has joined #bitcoin-core-dev
19:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:37 -!- scoop [~scoop@199.116.75.130] has quit [Ping timeout: 245 seconds]
19:38 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
19:45 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
19:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
19:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
19:46 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.7.3 - https://znc.in]
19:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
19:47 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
19:47 < fanquake> meshcollider are you about to merge that PR. I'm in the middle of doing the same..
19:48 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 260 seconds]
19:48 < meshcollider> Oh yes I am lol
19:48 < meshcollider> Do you want to continue or shall I do it?
19:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
19:48 < fanquake> I'm basically at sign and push hah
19:49 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
19:49 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:49 < meshcollider> Ok go for it :)
19:50 < meshcollider> It's safe to assume I'll see and merge anything tagged with wallet which is RTM within half a day or so, but you beat me to it this time
19:51 < fanquake> cheers, no worries
19:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:54 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/332c6134bb15...ca80fec973f0
19:54 < bitcoin-git> bitcoin/master d8bd97d Hennadii Stepanov: Fix GCC 7.4.0 warning
19:54 < bitcoin-git> bitcoin/master ca80fec fanquake: Merge #16286: refactoring: wallet: Fix GCC 7.4.0 warning
19:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:55 < bitcoin-git> [bitcoin] fanquake merged pull request #16286: refactoring: wallet: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
19:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:00 -!- nihui [~nihui@89.238.178.75] has quit []
20:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:04 -!- Barras2 [~Barras2@185.204.1.185] has joined #bitcoin-core-dev
20:07 -!- surja795 [~sourabh@76.118.169.20] has quit [Ping timeout: 252 seconds]
20:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:16 -!- hugohn [~textual@45.56.153.235] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:18 -!- hugohn [~textual@45.56.153.235] has joined #bitcoin-core-dev
20:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
20:38 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection]
20:44 -!- hugohn [~textual@45.56.153.235] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:46 -!- hugohn [~textual@45.56.153.235] has joined #bitcoin-core-dev
20:47 -!- surja795 [~sourabh@76.118.169.20] has joined #bitcoin-core-dev
20:48 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
20:49 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
20:50 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
20:51 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
20:52 -!- surja795 [~sourabh@76.118.169.20] has quit [Ping timeout: 245 seconds]
20:53 -!- bralycl__ [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
20:54 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 248 seconds]
20:55 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
20:55 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds]
20:56 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 245 seconds]
20:57 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
20:58 -!- bralycl__ [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 252 seconds]
21:00 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds]
21:01 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
21:03 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
21:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:06 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 258 seconds]
21:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
21:19 -!- hugohn [~textual@45.56.153.235] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:21 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection]
21:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
21:48 -!- PantsMcPants [~mtmoselle@66.115.169.210] has quit []
22:12 -!- Barras2 [~Barras2@185.204.1.185] has quit [Remote host closed the connection]
22:14 -!- hebasto [9fe07a9c@159.224.122.156] has joined #bitcoin-core-dev
22:18 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
22:22 -!- total1ty [~total1ty@185.59.221.95] has joined #bitcoin-core-dev
22:41 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
22:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds]
22:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
22:59 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
23:00 -!- total1ty [~total1ty@185.59.221.95] has quit []
23:03 -!- jonatack [~Mutter@37.168.47.248] has joined #bitcoin-core-dev
23:05 -!- jonatack [~Mutter@37.168.47.248] has quit [Client Quit]
23:10 -!- jonatack [~Mutter@37.168.47.248] has joined #bitcoin-core-dev
23:14 -!- jonatack [~Mutter@37.168.47.248] has quit [Client Quit]
23:15 -!- Dantman [~Dantman@141.98.101.133] has joined #bitcoin-core-dev
23:23 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-uvuxbnaaomxptmcu] has quit [Quit: Connection closed for inactivity]
23:24 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds]
23:24 -!- tryphe_ is now known as tryphe
23:24 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
23:25 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds]
23:30 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
23:31 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:32 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
23:37 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
23:49 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
23:49 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
23:50 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev
23:56 < fanquake> NicolasDorier: Restarted the test for you.
--- Log closed Wed Jun 26 00:00:20 2019