--- Log opened Wed Jun 26 00:00:20 2019 --- Day changed Wed Jun 26 2019 00:00 -!- scoop [~scoop@12.35.79.25] has quit [Remote host closed the connection] 00:05 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 00:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 00:20 -!- reallll is now known as belcher 00:32 -!- scoop [~scoop@199.116.75.130] has joined #bitcoin-core-dev 00:36 -!- scoop [~scoop@199.116.75.130] has quit [Ping timeout: 244 seconds] 00:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 00:47 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev 00:51 -!- scoop [~scoop@12.35.79.25] has quit [Ping timeout: 252 seconds] 01:03 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev 01:07 -!- scoop [~scoop@12.35.79.25] has quit [Ping timeout: 245 seconds] 01:18 -!- scoop [~scoop@199.116.75.130] has joined #bitcoin-core-dev 01:20 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has quit [Ping timeout: 272 seconds] 01:23 -!- scoop [~scoop@199.116.75.130] has quit [Ping timeout: 272 seconds] 01:28 -!- laptop500 [~laptop@194.33.98.165] has joined #bitcoin-core-dev 01:34 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev 01:38 -!- scoop [~scoop@12.35.79.25] has quit [Ping timeout: 245 seconds] 01:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 01:47 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:49 -!- scoop [~scoop@199.116.75.130] has joined #bitcoin-core-dev 01:54 -!- scoop [~scoop@199.116.75.130] has quit [Ping timeout: 252 seconds] 01:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 01:55 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has joined #bitcoin-core-dev 01:59 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:00 -!- Dantman [~Dantman@141.98.101.133] has quit [] 02:05 -!- hebasto [9fe07a9c@159.224.122.156] has quit [Remote host closed the connection] 02:09 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has joined #bitcoin-core-dev 02:14 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 02:16 -!- visser_ [~visser_@141.98.101.133] has joined #bitcoin-core-dev 02:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 02:27 -!- goatpig [53724877@alagny-155-1-21-119.w83-114.abo.wanadoo.fr] has quit [Remote host closed the connection] 02:31 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:32 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:35 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #16289: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289 02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:41 < jonasschnelli> MarcoFalke: how is travis caching .ccache? Per job? Or does it combine/merge files in that cache folder? 02:41 -!- bushstar [~bushstar@2a00:23c7:9204:1700:bd22:889b:fafd:1757] has joined #bitcoin-core-dev 02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:43 < bitcoin-git> [bitcoin] Bushstar opened pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290 02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:43 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 02:43 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Client Quit] 02:43 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 244 seconds] 02:50 -!- bushstar [~bushstar@2a00:23c7:9204:1700:bd22:889b:fafd:1757] has quit [Remote host closed the connection] 02:56 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 02:56 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 02:56 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Read error: Connection reset by peer] 02:56 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Read error: Connection reset by peer] 02:57 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds] 02:57 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:57 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds] 02:58 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 03:02 -!- laptop500 [~laptop@194.33.98.165] has quit [Ping timeout: 252 seconds] 03:03 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 03:05 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:06 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 03:08 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 03:22 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has quit [Remote host closed the connection] 03:24 -!- surja795 [~sourabh@76.118.169.20] has joined #bitcoin-core-dev 03:27 -!- laptop500 [~laptop@194.33.98.165] has joined #bitcoin-core-dev 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:31 < bitcoin-git> [bitcoin] fanquake closed pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290 03:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:32 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 03:32 -!- surja795 [~sourabh@76.118.169.20] has quit [Ping timeout: 245 seconds] 03:38 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has joined #bitcoin-core-dev 03:39 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 03:39 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 03:40 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 03:40 < fanquake> Be good to get some eyes over #16035. A couple of unclean cherry-picks, important bug fixes etc for 0.18.1. 03:40 < gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub 03:46 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 03:47 -!- csknk [~csknk@unaffiliated/csknk] has quit [Client Quit] 03:49 < fanquake> If anyone is interested in some build system review. Cory has a PR open on the bitcoin-core/univalue repo: https://github.com/bitcoin-core/univalue/pull/19 03:51 -!- shesek [~shesek@87.71.1.116] has joined #bitcoin-core-dev 03:51 -!- shesek [~shesek@87.71.1.116] has quit [Changing host] 03:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:52 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 04:12 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 04:12 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 04:14 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 04:19 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 04:27 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 04:28 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 268 seconds] 04:30 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 04:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds] 04:31 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:31 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:31 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 04:32 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 04:36 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 04:37 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 04:40 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 04:41 -!- darosior [6dbe8dc1@193-141-190-109.dsl.ovh.fr] has quit [Remote host closed the connection] 04:49 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 04:58 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand] 04:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 05:00 -!- visser_ [~visser_@141.98.101.133] has quit [] 05:04 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 248 seconds] 05:04 -!- Jayflux [~Jayflux@89.238.178.75] has joined #bitcoin-core-dev 05:07 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 05:19 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 245 seconds] 05:21 -!- kljasdfvv [~flack@p200300D46F2D620091C7C62AF271C0DD.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:22 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 05:24 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 05:29 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 05:32 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 245 seconds] 05:36 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 05:39 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 05:40 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Client Quit] 05:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 05:47 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 05:48 -!- hrofu [hrofu@gateway/vpn/mullvad/hrofu] has quit [Quit: in the matrix] 05:51 -!- Guest45841 [82d1a06d@dh160-109.eng.gla.ac.uk] has joined #bitcoin-core-dev 05:55 -!- hesghasaq [~12121@2604:2000:12c1:e144:c5f1:b67f:f53a:31c] has joined #bitcoin-core-dev 05:56 -!- hesghasa_ [~12121@141.98.255.152] has joined #bitcoin-core-dev 05:56 -!- hesghasa_ [~12121@141.98.255.152] has quit [Client Quit] 05:56 -!- nijak [~nijak@141.98.255.152] has joined #bitcoin-core-dev 05:57 -!- hugohn [~textual@45.56.153.235] has joined #bitcoin-core-dev 05:58 -!- hugohn [~textual@45.56.153.235] has quit [Client Quit] 05:58 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 05:59 -!- hugohn [~textual@45.56.153.235] has joined #bitcoin-core-dev 06:00 -!- hesghasaq [~12121@2604:2000:12c1:e144:c5f1:b67f:f53a:31c] has quit [Ping timeout: 250 seconds] 06:00 -!- nijak [~nijak@141.98.255.152] has quit [Client Quit] 06:01 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zrmrphvvhhcgkfud] has joined #bitcoin-core-dev 06:06 < promag> fanquake: will look those backports 06:06 -!- nijak [~nijak@141.98.255.150] has joined #bitcoin-core-dev 06:06 -!- laptop500 [~laptop@194.33.98.165] has quit [Quit: Leaving] 06:08 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 06:09 -!- hugohn [~textual@45.56.153.235] has quit [Ping timeout: 258 seconds] 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca80fec973f0...1b28bca04c27 06:17 < bitcoin-git> bitcoin/master 9824a0d RJ Rybarczyk: Remove extra CBlockIndex declaration 06:17 < bitcoin-git> bitcoin/master 1b28bca MarcoFalke: Merge #16287: refactor: remove extra CBlockIndex declaration 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16287: refactor: remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287 06:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:28 -!- scoop [~scoop@199.116.75.130] has joined #bitcoin-core-dev 06:29 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 06:30 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 06:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:38 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 06:41 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit] 06:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:44 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 06:49 -!- ricardobessa [~ricardobe@2804:7f3:4880:71e3:50fc:f20b:4e4f:c044] has joined #bitcoin-core-dev 06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- ricardobessa [~ricardobe@2804:7f3:4880:71e3:50fc:f20b:4e4f:c044] has left #bitcoin-core-dev [] 06:51 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:52 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 06:54 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 248 seconds] 06:55 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 245 seconds] 06:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 07:10 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:11 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:18 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 244 seconds] 07:33 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 07:34 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 245 seconds] 07:35 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 07:36 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has joined #bitcoin-core-dev 07:36 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds] 07:39 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 258 seconds] 07:40 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 07:43 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 07:43 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 07:43 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 07:46 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 07:48 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:120:3abe:46f4:9ff] has quit [Quit: Sleep mode] 07:48 -!- kljasdfvv [~flack@p200300D46F2D620091C7C62AF271C0DD.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 07:52 -!- scoop [~scoop@199.116.75.130] has quit [Remote host closed the connection] 07:52 -!- jason_ [~jason@101.132.74.90] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.1 - http://znc.in] 07:53 -!- jason [~jason@101.132.74.90] has joined #bitcoin-core-dev 07:53 -!- jason is now known as Guest61179 07:54 -!- scoop [~scoop@intercontinental-sf.static.monkeybrains.net] has joined #bitcoin-core-dev 07:55 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection] 07:57 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 08:00 -!- Jayflux [~Jayflux@89.238.178.75] has quit [] 08:01 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:02 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 245 seconds] 08:03 -!- goatpig [53724877@alagny-155-1-21-119.w83-114.abo.wanadoo.fr] has joined #bitcoin-core-dev 08:03 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 08:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:04 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 08:04 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:05 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 08:05 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 08:05 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 08:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 08:07 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 252 seconds] 08:08 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:11 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291 08:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:12 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection] 08:13 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 08:18 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 272 seconds] 08:22 -!- kaimi1 [~kaimi@195.206.169.238] has joined #bitcoin-core-dev 08:22 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 08:22 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:24 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:24 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 08:26 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:39 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:41 -!- aseem [~aseem@38.88.150.114] has quit [Read error: Connection reset by peer] 08:41 -!- aseem_ [~aseem@38.88.150.114] has joined #bitcoin-core-dev 08:42 -!- aseem_ [~aseem@38.88.150.114] has quit [Client Quit] 08:46 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:47 -!- scoop [~scoop@intercontinental-sf.static.monkeybrains.net] has quit [Remote host closed the connection] 08:47 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 08:49 -!- scoop [~scoop@12.35.79.25] has joined #bitcoin-core-dev 08:58 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 08:59 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:02 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:10 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 09:12 -!- michaelfolkson [~textual@82-132-212-230.dab.02.net] has joined #bitcoin-core-dev 09:28 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:28 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 09:28 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds] 09:32 -!- jtimon [~quassel@205.201.35.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:35 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 09:36 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 09:36 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 09:37 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 258 seconds] 09:48 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 09:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 09:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:57 -!- lightlike [~lightlike@2001:16b8:5745:f200:7095:c73f:87c3:3f09] has joined #bitcoin-core-dev 10:01 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 10:11 -!- r8921039 [~r8921039@173.239.65.123] has joined #bitcoin-core-dev 10:14 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:17 -!- cidercider [3cbad8cf@60.186.216.207] has joined #bitcoin-core-dev 10:20 -!- scoop [~scoop@12.35.79.25] has quit [Remote host closed the connection] 10:26 -!- b10c [~b10c@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:28 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Quit: pinheadmz] 10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:29 < bitcoin-git> [bitcoin] instagibbs opened pull request #16292: wallet_resendwallettransaction.py: fix coinbase height (master...resend_test_height) https://github.com/bitcoin/bitcoin/pull/16292 10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:30 -!- pinheadmz [~matthewzi@207.189.24.169] has joined #bitcoin-core-dev 10:31 -!- pinheadmz [~matthewzi@207.189.24.169] has quit [Client Quit] 10:35 < jtimon> regarding https://github.com/bitcoin/bitcoin/pull/8994 I'm not sure it needs conceptual review (I'm sure there's many concept acks buried in the comments), but mostly review and re-review 10:39 -!- dfsg [~dfsg@unaffiliated/dfsg] has joined #bitcoin-core-dev 10:39 -!- dfsg [~dfsg@unaffiliated/dfsg] has left #bitcoin-core-dev [] 10:41 -!- michaelfolkson [~textual@82-132-212-230.dab.02.net] has quit [Quit: Sleep mode] 10:50 -!- Jaamg_ [jaamg@kapsi.fi] has joined #bitcoin-core-dev 10:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:50 < bitcoin-git> [bitcoin] practicalswift closed pull request #16045: Skip redundant memset(p, 0, 0) calls where p is not valid for writing (master...redundant-memsets) https://github.com/bitcoin/bitcoin/pull/16045 10:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:52 -!- tynes [~tynes@30.50.237.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293 10:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:53 -!- Jaamg [jaamg@kapsi.fi] has quit [Ping timeout: 258 seconds] 10:53 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 258 seconds] 10:53 -!- tynes_ [~tynes@30.50.237.35.bc.googleusercontent.com] has quit [Ping timeout: 258 seconds] 10:54 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit] 10:55 -!- dfsg [~dfsg@unaffiliated/dfsg] has joined #bitcoin-core-dev 10:55 -!- dfsg [~dfsg@unaffiliated/dfsg] has left #bitcoin-core-dev [] 10:56 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev 10:57 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 10:57 < MarcoFalke> [05:41] MarcoFalke: how is travis caching .ccache? Per job? Or does it combine/merge files in that cache folder? 10:57 < MarcoFalke> It should be per job 10:58 < jonasschnelli> so per build? per job would not make much sense? 10:58 < MarcoFalke> I think they run something like $(env | md5sum) to get the cache name, so that should be different for each entry in the matrix 10:58 < jonasschnelli> I see... 10:58 < jonasschnelli> yes. Makes sense 10:58 < MarcoFalke> each HOST should have their own cache 10:59 < jonasschnelli> maybe based on the job name or so 10:59 < jonasschnelli> (or as you said a hash of the env) 11:00 -!- kaimi1 [~kaimi@195.206.169.238] has quit [] 11:01 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:02 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 11:04 < MarcoFalke> E.g the arm hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550863420#L160 is 42c149c5429f559658e55580a560c8f631c5a8c8bb2db228b3b73635f0e90558 11:04 < MarcoFalke> And the win64 hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550927504#L159 is d42e27fad05b3f827b638d9dda4edcac0b86aeefd6658d03f48468bbde9b1845 11:06 < MarcoFalke> doc: https://docs.travis-ci.com/user/caching/#caches-and-build-matrices 11:12 -!- MTecknology1 [~MTecknolo@185.5.172.148] has joined #bitcoin-core-dev 11:20 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 11:21 -!- pinheadmz [~matthewzi@207.189.24.169] has joined #bitcoin-core-dev 11:21 -!- pinheadmz [~matthewzi@207.189.24.169] has quit [Client Quit] 11:22 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 11:23 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:23 -!- rex4539 [~rex4539@2a02:587:3513:9600:a585:6940:feb0:8c9a] has joined #bitcoin-core-dev 11:26 < dongcarl> For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly. 11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/13989 | add avx512 instrinsic by fingera · Pull Request #13989 · bitcoin/bitcoin · GitHub 11:27 < dongcarl> Is this something that's worth keeping maintained in the codebase? I see that there's precedent already with AVX(2) 11:27 -!- r8921039 [~r8921039@173.239.65.123] has quit [Quit: leaving] 11:27 -!- r8921039 [~r8921039@173.239.65.123] has joined #bitcoin-core-dev 11:28 < jamesob> imo we shouldn't trust chip manufacturers with SHA implementations unless there's a really compelling performance reason to do so 11:29 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:30 < jamesob> let me amend that to "imo we shouldn't trust chip manufacturers with SHA implementations" :) 11:32 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Remote host closed the connection] 11:32 < sipa> dongcarl: SHA256 performance mainly affects propagation speed, not IBD 11:32 < sipa> which we don't have good benchmarks for 11:33 * dongcarl thinking 11:33 < BlueMatt> sipa: the total CheckBlock time in IBD isn't 0, though? 11:33 < BlueMatt> especially with assumevalid 11:33 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 11:34 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:34 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:34 < sipa> BlueMatt: yeah, true 11:35 < sipa> still, i don't expect IBD to be bottlenecked by sha256 11:35 < BlueMatt> it is (for now) critical-path, though I do want to change that..... 11:36 < dongcarl> So is there consensus around whether to continue maintaining intrinsics? Should they be phased out over time, or we just don't add new ones? 11:36 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Read error: Connection reset by peer] 11:36 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:36 -!- cidercider [3cbad8cf@60.186.216.207] has quit [Ping timeout: 260 seconds] 11:36 < sipa> dongcarl: i suggest you try comparing performance with versions without any intrinsics :) 11:37 < sipa> (we have sse4, avx2, and shani based optimized code already, which you may be seeing) 11:37 < sipa> i don't see any reason why we'd drop them? 11:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 11:38 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 11:38 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds] 11:38 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Remote host closed the connection] 11:39 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:39 < dongcarl> perhaps I'm misunderstanding but jamesob brought up the point that we might not want to trust chip manufacturers with SHA implementations? 11:39 < sipa> we're trusting them entirely for everything else already? 11:39 < jamesob> nvm, I think *I* misunderstood there - I thought the intrinsics were doing more than they rae 11:40 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 11:41 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 11:41 < dongcarl> sipa: true 11:42 < dongcarl> have there been previous attempts at benchmarking propagation speed? (what would that even entail?) 11:44 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 11:46 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 11:47 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 11:47 < sipa> jamesob: they're just syntactic C sugar for platform-specific assembly instructions 11:48 < jamesob> sipa: gotcha; for some reason I had it in my head that we may be wanting to make use of some sha256 native instruction 11:49 < sipa> we are; through intrinsics in some cases :) 11:51 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Remote host closed the connection] 11:55 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:58 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:59 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 11:59 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Read error: Connection reset by peer] 12:00 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Remote host closed the connection] 12:00 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 12:02 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit] 12:03 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 12:04 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit] 12:04 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Remote host closed the connection] 12:04 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 12:05 -!- b10c [~b10c@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: Leaving] 12:05 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit] 12:07 -!- pinheadmz [~matthewzi@207.189.24.169] has joined #bitcoin-core-dev 12:07 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 12:09 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 12:11 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 12:12 < dongcarl> sipa: The rationale here is that SHA-NI seems to be faster than SSE4/AVX2 in all cases? https://github.com/bitcoin/bitcoin/pull/13386/files#diff-cf563899256ae1ec7ee78b61806e40caR608 12:12 < sipa> yes 12:13 -!- pinheadmz [~matthewzi@207.189.24.169] has quit [Quit: pinheadmz] 12:15 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 12:15 < sipa> dongcarl: it could have been written as an else branch instead 12:15 < sipa> but it's kinda hard with all the conditional compilation 12:15 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 12:16 < sipa> once you've installed a sha-ni based hasher, you don't want it to be overwritten afterwards with a measly sse4-based one 12:17 < dongcarl> sipa: Right... So when we add AVX512 we should also disable it like you did? Or are benchmarks required before that call can be made? 12:19 -!- aseem [~aseem@38.88.150.114] has quit [Client Quit] 12:20 < sipa> dongcarl: AVX512 only lets you speed up 16-way hashing; not 8-way, 4-way, 2-way, 1-way, or double-64byte :) 12:20 < sipa> so no 12:21 < sipa> AVX2 code right now is also only used for 8-way hashing, but 4-way is still done using the sse4 based code 12:21 < sipa> this is different from sha-ni which gives you a faster 1-way hash 12:22 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 12:23 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 12:24 -!- aseem [~aseem@38.88.150.114] has quit [Client Quit] 12:24 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 12:25 < sipa> dongcarl: maybe this isn't obvious, but the AVX2/AVX512 instructions really just give you a fast way to implement the computation of 8/16 (for avx2/avx512) hashes simultaneously 12:25 < sipa> if you'd use AVX512 based code to compute just one hash, you'd need to fill the buffers with 15 pieces of dummy input, and hash those at the same time still 12:25 * dongcarl digesting and thinking 12:26 < sipa> but the AVX512 code for 16 hashes is slower than just using naive non-optimized SHA 12:26 < sipa> so it's only worth it when you actually have 16 things to hash 12:27 < sipa> it's very likely that AVX512 (for 16 hashes) is also slower than AVX2 (for 8 hashes) 12:27 < sipa> same as AVX2 (for 8 hashes) is usually slower than using SSE4 (for 4 hashes) 12:27 < sipa> slower in clock time; per hash it's obviously faster, or we wouldn't have the code at all 12:27 < sipa> does that make sense? 12:28 < dongcarl> sipa: I guess I'm not understanding why we disable SSE4/AVX2 when SHA-NI is present, but you're saying we shouldn't disable AVX512? 12:29 < sipa> dongcarl: because SHA-NI just gives you superfast code to compute *one* hash 12:29 < sipa> you can't even implement computing *one* hash with AVX512; you always compute 16 12:30 < sipa> so if you have SHA-NI you want to use it for everything 12:30 < sipa> with AVX512 you don't only don't want to use it for everything; you can't 12:30 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 12:31 < dongcarl> Right I believe I understand that. But thinking along this line of logic, shouldn't we disable AVX512 when SHA-NI is present? 12:31 < sipa> oh! 12:31 < sipa> yes 12:32 < sipa> i thought you were asking if we shouldn't disable SSE4/AVX2 when AVX512 is present; the answer there is no 12:32 < sipa> SHA-NI will likely be faster than AVX512 code, even for 16 hashes 12:32 < dongcarl> Haha okay cool that makes perfect sense! Thanks for your patience! 12:32 < sipa> np! 12:35 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 245 seconds] 12:35 < sipa> that's actually something you may want to benchmark, whether 16-way AVX512 isn't faster per hash than SHA-NI 12:35 < sipa> unfortunately, I don't think any hardware exists with both AVX512 and SHA-NI :p 12:37 < dongcarl> sipa: True. Why aren't there overlaps in hardware? 12:38 < sipa> for some reason AMD has been much faster with rolling out SHA-NI support than Intel... which is surprising as SHA-NI was designed and proposed by Intel 12:39 < dongcarl> sipa: Ahhh... probably doesn't make much sense to benchmark when there isn't a machine that supports both then... 12:40 < luke-jr> sipa: AFAIK there must have been hardware issues, as earlier Intel CPUs were advertised to have it, then they backed out 12:40 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand] 12:40 < luke-jr> actually, I would think some Atoms have both? 12:41 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 246 seconds] 12:41 < sipa> luke-jr: atoms have avx512? 12:41 < luke-jr> unsure 12:42 < luke-jr> nah, looks like Intel left it out of them 12:43 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 12:43 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:44 < luke-jr> fwiw, what BFGMiner did for CPU mining, is benchmark all algorithms in separate processes, then use the best performing 12:45 < luke-jr> (at startup) 12:48 < sipa> yeah 12:48 < sipa> that may be necessary at some point 13:06 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 13:07 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:08 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 13:10 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 244 seconds] 13:13 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 244 seconds] 13:13 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:17 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 13:18 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 13:18 -!- promag__ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 13:19 -!- Skirmant [~Skirmant@m90-131-44-9.cust.tele2.lt] has joined #bitcoin-core-dev 13:21 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 13:26 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 13:33 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 13:36 -!- sturles [~sturles@unaffiliated/sturles] has quit [Remote host closed the connection] 13:36 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 13:36 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 13:36 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:43 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:55 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 245 seconds] 13:56 -!- StopAndDecrypt [~StopAndDe@107.181.189.46] has joined #bitcoin-core-dev 13:58 -!- StopAndDecrypt [~StopAndDe@107.181.189.46] has quit [Changing host] 13:58 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 13:58 < achow101> how do people feel about getting rid of dumpwallet and the import* commands except for importmulti? 14:00 -!- MTecknology1 [~MTecknolo@185.5.172.148] has quit [] 14:00 < sipa> for now dumpwallet is kind of the only way to actually see everything you've imported in the past 14:01 < achow101> it kind of gets in the way of all of these wallet changes 14:02 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 14:08 < sipa> they can keep working on top of the legacy spkprovider i think? 14:09 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 14:23 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Quit: pinheadmz] 14:25 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 14:26 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds] 14:26 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds] 14:28 -!- jchnak [d563ddb9@gateway/web/cgi-irc/kiwiirc.com/ip.213.99.221.185] has joined #bitcoin-core-dev 14:28 -!- yano1 [~yano@89.238.178.75] has joined #bitcoin-core-dev 14:29 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Disconnected by services] 14:29 < promag__> achow101: really? don't people use dumpwallet and importwallet for backups? 14:29 -!- promag__ is now known as promag 14:30 < promag> achow101: really? don't people use dumpwallet and importwallet for backups? 14:30 < achow101> promag: they shouldn't... 14:30 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:30 < promag> breaking change alert :P 14:31 < promag> do you have that refactor pushed? 14:31 < sipa> achow101: that's not a good reason :) 14:32 < sipa> there are plenty of things supported that are Bad Ideas (tm) 14:32 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 14:33 < achow101> promag: https://github.com/achow101/bitcoin/tree/box-the-wallet 14:33 < promag> sipa: or Were Good Ideas (tm) 14:33 < sipa> they can certainly be deprecated if there are alternatives, but i suspect here that the expected workflow will be that once you upgrade to a Shiny Descriptor Wallet certain RPCs stop being available, but remain supported on legacy wallets 14:38 < promag> achow101: oh nice, lots of commits :D 14:38 < achow101> i'm going to reorganize them after I get the thing to actually work 14:41 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 14:50 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 14:53 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 14:54 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:55 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 14:57 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:58 < jb55> achow101: why do you need [ci skip], does CI run on every commit? I thought it only ran on the tip. 14:59 < achow101> jb55: it's just to note that those commits won't compile/won't pass tests 14:59 < jb55> I see 14:59 < achow101> the order is kind of screwed up right now 14:59 < achow101> all the [ci skip] commits should be at the end 15:02 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 15:03 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:04 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:06 -!- rex4539 [~rex4539@2a02:587:3513:9600:a585:6940:feb0:8c9a] has quit [Ping timeout: 250 seconds] 15:16 < luke-jr> eh, why wouldn't they compile at least? 15:19 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:21 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:23 -!- goatpig [53724877@alagny-155-1-21-119.w83-114.abo.wanadoo.fr] has quit [Remote host closed the connection] 15:24 < achow101> cause I fucked up. they'll compile later when I reorganize everything 15:24 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:26 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 15:27 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:29 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 245 seconds] 15:30 -!- Guest45841 [82d1a06d@dh160-109.eng.gla.ac.uk] has quit [Remote host closed the connection] 15:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b28bca04c27...3077f11dadff 15:32 < bitcoin-git> bitcoin/master f466c4c Jonas Schnelli: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp 15:32 < bitcoin-git> bitcoin/master 3077f11 MarcoFalke: Merge #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp 15:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289 15:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:35 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:39 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 248 seconds] 15:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 15:43 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:46 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:46 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Read error: Connection reset by peer] 15:48 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 15:49 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit] 15:51 -!- scoop_ [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 15:53 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 16:07 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 16:08 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 16:10 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 248 seconds] 16:16 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:25 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 16:29 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 16:39 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 16:40 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 16:43 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 16:44 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit] 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294 16:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:48 -!- lightlike [~lightlike@2001:16b8:5745:f200:7095:c73f:87c3:3f09] has quit [Quit: Leaving] 16:51 -!- surja795 [~sourabh@76.118.169.20] has joined #bitcoin-core-dev 16:56 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 17:00 -!- yano1 [~yano@89.238.178.75] has quit [] 17:00 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 248 seconds] 17:00 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev 17:02 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection] 17:03 -!- cprofitt1 [~cprofitt@141.98.101.133] has joined #bitcoin-core-dev 17:06 -!- Netsplit *.net <-> *.split quits: vfP56jSe, gleb, gwillen, adiabat, Liliaceae, schmidty, nehan, Apocalyptic, TheV01d-, valwal___, (+2 more, use /NETSPLIT to show all of them) 17:06 -!- Netsplit over, joins: gwillen 17:06 -!- valwal___ [sid334773@gateway/web/irccloud.com/x-teustjwbxhtmkuct] has joined #bitcoin-core-dev 17:06 -!- TheV01d_ [thev01d@2001:19c0:1:801:851:ff00:1:6] has joined #bitcoin-core-dev 17:06 -!- gleb [sid306870@gateway/web/irccloud.com/x-lkmvofaebbvdcona] has joined #bitcoin-core-dev 17:06 -!- Netsplit over, joins: nehan 17:06 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-uqtmhlsozrjrnlmh] has joined #bitcoin-core-dev 17:06 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-pilwuektxvmmgyvx] has joined #bitcoin-core-dev 17:07 -!- schmidty [sid297174@gateway/web/irccloud.com/x-yfosxlgrnlcgdoev] has joined #bitcoin-core-dev 17:07 -!- nejon [sid38993@gateway/web/irccloud.com/x-mcdzzlciwftravxs] has joined #bitcoin-core-dev 17:07 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-hbdsdxhzuyjhjxww] has joined #bitcoin-core-dev 17:07 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-uqtmhlsozrjrnlmh] has quit [Changing host] 17:07 -!- jl2012 [sid133844@unaffiliated/jl2012] has joined #bitcoin-core-dev 17:07 -!- jl2012 [sid133844@unaffiliated/jl2012] has quit [Changing host] 17:07 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-uqtmhlsozrjrnlmh] has joined #bitcoin-core-dev 17:07 -!- schmidty [sid297174@gateway/web/irccloud.com/x-yfosxlgrnlcgdoev] has quit [Changing host] 17:07 -!- schmidty [sid297174@unaffiliated/schmidty] has joined #bitcoin-core-dev 17:07 -!- schmidty [sid297174@unaffiliated/schmidty] has quit [Changing host] 17:07 -!- schmidty [sid297174@gateway/web/irccloud.com/x-yfosxlgrnlcgdoev] has joined #bitcoin-core-dev 17:07 -!- Netsplit over, joins: Apocalyptic 17:07 -!- Netsplit over, joins: adiabat 17:09 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 248 seconds] 17:09 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 272 seconds] 17:11 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev 17:13 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 17:14 -!- pinheadmz [~matthewzi@globaldatalink1.old.static.monkeybrains.net] has quit [Client Quit] 17:14 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:9966:3487:db53:939a] has joined #bitcoin-core-dev 17:16 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:9966:3487:db53:939a] has quit [Client Quit] 17:21 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:9966:3487:db53:939a] has joined #bitcoin-core-dev 17:26 -!- r8921039 [~r8921039@173.239.65.123] has quit [Ping timeout: 272 seconds] 17:33 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 17:37 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 17:37 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 17:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:9966:3487:db53:939a] has quit [Quit: Sleep mode] 17:46 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zrmrphvvhhcgkfud] has quit [Quit: Connection closed for inactivity] 17:49 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-amoylfzofurlaziv] has quit [Ping timeout: 252 seconds] 17:53 -!- wbnns [sid105317@21/bitcoin/binns] has quit [Ping timeout: 258 seconds] 17:53 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-bbtmcqkbskflmmmi] has joined #bitcoin-core-dev 17:53 -!- mariorz [sid490@gateway/web/irccloud.com/x-jmrujhhpplpqatep] has quit [Ping timeout: 258 seconds] 17:55 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 17:55 -!- mariorz [sid490@gateway/web/irccloud.com/x-ngzxkxantultlval] has joined #bitcoin-core-dev 18:08 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 18:15 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 258 seconds] 18:17 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:22 < achow101> sipa: meshcollider: Instead of having the ScriptPubKeyManagers be the SigningProviders for CWallet, what do you think about keeping CWallet as a SigningProvider and just having it poll all of its ScriptPubKeyManagers for keys and scripts? I think this makes the implementation much simpler as it doesn't require knowing exactly which address type the output is in order to sign for it (as well as a bunch of other things that take 18:22 < achow101> SigingProviders) 18:26 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:27 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:31 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Ping timeout: 248 seconds] 18:31 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 18:35 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 244 seconds] 19:07 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Quit: WeeChat 2.4] 19:07 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 19:09 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5] 19:10 -!- omonk [~omonk@unaffiliated/omonk] has quit [Quit: quit] 19:12 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 19:13 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 19:17 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 244 seconds] 19:23 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds] 19:23 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 19:23 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds] 19:29 < sipa> achow101: did you see my comment on your issue? 19:30 < sipa> i think a more efficient interface is having a method that you give an sPK, and it gives you a SigningProvider for it 19:30 < sipa> which for the legacy one would just give its built-in bulky one 19:31 < sipa> and for descriptor based ones would expand the relevant descriptor at the right index and just return that 19:31 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 19:31 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 19:34 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Read error: Connection reset by peer] 19:34 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has joined #bitcoin-core-dev 19:38 -!- scoop [~scoop@globaldatalink1.old.static.monkeybrains.net] has quit [Ping timeout: 252 seconds] 19:48 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Ping timeout: 260 seconds] 19:49 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 19:51 < achow101> sipa: there are a few things I think that approach won't work for. I'll take a closer look at that tomorrow 19:53 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 19:57 < sipa> achow101: yeah, i believe that; it's just a suggestion 19:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:58 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 268 seconds] 20:00 -!- cprofitt1 [~cprofitt@141.98.101.133] has quit [] 20:00 -!- surja795 [~sourabh@76.118.169.20] has quit [Ping timeout: 245 seconds] 20:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 20:03 -!- ElectroBNC [~ElectroBN@184.75.223.219] has joined #bitcoin-core-dev 20:09 -!- bralyclow01 [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection] 20:10 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 20:12 -!- surja795 [~sourabh@76.118.169.20] has joined #bitcoin-core-dev 20:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:22 -!- jtimon [~quassel@205.201.35.37.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds] 20:29 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 20:34 -!- r8921039 [~r8921039@2601:644:302:9760:d1f5:1d3e:1232:6831] has joined #bitcoin-core-dev 20:39 -!- r8921039 [~r8921039@2601:644:302:9760:d1f5:1d3e:1232:6831] has quit [Ping timeout: 252 seconds] 20:47 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 20:51 -!- surja795 [~sourabh@76.118.169.20] has quit [Ping timeout: 252 seconds] 20:51 -!- lafretini [488fd349@72.143.211.73] has joined #bitcoin-core-dev 20:53 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection] 20:54 -!- lafretini [488fd349@72.143.211.73] has quit [Remote host closed the connection] 21:02 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:04 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Remote host closed the connection] 21:04 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Client Quit] 21:05 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 21:07 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:16 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 21:20 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 268 seconds] 21:27 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:28 -!- profmac [~ProfMac@2001:470:1f0f:226:3490:9e93:6e8f:7a58] has quit [Ping timeout: 252 seconds] 21:35 < meshcollider> achow101: I thought that was handled by just checking IsMine on all of them anyway 21:40 < achow101> ngl, I think I did it way too rushed. If you look at the commits in my box-the-wallet branch, you'll see that they quality of each commit starts dropping off rapidly towards the end. I'll probably end up redoing a large chunk of it anyways 21:40 < achow101> at least now I know what all needs to actually be changed 21:42 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:43 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 21:51 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Remote host closed the connection] 21:52 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 21:57 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds] 22:06 -!- hebasto [9fe07a9c@159.224.122.156] has joined #bitcoin-core-dev 22:10 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:11 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 22:22 < fanquake> Has anyone else seen a crash similar too #16027 ? I don't think it's related solely to sleep/hibernation, as I've had two occurrences, both happening right after unloading a wallet. Unfortunately not running under lldb in either case.. 22:22 < gribble> https://github.com/bitcoin/bitcoin/issues/16027 | client 0.18.0 crashes when computer wakes up from hibernation · Issue #16027 · bitcoin/bitcoin · GitHub 22:26 -!- surja795 [~sourabh@2601:18e:100:b5c0:cdcc:1ec4:72b5:2aad] has joined #bitcoin-core-dev 22:26 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:27 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 22:30 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Client Quit] 22:32 -!- surja795 [~sourabh@2601:18e:100:b5c0:cdcc:1ec4:72b5:2aad] has quit [Ping timeout: 276 seconds] 22:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 22:47 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 22:51 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 22:52 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 244 seconds] 23:00 -!- ElectroBNC [~ElectroBN@184.75.223.219] has quit [] 23:00 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 23:04 -!- lgedeon [~lgedeon@141.98.101.133] has joined #bitcoin-core-dev 23:08 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 23:09 -!- baldur [~baldur@pool-108-30-43-28.nycmny.fios.verizon.net] has quit [Ping timeout: 258 seconds] 23:13 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 252 seconds] 23:17 -!- jchnak [d563ddb9@gateway/web/cgi-irc/kiwiirc.com/ip.213.99.221.185] has quit [Remote host closed the connection] 23:22 -!- baldur [~baldur@pool-108-30-43-28.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:37 -!- JamesAU [~jamesau@49.148.205.19] has joined #bitcoin-core-dev 23:38 -!- JamesAU [~jamesau@49.148.205.19] has quit [Client Quit] 23:49 -!- r8921039 [~r8921039@67.180.158.179] has joined #bitcoin-core-dev 23:53 -!- r8921039 [~r8921039@67.180.158.179] has quit [Ping timeout: 258 seconds] --- Log closed Thu Jun 27 00:00:54 2019