--- Log opened Tue Jul 09 00:00:05 2019 00:01 -!- as1nc_ [~as1nc@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 258 seconds] 00:03 -!- murr4y [ali@11.0.196.35.bc.googleusercontent.com] has quit [Quit: WeeChat 1.9.1] 00:04 -!- murr4y [ali@11.0.196.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 00:05 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has joined #bitcoin-core-dev 00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:17 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:20 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:59 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 01:04 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:06 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:15 -!- Xunie [~Xunie@unaffiliated/xunie] has quit [Remote host closed the connection] 01:15 -!- Xunie [~Xunie@unaffiliated/xunie] has joined #bitcoin-core-dev 01:20 < wumpus> "BIP148 user activated activation of segwit" huuuh that's a bit late 01:45 < aj> not if there's a ~100k block reorg! 01:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:51 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 01:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 260 seconds] 02:00 -!- Mark_Cockrell [~Mark_Cock@178.162.204.238] has quit [] 02:00 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 02:03 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:05 -!- billstclair1 [~billstcla@104.254.90.243] has joined #bitcoin-core-dev 02:08 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:09 < bitcoin-git> [bitcoin] laanwj closed pull request #16357: util: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357 02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:25 -!- darosior [~darosior@107.175.255.247] has joined #bitcoin-core-dev 02:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 02:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:48 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c799976c86e2...8046a3e0befe 02:48 < bitcoin-git> bitcoin/master f27bd96 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*) 02:48 < bitcoin-git> bitcoin/master 64fee48 João Barbosa: qt: Assert QMetaObject::invokeMethod result 02:48 < bitcoin-git> bitcoin/master 8046a3e Wladimir J. van der Laan: Merge #16348: qt: Assert QMetaObject::invokeMethod result 02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:49 < bitcoin-git> [bitcoin] laanwj merged pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348 02:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:08 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 03:15 -!- goatpig [537241de@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has quit [Remote host closed the connection] 03:18 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 03:36 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 03:41 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds] 03:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:58 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 268 seconds] 04:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 04:02 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:12 < bitcoin-git> [bitcoin] conscott closed pull request #14691: tests: Speedup feature_pruning test and refactor big transaction logic (master...2018_11_opreturn_splices) https://github.com/bitcoin/bitcoin/pull/14691 04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:28 -!- goatpig [537241de@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has joined #bitcoin-core-dev 04:36 -!- hi102 [492ac633@c-73-42-198-51.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 04:42 -!- torkelrogstad [~quassel@195-159-115-158.customer.powertech.no] has joined #bitcoin-core-dev 04:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 04:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 04:51 -!- lesderid_ [~lesderid@2a03:b0c0:1:d0::2a5:4002] has joined #bitcoin-core-dev 04:54 -!- xhire_ [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 04:55 -!- xhire_ [~xHire@kos.paskuli.cz] has quit [Client Quit] 04:55 -!- xhire_ [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 04:56 -!- Netsplit *.net <-> *.split quits: moneyball, pierre_rochard, nullptr|, jamesob, xHire, takinbo, lesderid, peltre, emzy, ahmed_ 04:57 -!- xhire_ [~xHire@kos.paskuli.cz] has quit [Client Quit] 04:57 -!- Netsplit over, joins: xHire 04:57 -!- lesderid_ is now known as lesderid 05:00 -!- billstclair1 [~billstcla@104.254.90.243] has quit [] 05:01 -!- nullptr| [~nullptr|@2001:bc8:47a4:241::1] has joined #bitcoin-core-dev 05:01 -!- peltre [sid268329@gateway/web/irccloud.com/x-weyqdzoaoqldjlrq] has joined #bitcoin-core-dev 05:01 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-aigniysssfcgylbe] has joined #bitcoin-core-dev 05:01 -!- takinbo [sid19838@gateway/web/irccloud.com/x-khjxhymesieoomuc] has joined #bitcoin-core-dev 05:01 -!- moneyball [sid299869@gateway/web/irccloud.com/x-iyblqpsknmubaxkl] has joined #bitcoin-core-dev 05:01 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-knhxbumcudauvjou] has joined #bitcoin-core-dev 05:01 -!- jamesob [sid180710@gateway/web/irccloud.com/x-fegdhdwyjeczkkxm] has joined #bitcoin-core-dev 05:01 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev 05:04 -!- peltre [sid268329@gateway/web/irccloud.com/x-weyqdzoaoqldjlrq] has quit [Ping timeout: 246 seconds] 05:04 -!- lliehu1 [~lliehu@104.254.90.243] has joined #bitcoin-core-dev 05:04 -!- peltre [sid268329@gateway/web/irccloud.com/x-uuozmlmuelfkndbe] has joined #bitcoin-core-dev 05:05 -!- jonatack [d598a123@213.152.161.35] has joined #bitcoin-core-dev 05:08 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:10 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Client Quit] 05:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 05:13 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:16 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 260 seconds] 05:16 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Client Quit] 05:17 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 05:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 05:33 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev 05:37 -!- jonatack [d598a123@213.152.161.35] has quit [Remote host closed the connection] 05:45 < promag> hebasto: please rebase #16349 05:45 < gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Remove redundant WalletController::addWallet signal by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub 05:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 05:47 < hebasto> promag: ... in process right now 05:52 < hebasto> promag: done. 05:58 < promag> #16348 should be backport 05:58 < gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub 06:02 < hebasto> MarcoFalke: hi, are you around? 06:02 < wumpus> promag: the bug also exists in 0.18? 06:04 < hebasto> MarcoFalke: I'm going to rebase my PR and implement your suggestion. Could you look into https://github.com/bitcoin/bitcoin/pull/15864#discussion_r301258664 ? 06:05 < promag> wumpus: yes, the code is in 0.18 06:05 < wumpus> promag: ok, will label it for backport 06:06 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:15 < bitcoin-git> [bitcoin] darosior opened pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] promag opened pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:19 < promag> thanks wumpus & fanquake 06:20 < fanquake> promag 👍 06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] darosior closed pull request #16358: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16358 06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:24 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] darosior opened pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360 06:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:30 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 06:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:37 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:40 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 06:40 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:43 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:55 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:56 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:00 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 07:01 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 07:05 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 245 seconds] 07:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ctpyxhufvaopmtzd] has joined #bitcoin-core-dev 07:08 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:08 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem] 07:08 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:13 < bitcoin-git> [bitcoin] instagibbs opened pull request #16361: Remove redundant pre-TopUpKeypool checks (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:14 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 07:20 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 07:26 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 07:31 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 258 seconds] 07:34 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev 07:35 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 07:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:40 -!- pbase [~pbase@unaffiliated/pbase] has quit [Remote host closed the connection] 07:40 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds] 07:41 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:51 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 08:00 -!- lliehu1 [~lliehu@104.254.90.243] has quit [] 08:04 -!- dos11 [~dos1@139.28.218.198] has joined #bitcoin-core-dev 08:05 -!- davterra [~tralfaz@178.128.106.205] has joined #bitcoin-core-dev 08:16 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:16 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Client Quit] 08:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 08:41 -!- as1nc [~as1nc@2a01:e35:2429:dc20:309f:c7f9:6e2e:cd75] has joined #bitcoin-core-dev 08:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:50 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 08:52 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:08 -!- scoop [~scoop@2601:240:d780:33e8:a994:5b97:a6f4:3a69] has joined #bitcoin-core-dev 09:12 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:12 -!- scoop [~scoop@2601:240:d780:33e8:a994:5b97:a6f4:3a69] has quit [Ping timeout: 252 seconds] 09:15 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 09:19 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 272 seconds] 09:20 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:26 -!- scoop [~scoop@2601:240:d700:b3a:d046:9541:9321:e2b0] has joined #bitcoin-core-dev 09:28 -!- StopAndDecrypt_ [~StopAndDe@197.189.219.146] has quit [Ping timeout: 258 seconds] 09:28 -!- StopAndDecrypt [~StopAndDe@197.189.219.146] has joined #bitcoin-core-dev 09:28 -!- StopAndDecrypt [~StopAndDe@197.189.219.146] has quit [Client Quit] 09:30 -!- scoop [~scoop@2601:240:d700:b3a:d046:9541:9321:e2b0] has quit [Ping timeout: 276 seconds] 09:36 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 09:44 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:44 -!- torkelrogstad [~quassel@195-159-115-158.customer.powertech.no] has quit [Ping timeout: 248 seconds] 09:47 -!- harding [~harding@c-73-196-98-36.hsd1.nj.comcast.net] has quit [Quit: leaving] 09:50 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 245 seconds] 09:51 -!- scoop [~scoop@c-73-74-167-11.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:54 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 09:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 09:57 -!- scoop [~scoop@c-73-74-167-11.hsd1.il.comcast.net] has quit [Remote host closed the connection] 09:57 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 245 seconds] 10:05 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:06 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 10:30 -!- sfhi [~sfhi@178.255.154.107] has joined #bitcoin-core-dev 10:45 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 10:53 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 10:53 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 11:00 -!- dos11 [~dos1@139.28.218.198] has quit [] 11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:01 < bitcoin-git> [bitcoin] hebasto opened pull request #16362: gui: Bilingual translation (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362 11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:02 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 11:05 -!- wotwot1 [~wotwot@104.254.90.243] has joined #bitcoin-core-dev 11:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363 11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:32 -!- sfhi [~sfhi@178.255.154.107] has quit [Quit: Leaving] 11:43 -!- lightlike [~lightlike@2001:16b8:577d:7000:3de5:59a6:7cac:196] has joined #bitcoin-core-dev 11:50 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] --- Log closed Tue Jul 09 11:51:00 2019 --- Log opened Tue Jul 09 11:51:00 2019 11:56 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 12:00 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 12:00 -!- jarthur [~jarthur@207.114.244.5] has quit [] 12:00 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 12:10 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds] 12:16 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 12:25 -!- tryphe_ is now known as tryphe 12:26 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 12:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 12:28 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 12:36 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 258 seconds] 12:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 12:48 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection] 12:49 -!- Netsplit *.net <-> *.split quits: nickler 12:49 -!- Netsplit over, joins: nickler 13:13 -!- hexyul [~omonk@unaffiliated/omonk] has quit [Ping timeout: 258 seconds] 13:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 13:15 -!- hexyul [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 13:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 13:49 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Quit: Something is wrong...] 13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:58 < bitcoin-git> [bitcoin] LarryRuane opened pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365 13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 -!- wotwot1 [~wotwot@104.254.90.243] has quit [] 14:00 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 14:04 -!- pdurbin1 [~pdurbin@141.98.101.133] has joined #bitcoin-core-dev 14:06 -!- as1nc_ [~as1nc@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 14:07 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 245 seconds] 14:08 -!- as1nc [~as1nc@2a01:e35:2429:dc20:309f:c7f9:6e2e:cd75] has quit [Remote host closed the connection] 14:10 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 14:14 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 14:21 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev 14:42 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem] 14:46 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 14:50 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 14:51 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 15:03 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 15:03 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 15:03 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 15:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:26 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 15:47 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 15:47 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has joined #bitcoin-core-dev 15:50 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:52 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:52 -!- janissary2k [~moon@179.183.80.209] has joined #bitcoin-core-dev 15:54 -!- hugohn [~textual@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Client Quit] 15:55 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has quit [Ping timeout: 248 seconds] 15:55 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 15:57 -!- BillyGarrison [8e861c5d@142.134.28.93] has joined #bitcoin-core-dev 15:58 -!- janissary2k [~moon@179.183.80.209] has quit [Ping timeout: 272 seconds] 15:58 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 16:00 < BillyGarrison> Looking to change a doc typo and I have some questions. Please let me know if I'm in the wrong place. 16:00 < sipa> BillyGarrison: shoot 16:03 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 16:04 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 16:04 < BillyGarrison> In the CONTRIBUTING.md it says to fork, create branch, commit to branch, and submit PR. Should I submit the PR to put the changes into master? Do I need to worry about branch name conflicts? 16:05 < BillyGarrison> Under the refactoring section of the contributor guide it says that trivial PRs may be rejected to save time. Does this also apply to a trivial typo fix or does it specifically mean trivial refactoring PRs? 16:05 < sipa> Yes, always submit changes to master; maintainers will backport them to release branches where desired 16:05 < sipa> fixing a single typo is probably not worth it 16:05 < sipa> if you have a whole bunch that you can fix at once, maybe 16:07 < BillyGarrison> That's good to know, thanks. I will make note of any typos I find and submit them all together at a later point. 16:07 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has joined #bitcoin-core-dev 16:09 < sipa> and thank you for looking into ways to contribute (and reading the guidelines!) 16:13 < BillyGarrison> (y) hoping to be able to contribute to functional testing eventually 16:22 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 16:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8046a3e0befe...357488f660a5 16:33 < bitcoin-git> bitcoin/master 0ab8ba1 Karl-Johan Alm: rpc: fix RPC help requirements for getblocktemplate 16:33 < bitcoin-git> bitcoin/master 5c5e32b Karl-Johan Alm: rpc: migrate JSONRPCRequest functionality into request.cpp 16:33 < bitcoin-git> bitcoin/master c7a9fc2 Karl-Johan Alm: Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper 16:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16240: JSONRPCRequest-aware RPCHelpMan (master...2019-06-json-aware-helper) https://github.com/bitcoin/bitcoin/pull/16240 16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:37 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:48 < bitcoin-git> [bitcoin] darosior closed pull request #16360: Upgrade encrypted wallet (master...upgrade_encrypted_wallet) https://github.com/bitcoin/bitcoin/pull/16360 16:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:52 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:58 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 16:59 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 17:00 -!- pdurbin1 [~pdurbin@141.98.101.133] has quit [] 17:04 -!- hoobop1 [~hoobop@192.145.126.244] has joined #bitcoin-core-dev 17:05 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 17:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 17:09 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds] 17:11 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds] 17:16 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 17:18 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has quit [Quit: Leaving] 17:19 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has joined #bitcoin-core-dev 17:22 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has quit [Client Quit] 17:22 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has joined #bitcoin-core-dev 17:23 < jb55> I screwed up my first psbt, I didn't realize core created a sh(wpkh()) change address to m/84' which would have been a funds loss to a regular trezor user. hopefully future wallet devs don't make that mistake. 17:24 -!- Xunie [~Xunie@unaffiliated/xunie] has quit [Ping timeout: 264 seconds] 17:24 < jb55> not really "loss" but would require some manual recovery with sign-tx which I just did 17:24 < sipa> jb55: core doesn't care about derivation paths 17:24 < jb55> yeah 17:24 < sipa> it creates whatever you imported as change 17:24 -!- Xunie [~Xunie@unaffiliated/xunie] has joined #bitcoin-core-dev 17:25 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-ldkqzjsphmtzpfbg] has quit [Quit: Connection closed for inactivity] 17:25 < jb55> I'm just thinking about people building hardware wallet stuff, since core only cares about addresses and not paths, would be a common source of dev errors I predict 17:27 < jb55> afaik native descriptor wallets don't help here either if I understand that PR correctly 17:28 -!- Xunie_ [~Xunie@unaffiliated/xunie] has joined #bitcoin-core-dev 17:30 -!- Xunie [~Xunie@unaffiliated/xunie] has quit [Ping timeout: 272 seconds] 17:32 < sipa> i don't see how it would be related, no 17:33 < jb55> sipa: with importmulti I imported wpkh addresses, but when I dumpwallet I see sh(wpkh()) addresses. I'm still a bit confused as to what is actually stored on disk 17:34 < jb55> just pubkeys? 17:36 < sipa> jb55: keys and scripts 17:36 < sipa> and what is treated as "mine" is a based om complex historically grown rules that make little sense 17:37 < jb55> it's possible I screwed something up, but I find it weird that it would generate sh(wpkh()) change addresses after a wpkh import. I guess that descriptor info isn't retained and it just does p2sh-segwit by default 17:37 < sipa> jb55: importing something (for now) in now restricts it to be importing just that 17:38 < sipa> it does make sure the result is "policy compatible"; e.g. importing a multisig will never result in your wallet treating payments to individual keys in it as your 17:38 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds] 17:38 < sipa> but other than that... the current representation simply has no way to represent one exact type of imported things... it's just keys and script 17:38 < sipa> that's actually the entire reason why i started working on descriptors 17:39 < sipa> *in now -> in no way 17:41 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 17:42 < jb55> sipa: cool. in the meantime I'll be more careful with psbts... 17:43 < sipa> with getrawchangeaddress you can control what type of address you create 17:45 < jb55> yeah and there's a change_type option in createwalletfundedpsbt I just forgot to set it to bech32 :[ 17:47 < jb55> s/createwalletfundedpsbt/walletcreatefundedpsbt/ 18:02 -!- lightlike [~lightlike@2001:16b8:577d:7000:3de5:59a6:7cac:196] has quit [Quit: Leaving] 18:14 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 18:31 -!- BillyGarrison [8e861c5d@142.134.28.93] has quit [Ping timeout: 260 seconds] 18:56 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:59 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:01 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 19:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 19:05 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds] 19:05 -!- esotericnonsens_ [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 19:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:14 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:21 -!- ghost43_ is now known as ghost43 19:22 -!- JamesAU [~jamesau@49.151.93.201] has joined #bitcoin-core-dev 19:26 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 19:45 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 19:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 19:46 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:46 -!- hugohn [~textual@pool-71-167-27-172.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds] 19:59 -!- JamesAU [~jamesau@49.151.93.201] has quit [] 19:59 -!- hugohn [uid304114@gateway/web/irccloud.com/x-jthywcxjasmhusgu] has joined #bitcoin-core-dev 20:00 -!- hoobop1 [~hoobop@192.145.126.244] has quit [] 20:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:04 -!- kenperkins [~kenperkin@185.5.172.148] has joined #bitcoin-core-dev 20:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:26 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5] 21:18 < achow101> jb55: native descriptor wallets will help as you would import one descriptor for change sh(wpkh()) and a different for wpkh() and so on 21:19 < achow101> but the wallet currently treats all keys the same and any key can be used for p2sh-segwit, legacy, or bech32 21:21 < achow101> jb55: if you're using Core + HWI, it shouldn't matter to you whether the path is the type the trezor expects. it will still sign regardless, just complain when the path isn't what it expects 21:21 < jb55> achow101: that means that combo multiimports should do the same thing as any other multiimport on the same range? 21:21 < achow101> right now it does 21:21 < achow101> in theory 21:23 < jb55> achow101: it prompted the change address on the trezor display, because I guess it thought it was someone else's address. 21:23 < jb55> Makes sense in hindsight, thought it was just some bug 21:24 < achow101> IIRC change detection is disabled for trezor by HWI 21:25 < achow101> so that should be expected behavior regardless of derivation path 21:25 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 21:25 < achow101> I don't think we give it the derivation path for outputs (yet). This is intentional behavior because change detection isn't very smart 21:26 < jb55> ah ok yeah I read about, and assumed that what was happening the first time around 21:27 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has quit [Quit: Leaving] 21:30 < jb55> achow101: one thing I couldn't get working was a walletcreatefundedpsbt that was flexible enough to express a sh(wpkh(m/84'/..)) -> wpkh(m/84'/...) tx. I tried specifying a specific change address with no outputs but that wasn't allowed 21:31 < jb55> so I ended up just doing an interactive trezorctl sign-tx 21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:32 < jb55> perhaps createpsbt could do this but I'm not sure how to get that to work with hwi... 21:33 < achow101> jb55: huh? was it not filling in the input, or did it not like the output? what about itwasn't working? 21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds] 21:34 < jb55> achow101: input was fine, but I only wanted one output which was the exact same derivation path but as a wpkh output instead of sh(wpkh). I couldn't figure out how to do that with walletcreatefundedpsbt. 21:35 < achow101> just get a new address, set that as the output, and use the option "subtractFeeFromOutputs":[0] 21:35 < jb55> that's the ticket 21:35 < achow101> and send the full input amount to that output 21:36 < achow101> it shouldn't care 21:36 < jb55> that's good to know, I haven't used that option before but that makes sense! 21:39 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 21:49 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 21:55 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:59 -!- hebasto [9fe07a9c@159.224.122.156] has joined #bitcoin-core-dev 22:13 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds] 22:20 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 22:21 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ctpyxhufvaopmtzd] has quit [Quit: Connection closed for inactivity] 22:22 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Ping timeout: 245 seconds] 22:28 < hebasto> MarcoFalke: hi! if #16362 has been marked with 0.19.0 milestone, could #16224 be marked 0.19.0 milestone as well? 22:28 < gribble> https://github.com/bitcoin/bitcoin/issues/16362 | gui: Bilingual translation by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub 22:28 < gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub 22:30 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has joined #bitcoin-core-dev 22:50 -!- state_bits [~state_bit@178.128.177.41] has quit [Ping timeout: 245 seconds] 22:51 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 22:51 -!- windsok [~windsok@unaffiliated/windsok] has quit [Remote host closed the connection] 22:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 260 seconds] 22:52 -!- state_bits [~state_bit@2604:a880:2:d0::216b:7001] has joined #bitcoin-core-dev 22:53 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev 22:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 23:00 -!- kenperkins [~kenperkin@185.5.172.148] has quit [] 23:01 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 23:13 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 23:21 -!- fnichol [~fnichol@195.206.169.238] has joined #bitcoin-core-dev 23:32 -!- hugohn [uid304114@gateway/web/irccloud.com/x-jthywcxjasmhusgu] has quit [Quit: Connection closed for inactivity] 23:43 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection] 23:43 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev 23:44 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:47 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 23:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 23:57 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:58 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 260 seconds] --- Log closed Wed Jul 10 00:00:05 2019