--- Log opened Fri Jul 12 00:00:09 2019
00:07 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds]
00:13 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
00:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
00:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
00:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
00:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:33 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds]
00:35 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
00:39 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
00:52 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
01:03 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
01:15 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
01:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:20 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 245 seconds]
01:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:25 -!- jonatack [b9cee133@185.206.225.51] has joined #bitcoin-core-dev
01:27 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]
01:28 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #bitcoin-core-dev
01:45 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
01:47 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
01:51 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:54 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 246 seconds]
01:59 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
02:00 -!- limpkin1 [~limpkin@89.238.178.75] has quit []
02:01 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
02:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 245 seconds]
02:03 -!- scoop_ [~scoop@205.178.77.52] has joined #bitcoin-core-dev
02:04 -!- pleia21 [~pleia2@199.19.94.16] has joined #bitcoin-core-dev
02:14 -!- Guest30053 [~justanoth@cpe-74-68-58-58.nj.res.rr.com] has joined #bitcoin-core-dev
02:15 -!- scoop_ [~scoop@205.178.77.52] has quit [Remote host closed the connection]
02:20 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds]
02:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
02:27 -!- jonatack [b9cee133@185.206.225.51] has quit [Ping timeout: 260 seconds]
02:38 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:43 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
02:43 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
02:44 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
02:44 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Ping timeout: 245 seconds]
02:48 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 245 seconds]
02:58 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
03:08 < fanquake> Hopefully no-one has to clean any toilets.. https://github.com/bitcoin/bitcoin/pull/16248#issuecomment-510831024
03:08 -!- dviola [~diego@179.153.226.110] has joined #bitcoin-core-dev
03:09 -!- dviola [~diego@179.153.226.110] has quit [Changing host]
03:09 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
03:21 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
03:27 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds]
03:34 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:46 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
03:46 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:46 -!- IGHOR [~quassel@93.178.216.72] has quit [Client Quit]
03:51 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 268 seconds]
03:52 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
03:55 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
04:01 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 244 seconds]
04:04 -!- designwish [~designwis@51.ip-51-68-136.eu] has quit [Quit: ZNC - http://znc.in]
04:04 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Quit: bye]
04:06 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
04:07 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev
04:11 -!- designwish [~designwis@51.ip-51-68-136.eu] has joined #bitcoin-core-dev
04:16 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
04:16 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
04:22 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:37 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds]
04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:41 < bitcoin-git> [bitcoin] Sjors opened pull request #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt (master...2019/07/walletcreatefundedpsbt_addinputs) https://github.com/bitcoin/bitcoin/pull/16377
04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:52 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 248 seconds]
04:56 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev
04:59 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
05:00 -!- pleia21 [~pleia2@199.19.94.16] has quit []
05:01 -!- goatpig [537241de@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has joined #bitcoin-core-dev
05:04 -!- csslayer [~csslayer@185.204.1.185] has joined #bitcoin-core-dev
05:04 -!- csslayer is now known as Guest16440
05:15 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-juixrrwbybhjklzv] has joined #bitcoin-core-dev
05:22 -!- threewater027 [767268f0@118.114.104.240] has joined #bitcoin-core-dev
05:24 -!- threewater027 [767268f0@118.114.104.240] has quit [Remote host closed the connection]
05:45 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
05:47 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
05:48 -!- lightlike [~lightlike@2001:16b8:5782:f900:549f:2074:c3a0:81d8] has joined #bitcoin-core-dev
05:50 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
05:55 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
05:56 -!- Guest30053 [~justanoth@cpe-74-68-58-58.nj.res.rr.com] has quit [Quit: WeeChat 2.4]
05:58 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
05:59 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
05:59 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:00 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has quit [Read error: Connection reset by peer]
06:00 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has joined #bitcoin-core-dev
06:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
06:02 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 245 seconds]
06:35 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
06:37 -!- gelmutshmidt [~gelmutshm@188.113.53.102] has joined #bitcoin-core-dev
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:51 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:57 < bitcoin-git> [bitcoin] Sjors opened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
07:05 -!- hebasto [9fe07a9c@159.224.122.156] has quit [Remote host closed the connection]
07:06 -!- Aaronvan_ is now known as AaronvanW
07:16 < sdaftuar> if we're making a regular outbound connection and our peer has fRelayTxes=false when we connect (ie because that node is running in -blocksonly mode, i'm guessing?) should we disconnect?
07:17 < sdaftuar> now that -blocksonly is not a hidden option, i think we should probably do something to ensure we have sufficient tx-relay peers
07:17 < sdaftuar> opinions?
07:23 < jamesob> sounds reasonable to me. I'd say this would be especially important if we're more lenient with fRelayTxes=false peers re: eviction based on some kind of inactivity ("I haven't received an INV from this peer in n minutes") but I don't think that's the case at the moment
07:25 < jamesob> the rationale being that it'd take fewer resources to sybil broadly with a bunch of -blocksonly nodes, but again I don't think that's the case atm
07:29 < sdaftuar> i don't think there's a partition risk introduced by this, i'm more thinking that we have no protections in our code against our 8 regular outbounds all being run in -blocksonly mode and so there's an edge case where we are surprised to not receive transactions at all
07:30 < sdaftuar> i'm not sure how much transaction-relaying peers is sufficient, but it'd be easy to detect a blocksonly peer when we're looking for a regular peer and just disconnect, i think.  might be too heavy-handed though?
07:32 < jamesob> is ensuring some min ratio of regular peers too special casey?
07:34 < sdaftuar> well, there are only 9 values to choose from when it comes to the number of blocksonly peers you'd tolerate as a "regular" outbound, so i think we can just pick where to set that threshold :)
07:34 < sdaftuar> (i don't think we should include inbounds in that calculation)
07:39 -!- gleb [sid306870@gateway/web/irccloud.com/x-lkmvofaebbvdcona] has left #bitcoin-core-dev []
07:39 -!- gleb [sid306870@gateway/web/irccloud.com/x-lkmvofaebbvdcona] has joined #bitcoin-core-dev
07:40 -!- nmnkgl [~nmnkgl@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
07:43 -!- gleb [sid306870@gateway/web/irccloud.com/x-lkmvofaebbvdcona] has left #bitcoin-core-dev []
07:43 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:44 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
07:44 -!- gleb [sid306870@gateway/web/irccloud.com/x-obnyzlufybbwvrkv] has joined #bitcoin-core-dev
07:48 < gleb> hi
07:48 < gleb> sdaftuar: Why there is no explicit p2p message when "fRelayTxes=false"?
07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:50 < sdaftuar> it's a hack -- we use a bit added to version messages when bip37 was rolled out to communicate that we don't want to enable transaction relay
07:50 < sdaftuar> see https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki
07:51 < gleb> So why we don't want to keep using this bit when identifying a fRelayTxes=false on other side?
07:51 < sdaftuar> because bip37 allows for transaction relay to be re-enabled later in the connection's lifetime
07:52 < sdaftuar> i'm not sure whether bip37 support is currently default on or off right now in our software, but we should do something more explicit for blocksonly connections in the future, i think.
07:52 < gleb> Oh, I See. So something like an explicit message? :)
07:53 < sdaftuar> yes
07:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:58 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:00 -!- Guest16440 [~csslayer@185.204.1.185] has quit []
08:04 -!- peeja [~peeja@185.204.1.185] has joined #bitcoin-core-dev
08:10 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
08:10 -!- nmnkgl [~nmnkgl@rrcs-184-74-240-156.nyc.biz.rr.com] has quit []
08:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
08:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
08:27 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
08:34 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
08:40 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
08:44 -!- amnesiac [~amnesiac@bba483212.alshamil.net.ae] has joined #bitcoin-core-dev
08:46 -!- amnesiac [~amnesiac@bba483212.alshamil.net.ae] has left #bitcoin-core-dev []
08:46 -!- mnarix [~lwnmaro@77.243.22.143] has joined #bitcoin-core-dev
08:47 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
08:48 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds]
08:58 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
09:01 -!- rutyiraw [~lwnmaro@77.243.22.143] has joined #bitcoin-core-dev
09:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:05 -!- mnarix [~lwnmaro@77.243.22.143] has quit [Ping timeout: 245 seconds]
09:07 < lightlike> sdaftuar: looks like bip37 support is on per default, but will possibly be disabled if #16152 is merged
09:07 < gribble> https://github.com/bitcoin/bitcoin/issues/16152 | Disable bloom filtering by default. by TheBlueMatt · Pull Request #16152 · bitcoin/bitcoin · GitHub
09:07 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:08 < bitcoin-git> [bitcoin] hebasto opened pull request #16379: Fix autostart filenames Linux for testnet/regtest (master...20190712-fix-autostart) https://github.com/bitcoin/bitcoin/pull/16379
09:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:09 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
09:11 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
09:14 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
09:15 -!- nijak [~nijak@141.98.255.151] has joined #bitcoin-core-dev
09:15 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:16 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has quit [Ping timeout: 244 seconds]
09:17 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:18 -!- jonatack [d598a272@213.152.162.114] has joined #bitcoin-core-dev
09:22 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
09:22 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Client Quit]
09:25 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
09:29 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Client Quit]
09:31 -!- double_helix [~pi@94-168-81-10.static.v4.ziggozakelijk.nl] has quit [Ping timeout: 272 seconds]
09:32 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
09:57 -!- itsiku [~itsiku@abelohost-34.207.207.185.dedicated-ip.abelons.com] has quit [Quit: leaving]
09:58 -!- itsiku [~itsiku@abelohost-34.207.207.185.dedicated-ip.abelons.com] has joined #bitcoin-core-dev
10:01 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:09 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
10:09 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
10:16 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
10:20 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 246 seconds]
10:20 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:23 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds]
10:24 < BlueMatt> seems like something that should just get merged :)
10:24 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:25 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/735d6b57e795...3453cf26dbaf
10:25 < bitcoin-git> bitcoin/master 3e80ec3 Carl Dong: contrib: Add deterministic Guix builds.
10:25 < bitcoin-git> bitcoin/master 8dff3e4 Carl Dong: contrib: guix: Clarify SOURCE_DATE_EPOCH.
10:25 < bitcoin-git> bitcoin/master cd3e947 Carl Dong: contrib: guix: Various improvements.
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:25 < bitcoin-git> [bitcoin] laanwj closed pull request #16310: refactor: small optimization for IsHex method (master...master) https://github.com/bitcoin/bitcoin/pull/16310
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:26 < bitcoin-git> [bitcoin] laanwj merged pull request #15277: contrib: Enable building in Guix containers (master...2019-01-guix) https://github.com/bitcoin/bitcoin/pull/15277
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:27 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:39 < instagibbs> BlueMatt, marked "waiting for author" for some reason....
10:41 < achow101> so are we now using guix for deterministic builds instead of gitian?
10:41 < BlueMatt> instagibbs: dunno why?
10:41 < BlueMatt> looks fine to me
10:42 < instagibbs> Marco said stuff in his ACK, but you need to say "Shove it" and he'll merge
10:42 < instagibbs> ;)
10:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:43 < BlueMatt> right, I dont know that the release note categories are
10:43 < instagibbs> achow101, https://github.com/bitcoin/bitcoin/tree/master/contrib/guix looks like you're supposed ot be able to use it
10:44 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
10:46 -!- nijak_ [~nijak@141.98.255.151] has joined #bitcoin-core-dev
10:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
10:47 -!- nijak [~nijak@141.98.255.151] has quit [Ping timeout: 244 seconds]
10:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:57 < dongcarl> achow101: This section was written specifically for you: https://github.com/bitcoin/bitcoin/tree/master/contrib/guix#speeding-up-builds-with-substitute-servers
10:57 < dongcarl> <3
10:59 -!- nijak [~nijak@141.98.255.144] has joined #bitcoin-core-dev
10:59 -!- nijak_ [~nijak@141.98.255.151] has quit [Ping timeout: 248 seconds]
11:00 -!- peeja [~peeja@185.204.1.185] has quit []
11:12 -!- Wolfy87 [~Wolfy87@178.162.204.238] has joined #bitcoin-core-dev
11:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
11:16 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 245 seconds]
11:16 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
11:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
11:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:26 -!- jonatack [d598a272@213.152.162.114] has left #bitcoin-core-dev []
11:26 -!- jonatack [d598a272@213.152.162.114] has joined #bitcoin-core-dev
11:29 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-juixrrwbybhjklzv] has quit []
11:33 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev
11:43 -!- xwirton [~lwnmaro@77.243.22.205] has joined #bitcoin-core-dev
11:43 -!- rutyiraw [~lwnmaro@77.243.22.143] has quit [Read error: Connection reset by peer]
11:50 < emilengler> Can someone help me? I'm currently stucking at a PR and I have no idea why the travis build is failing on the tests (https://travis-ci.org/bitcoin/bitcoin/jobs/557960750)
11:56 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Quit: ZNC 1.6.3+deb1ubuntu0.1 - http://znc.in]
11:56 < MarcoFalke> Looks like a segfault in your code
11:57 < MarcoFalke> Run a getblockbyheight locally and you get the error
11:58 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #bitcoin-core-dev
11:58 < wumpus> yea, 'waiting for author' just means 'author needs to reply', it doesn't mean that the author needs to do everything (including cleaning toilets) that the reviewers propose :p
11:58 < wumpus> it's fiine to say 'this is out of scope of this PR'
11:59 < MarcoFalke> A p2p network change is not a command line change
11:59 < wumpus> I'd even encourage that to make sure that progress is made and things don't get held up in a back-and-forth forever
12:00 < wumpus> MarcoFalke: definitely
12:01 < MarcoFalke> If there is feedback and multiple reviewers agree on it, it shouldn't be ignored
12:02 < MarcoFalke> If it was a whitespace nit or something, yeah maybe ignore it
12:03 < wumpus> it should never be *ignored*
12:03 < wumpus> saying 'no' is ok, ignorning not
12:03 < MarcoFalke> Agree
12:04 < MarcoFalke> Knowing the reason that some feedback has not been addressed gives helpful insights
12:04 < MarcoFalke> s/that/why/
12:05 < wumpus> I mean reviewers spend time in writing review comments so the least you can do is respond to it, with reasoning
12:05 < wumpus> right
12:08 -!- RandolfR [~randolf@96.53.47.42] has joined #bitcoin-core-dev
12:11 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 272 seconds]
12:13 -!- RandolfR is now known as Randolf
12:18 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: Leaving]
12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:29 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3453cf26dbaf...536590f358dc
12:29 < bitcoin-git> bitcoin/master 604e2a9 Carl Dong: test: rpc_users: Add function for auth'd requests.
12:29 < bitcoin-git> bitcoin/master c73d871 Carl Dong: test: rpc_users: Add function for testing auth params.
12:29 < bitcoin-git> bitcoin/master 830dc2d Carl Dong: test: rpc_users: Also test rpcauth.py with specified password.
12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:30 < bitcoin-git> [bitcoin] laanwj merged pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:37 < emilengler> MarcoFalke, it works without any issues on my system (Debian Buster, amd64), thats really strange
12:37 < MarcoFalke> Oh, you might have to compile with --enable-debug
12:38 < MarcoFalke> ./configure --enable-debug
12:39 < MarcoFalke> if that doesn't help, run the server in valgrind and call the rpc again
12:40 < emilengler> Ok thanks
12:43 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hacfyzmcrztowdnz] has joined #bitcoin-core-dev
12:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:00 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
13:05 -!- Deangus [~manjaro-g@205.234.124.67] has joined #bitcoin-core-dev
13:08 < midnightmagic> dongcarl: Any experience yet with non-arm/x86 hosts for guix..?
13:11 < emilengler> Is it normal that when you compile with --enable-debug bitcoind quits after one RPC command#
13:14 < emilengler> Nevermind, it is a problem of my code
13:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
13:21 < midnightmagic> the guix guy's gpg key is expired as of four days ago.
13:22 < midnightmagic> rsa4096/090B11993D9AEBB5 -> expired: 2019-07-08
13:26 < dongcarl> midnightmagic: Not really, I know MIPS is supported well
13:26 < dongcarl> I've been porting things to riscv64, but have only gotten it working as a build target
13:28 < dongcarl> midnightmagic: Try refreshing it
13:28 < dongcarl> you might have pulled it a few months ago
13:28 < dongcarl> he refreshes every few months I believe
13:45 < emilengler> Can someone with permission restart this build? https://travis-ci.org/bitcoin/bitcoin/builds/556932611?utm_source=github_status&utm_medium=notification
13:55 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
14:00 -!- Wolfy87 [~Wolfy87@178.162.204.238] has quit []
14:05 < emilengler> Thanks to whoever has restarted the build ^^ :-)
14:13 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:14 -!- jonatack is now known as jonatack_
14:15 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:18 -!- mmf [~mmf@89.238.178.75] has joined #bitcoin-core-dev
14:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:39 -!- gelmutshmidt [~gelmutshm@188.113.53.102] has quit [Read error: Connection reset by peer]
14:39 -!- gelmutshmidt [~gelmutshm@188.113.53.102] has joined #bitcoin-core-dev
14:43 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
14:45 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 244 seconds]
14:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
15:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
15:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
15:22 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:27 -!- michaelfolkson [~textual@host109-159-18-89.range109-159.btcentralplus.com] has joined #bitcoin-core-dev
15:30 < midnightmagic> dongcarl: no, I pulleld it literally minutes before I mentioned it in here..?
15:30 < midnightmagic> based on the install script suggestion for import anyway
15:31 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
15:33 -!- michaelfolkson [~textual@host109-159-18-89.range109-159.btcentralplus.com] has quit [Quit: Sleep mode]
15:41 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
15:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
15:53 -!- hexyul [~omonk@unaffiliated/omonk] has quit [Read error: Connection reset by peer]
15:59 -!- hexyul [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev
16:13 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection]
16:35 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev
16:43 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
16:48 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds]
16:59 -!- jarthur [~jarthur@207.114.244.5] has quit []
17:00 -!- mmf [~mmf@89.238.178.75] has quit []
17:04 -!- CrystalNice [~CrystalNi@141.98.102.243] has joined #bitcoin-core-dev
17:07 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
17:14 -!- Deangus [~manjaro-g@205.234.124.67] has quit [Remote host closed the connection]
17:26 -!- gelmutshmidt [~gelmutshm@188.113.53.102] has quit [Remote host closed the connection]
17:34 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Write error: Connection reset by peer]
17:39 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
17:44 -!- kristapsk___ is now known as kristapsk
18:17 -!- lightlike [~lightlike@2001:16b8:5782:f900:549f:2074:c3a0:81d8] has quit [Quit: Leaving]
18:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
19:13 -!- xwirton [~lwnmaro@77.243.22.205] has quit [Quit: Leaving]
19:52 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has joined #bitcoin-core-dev
20:00 -!- CrystalNice [~CrystalNi@141.98.102.243] has quit []
20:04 -!- ebf01 [~ebf0@185.103.96.147] has joined #bitcoin-core-dev
20:18 -!- Krellan [~Krellan@2601:640:4100:ac00:29e6:61a1:a4b1:f168] has joined #bitcoin-core-dev
20:29 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 272 seconds]
20:29 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
20:30 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
20:34 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
21:08 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
21:08 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
21:08 -!- Fuzzbawls [~Fuzzbawls@2601:643:4001:d8af:287d:b685:2565:c3db] has quit [Quit: Textual IRC Client: www.textualapp.com]
21:12 -!- nijak_ [~nijak@141.98.255.143] has joined #bitcoin-core-dev
21:12 -!- nijak [~nijak@141.98.255.144] has quit [Ping timeout: 245 seconds]
21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 248 seconds]
21:58 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
22:06 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:30 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
22:34 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds]
23:00 -!- ebf01 [~ebf0@185.103.96.147] has quit []
23:03 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
23:13 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
23:19 -!- vkmc1 [~vkmc@185.103.96.147] has joined #bitcoin-core-dev
23:54 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
23:55 -!- MoonJaCk- [~moon@unaffiliated/moonjack-] has quit [Quit: Leaving]
--- Log closed Sat Jul 13 00:00:09 2019