--- Log opened Mon Jul 29 00:00:24 2019
00:18 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
00:22 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:37 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
00:42 -!- Keshawn1Walker [~Keshawn1W@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
00:42 -!- rex4539 [~rex4539@2a02:587:3514:c700:c0da:b2af:7c6c:51c1] has joined #bitcoin-core-dev
00:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:55 -!- Keshawn1Walker [~Keshawn1W@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]
01:04 -!- zrc [~zrc@124x35x200x88.ap124.ftth.ucom.ne.jp] has joined #bitcoin-core-dev
01:04 -!- zrc [~zrc@124x35x200x88.ap124.ftth.ucom.ne.jp] has quit [Client Quit]
01:05 -!- JamesAU [~jamesau@49.148.129.191] has joined #bitcoin-core-dev
01:07 -!- JamesAU__ [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has joined #bitcoin-core-dev
01:08 -!- JamesAU_ [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has quit [Ping timeout: 248 seconds]
01:10 -!- JamesAU [~jamesau@49.148.129.191] has quit [Ping timeout: 246 seconds]
01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:20 < bitcoin-git> [bitcoin] sipsorcery opened pull request #16483: Updated python command in msvc readme (master...update_msvc_readme) https://github.com/bitcoin/bitcoin/pull/16483
01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:24 < bitcoin-git> [bitcoin] fanquake closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:28 -!- kljasdfvv [~flack@p200300D46F0E78009012E10EBC2DC9BB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:30 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
01:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:37 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds]
01:39 < jonasschnelli> hebasto: https://github.com/bitcoin/bitcoin/pull/16476,... 5 labels? :-)
01:39 < jonasschnelli> Draht added them... I see
01:40 < fanquake> jonasschnelli: sometimes the bot gets a bit out of control hah
01:43 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
01:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
01:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
01:55 -!- JamesAU [~jamesau@49.148.129.191] has joined #bitcoin-core-dev
01:58 -!- JamesAU_ [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has joined #bitcoin-core-dev
01:59 -!- JamesAU__ [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has quit [Ping timeout: 244 seconds]
02:00 -!- Pysis|work [~Pysis|wor@139.28.218.198] has quit []
02:02 -!- JamesAU [~jamesau@49.148.129.191] has quit [Read error: Connection reset by peer]
02:11 < jonasschnelli> sipa: the PR #16202 is a result of your NACK/comment in 14046. Appreciate your review. Thanks
02:11 < gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
02:13 -!- mengu [~mengu@192.145.126.244] has joined #bitcoin-core-dev
02:13 -!- mengu is now known as Guest2233
02:15 -!- JamesAU [~jamesau@49.148.129.191] has joined #bitcoin-core-dev
02:18 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:18 -!- JamesAU_ [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has quit [Ping timeout: 258 seconds]
02:22 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-jgqvrbdhaookqfzp] has quit [Remote host closed the connection]
02:22 -!- tuirektiujm[m] [tuirektiuj@gateway/shell/matrix.org/x-avbcvmonjmubrpvl] has quit [Remote host closed the connection]
02:22 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-wswswfbfpivmwuwg] has quit [Read error: Connection reset by peer]
02:22 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-xfgpzrbviaxuliba] has quit [Remote host closed the connection]
02:22 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-cwhlpuftmotajpyh] has quit [Read error: Connection reset by peer]
02:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
02:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
02:29 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-twpmeliaoxaxpmac] has joined #bitcoin-core-dev
02:36 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-yyjpchmhfkhrasda] has joined #bitcoin-core-dev
02:36 -!- tuirektiujm[m] [tuirektiuj@gateway/shell/matrix.org/x-jgyktqshlcdivytv] has joined #bitcoin-core-dev
02:36 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-cejsvubipywrcjjh] has joined #bitcoin-core-dev
02:36 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-pjtxchxfbuynefgz] has joined #bitcoin-core-dev
02:38 -!- JamesAU [~jamesau@49.148.129.191] has quit [Remote host closed the connection]
02:44 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
02:51 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:09 -!- JamesAU [~jamesau@49.148.129.191] has joined #bitcoin-core-dev
03:39 -!- jonatack [d598a272@213.152.162.114] has quit [Remote host closed the connection]
03:46 -!- JamesAU [~jamesau@49.148.129.191] has quit [Ping timeout: 272 seconds]
03:55 -!- shtirlic [~shtirlic@ec2-52-57-69-234.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]
03:56 -!- shtirlic [~shtirlic@ec2-52-57-69-234.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev
04:03 -!- dgfhdfg [~hgfdfgh@77.243.19.196] has joined #bitcoin-core-dev
04:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
04:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
04:17 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
04:19 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
04:59 -!- rex4539 [~rex4539@2a02:587:3514:c700:c0da:b2af:7c6c:51c1] has quit [Quit: rex4539]
05:00 -!- Guest2233 [~mengu@192.145.126.244] has quit []
05:04 -!- j3parker1 [~j3parker@192.145.126.244] has joined #bitcoin-core-dev
05:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:16 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
05:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:17 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev
05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:18 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c2885f9b2e3...502ec0227290
05:22 < bitcoin-git> bitcoin/master fabfcb5 MarcoFalke: build: Treat -Wswitch as error when --enable-werror
05:22 < bitcoin-git> bitcoin/master 502ec02 MarcoFalke: Merge #16424: build: Treat -Wswitch as error when --enable-werror
05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
05:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
05:28 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
05:28 -!- goatpig [537241de@aaubervilliers-652-1-90-222.w83-114.abo.wanadoo.fr] has quit [Remote host closed the connection]
05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16484: doc: Remove "trivial" label in CONTRIBUTING (master...1907-docNoTrivial) https://github.com/bitcoin/bitcoin/pull/16484
05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:44 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 258 seconds]
05:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:52 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/502ec0227290...f735851be294
05:52 < bitcoin-git> bitcoin/master 07e01d6 Jon Atack: rpc: sendrawtransaction unconditionality/privacy note
05:52 < bitcoin-git> bitcoin/master f735851 Wladimir J. van der Laan: Merge #16467: rpc: sendrawtransaction help privacy note
05:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] laanwj merged pull request #16467: rpc: sendrawtransaction help privacy note (master...sendrawtransaction-privacy-note) https://github.com/bitcoin/bitcoin/pull/16467
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:11 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 250 seconds]
06:17 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
06:21 -!- JamesAU [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has joined #bitcoin-core-dev
06:23 -!- Kvaciral [~Kvaciral@94-214-185-162.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 246 seconds]
06:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f735851be294...29220250c10e
06:33 < bitcoin-git> bitcoin/master 98a64bd fanquake: build: disable libjpeg in qt
06:33 < bitcoin-git> bitcoin/master 0aeb98a fanquake: build: remove jpeg lib check from bitcoin_qt.m4
06:33 < bitcoin-git> bitcoin/master 1bb1661 fanquake: doc: fix typo in bitcoin_qt.m4 comment
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:34 < bitcoin-git> [bitcoin] laanwj merged pull request #16441: build: remove qt libjpeg check from bitcoin_qt.m4 (master...remove-qt-libjpeg-check) https://github.com/bitcoin/bitcoin/pull/16441
06:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/29220250c10e...74ea1f3b0f26
06:38 < bitcoin-git> bitcoin/master 3199610 Fabian Jahr: Place out args at the end for CreateWallet
06:38 < bitcoin-git> bitcoin/master d6649d1 Fabian Jahr: Use strong enum for WalletCreationStatus
06:38 < bitcoin-git> bitcoin/master ba1f128 Fabian Jahr: Return error for ignored passphrase through disable private keys option
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:42 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bhjvnsbayvdrcowf] has joined #bitcoin-core-dev
06:44 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 258 seconds]
06:50 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
07:20 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev
07:33 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has joined #bitcoin-core-dev
07:35 -!- nijak [nijak@gateway/vpn/mullvad/nijak] has quit [Ping timeout: 244 seconds]
07:41 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:52 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/74ea1f3b0f26...b21acab82fe9
07:52 < bitcoin-git> bitcoin/master 9f76e45 Hennadii Stepanov: Drop support of insecure miniUPnPc versions
07:52 < bitcoin-git> bitcoin/master 91a1b85 Hennadii Stepanov: Use PACKAGE_NAME in UPnP description
07:52 < bitcoin-git> bitcoin/master 02709e9 Hennadii Stepanov: Align formatting with clang-format
07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:53 < bitcoin-git> [bitcoin] laanwj merged pull request #15993: net: Drop support of the insecure miniUPnPc versions (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:54 < sdaftuar> hi all, if anyone is interested in reviewing or even just testing #15759 i'd appreciate it, as i think it'd be best if p2p changes like this simmer in master with plenty of time before a new release in case of bugs or unintended side effects
07:54 < gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
07:54 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
07:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:58 -!- profmac [~ProfMac@2001:470:1f0f:226:b0d7:2a6e:1d81:17ec] has quit [Ping timeout: 250 seconds]
07:58 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
07:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
08:00 -!- j3parker1 [~j3parker@192.145.126.244] has quit []
08:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds]
08:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b21acab82fe9...2a7c3bc498b5
08:19 < bitcoin-git> bitcoin/master 4057b7a Hennadii Stepanov: wallet: Recognize -disablewallet option early
08:19 < bitcoin-git> bitcoin/master 2a7c3bc Wladimir J. van der Laan: Merge #16436: gui: Do not create payment server if -disablewallet option p...
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:19 < wumpus> sdaftuar: agreed
08:19 -!- |Kin| [~|Kin|@185.103.96.147] has joined #bitcoin-core-dev
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:20 < bitcoin-git> [bitcoin] laanwj merged pull request #16436: gui: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:24 -!- profmac [~ProfMac@2001:470:1f0f:226:b0d7:2a6e:1d81:17ec] has joined #bitcoin-core-dev
08:31 < sdaftuar> sipa: wumpus: any thoughts on the issue described in #16444? seems like an annoying problem to fix
08:31 < gribble> https://github.com/bitcoin/bitcoin/issues/16444 | Assertion `setBlockIndexCandidates.count(pindex) failed · Issue #16444 · bitcoin/bitcoin · GitHub
08:32 < sdaftuar> i think if we want to maintain the invariants we've historically had and not change CheckBlockIndex() at all, then we could add some more code to InvalidateBlock() so that everything works as it used to.
08:32 -!- kljasdfvv [~flack@p200300D46F0E78009012E10EBC2DC9BB.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:33 < sdaftuar> it just seems a bit tedious and it's not totally clear to me that it's important to maintain our usual invariants in this one specific case
08:39 -!- anemous [~yaaic@58.81-167-146.customer.lyse.net] has joined #bitcoin-core-dev
08:55 -!- anemous [~yaaic@58.81-167-146.customer.lyse.net] has quit [Ping timeout: 246 seconds]
09:00 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:05 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
09:11 -!- dgfhdfg [~hgfdfgh@77.243.19.196] has quit [Ping timeout: 268 seconds]
09:20 -!- lightlike [~lightlike@2001:16b8:5757:ee00:e853:7fef:7745:dede] has joined #bitcoin-core-dev
09:29 -!- dgfhdfg [~hgfdfgh@77.243.19.196] has joined #bitcoin-core-dev
09:34 -!- sfhi [~sfhi@37.252.225.109] has joined #bitcoin-core-dev
09:36 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:39 -!- roconnor [~roconnor@host-184-164-15-238.dyn.295.ca] has joined #bitcoin-core-dev
09:48 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:55 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a7c3bc498b5...68da54987df4
09:55 < bitcoin-git> bitcoin/master 42a5e91 John Newbery: [mempool] log correct messages when CPFP fails
09:55 < bitcoin-git> bitcoin/master 68da549 Wladimir J. van der Laan: Merge #16471: [mempool] log correct messages when CPFP fails
09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:56 < bitcoin-git> [bitcoin] laanwj merged pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 258 seconds]
09:59 -!- roconnor [~roconnor@host-184-164-15-238.dyn.295.ca] has quit [Read error: Connection reset by peer]
10:00 -!- roconnor [~roconnor@host-184-164-15-238.dyn.295.ca] has joined #bitcoin-core-dev
10:08 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:13 -!- sfhi2 [~sfhi@37.252.225.109] has joined #bitcoin-core-dev
10:13 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 244 seconds]
10:17 -!- sfhi [~sfhi@37.252.225.109] has quit [Ping timeout: 272 seconds]
10:19 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:21 -!- pinheadmz [~matthewzi@185.244.215.158] has quit [Read error: Connection reset by peer]
10:21 -!- pinheadmz_ [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:24 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:28 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
10:34 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
10:34 -!- fasdlkfjaslkfj [68840050@104.132.0.80] has joined #bitcoin-core-dev
10:35 -!- jonatack [58aba822@jau64-1-88-171-168-34.fbx.proxad.net] has joined #bitcoin-core-dev
10:36 -!- fasdlkfjaslkfj [68840050@104.132.0.80] has quit [Remote host closed the connection]
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] pstratem opened pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
10:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:57 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
10:58 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:00 < bitcoin-git> [bitcoin] jamesob opened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:00 -!- |Kin| [~|Kin|@185.103.96.147] has quit []
11:04 -!- josef641 [~josef64@185.103.96.147] has joined #bitcoin-core-dev
11:04 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:06 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
11:12 -!- jarthur [~jarthur@207.114.244.5] has quit []
11:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:15 -!- dgfhdfg [~hgfdfgh@77.243.19.196] has quit [Read error: Connection reset by peer]
11:17 -!- dgfhdfg [~hgfdfgh@77.243.23.164] has joined #bitcoin-core-dev
11:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
11:18 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:18 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
11:21 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 248 seconds]
11:22 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds]
11:24 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:47 -!- JamesAU [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has quit [Remote host closed the connection]
11:48 < phantomcircuit> also the TODO in the BIP30 logic while not exactly immediate should be looked into
12:06 -!- captjakk_ [~captjakk@75-166-175-210.hlrn.qwest.net] has quit [Remote host closed the connection]
12:21 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
12:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:30 < bitcoin-git> [bitcoin] jonatack opened pull request #16489: log: update bitcoind daemon logging (master...daemon-logging-harmonisation) https://github.com/bitcoin/bitcoin/pull/16489
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:38 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
12:39 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:40 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
12:40 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:42 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:45 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
12:46 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:50 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 246 seconds]
12:51 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:53 -!- davterra [~Beta@36.177.181.107.wiredns.net] has joined #bitcoin-core-dev
13:00 -!- davterra [~Beta@36.177.181.107.wiredns.net] has quit [Quit: Leaving]
13:06 -!- sfhi2 [~sfhi@37.252.225.109] has quit [Quit: Leaving]
13:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:14 -!- davterra [~none@69.161.195.101] has joined #bitcoin-core-dev
13:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
13:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit []
13:41 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
13:44 -!- sblinn [493d0bf2@73.61.11.242] has joined #bitcoin-core-dev
13:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:51 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
13:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:00 -!- josef641 [~josef64@185.103.96.147] has quit []
14:02 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
14:03 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:04 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
14:04 -!- VitamineD [~VitamineD@89.238.178.75] has joined #bitcoin-core-dev
14:04 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
14:14 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:15 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
14:19 -!- sblinn [493d0bf2@73.61.11.242] has quit [Ping timeout: 260 seconds]
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:28 < bitcoin-git> [bitcoin] jonatack opened pull request #16491: qa: fix deprecated log.warn in feature_dbcrash test (master...test-fix-feature_dbcrash-warn-deprecation) https://github.com/bitcoin/bitcoin/pull/16491
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:31 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
14:46 < sipa> jonasschnelli, BlueMatt: about v2 transport and the question on how to encode the message types. given that 12 bytes is complete overkill anyway, i wonder if an alternative to shortcuts+variable length as proposed currently, it wouldn't be easier to just shrink the message type field; it turns out that first 2 characters + last 2 characters of every message name is unique currently
14:46 < BlueMatt> why?
14:47 < BlueMatt> just use the current one-byte proposal with a fallback to 12 bytes?
14:47 < BlueMatt> or fallback to, I dunno, 8 bytes? whatever you want
14:47 < sipa> that's also a possibility, but harder to extend
14:47 < BlueMatt> is it?
14:48 < sipa> as in: the shortening will only be available to a select number of messages, and probably need a lot of coordination to avoid collisions between them
14:48 < BlueMatt> a lot of coordination? as in te bip process?
14:48 < sipa> right
14:49 < BlueMatt> that seems reasonable to me.
14:49 < sipa> string messages are unlikely to collide, for 1-byte types you really need to assign sequentially
14:49 < BlueMatt> how about 8 bytes and you must use the time of when you selected the message :p
14:49 < sipa> while 4-byte messages for everything doesn't have this problem, is even simpler to implement, gets you most of the savings, and is backward compatible
14:50 < BlueMatt> ok, or 4 byte message types and you must use the time of when you selected the message mod 2**32 :p
14:50 < sipa> that could totally work
14:51 < BlueMatt> I prefer that infinitely over a variable-length message type anyway
14:51 < sipa> infinity is a lot
14:52 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:53 < BlueMatt> YUGE
14:55 < sipa> filterclear would become "feer".
14:55 < BlueMatt> limiting to common-char-lower-case-ascii seems like a waste of 4 bytes, but, whatever
14:55 < sipa> it is; for v2-only messages that restriction wouldn't be needed
14:55 < sipa> actually it's need needed at all, agree
14:58 < sipa> or we could use SHA256(message)[0:4] :p
14:58 < sipa> oh no, double-SHA256(message)[0:4], satoshi style
14:59 < BlueMatt> rot13(rot13(message))
15:00 < sipa> i'm only half joking; using a hash function or CRC or so as mapping from string names to 4-byte message type ids has hardly any downsides i think
15:01 < BlueMatt> true
15:01 < sipa> an actual implementation wouldn't actually compute the hashes; they'd just be precomputed for every message type
15:01 < BlueMatt> sure, of course
15:01 < sipa> anyway, let's see what jonasschnelli thinks
15:04 < hugohn> sipa: do you think it makes sense for descriptor.cpp->Parse() to return the output type of the descriptor string, along with the Signing Provider? I'm trying to infer the output type through other means without touching descriptor.h/.cpp. But Expand() doesn't work as intermediate redeem scripts are no longer saved to memory with native descriptor wallets (so you can’t peek into them). And string pattern matching
15:04 < hugohn> (e.g. matching against `"sh(wsh"`) is ugly IMO.
15:05 < sipa> hugohn: what is 'output type' ?
15:06 < sipa> and i don't understand why Expand doesn't work
15:06 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
15:07 < sipa> oh, output type as in address type
15:07 < sipa> hmm
15:07 < sipa> what about raw multisig, or combo? those don't have a well-defined output type
15:07 < hugohn> https://github.com/bitcoin/bitcoin/blob/master/src/outputtype.h#L16
15:07 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:07 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:07 < hugohn> the "buckets" used in the refactored wallet
15:10 < sipa> Expand() + ExtractDestination should work, i think
15:11 < sipa> and you should always be able to call Expand on descriptors in the wallet, otherwise how would you participate in signing?
15:11 < sipa> and you don't need the intermediate redeemscript; just ExtractDestination on the output scriptPubKey should be sufficient
15:12 < sipa> i may be missing things :)
15:13 < hugohn> yeah I can call Expand just fine :D my problem is distinguishing between a legacy P2SH & a P2SH-Segwit
15:13 < sipa> there shouldn't be a need to distinguish between those
15:13 < sipa> if the sender supports P2SH, he will support both
15:13 < sipa> as he obviously can't distinguish
15:14 < sipa> output types currently distinguish between them, as that what the mechanism to determine whether you wanted to use segwit in the wallet or not
15:14 < sipa> but in a post-descriptor world, i think that distinction would simply be made by having a segwit descriptor or not
15:16 < hugohn> right, it doesn't make a difference to the user, but I believe in achow101 's proposed new wallet architecture, we would have different scriptPubKeyManager(s) for each of the 3 output types: LEGACY, P2SH_SEGWIT (wrapped Segwit), and BECH32. 
15:16 < sipa> right, and you need a sanity check when creating a new descriptor?
15:16 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
15:17 < sipa> that the descriptor is compatible with that type
15:17 < sipa> ?
15:26 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Read error: Connection timed out]
15:26 < achow101> Yes
15:26 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
15:26 < sipa> arguably we should just get rid of the distinction between P2SH and P2SH-Segwit
15:27 < achow101> I wrote a function that used the Solver + a SigningProvider in order to determine the address type, but apparently that doesn't work since the p2sh-segwit redeemScript is not put in the SigningProvider by Descriptor Expand or Parse
15:27 < sipa> though perhaps that's not something to do simultaneously
15:28 < sipa> hmm, really?
15:28 < sipa> Expand should put it there
15:28 < achow101> That's what I thought, but hugohn told me it isn't (haven't had the chance to check)
15:29 < sipa> that sounds like a major issue if it isn't
15:29 < sipa> https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L461
15:29 < hugohn> https://www.irccloud.com/pastebin/NoBXcIt6/ExpandHelper
15:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
15:31 < sipa> hugohn: yes?
15:32 < hugohn> sorry ignore that snippet. I missed that line you posted above, looks like the redeem script is saved to the Signing Provider. 
15:33 < sipa> hugohn: in general no information should get lost through an Expand
15:33 < hugohn> then I don't understand why when we look up for the redeemScript later, we don't find it, hmm...
15:33 < sipa> otherwise InferDescriptor wouldn't be able to reconstruct things
15:33 < sipa> which afaik has a test
15:34 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:37 < elichai2> hugohn: maybe it wasn't expanded yet?
15:39 < hugohn> elichai2: no I made sure it was expanded
15:43 < hugohn> code for more context: https://github.com/achow101/bitcoin/pull/4/files#diff-b2bb174788c7409b671c46ccc86034bdR4273
15:43 < hugohn> I'm not getting the correct output type by peeking into an address generated by Expand() here^
15:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 258 seconds]
15:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:52 < hugohn> implementation for DetermineOutputType: https://github.com/achow101/bitcoin/blob/wallet-of-the-glorious-future/src/outputtype.cpp#L126
15:52 < hugohn> `provider.GetCScript()` fails to look up the redeem script given the script ID
15:56 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
15:57 < hugohn> nway, very likely I'm doing something wrong, will investigate further. thanks sipa!
15:59 -!- jonatack [58aba822@jau64-1-88-171-168-34.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
16:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
16:00 -!- dgfhdfg [~hgfdfgh@77.243.23.164] has quit [Ping timeout: 245 seconds]
16:01 < sipa> hugohn: add some debug statements that print the contents of the SigningProvider before calling the code to determine output type
16:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:04 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
16:06 < hugohn> sipa: yes I'm adding printf eveywhere lol. will try that next!
16:10 -!- rex4539 [~rex4539@2a02:587:3514:c700:ec77:4dfb:37a8:50d] has joined #bitcoin-core-dev
16:11 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
16:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
16:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:36 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:37 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Client Quit]
16:38 -!- lightlike [~lightlike@2001:16b8:5757:ee00:e853:7fef:7745:dede] has quit [Quit: Leaving]
16:39 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:46 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:00 -!- VitamineD [~VitamineD@89.238.178.75] has quit []
17:04 -!- tflgen2 [~tflgen2@184.75.223.219] has joined #bitcoin-core-dev
17:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
17:11 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Ping timeout: 246 seconds]
17:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
17:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:15 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
17:15 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:24 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
17:24 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:34 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
17:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:35 < bitcoin-git> [bitcoin] ezegom opened pull request #16492: <WIP> Add feeRate argument to bumpFee RPC (master...feerate_bumpfee) https://github.com/bitcoin/bitcoin/pull/16492
17:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:38 < bitcoin-git> [bitcoin] ezegom closed pull request #16492: <WIP> Add feeRate argument to bumpFee RPC (master...feerate_bumpfee) https://github.com/bitcoin/bitcoin/pull/16492
17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:01 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Quit: ZNC - https://znc.in]
18:03 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] ezegom reopened pull request #16492: <WIP> Add feeRate argument to bumpFee RPC (master...feerate_bumpfee) https://github.com/bitcoin/bitcoin/pull/16492
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:04 -!- JamesAU [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has joined #bitcoin-core-dev
18:04 < emilengler> How the CTRL+L shortcut is being handled in bitcoin-qt? Over a QAction or a QShortcut?
18:11 -!- sdupre [48172556@dynamic-acs-72-23-37-86.zoominternet.net] has joined #bitcoin-core-dev
18:16 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
18:16 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
18:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
18:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
18:33 -!- JamesAU [~jamesau@rrcs-198-179-121-220.nys.biz.rr.com] has quit [Ping timeout: 258 seconds]
18:38 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Quit: Leaving]
18:42 -!- sdupre [48172556@dynamic-acs-72-23-37-86.zoominternet.net] has quit [Remote host closed the connection]
18:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:52 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
18:53 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
18:56 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:56 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
18:57 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:08 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds]
19:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
19:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:15 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
19:16 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
19:18 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 245 seconds]
19:20 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
19:20 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
19:20 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
19:20 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 248 seconds]
19:20 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
19:22 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bhjvnsbayvdrcowf] has quit [Quit: Connection closed for inactivity]
19:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:27 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
19:36 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:37 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
19:37 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:45 -!- sanket1729 [~sanket172@72.36.89.11] has joined #bitcoin-core-dev
20:00 -!- tflgen2 [~tflgen2@184.75.223.219] has quit []
20:04 -!- vexed__ [~vexed__@195.206.169.238] has joined #bitcoin-core-dev
20:04 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
20:15 -!- whatsup [05b5ea5e@5.181.234.94] has joined #bitcoin-core-dev
20:16 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
20:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68da54987df4...2410088003a1
20:17 < bitcoin-git> bitcoin/master 62d3f50 Jon Atack: qa: fix deprecated log.warn in feature_dbcrash test
20:17 < bitcoin-git> bitcoin/master 2410088 fanquake: Merge #16491: qa: fix deprecated log.warn in feature_dbcrash test
20:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:18 < bitcoin-git> [bitcoin] fanquake merged pull request #16491: qa: fix deprecated log.warn in feature_dbcrash test (master...test-fix-feature_dbcrash-warn-deprecation) https://github.com/bitcoin/bitcoin/pull/16491
20:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:19 -!- guest62 [ab06f39a@mx-ll-171.6.243-154.dynamic.3bb.co.th] has joined #bitcoin-core-dev
20:20 -!- whatsup [05b5ea5e@5.181.234.94] has quit [Ping timeout: 260 seconds]
20:21 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds]
20:28 -!- nockk100 [05b5ea5e@5.181.234.94] has joined #bitcoin-core-dev
20:37 < kallewoof> achow101: https://github.com/bitcoin/bitcoin/pull/16440#discussion_r308332901 I basically need the wallet interface to give me a way to sign things from the QT side, and this was the only approach I could think of. sipa suggested I ping you to make sure I wasn't trampling on stuff with the descriptor wallet changes you are working on.
20:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:37 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2410088003a1...478fe328a793
20:37 < bitcoin-git> bitcoin/master fa6dc7f MarcoFalke: wallet: Enumerate walletdb keys
20:37 -!- nockk100 [05b5ea5e@5.181.234.94] has quit [Remote host closed the connection]
20:37 < bitcoin-git> bitcoin/master fa6f22b MarcoFalke: wallet: Rename CWalletKey to OldKey
20:37 < bitcoin-git> bitcoin/master 478fe32 fanquake: Merge #16475: wallet: Enumerate walletdb keys
20:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:38 < bitcoin-git> [bitcoin] fanquake merged pull request #16475: wallet: Enumerate walletdb keys (master...1907-walletDbKeys) https://github.com/bitcoin/bitcoin/pull/16475
20:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:39 < achow101> kallewoof: it doesn't interfere, I'll leave a comment
20:39 < kallewoof> Great, thanks!
20:44 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
20:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/478fe328a793...33894612c0de
20:51 < bitcoin-git> bitcoin/master faa88d0 MarcoFalke: doc: update labels in CONTRIBUTING.md
20:51 < bitcoin-git> bitcoin/master 3389461 fanquake: Merge #16484: doc: update labels in CONTRIBUTING.md
20:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:52 < bitcoin-git> [bitcoin] fanquake merged pull request #16484: doc: update labels in CONTRIBUTING.md (master...1907-docNoTrivial) https://github.com/bitcoin/bitcoin/pull/16484
20:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:53 -!- schnerch_ [~schnerchi@p5084AC20.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
20:56 -!- schnerchi [~schnerchi@p57B8327F.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20:57 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
21:02 < hugohn> sipa: fwiw I found the issue, the redeem script was expanded in the signing provider but it was a _different_ provider. the caller needs to retrieve the expanded provider (instead of using the original one it got from Parse()) before doing the lookup. 
21:04 < sipa> hugohn: ha
21:06 < hugohn> silly mistake :D so the correct importing flow is to TopUp(), which generates the cache, then call GetScriptPubKeyMan() to retrieve an expanded provider using the fresh cache, then do DetermineOutputType.
21:10 < hugohn> *GetSigningProvider, not GetScriptPubKeyMan
21:18 -!- roconnor [~roconnor@host-184-164-15-238.dyn.295.ca] has quit [Ping timeout: 246 seconds]
21:20 -!- d3spwn [~d3spwn@unaffiliated/d3spwn] has quit [Ping timeout: 246 seconds]
21:23 -!- peleion [~jeff@76.73.148.34] has quit [Ping timeout: 246 seconds]
21:27 -!- d3spwn [~d3spwn@unaffiliated/d3spwn] has joined #bitcoin-core-dev
21:32 -!- nullptr| [~nullptr|@51.158.108.68] has quit [Ping timeout: 245 seconds]
21:32 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Ping timeout: 245 seconds]
21:33 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev
21:34 -!- nullptr| [~nullptr|@2001:bc8:47a4:241::1] has joined #bitcoin-core-dev
21:48 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Quit: tryphe]
21:53 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-qrzynwjvjlhfuiid] has joined #bitcoin-core-dev
21:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:56 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:00 -!- guest62 [ab06f39a@mx-ll-171.6.243-154.dynamic.3bb.co.th] has quit [Ping timeout: 260 seconds]
22:27 -!- rex4539 [~rex4539@2a02:587:3514:c700:ec77:4dfb:37a8:50d] has quit [Quit: rex4539]
22:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:37 < bitcoin-git> [bitcoin] Bushstar reopened pull request #15709: wallet: Do not add "setting" key as unknown (master...walletdb-settings) https://github.com/bitcoin/bitcoin/pull/15709
22:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:00 -!- vexed__ [~vexed__@195.206.169.238] has quit []
23:05 -!- rex4539 [~rex4539@2a02:587:3514:c700:ec2d:b821:585:58bd] has joined #bitcoin-core-dev
23:10 -!- keyboardsurfer [~keyboards@89.249.74.218] has joined #bitcoin-core-dev
23:34 -!- kcalvinalvin [~calvin@104.143.95.18] has joined #bitcoin-core-dev
23:38 -!- guest69 [ab06f39a@171.6.243.154] has joined #bitcoin-core-dev
--- Log closed Tue Jul 30 00:00:24 2019