--- Log opened Wed Jul 31 00:00:26 2019
00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:01 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/39763b75556b...8241b5150431
00:01 < bitcoin-git> bitcoin/master b3a9d17 John Newbery: [wallet] Move CMerkleTx functions into CWalletTx
00:01 < bitcoin-git> bitcoin/master 783a76f John Newbery: [wallet] Flatten CWalletTx class hierarchy
00:01 < bitcoin-git> bitcoin/master 05b56d1 John Newbery: [wallet] Remove CMerkleTx serialization logic
00:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:02 < bitcoin-git> [bitcoin] laanwj merged pull request #16451: Remove CMerkleTx (master...2019-07-remove-CMerkleTx) https://github.com/bitcoin/bitcoin/pull/16451
00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
00:13 -!- Raystonn [~Raystonn@c-98-210-96-225.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
00:18 -!- petezz4 [uid2429@gateway/web/irccloud.com/x-yteiglaopptrqjxf] has joined #bitcoin-core-dev
00:25 -!- petezz4 [uid2429@gateway/web/irccloud.com/x-yteiglaopptrqjxf] has quit [Quit: Updating details, brb]
00:25 -!- petezz4 [uid2429@gateway/web/irccloud.com/x-khtvbfwezanbrpzm] has joined #bitcoin-core-dev
00:40 -!- kljasdfvv [~flack@p200300D46F0E780045CDB0F090457E57.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:46 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit []
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] sipsorcery opened pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:09 < fanquake> kallewoof: done 👍
01:10 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
01:12 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev
01:12 < kallewoof> Thanks! :)
01:12 -!- Krellan_ [~Krellan@2601:640:4100:ac00:a99a:2670:6ab:5dee] has quit [Remote host closed the connection]
01:12 -!- Krellan [~Krellan@2601:640:4100:ac00:4019:31d:afe9:a7b6] has joined #bitcoin-core-dev
01:17 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
01:17 -!- Krellan [~Krellan@2601:640:4100:ac00:4019:31d:afe9:a7b6] has quit [Ping timeout: 250 seconds]
01:24 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
01:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:35 -!- kcalvinalvin [~calvin@104.143.95.18] has quit [Ping timeout: 248 seconds]
01:58 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:00 -!- dlareg1 [~dlareg@185.103.96.147] has quit []
02:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
02:13 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:14 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
02:25 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
02:26 -!- guest69 [ab06f39a@171.6.243.154] has quit [Ping timeout: 260 seconds]
02:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
02:45 -!- guilhermeblanco [~guilherme@185.103.96.147] has joined #bitcoin-core-dev
03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:12 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8241b5150431...00922b872027
03:12 < bitcoin-git> bitcoin/master 80ba424 Amiti Uttarwar: extract min & max depth onto coin control
03:12 < bitcoin-git> bitcoin/master 00922b8 Wladimir J. van der Laan: Merge #15906: [wallet] Move min_depth and max_depth to coin control
03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:13 < bitcoin-git> [bitcoin] laanwj merged pull request #15906: [wallet] Move min_depth and max_depth to coin control (master...refactor_available_coins) https://github.com/bitcoin/bitcoin/pull/15906
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:37 -!- jonatack [d598a155@213.152.161.85] has quit [Remote host closed the connection]
03:59 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
04:15 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
04:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
04:17 -!- sdupre [48172556@dynamic-acs-72-23-37-86.zoominternet.net] has joined #bitcoin-core-dev
04:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
04:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
04:22 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds]
04:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00922b872027...f89113626e42
04:25 < bitcoin-git> bitcoin/master 0646ca5 Aaron Clauson: Changes the verbosity of msbuild from quiet to normal in the appveyor scri...
04:25 < bitcoin-git> bitcoin/master f891136 MarcoFalke: Merge #16505: Changes verbosity of msbuild from quiet to normal in the app...
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16505: Changes verbosity of msbuild from quiet to normal in the appveyor script (master...appveyor_verbosity) https://github.com/bitcoin/bitcoin/pull/16505
04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:28 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:28 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 -!- sdupre [48172556@dynamic-acs-72-23-37-86.zoominternet.net] has quit [Remote host closed the connection]
04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f89113626e42...3f288a1c05eb
04:37 < bitcoin-git> bitcoin/master 73b692b João Barbosa: doc: Add release note for the deprecated totalFee option of bumpfee
04:37 < bitcoin-git> bitcoin/master 3f288a1 MarcoFalke: Merge #16504: doc: Add release note for the deprecated totalFee option of ...
04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16504: doc: Add release note for the deprecated totalFee option of bumpfee (master...2019-07-release-notes-15996) https://github.com/bitcoin/bitcoin/pull/16504
04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 -!- guilhermeblanco [~guilherme@185.103.96.147] has quit []
05:00 -!- jonatack [d598a155@213.152.161.85] has joined #bitcoin-core-dev
05:04 -!- MarconM [~MarconM@139.28.218.198] has joined #bitcoin-core-dev
05:06 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:08 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
05:09 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev
05:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:18 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
05:27 < sdaftuar> phantomcircuit: regarding the bip 30 optimization
05:28 < sdaftuar> it’s important to enforce bip30 on potential “alternate” chains, because if there is a utxo “overwrite” from a duplicate transaction, then the utxo set will be potentially incorrect when reorging from that chain to some other chain (eg because you’ll have removed an entry from the utxo set that should still be there, if you’d never connected the block that overwrote the transaction in
05:28 < sdaftuar> the first place).
05:29 < sdaftuar> on the bitcoin main chain, this is not actually a problem (modulo the hypothetical future problem we can have after block 1.9M or whatever it is)
05:29 < sdaftuar> Anyway this would be a simple fix to your PR — just ensure that you only skip the bip30 checks if assume valid is set and the assume valid block hash builds on the known bip34 activation block hash; that would ensure that we only skip the bip30 checks on blocks we know to be safe from this issue
05:30 < sdaftuar> but as i mentioned on the pr, i don’t think it’s worth making any changes for a 22 second speedup during IBD.
05:35 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev
05:36 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev
05:37 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Client Quit]
05:44 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
05:56 -!- davterra [~none@209.58.190.248] has quit [Quit: Leaving]
05:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
06:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:10 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection]
06:11 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev
06:11 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:15 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 268 seconds]
06:16 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-vsjfpebelqcheecm] has quit [Read error: Connection reset by peer]
06:16 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-zxbyecrgtlitbrjz] has joined #bitcoin-core-dev
06:20 -!- dgfhdfg [~hgfdfgh@37.19.108.150] has joined #bitcoin-core-dev
06:32 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection]
06:40 -!- davterra [~none@64.120.89.22] has joined #bitcoin-core-dev
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:50 -!- lightlike [~lightlike@2001:16b8:57bf:800:a5cf:5b01:180a:96c] has joined #bitcoin-core-dev
07:01 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-isjyuaalbhbfdvbq] has joined #bitcoin-core-dev
07:07 -!- mzygar_ [~mzygar@212.123.247.72] has joined #bitcoin-core-dev
07:09 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev
07:10 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 245 seconds]
07:12 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection]
07:15 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev
07:20 -!- dgfhdfg [~hgfdfgh@37.19.108.150] has quit [Ping timeout: 246 seconds]
07:32 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
07:39 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
07:40 < jnewbery_> laanwj MarcoFalke: if you're in a merging mood, then I think #16452 is good to go
07:40 < gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub
07:45 < dongcarl> wumpus: How should addrv2 clients handle ::FFFF:0:0/96 IPv4-mapped addresses?
07:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:47 < dongcarl> More specifically, 1. Should they be accepted (I think yes) 2. Should they be internally parsed into IPv4 addresses, or stay internally as IPv6 addresses that still return true for `IsIPv4()`?
07:48 < phantomcircuit> sdaftuar, ooooh yes i see
07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f288a1c05eb...7821821a23b6
07:50 < bitcoin-git> bitcoin/master 9bc8b28 Antoine Riard: refactor : use RelayTransaction in BroadcastTransaction utility
07:50 < bitcoin-git> bitcoin/master 7821821 MarcoFalke: Merge #16452: refactor: use RelayTransaction in BroadcastTransaction utili...
07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:55 < sdaftuar> phantomcircuit: really, assumevalid has nothing to do with the optimization -- it'd be enough to check to see if a block is an ancestor of the known-bip34-activation blockhash, and if so, skip the check. i think.  but this is all so complicated that i think it's best not to risk changes here...
07:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
07:58 < phantomcircuit> sdaftuar, my principle motivation was to make measuring leveldb calls vs dbcache size easier
07:58 < phantomcircuit> i just thought it was a nice optimization as well
07:59 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:59 -!- sdupre [~androirc@107.242.116.59] has joined #bitcoin-core-dev
07:59 < phantomcircuit> but yeah i hadn't considered that it would erase a utxo entry that wouldn't be restored by the undo blocks
08:00 -!- MarconM [~MarconM@139.28.218.198] has quit []
08:00 < MarcoFalke> fanquake: If you leave the label for DrahtBot to remove, it will also remove all its comments and make the comment history shorter/easier to follow. https://github.com/bitcoin/bitcoin/pull/16400#event-2523391791
08:04 -!- paulk-collins [~paulk-col@185.103.96.147] has joined #bitcoin-core-dev
08:06 -!- schnerchi [~schnerchi@p57B830CA.dip0.t-ipconnect.de] has quit [Quit: Leaving...]
08:12 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:19 -!- dgfhdfg [~hgfdfgh@77.243.23.229] has joined #bitcoin-core-dev
08:21 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
08:21 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:21 < elichai2> should I impose the lex ordering over the tapdescriptor? meaning. should I fail a desc because it wasn't ordered correctly? on one hand this means it's really hard to constructe desc by hand(if that's even a thing?) on the other if we don't have this than there's no longer 1-1 mapping (multiple desc ordered differently will result in the same scriptPubKey)
08:23 < sipa> elichai2: good question
08:26 < wumpus> dongcarl: that's a good point, i think it should reject (ignore) them, addrv2 has its own way of sending IPv4 addresses that should be used
08:29 < wumpus> dongcarl: for Tor I do specify this explictly in the BIP"
08:29 < wumpus> dongcarl: e.g. " Clients SHOULD ignore OnionCat (<code>fd87:d87e:eb43::/48</code>) addresses on receive if they come with the <code>IPV6</code> network ID."
08:29 < wumpus> dongcarl: should probably add the same for IPv4 addresses encoded as IPv6
08:30 < sipa> wumpus: that makes sense
08:31 < dongcarl> that sounds good :-)
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:33 < bitcoin-git> [bitcoin] instagibbs closed pull request #16500: GetFee should round up to avoid undershooting feerate (master...fix_filter_mempool_mistmatch) https://github.com/bitcoin/bitcoin/pull/16500
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:37 < sipa> elichai2: it's kind of annoying for human construction if the branches need to be well-ordered (which is effectively random)
08:38 < sipa> elichai2: on the other hand, inferring a descriptor from comtext information will only possibly find one order
08:38 -!- hhhhtfuzrtzrtzey [~flack@p200300D46F0E7800992803960A53D29E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:38 < sipa> so... i don't know
08:39 < elichai2> sipa: hmm generally the inferring isn't a fun problem. but it actually makes it a little bit simpler if you don't care about the order. you can compare paths to identify siblings
08:41 < elichai2> (so siblings are gonna have the same script path except the last part(which will be the hash of each other), you can then combine them together to a new "script path" as a node, remove the last part of the path and find they're sibling. that way you reconstructe from the bottom up without verifying order)
08:42 < sipa> sure, you can compare things in multiple ways
08:42 -!- kljasdfvv [~flack@p200300D46F0E780045CDB0F090457E57.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
08:43 < sipa> i'm just wondering if the inconvenience of forcing an essentially random (and hard for humans to create) order weighs up against the added variance in descriptors (which will be wiped out by canonicalizing/infering)
08:43 < sipa> i think we should permit both orders
08:43 < sipa> there are already non-canonical things in descriptors
08:44 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
08:45 < elichai2> sipa: are there any non-canonical things *withou* addr and raw?
08:46 < sipa> elichai2: the h vs ' for hardened paths
08:46 < elichai2> (altough parsing a raw descriptor and then infering back the scriptPubKey might end you up with a different desc then the one you started with)
08:46 < elichai2> right
08:49 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
08:49 < sipa> yeah
08:49 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:49 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
08:50 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
08:50 -!- hhhhtfuzrtzrtzey [~flack@p200300D46F0E7800992803960A53D29E.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:54 -!- mzygar_ [~mzygar@212.123.247.72] has quit [Ping timeout: 258 seconds]
09:05 < emilengler> Hi, how can I detect in the qt debug window if the console tab is open? Is there a function which returns a bool for it or something similar?
09:17 < wumpus> emilengler: ui->tabWidget->widget(index) == ui->tab_console
09:17 < emilengler> wumpus: thank you
09:17 < wumpus> emilengler: though usually you shouldn't need to worry what tab is open
09:18 < emilengler> wumpus: Well how does bitcoin-qt then detects when Ctrl+L is pressed? It only works when the console tab is open
09:18 < wumpus> I suppose it only works when the console's input widget is selected
09:19 < wumpus> that's kind of the idea, to use qt's event propagation, it's very rare that you need to go outside that
09:20 < emilengler> The console also clears wiht Ctrl+L if the textbox isn't selected if this is what you've meant
09:24 < wumpus>            <property name="shortcut">
09:24 < wumpus>             <string notr="true">Ctrl+L</string>
09:24 < wumpus>            </property>
09:24 < wumpus> looks like the clearButton has that as shortcut
09:24 < wumpus> I *think* a button will only trigger if it is visible
09:25 < wumpus> so that explains it
09:25 < emilengler> Oh interesting this explains a lot... I searched exactly for this for so long haha
09:27 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds]
09:34 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:34 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 272 seconds]
09:38 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:44 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
09:44 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
09:45 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
09:50 -!- davex__ [~user@45.74.60.130] has joined #bitcoin-core-dev
09:53 -!- michaelfolkson [~textual@82-132-221-138.dab.02.net] has joined #bitcoin-core-dev
10:01 -!- i2 [~i2@195.181.160.175.adsl.inet-telecom.org] has joined #bitcoin-core-dev
10:03 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:11 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
10:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
10:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:23 -!- davterra [~none@64.120.89.22] has quit [Remote host closed the connection]
10:24 -!- davterra [~none@64.120.89.22] has joined #bitcoin-core-dev
10:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:24 < bitcoin-git> [bitcoin] instagibbs opened pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
10:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:26 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
10:29 -!- davterra [~none@64.120.89.22] has quit [Ping timeout: 248 seconds]
10:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
10:30 -!- davterra [~none@64.120.89.22] has joined #bitcoin-core-dev
10:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
10:31 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:36 -!- Dannzor [50d8065f@c80-216-6-95.bredband.comhem.se] has joined #bitcoin-core-dev
10:36 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 248 seconds]
10:40 -!- michaelfolkson [~textual@82-132-221-138.dab.02.net] has quit [Quit: Sleep mode]
10:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds]
10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:44 < bitcoin-git> [bitcoin] hebasto opened pull request #16508: Use ArgsManager::ALLOW_BOOL flag explicitly (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508
10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:49 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev
10:56 -!- michaelsdunn1_ [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: ZNC 1.6.3+deb1+xenial0 - http://znc.in]
11:00 -!- paulk-collins [~paulk-col@185.103.96.147] has quit []
11:04 -!- dougvann [~dougvann@195.206.169.238] has joined #bitcoin-core-dev
11:04 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
11:10 < jonatack> emilengler: git grep Ctrl+L (git grep is your friend :)...)
11:11 -!- Dannzor [50d8065f@c80-216-6-95.bredband.comhem.se] has quit [Remote host closed the connection]
11:11 < emilengler> jonatack: Well I tried the Unix grep but I searched for "Qt::CTRL" and "Qt::Key_L" I thought it was using a QShortcut or something similar
11:17 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds]
11:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:24 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
11:26 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
11:27 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev
11:30 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
11:35 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
11:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
11:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
11:46 -!- i2 [~i2@195.181.160.175.adsl.inet-telecom.org] has quit [Ping timeout: 244 seconds]
11:53 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds]
11:55 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: harrigan]
12:01 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:04 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
12:05 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:06 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
12:06 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
12:07 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:10 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 258 seconds]
12:13 -!- sdupre [~androirc@107.242.116.59] has quit [Remote host closed the connection]
12:13 -!- sdupre [~androirc@107.242.116.59] has joined #bitcoin-core-dev
12:15 -!- jarthur [~jarthur@207.114.244.5] has quit []
12:15 -!- sdupre [~androirc@107.242.116.59] has quit [Read error: Connection reset by peer]
12:20 -!- davterra [~none@64.120.89.22] has quit [Ping timeout: 246 seconds]
12:22 -!- sdupre [~androirc@dynamic-acs-72-23-37-86.zoominternet.net] has joined #bitcoin-core-dev
12:22 -!- jonatack [d598a155@213.152.161.85] has quit [Remote host closed the connection]
12:26 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
12:34 < phantomcircuit> sdaftuar, actually would that be right either? is it true we can't reorg backwards past an overwritten utxo entry?
12:37 < sdaftuar> phantomcircuit: if you reorg past an overwritten utxo, then your utxo state is incorrect/different from if you never connected the block that did the overwrite
12:39 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
12:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
12:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
12:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:54 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
12:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:57 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
12:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:06 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:08 -!- reallll is now known as belcher
13:12 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
13:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:18 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:18 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
13:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
13:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds]
13:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:46 -!- davereikher [8de2f395@141.226.243.149] has joined #bitcoin-core-dev
13:51 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
13:52 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
13:55 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:56 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:57 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
14:00 -!- dougvann [~dougvann@195.206.169.238] has quit []
14:04 -!- Waithamai1 [~Waithamai@192.145.126.244] has joined #bitcoin-core-dev
14:07 -!- davereikher [8de2f395@141.226.243.149] has quit [Ping timeout: 260 seconds]
14:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]
14:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:15 < emilengler> When I call QTabWidget::widget where can I get the index in rpcconsole.cpp?
14:18 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds]
14:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
14:30 < phantomcircuit> hmm i was thinking we could drop the leveldb bloomfilter if the bip30 checks aren't running but actually that makes bogus transactions sent to us much more expensive to handle
14:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:30 < phantomcircuit> currently mostly that's just cpu and bandwidth used, but without the bloomfilters it's potentially also disk access
14:32 -!- sdupre [~androirc@dynamic-acs-72-23-37-86.zoominternet.net] has quit [Read error: Connection reset by peer]
14:35 < phantomcircuit> and that type of transaction, missing utxo can't result in a peer being banned so it's an actual issue
14:40 -!- Raystonn [Raystonn@c-98-210-96-225.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
14:42 < BlueMatt> #proposedmeetingtopic is transaction.nVersion signed or unsigned?
14:43 < BlueMatt> dongcarl: ^ gets to handle that one :)
14:50 < promag> emilengler: what are you trying to do?
15:01 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 272 seconds]
15:01 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:03 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
15:04 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7821821a23b6...5639d71a07db
15:05 < bitcoin-git> bitcoin/master fa6fba3 MarcoFalke: test: Make local symbols in run_test members
15:05 < bitcoin-git> bitcoin/master faf8318 MarcoFalke: test: Split fundrawtx test into subtests
15:05 < bitcoin-git> bitcoin/master 5639d71 MarcoFalke: Merge #16293: test: Make test cases separate functions
15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:08 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds]
15:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:11 < bitcoin-git> [bitcoin] achow101 opened pull request #16512: Shuffle inputs and outputs after joining psbts (master...joinpsbt-rand) https://github.com/bitcoin/bitcoin/pull/16512
15:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:12 < emilengler> promag: I'm trying to check if the user is in a specific tab
15:12 < promag> why?
15:13 < emilengler> Because I want to add a shortcut which should only work in a specifc tab in the debug window
15:13 < emilengler> In the console to be correct
15:13 < emilengler> In bitcoin-qt
15:13 < sipa> a shortcut to do what?
15:14 < emilengler> I want to add a shortcut to close the debug window when the user is in the console
15:14 < emilengler> Ctrl+D
15:14 < emilengler> Like in any other terminal :P
15:15 < promag> you mean close the dialog?
15:15 < sipa> is there a close button?
15:16 < promag> ESC closes (at least on mac)
15:16 -!- rex4539 [~rex4539@2a02:587:3514:c700:b1cc:4273:ad20:982b] has joined #bitcoin-core-dev
15:16 < emilengler> Yes esc closes
15:16 < sipa> emilengler: that seems confusing; to anyone not familiar with a unix console that wouldn't be natural, while every OS probably has its native keybinding already to close windows
15:17 < emilengler> I'm thinking of adding a Ctrl+D beside the esc
15:17 < emilengler> I always get confused for a second or so if I press Ctrl+D and nothing happens
15:17 < emilengler> So I thought it would be a good addition
15:17 < sipa> (feel free to ignore my comments, i never use the UI)
15:17 < luke-jr> well, Ctrl-D is EOF, not "close window"
15:17  * luke-jr wonders what happens if you Ctrl-D in a cmd.exe window
15:18 < luke-jr> emilengler: if you do add it, it probably should only work if the text entry has focus specifically
15:18 < sipa> i guess Ctrl-J and Ctrl-M should also newline then
15:19 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
15:19 < emilengler> luke-jr: Does EOF stops a process?
15:19 < emilengler> In common shells it does
15:19 < sipa> emilengler: no, it sends EOF on stdin
15:19 < sipa> which many programs use a signal to quit
15:20 < emilengler> ok, thanks
15:20 < sipa> Ctrl-J sends newline, Ctrl-A sends BELL, ...
15:20 < sipa> there are a bunch of other control characters you can compose that way
15:21 < emilengler> sipa: You might be right but Ctrl+L is also implemented
15:21 < emilengler> Is this a control character as well?
15:21 < sipa> yes
15:21 < sipa> emilengler: http://www.asciitable.com/
15:21 < promag> emilengler: even if your idea is accepted it won't have the same behavior
15:21 < emilengler> But the most common control-chars are Ctrl+D and Ctrl+L (at least in my case)
15:22 < emilengler> promag: Why because it won't use a key event or because it wont send an EOF?
15:22 < emilengler> QKeyEvent
15:22 < sipa> emilengler: L = 12th position in alphabet, Ctrl-L = ASCII 12 = form feed = clear page
15:22 < sipa> emilengler: D = 4th position in alphabet, Ctrl-D = ASCII 4 = end of transmission
15:23 < sipa> emilengler: J = 10th position in alphabet, Ctrl-D = ASCII 10 = new line
15:23 < sipa> eh, Ctrl-J
15:23 < emilengler> sipa: thank you this explains a lot of stuff but Ctrl+L does not transmit this singal IIRC
15:23 < promag> emilengler: because you can't "terminate" the bitcoin-qt terminal
15:23 < sipa> emilengler: i don't know what you mean
15:23 < promag> emilengler: you would just hide/close the dialog
15:24 < emilengler> promag: But you can close the window the idea was a "synonym" for the esc
15:24 < promag> I'm sure you can find other stuff to improve on the gui
15:25 < emilengler> You might be right :) but when we already have Ctrl+L why not Ctrl+D then
15:27 < promag> feel free to submit the PR, I just think that on the gui ESC is more natural, people are used to close dialogs with ESC
15:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
15:28 < sipa> emilengler: can't you add a shortcut to a button in Qt? if so, that should be enough
15:28 < sipa> without trying to infer what tab you're on
15:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:28 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
15:28 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:29 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16513: Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513
15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:29 < emilengler> promag: Sure but for people who are there whole day in terminal emulators Ctrl+D is more natural I think
15:30 < emilengler> sipa: Sure but there is no close button in the qt gui
15:30 < emilengler> Only the window manager close button
15:30 < sipa> yeah ok
15:30 < sipa> and adding one would be redundant
15:31 < promag> not sure if it would work but try adding a QAction with the respective shortcut to the tab
15:33 < emilengler> promag: Already read that something like this is possible but tbh I'm a bloody beginner in Qt. I'm completely unable to design something that's why I always stick to cli programming
15:33 < sipa> haha
15:33 < sipa> sounds familiar
15:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
15:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:35 < bitcoin-git> [bitcoin] promag opened pull request #16514: gui: Remove unused RPCConsole::tabFocus (master...2019-07-remove-unused-tabfocus) https://github.com/bitcoin/bitcoin/pull/16514
15:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:37 < tryphe> emilengler, i've been using Qt for 20 years and i still prefer cli :p
15:40 < emilengler> tryphe: You may love or may hate gui design there is nothing inbetween
15:44 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
15:44 < tryphe> emilengler, to me, a cli is somewhere between having a gui and no interface, where later on you'd just build the gui on the same interface the cli uses
15:46 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
15:46 < emilengler> tryphe: It depends what do you mean by cli something like an interactive shell (like the openbsd installer), a curses(-like) application or just a program which you start with some args and prints log infos in the console
15:46 < tryphe> emilengler, yes, all of those
15:47 < emilengler> tryphe: Same in my definition a cli application is everything which displays text in a console
15:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
15:56 -!- jnewbery_ [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds]
15:56 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds]
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:56 < bitcoin-git> [bitcoin] promag opened pull request #16515: gui: Close console with CTRL+D ala terminal (master...2019-07-console-ctrld) https://github.com/bitcoin/bitcoin/pull/16515
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:57 < promag> emilengler: I can add you as co author if you like, or if you prefer you can pick that commit, re-work it and submit another pr (I'll close mine in that case)
15:58 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev
15:58 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
16:09 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
16:12 < promag> fanquake: https://github.com/bitcoin/bitcoin/pull/16502#event-2522283884 can be removed
16:12 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 245 seconds]
16:15 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Ping timeout: 258 seconds]
16:19 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
16:20 < emilengler> promag: Sorry my internet connection died, what do you meant?
16:20 < emilengler> Do you mean #16515
16:20 < gribble> https://github.com/bitcoin/bitcoin/issues/16515 | gui: Close console with CTRL+D ala terminal by promag · Pull Request #16515 · bitcoin/bitcoin · GitHub
16:20 < promag> y
16:21 < emilengler> Ok, I will take a look at it
16:21 < emilengler> But thank you a lot :)
16:22 < fanquake> promag: yep
16:23 < emilengler> Ok I'm compiling it right now, will write a comment then
16:24 < emilengler> How good that I deleted my already compiled dir -.-
16:25 -!- ptiyoyip [~hgfdfgh@77.243.23.229] has joined #bitcoin-core-dev
16:26 < promag> how do you build?
16:27 < emilengler> The classic way, ./autogen.sh; ./configure; make
16:29 -!- dgfhdfg [~hgfdfgh@77.243.23.229] has quit [Ping timeout: 245 seconds]
16:29 < promag> emilengler: make -j8 -C src/qt bitcoin-qt
16:30 < emilengler> promag: Yeah I was more git oriented like cloning your branch it my local repo
16:31 < emilengler> Maybe with git remote add promap https://github.com/promag/bitcoin.git; git fetch promag; git rebase promag/yourbranch yourbranch
16:31 < emilengler> But now it is too late already
16:34 < promag> emilengler: mayeb read https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#reference-prs-easily-with-refspecs
16:39 < emilengler> thx
16:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:55 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5639d71a07db...25f0edd59fee
16:55 < bitcoin-git> bitcoin/master fa2f991 Torkel Rogstad: doc: add note on precedence of options in bitcoin.conf
16:55 < bitcoin-git> bitcoin/master 25f0edd fanquake: Merge #16448: doc: add note on precedence of options in bitcoin.conf
16:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:56 < bitcoin-git> [bitcoin] fanquake merged pull request #16448: doc: add note on precedence of options in bitcoin.conf (master...options_bitocin_conf) https://github.com/bitcoin/bitcoin/pull/16448
16:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:58 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has joined #bitcoin-core-dev
17:00 -!- Waithamai1 [~Waithamai@192.145.126.244] has quit []
17:03 -!- Mark_Cockrell [~Mark_Cock@185.204.1.185] has joined #bitcoin-core-dev
17:08 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Quit: Leaving]
17:20 -!- lightlike [~lightlike@2001:16b8:57bf:800:a5cf:5b01:180a:96c] has quit [Quit: Leaving]
17:21 < emilengler> WHere does bitcoin-qt deals with the config?
17:22 < emilengler> Nevermind, I think I've found it in src/qt/optionsmodel.cpp
17:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:36 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Ping timeout: 272 seconds]
17:37 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has quit [Quit: Sleep mode]
17:43 -!- ptiyoyip [~hgfdfgh@77.243.23.229] has quit [Quit: Leaving]
17:47 -!- Krellan [~Krellan@50.227.64.178] has joined #bitcoin-core-dev
17:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:00 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 248 seconds]
18:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
18:55 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
18:56 -!- davterra [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
18:57 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev
19:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-isjyuaalbhbfdvbq] has quit [Quit: Connection closed for inactivity]
19:02 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 244 seconds]
19:03 -!- cryptapus_ is now known as cryptapus
19:11 -!- YonCole [4726475f@71-38-71-95.lsv2.qwest.net] has joined #bitcoin-core-dev
19:11 -!- ercwl [~ercwl@82-183-6-234.customers.ownit.se] has quit [Quit: ercwl]
19:18 < kallewoof> So, DrahtBot added a bunch of flags to #16440 (BIP322 PR). Not sure I agree with Build system flag, though.
19:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16440 | BIP-322: Generic signed message format by kallewoof · Pull Request #16440 · bitcoin/bitcoin · GitHub
19:18 < kallewoof> s/flags/labels/
19:19 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
19:19 < fanquake> kallewoof: I'll sort that out. The bot isn't great at adding labels to large changes.
19:20 < sipa> kallewoof: i assume that's just because it's touching Makefile.am
19:20 < kallewoof> sipa: You're probably right!
19:20 < kallewoof> fanquake: Thanks :)
19:25 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has quit [Ping timeout: 244 seconds]
19:26 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev
19:33 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:35 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Client Quit]
20:00 -!- Mark_Cockrell [~Mark_Cock@185.204.1.185] has quit []
20:04 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev
20:04 -!- hack_bot [~hack_bot@141.98.102.243] has joined #bitcoin-core-dev
20:06 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:08 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
20:09 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:12 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
20:13 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:17 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
20:18 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
20:18 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:41 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
21:07 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
21:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-dmyodtygbfxbndfz] has joined #bitcoin-core-dev
21:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:13 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25f0edd59fee...b7fbf74b980e
21:13 < bitcoin-git> bitcoin/master 0b1f4b3 João Barbosa: wallet: Drop unused OldKey
21:13 < bitcoin-git> bitcoin/master b7fbf74 fanquake: Merge #16502: wallet: Drop unused OldKey
21:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:15 < bitcoin-git> [bitcoin] fanquake merged pull request #16502: wallet: Drop unused OldKey (master...2019-07-drop-oldkey) https://github.com/bitcoin/bitcoin/pull/16502
21:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds]
21:46 -!- davereikher [8de2f395@141.226.243.149] has joined #bitcoin-core-dev
21:55 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
21:56 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
22:00 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds]
22:16 -!- YonCole [4726475f@71-38-71-95.lsv2.qwest.net] has quit [Ping timeout: 260 seconds]
22:24 -!- EF [75d53a6c@117.213.58.108] has joined #bitcoin-core-dev
22:44 -!- davereikher [8de2f395@141.226.243.149] has quit [Remote host closed the connection]
22:49 -!- Krellan [~Krellan@50.227.64.178] has quit [Remote host closed the connection]
22:52 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Ping timeout: 246 seconds]
22:56 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Remote host closed the connection]
22:58 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev
23:00 -!- hack_bot [~hack_bot@141.98.102.243] has quit []
23:02 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 245 seconds]
23:04 -!- ao2 [~ao2@178.162.204.238] has joined #bitcoin-core-dev
23:04 -!- ao2 is now known as Guest64082
23:09 -!- davereikher [~dave@141.226.243.149] has joined #bitcoin-core-dev
23:15 -!- davereikher [~dave@141.226.243.149] has quit [Quit: WeeChat 1.4]
23:16 -!- davereikher [~davereikh@141.226.243.149] has joined #bitcoin-core-dev
23:16 < fanquake> Doing a binary comparison of a bitcoin-qt built from HEAD~1 and HEAD~2, building on Debian using depends. Currently seeing this diff: https://gist.github.com/fanquake/653bb42176d7772578db08a0f8e60f11 . Any suggestions as to what could be causing the difference? bitcoind matches.
23:17 < fanquake> The change in the src between the two is only in Python test code, so that should be it.
23:17 < fanquake> *shouldn't
23:18 -!- davereikher [~davereikh@141.226.243.149] has quit [Client Quit]
23:20 -!- davereikher [~davereikh@141.226.243.149] has joined #bitcoin-core-dev
23:20 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-dmyodtygbfxbndfz] has quit [Quit: Connection closed for inactivity]
23:22 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Quit: reboot]
23:31 -!- davereikher [~davereikh@141.226.243.149] has quit [Quit: WeeChat 1.4]
23:33 < wumpus> fanquake: do you happen to know what section this difference is in?
23:34 < wumpus> e.g. if it's in .text it might be useful to look at the disassembly
23:35 < fanquake> wumpus Ok. I'm just rebuilding, but assume the same diff will happen again, can check that for you shortly.
23:36 < wumpus> was about to ask that: if you get this difference without any C code changes, then, I wonder if you do get a stable output running it on the same commit again and again
23:38 < fanquake> Hopefully we'll know that shortly 🔍 
23:40 < wumpus> if the difference is only in -qt it could suggest non-determinism in one of the qt tools
23:45 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
23:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
23:48 < wumpus> i don't think i've ever used build-for-compare with bitcoin-qt, at all
23:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
23:55 -!- EF74 [75d53a6c@117.213.58.108] has joined #bitcoin-core-dev
23:55 -!- EF [75d53a6c@117.213.58.108] has quit [Ping timeout: 260 seconds]
23:58 < wumpus> running the same compare now
23:59 < fanquake> wumpus: testing the new depends --prefix as well?
--- Log closed Thu Aug 01 00:00:27 2019