--- Log opened Mon Aug 05 00:00:30 2019 00:15 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 00:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:19 -!- Victor_sueca is now known as Victorsueca 00:25 -!- Julia73Armstrong [~Julia73Ar@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 00:34 < jonasschnelli> fanquake: nice! 00:35 < jonasschnelli> (flamegraph) 00:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 00:35 < jonasschnelli> I remember doing one with – was it callgrind – ? I think they can be of great use. 00:37 -!- kcalvinalvin [~calvin@14.52.115.204] has joined #bitcoin-core-dev 00:38 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 00:40 -!- kcalvinalvin [~calvin@14.52.115.204] has quit [Remote host closed the connection] 00:41 -!- kcalvinalvin [~calvin@104.143.95.21] has joined #bitcoin-core-dev 00:42 -!- kljasdfvv [~flack@p200300D46F0E7800113D08F2E7B727CA.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:49 -!- kcalvina_ [~calvin@14.52.115.204] has joined #bitcoin-core-dev 00:52 < fanquake> jonasschnelli: thanks. Just using dtrace for now. Trying to improve the coloured output a bit. 00:52 < fanquake> I've now split it up such that LevelDB is green, Boost blue, system is orange and Core yellow. Still not perfect. 00:52 -!- kcalvinalvin [~calvin@104.143.95.21] has quit [Ping timeout: 244 seconds] 00:53 < fanquake> Also higher resolution now. Couple more examples: 00:53 < fanquake> Startup: https://imgur.com/a/yTav68E 00:53 < fanquake> Later into IBD: https://imgur.com/a/LDugOpK 00:53 -!- Julia73Armstrong [~Julia73Ar@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 246 seconds] 00:55 -!- shesek` [~shesek@141.226.218.109] has quit [Ping timeout: 258 seconds] 00:56 < jonasschnelli> fanquake: I think they are interactive (JS/HTML)... 00:57 < jonasschnelli> I'm interested to generate one for every master commit.... 00:57 < fanquake> jonasschnelli: yes, it generates SVGs, that you can click on, filter, search through etc 00:57 < jonasschnelli> Ah. 00:57 < fanquake> I'd upload the SVGs for others to look at directly, but I'm not sure where to do that quickly/easily ? 00:58 < fanquake> imgur or github wont accept them 00:58 < jonasschnelli> Similar to the CI I run, maybe we can run Startup / IBD. etc. on a dedicated calm system and callgrind/flamgraph it. So comparision is possible 00:58 < jonasschnelli> fanquake: have a server somewhere. :P 00:59 < fanquake> jonasschnelli: heh yea 01:00 < fanquake> i.e If you drill down by selecting the calls you are interested in: https://imgur.com/a/1fPFb2S 01:13 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:34 -!- promag [~promag@83.223.235.134] has joined #bitcoin-core-dev 01:39 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 244 seconds] 01:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 01:45 -!- kcalvina_ [~calvin@14.52.115.204] has quit [Ping timeout: 272 seconds] 01:46 -!- kcalvinalvin [~calvin@14.52.115.204] has joined #bitcoin-core-dev 01:56 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:58 < kallewoof> While writing code to do the reorg feature in signet, I realized something really weird happened to my node when it switched chains. It was basically submitting several hundred transactions to the mempool for relay, despite those transactions being already mined and confirmed (some 4000+ blocks earlier). 02:00 -!- gonemad3 [~gonemad3@185.204.1.185] has quit [] 02:01 < kallewoof> I think those transactions are coinbase transactions, too. But maybe not all of them. Example -> https://pastebin.com/NHBJcUGP 02:03 -!- quaid1 [~quaid@185.59.221.95] has joined #bitcoin-core-dev 02:10 -!- promag [~promag@83.223.235.134] has quit [Remote host closed the connection] 02:12 -!- promag [~promag@83.223.235.134] has joined #bitcoin-core-dev 02:14 -!- promag [~promag@83.223.235.134] has quit [Remote host closed the connection] 02:14 -!- promag [~promag@83.223.235.134] has joined #bitcoin-core-dev 02:17 < promag> someone can review/merge #16404? ty 02:17 < gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub 02:21 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 02:26 -!- promag [~promag@83.223.235.134] has quit [Read error: Connection reset by peer] 02:26 -!- promag [~promag@83.223.235.134] has joined #bitcoin-core-dev 02:27 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:42 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev 02:43 -!- jonatack [d598a2a5@213.152.162.165] has quit [Remote host closed the connection] 02:50 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds] 02:52 -!- kcalvinalvin [~calvin@14.52.115.204] has quit [Remote host closed the connection] 02:56 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 03:04 -!- shesek` [~shesek@141.226.152.112] has joined #bitcoin-core-dev 03:28 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 03:30 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 03:30 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection] 03:32 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 03:36 -!- shesek` [~shesek@141.226.152.112] has quit [Ping timeout: 248 seconds] 03:56 -!- promag [~promag@83.223.235.134] has quit [Remote host closed the connection] 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e55444a2a8a2...6b6386e85492 04:50 < bitcoin-git> bitcoin/master fa566b2 MarcoFalke: test: Add missing sync_blocks to feature_pruning 04:50 < bitcoin-git> bitcoin/master 6b6386e MarcoFalke: Merge #16538: test: Add missing sync_blocks to feature_pruning 04:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538 04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:54 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b6386e85492...1063fc9cf9b5 04:56 < bitcoin-git> bitcoin/master 05fdb97 Antoine Riard: [doc] Update and extend benchmarking.md 04:56 < bitcoin-git> bitcoin/master 1063fc9 MarcoFalke: Merge #16536: doc: Update and extend benchmarking.md 04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16536: doc: Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536 04:57 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- quaid1 [~quaid@185.59.221.95] has quit [] 05:01 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1063fc9cf9b5...c77f7cdbd1ce 05:02 < bitcoin-git> bitcoin/master fa883ab MarcoFalke: net: Use mockable time for tx download 05:02 < bitcoin-git> bitcoin/master fab3658 Suhas Daftuar: [qa] Test that getdata requests work as expected 05:02 < bitcoin-git> bitcoin/master c77f7cd MarcoFalke: Merge #16197: net: Use mockable time for tx download 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16197: net: Use mockable time for tx download (master...1906-netMock) https://github.com/bitcoin/bitcoin/pull/16197 05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:04 -!- seawalk [~seawalk@141.98.102.243] has joined #bitcoin-core-dev 05:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c77f7cdbd1ce...d5ea8f4bf39a 05:09 < bitcoin-git> bitcoin/master 68f5466 Ben Woosley: test: Fix “local variable 'e' is assigned to but never used” 05:09 < bitcoin-git> bitcoin/master fa8a1d7 MarcoFalke: test: Adapt test framework for chains other than "regtest" 05:09 < bitcoin-git> bitcoin/master faf3683 MarcoFalke: test: Avoid hardcoding the chain name in combine_logs 05:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16509: test: Adapt test framework for chains other than "regtest" (master...1908-testChainName) https://github.com/bitcoin/bitcoin/pull/16509 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:12 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 05:12 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:17 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Client Quit] 05:17 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5ea8f4bf39a...62117f9f363e 05:17 < bitcoin-git> bitcoin/master 77770d9 MarcoFalke: test: Properly serialize BIP34 coinbase height 05:17 < bitcoin-git> bitcoin/master fa8489a MarcoFalke: test: Add test for BIP30 duplicate tx 05:17 < bitcoin-git> bitcoin/master 62117f9 MarcoFalke: Merge #16363: test: Add test for BIP30 duplicate tx 05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16363: test: Add test for BIP30 duplicate tx (master...1907-qaBIP30) https://github.com/bitcoin/bitcoin/pull/16363 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:20 -!- brianhoffman_ [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev 05:21 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds] 05:21 -!- brianhoffman_ is now known as brianhoffman 05:26 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 05:26 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:36 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 05:36 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:39 -!- promag [~promag@83.223.235.134] has joined #bitcoin-core-dev 05:43 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 05:44 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:47 -!- lightlike [~lightlike@2001:16b8:5734:7300:4022:2c77:1536:107] has joined #bitcoin-core-dev 05:55 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 05:56 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 05:59 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 06:17 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 06:19 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Max SendQ exceeded] 06:19 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 06:20 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Max SendQ exceeded] 06:20 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 06:22 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Remote host closed the connection] 06:30 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds] 06:32 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 248 seconds] 06:36 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 07:14 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 07:17 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Max SendQ exceeded] 07:17 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 07:21 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Read error: Connection reset by peer] 07:40 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 245 seconds] 07:40 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:43 -!- Xunie [~Xunie@unaffiliated/xunie] has quit [Ping timeout: 252 seconds] 07:43 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:51 -!- promag [~promag@83.223.235.134] has quit [Remote host closed the connection] 07:52 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 258 seconds] 07:54 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:56 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:57 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:00 -!- seawalk [~seawalk@141.98.102.243] has quit [] 08:15 -!- tomatopotato [~tomatopot@185.204.1.185] has joined #bitcoin-core-dev 08:17 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Quit: WeeChat 2.4] 08:18 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 08:19 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Read error: Connection reset by peer] 08:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:41 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 08:45 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 245 seconds] 08:48 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:51 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] ajtowns closed pull request #16229: Standardise deployment handling (master...201906-deployments) https://github.com/bitcoin/bitcoin/pull/16229 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:54 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:54 < bitcoin-git> [bitcoin] Alko89 opened pull request #16547: Check usages of #if defined(...) (master...if-defined-usages) https://github.com/bitcoin/bitcoin/pull/16547 08:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 09:16 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 09:30 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:35 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:42 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev 09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:43 < bitcoin-git> [bitcoin] hebasto closed pull request #16508: Disallow double negation syntax (-nofoo=0) for options (master...20190731-allow-bool) https://github.com/bitcoin/bitcoin/pull/16508 09:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:45 < MarcoFalke> [04:58] While writing code to do the reorg feature in signet, I realized something really weird happened to my node when it switched chains. It was basically submitting several hundred transactions to the mempool for relay, despite those transactions being already mined and confirmed (some 4000+ blocks earlier). 09:45 < MarcoFalke> Probably due to the wallet refactor on tx re-submission 09:45 < MarcoFalke> the IsCoinBase check was removed 09:45 < MarcoFalke> cc ariard 09:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:46 < MarcoFalke> #16452 09:46 < gribble> https://github.com/bitcoin/bitcoin/issues/16452 | refactor: use RelayTransaction in BroadcastTransaction utility by ariard · Pull Request #16452 · bitcoin/bitcoin · GitHub 09:47 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:48 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] mmachicao opened pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:50 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 246 seconds] 09:54 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:01 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:06 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 272 seconds] 10:08 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:08 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] emilengler closed pull request #16544: rpc: Add rpcallowstop (master...2019-08-rpc-disable-stop-parameter) https://github.com/bitcoin/bitcoin/pull/16544 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:12 -!- ctrlbreak_MAD [~ctrlbreak@142.134.84.46] has joined #bitcoin-core-dev 10:15 -!- ctrlbreak [~ctrlbreak@142.134.84.46] has quit [Ping timeout: 246 seconds] 10:22 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 10:25 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev 10:27 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:33 -!- jonatack [d598a2a5@213.152.162.165] has joined #bitcoin-core-dev 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:38 < bitcoin-git> [bitcoin] Sjors opened pull request #16549: [WIP] UI external signer support (e.g. hardware wallet) (master...2019/08/hww-qt) https://github.com/bitcoin/bitcoin/pull/16549 10:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:38 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 10:39 < provoostenator> ^ that was supposed to be Draft 10:45 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 10:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:47 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 248 seconds] 10:49 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 245 seconds] 10:57 -!- pseudoImposter [9d21ac6a@157.33.172.106] has joined #bitcoin-core-dev 11:00 -!- tomatopotato [~tomatopot@185.204.1.185] has quit [] 11:05 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds] 11:12 -!- rex4539 [~rex4539@2a02:587:3514:c700:7cdf:db87:30fd:3f1] has joined #bitcoin-core-dev 11:15 -!- Bille [~Bille@141.98.101.133] has joined #bitcoin-core-dev 11:16 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 11:18 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:26 -!- rex4539 [~rex4539@2a02:587:3514:c700:7cdf:db87:30fd:3f1] has quit [Read error: Connection reset by peer] 11:28 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:30 -!- jimpo [~jimpo@ec2-13-57-39-52.us-west-1.compute.amazonaws.com] has joined #bitcoin-core-dev 11:30 -!- jarthur [~jarthur@207.114.244.5] has quit [] 11:31 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection] 11:32 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 11:32 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 11:36 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 245 seconds] 11:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 11:39 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Leaving] 11:42 < kallewoof> MarcoFalke: Hm, not sure if 16452 is related or not from looking at the changes. Anyway Ithink you can trigger this by simply starting two regtest nodes and reorging one to the other. They should start spamming those messages I think 11:47 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:53 -!- pseudoImposter [9d21ac6a@157.33.172.106] has quit [Remote host closed the connection] 11:54 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 11:55 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:08 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 258 seconds] 12:08 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 12:09 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 12:16 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 12:21 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:24 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 12:26 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:54 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Remote host closed the connection] 12:54 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 12:55 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Remote host closed the connection] 12:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:08 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 13:12 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 13:13 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 13:13 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 13:14 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:18 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:18 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 246 seconds] 13:20 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 13:24 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 13:43 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Quit: leaving] 13:47 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:58 -!- arubi [~ese168@93-173-92-91.bb.netvision.net.il] has joined #bitcoin-core-dev 13:58 -!- arubi [~ese168@93-173-92-91.bb.netvision.net.il] has quit [Remote host closed the connection] 14:00 -!- Bille [~Bille@141.98.101.133] has quit [] 14:00 -!- arubi [~ese168@unaffiliated/ese168] has joined #bitcoin-core-dev 14:02 -!- eothica [503e7539@80-62-117-57-mobile.dk.customer.tdc.net] has joined #bitcoin-core-dev 14:04 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:05 -!- Morgon1 [~Morgon@89.249.74.218] has joined #bitcoin-core-dev 14:05 -!- arubi [~ese168@unaffiliated/ese168] has quit [Quit: Leaving] 14:06 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 14:06 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 14:06 -!- arubi_ is now known as arubi 14:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:11 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 14:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 14:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 14:20 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 245 seconds] 14:28 < sanket1729> and(pk(C),or(pk(C),or(9@pk(C),older(1000)))) 14:29 < sipa> what is this arcane language you utter? 14:29 < sanket1729> oops, sorry 14:31 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:32 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 268 seconds] 14:37 -!- eothica [503e7539@80-62-117-57-mobile.dk.customer.tdc.net] has quit [Remote host closed the connection] 14:38 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [] 14:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 14:48 -!- pinheadmz [~matthewzi@209.209.238.169] has joined #bitcoin-core-dev 14:48 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 14:49 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Client Quit] 14:58 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Remote host closed the connection] 14:58 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 14:59 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has joined #bitcoin-core-dev 14:59 -!- dgfhdfg [~hgfdfgh@188.120.117.157] has quit [Remote host closed the connection] 15:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 15:04 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 258 seconds] 15:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16551: test: Test that low difficulty chain fork is rejected (master...1908-testDosLowHeader) https://github.com/bitcoin/bitcoin/pull/16551 15:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:07 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:08 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 15:09 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 15:10 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 15:10 -!- promag [~promag@92.250.103.185] has joined #bitcoin-core-dev 15:11 -!- Emcy [~Emcy@200.177.9.51.dyn.plus.net] has joined #bitcoin-core-dev 15:11 -!- Emcy [~Emcy@200.177.9.51.dyn.plus.net] has quit [Changing host] 15:11 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:17 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving] 15:18 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 15:19 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:26 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [] 15:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 15:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 15:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 15:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:02 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 16:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:19 -!- confused [62d18e0e@98.209.142.14] has joined #bitcoin-core-dev 16:28 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 16:29 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Ping timeout: 248 seconds] 16:32 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 248 seconds] 16:44 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 16:45 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 17:00 -!- Morgon1 [~Morgon@89.249.74.218] has quit [] 17:00 -!- Cory [Cory@unaffiliated/cory] has joined #bitcoin-core-dev 17:08 -!- aqu4 [~aqu4@185.204.1.185] has joined #bitcoin-core-dev 17:09 -!- confused [62d18e0e@98.209.142.14] has quit [Remote host closed the connection] 17:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 17:26 -!- tryphe_ is now known as tryphe 17:28 -!- jonatack [d598a2a5@213.152.162.165] has quit [Ping timeout: 260 seconds] 17:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:28 -!- Haitham [2f978978@47.151.137.120] has joined #bitcoin-core-dev 17:30 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 17:32 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 17:32 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has left #bitcoin-core-dev [] 17:32 -!- Haitham [2f978978@47.151.137.120] has quit [Remote host closed the connection] 17:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:41 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 17:42 -!- profmac [~ProfMac@2001:470:1f0f:226:287b:524f:a939:ffc6] has quit [Ping timeout: 250 seconds] 17:47 -!- lightlike [~lightlike@2001:16b8:5734:7300:4022:2c77:1536:107] has quit [Quit: Leaving] 17:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:56 -!- profmac [~ProfMac@2001:470:1f0f:226:a102:76f4:a967:8936] has joined #bitcoin-core-dev 17:58 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 17:58 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 17:59 -!- kljasdfvv [~flack@p200300D46F0E7800113D08F2E7B727CA.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 18:00 -!- kljasdfvv [~flack@p200300D46F0E7800611D199F7B7450EF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 18:02 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Client Quit] 18:06 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 18:08 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 18:23 -!- pinheadmz [~matthewzi@209.209.238.169] has quit [Quit: pinheadmz] 18:25 -!- promag [~promag@92.250.103.185] has quit [Remote host closed the connection] 18:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:39 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62117f9f363e...31d98584f3c5 18:39 < bitcoin-git> bitcoin/master fa5a4cd MarcoFalke: gui: Generate bech32 addresses by default (take 2, fixup) 18:39 < bitcoin-git> bitcoin/master 31d9858 fanquake: Merge #16497: gui: Generate bech32 addresses by default (take 2, fixup) 18:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:40 < bitcoin-git> [bitcoin] fanquake merged pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497 18:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:54 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d98584f3c5...fbe4b7665b97 18:54 < bitcoin-git> bitcoin/master b2ea20d Kristian Kramer: doc: Fix grammar and punctuation in developer notes 18:54 < bitcoin-git> bitcoin/master fbe4b76 fanquake: Merge #16530: doc: Fix grammar and punctuation in developer notes 18:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:55 < bitcoin-git> [bitcoin] fanquake merged pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530 18:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 18:58 -!- promag [~promag@92.250.103.185] has joined #bitcoin-core-dev 19:03 -!- promag [~promag@92.250.103.185] has quit [Ping timeout: 272 seconds] 20:00 -!- aqu4 [~aqu4@185.204.1.185] has quit [] 20:04 -!- Eprom [~Eprom@141.98.102.243] has joined #bitcoin-core-dev 20:10 < emilengler> Does the argmanager also loads the bitcoin.conf? Or is this being done seperately 20:16 < ariard> kallewoof: but did your txn land in your mempool or were bounced-off by ATMP ? 20:16 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 20:18 < ariard> MarcoFalke: yes I agree, if I'm correct MaybeResendWallet will rebroadcast no matter what age? 20:28 < fanquake> I've added some Flame Graph notes to core-review: https://github.com/fanquake/core-review/tree/master/flamegraph 20:29 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 20:33 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 245 seconds] 20:40 < ariard> oh that's nice, it's interesting to see how much reads are expensive even if it's something you always expect 20:45 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection] 20:46 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 20:48 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 20:49 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 20:54 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 245 seconds] 21:06 < kallewoof> ariard: no the mempool is empty afterwards, it's just a big spam fest listing every coinbase ever mined by that node (i think) 21:15 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rnmnqbltvjwgcwfz] has quit [Quit: Connection closed for inactivity] 21:28 < kallewoof> This was not the case. Not sure what was different. --> MarcoFalke: Hm, not sure if 16452 is related or not from looking at the changes. Anyway Ithink you can trigger this by simply starting two regtest nodes and reorging one to the other. They should start spamming those messages I think 21:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds] 21:41 -!- Krellan [~Krellan@2601:640:4100:ac00:1cb7:74c9:204f:c056] has quit [Quit: Leaving...] 21:52 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:59 -!- Krellan [~Krellan@2601:640:4100:ac00:f48b:59c9:3a4d:445c] has joined #bitcoin-core-dev 22:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:10 -!- _atos [~quassel@109.252.72.133] has joined #bitcoin-core-dev 22:29 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 22:33 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 268 seconds] 22:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 22:37 < ariard> kallewoof: my PR removed coinbase check in SubmitMemoryPoolAndRelay because it was already checked in ATMP, what you're saying is coinbase txn being resubmited to mempool despite being confirmed? 22:44 -!- kcalvinalvin [~calvin@118.131.103.244] has joined #bitcoin-core-dev 22:59 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:00 -!- Eprom [~Eprom@141.98.102.243] has quit [] 23:04 -!- rawtaz1 [~rawtaz@185.103.96.147] has joined #bitcoin-core-dev 23:08 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 23:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds] 23:25 < fanquake> wumpus: looks like there is also at least 5204, 4908, 3095, 2936 23:29 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 272 seconds] 23:31 < wumpus> fanquake: ooh fun 23:35 < wumpus> fanquake: we should deprecate problematic things more often :) 23:35 < fanquake> wumpus: I agree 23:36 < fanquake> wumpus: I actually rebased my disable BIP70 by default PR earlier today as well.. #15584 23:36 < gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub 23:37 -!- promag [~promag@92.250.98.24] has joined #bitcoin-core-dev 23:37 < wumpus> fanquake:thanks ! 23:40 < fanquake> wumpus: also 5722, 2302 23:41 -!- promag [~promag@92.250.98.24] has quit [Ping timeout: 272 seconds] 23:46 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev --- Log closed Tue Aug 06 00:00:31 2019