--- Log opened Wed Aug 07 00:00:32 2019 00:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 00:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 00:06 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:38 -!- sylvanas [~sylvanas@81.28.175.196] has joined #bitcoin-core-dev 00:42 -!- sylvanas [~sylvanas@81.28.175.196] has left #bitcoin-core-dev [] 00:54 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:26 < fanquake> jonasschnelli: Will you be uploading some macOS sigs soonish? I can only see win sigs for 0.18.1 so far. 01:28 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:28 < jonasschnelli> fanquake: I will take a look when I'm back in my office (3-4h). 01:28 < fanquake> jonasschnelli: thanks! 01:33 -!- jonatack [6dca6b93@109.202.107.147] has joined #bitcoin-core-dev 01:36 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:52 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:00 -!- ironmarx [~ironmarx@178.162.204.238] has quit [] 02:02 < kallewoof> jnewbery: see my comment on your PR 02:04 -!- Kim2 [~Kim@178.162.204.238] has joined #bitcoin-core-dev 02:16 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 02:16 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 245 seconds] 02:17 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 02:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:39 -!- setpill [~setpill@unaffiliated/setpill] has quit [Read error: Connection reset by peer] 02:41 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:45 < fanquake> promag: re steps to reproduce #16307 (sorry it's taken so long). The best I can give you is just spam load and unload wallet actions from the GUI. "Eventually" it might happen. 02:45 < gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub 02:45 < fanquake> I saw a different, new crash today as well: https://gist.github.com/fanquake/678aea41c7d6a4f7de8e2ebf1efc3467 02:51 -!- ThomasLuong [~ThomasLuo@2601:1c2:0:f0ba:6461:76b3:8e16:6334] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:52 -!- ercwl [~ercwl@94.234.45.80] has joined #bitcoin-core-dev 03:08 -!- jonatack [6dca6b93@109.202.107.147] has quit [Remote host closed the connection] 03:25 < provoostenator> Fun fact, and something to be aware of when reviewing: if Travis flags the account of a contributor, it won't build their pull request. 03:25 < provoostenator> This doesn't show up as a failure! You still see a green check mark under the PR because of AppVeyor. 03:26 < provoostenator> Also Travis doesn't email you when they flag your account, which is I why I didn't found out for days, see e.g. #16555 03:26 < gribble> https://github.com/bitcoin/bitcoin/issues/16555 | [doc] mention whitelist is inbound, and applies to blocksonly by Sjors · Pull Request #16555 · bitcoin/bitcoin · GitHub 03:26 < provoostenator> (I contacted their support now to ask what happened) 03:27 -!- promag [~promag@31.22.202.43] has joined #bitcoin-core-dev 03:28 < promag> fanquake: ok thanks, I'll see what I can find 03:33 -!- ercwl [~ercwl@94.234.45.80] has quit [Quit: ercwl] 03:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:51 -!- rex4539 [~rex4539@2a02:587:3514:c700:703b:92ad:399f:1b00] has joined #bitcoin-core-dev 04:03 -!- lightlike [~lightlike@2001:16b8:5797:1d00:a4ab:d863:44bc:ec79] has joined #bitcoin-core-dev 04:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:21 < bitcoin-git> [bitcoin] practicalswift opened pull request #16561: tests: Add test_runner.py option --parsable (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561 04:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:22 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Quit: (。-ω-) zzz..] 04:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 04:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:50 -!- dgfhdfg [~hgfdfgh@77.243.31.157] has joined #bitcoin-core-dev 05:00 -!- Kim2 [~Kim@178.162.204.238] has quit [] 05:04 -!- davidfischer [~davidfisc@89.249.74.218] has joined #bitcoin-core-dev 05:05 -!- davidfischer is now known as Guest84170 05:05 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:11 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465 05:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:18 -!- promag [~promag@31.22.202.43] has quit [Remote host closed the connection] 05:21 -!- jonatack [6dca6b93@109.202.107.147] has joined #bitcoin-core-dev 05:22 -!- promag [~promag@31.22.202.43] has joined #bitcoin-core-dev 05:23 -!- jonatack [6dca6b93@109.202.107.147] has quit [Remote host closed the connection] 05:26 -!- dgfhdfg [~hgfdfgh@77.243.31.157] has quit [Quit: Leaving] 05:27 -!- promag [~promag@31.22.202.43] has quit [Remote host closed the connection] 05:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 05:32 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 05:32 < jnewbery> provoostenator: contributors' accounts have been flagged in the past because it looks like they're using travis for mining. An email to support usually gets in unblocked pretty quickly. 05:33 -!- rex4539 [~rex4539@2a02:587:3514:c700:703b:92ad:399f:1b00] has quit [Quit: rex4539] 05:34 < MarcoFalke> provoostenator: Going to send them an email. I do this every couple of weeks, and I have an email template 05:34 < MarcoFalke> God I can't wait to get rid of travis 05:34 < provoostenator> Thanks, I sent them an email earlier today. 05:37 -!- promag [~promag@31.22.202.43] has joined #bitcoin-core-dev 05:38 < jnewbery> kallewoof: thanks. Will look at it this morning. I think behaviour is basically unchanged, except for log spam. 05:39 < MarcoFalke> I guess it makes sense to revert the "Remove redundant checks" commit 05:39 -!- promag [~promag@31.22.202.43] has quit [Remote host closed the connection] 05:41 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection] 05:41 < MarcoFalke> Assuming a wallet with 100k txs, this will fill up the debug log in no time 05:41 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 05:43 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 05:54 -!- promag [~promag@31.22.202.43] has joined #bitcoin-core-dev 05:54 -!- promag [~promag@31.22.202.43] has quit [Remote host closed the connection] 06:29 < jonasschnelli> OSX sigs for 0.18.1 are ready to review and merge: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/28 06:36 < jonasschnelli> [merged] 06:36 < jonasschnelli> !start your gitian builders! 06:36 < gribble> Error: "start" is not a valid command. 06:36 < fanquake> 🚀 06:51 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 06:53 < jonasschnelli> fanquake: wait... it's not merged. :) 06:53 * jonasschnelli stops his gitian build 06:53 < jonasschnelli> https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/28 still open 06:53 < jonasschnelli> (confused it with my gitian sigs) 07:00 < fanquake> jonasschnelli: yea I only merged your sigs. Cory can check the detached. 07:00 < jonasschnelli> sure... thanks 07:30 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 07:33 < gleb> fanquake: btw thanks for pointing me to the PRs I looked at at some point but never ended up reviewing :) 07:35 < fanquake> gleb: no worries 👍 07:35 < fanquake> Thanks for following up 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:42 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #16562: Refactor message transport packaging (master...2019/06/net_refactor_2) https://github.com/bitcoin/bitcoin/pull/16562 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:45 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Quit: Leaving] 07:47 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:48 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:52 * provoostenator aborts gitian build 07:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:53 < provoostenator> Optech newsletter jumped the gun on "Upgrade to Bitcoin Core 0.18.1" 07:54 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:54 < jnewbery> oops. We'll tweet a correction and update the newsletter on our site. 07:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:57 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 08:00 -!- Guest84170 [~davidfisc@89.249.74.218] has quit [] 08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:07 < bitcoin-git> [bitcoin] mzumsande opened pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563 08:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:15 -!- glidenote1 [~glidenote@178.162.204.238] has joined #bitcoin-core-dev 08:18 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 08:30 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:38 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:39 < bitcoin-git> [bitcoin] candrews opened pull request #16564: Always define the raii_event_tests test suite (0.18...patch-1) https://github.com/bitcoin/bitcoin/pull/16564 08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:41 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds] 08:49 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer] 09:23 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 09:25 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds] 09:27 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 09:30 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds] 09:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:34 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:35 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:36 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 09:50 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 09:56 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 09:56 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 09:57 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:59 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:02 -!- ThomasLuong [~ThomasLuo@73.96.107.155] has joined #bitcoin-core-dev 10:07 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:10 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 10:12 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 244 seconds] 10:15 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:30 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 244 seconds] 10:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:31 -!- Emzy is now known as emzy 10:36 < dongcarl> For addrv2, it seems that version messages are also affected... Not sure what the best way to resolve is. If we keep as is, then what do Torv3 senders/receivers set as their `addr_{from,recv}`? If we change to new serialization, old nodes will be confused. It seems that we need a versionv2 as well, that's upgraded to by first sending a versionv1? (kind of messy) 10:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 10:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:55 -!- PaulTroon is now known as remyers 10:55 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev 10:56 -!- remyers [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has left #bitcoin-core-dev [] 10:56 -!- remyers [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:57 -!- remyers [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [] 10:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:00 -!- glidenote1 [~glidenote@178.162.204.238] has quit [] 11:02 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:07 < jonasschnelli> dongcarl: good point. Maybe wumpus have made some thoughts already on this. Probably something for the thursday meeting. 11:07 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 11:08 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 11:08 < dongcarl> jonasschnelli: Sounds good, I'll bring it up 11:08 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 11:12 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 244 seconds] 11:13 -!- kreative [~kreative@185.5.172.148] has joined #bitcoin-core-dev 11:15 < jonasschnelli> requesting Cory review on https://github.com/bitcoin/bitcoin/pull/16562 (especially a comment on the joining of header&payload as single buffer in vSendMsg) 11:18 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 11:20 -!- roconnor [~roconnor@host-45-58-228-96.dyn.295.ca] has joined #bitcoin-core-dev 11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 11:27 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 11:29 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:32 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:35 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 11:37 < fanquake> achow101 is currently live streaming some wallet dev: https://www.twitch.tv/achow101/ 11:43 < jonasschnelli> nice! 11:57 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 11:58 -!- jarthur [~jarthur@207.114.244.5] has quit [] 12:04 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 12:14 < wumpus> dongcarl: I don't think the address in the version message is of any relevance to tor, or other protocols where there's no known 'from' address 12:16 < dongcarl> wumpus: what about `addr_recv `? 12:16 * dongcarl is complete aware that he might be misunderstanding this whole situation 12:16 < dongcarl> completely* 12:17 < sipa> i think we rely on the addr in the version message to tell a peer through which address we're connecting to them 12:17 < sipa> to figure out which incoming addresses work 12:17 < sipa> which would still exist with TorV3? 12:18 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [] 12:20 < wumpus> sipa: oh, you're right 12:20 < dongcarl> Oh, I'm only vaguely aware that this piece of logic exists... Is there documentation or code I can read? 12:21 < sipa> i'm not sure it's particularly useful 12:22 < wumpus> dongcarl: maybe this could be part of the https://github.com/bitcoin/bips/pull/766#issuecomment-517003833 sendaddrv2 message here to notify peers of addrv2 support (which was poroposed as alternative to the protocol version bump the BIP currently documents) 12:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:23 < wumpus> dongcarl: I think the handling of the VERSION message is the only 'documentation' for this 12:23 < sipa> a sendaddrv2 message would go after a version message though 12:23 * dongcarl thinking 12:23 < sipa> so maybe the proposal should be to send a specific dummy address in the version message when v2 is in use 12:23 < wumpus> sipa: yes, so it can extend the version in the version message 12:23 < sipa> and send the actual one inside the sendaddrv2 12:23 < wumpus> yes, that 12:23 < dongcarl> sipa: Yeah that's what I'm thinking 12:24 < wumpus> I don't want to change the version message itself for this 12:24 < wumpus> that's even worse than changing the protocol version :-) 12:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 12:25 < dongcarl> wumpus: I'm not 100% sure why we need sendaddrv2 though, why doesn't the protocl VERSION bump work? 12:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:25 < sipa> dongcarl: because protocol version bumps require monotonically increasing features 12:25 < wumpus> dongcarl: please read the discussion in that PR 12:25 < wumpus> dongcarl: (esp marcofalke's point) 12:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 12:28 -!- ThomasLuong [~ThomasLuo@73.96.107.155] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:30 < dongcarl> wumpus: When I talked to MarcoFalke in person, he said it doesn't matter that much... But I can see the point for feature-monotonic protocol versions 12:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 12:31 < dongcarl> A little uncomfortable about adding another protocol message though... 12:32 < wumpus> if we need an extended-version message anyway, then this could have the two purposes at once 12:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:32 * dongcarl thinking 12:32 < wumpus> what's wrong with adidng another message? 12:33 < wumpus> at least unknown messages are simply ignored, so they're pretty much free 12:34 < dongcarl> wumpus: true... perhaps a naive thought but I was thinking maybe there needs to be a generic feature-signaling message for non-monotonic features that don't fit in the protocol version model. 12:34 < wumpus> yes, it's unfortunate that that doesn't exist, but let's please not include that in the scope of this 12:35 < dongcarl> wumpus: Of course not. Could you elaborate a little on how sendaddrv2 would serve dual purpose? I think I'm close to getting it but not quite 12:36 < wumpus> so it would a) signal that the peer sending it can accept addrv2 messages, and b) can contain the wide address that was connected to (e.g. extend what was sent in the version message before it) 12:36 -!- MasterdonX [~masterdon@185.193.36.226] has quit [Ping timeout: 245 seconds] 12:37 < dongcarl> wumpus: And this would be sent by the connection initiator immediately after its `version` message, right? 12:38 < wumpus> after the version handshake completes 12:38 < wumpus> it's the same as sendheaders 12:39 < dongcarl> wumpus: Okay, and there needs to be a stub netaddr in the version handshake if it's a wide address then? 12:40 < wumpus> yes 12:40 < sipa> yes, because you don't know whether the peer supports v2 yet by that point 12:41 < wumpus> FWIW a lot of alterntative implementations always put localhost in the version message, so that's probably a good dummy 12:41 -!- Victor_sueca is now known as Victorsueca 12:41 < dongcarl> wumpus: I was gunna use the SetInternal format on the "addrv2" string 12:42 < wumpus> dongcarl: what do you mean? 12:42 < wumpus> which addrv2 string? what setinternal format? 12:43 < dongcarl> wumpus: you know the special address format we use to encode seed hostnames so that addrman knows where addresses came from? 12:43 < wumpus> that will probably confuse other peers 12:43 < wumpus> e.g. localhost is well known as a 'ignore' value 12:43 < wumpus> that isn't 12:43 < dongcarl> wumpus: roger that 12:44 < sipa> agree 12:44 < dongcarl> easier for non-Core implementers too... 12:45 < wumpus> right, I think so too 12:45 -!- dgfhdfg [~hgfdfgh@77.243.31.157] has joined #bitcoin-core-dev 12:45 < dongcarl> Okay, I'll try making a PR to the BIP repo, thanks wumpus and sipa for being patient with me 12:45 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 12:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 12:46 < wumpus> dongcarl: we should do that, though, we might want to wait with that until we're further along with the implementation, there seem to be many thing no one had realized (like the addresses in the version) until someone tried implementing it :) 12:47 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:48 < dongcarl> wumpus: You're right, this entire experience has taught me how important implementation is to spec iteration 12:48 < dongcarl> I'll continue the implementation then, and we'll reconvene when I have something more testable 12:48 < wumpus> same for me 12:49 -!- pinheadmz [~matthewzi@172.255.125.150] has joined #bitcoin-core-dev 12:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 12:51 < wumpus> I think the PR comments on https://github.com/bitcoin/bips/pull/766 is an ok place to keep track of things we want to change to the BIP until that 12:52 < dongcarl> wumpus: One more thing... What will happen in the future if torv42 has 512-bit addresses or something? 12:52 < wumpus> I don't follow the mailing list much 12:52 < wumpus> dongcarl: this scheme is extensible 12:53 < wumpus> it's possible to add new address types to it in another BIP 12:53 < wumpus> old implementations ignore those 12:53 < dongcarl> wumpus: I see, so we'd bump the max size in another BIP 12:54 < dongcarl> wumpus: and the old client would ignore b/c of the max 32-byte restriction in the spec 12:54 < sipa> there isn't a max size, right? 12:54 < wumpus> "Field addr has a variable length, with a maximum of 32 bytes (256 bits). Clients SHOULD reject 12:54 < wumpus> longer addresses. 12:54 < sipa> ah 12:55 < wumpus> I've added a maximum, might want to bump that if we realistically expect protocols with even larger addresses 12:55 < wumpus> or even remove it 12:55 < sipa> this could be an implementation aspect "Implementations MAY ignore address messages of an unknown type, or otherwise impose limits on the maximum size of addr messages for unknown types they relay. 12:55 < wumpus> though, might want to keep some bound for deserialization DoS reasons? 12:55 < sipa> yeah 12:56 < dongcarl> should... implementations relay unknown types?? 12:57 < wumpus> "Client MAY store and gossip address formats that they do not know about. Further network ID numbers MUST be reserved in a new BIP document." 12:57 < wumpus> they may 12:57 < wumpus> it's not necessary, imo 12:58 < dongcarl> wumpus: yeah, so this way there's no hard cap, but realistically there's a cap based on the max size corresponding to defined network IDs 12:58 < sipa> probably best to recommand not to relay/store unknown types, at which point there is an implied max size anyway 12:58 < sipa> for bandwidth DoS you could have a max size, but it can be fairly large 12:59 < wumpus> the thing is you want to ignore individual unknown addresses even if they're larger than the cap, but not declare the entire addrv2 message they're in invalid 12:59 < wumpus> right 13:01 < sipa> like the limit could be 512 bytes or whatever; it's just so that you can instaban anyone who sends excessive things 13:01 < wumpus> ok, so if an addrv2 message contains any item larger than that, the entire message is invalid 13:01 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:05 < wumpus> https://github.com/bitcoin/bips/pull/766#issuecomment-519248699 13:06 < dongcarl> just to confirm, we still recommend to ignore individually for addresses that are in between MAX_KNOWN_NETWORK_ID_ADDR_LEN and 512 bytes, correct? 13:07 < wumpus> yes 13:07 < dongcarl> sorry, more accurately, for addresses that have unknown networkID and are below 512 bytes 13:08 < wumpus> they are independent rules a) addresses of unknown type should be ignored, individually, independent of their size b) if the message contains anything larger than 512 bytes the whole message is invalid and anything in it is ignored 13:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds] 13:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 13:10 -!- reallll is now known as belcher 13:16 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:18 < dongcarl> wumpus: address of unknown type + 513 bytes addr field -> invalidate entire message (rule b), addr of unknown type + 512 bytes addr field -> ignore individually (rule a) 13:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 13:23 < wumpus> dongcarl: yes 13:24 < wumpus> addr of known type + wrong-sized addr field -> also ignore individually, I think 13:30 < dongcarl> wumpus: true 13:32 -!- pinheadmz [~matthewzi@172.255.125.150] has quit [Quit: pinheadmz] 13:42 -!- ThomasLuong [~ThomasLuo@73.96.104.126] has joined #bitcoin-core-dev 13:46 -!- ercwl [~ercwl@94.234.47.33] has joined #bitcoin-core-dev 13:50 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:57 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 14:00 -!- kreative [~kreative@185.5.172.148] has quit [] 14:04 -!- seefischer [~seefische@185.204.1.185] has joined #bitcoin-core-dev 14:05 -!- MasterdonX [~masterdon@5.226.137.122] has joined #bitcoin-core-dev 14:05 -!- diverger [~div@89.238.130.200] has joined #bitcoin-core-dev 14:07 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 14:07 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 14:08 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Ping timeout: 268 seconds] 14:10 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 14:11 -!- pinheadmz [~matthewzi@208.69.41.101] has joined #bitcoin-core-dev 14:12 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 244 seconds] 14:14 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Ping timeout: 246 seconds] 14:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 14:27 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 14:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:44 -!- simerax [~quassel@91.132.138.220] has joined #bitcoin-core-dev 14:44 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Ping timeout: 245 seconds] 14:45 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:55 -!- booyah_ [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 15:07 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:07 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:08 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] 15:14 -!- ercwl [~ercwl@94.234.47.33] has quit [Quit: ercwl] 15:16 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds] 15:19 -!- dviola [~diego@189.7.68.220] has joined #bitcoin-core-dev 15:20 -!- dviola [~diego@189.7.68.220] has quit [Client Quit] 15:23 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev 15:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 15:27 -!- booyah_ [~bb@193.25.1.157] has quit [Remote host closed the connection] 15:29 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand] 15:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 15:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:47 -!- mdunnio [~mdunnio@38.126.31.226] has quit [] 15:55 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:56 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 15:56 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:06 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bsihzsmbdqhsuctf] has quit [Quit: Connection closed for inactivity] 16:12 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 16:17 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 258 seconds] 16:17 -!- dgfhdfg [~hgfdfgh@77.243.31.157] has quit [Read error: Connection reset by peer] 16:18 -!- dgfhdfg [~hgfdfgh@77.243.24.172] has joined #bitcoin-core-dev 16:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:28 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 16:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 244 seconds] 16:42 -!- dgfhdfg [~hgfdfgh@77.243.24.172] has quit [Quit: Leaving] 16:45 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 245 seconds] 16:53 -!- ThomasLuong [~ThomasLuo@73.96.104.126] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:00 -!- seefischer [~seefische@185.204.1.185] has quit [] 17:04 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 17:04 -!- Iam_thor [~Iam_thor@192.145.126.244] has joined #bitcoin-core-dev 17:08 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds] 17:13 -!- pinheadmz [~matthewzi@208.69.41.101] has quit [Quit: pinheadmz] 17:19 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 17:21 -!- simerax_ [~quassel@91.132.138.220] has joined #bitcoin-core-dev 17:21 -!- simerax [~quassel@91.132.138.220] has quit [Ping timeout: 272 seconds] 17:24 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 17:29 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 17:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:34 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds] 17:43 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 17:45 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 17:46 -!- lightlike [~lightlike@2001:16b8:5797:1d00:a4ab:d863:44bc:ec79] has quit [Quit: Leaving] 17:47 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test] 17:47 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:50 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 246 seconds] 18:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:04 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:05 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 18:07 -!- Bullitje [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 18:14 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 18:37 -!- marcinja_ [~marcin@c-24-61-229-30.hsd1.ma.comcast.net] has quit [Ping timeout: 248 seconds] 18:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 18:40 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Ping timeout: 245 seconds] 18:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 19:06 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has quit [Ping timeout: 260 seconds] 19:07 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 19:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 19:12 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 19:13 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 19:14 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 19:31 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 19:31 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 248 seconds] 19:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:37 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 19:37 < cfields> gitian builders: detached sigs for v0.18.1 are up. 19:37 < fanquake> 🎉 19:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:39 < bitcoin-git> [bitcoin] kallewoof opened pull request #16566: util: refactor upper/lowercase functions (master...2019-08-casefuns-refactor) https://github.com/bitcoin/bitcoin/pull/16566 19:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 19:47 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 19:48 < fanquake> Pushed up some signed sigs: https://github.com/bitcoin-core/gitian.sigs/pull/1065 19:49 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 19:51 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 272 seconds] 19:52 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 19:57 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Ping timeout: 268 seconds] 19:59 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 20:00 -!- Iam_thor [~Iam_thor@192.145.126.244] has quit [] 20:00 < ariard> cfields: hey if you are around and have time, could you have a look on https://github.com/bitcoin/bitcoin/pull/16503 :) ? People are uncertain on it 20:01 -!- kcalvina_ [~calvin@104.238.63.100] has joined #bitcoin-core-dev 20:04 -!- ukboi [~ukboi@141.98.102.243] has joined #bitcoin-core-dev 20:05 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 272 seconds] 20:19 -!- simerax_ [~quassel@91.132.138.220] has quit [Remote host closed the connection] 20:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:27 -!- kcalvina_ [~calvin@104.238.63.100] has quit [Remote host closed the connection] 20:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:31 -!- davterra [~none@209.58.185.33] has quit [Quit: Leaving] 20:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:33 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 20:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:40 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 20:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 20:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:46 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 20:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:06 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 21:07 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 21:16 < fanquake> promag: I've put together a AppleScript that spams wallet loads and unloads in the GUI: https://github.com/bitcoin/bitcoin/issues/16307#issuecomment-519355809 21:16 < fanquake> You might be able to use that to recreate the issue. 21:43 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has quit [Ping timeout: 260 seconds] 21:45 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 21:47 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 21:52 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds] 21:52 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 21:55 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 22:25 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 248 seconds] 22:44 -!- alko [~alko@BSN-77-147-172.static.siol.net] has quit [Quit: Konversation terminated!] 22:52 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 22:54 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 22:56 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 22:57 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 22:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 22:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 258 seconds] 22:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 23:00 -!- ukboi [~ukboi@141.98.102.243] has quit [] 23:04 -!- Kampala [~Kampala@89.249.74.218] has joined #bitcoin-core-dev 23:12 -!- kcalvinalvin [~calvin@104.238.63.100] has joined #bitcoin-core-dev 23:14 -!- kcalvina_ [~calvin@118.131.103.244] has joined #bitcoin-core-dev 23:14 -!- kcalvina_ [~calvin@118.131.103.244] has quit [Client Quit] 23:15 -!- somerandomperson [0ecb8862@14-203-136-98.tpgi.com.au] has joined #bitcoin-core-dev 23:15 -!- somerandomperson [0ecb8862@14-203-136-98.tpgi.com.au] has quit [Remote host closed the connection] 23:18 -!- kcalvinalvin [~calvin@104.238.63.100] has quit [Ping timeout: 268 seconds] 23:24 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 23:32 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:34 -!- kcalvinalvin [~calvin@118.131.103.244] has joined #bitcoin-core-dev 23:36 -!- ilyas67 [0ecb8862@14-203-136-98.tpgi.com.au] has joined #bitcoin-core-dev 23:44 -!- ilyas67 [0ecb8862@14-203-136-98.tpgi.com.au] has quit [Remote host closed the connection] 23:45 -!- kcalvinalvin [~calvin@118.131.103.244] has quit [Remote host closed the connection] 23:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 23:50 -!- kcalvinalvin [~calvin@118.131.103.244] has joined #bitcoin-core-dev 23:54 < jonasschnelli> promag: Re #16562: do you mean reallocation because of the vector::insert at the beginning? Yeah. I need to look for a better way. 23:54 < gribble> https://github.com/bitcoin/bitcoin/issues/16562 | Refactor message transport packaging by jonasschnelli · Pull Request #16562 · bitcoin/bitcoin · GitHub 23:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 23:55 < jonasschnelli> heh 23:58 -!- ilyasrid1uan [~ilyasridh@14-203-136-98.tpgi.com.au] has joined #bitcoin-core-dev --- Log closed Thu Aug 08 00:00:33 2019