--- Log opened Fri Aug 23 00:00:50 2019 00:07 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has joined #bitcoin-core-dev 00:08 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 00:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 00:14 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has joined #bitcoin-core-dev 00:34 -!- lalit [~lalitmee@14.98.11.206] has quit [Ping timeout: 258 seconds] 00:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:46 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 00:46 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds] 00:47 < warren> https://twitter.com/wtogami/status/1164805975615795202 <--- libfaketime 0.9.8 release is soon. I found it has regressions when tested against older userspace, maybe glibc. I don't know if this affects gitian but it really should be tested there. 00:49 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 00:50 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 00:59 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 01:20 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 01:24 -!- lalit [~lalitmee@14.98.11.206] has joined #bitcoin-core-dev 01:28 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 01:28 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:56 -!- rex4539 [~rex4539@2a02:587:3514:c700:442d:d4e7:daa9:f2fd] has quit [Remote host closed the connection] 01:58 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:58 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 02:00 -!- indolering [~indolerin@195.140.215.184] has quit [] 02:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:14 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43eaf76e0267...d72758c3f6c3 02:14 < bitcoin-git> bitcoin/master bca388d fanquake: gui: remove unused PlatformStyle::TextColorIcon 02:14 < bitcoin-git> bitcoin/master d72758c Jonas Schnelli: Merge #16677: gui: remove unused PlatformStyle::TextColorIcon 02:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:14 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #16677: gui: remove unused PlatformStyle::TextColorIcon (master...remove_unused_text_coloricon) https://github.com/bitcoin/bitcoin/pull/16677 02:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:16 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 02:16 -!- vosechu [~vosechu@195.206.169.238] has joined #bitcoin-core-dev 02:17 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 02:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 02:26 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 02:26 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:04 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 03:12 -!- lalit is now known as lalitmee 03:20 < fanquake> warren: I've compiled and run the tests on macOS. Looks like that got an autotools PR in progress. Might check that out later. 03:24 < warren> fanquake: he's brute force "fixing" problems by adding lots of ifdefs, I'm not sure if those fixes are actually fixes. Now I'm told to edit the Makefile to workaround a failure on older glibc. 03:25 < warren> I don't understand a lot of the more recent changes myself so I can't analyze 03:34 -!- lalitmee [~lalitmee@14.98.11.206] has quit [Quit: Leaving] 03:35 -!- lalitmee [~lalitmee@49.204.86.234] has joined #bitcoin-core-dev 03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:41 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d72758c3f6c3...442a9c647754 03:41 < bitcoin-git> bitcoin/master be27161 Russell Yanofsky: Clarify need to specify --prefix with depends 03:41 < bitcoin-git> bitcoin/master 2483266 Russell Yanofsky: packages.md: document depends build targets 03:41 < bitcoin-git> bitcoin/master 442a9c6 fanquake: Merge #16691: doc: improve depends prefix documentation 03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:43 < bitcoin-git> [bitcoin] fanquake merged pull request #16691: doc: improve depends prefix documentation (master...depends_improve_prefix_docs) https://github.com/bitcoin/bitcoin/pull/16691 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:46 < fanquake> jonatack: yea if you're doing more depends/docs stuff you can pick that nit up 馃憤 03:48 < jonatack> fanquake: 馃憤 03:49 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds] 03:49 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:25 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 04:33 -!- PWChenD [~Adium@165.22.103.250] has joined #bitcoin-core-dev 04:34 -!- PWChenD [~Adium@165.22.103.250] has left #bitcoin-core-dev [] 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:42 < bitcoin-git> [bitcoin] fanquake opened pull request #16694: gui: Ensure transaction send error is always visible (master...rebased_squashed_14956) https://github.com/bitcoin/bitcoin/pull/16694 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:42 < bitcoin-git> [bitcoin] fanquake closed pull request #14956: [qt] Ensure tx send error highlight is visible (master...show-highlighted-field) https://github.com/bitcoin/bitcoin/pull/14956 04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:49 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:49 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 244 seconds] 04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 04:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:00 -!- vosechu [~vosechu@195.206.169.238] has quit [] 05:12 -!- zivl [~zivl@unaffiliated/zivl] has quit [Quit: zivl] 05:27 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 05:28 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 05:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 05:36 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds] 05:49 -!- kephra [~kephra@139.28.218.198] has joined #bitcoin-core-dev 05:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 05:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 05:58 < fanquake> jonatack: Let me know if that issue persists. I'm seeing scrolling to the invalid recipient, regardless of it's position or if the address or amount is invalid. 05:59 -!- oriondeimos [a2fe84d7@162.254.132.215] has joined #bitcoin-core-dev 06:01 -!- oriondeimos [a2fe84d7@162.254.132.215] has quit [Remote host closed the connection] 06:03 -!- lalitmee [~lalitmee@49.204.86.234] has quit [Remote host closed the connection] 06:06 < jonatack> fanquake: Yep, tested PR/master/PR on testnet with Debian, not scrolling into sight... btw the gui looks much nicer in your video then it does irl for me ;D 06:08 < fanquake> jonatack: eh, if it doesn't work for everyone I'll just close and we can move onto other things. 06:09 < fanquake> Definitely don't want to waste time with PRs like that. 06:11 < jonatack> fanquake: Right. Maybe see if someone else on Debian confirms. 06:23 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:38 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Excess Flood] 06:56 < Kvaciral> 7777777777777777777777777777777777777777777777777777777777777784pls0ntQ42 06:56 -!- captjakk [~captjakk@107.145.175.198] has joined #bitcoin-core-dev 07:02 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 07:02 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 07:07 < ariard> provoostenator: I don't get your comment, how 16561 is failing travis 5 and 8 on unit tests ? 07:17 < hebasto> jonatack: what Debian version do you test on? 07:28 -!- Highway61 [~Thunderbi@96.44.145.154] has quit [Ping timeout: 272 seconds] 07:35 < jonatack> hebasto: I'm running a PureOS variant of Debian. uname -a gives Linux 4.19.0-5-amd64 #1 SMP Debian 4.19.37-5 (2019-06-19) x86_64 GNU/Linux 07:36 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) 路 Issue #1 路 bitcoin/bitcoin 路 GitHub 07:36 < jonatack> hebasto: Qt 5.11.3 according to the GUI Help tab -> About Qt 07:43 < achow101> anyone else seeing "Warning: unknown new rules activated (versionbit 1)" in getblockchaininfo? Were we just that unlucky with asicboost miners or did burying bip9 deployments accidentally cause this? 07:43 -!- pinheadmz [~matthewzi@198.8.81.211] has joined #bitcoin-core-dev 07:44 < achow101> using a build of master from a few days ago 07:47 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-vohqmufybdifcwge] has quit [] 07:47 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has joined #bitcoin-core-dev 07:56 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has quit [Changing host] 07:56 -!- schmidty_ [sid297174@unaffiliated/schmidty] has joined #bitcoin-core-dev 07:56 -!- schmidty_ [sid297174@unaffiliated/schmidty] has quit [Changing host] 07:56 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has joined #bitcoin-core-dev 07:56 -!- schmidty_ is now known as schmidty 07:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 08:00 -!- kephra [~kephra@139.28.218.198] has quit [] 08:00 < jonatack> achow101: yes i'm seeing it as well on recent master 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:01 < bitcoin-git> [bitcoin] leto opened pull request #16695: Add window final block height to getchaintxstats (master...getchaintxstats_height) https://github.com/bitcoin/bitcoin/pull/16695 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- Highway61 [~Thunderbi@96.44.145.154] has joined #bitcoin-core-dev 08:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 08:17 -!- lahwran [~lahwran@195.140.215.184] has joined #bitcoin-core-dev 08:22 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:23 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has quit [Read error: Connection reset by peer] 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:25 < bitcoin-git> [bitcoin] shargon opened pull request #16696: [validation] static_assert to ensure width in unit class (master...fix-uintbase) https://github.com/bitcoin/bitcoin/pull/16696 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:25 < bitcoin-git> [bitcoin] shargon closed pull request #16679: [validation] static_assert to ensure width in unit class (master...fix-unit-base) https://github.com/bitcoin/bitcoin/pull/16679 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:25 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in] 08:26 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has joined #bitcoin-core-dev 08:27 -!- captjakk [~captjakk@107.145.175.198] has quit [Remote host closed the connection] 08:27 -!- captjakk [~captjakk@107.145.175.198] has joined #bitcoin-core-dev 08:28 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev 08:31 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has quit [Client Quit] 08:31 -!- captjakk [~captjakk@107.145.175.198] has quit [Ping timeout: 245 seconds] 08:35 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:49 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 09:05 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer] 09:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:12 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:13 -!- kljasdfvv [~flack@p200300D46F0E78000823D19FB3A27D40.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:34 -!- PWChenD [~PWChenD@165.22.103.250] has joined #bitcoin-core-dev 09:37 -!- PWChenD [~PWChenD@165.22.103.250] has quit [] 09:38 -!- PWChenD [~PWChenD@165.22.103.250] has joined #bitcoin-core-dev 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #16698: [WIP] Mempool: rework rebroadcast logic to improve privacy (master...rebroadcast) https://github.com/bitcoin/bitcoin/pull/16698 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:50 -!- PWChenD [~PWChenD@165.22.103.250] has left #bitcoin-core-dev [] 09:50 -!- PWChenD [~PWChenD@165.22.103.250] has joined #bitcoin-core-dev 09:50 -!- PWChenD [~PWChenD@165.22.103.250] has left #bitcoin-core-dev [] 09:50 -!- PWChenD [~PWChenD@165.22.103.250] has joined #bitcoin-core-dev 09:59 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 10:00 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 10:03 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 10:04 -!- owowo [~ovovo@179.43.152.50] has joined #bitcoin-core-dev 10:04 -!- owowo [~ovovo@179.43.152.50] has quit [Changing host] 10:04 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:12 -!- PWChenD [~PWChenD@165.22.103.250] has quit [] 10:22 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev 10:32 -!- xzytrewq [~quassel@184.170.247.164] has quit [Ping timeout: 268 seconds] 10:33 -!- xzytrewq [~quassel@184.170.247.164] has joined #bitcoin-core-dev 10:39 -!- m1rror [~m1rror@unaffiliated/m1rror] has quit [Quit: The Lounge - https://thelounge.chat] 10:40 -!- m1rror [~m1rror@unaffiliated/m1rror] has joined #bitcoin-core-dev 10:45 -!- PWChenD [~textual@112.10.75.65] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz鈥 10:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-syqpnvnyavzdefpc] has joined #bitcoin-core-dev 11:00 -!- lahwran [~lahwran@195.140.215.184] has quit [] 11:17 -!- SRV_DW20 [~SRV_DW20@185.59.221.95] has joined #bitcoin-core-dev 11:27 -!- iamtimmarchant [~iamtimmar@2600:380:672b:6f0d:b157:edbb:652b:9835] has joined #bitcoin-core-dev 11:34 -!- iamtimmarchant [~iamtimmar@2600:380:672b:6f0d:b157:edbb:652b:9835] has quit [Ping timeout: 264 seconds] 11:42 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has joined #bitcoin-core-dev 11:42 < bitcoin-git> [bitcoin] hebasto opened pull request #16701: qt: Replace functions deprecated in Qt 5.13 (partly) (master...20190823-qt13-deprecated) https://github.com/bitcoin/bitcoin/pull/16701 11:42 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has left #bitcoin-core-dev [] 11:47 -!- lalitmee [~lalitmee@36.255.86.115] has joined #bitcoin-core-dev 11:48 -!- lalitmee [~lalitmee@36.255.86.115] has quit [Max SendQ exceeded] 11:49 -!- lalitmee [~lalitmee@36.255.86.115] has joined #bitcoin-core-dev 11:55 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection] 12:09 < jnewbery> achow101: almost certainly due to burying bip9 deployments 12:09 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 12:10 < provoostenator> ariard: https://travis-ci.org/bitcoin/bitcoin/builds/575909990?utm_source=github_status&utm_medium=notification 12:11 < provoostenator> If you look at those logs it says "No output has been received in the last 10m0s" right before the functional test suite is supposed to run. 12:11 < provoostenator> That's a bug that was fixed in #15561, so the problem should go away after you rebase. 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/15561 | GitHub 路 Where software is built 12:11 < provoostenator> Though MarcoFalke says not 12:12 < instagibbs> "This issue has been deleted." that's... annoying feature 12:13 < achow101> jnewbery: yes, see #16697 12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/16697 | Unknown version bit fork activated warning 路 Issue #16697 路 bitcoin/bitcoin 路 GitHub 12:14 -!- pinheadmz [~matthewzi@198.8.81.211] has quit [Quit: pinheadmz] 12:16 < provoostenator> achow101 great catch! 12:18 < provoostenator> instagibbs ariard: sorry, typo, I meant #16561 12:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16561 | tests: Use colors and dots in test_runner.py output only if standard output is a terminal by practicalswift 路 Pull Request #16561 路 bitcoin/bitcoin 路 GitHub 12:19 < jnewbery> I'd suggest we remove the "unknown new rules activated" warning entirely. It seems of dubious benefit. 12:20 < provoostenator> jnewbery: it seems useful after a softfork, becuase e.g. you might have something in your mempool that other nodes will never confirm 12:21 < provoostenator> I suppose not actually, because of the standardness rules. 12:21 < provoostenator> Still seems reasonable to warn people about softforks they don't know about. 12:22 < jnewbery> we also warn on every block that 40-50 of the last 100 blocks were of unexpected version 12:23 < provoostenator> I thought we killed those? 12:23 < harding> provoostenator: those are still in the logs, but no longer the GUI. 12:23 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Quit: WeeChat 2.4] 12:23 < provoostenator> Only keeping actual activation 12:23 < jnewbery> A warning in the software that tries to tell you about an event that didn't exist when the software was written isn't very robust. We don't even know if there will be another BIP 9 activation. 12:24 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 12:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:24 < bitcoin-git> [bitcoin] naumenkogs opened pull request #16702: p2p: supplying and using asmap to improve IP bucketing in addrman (master...asn_buckets) https://github.com/bitcoin/bitcoin/pull/16702 12:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:24 < provoostenator> I would say that even a false positive BIP9 activation message suggests something is going on that the user needs to look into. 12:26 < achow101> I don't think it makes sense to get rid of fork warnings altogether 12:26 < gleb> Could you mark #16702 draft? It certainly has couple questions to address (todos) before merging, although the code is working and I even have tests :) 12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs 路 Pull Request #16702 路 bitcoin/bitcoin 路 GitHub 12:30 < harding> I worry that the warning could be abused. E.g., miners with sufficient hashrate can trigger the warning at any time. If this was combined with, say, a compromise of Bitcoin.org or BitcoinCore.org, they could possibly get a lot of people to "upgrade" to compromised software. 12:37 -!- alko [~alko@BSN-77-147-172.static.siol.net] has quit [Read error: Connection reset by peer] 12:37 -!- alko_ [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev 12:42 < achow101> reading through the warning code, I can't actually figure out how having the deployment parameters prevented the warning from constantly triggering 12:44 -!- davex__ [~user@45.74.60.155] has joined #bitcoin-core-dev 12:47 < jnewbery> achow, yeah it took me a while to figure it out! I think it's this line in the WarningsBitConditionChecker::Condition(): https://github.com/bitcoin/bitcoin/blob/442a9c64775454a7073aff9872721c58b1dd35c5/src/validation.cpp#L1639 12:47 < jnewbery> that prevents it triggering for STARTED or LOCKED_IN versionbits activations 12:48 < achow101> oh, I see now 12:57 -!- ctrlbreak [~ctrlbreak@142.134.84.46] has quit [Read error: Connection reset by peer] 12:58 -!- ctrlbreak [~ctrlbreak@142.134.84.46] has joined #bitcoin-core-dev 13:14 -!- jarthur [~jarthur@207.114.244.5] has quit [] 13:19 -!- zrc [~zrc@66.157-14-84.ripe.coltfrance.com] has joined #bitcoin-core-dev 13:20 -!- zrc [~zrc@66.157-14-84.ripe.coltfrance.com] has quit [Client Quit] 13:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:35 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16703: rpc: Expose GetUTXOStats for testing (master...1908-rpcTestGetUTXOStats) https://github.com/bitcoin/bitcoin/pull/16703 13:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:39 < bitcoin-git> [bitcoin] achow101 opened pull request #16704: Don't warn about activated buried BIP 9 deployments (master...buried-versionbits-cache) https://github.com/bitcoin/bitcoin/pull/16704 13:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:54 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:54 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 13:55 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 248 seconds] 14:00 -!- SRV_DW20 [~SRV_DW20@185.59.221.95] has quit [] 14:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 14:10 -!- fox2p [~fox2p@185.9.18.115] has joined #bitcoin-core-dev 14:14 -!- jamesl22 [~james@185.58.225.100] has quit [Ping timeout: 245 seconds] 14:17 -!- mrd [~mrd@185.204.1.185] has joined #bitcoin-core-dev 14:17 -!- mrd is now known as Guest56340 14:47 -!- davex__ [~user@45.74.60.155] has quit [Ping timeout: 246 seconds] 14:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:58 -!- davex__ [~user@45.74.60.139] has joined #bitcoin-core-dev 14:59 < emilengler> What are the steps to do to add a new file to the compilation process? 15:00 < emilengler> Only add it to Makefile.am and then run a ./configure again? 15:04 < ariard> provoostenator: works now, was a potential deadlock issue well hindered by a boost mishandling of abort in a obscure travis log (see 16700) 15:04 < luke-jr> emilengler: there might be some dumb MSVC stuff now too :x 15:05 < emilengler> luke-jr: That will be funny, not even full C98 support iirc 15:06 < luke-jr> emilengler: C++ is not C 15:07 < emilengler> luke-jr: Sure thing but we use C functions right? 15:08 < sipa> the libsecp256k1 subtree is compiled with a C compiler 15:08 < sipa> but libsecp256k1 is C89 15:08 < sipa> the rest is all compiled with C++ i believe 15:10 < sipa> also, the msvc makefile is autogenerated from Makefile.am i think 15:10 < emilengler> But back to my question, is adding it to Makefile.am enough for a unix compilation? I'm not familiar with autotools 15:10 < sipa> yes 15:11 < sipa> you could figure this out yourself by grepping for an existing source file name 15:11 -!- Highway62 [~Thunderbi@96.44.145.154] has joined #bitcoin-core-dev 15:12 -!- Highway61 [~Thunderbi@96.44.145.154] has quit [Ping timeout: 245 seconds] 15:12 -!- Highway62 is now known as Highway61 15:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 15:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:16 -!- lalitmee [~lalitmee@36.255.86.115] has quit [Remote host closed the connection] 15:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 276 seconds] 15:22 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 15:23 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 15:37 -!- Highway61 [~Thunderbi@96.44.145.154] has quit [Ping timeout: 244 seconds] 15:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:41 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16453: validation: Run CheckBlockIndex only on success for now (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453 15:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:44 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has quit [Ping timeout: 276 seconds] 16:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 17:00 -!- Guest56340 [~mrd@185.204.1.185] has quit [] 17:01 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 17:02 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 17:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:17 -!- lestrrat [~lestrrat@139.28.218.198] has joined #bitcoin-core-dev 17:19 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds] 17:35 -!- xzytrewq [~quassel@184.170.247.164] has quit [Ping timeout: 245 seconds] 17:35 -!- xzytrewq [~quassel@184.170.247.164] has joined #bitcoin-core-dev 17:42 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has joined #bitcoin-core-dev 17:44 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:55 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/442a9c647754...d86a906a8840 17:55 < bitcoin-git> bitcoin/master a4765bd bpay: gui: Ensure tx send error highlight is visible 17:55 < bitcoin-git> bitcoin/master d86a906 fanquake: Merge #16694: gui: Ensure transaction send error is always visible 17:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:56 < bitcoin-git> [bitcoin] fanquake merged pull request #16694: gui: Ensure transaction send error is always visible (master...rebased_squashed_14956) https://github.com/bitcoin/bitcoin/pull/16694 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:30 -!- Giszmo [~leo@2407:7000:9d28:5100:8de1:da9d:15e7:2581] has quit [Quit: Leaving.] 18:33 -!- Giszmo [~leo@143.120.252.27.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 18:38 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 18:39 -!- davterra [~none@209.58.185.33] has quit [Remote host closed the connection] 18:40 -!- echonaut2 [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 18:40 -!- davterra [~none@209.58.185.33] has joined #bitcoin-core-dev 18:47 -!- davex__ [~user@45.74.60.139] has quit [Remote host closed the connection] 18:47 -!- davex__ [~user@45.74.60.139] has joined #bitcoin-core-dev 18:47 -!- Deadhand [~deadhand@kntaon1614w-grc-09-74-15-95-144.dsl.bell.ca] has quit [Ping timeout: 245 seconds] 18:50 -!- Deadhand [~deadhand@kntaon1614w-grc-09-74-15-95-144.dsl.bell.ca] has joined #bitcoin-core-dev 19:05 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:10 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 272 seconds] 19:11 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Ping timeout: 260 seconds] 19:13 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 19:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:39 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d86a906a8840...910ff94cf5c8 19:39 < bitcoin-git> bitcoin/master e7415a5 David A. Harding: Doc: move detached release notes into release-notes.md 19:39 < bitcoin-git> bitcoin/master 7e1634a David A. Harding: Release notes: edit previously-detached notes 19:39 < bitcoin-git> bitcoin/master 74e3876 David A. Harding: Release notes: add previously undocumented changes 19:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:40 < bitcoin-git> [bitcoin] meshcollider merged pull request #16690: Prepare release notes for 0.19 (master...2019-08-0.19-notes) https://github.com/bitcoin/bitcoin/pull/16690 19:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:45 < bitcoin-git> [bitcoin] meshcollider pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/910ff94cf5c8...3ca514ddb772 19:45 < bitcoin-git> bitcoin/master e439388 fanquake: depends: libXau: configure flags cleanup 19:45 < bitcoin-git> bitcoin/master e656d95 fanquake: depends: libxcb: configure flags cleanup 19:45 < bitcoin-git> bitcoin/master 86beb8c fanquake: depends: fontconfig: configure flags cleanup 19:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:46 < bitcoin-git> [bitcoin] meshcollider merged pull request #16370: depends: cleanup package configure flags (master...not_so_great_configure_cleanup) https://github.com/bitcoin/bitcoin/pull/16370 19:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:00 -!- lestrrat [~lestrrat@139.28.218.198] has quit [] 20:03 -!- pinheadmz [~matthewzi@198.8.81.211] has joined #bitcoin-core-dev 20:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 20:17 -!- Haigha [~Haigha@192.145.126.115] has joined #bitcoin-core-dev 20:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 20:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 20:22 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 20:22 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 20:30 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-syqpnvnyavzdefpc] has quit [Quit: Connection closed for inactivity] 20:40 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-joxtcxnuaoqsficw] has joined #bitcoin-core-dev 20:41 -!- pinheadmz [~matthewzi@198.8.81.211] has quit [Quit: pinheadmz] 20:44 -!- pinheadmz [~matthewzi@198.8.81.211] has joined #bitcoin-core-dev 21:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:16 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 21:16 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 248 seconds] 21:45 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 21:57 -!- justanotheruser is now known as jsut 21:57 -!- jsut is now known as justanotheruser 22:09 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev 22:18 -!- pinheadmz [~matthewzi@198.8.81.211] has quit [Quit: pinheadmz] 22:20 -!- pinheadmz [~matthewzi@198.8.81.211] has joined #bitcoin-core-dev 22:21 -!- PWChenD [~textual@112.10.75.65] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz鈥 22:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 22:44 -!- pinheadmz [~matthewzi@198.8.81.211] has quit [Quit: pinheadmz] 22:45 < fanquake> DrahtBot seems to be broken. Spamming conflict comments all over clearly non-conflicting PRs. 23:00 -!- Haigha [~Haigha@192.145.126.115] has quit [] 23:05 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev 23:07 -!- PWChenD [~textual@112.10.75.65] has quit [Client Quit] 23:13 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev 23:17 -!- Raccoon [~Raccoon@184.75.223.235] has joined #bitcoin-core-dev 23:23 -!- PWChenD [~textual@112.10.75.65] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz鈥 23:24 -!- Unnamed-3412 [4cac44d0@cpe-76-172-68-208.socal.res.rr.com] has joined #bitcoin-core-dev 23:26 -!- Unnamed-3412 [4cac44d0@cpe-76-172-68-208.socal.res.rr.com] has left #bitcoin-core-dev [] 23:38 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev 23:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:52 < bitcoin-git> [bitcoin] iamtimmarchant opened pull request #16705: Merge pull request #2 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/16705 23:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:53 < bitcoin-git> [bitcoin] fanquake closed pull request #16705: Merge pull request #2 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/16705 23:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:56 -!- PWChenD [~textual@112.10.75.65] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz鈥 23:56 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 23:57 -!- PWChenD [~textual@112.10.75.65] has joined #bitcoin-core-dev --- Log closed Sat Aug 24 00:00:49 2019