--- Log opened Fri Aug 30 00:00:55 2019 00:15 -!- hhhhhhhhhhh [~awesome-d@183.129.132.171] has quit [Ping timeout: 245 seconds] 00:17 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 00:18 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:22 -!- kcalvinalvin [~calvin@222.108.182.33] has joined #bitcoin-core-dev 00:33 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 00:42 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:51 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:57 -!- ExEric3 [~exeric3@dbox.reneunion.eu] has quit [Ping timeout: 252 seconds] 00:58 -!- ExEric3 [~exeric3@dbox.reneunion.eu] has joined #bitcoin-core-dev 01:30 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 01:31 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 01:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 01:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 01:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 01:48 < fanquake> darosior: I've rebooted those tests for you. 01:48 < darosior> Thank you :) 01:52 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 01:52 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 01:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 01:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 01:55 -!- kcalvinalvin [~calvin@222.108.182.33] has quit [Remote host closed the connection] 01:55 -!- kcalvinalvin [~calvin@222.108.182.33] has joined #bitcoin-core-dev 02:00 -!- devdsp [~devdsp@141.98.102.235] has quit [] 02:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 02:09 -!- promag [~promag@2.80.22.20] has joined #bitcoin-core-dev 02:12 -!- kcalvinalvin [~calvin@222.108.182.33] has quit [Remote host closed the connection] 02:17 -!- donri [~donri@141.98.102.235] has joined #bitcoin-core-dev 02:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 02:33 -!- cryptoIn_ [~cryptoInd@119.63.97.33] has joined #bitcoin-core-dev 02:36 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 258 seconds] 02:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:10 -!- promag [~promag@2.80.22.20] has quit [Read error: Connection reset by peer] 03:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:10 -!- cryptoIn_ [~cryptoInd@119.63.97.33] has quit [Remote host closed the connection] 03:11 -!- cryptoIndio [~cryptoInd@119.63.97.33] has joined #bitcoin-core-dev 03:14 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:15 -!- cryptoIndio [~cryptoInd@119.63.97.33] has quit [Ping timeout: 245 seconds] 03:24 -!- Netsplit *.net <-> *.split quits: Bullitje, lio17, comboy, Karyon, hardforkthis, commavir, a5m0, promag, nanotube, gkrizek, (+8 more, use /NETSPLIT to show all of them) 03:24 -!- Netsplit over, joins: adam3us, comboy 03:24 -!- Netsplit *.net <-> *.split quits: tynes, andytoshi, tryphe, hirish, so, dmkathayat, adiabat, farmerwampum, pinheadmz, spinza, (+11 more, use /NETSPLIT to show all of them) 03:24 -!- Netsplit over, joins: rabidus, asoltys 03:24 -!- slimcognito_ [~slimcogni@2604:a880:400:d1::b92:7001] has joined #bitcoin-core-dev 03:24 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-shqrewrggzzcuczb] has joined #bitcoin-core-dev 03:24 -!- Netsplit over, joins: Bullitje 03:24 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev 03:25 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Excess Flood] 03:25 -!- Netsplit over, joins: promag 03:26 -!- Netsplit over, joins: tryphe 03:26 -!- Netsplit over, joins: lio17 03:26 -!- Netsplit over, joins: sleepych, Evel-Knievel 03:27 -!- Netsplit over, joins: hirish 03:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:27 -!- Lauda [~quassel@95.216.196.120] has joined #bitcoin-core-dev 03:27 -!- Netsplit over, joins: tynes 03:27 -!- Lauda [~quassel@95.216.196.120] has quit [Changing host] 03:27 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 03:27 -!- Netsplit over, joins: shtirlic, dmkathayat, a5m0 03:28 -!- Netsplit over, joins: Karyon 03:28 -!- Netsplit over, joins: fox2p 03:28 -!- Netsplit over, joins: pinheadmz 03:29 -!- Netsplit over, joins: Jaamg, davec 03:29 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 03:29 -!- Netsplit over, joins: nodweber 03:29 -!- Netsplit over, joins: earlz, jcorgan, ppisati 03:29 -!- Netsplit over, joins: commavir 03:29 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev 03:29 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 03:29 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 03:30 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 03:30 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 03:31 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 03:32 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 03:39 -!- farmerwampum [~farmerwam@195.206.105.2] has joined #bitcoin-core-dev 03:40 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 03:48 -!- gelmutshmidt [~gelmutshm@188.113.6.134] has joined #bitcoin-core-dev 03:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 04:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 04:09 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 04:11 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 04:15 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit] 04:18 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev 04:27 -!- jtimon [~quassel@76.85.11.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:31 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: jonatack] 04:44 < meshcollider> Reminder that wallet meeting is this week 04:54 -!- gelmutshmidt [~gelmutshm@188.113.6.134] has quit [Remote host closed the connection] 05:00 -!- donri [~donri@141.98.102.235] has quit [] 05:05 -!- emilengler_ is now known as emilengler 05:10 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode] 05:17 -!- geekosaur [~geekosaur@195.206.169.238] has joined #bitcoin-core-dev 05:17 -!- geekosaur is now known as Guest97834 05:19 -!- TheHoliestRoger is now known as TheresaMay 06:02 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 06:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 06:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 06:25 -!- lightlike [~lightlike@2001:16b8:57bb:5b00:34dd:4f7f:e52b:bb81] has joined #bitcoin-core-dev 06:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 06:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:38 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 06:51 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 260 seconds] 06:54 -!- michaelfolkson [~textual@141.226.28.213] has joined #bitcoin-core-dev 06:58 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 07:12 -!- michaelfolkson [~textual@141.226.28.213] has quit [Quit: Sleep mode] 07:20 -!- michaelfolkson [~textual@141.226.28.213] has joined #bitcoin-core-dev 07:27 -!- michaelfolkson [~textual@141.226.28.213] has quit [Quit: Sleep mode] 07:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 07:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:00 -!- Guest97834 [~geekosaur@195.206.169.238] has quit [] 08:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:04 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 08:26 -!- pinheadmz [~matthewzi@209.58.135.89] has quit [Read error: Connection reset by peer] 08:27 -!- pinheadmz [~matthewzi@185.229.59.31] has joined #bitcoin-core-dev 08:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:32 < bitcoin-git> [bitcoin] GChuf opened pull request #16764: gui: update description for default language (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16764 08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 08:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:45 -!- jbarnette [~jbarnette@139.28.218.198] has joined #bitcoin-core-dev 08:49 -!- Salve [~salve@2001:1948:212:b220:d13:e66c:5ba0:716c] has joined #bitcoin-core-dev 09:04 -!- alko [~alko@BSN-77-147-172.static.siol.net] has joined #bitcoin-core-dev 09:17 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:19 -!- kljasdfvv [~flack@p200300D46F0E7800C898606EA8220679.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 09:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 09:40 -!- m1rror [~m1rror@unaffiliated/m1rror] has quit [Quit: The Lounge - https://thelounge.chat] 09:41 -!- m1rror [~m1rror@unaffiliated/m1rror] has joined #bitcoin-core-dev 09:47 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 245 seconds] 09:52 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:01 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qvrdpfkaojpaouet] has left #bitcoin-core-dev [] 10:01 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qvrdpfkaojpaouet] has joined #bitcoin-core-dev 10:04 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev 10:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:10 -!- TheresaMay is now known as Holiest 10:10 -!- Holiest is now known as HoliestRoger 10:10 -!- HoliestRoger is now known as group 10:10 -!- group is now known as HoliestRoger 10:11 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 10:20 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev 10:24 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 10:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:38 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 10:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:55 < bitcoin-git> [bitcoin] GChuf closed pull request #16764: gui: update description for default language (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16764 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:00 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 11:00 -!- jbarnette [~jbarnette@139.28.218.198] has quit [] 11:01 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:01 < jeremyrubin> For IsTrusted, can someone explain why we don't recursively call istrusted on the parent? 11:02 < jeremyrubin> Currently we iterate over the inputs and check IsMine != Spendable 11:03 < jeremyrubin> Is that sufficient if we're spending from an unconfirmed tx? 11:11 -!- sleepych [sleepy@static-108-16-136-239.phlapa.ftas.verizon.net] has quit [] 11:15 -!- cprofitt1 [~cprofitt@195.140.215.184] has joined #bitcoin-core-dev 11:30 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:33 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 258 seconds] 11:37 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 11:49 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qvrdpfkaojpaouet] has left #bitcoin-core-dev [] 11:50 -!- jamesob [sid180710@gateway/web/irccloud.com/x-lrnxlmndpghtvtxe] has joined #bitcoin-core-dev 11:50 < jamesob> can anyone hear me yet? 11:50 < achow101> jamesob: shout louder 11:51 < jamesob> achow101: hah thanks 11:52 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev 11:53 < jamesob> sipa: apologies, tried replying to your question but freenode had me muted (or something). haven't tried sparsehash for chainstate but in general it looked not to perform as well as the robin_hood map. is there some reason in particular you think it'd be worth trying? 11:53 < instagibbs> jeremyrubin, I *think* it's by induction? if the previous output with !IsTrusted parent exists, you won't spend, right? 11:54 < instagibbs> if somehow you did, say raw API, well SFYL I guess 11:54 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:54 -!- jarthur_ [~jarthur@207.114.244.5] has quit [] 12:00 < meshcollider> #startmeeting 12:00 < lightningbot> Meeting started Fri Aug 30 19:00:25 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball 12:00 < instagibbs> hi 12:00 < achow101> hi 12:00 < kanzure> hi 12:00 < provoostenator> hi 12:00 < meshcollider> Topics this week? 12:00 < awesome-doge> hi 12:00 < wumpus> hi 12:01 < sipa> hi 12:01 < instagibbs> might need some assist reasoning about safety of new arg in #11413 12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub 12:01 < instagibbs> I'd like to use the X sat/B etc style as well for my bumpfee PR 12:02 < jtimon> I guess #16524 could be on-topic for this meeting? 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/16524 | Wallet: Disable -fallbackfee by default by jtimon · Pull Request #16524 · bitcoin/bitcoin · GitHub 12:02 < sipa> i'll try to have a first miniscript pr ready today 12:02 < achow101> woo miniscript 12:03 < meshcollider> instagibbs: is that a request for comment in the PR or do you want to discuss it here? 12:03 < meshcollider> sipa: exciting! :) 12:03 < instagibbs> meshcollider, the thread I guess? Unless someone has Strong Opinions 12:04 < instagibbs> problem with that PR is that it's hijacking the conf_target arg, which already has meaning without unit 12:04 < provoostenator> Probably good to discuss here, 12:04 < instagibbs> ok I propose as topic then 12:04 < meshcollider> #topic explicit feerate option (instagibbs) 12:05 < provoostenator> The easiest would be to make it mandotary to specify, but that is a breaking change. 12:06 < instagibbs> Right, it's really hard to do it safely without that, even if you don't re-purposed conf_target(unless you have 0 mean not using it?) 12:06 < provoostenator> I'm going to guess that most automated systems already set the estimate_mode param 12:07 < provoostenator> So those won't be affected. 12:08 -!- laptop500 [~laptop@92.118.153.193] has joined #bitcoin-core-dev 12:08 < provoostenator> If we deprecate & remove the "UNSET" (default) the error will at least be very clear and easy to detect if someone doesn't read the release notes. 12:08 < provoostenator> But maybe that's already going to far. 12:08 < instagibbs> that means really basic usage will break 12:09 < instagibbs> forcing -cli users to put in tons of args 12:09 < provoostenator> Forcing -cli users to specifiy what they mean with the fee rate seems reasonable to me. 12:09 < instagibbs> and the comment, comment-to, subtract fee from dest... 12:10 < achow101> named args gets around having to specify everything else 12:10 < provoostenator> I don't know if we can change the order to mvoe the fee rate first, in such a way that old invocations are guaranteed to fail 12:10 < achow101> I would rather not requiring users to have to specify the fee rate 12:11 < provoostenator> Ideally I would like "sendtoaddress AMOUNT ADDRESS FEE_RATE sat/B" 12:11 < instagibbs> new RPC command time? :P 12:11 < instagibbs> time to scope creep 12:12 < achow101> provoostenator has some ultimate send rpc pr 12:12 < instagibbs> hmm that's true 12:12 < provoostenator> #16378 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16378 | [WIP] The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub 12:12 < provoostenator> I was tempted 12:12 < achow101> maybe we should deprecate all the existing send rpcs and just make one that doesn't suck? 12:12 < provoostenator> But problem is, it'll be nice for a year or two, and then it sucks again. 12:12 < provoostenator> But I'm happy to reopen. 12:12 < sipa> mandatory xkcd: https://xkcd.com/927/ 12:13 < achow101> new rpcs: sendv1, sendv2, sendv3... 12:13 < provoostenator> Having a new RPC that's safe to use for newbies and useful for advanced forlks, might be worth doing. 12:14 < instagibbs> maybe brainstorm on how to make changes easier in the future. e.g., require units in args rather than implicit, I don't know 12:14 < provoostenator> It'd be useful to have an idea of what extra stuff we want that RPC to do in light of miniscript and multisig. 12:14 < provoostenator> Hopefully "nothing" 12:15 < instagibbs> If no one has objections to the "Xsat/B" type format I can roll with that for my PR at least 12:15 < achow101> ideally we would also have fee per weight unit too 12:15 < provoostenator> We could do something pedanctic like a 5 second delay that the user can abort with ctrl + c, if and only if the user didn't set an explicit argument. 12:16 < instagibbs> s/Wu :) c-lightning feelz 12:16 < achow101> I would prefer a single arg that specifies the unit at the end 12:16 < provoostenator> single arg with unit at the end has my preference too. As well as consistency between RPC calls. 12:17 < instagibbs> ok, I'll at least adapt my PR with a "standard" proposal 12:17 < meshcollider> Yes that seems clean 12:17 < instagibbs> then we can parse them all the same way in the future 12:17 < meshcollider> So what about kalle's PR 12:17 < instagibbs> with same code 12:17 < instagibbs> that's complicated. I don't really know. 12:17 < instagibbs> deprecate non-specified is the safe behavior 12:18 < instagibbs> non-specified unit* 12:19 < instagibbs> maybe kallewoof will have something to say when he awakes 12:20 < instagibbs> end topic I guess 12:21 < meshcollider> #topic disable -fallbackfee (jtimon) 12:21 < meshcollider> #16542 12:21 < gribble> https://github.com/bitcoin/bitcoin/issues/16542 | Return more specific errors about invalid descriptors by achow101 · Pull Request #16542 · bitcoin/bitcoin · GitHub 12:21 < meshcollider> Oops 12:21 < meshcollider> #16524 12:21 < gribble> https://github.com/bitcoin/bitcoin/issues/16524 | Wallet: Disable -fallbackfee by default by jtimon · Pull Request #16524 · bitcoin/bitcoin · GitHub 12:22 < jtimon> so what the PR does is having the same defualt for regtest as it has on mainnet, simply decoupling it from the chainparams stuff 12:23 < achow101> isn't the fallbackkfee useful though? 12:23 < instagibbs> it's useful to just have tests "Go" 12:23 < jtimon> it can still be used, you just don't have a different default for regtest 12:24 < instagibbs> so this is mostly just to pull it out of the chainparams? 12:24 < jtimon> I mean, I assume at some point we may want to change mainnet's default, but I think that's kind of orthogonal 12:24 < jtimon> instagibbs: yes 12:25 < meshcollider> Well it's not really "in" chainparams 12:26 < instagibbs> I guess I'm -0 on it, unless I see "where it's going" with follow-on changes? network-specific behavior outside of consensus params aren't going away.. 12:26 < jtimon> well, it is, it was just renamed to IsTestChain to couple it with another chainparams that says whether your chain allows you to set acceptnonstdtxs to true or not 12:27 < jtimon> I have 2 follow up PRs, but they're more related to chainparams than to the wallet: https://github.com/bitcoin/bitcoin/pull/16527 and https://github.com/bitcoin/bitcoin/pull/16526 12:28 < jtimon> I mean, I guess this is removign a feature, but is it really that important? is it that harsh to ask regtest and testnet users to set -fallbackfee explicitly? 12:28 < instagibbs> it's one sticking point that requires a restart 12:29 < instagibbs> that basically any one-off regtest users is going to have to remember to do 12:29 < instagibbs> anyways, maybe im off base 12:29 < meshcollider> Regtest will rarely have enough data for fee estimation so it is kinda annoying to have to set it every time but I'm -0 too I guess 12:29 < jtimon> I guess you won't like #16527 either then 12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/16527 | B: Get rid of Params().RequireStandard() by jtimon · Pull Request #16527 · bitcoin/bitcoin · GitHub 12:30 < instagibbs> well that won't help/stop "sendtoaddress" from working 12:30 < instagibbs> which the fallback PR would 12:30 < instagibbs> I think it's case by case 12:31 < provoostenator> It wouldn't be too bad if "1 sat/B" exists 12:31 < jtimon> so if we don't want to do this, can we at least rename it back to what it was instead of coupling it with other unrelated things with IsTestChain? 12:31 < instagibbs> could also just decouple it yeah 12:33 < jtimon> any more thoughts? if people agree with instagibbs I think that's it 12:33 < jtimon> that's it forf this topic, I mean 12:33 < meshcollider> Yeah I agree with instagibbs here 12:34 < meshcollider> sipa: did you want to talk about miniscript or was that just a PSA 12:34 < jtimon> cool, but to be clear, we agree on decoupling the IsTestChain stuff ? 12:34 < sipa> i guess 12:34 < instagibbs> jtimon, concept ACK 12:34 < instagibbs> (only speaking for self) 12:34 < jtimon> cool, thanks 12:35 < instagibbs> sipa, wasn't a yes or no question :P 12:35 < jtimon> sure, anyone feel free to express any nuances 12:35 < sipa> so there are really 4 different places miniscript can be integrated into: descriptors themselves (like, be able to write them, check them, compute addresses from), descriptor inference (finding a miniscript descriptor for a miniscript-compatible script), signing (including psbt update/finalize), and size estimation 12:35 < meshcollider> #topic miniscript (sipa) 12:36 < sipa> i'm working on a PR that includes just the first one (and maybe the second one), because the latter ones add quite a bit of complexity 12:36 < sipa> of course, it's also kinda pointless without the last ones 12:37 < achow101> I think 1 and 3 are the most useful to have first 12:37 < provoostenator> sipa: does miniscript (or your PR) help with the open issue of composing descriptors (as opposed to parsing string)? 12:37 < provoostenator> E.g. for hardware wallet support it'd be nice if we can get an xpub from the device and make a descriptor. 12:37 < provoostenator> Which currently involves hacking strings. 12:38 < sipa> no 12:38 < sipa> haven't looked at that 12:38 < meshcollider> provoostenator: open issue? Isn't that just an implementation feature 12:38 < provoostenator> Not literally an issue 12:38 < sipa> yeahh it's an imetail 12:38 < sipa> could be fixed with a bit of refactoring 12:38 < sipa> yeah it's an implementation detail 12:39 < sipa> why is my keyboard randomly dropping some letters 12:39 < provoostenator> Kind of. It gets more interesting with multisig 12:39 < sipa> achow101: 3 without 4 is a bit scary 12:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:39 < bitcoin-git> [bitcoin] godfrey-cw opened pull request #16765: Documentation for `systemd` troubleshooting (master...master) https://github.com/bitcoin/bitcoin/pull/16765 12:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:39 < sipa> right now we do size estimation just using the dummy signer... which works fine for single sig and multisig because every witness has the same size 12:40 < gwillen> 16IBtbcikinvnffggjcutlcrevrijukb 12:40 < sipa> gwillen: no begging! 12:40 < sipa> but with more complicated things it would result in the lowest possible sizes across all possible witnesses 12:40 < sipa> so that may cause fee underestimation 12:40 < provoostenator> That's probably not actually gwillen. 12:41 < gwillen> oops, sorry 12:42 < gwillen> that's no an address 12:42 < gwillen> it's an OTP from a yubikey 12:42 < sipa> haha 12:42 < provoostenator> LOL 12:42 < sipa> anyway, there'll be more to discuss when i have code to show 12:42 < achow101> sipa: maybe temporarily limit signing to single key until size estimation is in? 12:42 < achow101> like have it all there, but put some gate in the caller 12:43 < achow101> s/single key/things we already sign for 12:43 < sipa> but it's an interesting question how to structure things; in particular, the internal satisfaction code is very useful to test other parts of the miniscript logic (e.g., do randomized tests that show the stack size never exceeds the statically predicted max stack size) 12:44 < sipa> even if it isn't exposed yet because of lack of 4 12:45 < meshcollider> sipa: sounds good yeah 12:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:46 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #16766: Make IsTrusted scan parents recursively (master...recursive-istrusted) https://github.com/bitcoin/bitcoin/pull/16766 12:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:46 < meshcollider> Ok we wait for pr then 12:46 < meshcollider> Any other topics? 12:47 < jeremyrubin> Well it is wallet related, but if anyone wants to look at the PR I just opened would be thankful. 12:47 < jeremyrubin> Trying to patch in covenant detection for OP_SECURETHEBAG so that you know if you can trust funds have been paid 12:48 < jeremyrubin> But the lack of recursive trust seems like a bug because it breaks transitivity 12:48 < sipa> jeremyrubin: can you give an example of how parents could be untrusted but a child is false marked as trusted? 12:49 < jeremyrubin> Sure 12:50 < jeremyrubin> Suppose I have a txn B which I generated from a output A.0 12:50 < jeremyrubin> A.0 ISMINE_SPENDABLE 12:51 < jeremyrubin> But transaction A has an input Z.0 which is not ISMINESPENDABLE 12:51 < sipa> which of these are confirmed? 12:52 < jeremyrubin> None have to be I think 12:54 < sipa> right so you have Z,A,B in the mempool, and A will be correctly marked as !IsTrusted(), but B will be marked as IsTrusted 12:54 < jeremyrubin> Yeah that sounds right 12:55 < meshcollider> I thought transactions in the mempool are always untrusted 12:55 < jeremyrubin> Z also has to be a wallettx I think, which can be accomplished by having a Z.10 which ismine (so we're tacking it) 12:56 < meshcollider> Dw ignore me 12:56 < jeremyrubin> No, if the txn ISMINE_SPENDABLE then in theory only we can spend it (we should probably be checking ISMINE and NOT IS_SOMEONEELSES or something too for complex scripts) 12:57 < sipa> jeremyrubin: multisig is currently never ISMINE_SPENDABLE, unless you literally have all the keys in your wallet (not even just the threshold) 12:57 < jeremyrubin> Cool 12:57 < jeremyrubin> Wasn't sure 12:57 < sipa> i think that's a horrible mistake, though :) 12:57 < sipa> ownership of funds shouldn't be tied to control over keys 12:58 < jeremyrubin> In any case, I think that the recursive check fixes the edge condition 12:58 < sipa> the performance impact is scary 12:59 < sipa> you can construct a graph of transactions that makes this computation explode without caching 12:59 < jeremyrubin> I think it's OK given the limits on longchain in the mempool 12:59 < sipa> i'm not sure 12:59 < jeremyrubin> It would also be OK to construct a cache per call to IsTrusted 13:00 < jeremyrubin> but caching across calls to IsTrusted is a bit finicky 13:00 < jeremyrubin> Would that sort of caching be happier sipa? 13:01 < sipa> yeah 13:01 < jeremyrubin> e.g., you can optionally pass a unordered_set trustedParents to the call and you query against that and pass it on recursion 13:02 < jeremyrubin> k I will modify it to work that way 13:02 < meshcollider> #endmeeting 13:02 < lightningbot> Meeting ended Fri Aug 30 20:02:21 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:02 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.html 13:02 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.txt 13:02 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.log.html 13:02 < sipa> a graph of transactions consisting of 25 levels, with 2 2-in-2-out transactions per level, each spending an output from each of the previous level's transactions 13:02 < sipa> i think that would fit in the mempool 13:02 < sipa> but cost 2^26 IsTrusted calls 13:04 < sipa> with more outputs and inputs the base of the exponentiation goes up 13:08 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:13 -!- Salve [~salve@2001:1948:212:b220:d13:e66c:5ba0:716c] has quit [] 13:13 < jeremyrubin> Would you also prefer the code to be a non recursive loop? 13:14 -!- pinheadmz [~matthewzi@185.229.59.31] has quit [Quit: pinheadmz] 13:16 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:42 < jeremyrubin> I think the recursion isn't too big a deal since we're at most up 25 levels -- lmk if you feel differently. I also decided to only cache the ones we detect as being trusted, but we could cache the untrusted ones as well 13:43 < jeremyrubin> Caching untrusted seems less a big deal because it works out to be at most 25 (assuming a fully loaded trusted cache) 13:52 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 13:53 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Quit: Leaving] 14:00 -!- cprofitt1 [~cprofitt@195.140.215.184] has quit [] 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] kristapsk opened pull request #16767: test: Check for codespell in lint-spelling.sh (master...check-for-codespell) https://github.com/bitcoin/bitcoin/pull/16767 14:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 14:10 -!- pinheadmz [~matthewzi@208.69.41.101] has joined #bitcoin-core-dev 14:10 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds] 14:11 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #bitcoin-core-dev 14:11 -!- iamtimmarchant [~iamtimmar@2605:a000:1402:80d9:3de3:2c26:da37:79ee] has joined #bitcoin-core-dev 14:14 -!- laptop500 [~laptop@92.118.153.193] has quit [Remote host closed the connection] 14:14 -!- laptop500 [~laptop@92.118.153.193] has joined #bitcoin-core-dev 14:14 -!- iamtimmarchant [~iamtimmar@2605:a000:1402:80d9:3de3:2c26:da37:79ee] has quit [Remote host closed the connection] 14:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:16 -!- laptop500 [~laptop@92.118.153.193] has quit [Remote host closed the connection] 14:17 -!- laptop500 [~laptop@92.118.153.193] has joined #bitcoin-core-dev 14:23 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 14:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:29 < bitcoin-git> [bitcoin] kristapsk opened pull request #16768: test: Make lint-includes.sh work from any directory (master...lint-includes-anydir) https://github.com/bitcoin/bitcoin/pull/16768 14:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:33 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 14:34 -!- HoliestRoger is now known as TheHoliestRoger 14:41 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:43 -!- mkrautz1 [~mkrautz@139.28.218.198] has joined #bitcoin-core-dev 15:03 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 15:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:11 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:12 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 15:37 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has quit [Read error: Connection reset by peer] 15:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:39 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev 16:23 -!- davex_ [~user@45.74.60.132] has quit [Ping timeout: 258 seconds] 16:24 -!- davex__ [~user@45.74.60.132] has quit [Ping timeout: 258 seconds] 16:24 -!- davex_ [~user@45.74.60.132] has joined #bitcoin-core-dev 16:25 -!- davex__ [~user@45.74.60.132] has joined #bitcoin-core-dev 16:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:49 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 16:50 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:52 -!- laptop500 [~laptop@92.118.153.193] has quit [Ping timeout: 268 seconds] 16:55 -!- pinheadmz [~matthewzi@208.69.41.101] has quit [Quit: pinheadmz] 17:00 -!- mkrautz1 [~mkrautz@139.28.218.198] has quit [] 17:15 -!- ButterflyOfFire [~Butterfly@141.98.102.235] has joined #bitcoin-core-dev 17:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 17:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 17:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:44 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5db3f2128f0...de048a59ad11 17:44 < bitcoin-git> bitcoin/master 635e915 GChuf: [qt] Change uninstall icon on Windows 17:44 < bitcoin-git> bitcoin/master de048a5 fanquake: Merge #16760: qt: Change uninstall icon on Windows 17:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:45 < bitcoin-git> [bitcoin] fanquake merged pull request #16760: qt: Change uninstall icon on Windows (master...uninstall-icon) https://github.com/bitcoin/bitcoin/pull/16760 17:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:45 -!- lightlike [~lightlike@2001:16b8:57bb:5b00:34dd:4f7f:e52b:bb81] has quit [Quit: Leaving] 18:10 -!- davex__ [~user@45.74.60.132] has quit [Remote host closed the connection] 18:10 -!- davex__ [~user@45.74.60.132] has joined #bitcoin-core-dev 18:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de048a59ad11...e9ef1b2c2ec2 18:18 < bitcoin-git> bitcoin/master d9d8984 João Barbosa: wallet: Use wallet name instead of pointer on unload/release 18:18 < bitcoin-git> bitcoin/master e9ef1b2 fanquake: Merge #16716: wallet: Use wallet name instead of pointer on unload/release... 18:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:19 < bitcoin-git> [bitcoin] fanquake merged pull request #16716: wallet: Use wallet name instead of pointer on unload/release (master...2019-08-releasewallet) https://github.com/bitcoin/bitcoin/pull/16716 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 18:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 18:42 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 18:43 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 18:49 -!- hhhhhhhhhhh [~awesome-d@112.10.85.197] has joined #bitcoin-core-dev 19:01 -!- jtimon [~quassel@76.85.11.37.dynamic.jazztel.es] has quit [Quit: gone] 19:06 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:07 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 245 seconds] 19:19 -!- Highway61 [~Thunderbi@96.44.189.130] has quit [Ping timeout: 245 seconds] 19:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 19:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:00 -!- ButterflyOfFire [~Butterfly@141.98.102.235] has quit [] 20:00 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 20:03 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has quit [Quit: Leaving.] 20:05 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Client Quit] 20:05 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev 20:26 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 20:36 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 20:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:51 -!- hhhhhhhhhhh [~awesome-d@112.10.85.197] has quit [Remote host closed the connection] 21:10 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 244 seconds] 21:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 21:16 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 21:17 -!- Kabaka [~Kabaka@141.98.102.235] has joined #bitcoin-core-dev 21:17 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:27 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 21:28 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 21:28 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 21:29 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:31 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev 21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds] 21:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 21:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 22:28 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev 22:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 22:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:43 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has quit [Quit: Leaving.] 23:00 -!- Kabaka [~Kabaka@141.98.102.235] has quit [] 23:01 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev 23:15 -!- cryptoIndio [~cryptoInd@n11923781126.netvigator.com] has joined #bitcoin-core-dev 23:17 -!- torax [~torax@195.140.215.184] has joined #bitcoin-core-dev 23:19 -!- cryptoIndio [~cryptoInd@n11923781126.netvigator.com] has quit [Remote host closed the connection] 23:22 -!- cryptoIndio [~cryptoInd@n11923781126.netvigator.com] has joined #bitcoin-core-dev 23:24 -!- cryptoIndio [~cryptoInd@n11923781126.netvigator.com] has quit [Remote host closed the connection] 23:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9ef1b2c2ec2...495db72ee7d8 23:30 < bitcoin-git> bitcoin/master 8340763 Kristaps Kaupe: Check for codespell in lint-spelling.sh 23:30 < bitcoin-git> bitcoin/master 495db72 fanquake: Merge #16767: test: Check for codespell in lint-spelling.sh 23:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:31 < bitcoin-git> [bitcoin] fanquake merged pull request #16767: test: Check for codespell in lint-spelling.sh (master...check-for-codespell) https://github.com/bitcoin/bitcoin/pull/16767 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 23:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 23:40 -!- cryptoIn_ [~cryptoInd@n11923781126.netvigator.com] has joined #bitcoin-core-dev 23:43 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:45 -!- cryptoIn_ [~cryptoInd@n11923781126.netvigator.com] has quit [Remote host closed the connection] 23:55 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has quit [Quit: Leaving.] 23:58 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 246 seconds] 23:58 -!- Giszmo [~leo@2407:7000:9d28:5100:40a3:b13a:6bd6:ce10] has joined #bitcoin-core-dev --- Log closed Sat Aug 31 00:00:56 2019