--- Log opened Tue Sep 10 00:00:06 2019 00:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:04 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/59681beb899e...33c466a64254 00:04 < bitcoin-git> bitcoin/master 6564f58 darosior: rpc/net: decode the services flags in a new entry 00:04 < bitcoin-git> bitcoin/master 66740f4 darosior: doc: add a release note for the new field in 'getpeerinfo' and 'getnetwork... 00:04 < bitcoin-git> bitcoin/master 33c466a Wladimir J. van der Laan: Merge #16787: rpc: Human readable network services 00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:05 < bitcoin-git> [bitcoin] laanwj merged pull request #16787: rpc: Human readable network services (master...services_for_humans) https://github.com/bitcoin/bitcoin/pull/16787 00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:06 < promag> small fix #15997 00:06 < gribble> https://github.com/bitcoin/bitcoin/issues/15997 | refactor: GuessVerificationProgress requires cs_main lock by promag · Pull Request #15997 · bitcoin/bitcoin · GitHub 00:12 -!- yarwn [~yarwn@x590cbc9e.dyn.telefonica.de] has quit [Remote host closed the connection] 00:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 00:18 -!- vincenzopalazzo [~vincenzop@host253-17-dynamic.37-79-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:21 -!- vincentpalazzo [~vincenzop@host137-162-dynamic.245-95-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:24 -!- vincenzopalazzo [~vincenzop@host253-17-dynamic.37-79-r.retail.telecomitalia.it] has quit [Ping timeout: 258 seconds] 00:29 -!- yarwn [~yarwn@x590cbc9e.dyn.telefonica.de] has joined #bitcoin-core-dev 00:30 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 00:39 < wumpus> would be nice if github had explicit depends-on metadata for PRs/issues 00:49 < fanquake> Would be nice if GH had a lot of things hah. 00:50 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 01:02 < aj> meshcollider: ping? did you delete your comment "Yes and this is also not correct I think?" on 16251? github is confusing 01:04 < aj> wumpus: not sure if you got the email, but was thinking about setting up a github project board for tracking p2p PRs; does that sound plausible? 01:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:09 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:11 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:13 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:16 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:19 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 01:20 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 01:28 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:29 < fanquake> aj: I thought we had one already? 01:29 -!- Giszmo [~leo@2407:7000:9d28:5100:5d26:c4d8:c4c1:6494] has quit [Read error: Connection reset by peer] 01:29 < fanquake> https://github.com/bitcoin/bitcoin/projects/4 01:32 -!- Giszmo [~leo@2407:7000:9d28:5100:a868:5a35:748a:4bfa] has joined #bitcoin-core-dev 01:33 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:35 < wumpus> aj: oh yes I got that one, sorry, haven't got around to it yet 01:38 -!- zivl [~zivl@unaffiliated/zivl] has quit [Ping timeout: 276 seconds] 01:39 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:42 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:45 < wumpus> aj: replied 01:53 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:56 < wumpus> fanquake: hm, looks like many of the PRs there are already closed, that project isn't really kept up to date, but I guess someone could resurrect it 01:58 < fanquake> wumpus: yes, good call. Probably worth syncing up with dongcarl to structure that? 01:58 < wumpus> fanquake: yes let's ask 02:00 -!- moth [~moth@141.98.102.235] has quit [] 02:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:03 < bitcoin-git> [bitcoin] BIAgents opened pull request #16843: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/16843 02:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:03 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:05 < bitcoin-git> [bitcoin] fanquake closed pull request #16843: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/16843 02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:05 < gleb> Apparently, investment professionals are not github professionals =\ 02:17 -!- AmberJ_ [~AmberJ_@141.98.102.235] has joined #bitcoin-core-dev 02:20 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev 02:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 02:36 -!- laptop500 [~laptop@194.33.98.165] has quit [Ping timeout: 246 seconds] 02:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 02:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/33c466a64254...750c2fbf2670 02:45 < bitcoin-git> bitcoin/master 052c54e Jorge Timón: Testchains: Generic selection with -chain= in addition of -testnet an... 02:45 < bitcoin-git> bitcoin/master 3bf9d8c Jorge Timón: Testchains: Qt: Simplify network/chain styles 02:45 < bitcoin-git> bitcoin/master 750c2fb MarcoFalke: Merge #16680: Preparations for more testchains 02:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16680: Preparations for more testchains (master...b19-testchains-qt) https://github.com/bitcoin/bitcoin/pull/16680 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:53 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:57 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:04 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:08 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:09 < meshcollider> aj: yeah I thought about it more and realised I was wrong not it :) 03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:11 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:16 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:23 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:25 -!- coinmonks [736338cb@115.99.56.203] has joined #bitcoin-core-dev 03:28 < wumpus> gleb: heh, clearly, I'm surprised how people manage to open spurious PRs, like okay sometimes it's easy to do something stupid by misclicking, but they fill in and submit an actual form 03:37 < aj> meshcollider: :) 03:38 < fanquake> Did I miss a spam PR 👀 03:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:40 < aj> fanquake: 19:05 [bitcoin] fanquake closed pull request #16843: Merge pull 03:41 < gribble> https://github.com/bitcoin/bitcoin/issues/16843 | Merge pull request #1 from bitcoin/master by BIAgents · Pull Request #16843 · bitcoin/bitcoin · GitHub 03:41 < aj> fanquake: so no? 03:44 -!- coinmonks [736338cb@115.99.56.203] has quit [Ping timeout: 260 seconds] 03:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 03:54 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tqcxyncnqjqoqprn] has joined #bitcoin-core-dev 04:00 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:06 -!- laptop500 [~laptop@194.33.98.165] has joined #bitcoin-core-dev 04:08 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:19 < aj> #proposedmeetingtopic p2p pr dashboard https://gist.github.com/ajtowns/6073bd110b9f3193293b4321ce8a0394 04:21 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:30 -!- laptop500 [~laptop@194.33.98.165] has quit [Ping timeout: 276 seconds] 04:41 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.17: https://github.com/bitcoin/bitcoin/compare/ed65d1483466...2e4353d3f155 04:41 < bitcoin-git> bitcoin/0.17 2e4353d Wladimir J. van der Laan: qt: Final translations update for 0.17 branch 04:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:44 -!- Victor_sueca is now known as Victorsueca 04:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:52 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 04:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:57 -!- iuwer98374wioeur [~flack@p200300D46F0E780018C9C6ADF03214DB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:00 -!- AmberJ_ [~AmberJ_@141.98.102.235] has quit [] 05:01 -!- kljasdfvv [~flack@p200300D46F0E7800106BD438CDD85B16.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 05:17 -!- skinkie [~skinkie@192.145.126.115] has joined #bitcoin-core-dev 05:29 -!- Ox207fffff [~Thunderbi@072-182-192-217.res.spectrum.com] has quit [Quit: Ox207fffff] 05:29 -!- Ox207fffff [~Thunderbi@072-182-192-217.res.spectrum.com] has joined #bitcoin-core-dev 05:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 05:34 < gleb> Ack p2p PR dashboard. I first thought about why not labels, but managing priority etc is obviously cleaner on a dashboard. 05:39 < gleb> Not sure how to navigate between general high prio and p2p high prio tho 05:42 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 264 seconds] 05:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:57 -!- Highway61 [~Thunderbi@96.44.146.186] has joined #bitcoin-core-dev 06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:06 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/750c2fbf2670...1985c4efda56 06:06 < bitcoin-git> bitcoin/master 0c6054f THETCR: depends: Bump QT to LTS release 5.9.8 06:06 < bitcoin-git> bitcoin/master 1985c4e Wladimir J. van der Laan: Merge #16413: depends: Bump QT to LTS release 5.9.8 06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:07 < bitcoin-git> [bitcoin] laanwj merged pull request #16413: depends: Bump QT to LTS release 5.9.8 (master...qt-lts) https://github.com/bitcoin/bitcoin/pull/16413 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:08 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:08 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 06:10 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit] 06:11 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:11 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Remote host closed the connection] 06:12 -!- captjakk [~captjakk@71-218-157-130.hlrn.qwest.net] has joined #bitcoin-core-dev 06:13 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:14 -!- captjakk_ [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 06:15 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit] 06:17 -!- captjakk [~captjakk@71-218-157-130.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 06:19 -!- vincentpalazzo [~vincenzop@host137-162-dynamic.245-95-r.retail.telecomitalia.it] has quit [Quit: Leaving] 06:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Remote host closed the connection] 06:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:25 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit] 06:27 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 06:28 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 06:28 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:31 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit] 06:32 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 06:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:35 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Remote host closed the connection] 06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:38 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16845: test: Add notes on how to generate data/wallets/high_minversion (master...1909-docTestGenWalletDataHighMinVersion) https://github.com/bitcoin/bitcoin/pull/16845 06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:43 -!- MasterdonX [~masterdon@5.226.137.20] has quit [Ping timeout: 245 seconds] 06:47 -!- MasterdonX [~masterdon@207.244.76.233] has joined #bitcoin-core-dev 06:47 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:48 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:59 < promag> wumpus: in 15871 what were the arguments? 06:59 < promag> have you rebased it? 07:01 -!- captjakk_ [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Remote host closed the connection] 07:02 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 07:06 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Ping timeout: 246 seconds] 07:10 -!- ccdle12 [~ccdle12@213.137.66.63] has joined #bitcoin-core-dev 07:18 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Remote host closed the connection] 07:33 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 07:41 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Remote host closed the connection] 07:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:49 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:51 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 07:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:52 -!- kcalvina_ [~calvin@110.14.152.121] has joined #bitcoin-core-dev 07:52 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Read error: Connection reset by peer] 07:53 -!- pinheadmz [~matthewzi@209.209.238.169] has joined #bitcoin-core-dev 07:53 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 07:56 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tqcxyncnqjqoqprn] has quit [Quit: Connection closed for inactivity] 08:00 -!- skinkie [~skinkie@192.145.126.115] has quit [] 08:04 -!- ccdle12 [~ccdle12@213.137.66.63] has quit [Remote host closed the connection] 08:22 < dongcarl> wumpus fanquake aj: I haven't been making much progress on the P2P refactor mostly because I didn't find a worthy "final deliverable" that might justify touching the code (should probably try harder). I'm almost certain I'll be coming back to this after I take care of my other projects. No opinion on starting a new board or using the existing one. I believe we should have a "previous attempts" column though 08:22 < dongcarl> as there might be much to learn from those. 08:23 < sdaftuar_> dongcarl: that's a great idea 08:24 -!- sdaftuar_ is now known as sdaftuar 08:30 -!- pinheadmz [~matthewzi@209.209.238.169] has quit [Read error: Connection reset by peer] 08:33 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 08:34 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 08:40 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:47 -!- Guest45059 [~angvp@141.98.102.235] has joined #bitcoin-core-dev 08:47 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 276 seconds] 08:52 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:52 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 245 seconds] 08:53 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 08:53 -!- pinheadmz_ is now known as pinheadmz 08:54 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:59 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 276 seconds] 08:59 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 09:02 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:04 -!- pinheadmz [~matthewzi@104.222.153.40] has joined #bitcoin-core-dev 09:07 -!- pinheadmz [~matthewzi@104.222.153.40] has quit [Read error: Connection reset by peer] 09:08 -!- emilengler_ is now known as emilengler 09:08 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:15 -!- pinheadmz_ [~matthewzi@5.181.234.124] has joined #bitcoin-core-dev 09:15 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 09:15 -!- pinheadmz_ is now known as pinheadmz 09:25 -!- pinheadmz [~matthewzi@5.181.234.124] has quit [Ping timeout: 246 seconds] 09:29 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:35 -!- Highway62 [~Thunderbi@162.219.178.138] has joined #bitcoin-core-dev 09:36 -!- Highway61 [~Thunderbi@96.44.146.186] has quit [Ping timeout: 268 seconds] 09:36 -!- Highway62 is now known as Highway61 09:41 -!- lightlike [~lightlike@2001:16b8:57b3:8a00:68de:2191:adc4:3d37] has joined #bitcoin-core-dev 09:50 -!- kcalvina_ [~calvin@110.14.152.121] has quit [Remote host closed the connection] 09:54 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 09:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:00 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:07 -!- ccdle12 [~ccdle12@89-139-132-205.bb.netvision.net.il] has joined #bitcoin-core-dev 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:17 < bitcoin-git> [bitcoin] jamesob opened pull request #16847: doc: add comments clarifying how local services are advertised (master...2019-09-localservices-doc) https://github.com/bitcoin/bitcoin/pull/16847 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:37 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev 10:37 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Remote host closed the connection] 10:38 -!- Highway62 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev 10:38 -!- Highway61 [~Thunderbi@162.219.178.138] has quit [Ping timeout: 244 seconds] 10:38 -!- Highway62 is now known as Highway61 10:59 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:00 -!- Guest45059 [~angvp@141.98.102.235] has quit [] 11:17 -!- meetingology1 [~meetingol@141.98.102.235] has joined #bitcoin-core-dev 11:22 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 11:26 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:28 < bitcoin-git> [bitcoin] sdaftuar opened pull request #16849: Fix block index inconsistency in InvalidateBlock() (master...2019-09-fix-invalidate-block-consistency) https://github.com/bitcoin/bitcoin/pull/16849 11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:31 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has joined #bitcoin-core-dev 11:33 -!- kcalvina_ [~calvin@110.14.152.121] has joined #bitcoin-core-dev 11:33 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Read error: Connection reset by peer] 11:34 -!- kcalvinalvin [~calvin@223.38.8.211] has joined #bitcoin-core-dev 11:37 -!- kcalvina_ [~calvin@110.14.152.121] has quit [Ping timeout: 246 seconds] 11:39 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has quit [Ping timeout: 240 seconds] 11:44 -!- kcalvina_ [~calvin@110.14.152.121] has joined #bitcoin-core-dev 11:44 -!- kcalvinalvin [~calvin@223.38.8.211] has quit [Read error: Connection reset by peer] 11:46 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has joined #bitcoin-core-dev 11:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 11:49 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 11:58 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 12:01 -!- yarwn [~yarwn@x590cbc9e.dyn.telefonica.de] has quit [Remote host closed the connection] 12:02 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 12:20 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 12:20 -!- xzytrewq [quassel@gateway/vpn/nordvpn/nptm] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 12:22 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 12:23 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 12:24 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 12:24 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 246 seconds] 12:25 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 12:27 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 12:51 -!- kcalvina_ [~calvin@110.14.152.121] has quit [Remote host closed the connection] 12:55 -!- xzytrewq [~quassel@208.131.139.69] has joined #bitcoin-core-dev 13:05 < BlueMatt> fanquake: whats the status of #15584 ? 13:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub 13:05 < BlueMatt> do you still want to try it for 0.19? I assume its too late now? 13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:12 < bitcoin-git> [bitcoin] darosior opened pull request #16850: Functionnal tests for `servicesnames` field in `getpeerinfo` and `getnetworkinfo` (master...servicenames) https://github.com/bitcoin/bitcoin/pull/16850 13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:12 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:13 -!- Krellan [~Krellan@c-24-130-200-46.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:16 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 13:23 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 264 seconds] 13:24 < meshcollider> BlueMatt: I don't think it's too late for 19? 13:25 < meshcollider> It has two ACKs already 13:34 < luke-jr> I don't like the idea of losing wallet metadata :/ 13:38 < luke-jr> one is only a concept ACK; the other doesn't address it at all 13:40 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 245 seconds] 13:41 -!- Highway61 [~Thunderbi@162.219.179.138] has joined #bitcoin-core-dev 13:43 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 13:44 < BlueMatt> luke-jr: the wallet metadata is usually wrong, though....it'll say "bitpay" when you paid xyz.com via bitpay 13:44 < fanquake> BlueMatt: yea, I’d like to get that in. 13:44 < BlueMatt> (also, doesn't have to be "lost", you just have to turn on bip70 to see it) 13:48 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:49 -!- profmac [~ProfMac@2001:470:1f0f:226:eccb:ac0e:9cd6:df58] has quit [Ping timeout: 250 seconds] 13:50 -!- Highway61 [~Thunderbi@162.219.179.138] has quit [Remote host closed the connection] 13:51 -!- Highway61 [~Thunderbi@162.219.179.138] has joined #bitcoin-core-dev 13:52 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:54 < luke-jr> BlueMatt: afaik the goal is to remove BIP70 entirely - in which case, you have to turn it on BEFORE 0.20 or whatever 13:54 < luke-jr> and we have a terrible track record of wallet backward compatibility 13:54 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 276 seconds] 13:55 -!- Giszmo [~leo@2407:7000:9d28:5100:a868:5a35:748a:4bfa] has quit [Read error: Connection reset by peer] 13:58 -!- Giszmo [~leo@2407:7000:9d28:5100:a868:5a35:748a:4bfa] has joined #bitcoin-core-dev 14:00 -!- meetingology1 [~meetingol@141.98.102.235] has quit [] 14:00 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 14:02 -!- profmac [~ProfMac@2001:470:1f0f:226:40e6:66cf:f16a:62e] has joined #bitcoin-core-dev 14:06 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:06 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Read error: Connection reset by peer] 14:07 -!- profmac [~ProfMac@2001:470:1f0f:226:40e6:66cf:f16a:62e] has quit [Ping timeout: 250 seconds] 14:07 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 14:08 -!- profmac [~ProfMac@2001:470:1f0f:226:40e6:66cf:f16a:62e] has joined #bitcoin-core-dev 14:08 -!- reallll is now known as belcher 14:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kghtqlnjdzztmchy] has joined #bitcoin-core-dev 14:11 -!- michaelfolkson [~textual@bzq-82-81-55-16.red.bezeqint.net] has joined #bitcoin-core-dev 14:14 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 276 seconds] 14:15 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has quit [Ping timeout: 240 seconds] 14:17 -!- brimstone1 [~brimstone@94.229.74.91] has joined #bitcoin-core-dev 14:25 < achow101> that's not even wallet metadata, is it? It's just a display thing, nothing bip70 specific is stored in the wallet db 14:31 -!- profmac [~ProfMac@2001:470:1f0f:226:40e6:66cf:f16a:62e] has quit [Ping timeout: 250 seconds] 14:34 -!- profmac [~ProfMac@2001:470:1f0f:226:40e6:66cf:f16a:62e] has joined #bitcoin-core-dev 14:36 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 14:44 -!- shesek [~shesek@141.226.218.61] has joined #bitcoin-core-dev 14:44 -!- shesek [~shesek@141.226.218.61] has quit [Changing host] 14:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:57 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 15:00 -!- Ox207fffff [~Thunderbi@072-182-192-217.res.spectrum.com] has quit [Quit: Ox207fffff] 15:00 -!- Ox207fffff [~Thunderbi@072-182-192-217.res.spectrum.com] has joined #bitcoin-core-dev 15:02 -!- Netsplit *.net <-> *.split quits: hirish, nanotube 15:02 -!- michaelfolkson [~textual@bzq-82-81-55-16.red.bezeqint.net] has quit [Quit: Sleep mode] 15:02 -!- Netsplit over, joins: hirish 15:06 -!- ccdle12 [~ccdle12@89-139-132-205.bb.netvision.net.il] has quit [Remote host closed the connection] 15:09 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:09 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 15:11 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:11 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:13 -!- michaelfolkson [~textual@bzq-82-81-54-76.red.bezeqint.net] has joined #bitcoin-core-dev 15:17 -!- michaelfolkson [~textual@bzq-82-81-54-76.red.bezeqint.net] has quit [Ping timeout: 245 seconds] 15:32 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:34 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:38 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 264 seconds] 15:41 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 15:43 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 16:05 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:08 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:09 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:12 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 16:12 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 16:19 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:20 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:21 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 16:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 16:29 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kghtqlnjdzztmchy] has quit [Quit: Connection closed for inactivity] 16:32 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:32 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 16:33 -!- tnaka [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev 16:49 -!- silas26 [185bbe05@c-24-91-190-5.hsd1.ct.comcast.net] has joined #bitcoin-core-dev 16:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-grmmclmmxycqkoxu] has joined #bitcoin-core-dev 17:00 -!- brimstone1 [~brimstone@94.229.74.91] has quit [] 17:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds] 17:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:04 -!- silas26 [185bbe05@c-24-91-190-5.hsd1.ct.comcast.net] has quit [Ping timeout: 260 seconds] 17:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:12 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 17:16 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 17:17 -!- furkanmustafa [~furkanmus@141.98.102.235] has joined #bitcoin-core-dev 17:22 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 245 seconds] 17:31 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 17:37 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.6] 17:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:55 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 17:58 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 17:59 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:04 -!- lightlike [~lightlike@2001:16b8:57b3:8a00:68de:2191:adc4:3d37] has quit [Quit: Leaving] 18:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:06 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 18:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:13 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:16 -!- jayme40 [18777fe4@24-119-127-228.cpe.cableone.net] has joined #bitcoin-core-dev 18:18 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 18:19 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 18:26 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:26 -!- jayme40 [18777fe4@24-119-127-228.cpe.cableone.net] has quit [Ping timeout: 260 seconds] 18:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:30 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:33 < luke-jr> achow101: if you want to argue it's technically BIP70-independent since it's not on the network, okay, but the fact is that --disable-bip70 disables that code too :/ 18:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 18:35 < achow101> luke-jr: huh? my point was that it isn't something stored in the wallet db that requires bip70 to decode. it's a message, and afaict, it's still shown to the user, it will just look different 18:37 < achow101> if there is something that requires bip70 to decode, could you give me a code ref to it? 18:41 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 264 seconds] 18:50 < achow101> Also, if there is something that is protobuf encoded that is stored, we can just a do a minial protobuf decoder to get the data that needs to be shown 18:52 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:53 < luke-jr> achow101: the part in the #ifdef that's protobuf-encoded 18:53 < achow101> luke-jr: there's a ton of #ifef ENABLE_BIP70 lines 18:54 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 246 seconds] 18:59 < luke-jr> achow101: looking over the code, I only see the authenticated merchant name in the transactiondesc 19:00 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 19:00 < achow101> Oh.. I see it now 19:01 < luke-jr> looks like that's all I was migrating in #15064 as well 19:01 < gribble> https://github.com/bitcoin/bitcoin/issues/15064 | [PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] by luke-jr · Pull Request #15064 · bitcoin/bitcoin · GitHub 19:02 < luke-jr> I'm not sure extracting it w/o protobuf+OpenSSL is easy, but maybe I'm wrong 19:04 < achow101> i'm not sure that that is necesarily worth trying to keep. If the cert is expired (as it eventually will be), then there won't be a name shown anyways 19:04 < luke-jr> hmm 19:05 < luke-jr> sounds like a bug if we don't use the tx date when checking expiration, but oh well 19:05 < achow101> and there's been recent discussions with the CAB forum to reduce cert expirys to 1 year 19:05 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 19:05 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 240 seconds] 19:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-grmmclmmxycqkoxu] has quit [Quit: Connection closed for inactivity] 19:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 19:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 19:15 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 19:24 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 19:28 < achow101> luke-jr: could just say that the merchant name is unauthenticated 19:39 < BlueMatt> luke-jr: looks like your pr needs a rebase? 19:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:39 < BlueMatt> luke-jr: it also looks pretty simple, maybe we can land it for 19? 19:39 < BlueMatt> I mean I dont know anything about the gui, someone else should chime in, but it looks reasonable enough? 19:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 19:52 < achow101> luke-jr: I think both are relatively straightforward to decode. I can work on a decoder to extract the merchant name 19:53 < achow101> it would be preferable if we could get disable bip70 in 0.19 rather than having to wait another version to let people migrate 20:00 -!- furkanmustafa [~furkanmus@141.98.102.235] has quit [] 20:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 20:17 -!- DragonEyes1 [~DragonEye@141.98.102.235] has joined #bitcoin-core-dev 20:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 20:26 -!- kcalvinalvin [~calvin@110.14.152.121] has joined #bitcoin-core-dev 20:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 20:37 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 20:39 < luke-jr> BlueMatt: it doesn't make sense if we're disablign BIP70 too 20:39 < luke-jr> in that case, we would need to either just accept the lost metadata, or write a custom decoder 20:40 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-ghdgacblqxpdwvmj] has quit [Ping timeout: 252 seconds] 20:43 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 245 seconds] 20:44 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-tygjqsvyyzrokwed] has joined #bitcoin-core-dev 20:48 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 20:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 20:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 21:01 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 21:12 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 264 seconds] 21:23 -!- kcalvinalvin [~calvin@110.14.152.121] has quit [Ping timeout: 246 seconds] 21:25 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #bitcoin-core-dev 21:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 21:32 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 240 seconds] 21:34 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #bitcoin-core-dev 21:49 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 21:55 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 22:03 -!- ppisati [~ppisati@net-47-53-1-163.cust.vodafonedsl.it] has quit [Quit: leaving] 22:03 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 22:09 -!- davec [~davec@cpe-24-243-230-10.hot.res.rr.com] has joined #bitcoin-core-dev 22:09 -!- ppisati [~ppisati@net-188-153-155-81.cust.vodafonedsl.it] has joined #bitcoin-core-dev 22:10 < achow101> luke-jr: I'm working on a custom decoder, and it's actually not as complicated as I thought it would be. It looks to be ~200 LOC 22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:10 < bitcoin-git> [bitcoin] ajtowns opened pull request #16851: Continue relaying transactions after they expire from mapRelay (master...201909-relayparents) https://github.com/bitcoin/bitcoin/pull/16851 22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:12 < fanquake> Thanks achow101. 22:25 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 22:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:26 < bitcoin-git> [bitcoin] fanquake closed pull request #16833: bitcoin-tx: fix comment about pay-to-witness script type ("addoutpubkey" command) (master...20190908-bitcoin-tx_fix_comment_p2wsh_to_p2wpkh) https://github.com/bitcoin/bitcoin/pull/16833 22:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:37 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1985c4efda56...2296fe65f598 22:37 < bitcoin-git> bitcoin/master 3c481f8 Anthony Towns: signrawtransactionwithkey: better error messages for bad redeemScript/witn... 22:37 < bitcoin-git> bitcoin/master ec4c793 Anthony Towns: signrawtransaction*: improve error for partial signing 22:37 < bitcoin-git> bitcoin/master 2296fe6 fanquake: Merge #16251: Improve signrawtransaction error reporting 22:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:38 < bitcoin-git> [bitcoin] fanquake merged pull request #16251: rpc: Improve signrawtransaction error reporting (master...201906-signrawerror) https://github.com/bitcoin/bitcoin/pull/16251 22:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 22:42 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 245 seconds] 22:44 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #bitcoin-core-dev 22:46 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has joined #bitcoin-core-dev 22:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:00 -!- DragonEyes1 [~DragonEye@141.98.102.235] has quit [] 23:08 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 23:14 < achow101> instead of having an actual decoder, what about doing just a string search? There's a sequence of a 5 bytes that precede the merchant name that we could just search for in the payment request string itself 23:18 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit] 23:18 -!- shtirlic [~shtirlic@ec2-52-57-69-234.eu-central-1.compute.amazonaws.com] has quit [Read error: Connection reset by peer] 23:18 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev 23:22 -!- shtirlic [~shtirlic@ec2-52-57-69-234.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev 23:25 -!- yarwn [~yarwn@x4d0db1f2.dyn.telefonica.de] has joined #bitcoin-core-dev 23:29 -!- yarwn [~yarwn@x4d0db1f2.dyn.telefonica.de] has quit [Ping timeout: 244 seconds] 23:33 -!- yarwn [~yarwn@x4d0db1f2.dyn.telefonica.de] has joined #bitcoin-core-dev 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2296fe65f598...2324aa1dc409 23:36 < bitcoin-git> bitcoin/master 1619684 Aaron Clauson: Added libbitcoin_qt and bitcoin-qt to the msbuild configuration. 23:36 < bitcoin-git> bitcoin/master 2324aa1 fanquake: Merge #15529: Add Qt programs to msvc build (updated, no code changes) 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:37 < bitcoin-git> [bitcoin] fanquake merged pull request #15529: Add Qt programs to msvc build (updated, no code changes) (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529 23:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:38 -!- ccdle12 [~ccdle12@89-139-132-205.bb.netvision.net.il] has joined #bitcoin-core-dev 23:48 -!- Salt1 [~Salt@141.98.102.235] has joined #bitcoin-core-dev 23:49 -!- Krellan [~Krellan@2601:640:4100:ac00:709b:a32b:2f3b:2549] has quit [Ping timeout: 252 seconds] --- Log closed Wed Sep 11 00:00:07 2019