--- Log opened Wed Sep 18 00:00:14 2019 00:12 -!- tochka4 [~tochka4@109.195.21.38] has quit [Ping timeout: 268 seconds] 00:22 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 250 seconds] 00:28 -!- kcalvina_ [~calvin@121.162.198.124] has joined #bitcoin-core-dev 00:31 -!- kcalvinalvin [~calvin@121.162.198.124] has quit [Ping timeout: 246 seconds] 00:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Disconnected by services] 00:32 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 244 seconds] 00:33 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev 00:33 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has joined #bitcoin-core-dev 00:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 01:02 -!- kljasdfvv [~flack@p200300D46F0E780055BCB9DDA82FEF87.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 01:04 -!- kljasdfvv [~flack@p200300D46F0E780018213C938D63B247.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:10 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev 01:17 -!- Trifon [9a466ba1@154.70.107.161] has joined #bitcoin-core-dev 01:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:21 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 01:25 -!- Trifon [9a466ba1@154.70.107.161] has quit [Remote host closed the connection] 01:31 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 258 seconds] 01:33 -!- jonatack [~jon@37.166.86.165] has joined #bitcoin-core-dev 01:52 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has joined #bitcoin-core-dev 01:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:56 -!- kcalvina_ [~calvin@121.162.198.124] has quit [Remote host closed the connection] 01:58 -!- kcalvinalvin [~calvin@121.162.198.124] has joined #bitcoin-core-dev 02:00 -!- Nipo1 [~Nipo@84.39.116.180] has quit [] 02:01 -!- Deinogalerix21 [~Deinogale@81.92.202.18] has quit [Quit: WeeChat 2.6] 02:10 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:13 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:17 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-aljfsmnzbununyhz] has joined #bitcoin-core-dev 02:17 -!- seeder [uid377087@gateway/web/irccloud.com/x-kcnkbnpbhdwcvxkk] has quit [Quit: Connection closed for inactivity] 02:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:44 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 02:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:47 -!- bugbot1 [~bugbot@192.145.126.115] has joined #bitcoin-core-dev 02:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 02:56 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:57 -!- davex__ [~user@45.74.60.141] has quit [Ping timeout: 265 seconds] 03:00 -!- davex__ [~user@45.74.60.136] has joined #bitcoin-core-dev 03:06 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:06 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:08 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 03:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:13 -!- jonatack [~jon@37.166.86.165] has quit [Quit: jonatack] 03:14 -!- davex__ [~user@45.74.60.136] has quit [Ping timeout: 265 seconds] 03:14 -!- jonatack [~jon@37.166.86.165] has joined #bitcoin-core-dev 03:16 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:16 -!- davex__ [~user@45.74.60.134] has joined #bitcoin-core-dev 03:17 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:21 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection] 03:22 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev 03:23 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:34 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:52 -!- jonatack [~jon@37.166.86.165] has quit [Quit: jonatack] 03:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 03:53 -!- jonatack [~jon@37.166.86.165] has joined #bitcoin-core-dev 03:57 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:10 -!- reallll is now known as belcher 04:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 04:33 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:35 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:37 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 04:37 -!- kcalvinalvin [~calvin@121.162.198.124] has quit [Ping timeout: 268 seconds] 04:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 04:46 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:58 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:00 -!- bugbot1 [~bugbot@192.145.126.115] has quit [] 05:05 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev 05:14 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Disconnected by services] 05:15 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:18 -!- aricon1 [~aricon@195.206.169.238] has joined #bitcoin-core-dev 05:20 -!- jonatack [~jon@37.166.86.165] has quit [Quit: jonatack] 05:21 -!- jonatack [~jon@37.166.86.165] has joined #bitcoin-core-dev 05:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 05:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:40 -!- jonatack [~jon@37.166.86.165] has quit [Quit: jonatack] 05:41 -!- jonatack [~jon@37.166.86.165] has joined #bitcoin-core-dev 05:43 -!- jonatack_ [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev 05:46 -!- jonatack [~jon@37.166.86.165] has quit [Ping timeout: 268 seconds] 05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:55 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cc1d7fd57c9e...4b5e5ef4cec3 05:55 < bitcoin-git> bitcoin/master f0636d3 Carl Dong: depends: zlib: Move toolchain options to configure 05:55 < bitcoin-git> bitcoin/master 4b5e5ef Wladimir J. van der Laan: Merge #16809: depends: zlib: Move toolchain options to configure 05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:55 < bitcoin-git> [bitcoin] laanwj merged pull request #16809: depends: zlib: Move toolchain options to configure (master...2019-09-improve-zlib-pkg) https://github.com/bitcoin/bitcoin/pull/16809 05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:11 -!- jonatack_ [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 276 seconds] 06:31 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:40 -!- tsujp [~tsujp@220-245-200-152.tpgi.com.au] has joined #bitcoin-core-dev 06:43 < promag> running extended tests in branch #16898 06:43 < gribble> https://github.com/bitcoin/bitcoin/issues/16898 | test: Remove connect_nodes_bi by MarcoFalke · Pull Request #16898 · bitcoin/bitcoin · GitHub 06:52 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 06:52 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds] 06:59 -!- lightlike [~lightlike@2001:16b8:57b0:1900:e0bb:3cd3:91b1:3a70] has joined #bitcoin-core-dev 07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:02 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4b5e5ef4cec3...feb162d50027 07:02 < bitcoin-git> bitcoin/master 38bfca6 lucash-dev: Added comments referencing multiple CVEs in tests and production code. 07:02 < bitcoin-git> bitcoin/master 0c62e3a lucash-dev: New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-513... 07:02 < bitcoin-git> bitcoin/master feb162d Wladimir J. van der Laan: Merge #14696: qa: Add explicit references to related CVE's in p2p_invalid_... 07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:02 < bitcoin-git> [bitcoin] laanwj merged pull request #14696: qa: Add explicit references to related CVE's in p2p_invalid_block test (master...mention-cve-invalid-block) https://github.com/bitcoin/bitcoin/pull/14696 07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:16 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/feb162d50027...408c92038102 07:16 < bitcoin-git> bitcoin/master 4a87c5c Suhas Daftuar: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts 07:16 < bitcoin-git> bitcoin/master 408c920 Wladimir J. van der Laan: Merge #16400: refactor: Rewrite AcceptToMemoryPoolWorker() using smaller p... 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:16 < bitcoin-git> [bitcoin] laanwj merged pull request #16400: refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400 07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:20 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/408c92038102...72d30d668afd 07:20 < bitcoin-git> bitcoin/master 6f405a1 Andrew Chow: Shuffle inputs and outputs after joining psbts 07:20 < bitcoin-git> bitcoin/master c0b5d97 Andrew Chow: Test that joinpsbts randomly shuffles the inputs 07:20 < bitcoin-git> bitcoin/master 72d30d6 Wladimir J. van der Laan: Merge #16512: rpc: Shuffle inputs and outputs after joining psbts 07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:20 < bitcoin-git> [bitcoin] laanwj merged pull request #16512: rpc: Shuffle inputs and outputs after joining psbts (master...joinpsbt-rand) https://github.com/bitcoin/bitcoin/pull/16512 07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:28 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 245 seconds] 07:29 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 07:29 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:33 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/72d30d668afd...dd8cf82e9604 07:33 < bitcoin-git> bitcoin/master 7fb886b Ben Woosley: [moveonly] Split glibc sanity_test_fdelt out 07:33 < bitcoin-git> bitcoin/master b4fd0ca Ben Woosley: Include cstring for sanity_test_fdelt if required 07:33 < bitcoin-git> bitcoin/master dd8cf82 Wladimir J. van der Laan: Merge #15146: Solve SmartOS FD_ZERO build issue 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:34 < bitcoin-git> [bitcoin] laanwj merged pull request #15146: build: Solve SmartOS FD_ZERO build issue (master...glibc-sanity-string) https://github.com/bitcoin/bitcoin/pull/15146 07:34 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:36 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 07:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 07:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 07:41 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:42 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:42 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:43 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:44 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:47 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:47 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:48 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd8cf82e9604...0ee047423465 07:49 < bitcoin-git> bitcoin/master 261843e Joonmo Yang: wallet/rpc: Use the default maxfeerate value as BTC/kB 07:49 < bitcoin-git> bitcoin/master 2dfd683 Joonmo Yang: test: Add test for default maxfeerate in sendrawtransaction 07:49 < bitcoin-git> bitcoin/master 0ee0474 Wladimir J. van der Laan: Merge #16521: rpc: Use the default maxfeerate value as BTC/kB 07:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] laanwj merged pull request #16521: rpc: Use the default maxfeerate value as BTC/kB (master...maxfeerate-as-rate) https://github.com/bitcoin/bitcoin/pull/16521 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:56 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:00 -!- aricon1 [~aricon@195.206.169.238] has quit [] 08:02 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev 08:06 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [bitcoin] elichai opened pull request #16905: test: return self from ECKey/ECPubKey functions (master...2019-09-self) https://github.com/bitcoin/bitcoin/pull/16905 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:15 < wumpus> hmm don't really know what to do with #16906 08:15 < gribble> https://github.com/bitcoin/bitcoin/issues/16906 | False positive (?) in lint-python-dead-code.sh · Issue #16906 · bitcoin/bitcoin · GitHub 08:15 < wumpus> is there a pragma to make the linter ignore it? 08:17 < wumpus> iterating over subclasses is kiiinda weird code, but, how can we get travis to pass here for now without refactoring the entire way this works? 08:20 < wumpus> if we don't get a better solution I'm going to disable that linter for now 08:32 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:33 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16907: test: Add DisabledOpcodeTemplates to dead code whitelist linter (master...1909-testLintCrap) https://github.com/bitcoin/bitcoin/pull/16907 08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 08:34 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 08:47 -!- cwj1 [~cwj@84.39.116.180] has joined #bitcoin-core-dev 08:53 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Remote host closed the connection] 08:54 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has joined #bitcoin-core-dev 08:58 -!- captjakk [~captjakk@174-16-212-40.hlrn.qwest.net] has quit [Ping timeout: 245 seconds] 09:01 -!- Highway62 [~Thunderbi@96.44.145.114] has joined #bitcoin-core-dev 09:01 -!- Highway61 [~Thunderbi@96.44.145.114] has quit [Ping timeout: 276 seconds] 09:01 -!- Highway62 is now known as Highway61 09:06 -!- pinheadmz [~matthewzi@184.170.246.173] has quit [Read error: Connection reset by peer] 09:06 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:11 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.37] has joined #bitcoin-core-dev 09:13 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 268 seconds] 09:14 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 09:15 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:16 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 09:16 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 09:19 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ee047423465...cfcaa9759e23 09:29 < bitcoin-git> bitcoin/master fac35b2 MarcoFalke: test: lint: Add DisabledOpcodeTemplates to whitelist 09:29 < bitcoin-git> bitcoin/master cfcaa97 MarcoFalke: Merge #16907: test: lint: Add DisabledOpcodeTemplates to whitelist 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16907: test: lint: Add DisabledOpcodeTemplates to whitelist (master...1909-testLintCrap) https://github.com/bitcoin/bitcoin/pull/16907 09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:30 < stevenroose> are HWI questions allowed here? 09:30 < achow101> ooh lots of merges 09:30 < achow101> stevenroose: ##hwi 09:34 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev 09:35 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Read error: Connection reset by peer] 09:40 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev 09:43 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has joined #bitcoin-core-dev 09:56 -!- clarkmoody [~clarkmood@167.71.122.99] has joined #bitcoin-core-dev 09:57 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:02 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 265 seconds] 10:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 10:03 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 10:05 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:10 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 10:17 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds] 10:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:24 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds] 10:40 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16908: txmempool: Make entry time type-safe (std::chrono) (master...1909-mempoolEntryChrono) https://github.com/bitcoin/bitcoin/pull/16908 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:43 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection] 10:44 < achow101> wumpus: I think someone has vandalized the devwiki a bit. could you see if it can be restored to how it was originally? The history for the wallet class structure stuff has been lost 10:46 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 246 seconds] 10:46 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 10:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:49 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 276 seconds] 10:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:51 -!- kljasdfvv [~flack@p200300D46F0E780018213C938D63B247.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 10:51 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving] 10:51 -!- kljasdfvv [~flack@p200300D46F0E7800CCD5191B7468A7D5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:53 < achow101> nvm, I fixed it I think 11:00 -!- cwj1 [~cwj@84.39.116.180] has quit [] 11:00 -!- sipsorcery2 [~sipsorcer@68.36.195.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 11:04 -!- sipsorcery [~sipsorcer@68.36.195.178.dynamic.wline.res.cust.swisscom.ch] has quit [Ping timeout: 245 seconds] 11:05 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 11:17 -!- keyboardsurfer [~keyboards@89.238.178.75] has joined #bitcoin-core-dev 11:24 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has quit [Quit: Sleep mode] 11:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:37 < luke-jr> achow101: it's a git repo, so it shouldn't be able to lose anything without a force push (which I expect is forbidden) 11:39 < achow101> yeah, it looks like github's ui just wasn't showing it. it's still in history 11:40 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/cfcaa9759e23...59c138d2f149 11:43 < bitcoin-git> bitcoin/master 1111bb9 MarcoFalke: test: Reformat python imports to aid scripted diff 11:43 < bitcoin-git> bitcoin/master faaee1e MarcoFalke: test: Use connect_nodes when connecting nodes in the test_framework 11:43 < bitcoin-git> bitcoin/master fa3b9ee MarcoFalke: scripted-diff: test: Replace connect_nodes_bi with connect_nodes 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16898: test: Remove connect_nodes_bi (master...1908-testConnectNodes) https://github.com/bitcoin/bitcoin/pull/16898 11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:45 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-aljfsmnzbununyhz] has quit [Quit: Connection closed for inactivity] 11:47 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has joined #bitcoin-core-dev 12:02 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 240 seconds] 12:02 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev 12:05 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 276 seconds] 12:07 -!- jonatack [~jon@37.168.169.168] has joined #bitcoin-core-dev 12:07 -!- jonatack [~jon@37.168.169.168] has quit [Client Quit] 12:08 -!- jonatack [~jon@37.168.169.168] has joined #bitcoin-core-dev 12:16 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:17 -!- Highway61 [~Thunderbi@96.44.145.114] has quit [Ping timeout: 245 seconds] 12:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:34 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 12:34 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 12:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:39 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has quit [Quit: Sleep mode] 12:39 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:39 -!- jonatack [~jon@37.168.169.168] has quit [Quit: jonatack] 12:40 -!- jonatack [~jon@37.168.169.168] has joined #bitcoin-core-dev 12:42 -!- lightlike [~lightlike@2001:16b8:57b0:1900:e0bb:3cd3:91b1:3a70] has left #bitcoin-core-dev ["Leaving"] 12:42 -!- lightlike [~lightlike@2001:16b8:57b0:1900:e0bb:3cd3:91b1:3a70] has joined #bitcoin-core-dev 12:43 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 12:44 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 12:45 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:46 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 12:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:52 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 264 seconds] 12:52 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 12:58 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 12:58 -!- jarthur [~jarthur@207.114.244.5] has quit [] 13:00 -!- promag_ [~promag@2.80.22.20] has joined #bitcoin-core-dev 13:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 13:04 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 13:06 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has joined #bitcoin-core-dev 13:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:14 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 240 seconds] 13:15 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:15 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Read error: Connection reset by peer] 13:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 13:15 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:5c08:17f7:f672:4239] has quit [Quit: Sleep mode] 13:22 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 13:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:24 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds] 13:27 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has joined #bitcoin-core-dev 13:28 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 276 seconds] 13:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 13:46 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 13:50 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:54 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:58 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 14:00 -!- keyboardsurfer [~keyboards@89.238.178.75] has quit [] 14:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 14:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 14:08 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 14:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55] 14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:16 < bitcoin-git> [bitcoin] achow101 opened pull request #16910: wallet: reduce loading time by using unordered maps (master...reduce-wallet-load) https://github.com/bitcoin/bitcoin/pull/16910 14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:16 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 14:17 -!- lordnoid1 [~lordnoid@139.28.218.198] has joined #bitcoin-core-dev 14:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 14:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 14:32 -!- Skirmant [~Skirmant@78-56-81-100.static.zebra.lt] has quit [Ping timeout: 268 seconds] 14:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Disconnected by services] 14:34 -!- promag_ is now known as promag 14:35 < promag> achow101: typo in "Chamge mapWallet to be a std::unordered_map" 14:35 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:36 < promag> achow101: are you happy with the 10% reduction? 14:37 < achow101> promag: fixed that 14:37 < achow101> 10% is better than 0% 14:37 < achow101> I'm looking for more places to improve as well 14:38 < promag> well for big wallets, for "regular" (or common) wallets I guess it's ~0%? 14:39 < sipa> achow101: is there a measurable memory usage change? 14:39 < promag> I also wonder what is the impact of "Change getWalletTxs to return a set instead of a vector" 14:40 < achow101> sipa: I haven't checked 14:40 < sipa> there is probably a performance difference too for other operations than loading, but perhaps harder to measure 14:40 < achow101> sipa: I expect those to also improve 14:40 < promag> you may be turning the GUI slower than it is 14:41 < achow101> it shouldn't be 14:42 < achow101> what were previously log(n) operations to load things from the wallet now become O(1). the only difference with the gui is that there is now one additional O(log(n)) during load 14:42 < achow101> I changed it to use a std::set which is sorted and is log(n) instead of sorting a vector 14:43 < promag> ah that's because getWalletTxs is only called once 14:43 < achow101> yes 14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:44 < bitcoin-git> [bitcoin] achow101 opened pull request #16911: Only check the hash of transactions loaded from disk (master...wallet-skip-checktx) https://github.com/bitcoin/bitcoin/pull/16911 14:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:45 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 14:47 -!- clarkmoo_ [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 14:50 -!- clarkmoody [~clarkmood@167.71.122.99] has quit [Ping timeout: 240 seconds] 14:53 -!- Highway61 [~Thunderbi@96.44.145.98] has joined #bitcoin-core-dev 14:53 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 14:53 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.37] has quit [Ping timeout: 245 seconds] 14:54 -!- StopAndDecrypt [~StopAndDe@107.181.189.37] has joined #bitcoin-core-dev 14:54 -!- StopAndDecrypt [~StopAndDe@107.181.189.37] has quit [Changing host] 14:54 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 14:58 < achow101> sipa: memory impact seems to be 3 MB with my test case. 262.5 MB on master, 259.6 with the pr 14:59 < achow101> saves a little bit apparently 14:59 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 15:08 -!- clarkmoo_ [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Remote host closed the connection] 15:08 -!- clarkmoody [~clarkmood@167.71.122.99] has joined #bitcoin-core-dev 15:09 -!- achow101 [~achow101@unaffiliated/achow101] has left #bitcoin-core-dev ["Leaving"] 15:11 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [] 15:12 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 15:15 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:16 < promag> achow101: re #16991 not sure of this but wasn't there a bug in the past that caused bad txs in wallets? 15:16 < gribble> https://github.com/bitcoin/bitcoin/issues/16991 | HTTP Error 404: Not Found 15:16 < promag> #16911 15:16 < gribble> https://github.com/bitcoin/bitcoin/issues/16911 | wallet: Only check the hash of transactions loaded from disk by achow101 · Pull Request #16911 · bitcoin/bitcoin · GitHub 15:23 < achow101> promag: hmm, maybe? 15:24 < promag> achow101: 8 years ago https://github.com/bitcoin/bitcoin/blame/8d5f461cb6d4bb954fef5c3deebe2b2a7bdbfe27/src/walletdb.cpp#L244-L245 15:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 15:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 15:25 < promag> then this added CheckTransaction https://github.com/bitcoin/bitcoin/commit/eed1785f701be93ac2464e854c2a7de1f748ef84 15:26 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:27 -!- jonatack [~jon@37.168.169.168] has quit [Read error: Connection reset by peer] 15:28 < achow101> even there, the CheckTransaction isn't really well motivated 15:28 < achow101> any corruption issue (which that commit is supposed to be handling better) would be caught by the hash check 15:28 < promag> right, nothing at all, not even in the PR discussion 15:29 -!- FlipBill [~FlipBill@smtpv5.cosi.net] has joined #bitcoin-core-dev 15:31 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:31 < promag> achow101: anyway CheckTransaction sounds sane, does it slows down loading that much? 15:32 < achow101> not really 15:32 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev 15:32 < achow101> but that's just on my test case where such slowdowns may not be noticeable 15:33 < achow101> the variance in load times is too high for me tell 15:40 < promag> without that test couldn't you inject a fake tx with no input just to fake balance for instance? 15:41 < achow101> sure, but you could do the same with one with invalid inputs. signatures aren't checked 15:42 < achow101> or even existence of inputs 15:42 < achow101> err, that the inputs spend valid outputs 15:43 < promag> you are saying that currently balances shouldn't be trusted? 15:44 < sipa> ? 15:44 -!- Highway62 [~Thunderbi@184.75.220.178] has joined #bitcoin-core-dev 15:45 < sipa> if an attacker has access to your wallet.dat, nothing can be trusted 15:47 -!- Highway61 [~Thunderbi@96.44.145.98] has quit [Ping timeout: 268 seconds] 15:47 -!- Highway62 is now known as Highway61 15:48 < promag> case is you wouldn't know that, say you have a watchonly wallet, see an incorrect balance spend and sign elsewhere 15:49 < achow101> having something directly modify your wallet.dat file isn't part of our threat model 15:49 -!- marcoagner [~user@2001:8a0:6a53:2e00:1967:22be:ad77:2d5] has quit [Ping timeout: 245 seconds] 15:49 < promag> I understand is farfetched, but validation on loading just sounds good to me, and if it doesn't cost then why not 15:49 < achow101> if you had an invalid transaction in your wallet that changed the balance, you would probably also have a high likelihood of making an invalid spending tx 15:50 < promag> achow101: only when it picks the invalid utxo I believe 15:51 < sipa> promag: if they can overwrite your wallet.dat, they can modify the UTXO set too 15:51 < promag> just playing the devils advocate :P 15:51 < achow101> promag: have you even looked at what CheckTransaction does? it only checks that a transaction is well formed, it doesn't actually check validity 15:51 < promag> yes I did 15:52 -!- Highway61 [~Thunderbi@184.75.220.178] has quit [Ping timeout: 258 seconds] 15:52 -!- Highway61 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev 15:53 < promag> still, you are dropping a validation check for no good reason afaict 15:53 < achow101> I'll see if I can get benchmarks with less variance 15:54 < sipa> i doesn't look like it protects againsy anything that isn't checked otherwise 15:54 < sipa> so if there is a performance reason for dropping it, i think it should be considered 15:55 < promag> yes in that case I agree 15:56 < promag> regarding balances validity, this could be done asynchronously 15:57 < luke-jr> promag: if your full node is compromised, you are compromised. this is why hardware wallets today are a false sense of security 16:00 < sipa> promag: we don't have the data available to fully validate transactions in the wallet; the UTXOs they spend are gone 16:03 -!- Eagle[TM] [EagleTM@gateway/vpn/nordvpn/eagletm] has joined #bitcoin-core-dev 16:04 < promag> partial validation would be better than nothing? and the source utxos could be retrieved? 16:04 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 258 seconds] 16:04 < achow101> not without txindex 16:05 < sipa> promag: partial validation is useless unless it actually makes attacks more expensive 16:06 < sipa> achow101: and without pruning 16:06 < promag> right right right 16:06 < sipa> and arguably validity of wallet transactions needs recursive validity of all transactions dependent on, which may in fact be pretty much the entire chain 16:06 < sipa> *depended 16:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 16:07 < promag> so in wallet.dat we trust 16:07 < sipa> and chainstate/ we trust 16:07 < sipa> and bitcoind we trust 16:08 < sipa> and the OS we trust 16:08 < promag> eventually the network trusts too 16:08 < promag> now the word trust sounds weird 16:11 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 16:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:24 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:24 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 16:28 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 260 seconds] 16:30 -!- promag [~promag@2.80.22.20] has quit [Remote host closed the connection] 16:31 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:34 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #16912: doc: Remove Doxygen intro from src/bitcoind.cpp (master...doc/doxygen-intro) https://github.com/bitcoin/bitcoin/pull/16912 16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:35 -!- laptop500 [~laptop@host86-134-43-42.range86-134.btcentralplus.com] has quit [Ping timeout: 240 seconds] 16:38 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 16:44 -!- lightlike [~lightlike@2001:16b8:57b0:1900:e0bb:3cd3:91b1:3a70] has quit [Quit: Leaving] 16:53 < fanquake> #proposedmeetingtopic #16883: QML based mobile GUI - feel free to skip if I'm not up. 16:53 < gribble> https://github.com/bitcoin/bitcoin/issues/16883 | WIP: Qt: add QML based mobile GUI by icota · Pull Request #16883 · bitcoin/bitcoin · GitHub 16:54 < fanquake> I will leave further thoughts in the PR. 17:00 -!- lordnoid1 [~lordnoid@139.28.218.198] has quit [] 17:13 -!- EagleTM [EagleTM@gateway/vpn/nordvpn/eagletm] has joined #bitcoin-core-dev 17:14 -!- Eagle[TM] [EagleTM@gateway/vpn/nordvpn/eagletm] has quit [Ping timeout: 245 seconds] 17:17 -!- jonhcw [~jonhcw@195.206.169.238] has joined #bitcoin-core-dev 17:26 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:28 -!- KeepmbyourSide [5cfc7f9d@gateway/web/cgi-irc/kiwiirc.com/ip.92.252.127.157] has joined #bitcoin-core-dev 17:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:37 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #16913: build: Reorder a msvc macro (master...build/msvc-core-macros) https://github.com/bitcoin/bitcoin/pull/16913 17:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 17:49 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 17:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59c138d2f149...9bf5768dd628 17:51 < bitcoin-git> bitcoin/master c4b0c08 Gregory Sanders: Update tx-size-small comment with relevant CVE disclosure 17:51 < bitcoin-git> bitcoin/master 9bf5768 fanquake: Merge #16885: doc: Update tx-size-small comment with relevant CVE disclosu... 17:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:52 < bitcoin-git> [bitcoin] fanquake merged pull request #16885: doc: Update tx-size-small comment with relevant CVE disclosure (master...CVE-2017-12842_comment) https://github.com/bitcoin/bitcoin/pull/16885 17:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:10 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 18:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:11 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 18:13 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 18:27 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 18:32 -!- Krellan_ [~Krellan@2601:640:4100:ac00:c525:3399:43cb:68a5] has joined #bitcoin-core-dev 18:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:33 < bitcoin-git> [bitcoin] fanquake closed pull request #16913: build: Reorder a msvc macro (master...build/msvc-core-macros) https://github.com/bitcoin/bitcoin/pull/16913 18:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:36 -!- Krellan [~Krellan@2601:640:4100:ac00:6012:4508:1492:d7c8] has quit [Ping timeout: 245 seconds] 18:37 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 18:43 -!- clarkmoody [~clarkmood@167.71.122.99] has quit [] 18:45 -!- xzytrewq [~quassel@192.200.24.3] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 18:56 -!- KeepmbyourSide [5cfc7f9d@gateway/web/cgi-irc/kiwiirc.com/ip.92.252.127.157] has quit [Remote host closed the connection] 18:56 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev 19:01 -!- xzytrewq [~quassel@192.200.24.3] has joined #bitcoin-core-dev 19:03 < fanquake> #proposedmeetingtopic: #16713 Ignore old versionbit activations to avoid 'unknown softforks' warning 19:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16713 | Ignore old versionbit activations to avoid unknown softforks warning by jnewbery · Pull Request #16713 · bitcoin/bitcoin · GitHub 19:05 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 19:09 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 245 seconds] 19:21 -!- ensign [~ensign@2001:41d0:8:d711::1] has quit [Ping timeout: 245 seconds] 19:22 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 245 seconds] 19:23 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 245 seconds] 19:29 -!- xzytrewq [~quassel@192.200.24.3] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 19:44 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 19:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:00 -!- jonhcw [~jonhcw@195.206.169.238] has quit [] 20:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 20:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 20:12 -!- Honthe [~Honthe@s91904421.blix.com] has joined #bitcoin-core-dev 20:40 -!- xzytrewq [~quassel@192.200.24.3] has joined #bitcoin-core-dev 20:44 -!- xzytrewq_ [~quassel@192.200.24.3] has joined #bitcoin-core-dev 20:48 -!- xzytrewq [~quassel@192.200.24.3] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 20:56 -!- Honthe [~Honthe@s91904421.blix.com] has quit [Quit: Leaving] 21:08 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 21:18 -!- jaqque1 [~jaqque@195.206.169.238] has joined #bitcoin-core-dev 21:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 21:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 21:34 -!- Highway61 [~Thunderbi@104.223.95.34] has quit [Ping timeout: 240 seconds] 21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds] 21:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 21:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 22:29 -!- RandolfR [~randolf@184.70.10.189] has joined #bitcoin-core-dev 22:32 -!- Randolf [~randolf@184.70.10.188] has quit [Ping timeout: 258 seconds] 22:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 22:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 22:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 22:45 -!- kcalvinalvin [~calvin@203.251.184.132] has joined #bitcoin-core-dev 22:46 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev 22:50 -!- RandolfR is now known as Randolf 23:00 -!- jaqque1 [~jaqque@195.206.169.238] has quit [] 23:10 -!- EagleTM [EagleTM@gateway/vpn/nordvpn/eagletm] has quit [Ping timeout: 240 seconds] 23:15 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 23:17 -!- sammuel86 [~sammuel86@185.204.1.185] has joined #bitcoin-core-dev 23:19 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds] 23:20 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 23:40 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 23:40 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 23:41 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 23:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 23:43 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 23:56 -!- bushstar [~bushstar@2a00:23c7:9204:1700:98ff:b07:cfe5:1028] has joined #bitcoin-core-dev 23:57 -!- bushstar [~bushstar@2a00:23c7:9204:1700:98ff:b07:cfe5:1028] has quit [Remote host closed the connection] 23:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev --- Log closed Thu Sep 19 00:00:15 2019