--- Log opened Thu Oct 24 00:00:43 2019
00:02 -!- laptop_ [~laptop@194.33.98.165] has joined #bitcoin-core-dev
00:06 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
00:09 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has joined #bitcoin-core-dev
00:10 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
00:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:22 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
00:26 -!- laptop_ [~laptop@194.33.98.165] has quit [Ping timeout: 245 seconds]
00:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
00:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:44 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
00:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:55 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds]
00:57 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 276 seconds]
00:58 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
01:01 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
01:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
01:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
01:07 < elichai2> Look at how they handle performance checks for PRs. I want this. https://github.com/rust-lang/rust/pull/64595
01:09 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #bitcoin-core-dev
01:10 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has joined #bitcoin-core-dev
01:12 -!- promag [~promag@176.79.11.53] has joined #bitcoin-core-dev
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:16 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c5ac7af7793a...8a191148db3f
01:16 < bitcoin-git> bitcoin/master 8bba91b John Newbery: [wallet] Fix whitespace in CWallet::CommitTransaction()
01:16 < bitcoin-git> bitcoin/master b6f486a John Newbery: [wallet] Add doxygen comment to CWallet::CommitTransaction()
01:16 < bitcoin-git> bitcoin/master d1734f9 John Newbery: [wallet] Remove return value from CommitTransaction()
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:17 < bitcoin-git> [bitcoin] laanwj merged pull request #17154: wallet: Remove return value from CommitTransaction (master...2019-04-CommitTransaction) https://github.com/bitcoin/bitcoin/pull/17154
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:17 -!- promag [~promag@176.79.11.53] has quit [Ping timeout: 265 seconds]
01:19 -!- promag [~promag@dsl-11-53.bl27.telepac.pt] has joined #bitcoin-core-dev
01:21 -!- promag_ [~promag@dsl-11-53.bl27.telepac.pt] has joined #bitcoin-core-dev
01:24 -!- promag [~promag@dsl-11-53.bl27.telepac.pt] has quit [Read error: Connection reset by peer]
01:24 -!- promag_ [~promag@dsl-11-53.bl27.telepac.pt] has quit [Read error: Connection reset by peer]
01:25 -!- promag [~promag@176.79.11.53] has joined #bitcoin-core-dev
01:25 -!- promag_ [~promag@dsl-11-53.bl27.telepac.pt] has joined #bitcoin-core-dev
01:27 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has quit [Quit: Sleep mode]
01:27 -!- laptop_ [~laptop@194.33.98.165] has joined #bitcoin-core-dev
01:32 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
01:37 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 246 seconds]
01:39 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
01:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has joined #bitcoin-core-dev
01:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 276 seconds]
01:44 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:47 < bitcoin-git> [bitcoin] promag opened pull request #17237: wallet: LearnRelatedScripts only if KeepDestination (master...2019-10-wallet-reservedestination) https://github.com/bitcoin/bitcoin/pull/17237
01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:50 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8a191148db3f...b688b859dbb2
01:50 < bitcoin-git> bitcoin/master a1a07cf John Newbery: [validation] Fix peer punishment for bad blocks
01:50 < bitcoin-git> bitcoin/master 0053e16 John Newbery: [logging] Don't log REJECT code when transaction is rejected
01:50 < bitcoin-git> bitcoin/master e9d5a59 John Newbery: [validation] Remove REJECT code from CValidationState
01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:50 < bitcoin-git> [bitcoin] laanwj merged pull request #17004: validation: Remove REJECT code from CValidationState (master...2019-09-no-reject-validation-state) https://github.com/bitcoin/bitcoin/pull/17004
01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:52 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has quit [Quit: Sleep mode]
02:00 -!- G13 [~G13@77.243.177.38] has quit []
02:03 -!- acked [b94186ae@185.65.134.174] has joined #bitcoin-core-dev
02:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
02:12 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
02:17 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
02:20 -!- acked [b94186ae@185.65.134.174] has left #bitcoin-core-dev []
02:22 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:31 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #bitcoin-core-dev
02:34 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has joined #bitcoin-core-dev
02:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
02:36 -!- tecnovert [~user@mail.tecnovert.net] has joined #bitcoin-core-dev
02:38 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
02:42 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
02:43 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has joined #bitcoin-core-dev
02:43 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds]
02:44 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Remote host closed the connection]
02:46 -!- ffej [~ffej@141.98.102.179] has joined #bitcoin-core-dev
02:54 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 252 seconds]
03:03 -!- rex4539 [~rex4539@2a02:587:3514:c700:d47b:d913:73d2:49f3] has joined #bitcoin-core-dev
03:37 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
03:40 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
03:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has quit [Quit: Sleep mode]
03:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has joined #bitcoin-core-dev
03:42 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
03:44 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
03:48 -!- Honthe [~Honthe@s91904421.blix.com] has quit [Read error: Connection reset by peer]
04:06 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
04:10 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 268 seconds]
04:11 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 276 seconds]
04:15 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Quit: jonatack]
04:16 -!- jonatack_ [~jon@213.152.161.249] has joined #bitcoin-core-dev
04:16 -!- jonatack_ [~jon@213.152.161.249] has quit [Client Quit]
04:16 -!- jonatack_ [~jon@213.152.161.249] has joined #bitcoin-core-dev
04:18 -!- jonatack_ [~jon@213.152.161.249] has quit [Client Quit]
04:18 -!- jonatack_ [~jon@213.152.161.249] has joined #bitcoin-core-dev
04:21 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has quit [Quit: Sleep mode]
04:22 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has joined #bitcoin-core-dev
04:22 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c0cf:92fb:ed09:3579] has quit [Client Quit]
04:28 -!- pergaminho [~Cleber@177.19.230.39] has joined #bitcoin-core-dev
04:28 -!- pergaminho [~Cleber@177.19.230.39] has quit [Remote host closed the connection]
04:33 -!- pergaminho [~Cleber@177.19.230.39] has joined #bitcoin-core-dev
04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:42 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b688b859dbb2...205cffaf383c
04:42 < bitcoin-git> bitcoin/master 0fc81a1 Joao Barbosa: gui: Fix payAmount tooltip in SendCoinsEntry
04:42 < bitcoin-git> bitcoin/master 205cffa Wladimir J. van der Laan: Merge #17226: gui: Fix payAmount tooltip in SendCoinsEntry
04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:42 < bitcoin-git> [bitcoin] laanwj merged pull request #17226: gui: Fix payAmount tooltip in SendCoinsEntry (master...2019-10-payamount-tooltip) https://github.com/bitcoin/bitcoin/pull/17226
04:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:43 -!- promag [~promag@176.79.11.53] has quit [Remote host closed the connection]
04:45 -!- promag_ [~promag@dsl-11-53.bl27.telepac.pt] has quit [Remote host closed the connection]
04:46 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
04:52 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
04:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
05:00 -!- ffej [~ffej@141.98.102.179] has quit []
05:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:16 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
05:17 -!- ao2 [~ao2@141.98.102.235] has joined #bitcoin-core-dev
05:18 -!- ao2 is now known as Guest68338
05:18 -!- lightlike [~lightlike@2001:16b8:5755:300:44e4:3af8:45cd:7840] has joined #bitcoin-core-dev
05:30 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
05:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/205cffaf383c...d53828cb7968
05:35 < bitcoin-git> bitcoin/master db4bd32 practicalswift: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only w...
05:35 < bitcoin-git> bitcoin/master c2f964a practicalswift: tests: Remove Cygwin WinMain workaround
05:35 < bitcoin-git> bitcoin/master d53828c MarcoFalke: Merge #17235: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerif...
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17235: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed. (master...fuzz-initialize-when-needed) https://github.com/bitcoin/bitcoin/pull/17235
05:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:40 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
05:45 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] sandakersmann closed pull request #17166: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17166
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:58 < bitcoin-git> [bitcoin] sandakersmann opened pull request #17239: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17239
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:00 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
06:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
06:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:04 < ryanofsky> can add ariard pr #15931 to high priority reviews? first in a series of changes to make wallet sync code sane and nonblocking
06:04 < gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard . Pull Request #15931 . bitcoin/bitcoin . GitHub
06:05 -!- davterra [~none@195.242.213.120] has quit [Remote host closed the connection]
06:06 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Remote host closed the connection]
06:06 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev
06:07 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
06:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
06:15 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
06:15 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
06:15 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
06:27 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
06:28 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
06:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:31 -!- jonatack_ [~jon@213.152.161.249] has quit [Ping timeout: 246 seconds]
06:39 -!- rex4539 [~rex4539@2a02:587:3514:c700:d47b:d913:73d2:49f3] has quit [Ping timeout: 246 seconds]
06:46 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
06:55 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
07:00 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 252 seconds]
07:00 -!- laptop_ [~laptop@194.33.98.165] has quit [Quit: Leaving]
07:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.4]
07:17 -!- jonatack_ [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
07:22 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
07:26 -!- jonatack_ [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: jonatack_]
07:27 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 252 seconds]
07:27 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
07:28 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
07:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
07:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
07:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
07:41 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:44 -!- pergaminho [~Cleber@177.19.230.39] has quit [Quit: Saindo]
07:46 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
07:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
07:51 -!- pergaminho [~Cleber@177.19.230.39] has joined #bitcoin-core-dev
07:51 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:52 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has joined #bitcoin-core-dev
07:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 264 seconds]
07:54 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has left #bitcoin-core-dev []
07:56 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
07:56 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has joined #bitcoin-core-dev
07:58 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:00 -!- Guest68338 [~ao2@141.98.102.235] has quit []
08:03 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
08:06 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
08:06 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Read error: Connection reset by peer]
08:07 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:08 < bitcoin-git> [bitcoin] fanquake closed pull request #17054: [0.18.2] Backport of #15706 (0.18...check-qt-version-0.18) https://github.com/bitcoin/bitcoin/pull/17054
08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:08 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:12 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
08:14 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
08:15 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 245 seconds]
08:17 -!- Aaaron [~Aaaron@89.238.178.75] has joined #bitcoin-core-dev
08:28 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Ping timeout: 240 seconds]
08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d53828cb7968...d7134ead84e3
08:36 < bitcoin-git> bitcoin/master 6f68523 Marius Kjaerstad: doc: Changed miniupnp links to https
08:36 < bitcoin-git> bitcoin/master d7134ea fanquake: Merge #17239: doc: Changed miniupnp links to https
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] fanquake merged pull request #17239: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17239
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:58 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Remote host closed the connection]
08:58 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has joined #bitcoin-core-dev
08:58 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 260 seconds]
09:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
09:14 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
09:23 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
09:23 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has joined #bitcoin-core-dev
09:28 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
09:28 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
09:28 -!- davterra [~none@195.242.213.120] has quit [Quit: Leaving]
09:31 -!- rex4539 [~rex4539@2a02:587:3514:c700:d47b:d913:73d2:49f3] has joined #bitcoin-core-dev
09:37 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev
09:39 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
09:45 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
09:46 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
09:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:47 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17240: ci: Disable functional tests on mac host (master...1910-ciNoFunMac) https://github.com/bitcoin/bitcoin/pull/17240
09:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:53 < wumpus> removed "waiting for author" and "needs rebase" from all closed PRs
09:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:57 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
09:58 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds]
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:58 < bitcoin-git> [bitcoin] jnewbery opened pull request #17241: [WIP] remove fCheckDuplicateInputs from CheckTransaction() (master...2019-10-fduplicateinputs) https://github.com/bitcoin/bitcoin/pull/17241
09:59 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:59 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
10:00 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoin] jnewbery closed pull request #17241: [WIP] remove fCheckDuplicateInputs from CheckTransaction() (master...2019-10-fduplicateinputs) https://github.com/bitcoin/bitcoin/pull/17241
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:10 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds]
10:11 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:13 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev
10:13 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
10:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
10:13 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 276 seconds]
10:14 -!- afk11` is now known as afk11
10:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:16 < bitcoin-git> [bitcoin] jnewbery opened pull request #17242: validation: Remove unused cacheSigStore from CheckInputsFromMempooAndCache (master...2019-10-checkinputsfrommempool) https://github.com/bitcoin/bitcoin/pull/17242
10:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:19 < MarcoFalke> wumpus: could you add  adamjonas  to the Bitcoin Core label group pls?
10:19 < MarcoFalke> Also, ryanofsky qualifies for that group
10:21 < jonatack> MarcoFalke: what is the Bitcoin Core label group, and how does one qualify?
10:21 < wumpus> MarcoFalke: sure
10:22 < MarcoFalke> jonatack: Anyone who is doing that work, but has to ask others currently, qualifies
10:23 < wumpus> jonatack: the people who have semi-write access to the repository to be able to change labels and open/close issues
10:23 < MarcoFalke> I saw ryanofsky and adamjonas go over a lot of historic issues and ask other maintainers to close them or add/remove labels
10:24 < jonatack> Thank you.
10:24 -!- rex4539 [~rex4539@2a02:587:3514:c700:d47b:d913:73d2:49f3] has quit [Quit: rex4539]
10:24 < wumpus> haven't seen the name adamjonas a lot
10:24 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 268 seconds]
10:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
10:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:27 < wumpus> invited them to the orgs at least...
10:28 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
10:40 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 240 seconds]
10:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:46 -!- pergaminho [~Cleber@177.19.230.39] has quit [Ping timeout: 240 seconds]
10:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:52 -!- pergaminho [~Cleber@177.19.230.39] has joined #bitcoin-core-dev
10:58 -!- pergaminho [~Cleber@177.19.230.39] has quit [Quit: Saindo]
11:00 -!- Aaaron [~Aaaron@89.238.178.75] has quit []
11:03 < fanquake> wumpus yea that's only very recently
11:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:14 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has quit [Ping timeout: 240 seconds]
11:14 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has joined #bitcoin-core-dev
11:17 -!- MarkusH1 [~MarkusH@185.204.1.185] has joined #bitcoin-core-dev
11:24 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:27 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7134ead84e3...4af044716952
11:27 < bitcoin-git> bitcoin/master fa71006 MarcoFalke: ci: Disable functional tests on mac host
11:27 < bitcoin-git> bitcoin/master 4af0447 Wladimir J. van der Laan: Merge #17240: ci: Disable functional tests on mac host
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:28 < bitcoin-git> [bitcoin] laanwj merged pull request #17240: ci: Disable functional tests on mac host (master...1910-ciNoFunMac) https://github.com/bitcoin/bitcoin/pull/17240
11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:29 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
11:34 < fanquake> I've started engaging with GitHub in regards to: https://github.com/bitcoin/bitcoin/issues/15847#issuecomment-526829870.
11:35 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
11:35 < fanquake> Interestingly, there are at least two members of the Rust Core team in the same group, and it's looks like we are sharing some of the same GitHub grievances as them.
11:35 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
11:43 -!- rex4539 [~rex4539@2a02:587:3514:c700:5d15:24bd:fb16:8e32] has joined #bitcoin-core-dev
11:43 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
11:48 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
11:57 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
11:59 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
11:59 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
12:00 < wumpus> meeting time?
12:00 < MarcoFalke> yeah
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Oct 24 19:00:51 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < fanquake> Hi
12:00 < jonatack> hi
12:01 < sipa> hi
12:01 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:01 < jeremyrubin> hi
12:01 < MarcoFalke> I'd like to add #16975 and remove my current pull request from high prio
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/16975 | test: Show debug log on unit test failure by MarcoFalke . Pull Request #16975 . bitcoin/bitcoin . GitHub
12:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds]
12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
12:01 < amiti> hi
12:01 < moneyball> hi
12:01 < wumpus> #topic High priority for review
12:01 < kanzure> hi
12:01 < achow101> hi
12:02 < dongcarl> ih
12:02 < ariard> hi
12:02 < wumpus> MarcoFalke: done
12:03 < jamesob> hi
12:03 < MarcoFalke> thx
12:03 < MarcoFalke> https://github.com/bitcoin/bitcoin/projects/8
12:03 < fjahr> hi
12:03 < fanquake> I'll propose #17165 of mine, as that's now in a fairly reviewable state.
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/17165 | Remove BIP70 support by fanquake . Pull Request #17165 . bitcoin/bitcoin . GitHub
12:04 < provoostenator> hi
12:04 < jamesob> can I request we add #16442 to high prio?
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo . Pull Request #16442 . bitcoin/bitcoin . GitHub
12:04 < provoostenator> +1 for 16422
12:04 < wumpus> fanquake: added
12:04 -!- JeremyCrookshank [d9925277@217.146.82.119] has joined #bitcoin-core-dev
12:05 < MarcoFalke> fanquake: Needs (trivial) rebase ;)
12:05 < wumpus> jamesob: provoostenator  also added
12:05 < jamesob> thanks!
12:05 < fanquake> MarcoFalke: I feel like thats at least the 3rd time I've had to rebase recently for that same file :o
12:05 < wumpus> which file ?
12:05 < provoostenator> Suggested topic BIP157 if we have time...
12:05 < fanquake> ci/test/00_setup_env_mac_functional.sh
12:06 < wumpus> oh, well, mac functional tests are gone now, you shouldn't have to rebase anymore for that
12:07 < instagibbs> hi
12:07 < wumpus> I think we have plenty of time, no topics have been suggested for today; though I think we need to discuss 0.19.0rc2 as well
12:07 < jtimon> can we add #17037 to chasing concept ack?
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17037 | Testschains: Many regtests with different genesis and default datadir by jtimon . Pull Request #17037 . bitcoin/bitcoin . GitHub
12:07 < wumpus> #topic BIP157 (provoostenator)
12:08 < provoostenator> I found some issues while testing against Lnd / Btcd
12:08 < provoostenator> cc roasbeef
12:08 < wumpus> jtimon: added
12:08 < digi_james> hi
12:08 < jtimon> thanks
12:08 < instagibbs> provoostenator, testing what against, 0.19?
12:09 < provoostenator> btcd uses a max getcfilters of 1000
12:09 < provoostenator> Where the BIP uses 100
12:09 < jeremyrubin> suggested topic: mempool limits
12:09 < provoostenator> So the #16442 will disconnect from those
12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo . Pull Request #16442 . bitcoin/bitcoin . GitHub
12:10 -!- reallll is now known as belcher
12:10 < provoostenator> I believe the rationale for 100 was to get those messages to about 2 MB
12:10 < provoostenator> Bigger means fewer round dtrips for mobile.
12:10 < provoostenator> I don't know if there's a downside to bigger...
12:10 < provoostenator> We don't send these things unsollicited
12:11 < MarcoFalke> That sounds like a bug in either btcd or the bip? Maybe the mailing list is a better place to discuss?
12:11 < provoostenator> Converesy, we don't have a rate limiter for this in the PR. Lnd, when "misconfigured" will happily fetch gigabytes per minute...
12:11 < provoostenator> Yeah, mailinglist makes sense regardless, but was hoping to find opinions here first.
12:12 < sipa> provoostenator: how does the misconfiguration manifest?
12:12 < sipa> is it fetching the same block over and over?
12:12 < provoostenator> sipa: when it checks lightning channel gossip, it refetches old filters all the time
12:12 < provoostenator> That's an Lnd bug imo
12:12 < provoostenator> But someone can do this intentionally too
12:13 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 252 seconds]
12:13 < sipa> of course
12:13 < provoostenator> Do we have any rate limiting on block fetching and such?
12:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: No route to host]
12:13 -!- Venom80 [5323bc56@gateway/web/cgi-irc/kiwiirc.com/ip.83.35.188.86] has joined #bitcoin-core-dev
12:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:14 < sipa> not afaik
12:14 < provoostenator> Ok, I guess in that case there's not much precedent to add it for filters.
12:14 < wumpus> no, there's no rate limiting on block fetching
12:15 < wumpus> it's only limited by the I/O speeds, disk and network
12:15 < MarcoFalke> or by -maxuploadtarget
12:16 < wumpus> the extra DoS vector with bloom filters is that it allowed to do a DoS on the disk without actually having to receive the data over the network, but, it's easy to saturate bandwidth
12:16 < wumpus> yes, there's that
12:16 < jnewbery> Can we add #15934 to high priority? It's blocking three other PRs which add quite nice functionality (#15935, #15936, #15937)
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky . Pull Request #15934 . bitcoin/bitcoin . GitHub
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky . Pull Request #15935 . bitcoin/bitcoin . GitHub
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15936 | WIP: Unify bitcoin-qt and bitcoind persistent settings by ryanofsky . Pull Request #15936 . bitcoin/bitcoin . GitHub
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15937 | WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky . Pull Request #15937 . bitcoin/bitcoin . GitHub
12:16 < sipa> BIP157 doesn't have the same problem as the I/O required is proportional to what is sent over the network
12:16 < wumpus> right
12:17 < wumpus> jnewbery: sure, though I think with 10 blockers in high prio we're kind of pushing it
12:17 < jamesob> +1 on 15934
12:17 < jamesob> (but agree the list is getting long)
12:17 < provoostenator> Ok, so any thoughts on the maximum size of filter messages we send (ignoring the BIP)?
12:17 < jnewbery> wumpus: how about if I promise to review some of the other ones? :)
12:18 < instagibbs> wumpus, people have different interests in subtopics, i dont think "long" hurts more than too many type collsions 
12:18 < wumpus> jnewbery: great!
12:18 < wumpus> instagibbs: 10 is fine 
12:18 < instagibbs> :)
12:19 < jeremyrubin> I've been making fine progress on the things that depend on #16766, so am OK with either removing from high priority while it gets more review or else I think it's basically mergeable now.
12:19 < gribble> https://github.com/bitcoin/bitcoin/issues/16766 | wallet: Make IsTrusted scan parents recursively by JeremyRubin . Pull Request #16766 . bitcoin/bitcoin . GitHub
12:20 < wumpus> #topic 0.19.0rc2
12:20 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
12:20 < fanquake> https://github.com/bitcoin/bitcoin/milestones/0.19.0
12:20 < wumpus> there have been quite a few things merged since rc1, and some time has passed, I think it is time to tag rc2?
12:20 -!- JJ34 [d9925277@217.146.82.119] has joined #bitcoin-core-dev
12:20 < fanquake> I agree. I think I backported most/all of the bug fixes
12:21 < wumpus> #17120 should make it in probably
12:21 < gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag . Pull Request #17120 . bitcoin/bitcoin . GitHub
12:21 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Ping timeout: 245 seconds]
12:22 < fanquake> I'd sort of lost whats been happening in there. Also nother GUI only issue.
12:22 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
12:22 < provoostenator> That definately needs to be in an rc.
12:22 < wumpus> it's an actual serious bug, which can result in crashes
12:22 < MarcoFalke> so #17112 is not going to get fixed?
12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/17112 | v0.19.0rc1 GUI repeatedly not responding . Issue #17112 . bitcoin/bitcoin . GitHub
12:22 < provoostenator> MarcoFalke: #1712 fixes that
12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/1712 | Qt: possible bug related to immature balance? . Issue #1712 . bitcoin/bitcoin . GitHub
12:22 < wumpus> (creating qt objects like timers outside the GUI thread should be considered *really* carefully)
12:22 < fanquake> I opened the original issue that that is fixing. The crashes only occur, or at least the ones I saw, when you run with FATAL_WARNINGS
12:23 < fanquake> Which turns warnings into crashes
12:23 < MarcoFalke> provoostenator: Does it?
12:23 < provoostenator> MarcoFalke: I meant #17120
12:23 < gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag . Pull Request #17120 . bitcoin/bitcoin . GitHub
12:23 < wumpus> remember, qt is essentially single-threaded
12:23 < wumpus> at least the GUI part
12:24 < fanquake> We are still talking about fixing this right #16296 ?
12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS . Issue #16296 . bitcoin/bitcoin . GitHub
12:24 < wumpus> I'm talking about the fix in #17120
12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag . Pull Request #17120 . bitcoin/bitcoin . GitHub
12:24 < MarcoFalke> provoostenator: I thought that #17135 fixes it, but that isn't tagged for backport
12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag . Pull Request #17135 . bitcoin/bitcoin . GitHub
12:25 < wumpus> MarcoFalke: we're not sure that that fixes it, and it's too risky to merge between RCs imo
12:25 < fanquake> Right, 17120 will close 16296
12:25 < provoostenator> MarcoFalke: for the freeze UI problem there were two seperate solutions, I only tested 17120, which fixes it
12:25 < MarcoFalke> Ah nice
12:26 < fanquake> So should 17120 be high-prio, and once it's merged we tag an rc2 ?
12:26 < fanquake> Or do we have other rc blockers?
12:26 < wumpus> sgtm
12:27 < promag> provoostenator: wat?
12:27 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
12:27 < wumpus> #17035, though tagged 0.19.0 is definitely not a blocker imo
12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler . Pull Request #17035 . bitcoin/bitcoin . GitHub
12:27 < wumpus> it's also nowhere near ready
12:27 < MarcoFalke> provoostenator: If that is the case, the pull should mention it somewhere
12:27 < promag> 17120 fixes UI freeze?
12:27 < MarcoFalke> yeah, I am doubtful as well
12:28 < emilengler> wumpus: The current text is a bit misleading IMO
12:28 < emilengler> Same with storage etc.
12:28 < MarcoFalke> emilengler: Is it a regression?
12:28 < wumpus> emilengler: yes, it is, I don't disagree 
12:28 < MarcoFalke> If not, it can go in 0.19.1
12:28 < provoostenator> Oh wait, #17133 fixes those, argh
12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/17133 | 0.19: gui: Fix start timer from non QThread by promag . Pull Request #17133 . bitcoin/bitcoin . GitHub
12:28 < promag> IMO both 17120 and 17135 should go to RC
12:29 < sipa> #17135
12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag . Pull Request #17135 . bitcoin/bitcoin . GitHub
12:29 < provoostenator> What sipa says, that's the one I tested. Indeed that needs to go in the rc too 
12:30 < wumpus> I still think it's too much of a change to go in a rc, but ok...
12:30 < sipa> (to be clear i don't have a strong opinion on the issue; i was just trying to quickly check what 17135 was)
12:30 < promag> wumpus: what changes if you only merge after rc?
12:31 < wumpus> promag: it can be in master for a while
12:31 < MarcoFalke> I think the changes are straightforward (moving polling to a new thread)
12:31 < wumpus> so this creates a thread per wallet?
12:31 < MarcoFalke> What could possibly go wrong?
12:31 < wumpus> yes, what could possibly go wrong...
12:31 < promag> wumpus: no, one thread only
12:31 < sipa> last week we discussed reverting the change that exacerbated the issue; i assume that's considered too complicated?
12:32 < promag> ClientModel is singleton I think?
12:32 < wumpus> clientmodel is
12:32 < MarcoFalke> sipa: I think a lot more can go wrong when we remove all the lock annotations in validation/mempool
12:32 < promag> sipa: not a clean revert by far
12:32 < MarcoFalke> and restore the 0.18.0 mempool locks
12:32 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds]
12:32 < fanquake> sipa: At least in my opinion, reverting a mempool related bug fix to "fix" the gui doesn't seem like the way to go.
12:32 < sipa> MarcoFalke: that's fair
12:32 < MarcoFalke> agree with fanquake
12:32 < promag> too many lock annotations and other refactors were merged
12:33 < wumpus> yes, the revert is a mess
12:33 < sipa> ok
12:33 < MarcoFalke> With the gui fix the worst that could happen is that the polling in the new thread just does not work at all?
12:33 < promag> well I guess its ok too have a UI freezing in a RC
12:33 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
12:33 < wumpus> a lot can go wrong with qt and threads
12:34 < MarcoFalke> I don't know a lot about qt, so I should probably shut up
12:34 < promag> In this particular case I think it's fine - threading with loading wallets etc was more tricky
12:34 < wumpus> like, if you update the GUI from any thread but the GUI thread, you risk a race/crash
12:34 < MarcoFalke> crash doesn't sound too nice
12:35 < wumpus> it's worse than a temporary hang anyhow
12:36 < wumpus> anyhow, I think what 17135 does is correct
12:36 < wumpus> it only emits signals from the thread right?
12:36 < promag> right
12:36 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:37 < wumpus> wait, no, it's not correct
12:38 < promag> acquires the locks -> reads -> enqueues signal events to gui event loop -> repeat
12:38 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev
12:38 < wumpus> you move pollTimer to the thread then in the destructor, delete it in the main thread
12:38 < MarcoFalke> Is there anything we need to do about this macOS crap?
12:38 < wumpus> no I'm not 100% sure about this
12:38 < MarcoFalke> #16387
12:38 < gribble> https://github.com/bitcoin/bitcoin/issues/16387 | macOS Catalina . Issue #16387 . bitcoin/bitcoin . GitHub
12:38 < promag> wumpus: that's fine the thread is alread stopped
12:38 < wumpus> promag: I don't think that makes it ok
12:38 < provoostenator> So macOs requires ./configure CFLAGS="-fno-stack-check"
12:38 < fanquake> MarcoFalke: I have not upgraded to 10.15, so someone else will have to comment
12:39 < wumpus> e.g. the timer affects the local event loop of the thread
12:39 < provoostenator> For secp256k1 tests to pass
12:39 < wumpus> deleting it somewhere else might mess with the main event loop
12:39 < provoostenator> No idea if that's a sane config flag.
12:39 < promag> but I stop and join the thread
12:39 < wumpus> I know
12:39 < promag> so the timer's event-loop is no longer running
12:40 < wumpus> but things need to be deleted inthe thread that owns them
12:40 < promag> yes, if the event loop is running
12:40 < wumpus> no, always
12:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
12:40 < promag> ref?
12:40 -!- jcorgan_ [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Ping timeout: 240 seconds]
12:41 < promag> I can change to deleteLater(); quit(); wait() if you prefer
12:41 < wumpus> I'd rather have that you find for sure that this is safe
12:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:41 < promag> wumpus: deal
12:41 < wumpus> we've had some horrible crashes due to things like this w/ the debug console thread
12:42 < wumpus> it takes some very careful steps there to delete everything in the thread that owns it
12:42 < wumpus> provoostenator: what does no-stack-check do?
12:42 -!- Venom80 [5323bc56@gateway/web/cgi-irc/kiwiirc.com/ip.83.35.188.86] has quit [Remote host closed the connection]
12:43 < provoostenator> No idea, elichai2 found this "fix" in https://github.com/bitcoin-core/secp256k1/issues/674
12:43 < wumpus> it doesn't disable any hardening features does it?
12:44 < elichai2> provoostenator: I hope this bug will be fixed before the stable release
12:44 < wumpus> can we find out what code makes this necessary? is it a bug on our end?
12:44 < elichai2> wumpus: sounds like a weird story https://stackoverflow.com/questions/10712972/what-is-the-use-of-fno-stack-protector
12:45 < elichai2> wait it Catalina stable already?
12:45 < fjahr> elichai2: I thought this was a compiler bug!?
12:45 < fjahr> yes
12:45 < wumpus> yes stack protector is what protects against buffer overflows on the stack
12:45 < MarcoFalke> why can't apple fix their crap?
12:46 < provoostenator> Catalina is released yes, they even did a few security patches...
12:46 < elichai2> fjahr: sounds like a compiler bug. https://forums.developer.apple.com/thread/121887 https://trac.ffmpeg.org/ticket/8073
12:46 < elichai2> but I don't have a mac to try and dive deep into this
12:46 < wumpus> we're definitely not going to disable that by default, if people want to use such a work-around they're on their own
12:46 < elichai2> wumpus: +1
12:46 < provoostenator> The gitian / rc binaries work fine, so I indeed wouldn't change anything there.
12:47 < elichai2> My comment was more as a step in debugging this :) I really don't know the consequences of actually using this 
12:47 < elichai2> the bug is in AVX assembly *produced by the compiler* (i.e. secp has no avx)
12:47 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
12:48 < wumpus> ok, nothing for us to do there then
12:48 < elichai2> isn't it possible to just compile clang on Mac OS and use all of the llvm ecosystem instead of xcode?
12:48 < elichai2> but yeah, off topic
12:49 < wumpus> any other topics?
12:50 < wumpus> #endmeeting
12:50 < lightningbot> Meeting ended Thu Oct 24 19:50:16 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:50 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.html
12:50 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.txt
12:50 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.log.html
12:50 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
12:51 < jeremyrubin> I guess it's fine for post meeting; but I wanted to get examples/edge cases people know of bad mempool behaviors that justify the limits currently and collect any tests people have written to benchmark this
12:51 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:52 < jeremyrubin> Because I think there's a bit of a documentation gap for why certain limits exist and the intended protection (or, if additional protections conferred became known post-hoc)
12:52 < instagibbs> Unfortunately lots of mempool design is communal knowledge spread among like 5 people.
12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:52 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #17243: tools: add PoissonNextSend method that returns mockable time (master...1910-mockable-poisson) https://github.com/bitcoin/bitcoin/pull/17243
12:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:52 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
12:54 < jeremyrubin> instagibbs: this is one way to fix it ;) 
12:55 < wumpus> jeremyrubin: oh sorry I forgot your topic
12:55 < instagibbs> I'm concept ACKing your call. I've previously asked for a "philosophy of design" type document, sdaftuar wrote something(now I cannot find the link, oops) 
12:55 < wumpus> jeremyrubin: maybe propose it for next week
12:55 < instagibbs> oh here we go jeremyrubin https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Design-Philosophy
12:56 < instagibbs> that seems to be more block related, but transaction gossiping would be a good one
12:56 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
12:58 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 264 seconds]
12:59 < wumpus> elichai2: it looks like -fno-stack-check disables stack alignment check, not security checks like the stack protector
13:00 < wumpus> hm or maybe not, I'm not sure
13:00 < elichai2> well theoretically x86 is fine with unaligned reads/writes. altough I have no idea if it's even related to this :D
13:01 < wumpus> I think there's an exception for some instructions like AVX2
13:01 < sipa> movdqa requires aligned arguments
13:01 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
13:04 < elichai2> <elichai2> the bug is in AVX assembly *produced by the compiler* (i.e. secp has no avx)
13:05 < elichai2> wumpus: oh. you meant about read alignments. sorry
13:05 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
13:05 < wumpus> thinking of it, it might generate that AVX code to check the stack cookie
13:06 < wumpus> assuming the stack pointer is aligned
13:06 -!- thoragh [~thoragh@78-72-178-138-no79.tbcn.telia.com] has quit []
13:08 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:10 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
13:11 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
13:12 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:14 < sdaftuar> instagibbs: i also have some high level slides lying around somewhere that explain mempool design if you're interested
13:15 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
13:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
13:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 252 seconds]
13:18 < instagibbs> sure
13:20 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
13:21 -!- JJ34 [d9925277@217.146.82.119] has quit [Remote host closed the connection]
13:24 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
13:27 -!- jarthur [~jarthur@207.114.244.5] has quit []
13:29 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:29 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:30 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
13:33 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev
13:34 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 245 seconds]
13:34 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
13:34 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:35 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
13:35 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
13:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
13:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
13:46 -!- JeremyCrookshank [d9925277@217.146.82.119] has quit [Remote host closed the connection]
13:46 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
13:47 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
13:48 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:50 -!- JJ34 [d9925277@217.146.82.119] has joined #bitcoin-core-dev
13:57 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
13:57 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:00 -!- MarkusH1 [~MarkusH@185.204.1.185] has quit []
14:00 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving]
14:02 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
14:02 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:03 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
14:05 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:05 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
14:05 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Client Quit]
14:08 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
14:09 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
14:12 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
14:13 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:17 -!- b_b1 [~b_b@185.169.255.76] has joined #bitcoin-core-dev
14:19 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
14:20 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:22 -!- JJ34 [d9925277@217.146.82.119] has quit [Remote host closed the connection]
14:22 < jonatack> jeremyrubin: Thanks, it seems like a good idea to assemble this information, building on jnewbery's document instagibbs linked to and sdaftuar's slides. I'd be interested.
14:26 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
14:26 < elichai2> I just tried to convert `DecodeDumpTime` from using boost to `std::get_time` and chrono. and got into timezone rabbit hole
14:26  * elichai2 facepalm
14:26 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:27 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4af044716952...773026044f9d
14:28 < bitcoin-git> bitcoin/master 5b44a75 Sebastian Falbesoner: refactor: Remove unused CExt{Pub,}Key (de)serialization methods
14:28 < bitcoin-git> bitcoin/master 7730260 MarcoFalke: Merge #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization meth...
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization methods (master...20191021-refactor-remove_unused_cextkey_and_cextpubkey_serialization) https://github.com/bitcoin/bitcoin/pull/17212
14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:30 < MarcoFalke> elichai2: when pull request?
14:30 < elichai2> C++20? lol
14:30 < MarcoFalke> Oh
14:31 < MarcoFalke> So we will never get rid of boost
14:31 < elichai2> https://en.cppreference.com/w/cpp/chrono/time_zone
14:31 < elichai2> i'm joking, trying to work on a weirder way, just really hoped I can do it using libstd
14:31 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:32 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Ping timeout: 246 seconds]
14:33 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has joined #bitcoin-core-dev
14:33 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:33 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:36 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
14:37 < luke-jr> [19:16:40] <jnewbery> Can we add #15934 to high priority? It's blocking three other PRs which add quite nice functionality (#15935, #15936, #15937) <-- more like conflciting with..
14:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky . Pull Request #15934 . bitcoin/bitcoin . GitHub
14:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky . Pull Request #15935 . bitcoin/bitcoin . GitHub
14:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15936 | WIP: Unify bitcoin-qt and bitcoind persistent settings by ryanofsky . Pull Request #15936 . bitcoin/bitcoin . GitHub
14:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15937 | WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky . Pull Request #15937 . bitcoin/bitcoin . GitHub
14:37 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection]
14:37 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection]
14:38 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
14:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Client Quit]
14:38 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:39 < luke-jr> oh, those listed are the poorly rewritten ones :/
14:39 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:39 < luke-jr> #11082 should go in instead ;)
14:39 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr . Pull Request #11082 . bitcoin/bitcoin . GitHub
14:42 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 245 seconds]
14:44 -!- rex4539 [~rex4539@2a02:587:3514:c700:5d15:24bd:fb16:8e32] has quit [Quit: rex4539]
14:46 < jonatack> luke-jr: your PR came up in the review club discussion yesterday (https://bitcoincore.reviews/15934.html). Seems PRs 11082 and 15934 ought to be reviewed concurrently then.
14:47 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:48 < luke-jr> jonatack: well, 11082 vs 15935 really; 15934 is probably rebasable
14:49 < luke-jr> 11082 has been in production use for years at this point
14:50 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:51 < jonatack> luke-jr: in https://bitcoinknots.org?
14:51 < luke-jr> yes
14:52 < luke-jr> since 2016, apparently
14:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:52 < elichai2> does boost test framework gives us a way to unit test static functions?
14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/773026044f9d...fce7c7542234
14:53 < bitcoin-git> bitcoin/master 168b781 Anthony Towns: Continue relaying transactions after they expire from mapRelay
14:53 < bitcoin-git> bitcoin/master fce7c75 MarcoFalke: Merge #16851: Continue relaying transactions after they expire from mapRel...
14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16851: Continue relaying transactions after they expire from mapRelay (master...201909-relayparents) https://github.com/bitcoin/bitcoin/pull/16851
14:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:54 < MarcoFalke> elichai2: no
14:55 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
14:55 < elichai2> MarcoFalke: so if I want to add a unit test to a static function I must make it non-static?
14:55 < MarcoFalke> yes
14:55 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds]
14:55 < MarcoFalke> otherwise it wouldn't be properly linked into the test_bitcoin, I think
14:57  * luke-jr wonders if he should submit PRs for everything blocked on #11082..
14:57 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr . Pull Request #11082 . bitcoin/bitcoin . GitHub
14:57 < elichai2> MarcoFalke: well one ugly way would be to `#include` the cpp file heh
14:57 < sipa> you can test a static function if it's defined in the same compilation unit as the test
14:58 < sipa> anything else would grossly violate C++
14:58 < sipa> (that's the definition of static: accessible within the same compilation unit)
14:58 < MarcoFalke> elichai2: Oh right. Forgot about that, but I'd rather not do that.
14:58 < elichai2> sipa: so if i'm testing a static function from rpcdump.cpp in wallet_tests.cpp I must make it non static :/
14:59 < sipa> yes
14:59 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
14:59 < sipa> or put in a .h file, and make it static inline; that also works :p
14:59 < sipa> or just static;
14:59 < elichai2> MarcoFalke: yeah, that's seriously ugly and would give us trouble in the future on using the wrong types / redeclaring the same functions etc.
15:00 < luke-jr> sipa: I think we've been moving away from that?
15:00 < elichai2> I guess no static it is
15:00  * luke-jr remembers when GetMinFee was in .h
15:01 < nothingmuch> typically what is the rationale behind making things static (not in general, in core)?
15:01 < luke-jr> so the compiler cna inline it?
15:02 < elichai2> nothingmuch: I would guess if it's a small function used only in that compilation unit that you want to be easily inlined
15:02 < sipa> s/easily//
15:02 < MarcoFalke> elichai2: Which function is it?
15:02 < elichai2> core doesn't get special treatment from gcc yet :P
15:02 < elichai2> MarcoFalke: DecodeDumpTime
15:02 < elichai2> wrote a test case that asserts that the old and new ones returns the same value
15:03 < sipa> something in another compilation unit cannot be inlined (except through LTO)
15:03 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
15:03 < nothingmuch> thanks, i thought maybe it was something more... in that case wouldn't a non static wrapper also do the job?
15:04 < MarcoFalke> Yeah, that should be exposed in the header I guess
15:04 < elichai2> sipa: yeah but in the same compilation unit people tend to think(hope?) that static has more chance to be inlined
15:05 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
15:05 < MarcoFalke> for rpc code such inline performance doesn't matter
15:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
15:06 < MarcoFalke> also, the rpc*.cpp files should not contain any logic except parsing UniValue and then calling an util function
15:09 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
15:09 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds]
15:10 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e54a:392d:cc0a:581e] has quit [Quit: Sleep mode]
15:10 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-dev
15:11 < elichai2> MarcoFalke: so to which header do you think it should move? rpcwallet.h?
15:13 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
15:15 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
15:16 < MarcoFalke> That's the easiest for now
15:17 < MarcoFalke> If you feel fancy, you could move it to something like ./src/wallet/util
15:20 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
15:27 -!- ensign [~ensign@2001:41d0:8:d711::1] has quit [Quit: ZNC - http://znc.in]
15:27 -!- nsh [~lol@wikipedia/nsh] has quit [Quit: ZNC - http://znc.in]
15:30 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
15:34 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
15:36 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev
15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:38 < bitcoin-git> [bitcoin] elichai opened pull request #17245: Removing Boost from DecodeDumpTime (master...2019-10-DecodeDumpTime) https://github.com/bitcoin/bitcoin/pull/17245
15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:39 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
15:39 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
15:40 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
15:42 -!- ensign [~ensign@2001:41d0:8:d711::1] has joined #bitcoin-core-dev
15:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:43 < elichai2> Fingers crossed for the windows CI hehe
15:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:45 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:45 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
15:46 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
15:51 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
15:53 -!- marcoagner [~user@2001:8a0:6a5f:5700:7bb3:6296:d274:7295] has quit [Ping timeout: 250 seconds]
15:57 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
16:01 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
16:05 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
16:12 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
16:20 -!- lightlike [~lightlike@2001:16b8:5755:300:44e4:3af8:45cd:7840] has quit [Quit: Leaving]
16:23 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
16:27 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
16:29 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer]
16:29 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
16:30 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
16:35 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
16:39 -!- arik_ [~arik@c-24-5-126-13.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz...]
16:43 -!- farmerwampum [~farmerwam@195.206.105.7] has quit [Ping timeout: 276 seconds]
16:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:55 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Remote host closed the connection]
16:56 -!- farmerwampum [~farmerwam@195.206.105.52] has joined #bitcoin-core-dev
17:00 -!- b_b1 [~b_b@185.169.255.76] has quit []
17:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
17:14 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 246 seconds]
17:24 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
17:37 -!- jtimon [~quassel@22.133.134.37.dynamic.jazztel.es] has quit [Quit: gone]
17:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
17:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:48 -!- flaburgan1 [~flaburgan@172.83.40.52] has joined #bitcoin-core-dev
17:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
18:00 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
18:02 < roasbeef> provoostenator: responded elsewhere, but yeh I think the bip should be modified to raise back to 1k to reduce the number of round trips when catching up, the PR on the bip to move from 1k to 100 was merged w/o any comments, iirc bitcoin has settings to limit upload on a per peer basis as well which can kick in, as it's no diff from spamming a perry with getblocks/getdata messages
18:09 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.6]
18:16 -!- jamesl22_ [~james@185.58.225.100] has quit [Quit: WeeChat 1.4]
18:17 -!- jamesl22 [~james@185.58.225.100] has joined #bitcoin-core-dev
18:17 -!- Highway62 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
18:18 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 240 seconds]
18:18 -!- Highway62 is now known as Highway61
18:22 -!- Highway62 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
18:23 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 240 seconds]
18:25 -!- Highway62 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 240 seconds]
18:29 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 240 seconds]
18:48 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
18:53 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Remote host closed the connection]
19:02 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
19:06 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 240 seconds]
19:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 240 seconds]
19:09 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
19:13 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
19:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
19:27 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
19:40 -!- felixfoertsch23 [~felixfoer@2001:16b8:5062:400:f130:4739:c850:391] has joined #bitcoin-core-dev
19:42 -!- felixfoertsch [~felixfoer@i6DFA647E.versanet.de] has quit [Ping timeout: 240 seconds]
19:44 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
19:44 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
19:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:45 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
19:48 -!- Highway61 [~Thunderbi@96.44.145.186] has quit [Ping timeout: 265 seconds]
19:49 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has joined #bitcoin-core-dev
19:50 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
19:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
20:00 -!- flaburgan1 [~flaburgan@172.83.40.52] has quit []
20:12 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
20:17 -!- dfkt [~dfkt@141.98.102.179] has joined #bitcoin-core-dev
20:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
20:23 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
20:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
20:30 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has quit [Remote host closed the connection]
20:32 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has joined #bitcoin-core-dev
20:46 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
21:02 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
21:03 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:03 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
21:06 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
21:11 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
21:14 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
21:31 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
21:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 250 seconds]
21:39 -!- captjakk [~captjakk@174-16-221-137.hlrn.qwest.net] has quit [Remote host closed the connection]
21:41 -!- felixfoertsch23 [~felixfoer@2001:16b8:5062:400:f130:4739:c850:391] has quit [Quit: ZNC 1.7.3 - https://znc.in]
21:42 -!- felixfoertsch [~felixfoer@2001:16b8:5062:400:d496:31d4:98a0:f3e5] has joined #bitcoin-core-dev
21:45 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:50 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
22:02 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
22:03 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
22:05 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
22:07 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
22:18 -!- roconnor [~roconnor@host-104-157-204-21.dyn.295.ca] has quit [Ping timeout: 268 seconds]
22:26 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
22:28 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
22:36 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
22:38 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
22:42 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
22:45 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
22:59 -!- Highway61 [~Thunderbi@96.44.145.186] has joined #bitcoin-core-dev
23:00 -!- dfkt [~dfkt@141.98.102.179] has quit []
23:03 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #bitcoin-core-dev
23:12 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
23:15 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
23:17 -!- gnomus [~gnomus@185.103.96.143] has joined #bitcoin-core-dev
23:30 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:35 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
23:37 -!- felixfoertsch [~felixfoer@2001:16b8:5062:400:d496:31d4:98a0:f3e5] has quit [Quit: ZNC 1.7.3 - https://znc.in]
23:37 -!- felixfoertsch [~felixfoer@2001:16b8:5062:400:10ba:d356:7a1b:7ccb] has joined #bitcoin-core-dev
23:46 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has joined #bitcoin-core-dev
23:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:51 -!- koti [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 260 seconds]
23:53 -!- cryptoIndio [~cryptoInd@42-200-238-108.static.imsbiz.com] has quit [Ping timeout: 268 seconds]
--- Log closed Fri Oct 25 00:00:44 2019