--- Log opened Thu Nov 07 00:00:02 2019
00:00 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 250 seconds]
00:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 245 seconds]
00:20 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has joined #bitcoin-core-dev
00:26 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
00:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
00:36 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has quit [Remote host closed the connection]
00:36 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev
00:40 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit []
00:47 -!- marcoagner [~user@bl13-33-51.dsl.telepac.pt] has joined #bitcoin-core-dev
00:52 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
00:52 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has quit [Remote host closed the connection]
00:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:54 -!- b10c [~Thunderbi@mue-88-130-54-143.dsl.tropolys.de] has joined #bitcoin-core-dev
00:59 -!- kabaum [~kabaum@185.224.57.161] has quit [Ping timeout: 240 seconds]
01:00 -!- Guest80066 [~Lurker69@89.238.178.75] has quit []
01:01 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has joined #bitcoin-core-dev
01:02 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has quit [Remote host closed the connection]
01:02 -!- kljasdfvv [~flack@p200300D46F014C000546CD66C7919329.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
01:05 -!- potatoe_1ace [~potatoe_f@157.230.27.253] has quit [Quit: leaving]
01:05 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
01:11 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Quit: leaving]
01:11 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
01:17 -!- Perceptes [~Perceptes@141.98.102.179] has joined #bitcoin-core-dev
01:18 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Quit: leaving]
01:18 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
01:20 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:21 -!- potatoe_face [~potatoe_f@157.230.27.253] has quit [Client Quit]
01:41 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has joined #bitcoin-core-dev
01:41 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has quit [Client Quit]
01:42 -!- Producer [cb6f0445@203.111.4.69] has joined #bitcoin-core-dev
01:52 -!- Producer [cb6f0445@203.111.4.69] has quit [Remote host closed the connection]
01:52 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #bitcoin-core-dev
01:53 -!- kabaum [~kabaum@93.182.128.34] has joined #bitcoin-core-dev
02:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:09 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]
02:19 < promag> jonatack: hi, https://github.com/bitcoin/bitcoin/pull/17283/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR949
02:20 < promag> Why "an"?
02:22 < real_or_random> promag: "nrequired" starts with a vowel sound
02:22 -!- baldur [~baldur@pool-100-2-132-165.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
02:22 < real_or_random> try to pronounce it
02:31 < promag> real_or_random: oh thats a rule? ok then ?
02:31 < promag> ty
02:46 -!- kljasdfvv [~flack@p200300D46F014C00E46E11D27C10417E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
02:54 < jonatack> promag: yes, what real_or_random said. See discussion at https://github.com/bitcoin/bitcoin/pull/16047#discussion_r285628201
02:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
02:55 < jonatack> er, that link is the inverse case :)
02:56 < wumpus> I tend to get that wrong too, it's a very difficult rule for non native speakers of English
03:05 -!- DannyK [7bf39ac8@123.243.154.200] has joined #bitcoin-core-dev
03:11 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
03:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds]
03:25 < jonatack> I agree it can look strange to read
03:34 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Read error: Connection reset by peer]
03:43 < wumpus> for 30 years of so I was blissfully unaware and based a/an on the simple letter-based heuristic, it worked enough for people to never complain
03:45 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has joined #bitcoin-core-dev
03:52 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
03:54 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Ping timeout: 260 seconds]
03:57 -!- kabaum [~kabaum@93.182.128.34] has quit [Ping timeout: 265 seconds]
04:00 -!- Perceptes [~Perceptes@141.98.102.179] has quit []
04:04 -!- cryptoIndio [~cryptoInd@1-64-75-023.static.netvigator.com] has quit [Quit: Leaving...]
04:10 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has joined #bitcoin-core-dev
04:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:17 -!- jaqque1 [~jaqque@89.238.178.75] has joined #bitcoin-core-dev
04:22 < elichai2> Still have some problems but look at build no. 3 :) https://travis-ci.org/elichai/bitcoin/builds/608703220
04:23 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 246 seconds]
04:24 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
04:26 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
04:28 < wumpus> elichai2: you've added a native ppc build? nice
04:29 < elichai2> yep. it's kinda undocumented, so we might need to allow it to fail (altough it works on my repos), still have some problems with the docker. but it's pretty cool
04:29 < wumpus> so they have actual POWER servers running builds? sounds expensive :)
04:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
04:31 < elichai2> wumpus: either that or a bunch of emulation stuff
04:31 < wumpus> for ARM it's not hard to believe it's real native
04:51 < luke-jr> POWER isn't that expensive either, especially for business..
04:51 < luke-jr> I built my Talos II for $3k and there's the cheaper Blackbird now
04:53 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
04:53 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev
04:53 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds]
04:54 < luke-jr> wumpus: Technically you could always use "an" and just defer to the Tonal number system (where "an" is 1)
04:54 < elichai2> if any docker wizard has any inputs on what's going on here it'll be appretiated :) (added `set -x` and some docker ls's here and there) https://travis-ci.org/elichai/bitcoin/jobs/608713371#L435
04:55 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
04:59 < wumpus> sure, but it's more expensive than x86; ARM is really really cheap so adding that was kind of low-hanging fruit
04:59 < wumpus> heh yes 
04:59 < wumpus> I don't know anything about docker, sorry
05:02 < luke-jr> wumpus: I'm sure Travis has way many more x86 than POWER though ;)
05:03 < luke-jr> (and POWER probably finishes the jobs faster to make up for it!)
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e65b4160e99f...46fc4d1a24c8
05:03 < bitcoin-git> bitcoin/master faec282 MarcoFalke: scripted-diff: test: Move setup_common to test library
05:03 < bitcoin-git> bitcoin/master fa4c6fa MarcoFalke: doc: Add documentation for new test/lib
05:03 < bitcoin-git> bitcoin/master 46fc4d1 MarcoFalke: Merge #17384: test: Create new test library
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17384: test: Create new test library (master...1911-testLib) https://github.com/bitcoin/bitcoin/pull/17384
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:07 -!- Highway61 [~Thunderbi@69.12.94.178] has joined #bitcoin-core-dev
05:12 -!- DannyK [7bf39ac8@123.243.154.200] has quit [Remote host closed the connection]
05:13 < wumpus> I don't get it, ci/lint/06_script.sh runs subtree checks for various trees, but doesn't import their master branches, how is this supposed to work?
05:13 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 240 seconds]
05:14 < wumpus> I added a new subtree in #17398 and locally the subtree checks pass, but not on travis, because it doesn't have the commit available
05:14 < gribble> https://github.com/bitcoin/bitcoin/issues/17398 | WIP: build: Update leveldb to 1.22+ by laanwj . Pull Request #17398 . bitcoin/bitcoin . GitHub
05:14 -!- jonatack [~jon@213.152.162.74] has joined #bitcoin-core-dev
05:17 < wumpus> ok added an explicit "git fetch https://github.com/google/crc32c.git master" for now, let's see...
05:18 < wumpus> #proposedmeetingtopic Move subtrees out of src/
05:19 < wumpus> or at least under a single roo
05:20 < wumpus> would be a lot easier for linters and doxugen and maintenance scripts and such if there was a single path to ignore
05:24 -!- lightlike [~lightlike@2001:16b8:573d:6a00:dcf:cdba:c6e6:c157] has joined #bitcoin-core-dev
05:25 < wumpus> e.g. https://github.com/bitcoin/bitcoin/pull/17398/commits/b9b829574c517fcbc0fbcbda67ed667b04a73899  the other option would be to have an unified exclude path, but having to specify it 10+ times is absurd
05:26 < wumpus> YESS they pass
05:31 < fanquake> guess we can wait for a bunch of rebases now that #17384 went in
05:31 < gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke . Pull Request #17384 . bitcoin/bitcoin . GitHub
05:32 < fanquake> Had been ready to merge 17342
05:32 < wumpus> same
05:36 < wumpus> ooh the native osx travis build has beer keg emojis, yes it's the first time I look at that
05:36 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
05:36 < fanquake> is that in the brew output?
05:36 < fanquake> We can turn that off if required heh
05:36 < wumpus> no, let's leave it
05:37 < fanquake> We can also customize it using HOMEBREW_INSTALL_BADGE
05:38 < wumpus> "checking for F_FULLFSYNC... no" looks like the detection is somehow not working, fullfsync is a MacOS thing right? 
05:40 < wumpus> oh, I think I understand the issue
05:49 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev
05:54 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
05:57 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:70b1:61d2:95e:e2d7] has joined #bitcoin-core-dev
05:57 < fanquake> wumpus let me know when that PR is "stable" enough to test in various places
05:59 < wumpus> fanquake: sure; it should work now on linux/windows/osx, though without crc32c acceleration
06:00 < wumpus> integrating crc32c into the build system is going to be slightly involved, there's various new things (besides sse42 support) that need to be detected
06:00 < fanquake> wumpus ok. Will do some initial testing on macOS / BSDs
06:00 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
06:00 < wumpus> most of the fixes I've pushed in the last hour or so, except for the FULLFSYNC one, were to make linters happy
06:01 < wumpus> that's how it goes right ...
06:01 < fanquake> ?
06:02 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:02 < fanquake> I've been trying to track down the file descriptor discrepancy for the past day or so. Think it's time to give up and dump the info in an issue..
06:03 < wumpus> that sometimes helps, maybe someone else has ideas
06:03 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
06:03 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection]
06:03 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
06:04 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
06:05 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 265 seconds]
06:07 -!- jonatack [~jon@213.152.162.74] has quit [Ping timeout: 264 seconds]
06:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
06:14 < wumpus> cleaned up the commits; everything besides "build: Update build system for new leveldb" (and the subtree update for src/leveldb) is related to crc32c and not necessary for build at the moment
06:14 < fanquake> cool
06:15 < wumpus> (but also shouldn't get in the way; HAVE_CRC32C is hardwired to 0 at the moment)
06:15 < fanquake> ok
06:15 < fanquake> are we discussing 0.19.0 release at the meeting this arvo? 
06:16 < wumpus> yes, we should
06:16 < wumpus> I think it's ready, nothing else has come up with the last rc
06:17 < fanquake> Yep.
06:17 < fanquake> One final thing we probably want to do is at least add a note to the release notes in regards to macOS Catalina users having to "right click" and open.
06:17 < fanquake> Might avoid some potential confusion.
06:17 < wumpus> yes, definitely
06:17 < fanquake> That's all I'll say in regards to macOS atm.
06:21 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
06:23 < fanquake> Can anyone remember in which PR sdaftuar mined a commit hash to have 6-7 leading 0s ?
06:24 < fanquake> or it might actually have been marco
06:24 < aj> fanquake: "git log 000000" should tell you, #13510
06:24 < gribble> https://github.com/bitcoin/bitcoin/issues/13510 | Scripts and tools: Obsolete #!/bin/bash shebang by DesWurstes . Pull Request #13510 . bitcoin/bitcoin . GitHub
06:24 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:25 < fanquake> aj cheers. Guess I completely mis-remembered 
06:26 < aj> fanquake: marcofalke has a shorter one in #14264 by the looks
06:26 < gribble> https://github.com/bitcoin/bitcoin/issues/14264 | doc: Split depends installation instructions per arch by MarcoFalke . Pull Request #14264 . bitcoin/bitcoin . GitHub
06:26 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 265 seconds]
06:27 < fanquake> aj thanks for both. 14264 doesn't have any ACK comments, so I'll use 13510
06:27 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-dev
06:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]
06:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
06:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
06:42 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
06:47 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 276 seconds]
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46fc4d1a24c8...46e0e276398e
06:47 < bitcoin-git> bitcoin/master 3c84dee Aaron Clauson: Updated appveyor config:
06:47 < bitcoin-git> bitcoin/master 46e0e27 MarcoFalke: Merge #17364: Updates to appveyor config for VS2019 and Qt5.9.8 + msvc pro...
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17364: Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:48 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
06:54 -!- fox2p [~fox2p@185.212.170.51] has quit [Ping timeout: 245 seconds]
06:54 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
06:55 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
06:56 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
06:57 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
06:57 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
07:00 -!- jaqque1 [~jaqque@89.238.178.75] has quit []
07:01 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 265 seconds]
07:01 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:70b1:61d2:95e:e2d7] has quit [Quit: Sleep mode]
07:03 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:70b1:61d2:95e:e2d7] has joined #bitcoin-core-dev
07:03 < elichai2> FIxed the docker problem. I'm now getting `conftest.cpp:32:10: fatal error: sys/endian.h: No such file or directory`
07:07 < wumpus> sorry, your system is middle-endian so lacks the endian header :-)
07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/46e0e276398e...7d14e35f3fb7
07:08 < bitcoin-git> bitcoin/master d995762 John Newbery: [tests] Don't use TestingSetup in the checkqueue_tests
07:08 < elichai2> so that's fine? I guess that's not the actual error. there's too much noise, i'll remove the `set -x` now
07:08 < bitcoin-git> bitcoin/master 5506ecf John Newbery: [refactor] Replace global int nScriptCheckThreads with bool
07:08 < bitcoin-git> bitcoin/master 7d14e35 MarcoFalke: Merge #17342: refactor: Clean up nScriptCheckThreads
07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17342: refactor: Clean up nScriptCheckThreads (master...2019-11-nScriptCheckThreads-comment) https://github.com/bitcoin/bitcoin/pull/17342
07:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:17 -!- wjp1 [~wjp@141.98.102.235] has joined #bitcoin-core-dev
07:18 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
07:19 -!- Lexyon_ [uid402723@gateway/web/irccloud.com/x-ulfnuqlgujkvpltq] has joined #bitcoin-core-dev
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d14e35f3fb7...772673dfbe70
07:20 < bitcoin-git> bitcoin/master fae43a9 MarcoFalke: test: Seed test RNG context for each test case, print seed
07:20 < bitcoin-git> bitcoin/master 772673d MarcoFalke: Merge #16978: test: Seed test RNG context for each test case, print seed
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16978: test: Seed test RNG context for each test case, print seed (master...1909-testSeed) https://github.com/bitcoin/bitcoin/pull/16978
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:23 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:70b1:61d2:95e:e2d7] has quit [Quit: Sleep mode]
07:29 -!- Highway61 [~Thunderbi@69.12.94.178] has quit [Ping timeout: 268 seconds]
07:29 -!- kabaum [~kabaum@ec2-52-212-246-229.eu-west-1.compute.amazonaws.com] has quit [Ping timeout: 240 seconds]
07:41 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
07:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
07:54 < fanquake> #proposedmeetingtopic not so much a topic, but a reminder that if everyone wants to air / dump their GitHub grievances into #15847, I'll be discussing with GH next week
07:54 < gribble> https://github.com/bitcoin/bitcoin/issues/15847 | Feedback for GitHub CEO . Issue #15847 . bitcoin/bitcoin . GitHub
07:54 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Ping timeout: 245 seconds]
08:01 < elichai2> Getting frustrated. at this point any help would be wellcome. I can't figure out why this test is failing :/ https://travis-ci.org/elichai/bitcoin/jobs/608789848
08:01 < elichai2> ci script: https://github.com/elichai/bitcoin/blob/2019-11-powerpc64/ci/test/00_setup_env_powerpc64.sh
08:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:02 < fanquake> elichai2 a test, or the depends build of OpenSSL ?
08:04 < fanquake> We use 'Configure' to configure OpenSSL in depends, looks like it's suggesting to use ./config instead. I'd assume Configure is bombing out for some reason
08:05 < elichai2> so why will it fail only on here?
08:05 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:05 < elichai2> (maybe the tests shouldn't use the depends and add the incompatible db flag?)
08:05 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer]
08:06 -!- Eric3 [~exeric3@178.132.3.92] has joined #bitcoin-core-dev
08:06 < fanquake> I'd guess no one has tested a depends build with a powerpc64le-unknown-linux-gnu HOST before, and haven't run into the OpenSSL configure failure
08:06 -!- ExEric3 [~exeric3@178.132.3.92] has quit [Ping timeout: 252 seconds]
08:08 < elichai2> fanquake: what do you think, should I try fighting it (replacing Configure with `./config` or just not use the depends?)
08:08 < fanquake> elichai2 I'm going to spin up a container and take a quick look in a second.
08:08 < fanquake> In any case hopefully OpenSSL will be gone soon
08:08 < elichai2> k. i'll for now try without depends to see if any other erros come up that are more directly related to bitcoin
08:11 < elichai2> if you have a local container with ppc64le feel free to debug a Docker bug i've found that made me replace `library/ubuntu` with `ppc64le/ubuntu:18.04`
08:14 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
08:21 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has joined #bitcoin-core-dev
08:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: No route to host]
08:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:24 -!- shesek [~shesek@185.3.145.80] has joined #bitcoin-core-dev
08:24 -!- shesek [~shesek@185.3.145.80] has quit [Changing host]
08:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:26 -!- fox2p_ [~fox2p@82.102.24.187] has joined #bitcoin-core-dev
08:27 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-dev
08:28 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 264 seconds]
08:29 -!- emilengler [~emilengle@2a02:8108:8200:1c80:4001:46af:1f83:608e] has joined #bitcoin-core-dev
08:29 -!- kabaum [~kabaum@185.224.57.161] has joined #bitcoin-core-dev
08:30 -!- emilengler [~emilengle@2a02:8108:8200:1c80:4001:46af:1f83:608e] has quit [Client Quit]
08:30 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
08:48 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving]
08:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:52 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
08:53 -!- laurentmt [~Thunderbi@92.223.89.146] has joined #bitcoin-core-dev
08:53 < fanquake> elichai2 I've recreated your issue locally with HOST=powerpc64le-unknown-linux-gnu. OpenSSLs ./Configure fails. ./config detects ppc64le-whatever-linux2 and will configure for linux-generic32
08:54 < elichai2> fanquake: does that mean it's working, `linux-generic32` doesn't sound good hehe
08:55 < elichai2> (it's still building with no depends https://travis-ci.org/elichai/bitcoin/jobs/608821982)
08:55 < fanquake> I assume linux-ppc64 is what we should be passing to ./Configure, but I don't know what detection is failing
08:55 < fanquake> that openSSL doens't figure that out.
08:58 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
08:59 -!- IGHOR [~quassel@93.178.216.72] has quit [Client Quit]
09:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:00 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/772673dfbe70...270616228bc9
09:00 < bitcoin-git> bitcoin/master 6d50b26 Jon Atack: test: add logging to wallet_avoidreuse.py
09:00 < bitcoin-git> bitcoin/master 0e7c90e Jon Atack: test: speed up wallet_avoidreuse.py
09:00 < bitcoin-git> bitcoin/master 2706162 fanquake: Merge #17362: test: speed up wallet_avoidreuse, add logging
09:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:00 < elichai2> hmmm `/home/travis/build/elichai/bitcoin/build/bitcoin-powerpc64le-unknown-linux-gnu/src/compat/glibc_compat.cpp:75: undefined reference to `log2f_old'`
09:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:00 < bitcoin-git> [bitcoin] fanquake merged pull request #17362: test: speed up wallet_avoidreuse, add logging (master...wallet_avoidreuse-test-improvements) https://github.com/bitcoin/bitcoin/pull/17362
09:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:01 < elichai2> oh. we have no ifdef for powerpc
09:02 < elichai2> I thought luke-jr / BlueMatt  are testing/using PowerPC
09:04 -!- laurentmt [~Thunderbi@92.223.89.146] has quit [Quit: laurentmt]
09:06 < elichai2> i'll try dropping `--enable-glibc-back-compat`
09:07 < BlueMatt> I work daily on ppc64, though I dont daily build bitcoin core
09:07 < BlueMatt> at least not latest master
09:08 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
09:11 -!- kabaum [~kabaum@185.224.57.161] has quit [Ping timeout: 252 seconds]
09:20 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
09:20 -!- michaelfolkson [~textual@62.60.62.11] has joined #bitcoin-core-dev
09:20 -!- IGHOR [~quassel@93.178.216.72] has quit [Client Quit]
09:24 < MarcoFalke> #14066 might fix the depends issue
09:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr . Pull Request #14066 . bitcoin/bitcoin . GitHub
09:27 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
09:29 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 276 seconds]
09:34 -!- ExtraCrispy [~ExtraCris@185.51.134.195] has joined #bitcoin-core-dev
09:35 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
09:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
09:45 < MarcoFalke> elichai2: The functional tests are a bit slow. You might just disable them for now
09:45 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
09:46 < elichai2> MarcoFalke: you're saying the failure is a timeout?
09:46 < MarcoFalke> you 120 seconds rpc timeout
09:46 < MarcoFalke> *yeah,
09:46 < elichai2> it sucks that travis doesn't cache if the build fails :/ I need it to succeed at least once so i'll have faster builds lol
09:47 < elichai2> MarcoFalke: so I should not run them?
09:47 < MarcoFalke> https://travis-ci.org/elichai/bitcoin/jobs/608838438#L8203
09:47 < MarcoFalke> You may also bump the timeouts
09:47 < elichai2> I guess that's a change to the test framework though?
09:47 < MarcoFalke> Idk. I kept bumping them for years
09:48 < elichai2> or is there a env variable?
09:48 < MarcoFalke> Maybe we should remove the timeout
09:48 < MarcoFalke> They are hardcoded in the individual test files
09:48 < elichai2> k. i'll start by making this work *without* functional. so I can open a PR and document what works and what doesn't, and then look into timeouts
09:49 < MarcoFalke> self.rpc_timeout = 120
09:50 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 240 seconds]
09:52 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
09:55 -!- michaelfolkson [~textual@62.60.62.11] has quit [Quit: Sleep mode]
09:57 -!- ExtraCrispy [~ExtraCris@185.51.134.195] has quit [Quit: ExtraCrispy]
09:59 < wumpus> elichai2: you're not basing it on luke-jr's PR? I thought that was the idea
09:59 < elichai2> :O
09:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
10:00 -!- wjp1 [~wjp@141.98.102.235] has quit []
10:01 < elichai2> #14066? 
10:01 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr . Pull Request #14066 . bitcoin/bitcoin . GitHub
10:02 < wumpus> yes
10:02 < wumpus> would be nice to have that in for 0.20
10:02 < elichai2> It's been a year, hmm the only thing there that's related is the glibc_compact. But I assume the CI will increase people's confidence in that PR? 
10:03 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:04 < wumpus> helping test and review it would increase confidence in the PR, just asking because you care about ppc apparently :)
10:05 -!- michaelfolkson [~textual@62.60.62.11] has joined #bitcoin-core-dev
10:06 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
10:06 < wumpus> and yes I don't think it makes sense to add a travis run for a platform we don't distribute binaries for
10:06 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
10:06 < wumpus> unless it's a big endian platform, would be nice to have a big-endian travis run no matter what
10:07 < sipa> wumpus: (not sure where to comment) your leveldb commit 180296c359ba248ae6f2a6094098a22fd31994d6 drops a few 'override' modifiers for no reason, i think
10:07 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
10:07 < wumpus> sipa: oh that's not intentional, thanks
10:08 -!- jarthur_ is now known as jarthur
10:08 < sipa> also in 415ad71a96070dd4989153a800e6fd969269590b's commit message you have a typo in your own name
10:08 < sipa> (i think!)
10:08 < elichai2> wumpus: I don't even have ppc, was just excited that I found this new Travis feature, and always looking for ways to contribute :) 
10:10 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 240 seconds]
10:10 < wumpus> sipa: thanks, will fix
10:12 -!- michaelfolkson [~textual@62.60.62.11] has quit [Quit: Sleep mode]
10:12 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:14 < sipa> the patchset for leveldb seems amazingly small now
10:14 < sipa> and entirely upstreamable?
10:16 < wumpus> sipa: yes, I think it's eventually upstreamable
10:17 < sipa> this is great :)
10:17 < wumpus> already had to make a patch on top on crc32c too, build system related, https://github.com/bitcoin-core/crc32c/commit/a3f2c1c13051d922cef031aec505801462080579 but should be upstreamable too I think
10:17 < sipa> we're using the cmake buildsystem for crc32c?
10:17 < wumpus> no :)
10:17 -!- Dogechain [~Dogechain@89.238.178.75] has joined #bitcoin-core-dev
10:18 < sipa> then why does your patch modify CMakeLists.txt?
10:18 < fanquake> Glad we don't have too
10:18 < wumpus> I've integrated crc32c into the build system in the same way as leveldb, this requires being able to pass defined manually instead of having this .h file
10:18 < wumpus> because cmake uses that .h.in file to provide configuration
10:18 < sipa> oh i see, to make sure things don't break for when people build the patched tree using cmake
10:18 < wumpus> I don't, but don't want to break their buid system...
10:18 < wumpus> yes
10:19 < sipa> of course
10:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:21 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:22 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:22 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:23 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:23 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:24 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:24 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:24 < wumpus> I have sse42 already working locally (it's not in the PR yet), now trying to get ARM64 crc32c to work
10:25 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:25 < wumpus> it's easy just have to convert the cmake detection to autoconf (it doesn't help I don't really know either very well though :)
10:25 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:25 < sipa> nobody does.
10:25 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:26 < wumpus> true.
10:26 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:26 -!- captjakk [~captjakk@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:28 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
10:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:38 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
10:39 -!- thoragh [~victor@78-72-178-138-no79.tbcn.telia.com] has joined #bitcoin-core-dev
10:41 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
10:44 -!- soju__ [~soju@2601:640:8780:6d90:8d5f:7c5a:ed4:a0bf] has quit [Remote host closed the connection]
10:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
10:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:51 < MarcoFalke> is the meeting in 9 minutes?
10:52 < fanquake> *8 minutes
10:53 < wumpus> I think so
10:53 < wumpus> date -u shows it's 18:53 so yea
10:55 -!- Guest32182 [~PC@host-36.58.217.201.copaco.com.py] has joined #bitcoin-core-dev
10:56 -!- Guest32182 [~PC@host-36.58.217.201.copaco.com.py] has quit [Client Quit]
11:00 -!- kvaciral [~kvaciral@185.198.57.211] has joined #bitcoin-core-dev
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Nov  7 19:00:29 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < kanzure> hi
11:00 < gleb> hi
11:00 < jonatack> bonsoir
11:00 < jnewbery> hi
11:00 < dongcarl> saluton
11:01 < digi_james> hi
11:01 < fanquake> hi
11:01 < provoostenator> hi
11:01 < wumpus> #topic 0.19.0 final
11:01 < meshcollider> hi
11:01 < sipa> hi
11:02 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
11:02 < wumpus> jeremyrubin lightlike
11:02 < jamesob> hi
11:02 < fanquake> #17079 #16996
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/17079 | v0.19.0 testing . Issue #17079 . bitcoin/bitcoin . GitHub
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/16996 | Release process for 0.19.0 . Issue #16996 . bitcoin/bitcoin . GitHub
11:02 < fanquake> Does anyone have new issues to report after testing rc3?
11:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
11:02 < wumpus> I haven't heard of any new problems coming up with rc3, so it's probably time to tag final?
11:02 < instagibbs> hi
11:03 < fanquake> ACK. I haven't seen anything new either.
11:03 < achow101> hi
11:03 < fanquake> Also: https://github.com/bitcoin/bitcoin/milestone/37
11:03 < wumpus> well, first moving the release notes back to the branch from the wiki
11:04 < fanquake> and adding the macOS catalina note
11:04 < wumpus> so if anyone wants to do any last minute edits in the release notes, now would be the time
11:05 < MarcoFalke> ship it
11:05 < wumpus> yess
11:05 < fanquake> ?
11:06 < provoostenator> Ship it!
11:06 < arik_> ?
11:06 < wumpus> #topic High priority for review
11:06 < fanquake> I guess we could shift topics then?
11:06 < wumpus> https://github.com/bitcoin/bitcoin/projects/8
11:06 < wumpus> 7 blockers, 7 things chasing ACK
11:06 < wumpus> I think that's already a perfect number so let's move on
11:07 < BlueMatt> proposed topic: one last question blocking rust progress
11:07 < wumpus> (anything to add/remove?)
11:07 < achow101> add #17373 pls
11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 . Pull Request #17373 . bitcoin/bitcoin . GitHub
11:08 < wumpus> achow101: ok, added
11:08 < fanquake> Only PR I'd suggest adding is #17270. I have some new comments to make there, and think it could be split up to aid review, but could use more eyes regardless.
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
11:08 < gleb> I think there is some valuable discussion is going on here: #17326. Not sure it's a particularly high-prio, but I think it's worth looking at for whoever missed. It's about whether we should keep (some) p2p connections on a node restart or connect to new peers.
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/17326 | rfc, p2p: Eclipse attack mitigation . Issue #17326 . bitcoin/bitcoin . GitHub
11:08 < gleb> It's not even mine :P
11:09 < wumpus> it doesn't have to be to propose it
11:10 < wumpus> but yea, that would be more like a proposed meeting topic than something for review
11:10 < fanquake> Should we move onto a proposed topic? This might be a quick meeting for once.
11:11 < fanquake> is nickler or instagibbs here?
11:11 < gleb> I don't think at this point we need real-time discussion, as long as the conversation is happening there on github. Just wanted to bring a bit attention of everyone.
11:11 < MarcoFalke> fanquake: https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
11:11 < wumpus> fanquake: I think everyone is already looking at #17270
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
11:11 < wumpus> happy with adding that to high prio, though
11:11 < MarcoFalke> Also, wumpus had another topic
11:11 < wumpus> yes
11:12 < fanquake> wumpus: if everyone is looking at it, I'm surprised there hasn't been more commentary
11:12 < wumpus> quite a lot of topics this week, let's move on
11:12 < wumpus> #topic security email address for bitcoin-core/secp256k1 (nickler)
11:12 < sipa> real_or_random, nickler: here?
11:13 < wumpus> https://github.com/bitcoin-core/secp256k1/pull/679
11:13 < nickler> hi
11:13 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 260 seconds]
11:13 < BlueMatt> seems like an easy solution is proposed there: add a list for secp-securiy@bitcoincore.org and add relevant folks to it?
11:14 < nickler> We're adding a SECURITY.md file to the bitcoin-core/secp256k1 repo and considered secp256k1-security@bitcoincore.org as security email address.Would it be possible to add such an email address? How are we making sure that security contacts will actually get emails forwarded to them? Who can see the content of a vulnerability report if it's sent unencrypted?
11:14 < BlueMatt> I presume wumpus can do that?
11:14 < wumpus> yes, I can make a forward address on bitcoin-core.org
11:14 < BlueMatt> dig +short bitcoincore.org mx
11:14 < BlueMatt> 10 spool.mail.gandi.net.
11:14 < wumpus> just tell me who to include
11:14 < wumpus> doesn't have to be in the meeting :p
11:14 < nickler> wumpus: cool, will do in private
11:15 < sipa> we'd need to put it on the bitcoincore.org website as well, i think
11:15 < sipa> together with gpg keys of some/all of the people involved
11:15 < wumpus> sure
11:15 < BlueMatt> sounds good, next topic?
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:15 < bitcoin-git> [bitcoin] elichai opened pull request #17402: Travis support for PowerPC64 (master...2019-11-powerpc64) https://github.com/bitcoin/bitcoin/pull/17402
11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:15 < wumpus> #topic opt-in SRD (instagibbs)
11:16 < wumpus> #17331
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 . Pull Request #17331 . bitcoin/bitcoin . GitHub
11:17 < achow101> instagibbs wanted to ask whether we should consider making SRD something that is opt in instead of outright replacing the current knapsacksolver fallback
11:17 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has quit [Quit: Leaving]
11:17 < wumpus> could at least initially do that I guess
11:17 < gleb> Is it assumed that everybody knows what does SRD stand for?
11:17 < achow101> so people who care could set some switch to use srd as the fallback so that we aren't breaking things too much
11:17 < sipa> gleb: single random draw
11:18 < wumpus> replacing it is goig to be much more controversial than adding a new method
11:18 < achow101> but I don't think anyone would opt in because what user knows that srd is or really cares about the coin selection algo details?
11:18 < achow101> My current pr for srd is to actually use both knapsack and srd, then choose the one that produces the "better" solution
11:18 < wumpus> it's something that needs to be tested/evaluate over a long period 
11:18 < achow101> although defining "better" is non-trivial
11:18 < wumpus> people that want to test it can enable it
11:19 < achow101> i'm not convinced that people are going to test it
11:19 < wumpus> you mean, no one?
11:20 < meshcollider> Probably lol
11:20 < wumpus> that's a dangerous statement, if you think no one cares, why work on it?
11:20 < sipa> a possibility could be to run both, and add a debug log that tells you what SRD would have done instead
11:21 < achow101> I would guess that the people who would test it are not the same people who make enough transactions for it to matter
11:21 < wumpus> that doesn't matter
11:21 < sipa> there's a big difference between people in general being interested in a feature ("better coin selection" i think certainly qualified) and people with both the technical means and in a situation where they can provide good feedback
11:21 < jonatack> perhaps it needs awareness raised about it? via bitcoin optech, forums, etc.
11:21 < achow101> then there's no meaningful results or feedback
11:21 < wumpus> though it might mean you need to convince people that make enough transactions to test it, maybe
11:22 < wumpus> that's easier if it's an option
11:22 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
11:22 < wumpus> I don't think we can have this discussion without anyone arguing to add it
11:23 < wumpus> let's move to next topic
11:23 < wumpus> #topic Subtree organization and linters (wumpus)
11:23 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-axqlnmdvalazbwek] has joined #bitcoin-core-dev
11:24 < fanquake> linters ?
11:24 < wumpus> so while trying to add crc32c to the tree (because the new leveldb uses that), I've noticed that the exceptions to linting are spread all over the place
11:24 < wumpus> I think it'd be useful to move subtrees to one place in the tree
11:25 < sipa> yes!
11:25 < MarcoFalke> Linters shouldn't be a reason to move source code around
11:25 < BlueMatt> ack
11:25 < wumpus> so that doxygen knows to avoid it, linters know to avoid it, etc
11:25 < gleb> broke: minting; woke: linting
11:25 < MarcoFalke> But I agree it makes sense even absent of linters
11:25 < BlueMatt> mostly cause putting them in one place is clean from a "this isnt our code, you should know that" human pov
11:25 < BlueMatt> but, yea, my preference for anything where linters come up is to remove them :)
11:26 < wumpus> soo
11:26 < wumpus> look at this commit: https://github.com/bitcoin/bitcoin/pull/17398/commits/50c86bfc0bfb44c3962b681320aee8d54fc8614d
11:26 < MarcoFalke> wumpus: Any reason to not run doxygen on it?
11:26 < wumpus> I had to change 10 places (and more) just to add one subtree
11:26 < wumpus> MarcoFalke: because it's not our code
11:26 < wumpus> I don't want general google documentation in our doxygen
11:26 < jonasschnelli> Can't attend the meeting today...
11:27 < wumpus> it's meant to document bitcoin core, not leveldb, or a crc32 library
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:27 < bitcoin-git> [bitcoin] fanquake opened pull request #17403: doc: reintegrate 0.19.0 release notes (0.19...reintegrate_relnotes_019) https://github.com/bitcoin/bitcoin/pull/17403
11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:27 < MarcoFalke> ok, fine
11:27 < wumpus> do you think it would not only be clutter?
11:28 < wumpus> in any case that leaves the linters and everything
11:28 < wumpus> I think a mess now
11:29 < wumpus> it took me an hour or so to find them all
11:29 < MarcoFalke> #action Move subtrees to one place
11:29 < sipa> it seems ctaes and secp256k1 are included in doxygen, though
11:30 < wumpus> that's probably accidental
11:30 < jnewbery> an alternative would be to have an exclude.txt file in the linter directory and have all linters read from there
11:30 < wumpus> it's also easy to forget one
11:31 < jnewbery> (not saying we shouldn't change code organization structure, just agree with Marco that it shouldn't be driven by satisfying the linters)
11:31 < wumpus> yes, that's also possible
11:31 < wumpus> oh I agree
11:31 < sipa> or have a directory subtrees with all the subtrees? :)
11:31 < fanquake> another alternative would be to just remove all the linters, as they seem to take up a disproportionate amount of everyones time ?
11:32 < MarcoFalke> fanquake: Not having them also takes up time, unfortunately (as we recently saw)
11:32 < jnewbery> Concept ACK directory subtrees with subtrees
11:32 < jamesob> something something baby bathwater
11:32 < wumpus> FWIW doxygen input is already generated using automake so it'd be trivial to generate it from a central list
11:32 < wumpus> the linters are shell scripts all over the place 
11:33 < BlueMatt> ignoring linters, I think its a good idea to put them all in one place, and it looks like no one materially disagreed?
11:33 < wumpus> using different ways to scan the tree
11:33 < wumpus> so that's more work...
11:33 < BlueMatt> so...next topic?
11:33 < fanquake> I have a real quick topic if there aren't any others left
11:33 < BlueMatt> i haz topic
11:33 < MarcoFalke> It is going to change all includes. Incoming merge conflicts
11:33 < wumpus> #topic rust in bitcoin core (BlueMatt)
11:34 < wumpus> MarcoFalke: yes, it's a mess to clean up a mess
11:34 < MarcoFalke> lol
11:34 < BlueMatt> one question about the rust stuff that wasn't answered in the last meeting (#16834)...in the last meeting the conclusion was "why merge if not shipped by default", so I set it as default, and this added a new question...if you dont have rustc installed, should configure fail, or just warn and not build rust.
11:34 < BlueMatt> cfields made the point that this results in silently building binaries with significantly different feature sets than release ones, which feels super strange, but I figure folks will complain if suddenly master stops building for them cause rustc is required unless you say --disable-rust. thoughts?
11:34 < gribble> https://github.com/bitcoin/bitcoin/issues/16834 | Fetch Headers over DNS by TheBlueMatt . Pull Request #16834 . bitcoin/bitcoin . GitHub
11:35 < BlueMatt> other than this it seems that pr is Ready to Go (tm)
11:35 < jamesob> seems pretty aggressive to me to require rustc by default
11:35 < wumpus> but if someone wants to fix the linters to use a central exclude list that's fine with me too ,anyhow, I really don't know what's the best solution here, but I think something needs to change
11:35 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
11:36 < fanquake> I don't think rustc should be a requirement to build master, I also agree that silently failing to build new feature sets feels like the wrong behaviour.
11:36 < wumpus> also I didn't really like including crc32c in our main src directory, it's kind of indirect
11:36 < wumpus> something like /src/external would be better
11:36 < sipa> why not just leave the rust stuff off by default?
11:36 < wumpus> yes, leave the rust stuff off by default, at least initially
11:36 < BlueMatt> sipa: you're three meetings late on that one :p
11:37 < sipa> yeah, haven't paid much attention to that
11:37 < sipa> but i don't see why that isn
11:37 < sipa> 't the obvious solution
11:37 < jnewbery> Sorry, I also missed the 'on by default' decision
11:37 < BlueMatt> well I mean we could also leave it off by default, but there was strong agreement to have it on by default in 0.20
11:37 < BlueMatt> I dont think there were any voices that disagreed with that
11:37 < promag> hi
11:37 < jnewbery> BlueMatt: do you have a link? Struggling to find it in my scrollback
11:37 < wumpus> I haven't seen that
11:38 < wumpus> I like to merge *some* rust code by 0.20
11:38 < BlueMatt> (built by default, not, like, making new network calls by default at runtime, that is)
11:38 < wumpus> I think it's best to have it disabled by default initally
11:38 < meshcollider> Maybe the "strong agreement" was just everyone missing the discussion :p
11:38 < jamesob> and just to clarify, there's no way that a failure in any of the rust subsystems can cascade over to the other processes, right?
11:38 < BlueMatt> (in case that was the confusion)
11:38 < wumpus> it's always possible to change a default
11:38 < wumpus> but you're going to have a merge harder time getting it merged it you want to require it
11:38 < BlueMatt> yes, jamesob, that is (to my knowledge) true.
11:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:39 < fanquake> #17090 some default discussion in here
11:39 < gribble> https://github.com/bitcoin/bitcoin/issues/17090 | RFC: Rust code integration . Issue #17090 . bitcoin/bitcoin . GitHub
11:39 < BlueMatt> wumpus: I personally dont want to require it, my preference was just "on if you have rustc available"
11:39 < BlueMatt> but cfields pointed out this felt....strange
11:39 < BlueMatt> cause you would just silently get things that had different feature sets from release
11:39 < wumpus> I like explicit configuration flags, but anyhow
11:39 < promag> BlueMatt: isnt that the same as with qt?
11:40 < jamesob> I think in general whenever we release major new features they should be opt-in (if possible) for a few releases to iron out kinks
11:40 < BlueMatt> you mean ./configure flags, anything written so far has to be opt-ed in at runtime
11:40 < sipa> promag: but Qt is actually built and enabled by default in release builds
11:40 < BlueMatt> promag: maybe zmq is a better example, at least with qt you just totally miss the bitcoin-qt binary
11:40 < meshcollider> why not off unless you have --enable-rust then?
11:40 < BlueMatt> jamesob: you mean opt-in, or not built-in, cause those are different
11:40 < wumpus> I'm not sure why this is such a big issue, just leave it experimental for the first release and only activated with a flag
11:41 < jamesob> BlueMatt: I mean available but disabled by default
11:41 < wumpus> this can always be chagned later
11:41 < fanquake> I feel like an explicit opt into rust stuff for 0.20.0 is ok. That would be the same as all this new android stuff. None of that is going to be anything other than explicitly opt in for a while
11:41 < promag> +1 fanquake
11:41 < wumpus> fanquake: exactly
11:41 < BlueMatt> wumpus: I'm confused, you mean on by default at runtime or built by default
11:41 < sipa> by default don't compile it in
11:41 < wumpus> it's much *easier* to merge things if they're introduced that way
11:41 < BlueMatt> same goes for fanquake...
11:42 < wumpus> disabled in the compile by default
11:42 < jnewbery> wumpus: +1
11:42 < jamesob> +1
11:42 < fanquake> BlueMatt I mean if you want to do rust things, do ./configure --enable-rust, and that's the only time it's used
11:42 < BlueMatt> lol wumpus i distinctly recall the opposite thought last meeting
11:42 < BlueMatt> but, ok, I can undo all those changes...
11:42 < BlueMatt> fanquake: lol you too...
11:42 < jnewbery> BlueMatt: no-one else remembers. I can't see any agreement in the Oct 10 meeting
11:43 < promag> BlueMatt: just to be clear, you suggest to enable if rustc is available?
11:44 < wumpus> I'm not sure having rustc in your path should change anything automatically to bitcoin configuration 
11:44 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
11:44 < BlueMatt> yea, that was cfields' objection, which seems strange
11:45 < wumpus> but than again, I like explicit configuration options, I hate 'intelligent' software trying to second-guess me in general, so :)
11:45 < wumpus> any other topics?
11:45 < promag> I think it's fair to expect a first-time thing to be opt-in
11:45 < fanquake> I have one in regards to #15847
11:46 < gribble> https://github.com/bitcoin/bitcoin/issues/15847 | Feedback for GitHub CEO . Issue #15847 . bitcoin/bitcoin . GitHub
11:46 < wumpus> #topic github feedback (fanquake)
11:46 < fanquake> Basically just for everyone to dump any more thoughts they have into that thread, as the (in person) discussions with GitHub are happening early next week.
11:46 < wumpus> BlueMatt: let' sjust aim to get some rust code in, the default discussion is really something that can be left for later and only confuses the intial merge I think
11:47 < fanquake> There have already been some discussions in repos in GitHub in which I've started bringing up some of our suggestions.
11:47 < BlueMatt> right, ok, I'll just turn it off by default and we can have this conversation again post-merge.
11:47 < wumpus> yes, maybe in a major release or two
11:47 < promag> wumpus: I have one topic: cmd notify queue
11:47 < fanquake> Seems that some of the maintainers from other projects, which include some people from Rust core, agree with some of our concerns/issues.
11:48 < fanquake> That was all though. If you have any thoughts you don't wont to post in the issue, feel free to get in touch with me directly.
11:48 < sipa> fanquake: come say hi when you're in the bay area
11:48 < fanquake> sipa: will do
11:49 < wumpus> #topic cmd notify queue (promag)
11:49 < promag> so -walletnottify and -blocknotify spawn a thread which in turn call system()
11:50 < promag> and sometimes that can lead to some load - but that's not the issue now
11:50 < wumpus> you want an unbounded queue instead of a fork bomb :)
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:50 < bitcoin-git> [bitcoin] sipsorcery opened pull request #17404: Remove redundant class file include from test_bitcoin msvc project (master...msvc_test) https://github.com/bitcoin/bitcoin/pull/17404
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:50 < wumpus> launching processes for notifications was always a bad idea
11:51 < promag> well, that can't be changed I guess
11:51 < wumpus> definitely if they happen often enough to consider things like that
11:51 < wumpus> well if it's just every 10 minutes no one complains
11:51 < promag> while replacing with boost::process I've noticed that the pace of process spawning is shorter
11:51 < wumpus> if it's a high frequency noticication you should use another mechanism
11:52 < promag> so I wonder wdyt about adding some queue
11:52 < promag> which has de bonus of guaranteeing order
11:53 < promag> also, the advantage is to avoid command line placeholders
11:53 < wumpus> that adds latency, also people expect the thread to run free (so keeping a command running doesn't block bitcoind), so  you can't guarantee much
11:53 < promag> and pass vars via env
11:54 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: BBL]
11:54 < promag> wumpus: I think that if a command does that now I will have problems anyway
11:54 < promag> *it will
11:54 < wumpus> right now, it creates a new thread an starts the command in that
11:55 < promag> right, but if the command doesn't quit you end up with lots of threads?
11:55 < wumpus> if you want to create say, a single-threaded worker queue for notifications, that does change how it works
11:55 < wumpus> I'm sure it needs to quit some time
11:56 < promag> would you nack that?
11:56 < wumpus> I think it's a unnecessary change
11:56 < wumpus> how it is now works for the people that use the current mechanism
11:56 < wumpus> if you want more, use zmq
11:56 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 265 seconds]
11:57 < wumpus> you're not going to make a system that supports high frequency notifications with process spawning
11:58 < promag> my problem is that in #13339 if I use boost::process notifications are slowly handled 
11:58 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag . Pull Request #13339 . bitcoin/bitcoin . GitHub
11:58 < wumpus> why?
11:58 < wumpus> is boost process so inefficient? what does it do differently?
11:58 < promag> my guess is that because internally it has to guard getenv/send etc
11:58 < promag> setenv
11:58 < sipa> how does a queue help?
11:59 < wumpus> promag: why?
11:59 < wumpus> you can provide an environment when you exec
11:59 < wumpus> there's no need to ever call setenv
11:59 < wumpus> in a multi-threaded process you definitely don't want to use that
11:59 < promag> at a lower level those calls aren't thread safe
12:00 < wumpus> there are thread safe calls at a low leven
12:00 < wumpus> l
12:00 < wumpus> oh, it's time
12:00 < wumpus> #endmeeting
12:00 < lightningbot> Meeting ended Thu Nov  7 20:00:28 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:00 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-07-19.00.html
12:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-07-19.00.txt
12:00 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-07-19.00.log.html
12:00 < sipa> #lunch
12:00 < promag> sipa: adopting a queue to guarantee order doesn't fix that, but in turn its no longer a problem :P
12:00 < wumpus> promag: man execvpe
12:01 < jnewbery> wumpus: MarcoFalke: meshcollider: 15931 I think is ready for merge. ACKs on 36b68de from ryanofsky, jnewbery, jkczyz, promag
12:01 < MarcoFalke> #15931
12:01 < promag> ill dig a little more, ty
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard . Pull Request #15931 . bitcoin/bitcoin . GitHub
12:02 < meshcollider> jnewbery: sweet I'll take a look today
12:02 < jnewbery> thanks!
12:03 < wumpus> promag: sorry to be so cynical but the way you way that, the more I hear people talking about boost::process the more I start thinking that it's a bad idea to start using it
12:03 -!- soju__ [~soju@2601:640:8780:6d90:58df:79:3066:256e] has joined #bitcoin-core-dev
12:04 < wumpus> things like thread safe calls for process spawning have been solved in the 90's, it's not some magic new technology
12:05 < promag> The execvpe() function is a GNU extension.
12:05 < promag> from https://www.systutorials.com/docs/linux/man/3-execvpe/
12:07 < promag> wumpus: https://pastebin.com/9KT2qyHG
12:07 < wumpus> so do you need to override the environemtn?
12:07 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-dev
12:08 -!- soju__ [~soju@2601:640:8780:6d90:58df:79:3066:256e] has quit [Ping timeout: 245 seconds]
12:08 < wumpus> we've always passed things as arguments
12:08 < promag> wumpus: escaping issues
12:09 < wumpus> wait
12:09 < promag> and honestly do you prefer that over env vars?
12:09 < wumpus> you're talking about low-level process spawning right?
12:09 < wumpus> escaping issues are a shell thing
12:09 < jeremyrubin> Oh
12:10 < jeremyrubin> Meeting....
12:10 < wumpus> if you don't invovle the shell, so spawn a process directly, you're not going to have escaping issues
12:10 < wumpus> this is similar to python subprocess.Popen with shell=True versus shell=False
12:10 < wumpus> yes, I prefer arguments to environment variables
12:10 < ryanofsky> wumpus, on windows you have escaping issues without a shell because processes are starting with a single string, not an array of strings, and the c runtime library parses that into an argv array
12:11 < wumpus> environment variables are for global state
12:11 < wumpus> if you need to pass arguments to a process, the preferred way to do that is to use arguments
12:12 < promag> wumpus: what I usually see is if something has to launch a process with a custom configuration then env vars is the choice - honestly I don't recall seeing placeholders
12:12 < promag> like %s
12:12 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Ping timeout: 276 seconds]
12:13 < promag> anyway, I'll try to see what is slowing boost::process:spawn
12:14 < wumpus> ryanofsky: I have no idea about windows
12:14 < promag> I really dislike %w, and there's the windows "'issue'", that's why I'm trying with boost::process
12:14 < wumpus> POSIX already confuses me enough,thanks
12:14 < wumpus> let's look it up though
12:15 < promag> yup, I don't think this stuff too.. but walletnotify lacks support for multiwallet
12:16 < wumpus> which brings me back to, please use another notification mechanism
12:16 < promag> wumpus: we don't support zmq in the wallet
12:16 < wumpus> spawning processes is OS specific madness
12:16 < promag> right
12:16 < wumpus> in a sandboxed env you might not even be allowed to do that
12:17 < wumpus> promag: maybe we should!
12:17 < promag> I think that good solutions is a) some PR for longpoll by jonasschnelli b) push to some amqp
12:19 -!- Skirmant [~Skirmant@mobile-access-bcee1c-167.dhcp.inet.fi] has joined #bitcoin-core-dev
12:20 < promag> problem with a) you need a long poll for each wallet
12:20 < wumpus> so to be clear I'm not arguing to remove walletnotify etc, if the load is low enough that spawning processes is good enoguh, then it's good enough, but I don't think it's worth spending a lot of work to improve/change it, especially incompatibly or movingthings to environment variables etc
12:21 < promag> wumpus: right, I'm ok with last decision - just support %w in linux/mac
12:21 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
12:21 < wumpus> so why is wallet zmq not a thing?
12:21 < wumpus> why notwork on that instead?
12:21 -!- Skirmant [~Skirmant@mobile-access-bcee1c-167.dhcp.inet.fi] has quit [Client Quit]
12:21 < promag> ?\_(?)_/?
12:22 < promag> I think that was discussed before
12:22 < wumpus> okay
12:22 < promag> if the subscriber is down then you miss notifications?
12:22 < promag> I don't remember
12:22 < sipa> zmq is only useful as a "you need to poll right now" mechanism
12:22 < wumpus> I don't think spawning processes is 100% guaranteed either
12:22 < sipa> you need to poll at startup/intermittently anyway; zmq helps reduce your latency
12:23 < wumpus> it's extremely hard, maybe impossible to make a notification mechanism that is 100% loss proof
12:23 < promag> so the zmq message is (new stuff in wallet x, bye)
12:23 < wumpus> sipa: right
12:23 < wumpus> and it includes sequence numbers so you know if you missed something
12:24 < wumpus> (maybe use a block chain for your notifications *ducks)
12:24 < promag> that's so 2010..
12:26 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #bitcoin-core-dev
12:34 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Read error: Connection reset by peer]
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/270616228bc9...2fb6140d585f
12:42 < bitcoin-git> bitcoin/master b80f7db Aaron Clauson: Remove redundant class file includes from test_bitcoin project.
12:42 < bitcoin-git> bitcoin/master 2fb6140 fanquake: Merge #17404: Remove redundant class file include from test_bitcoin msvc p...
12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:43 < bitcoin-git> [bitcoin] fanquake merged pull request #17404: Remove redundant class file include from test_bitcoin msvc project (master...msvc_test) https://github.com/bitcoin/bitcoin/pull/17404
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
13:00 -!- Dogechain [~Dogechain@89.238.178.75] has quit []
13:01 -!- kvaciral [~kvaciral@185.198.57.211] has quit [Quit: leaving]
13:01 -!- thoragh [~victor@78-72-178-138-no79.tbcn.telia.com] has left #bitcoin-core-dev []
13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17405: wallet: Remove unused boost::this_thread::interruption_point (master...1911-walletNoBoost) https://github.com/bitcoin/bitcoin/pull/17405
13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:12 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
13:13 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
13:17 -!- wltjr1 [~wltjr@192.145.126.115] has joined #bitcoin-core-dev
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:18 < bitcoin-git> [bitcoin] BlockMechanic opened pull request #17406: Fix http server (master...fix-http-server) https://github.com/bitcoin/bitcoin/pull/17406
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:18 < bitcoin-git> [bitcoin] BlockMechanic closed pull request #17406: Fix http server (master...fix-http-server) https://github.com/bitcoin/bitcoin/pull/17406
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:33 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-axqlnmdvalazbwek] has quit [Quit: Connection closed for inactivity]
13:38 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Quit: WeeChat 2.5]
13:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
13:46 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
13:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:48 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17407: Add MempoolInstance() to get the current mempool (master...1911-txPoolOptional) https://github.com/bitcoin/bitcoin/pull/17407
13:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:53 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
13:53 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
13:53 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
13:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:16 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has joined #bitcoin-core-dev
14:22 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has quit [Ping timeout: 276 seconds]
14:23 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has quit [Remote host closed the connection]
14:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:23 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev
14:27 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
14:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
14:35 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has joined #bitcoin-core-dev
14:36 -!- b10c [~Thunderbi@mue-88-130-54-143.dsl.tropolys.de] has quit [Ping timeout: 264 seconds]
14:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17408: Replace assert with ASSERT (master...1911-assertASSERT) https://github.com/bitcoin/bitcoin/pull/17408
14:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:40 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has quit [Ping timeout: 264 seconds]
14:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
14:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:51 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #17408: Replace assert with ASSERT (master...1911-assertASSERT) https://github.com/bitcoin/bitcoin/pull/17408
14:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:52 -!- pinheadmz [~matthewzi@5.181.233.92] has quit [Quit: pinheadmz]
15:02 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has joined #bitcoin-core-dev
15:22 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev
15:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:33 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 276 seconds]
15:35 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Read error: Connection reset by peer]
15:39 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev
16:00 -!- wltjr1 [~wltjr@192.145.126.115] has quit []
16:03 -!- marcoagner [~user@bl13-33-51.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
16:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
16:16 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds]
16:16 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:38 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 240 seconds]
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17409: build: Avoid hardcoded libfaketime dir in gitian (master...1911-gitianArm64) https://github.com/bitcoin/bitcoin/pull/17409
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:43 -!- tronical1 [~tronical@89.238.178.75] has joined #bitcoin-core-dev
16:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
17:06 -!- soju [uid403160@gateway/web/irccloud.com/x-xbxryqnnquoemlev] has joined #bitcoin-core-dev
17:07 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
17:22 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has joined #bitcoin-core-dev
17:27 -!- soju__ [~soju@2601:640:8780:6d90:b0d0:665d:73a2:d119] has quit []
17:30 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has quit [Ping timeout: 268 seconds]
17:32 < wumpus> nice, travis is green for leveldb+crc32b
17:32 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has joined #bitcoin-core-dev
17:33 < sipa> wumpus: \o/
17:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
17:55 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8f4:48b5:f75a:b75f] has quit [Quit: Sleep mode]
18:08 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
18:12 -!- lightlike [~lightlike@2001:16b8:573d:6a00:dcf:cdba:c6e6:c157] has quit [Quit: Leaving]
18:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
18:36 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
19:00 -!- tronical1 [~tronical@89.238.178.75] has quit []
19:12 -!- felixfoertsch23 [~felixfoer@2001:16b8:50c1:f100:91d:b12b:f153:ede7] has joined #bitcoin-core-dev
19:13 -!- felixfoertsch [~felixfoer@2001:16b8:501a:8100:91d:b12b:f153:ede7] has quit [Ping timeout: 246 seconds]
19:17 -!- mkrautz1 [~mkrautz@172.83.40.52] has joined #bitcoin-core-dev
19:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
19:33 -!- pinheadmz [~matthewzi@184.75.212.188] has joined #bitcoin-core-dev
19:59 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has joined #bitcoin-core-dev
20:18 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
20:48 -!- rachelfish [~rachel@unaffiliated/itsrachelfish] has joined #bitcoin-core-dev
20:58 -!- pinheadmz [~matthewzi@184.75.212.188] has quit [Quit: pinheadmz]
21:07 -!- nosss2 [nosss2@gateway/vpn/privateinternetaccess/nosss2] has quit [Remote host closed the connection]
21:21 -!- felixfoertsch23 [~felixfoer@2001:16b8:50c1:f100:91d:b12b:f153:ede7] has quit [Quit: ZNC 1.7.3 - https://znc.in]
21:21 -!- felixfoertsch [~felixfoer@2001:16b8:50c1:f100:7da1:821:357:7d39] has joined #bitcoin-core-dev
21:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
21:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
22:00 -!- mkrautz1 [~mkrautz@172.83.40.52] has quit []
22:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:14 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 245 seconds]
22:19 -!- bastion-tester [~satoshi@pool-108-21-84-253.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]
22:31 -!- bastion-tester [~satoshi@pool-108-21-84-253.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
22:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
22:39 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
22:45 -!- armin76 [~armin76@195.206.169.238] has joined #bitcoin-core-dev
23:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
23:23 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Quit: ZNC 1.7.4 - https://znc.in]
23:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:29 < bitcoin-git> [bitcoin] laanwj opened pull request #17410: Rename `db` log category to `walletdb` (like `coindb`) (master...2019_11_rename_db_log_category) https://github.com/bitcoin/bitcoin/pull/17410
23:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
--- Log closed Fri Nov 08 00:00:02 2019