--- Log opened Tue Jan 07 00:01:01 2020
00:07 -!- RandolfR [~randolf@184.70.10.188] has joined #bitcoin-core-dev
00:07 -!- RandolfR is now known as Randolf
00:08 -!- Randolf [~randolf@184.70.10.188] has quit [Client Quit]
00:09 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
00:28 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
00:42 -!- Kiminuo [~mix@141.98.103.220] has joined #bitcoin-core-dev
00:56 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has quit [Ping timeout: 240 seconds]
00:57 -!- paultroon [~paultroon@141.98.255.147] has joined #bitcoin-core-dev
00:59 -!- marcoagner [~user@dsl-54-248.bl26.telepac.pt] has joined #bitcoin-core-dev
01:00 -!- Darki1 [~Darki@141.98.102.227] has quit []
01:01 -!- paultroon [~paultroon@141.98.255.147] has quit [Ping timeout: 260 seconds]
01:08 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Quit: leaving]
01:09 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
01:21 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev
01:33 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
01:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
01:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
01:47 -!- Mark_Cockrell [~Mark_Cock@139.28.218.198] has joined #bitcoin-core-dev
01:47 -!- kljasdfvv [~flack@p200300D46F0B250031E9FBAC20C6FF90.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
01:51 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Quit: leaving]
02:01 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev
02:01 -!- daniel_ [~quassel@konnect.k7.com] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
02:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
02:09 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
02:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
02:18 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
03:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:08 -!- kljasdfvv [~flack@p200300D46F0B2500EC79448C83489B49.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
03:09 -!- Guest83 [~textual@117.173.213.191] has joined #bitcoin-core-dev
03:10 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Remote host closed the connection]
03:13 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
03:19 < promag> ariard could be member in gh
03:26 -!- michaelfolkson [~textual@host-92-3-210-254.as43234.net] has joined #bitcoin-core-dev
03:34 -!- michaelfolkson [~textual@host-92-3-210-254.as43234.net] has quit [Quit: Sleep mode]
03:36 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
03:36 -!- Guest83 [~textual@117.173.213.191] has quit [Quit: My iMac has gone to sleep. ZZZzzz...]
03:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:40 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
03:46 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:51 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
03:51 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
03:52 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
03:53 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
03:54 -!- michaelfolkson [~textual@host-92-3-210-254.as43234.net] has joined #bitcoin-core-dev
04:00 -!- Mark_Cockrell [~Mark_Cock@139.28.218.198] has quit []
04:02 -!- michaelfolkson [~textual@host-92-3-210-254.as43234.net] has quit [Quit: Sleep mode]
04:16 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection]
04:17 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 268 seconds]
04:17 -!- Morgon1 [~Morgon@195.206.183.79] has joined #bitcoin-core-dev
04:21 -!- michaelfolkson [~textual@46.233.77.205] has joined #bitcoin-core-dev
04:22 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
04:29 -!- joncoe [joncoe@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev
04:39 -!- jonatack [~jon@213.152.161.170] has joined #bitcoin-core-dev
04:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
04:47 -!- paultroon [~paultroon@141.98.255.144] has joined #bitcoin-core-dev
04:54 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
05:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:03 -!- tryphe_ is now known as tryphe
05:06 -!- felixfoertsch [~felixfoer@2001:16b8:50fd:3c00:30ed:e9f8:35a8:fc6c] has quit [Ping timeout: 260 seconds]
05:09 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
05:13 -!- Guest83 [~textual@117.173.213.191] has joined #bitcoin-core-dev
05:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:16 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:18 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
05:27 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 268 seconds]
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:28 < bitcoin-git> [bitcoin] kallewoof opened pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:28 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] xyephy opened pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:31 < bitcoin-git> [bitcoin] fanquake closed pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:46 -!- felixfoertsch [~felixfoer@2001:16b8:50fd:3c00:30ed:e9f8:35a8:fc6c] has joined #bitcoin-core-dev
05:49 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:56 < bitcoin-git> [bitcoin] promag opened pull request #17889: wallet: Improve CWallet:MarkDestinationsDirty (master...2020-01-wallettx-iscacheempty) https://github.com/bitcoin/bitcoin/pull/17889
05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 258 seconds]
06:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
06:26 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev
06:26 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host]
06:26 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
06:30 -!- Kiminuo [~mix@141.98.103.220] has quit [Ping timeout: 268 seconds]
06:37 -!- jonatack [~jon@213.152.161.170] has quit [Read error: Connection reset by peer]
06:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:41 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:41 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
06:45 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
07:00 -!- Morgon1 [~Morgon@195.206.183.79] has quit []
07:03 -!- promag [~promag@31.22.146.210] has joined #bitcoin-core-dev
07:15 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds]
07:17 -!- DARKNE55 [~DARKNE55@89.238.178.75] has joined #bitcoin-core-dev
07:17 -!- michaelfolkson [~textual@46.233.77.205] has quit [Quit: Sleep mode]
07:17 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds]
07:20 -!- michaelfolkson [~textual@46.233.77.205] has joined #bitcoin-core-dev
07:20 -!- michaelfolkson [~textual@46.233.77.205] has quit [Client Quit]
07:27 -!- ctrlbreak_MAD is now known as ctrlbreak
07:40 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
07:45 -!- promag [~promag@31.22.146.210] has quit [Remote host closed the connection]
07:48 < kallewoof> Why would bitcoin core reopen old rev files after closing their blk files? #17890
07:48 < gribble> https://github.com/bitcoin/bitcoin/issues/17890 | Non-latest rev files are sometimes re-opened but never re-flushed . Issue #17890 . bitcoin/bitcoin . GitHub
07:49 < sipa> kallewoof: rev files are written at activation time, which is not the same time as the blocks are written
07:49 < sipa> (not sure that explains what you're seeing, though0
07:49 < kallewoof> sipa: we need to flush them afterwards then. maybe always flush after each write, if it is not the current one
07:49 < kallewoof> sipa: i am seeing 2 separate bugs. 1 bug is that we over-allocate by (file size) amount, and 2nd is that we are not flushing afterwards, leaving some of the rev files in the overblown-size state.
07:50 < sipa> hmm, we don't mark block index entries dirty when the corresponding block is activated/deactivated?
07:50 < kallewoof> sipa: we only ever flush a undo file when we close its block file.
07:50 < kallewoof> sipa: "Leaving block X" is when we flush both blk and rev. Never again after that
07:50 < sipa> ah, that seems wrong
07:51 < sipa> i'll have a look
07:52 -!- Guest83 [~textual@117.173.213.191] has quit [Quit: Textual IRC Client: www.textualapp.com]
08:19 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
08:27 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
08:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
08:28 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:28 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex (master...2001-c2-CC) https://github.com/bitcoin/bitcoin/pull/17891
08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:33 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving]
08:34 < kallewoof> sipa: ok. I'm looking too
08:36 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:40 < kallewoof> sipa: I think part of the issue is that blocks are stored to disk and there is a lag between that and the block being connected (probably due to sig checks / utxo etc), and since undo data is written then (at activation time as you said), the system will move on to the next block file but the activation will still be working against the previous one.
08:41 < kallewoof> I saw the first encounter of 'write to an older rev file' right after closing block file 0, which said it had 'heights=0...119975', but right before that line there was an UpdateTip new best for height 119963, and my code broke when it was about to find undo pos for height 119965.
08:42 < kallewoof> s/broke/hit my breakpoint/g
08:43 < kallewoof> looks like a decent fix here is to flush the blk/undo when the activation occurs (as well, probably, to cover both cases).
08:43 < kallewoof> i mean, when the activation goes from 'X' to 'X+1' in terms of the block file #.
08:58 < sipa> kallewoof: iirc we only have one set of "dirty" files which are synced at flush time, which covers both blk and rev files
08:58 < sipa> it seems we'll need to split that up
09:01 < kallewoof> sipa: there is a setDirtyBlockIndex which is then chucked at a txdb.cpp method which writes a bunch. It's not immediately clear to me if those are the rev/blk or the index stuff.
09:01 < kallewoof> the only place we flush (truncate to actual used size) the blk/rev is in that one place in validation.cpp. there is another place which calls but with finalize=false which doesn't do that.
09:02 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Ping timeout: 268 seconds]
09:05 -!- promag [~promag@31.22.146.210] has joined #bitcoin-core-dev
09:05 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
09:05 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Quit: Leaving]
09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
09:10 < sipa> kallewoof: ah right
09:11 -!- pinheadmz [~matthewzi@185.217.69.132] has quit [Read error: Connection reset by peer]
09:13 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
09:17 -!- promag [~promag@31.22.146.210] has quit [Remote host closed the connection]
09:19 -!- promag [~promag@31.22.146.210] has joined #bitcoin-core-dev
09:27 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:27 -!- promag [~promag@31.22.146.210] has quit [Remote host closed the connection]
09:37 -!- paultroon [~paultroon@141.98.255.144] has quit [Remote host closed the connection]
09:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
09:48 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
09:53 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 258 seconds]
09:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
09:55 < kallewoof> Contrary to what the block file tostring() would have you believe, it seems that blocks are not actually in a strict range inside the blk files. I see block 119776 in blk1 and 119777 in blk0. 
09:58 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:59 < goatpig_> hasnt been the case since header first
10:00 -!- DARKNE55 [~DARKNE55@89.238.178.75] has quit []
10:00 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:00 < kallewoof> i have a sorta working patch but it needs to be reworked around the fact blocks are jumbled. see https://github.com/kallewoof/bitcoin/tree/200108-reflush-undo
10:01 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:02 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
10:02 < kallewoof> I think the straightforward solution is to determine the last block in the old rev file beforehand and to have the write for that trigger the flush. But it's 3 am now. /waves
10:06 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:06 < bitcoin-git> [bitcoin] kallewoof opened pull request #17892: bug-fix: re-flush undo files after they have been re-opened (master...200108-reflush-undo) https://github.com/bitcoin/bitcoin/pull/17892
10:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:17 -!- derek1 [~derek@89.238.178.75] has joined #bitcoin-core-dev
10:22 -!- joncoe [joncoe@gateway/vpn/protonvpn/joncoe] has quit [Quit: Leaving]
10:34 -!- lowentropy [~lowentrop@gateway/tor-sasl/lowentropy] has quit [Remote host closed the connection]
10:39 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
10:40 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Read error: Connection reset by peer]
10:41 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
10:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
10:56 -!- Kiminuo [~mix@141.98.103.220] has joined #bitcoin-core-dev
11:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:04 < bitcoin-git> [bitcoin] IPGlider closed pull request #17884: utils: Use fallback for macOS in AllocateFileRange (master...workaround_apfs_allocation_problem) https://github.com/bitcoin/bitcoin/pull/17884
11:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Quit: Leaving]
11:12 < sipa> e er5~
11:12 < sipa> oops
11:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
11:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:51 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 258 seconds]
11:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:59 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: brb]
12:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
12:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
12:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
12:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
12:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
12:20 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
12:24 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
12:25 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
12:31 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
12:34 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
12:36 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit []
12:49 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
12:50 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Client Quit]
12:53 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
13:00 -!- derek1 [~derek@89.238.178.75] has quit []
13:02 -!- mr_paz [~mr_paz@24.14.251.223] has joined #bitcoin-core-dev
13:09 -!- mr_paz [~mr_paz@24.14.251.223] has quit [Quit: Leaving]
13:11 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-ktxierwbcwlryvgu] has joined #bitcoin-core-dev
13:17 -!- mreider [~mreider@185.169.255.76] has joined #bitcoin-core-dev
13:17 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
13:21 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
13:24 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds]
13:25 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
13:26 < jeremyrubin> Does anyone have any trouble with univalue encoding VARR types?
13:26 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
13:26 < jeremyrubin> I'm working on an RPC and I'm getting: vector::_M_range_check: __n (which is 1) >= this->size() (which is 1)
13:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
13:27 < jeremyrubin> (sidebar: the NONFATAL stuff makes debugging these sorts of problems harder, we should add flags to re-enable panic)
13:28 < sipa> it's probably good to make NONFATAL failures turn into assertion failures in debug builds
13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:32 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e8e79958a7b2...bcb4cdcca321
13:32 < bitcoin-git> bitcoin/master 0950245 Gregory Sanders: IsUsedDestination should count any known single-key address
13:32 < bitcoin-git> bitcoin/master bcb4cdc Samuel Dobson: Merge #17621: IsUsedDestination should count any known single-key address
13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:32 < bitcoin-git> [bitcoin] meshcollider merged pull request #17621: IsUsedDestination should count any known single-key address (master...actually_no_reuse) https://github.com/bitcoin/bitcoin/pull/17621
13:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:33 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
13:36 < jeremyrubin> sipa: what's the debug flag named (not NDEBUG)
13:36 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 240 seconds]
13:37 < sipa> jeremyrubin: --enable-debug sets some flags; it could set another one that specifically control this behaviour
13:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
13:38 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
13:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:41 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bcb4cdcca321...45f151913ef5
13:41 < bitcoin-git> bitcoin/master 75a5e47 Gregory Sanders: Change bumpfee to use watch-only funds for legacy watchonly wallets
13:41 < bitcoin-git> bitcoin/master e9b4f94 Gregory Sanders: bumpfee: Return PSBT when wallet has privkeys disabled
13:41 < bitcoin-git> bitcoin/master 091a876 Gregory Sanders: Test watchonly wallet bumpfee with PSBT return
13:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:42 < bitcoin-git> [bitcoin] meshcollider merged pull request #16373: bumpfee: Return PSBT when wallet has privkeys disabled (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:44 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
13:45 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
13:52 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
13:54 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
13:55 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving]
13:55 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:00 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
14:11 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
14:15 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
14:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
14:18 -!- Lox3u [58beaab8@88.190.170.184] has joined #bitcoin-core-dev
14:20 -!- paultroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
14:22 -!- Lox3u [58beaab8@88.190.170.184] has quit [Remote host closed the connection]
14:22 < jeremyrubin> Ah; I had a variable x and a string "x" and I did x.pushKV("label", x)
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:25 < bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/45f151913ef5...7ea3b85ecf7b
14:25 < bitcoin-git> bitcoin/master 7851f14 Jon Atack: rpc: incorporate review feedback from PR 17283
14:25 < bitcoin-git> bitcoin/master 60aba1f Jon Atack: rpc: simplify getaddressinfo labels, deprecate previous behavior
14:25 < bitcoin-git> bitcoin/master 8bb405b Jon Atack: test: getaddressinfo labels purpose deprecation test
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:26 < bitcoin-git> [bitcoin] meshcollider merged pull request #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior (master...deprecate-getaddress-info-labels-purpose) https://github.com/bitcoin/bitcoin/pull/17578
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:30 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea3b85ecf7b...cab3859a356d
14:30 < bitcoin-git> bitcoin/master e1e1442 Gregory Sanders: Activate no-privkey -> ISMINE_WATCH_ONLY behavior for LegacySPKM only
14:30 < bitcoin-git> bitcoin/master cab3859 Samuel Dobson: Merge #17677: Activate watchonly wallet behavior for LegacySPKM only
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:30 < bitcoin-git> [bitcoin] meshcollider merged pull request #17677: Activate watchonly wallet behavior for LegacySPKM only (master...legacy_spkm_watchonly) https://github.com/bitcoin/bitcoin/pull/17677
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:37 < hebasto> ryanofsky: hmm, why test/functional/feature_config_args.py passed on 67518f7cc61bf59ddfa0fd7c8dbbdec3653b9556 ?
14:39 < hebasto> I see now: test is broken.
14:39 < ryanofsky> test should be unaffected by that change, do you see a break somewhere?
14:41 < hebasto> yes: "-connect=0x7fff50369968" != "-connect=0"
14:46 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds]
14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:47 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cab3859a356d...fcef6dbc15ef
14:47 < bitcoin-git> bitcoin/master 77ef48d Jon Atack: gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy
14:47 < bitcoin-git> bitcoin/master fcef6db fanquake: Merge #17452: test: update fuzz directory in .gitignore
14:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:48 < bitcoin-git> [bitcoin] fanquake merged pull request #17452: test: update fuzz directory in .gitignore (master...update-fuzz-gitignore) https://github.com/bitcoin/bitcoin/pull/17452
14:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:49 < ryanofsky> Oh I see how that would happen, it should not be a problem in the current PR.
14:50 < hebasto> going to submit a pr to fix test
14:50 < ryanofsky> in the commit you mentioned, value is a pointer to a string, and it was printing the pointer address instead of the string on: LogPrintf("Warning: parsed potentially confusing double-negative -%s=%s\n", key, value);
14:51 < hebasto> correct
14:54 < ryanofsky> oh I see, test could be fixed to more robust and not accept trailing characters after 0
14:59 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection]
15:00 -!- captjakk [~captjakk@24.72.155.6] has joined #bitcoin-core-dev
15:11 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 268 seconds]
15:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:15 < captjakk> does bitcoind not support the newer 54 char onion addresses for tor?
15:15 < sipa> no
15:16 < sipa> needs bip 155 in order to represent those
15:17 -!- Kiminuo [~mix@141.98.103.220] has quit [Ping timeout: 268 seconds]
15:18 < captjakk> what's the timeline on 155, and is it something that could benefit from engineering contributions right now, or is it still being debated what the best approach is to get it in?
15:18 < sipa> i don't know if anyone is working on it right now
15:18 < sipa> i don't think there are any known problems with it
15:19 < captjakk> kk, so if I submit a patch implementing it, are you optimistic it would be merged assuming no implementation problems?
15:20 < captjakk> I'd imagine since this isn't a consensus issue, the vuln surface is substantially smaller
15:30 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:49 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
15:54 -!- captjakk [~captjakk@24.72.155.6] has quit [Ping timeout: 258 seconds]
15:55 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
16:00 -!- mreider [~mreider@185.169.255.76] has quit []
16:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:04 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
16:08 -!- captjak__ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has joined #bitcoin-core-dev
16:08 -!- captjakk [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 268 seconds]
16:11 -!- captjakk_ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 268 seconds]
16:12 < fanquake> captjakk feel free to open a PR. If you're interested in tor support, might want to checkout #15423 as well.
16:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15423 | torcontrol: Query Tor for correct -onion configuration by luke-jr . Pull Request #15423 . bitcoin/bitcoin . GitHub
16:14 -!- captjak__ [~captjakk@c-24-72-155-6.ni.gigamonster.net] has quit [Ping timeout: 258 seconds]
16:17 -!- solirc [~solirc@141.98.101.133] has joined #bitcoin-core-dev
16:19 -!- marcoagner [~user@dsl-54-248.bl26.telepac.pt] has quit [Ping timeout: 260 seconds]
16:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:28 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection]
16:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
16:33 -!- thunderstruck [~thunderst@S0106f0f249637173.wp.shawcable.net] has joined #bitcoin-core-dev
16:52 -!- tecnecio_ [~tecnecio_@92.58.58.54] has joined #bitcoin-core-dev
16:52 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 265 seconds]
16:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:00 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has quit [Remote host closed the connection]
17:00 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has joined #bitcoin-core-dev
17:01 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
17:08 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Ping timeout: 240 seconds]
17:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
17:12 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
17:17 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has quit [Ping timeout: 260 seconds]
17:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
17:37 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving]
17:37 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
17:38 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
17:38 -!- thunderstruck [~thunderst@S0106f0f249637173.wp.shawcable.net] has quit [Ping timeout: 260 seconds]
17:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:44 -!- rex4539 [~rex4539@balticom-197-78.balticom.lv] has joined #bitcoin-core-dev
17:45 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has quit [Remote host closed the connection]
17:45 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has joined #bitcoin-core-dev
17:56 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
17:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:58 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
18:02 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Quit: Highway61]
18:02 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
18:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
18:03 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
18:06 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
18:07 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
18:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:20 -!- thunderstruck [~thunderst@S0106f0f249637173.wp.shawcable.net] has joined #bitcoin-core-dev
18:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:30 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
18:34 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
18:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:35 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:46 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has quit [Ping timeout: 265 seconds]
19:00 -!- solirc [~solirc@141.98.101.133] has quit []
19:01 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev
19:04 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds]
19:11 -!- pinheadmz [~matthewzi@185.236.200.116] has joined #bitcoin-core-dev
19:13 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 240 seconds]
19:13 -!- apex944 [~apex@24.154.124.104] has joined #bitcoin-core-dev
19:14 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
19:17 -!- Mlpearc [~Mlpearc@84.39.117.57] has joined #bitcoin-core-dev
19:18 -!- apex944 [~apex@24.154.124.104] has quit [Ping timeout: 260 seconds]
19:23 -!- apex944 [~apex@24.154.124.104] has joined #bitcoin-core-dev
19:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:35 -!- felixfoertsch23 [~felixfoer@2001:16b8:504d:7a00:9c86:4c59:e23a:4d93] has joined #bitcoin-core-dev
19:37 -!- felixfoertsch [~felixfoer@2001:16b8:50fd:3c00:30ed:e9f8:35a8:fc6c] has quit [Ping timeout: 252 seconds]
19:46 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
20:02 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
20:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
20:13 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
20:15 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit]
20:16 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
20:19 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
20:27 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
20:28 -!- apex944 [~apex@24.154.124.104] has quit [Ping timeout: 260 seconds]
20:40 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
20:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
21:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
21:44 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
21:47 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
21:49 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
21:50 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
21:50 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:50 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
21:51 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:51 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
21:51 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:52 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
21:52 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:53 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Read error: Connection reset by peer]
21:53 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
21:53 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
22:00 -!- Mlpearc [~Mlpearc@84.39.117.57] has quit []
22:00 -!- turbo_choo [~turbo_cho@124.128.246.58] has quit [Ping timeout: 258 seconds]
22:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:12 -!- turbo_choo [~turbo_cho@124.128.246.58] has joined #bitcoin-core-dev
22:17 -!- uptime [~uptime@139.28.218.198] has joined #bitcoin-core-dev
22:17 -!- uptime is now known as Guest12445
22:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:27 < bitcoin-git> [bitcoin] Sjors closed pull request #17879: gui: uncheck encrypt by default when creating wallet (master...2020/01/ui-create-wallet) https://github.com/bitcoin/bitcoin/pull/17879
22:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:38 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds]
22:42 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
22:47 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
22:49 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
22:59 -!- Highway61 [~Thunderbi@ip174-73-12-161.no.no.cox.net] has joined #bitcoin-core-dev
23:03 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds]
23:06 -!- Kiminuo [~mix@141.98.103.220] has joined #bitcoin-core-dev
23:07 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
23:20 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
23:25 -!- tardy [31c17562@49.193.117.98] has joined #bitcoin-core-dev
23:26 -!- tardy [31c17562@49.193.117.98] has left #bitcoin-core-dev []
23:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds]
23:57 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
23:57 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
--- Log closed Wed Jan 08 00:00:01 2020