--- Log opened Wed Jan 22 00:00:16 2020 00:01 -!- commavir [~vir@23.226.237.192] has quit [Excess Flood] 00:01 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev 00:05 -!- real_or_random [~real_or_r@173.249.7.254] has quit [Ping timeout: 265 seconds] 00:09 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev 00:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:15 < bitcoin-git> [bitcoin] kallewoof opened pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980 00:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:17 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 00:19 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:27 < fanquake> kallewoof: hopefully the fix is that simple! 00:28 < kallewoof> fanquake: we'll know in half an hour or so :) 00:42 -!- volbil [~volbil@211.248.183.246] has quit [Remote host closed the connection] 00:49 -!- turbo_choo [~turbo_cho@221.0.31.248] has quit [Remote host closed the connection] 00:54 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 01:00 -!- kenperkins [~kenperkin@185.169.255.76] has quit [] 01:02 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:05 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:08 < fanquake> kallewoof: looks good. Has made it through to the functional tests. Wanna update the PR to mention it closes #17976. 01:08 < gribble> https://github.com/bitcoin/bitcoin/issues/17976 | Appveyor ci fails again . Issue #17976 . bitcoin/bitcoin . GitHub 01:09 < kallewoof> Oh, yeah okay 01:09 < kallewoof> Nice 01:09 < kallewoof> Done 01:09 < fanquake> :thu 01:09 < fanquake> ? 01:12 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:17 -!- tonsofpcs1 [~tonsofpcs@172.83.40.52] has joined #bitcoin-core-dev 01:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:25 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/742f84d0de79...e45463a06abe 01:25 < bitcoin-git> bitcoin/master a5a2654 Karl-Johan Alm: test: add missing #include to fix compiler errors 01:25 < bitcoin-git> bitcoin/master e45463a fanquake: Merge #17980: test: add missing #include to fix compiler errors 01:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:26 < bitcoin-git> [bitcoin] fanquake merged pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:32 -!- turbo_choo [~turbo_cho@221.0.31.248] has joined #bitcoin-core-dev 01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:33 < bitcoin-git> [bitcoin] giulio92 opened pull request #17981: Docs: Improve release-process.md formatting (master...release-process-formatting) https://github.com/bitcoin/bitcoin/pull/17981 01:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:43 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45463a06abe...a51aa2880d12 01:43 < bitcoin-git> bitcoin/master 9dd58ca Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback. 01:43 < bitcoin-git> bitcoin/master a51aa28 fanquake: Merge #17897: init: Stop indexes on shutdown after ChainStateFlushed callb... 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:43 < bitcoin-git> [bitcoin] fanquake merged pull request #17897: init: Stop indexes on shutdown after ChainStateFlushed callback. (master...index-commit) https://github.com/bitcoin/bitcoin/pull/17897 01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:04 < bitcoin-git> [bitcoin] fanquake pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/98159132c3e7...9d980c1f7f6f 02:04 < bitcoin-git> bitcoin/0.19 9d980c1 Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback. 02:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:11 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/9d980c1f7f6f...4cf73504220e 02:11 < bitcoin-git> bitcoin/0.19 4cf7350 Wladimir J. van der Laan: Merge branch '0.19_2' into 0.19 02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:17 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:19 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 02:20 < fanquake> In case anyone is wondering what has just happened; I had a lapse of concentration while preparing commits for backport (planning on cherry-picking to a branch and opening a PR), and accidentally pushed 9d980c1f7f6fd0eb686d3cc94ba4698547f151c2 straight to the 0.19 branch. wumpus has pushed 4cf73504220e95ea1c4961509ea757ce6d393a9b as a followup to 0.19 to add a Tree-SHA512 hash. 02:23 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 240 seconds] 02:23 < kallewoof> Now that you mention it it did look kinda odd. I just assumed it ws because it wasn't master. :) 02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:39 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 02:56 < wumpus> we kept it as it was as it's a good backport, avoiding the need to do a force-push 03:03 -!- Adan11Smitham [~Adan11Smi@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:04 < kallewoof> FTR, verified the backport matches the original. 03:08 -!- Adan11Smitham [~Adan11Smi@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 03:11 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds] 03:24 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 03:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:44 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 03:49 -!- promag [~promag@188.250.106.244] has quit [Read error: Connection reset by peer] 03:49 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 04:00 -!- tonsofpcs1 [~tonsofpcs@172.83.40.52] has quit [] 04:08 -!- Guyver2_ [~Guyver@2001:985:f3f:1:40ac:66d:f75e:68e9] has joined #bitcoin-core-dev 04:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 04:12 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 04:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:17 -!- ermau [~ermau@195.206.169.238] has joined #bitcoin-core-dev 04:18 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has joined #bitcoin-core-dev 04:19 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has quit [Excess Flood] 04:20 -!- turbo_choo [~turbo_cho@221.0.31.248] has quit [Ping timeout: 268 seconds] 04:22 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has joined #bitcoin-core-dev 04:29 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:30 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has quit [Quit: Textual IRC Client: www.textualapp.com] 04:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:31 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has joined #bitcoin-core-dev 04:32 -!- gfgdfgdfg4 [~textual@2a03:7380:5400:9:a5b0:305d:a6:1010] has quit [Remote host closed the connection] 04:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 04:38 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Read error: Connection reset by peer] 04:38 -!- jonatack [~jon@134.19.179.203] has joined #bitcoin-core-dev 04:39 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 04:39 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 04:42 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 04:47 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 05:01 -!- Guyver2__ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:03 -!- Guyver2_ [~Guyver@2001:985:f3f:1:40ac:66d:f75e:68e9] has quit [Ping timeout: 264 seconds] 05:05 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 05:09 -!- zivl [~zivl@unaffiliated/zivl] has quit [Quit: zivl] 05:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 05:47 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 05:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 05:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:05 -!- filchef [~filchef@212.104.97.177] has quit [Ping timeout: 268 seconds] 06:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:23 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 06:24 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has quit [Remote host closed the connection] 06:24 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has joined #bitcoin-core-dev 06:24 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 06:32 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 06:37 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:38 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 06:38 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 06:40 -!- Guyver2__ [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds] 06:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 06:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:45 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has joined #bitcoin-core-dev 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a51aa2880d12...0a8b68cdf7d2 06:52 < bitcoin-git> bitcoin/master fae7530 MarcoFalke: scripted-diff: Set gitian arch back to amd64 06:52 < bitcoin-git> bitcoin/master 0a8b68c MarcoFalke: Merge #17483: build: Set gitian arch back to amd64 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17483: build: Set gitian arch back to amd64 (master...1911-gitianRevertToAmd64) https://github.com/bitcoin/bitcoin/pull/17483 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has quit [Quit: Sleep mode] 06:56 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has joined #bitcoin-core-dev 07:00 -!- ermau [~ermau@195.206.169.238] has quit [] 07:02 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 07:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:12 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b68cdf7d2...0038e536de6e 07:12 < bitcoin-git> bitcoin/master 219417b Hennadii Stepanov: Revert "refactor: Simplify connection syntax" 07:12 < bitcoin-git> bitcoin/master 70e4706 Hennadii Stepanov: Revert "refactor: Remove never used default parameter" 07:12 < bitcoin-git> bitcoin/master 0038e53 Wladimir J. van der Laan: Merge #17965: qt: Revert changes of pr17943 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:13 < bitcoin-git> [bitcoin] laanwj merged pull request #17965: qt: Revert changes of pr17943 (master...20200119-revert17943) https://github.com/bitcoin/bitcoin/pull/17965 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:17 -!- AmberJ_ [~AmberJ_@185.169.255.76] has joined #bitcoin-core-dev 07:28 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 07:43 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038e536de6e...04f78b818f02 07:49 < bitcoin-git> bitcoin/master 75163f4 Karl-Johan Alm: bug-fix macos: give free bytes to F_PREALLOCATE 07:49 < bitcoin-git> bitcoin/master 04f78b8 Wladimir J. van der Laan: Merge #17887: bug-fix macos: give free bytes to F_PREALLOCATE 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] laanwj merged pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887 07:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:54 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 260 seconds] 07:54 -!- rex4539 [~rex4539@2a02:587:3514:7a00:19f3:c152:d927:d8e8] has joined #bitcoin-core-dev 07:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 07:59 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 260 seconds] 08:02 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev 08:12 -!- jonatack [~jon@134.19.179.203] has quit [Ping timeout: 268 seconds] 08:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:29 -!- Guyver2__ [~Guyver@2001:985:f3f:1:40ac:66d:f75e:68e9] has joined #bitcoin-core-dev 08:31 -!- bsm117532 [~mcelrath@2601:196:4902:25b0:c1e:7a3e:2318:e275] has joined #bitcoin-core-dev 08:32 -!- bsm117532 [~mcelrath@2601:196:4902:25b0:c1e:7a3e:2318:e275] has quit [Client Quit] 08:32 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds] 08:41 -!- thor [~thor@114.249.51.42] has joined #bitcoin-core-dev 08:42 -!- thor [~thor@114.249.51.42] has quit [Client Quit] 08:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:58 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:09 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 09:09 -!- tsujp [~tsujp@110-175-55-149.tpgi.com.au] has quit [Remote host closed the connection] 09:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 09:29 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:30 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 09:33 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 260 seconds] 09:35 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 09:38 -!- gr0kchain [c5d7a71b@197.215.167.27] has joined #bitcoin-core-dev 09:46 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:46 -!- lightlike [~lightlike@46.114.7.207] has joined #bitcoin-core-dev 09:50 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 09:52 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 09:56 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:57 -!- gr0kchain [c5d7a71b@197.215.167.27] has quit [Remote host closed the connection] 10:00 -!- AmberJ_ [~AmberJ_@185.169.255.76] has quit [] 10:03 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 10:04 < jeremyrubin> hebasto: btw if you're interested in eliminating dependencies, you might be interested in reviewing https://github.com/JeremyRubin/bitcoin/pull/7 10:04 < jeremyrubin> Currently we maintain an entire *data structure* in the mempool just because of a circular resolution issue 10:04 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:07 < jeremyrubin> And we then have to do all these extra map lookups too rather than just keeping the data in the owning class 10:08 -!- Kiminuo [~mix@141.98.103.148] has joined #bitcoin-core-dev 10:09 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:12 -!- Guyver2__ [~Guyver@2001:985:f3f:1:40ac:66d:f75e:68e9] has quit [Ping timeout: 264 seconds] 10:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:15 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 10:15 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer] 10:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 10:16 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 10:17 -!- erwin_bullet [~erwin_bul@84.39.117.57] has joined #bitcoin-core-dev 10:18 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-lmcawufwfcjimkvt] has joined #bitcoin-core-dev 10:37 < sipa> i haven't followed up on the fuzzing work that's been done to the codebase... but i wonder has anyone considered using a dummy signature checker, and fuzzing script execution with it? 10:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 10:50 < wumpus> not sure either, would be best to ask practicalswift 11:02 < phantomcircuit> sipa, i dont think anybody has done that 11:02 < sipa> maybe i'll spend some time looking into how fuzzing works :) 11:03 < instagibbs> sipa, you shoudl attend the PR review club they did it 2 weeks ago :) 11:04 < instagibbs> https://bitcoincore.reviews/17860.html 11:04 < sipa> i have not mastered the skill of attending meetings held in the past 11:04 < wumpus> hehe 11:04 < instagibbs> here I dropped this: ; 11:09 < jonatack> heh, the review club is gradually transitioning into a bitcoin optech-like resource 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:21 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/04f78b818f02...1ae46dce60a1 11:21 < bitcoin-git> bitcoin/master 9574de8 practicalswift: net: Avoid using C-style NUL-terminated strings as arguments in the netbas... 11:21 < bitcoin-git> bitcoin/master fefb916 practicalswift: tests: Add tests to make sure lookup methods fail on std::string parameter... 11:21 < bitcoin-git> bitcoin/master 7a046cd practicalswift: tests: Avoid using C-style NUL-terminated strings as arguments 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:21 < bitcoin-git> [bitcoin] laanwj merged pull request #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests. (master...c_str-cleanup-netbase) https://github.com/bitcoin/bitcoin/pull/17754 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:29 -!- truther10 [~truther10@91-152-137-182.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:31 < phantomcircuit> sipa, is it easy to replace the signature checker for a script instance? 11:31 < phantomcircuit> iirc i looked into it but realized i'd need to much with the internals of the scripting stuff more than i wanted to 11:31 < sipa> phantomcircuit: the script interpreter literally takes in an object that abstracts that out 11:32 < sipa> you can pass one in that always returns true 11:32 < sipa> no code changes to the script interpreter itself needed 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:34 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ae46dce60a1...a3d198c93cbe 11:34 < bitcoin-git> bitcoin/master 76bf972 fanquake: scripts: fix check-symbols & check-security argument passing 11:34 < bitcoin-git> bitcoin/master c491368 fanquake: scripts: add MACHO dylib checking to symbol-check.py 11:34 < bitcoin-git> bitcoin/master a3d198c Wladimir J. van der Laan: Merge #17863: scripts: Add MACHO dylib checks to symbol-check.py 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:34 < bitcoin-git> [bitcoin] laanwj merged pull request #17863: scripts: Add MACHO dylib checks to symbol-check.py (master...add_macos_dylib_checks) https://github.com/bitcoin/bitcoin/pull/17863 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:35 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 268 seconds] 11:37 < phantomcircuit> sipa, neat, then it should be pretty easy to do 11:38 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has quit [Quit: Sleep mode] 11:39 < sipa> see the BaseSignatureChecker passed to EvalScript/VerifyScript 11:49 -!- truther10 [~truther10@91-152-137-182.elisa-laajakaista.fi] has quit [Quit: Leaving] 11:55 -!- jarthur [~jarthur@207.114.244.5] has quit [] 11:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:56 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 12:00 -!- diogosergio [~diogoserg@0545f855.skybroadband.com] has joined #bitcoin-core-dev 12:05 -!- diogosergio [~diogoserg@0545f855.skybroadband.com] has quit [Ping timeout: 240 seconds] 12:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:07 < dongcarl> jonasschnelli: Rebased a few of the net refactor PRs for you :-) 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:09 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a3d198c93cbe...4a072330763b 12:09 < bitcoin-git> bitcoin/master fa5d709 MarcoFalke: ci: Move wrap-qemu into separate script 12:09 < bitcoin-git> bitcoin/master faba467 MarcoFalke: ci: Fix QEMU_USER_CMD parse issues 12:09 < bitcoin-git> bitcoin/master fabb946 MarcoFalke: ci: Install needed gcc and qemu-user iff cross-compiling 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:10 < bitcoin-git> [bitcoin] laanwj merged pull request #17767: ci: Fix qemu issues (master...1912-ciFixWrapQemu) https://github.com/bitcoin/bitcoin/pull/17767 12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:12 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 12:17 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:23 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17984: test: Add p2p test for forcerelay permission (master...2001-qaTxForceRelay) https://github.com/bitcoin/bitcoin/pull/17984 12:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:31 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds] 12:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:44 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Remote host closed the connection] 12:45 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 12:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 12:47 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!] 12:52 -!- lightlike [~lightlike@46.114.7.207] has quit [Quit: Leaving] 12:53 -!- Highway61 [~Thunderbi@173.254.255.34] has quit [Remote host closed the connection] 12:54 -!- Highway61 [~Thunderbi@173.254.255.34] has joined #bitcoin-core-dev 13:00 -!- erwin_bullet [~erwin_bul@84.39.117.57] has quit [] 13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:05 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17985: net: Remove forcerelay of rejected txs (master...2001-p2pNoDeadCode) https://github.com/bitcoin/bitcoin/pull/17985 13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:17 -!- pmuir [~pmuir@195.206.169.238] has joined #bitcoin-core-dev 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:25 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a072330763b...7a311fa54a93 13:25 < bitcoin-git> bitcoin/master f7453dc fanquake: build: remove linking librt for backwards compatibility 13:25 < bitcoin-git> bitcoin/master 7a311fa Wladimir J. van der Laan: Merge #17738: build: remove linking librt for backwards compatibility 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:25 < bitcoin-git> [bitcoin] laanwj merged pull request #17738: build: remove linking librt for backwards compatibility (master...remove_librt_back_compat) https://github.com/bitcoin/bitcoin/pull/17738 13:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:35 -!- Kiminuo [~mix@141.98.103.148] has quit [Ping timeout: 265 seconds] 13:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 13:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 13:56 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 14:00 < MarcoFalke> sipa: phantomcircuit: There is https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/eval_script.cpp and https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/script_flags.cpp 14:02 -!- diogosergio [~diogoserg@0545f855.skybroadband.com] has joined #bitcoin-core-dev 14:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 14:05 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:07 -!- diogosergio [~diogoserg@0545f855.skybroadband.com] has quit [Ping timeout: 272 seconds] 14:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 14:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 14:25 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-dev 14:25 -!- krvopije [~krvopije@185.106.109.144] has quit [Remote host closed the connection] 14:41 -!- side^effects [~al|iss@gateway/tor-sasl/aliss/x-63218493] has joined #bitcoin-core-dev 14:43 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:49 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 15:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 15:19 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 15:22 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 15:27 -!- michaelfolkson [~textual@92.6.97.247] has joined #bitcoin-core-dev 15:27 -!- michaelfolkson [~textual@92.6.97.247] has quit [Client Quit] 15:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 15:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:50 -!- orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-dev 15:50 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 268 seconds] 16:00 -!- pmuir [~pmuir@195.206.169.238] has quit [Read error: Connection reset by peer] 16:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:02 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has joined #bitcoin-core-dev 16:02 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has quit [Client Quit] 16:04 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev 16:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 16:17 -!- SchwarzeLocke [~SchwarzeL@185.169.255.76] has joined #bitcoin-core-dev 16:26 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:41 < bitcoin-git> [bitcoin] fanquake opened pull request #17988: [0.19] Final backports for 0.19.1 (0.19...0-19-1-final-backports) https://github.com/bitcoin/bitcoin/pull/17988 16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:43 < fanquake> If anyone has backport suggestions other than what is left tagged, https://github.com/bitcoin/bitcoin/labels/Needs%20backport%20%280.19%29, please comment etc 16:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:55 -!- nirved [~nirved@2a02:8071:b58a:3c00:d0:a3ff:3fb0:2a9f] has quit [Ping timeout: 272 seconds] 16:56 -!- nirved [~nirved@2a02:8071:b58a:3c00:3ca6:9fb9:2e23:4e12] has joined #bitcoin-core-dev 17:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 17:40 < fanquake> Going to backport #17980 as well so that AppVeyor works for 0.19. 17:40 < gribble> https://github.com/bitcoin/bitcoin/issues/17980 | test: add missing #include to fix compiler errors by kallewoof . Pull Request #17980 . bitcoin/bitcoin . GitHub 18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:08 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/a05d14d4a00e...8b67698420e2 18:08 < bitcoin-git> bitcoin/0.18 c89611e Wladimir J. van der Laan: net: Log to net category for exceptions in ProcessMessages 18:08 < bitcoin-git> bitcoin/0.18 8b67698 fanquake: Merge #17974: [0.18] net: Log to net category for exceptions in ProcessMes... 18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:08 < bitcoin-git> [bitcoin] fanquake merged pull request #17974: [0.18] net: Log to net category for exceptions in ProcessMessages (0.18...bp18_network_exceptions) https://github.com/bitcoin/bitcoin/pull/17974 18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:27 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 18:47 -!- zivl [~zivl@unaffiliated/zivl] has quit [Ping timeout: 260 seconds] 18:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:52 < bitcoin-git> [bitcoin] fanquake closed pull request #17964: doc: Improve contibutor doc formatting and readability (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17964 18:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:00 -!- SchwarzeLocke [~SchwarzeL@185.169.255.76] has quit [] 19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev 19:04 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds] 19:09 -!- davterra [~dulyNoded@195.206.105.106] has quit [Ping timeout: 260 seconds] 19:12 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 19:13 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 19:17 -!- rknLA1 [~rknLA@185.204.1.185] has joined #bitcoin-core-dev 19:26 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-lmcawufwfcjimkvt] has quit [Quit: Connection closed for inactivity] 19:54 -!- felixfoertsch [~felixfoer@92.117.41.97] has joined #bitcoin-core-dev 19:56 -!- felixfoertsch23 [~felixfoer@92.117.40.164] has quit [Ping timeout: 268 seconds] 20:02 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 20:03 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 20:06 -!- pandorian [~voidvecto@ool-3f8fc74b.dyn.optonline.net] has joined #bitcoin-core-dev 20:17 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 20:22 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 20:52 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Quit: Konversation terminated!] 21:27 -!- ppisati [~ppisati@net-47-53-205-12.cust.vodafonedsl.it] has quit [Quit: leaving] 21:30 -!- rex4539 [~rex4539@2a02:587:3514:7a00:19f3:c152:d927:d8e8] has quit [] 21:34 -!- ppisati [~ppisati@net-47-53-205-12.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:48 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.6] 21:53 -!- VoidVextor0 [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has joined #bitcoin-core-dev 21:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:57 -!- pandorian [~voidvecto@ool-3f8fc74b.dyn.optonline.net] has quit [Ping timeout: 272 seconds] 22:00 -!- rknLA1 [~rknLA@185.204.1.185] has quit [] 22:15 -!- VoidVextor0 [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has quit [] 22:16 -!- pandorian [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has joined #bitcoin-core-dev 22:17 -!- patryk2 [~patryk@172.83.40.52] has joined #bitcoin-core-dev 23:03 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 23:13 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 23:14 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 23:14 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 23:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:23 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:58 -!- Netsplit *.net <-> *.split quits: dlb76, raj_, emzy, real_or_random, stevenroose, Isthmus, ryanofsky, mrostecki[m], CodeShark__, Lightsword, (+12 more, use /NETSPLIT to show all of them) --- Log closed Thu Jan 23 00:00:17 2020