--- Log opened Thu Jan 23 00:00:17 2020
00:01 -!- mael-rolland[m] [mael-rolla@gateway/shell/matrix.org/x-pefsfamgbhjphjeh] has quit [Ping timeout: 252 seconds]
00:01 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
00:01 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-kcxzymuqwaauwldy] has quit [Ping timeout: 250 seconds]
00:01 -!- transist0[m] [transist0m@gateway/shell/matrix.org/x-ukuvmtpvskeixwlh] has quit [Ping timeout: 250 seconds]
00:02 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-geaeqwwpxwltkors] has quit [Ping timeout: 246 seconds]
00:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
00:02 -!- castlenine[m] [castlenine@gateway/shell/matrix.org/x-buibjhibnrskeaga] has quit [Ping timeout: 264 seconds]
00:03 -!- Netsplit over, joins: nothingmuch, Lightsword, Anduck, emzy, real_or_random, raj_, CodeShark__, TD-Linux, nehan_, dlb76 (+1 more)
00:04 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
00:09 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Remote host closed the connection]
00:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:10 -!- abrissbi1ne is now known as abrissbirne
00:11 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
00:12 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:14 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:14 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds]
00:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
00:18 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
00:23 -!- VoidVextor0 [~voidvecto@ool-d18c233b.dyn.optonline.net] has joined #bitcoin-core-dev
00:25 -!- pandorian [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has quit [Ping timeout: 268 seconds]
00:30 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
00:30 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
00:30 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
00:45 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-yrjzcjsccopsosvz] has joined #bitcoin-core-dev
00:45 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
00:45 -!- dr_orlovsky [~dr-orlovs@ip216.ip-54-36-238.eu] has joined #bitcoin-core-dev
00:45 -!- TheV01d [thev01d@overnet.cf] has joined #bitcoin-core-dev
00:45 -!- jdmark [~jdmark@unaffiliated/jdmark] has joined #bitcoin-core-dev
00:45 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev
00:45 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
00:45 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev
00:45 -!- stevenroose [~steven@vps.weuste.club] has joined #bitcoin-core-dev
01:00 -!- patryk2 [~patryk@172.83.40.52] has quit []
01:15 -!- promag [~promag@31.22.148.151] has joined #bitcoin-core-dev
01:17 -!- c9sloud [~c9sloud@141.98.102.235] has joined #bitcoin-core-dev
01:27 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:22 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
02:23 -!- pandorian [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has joined #bitcoin-core-dev
02:26 -!- VoidVextor0 [~voidvecto@ool-d18c233b.dyn.optonline.net] has quit [Ping timeout: 252 seconds]
02:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:34 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
02:37 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
02:42 -!- jcoe [~seru@82-132-217-219.dab.02.net] has joined #bitcoin-core-dev
02:45 -!- jcoe1 [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev
02:47 -!- jcoe [~seru@82-132-217-219.dab.02.net] has quit [Ping timeout: 268 seconds]
02:55 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:03 -!- Reba49Hickle [~Reba49Hic@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:15 -!- vasild_ is now known as vasild
03:15 -!- promag [~promag@31.22.148.151] has quit [Remote host closed the connection]
03:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
03:34 -!- Reba49Hickle [~Reba49Hic@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]
03:37 -!- promag_ [~promag@a89-152-187-241.cpe.netcabo.pt] has joined #bitcoin-core-dev
03:38 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
03:41 -!- promag_ [~promag@a89-152-187-241.cpe.netcabo.pt] has quit [Ping timeout: 248 seconds]
03:44 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-ybwgwdcrzwtbziqd] has joined #bitcoin-core-dev
03:44 -!- DavidMitchell[m] [davidfedii@gateway/shell/matrix.org/x-mroisfihdsoblqpq] has joined #bitcoin-core-dev
03:44 -!- electric-sheep[m [electric-s@gateway/shell/matrix.org/x-flpqfkzkgmrswliu] has joined #bitcoin-core-dev
03:44 -!- mael-rolland[m] [mael-rolla@gateway/shell/matrix.org/x-oyztizgplzjjlrdy] has joined #bitcoin-core-dev
03:44 -!- mrostecki[m]1 [mrosteckim@gateway/shell/matrix.org/x-ncgczmlpokdgzahh] has joined #bitcoin-core-dev
03:44 -!- transist0[m] [transist0m@gateway/shell/matrix.org/x-ujdtxoklapuasdjg] has joined #bitcoin-core-dev
03:44 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-svvrmffmvzonczvd] has joined #bitcoin-core-dev
03:44 -!- castlenine[m] [castlenine@gateway/shell/matrix.org/x-bizkjhbuhkdudisz] has joined #bitcoin-core-dev
03:49 -!- xabbix [4fb263dd@unaffiliated/xabbix] has joined #bitcoin-core-dev
03:52 < xabbix> Hi everyone. While syncing a new node, the message received in the rawtx subscription in ZMQ does not contain any identification for the block that the tx is included in. Why is that? Is it possible to include it in some way? (running with txindex=1)
03:55 < wumpus> I think it's because rawtx is *generally* meant for network transactions, not block transactions
03:55 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:55 < wumpus> IIRC transaction notification is even disabled during initial sync because there otherwise would be too many of them
03:57 < xabbix> wumpus Thanks. Looking for the most efficient way of syncing an external source with JSON data regarding transactions from block 0 to last. Any recommendations?
03:57 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
03:59 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has joined #bitcoin-core-dev
04:00 -!- c9sloud [~c9sloud@141.98.102.235] has quit []
04:14 -!- mrostecki[m]1 [mrosteckim@gateway/shell/matrix.org/x-ncgczmlpokdgzahh] has quit [Quit: authenticating]
04:17 -!- chrippa [~chrippa@195.206.183.79] has joined #bitcoin-core-dev
04:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:23 < bitcoin-git> [bitcoin] practicalswift opened pull request #17989: tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer. (master...fuzzers-net-process_message) https://github.com/bitcoin/bitcoin/pull/17989
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:28 < wumpus> xabbix: probably the most efficient way is to request the blocks through the REST interface, in binary format is most efficient (IIRC they will be loaded from disk and sent out in raw without intermediate server-side decoding), but if you prefer it in JSON format that's a possibility too
04:34 -!- tsujp [~tsujp@static-n49-176-253-110.per2.wa.optusnet.com.au] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
04:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
04:42 < wumpus> another way to get all the block data is the approach used in contrib/linearize/*.py, it requests only the block headers from the server then, using direct access to the block files, finds the blocks; I'm not sure if I can really recommend that, because there isn't really a guarantee that the format won't change at some point, but it can be really efficient
04:44 < xabbix> wumpus Thanks for all the help, I'll look into both approaches
04:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds]
04:53 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:11 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 265 seconds]
05:22 -!- jonatack [~jon@213.152.162.79] has joined #bitcoin-core-dev
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:27 < bitcoin-git> [bitcoin] sipsorcery opened pull request #17991: Add vcpkg custom port files (master...vcpkg-ports) https://github.com/bitcoin/bitcoin/pull/17991
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:34 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/4cf73504220e...1299a1a11f9b
05:34 < bitcoin-git> bitcoin/0.19 1299a1a Wladimir J. van der Laan: qt: Translations update pre-rc1
05:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:58 -!- xabbix [4fb263dd@unaffiliated/xabbix] has quit [Remote host closed the connection]
05:59 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: No Ping reply in 180 seconds.]
06:00 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
06:07 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]
06:09 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:11 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/1299a1a11f9b...1b0afb71a2ad
06:11 < bitcoin-git> bitcoin/0.19 c3cb602 Wladimir J. van der Laan: build: Bump version to 0.19.1rc1
06:11 < bitcoin-git> bitcoin/0.19 1b0afb7 Wladimir J. van der Laan: doc: Manpage updates for 0.19.1rc1
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:12 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
06:12 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
06:12 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
06:21 -!- TheRec [~toto@drupal.org/user/146860/view] has quit []
06:23 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
06:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds]
06:39 -!- jcoe1 [seru@gateway/vpn/protonvpn/joncoe] has quit [Quit: Konversation terminated!]
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:47 < bitcoin-git> [bitcoin] darosior opened pull request #17992: Correct a small typo in help / manpage (master...typo) https://github.com/bitcoin/bitcoin/pull/17992
06:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- chrippa [~chrippa@195.206.183.79] has quit []
07:01 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:03 -!- wedw [4e2e5f8a@static.138.95.46.78.clients.your-server.de] has joined #bitcoin-core-dev
07:04 -!- wedw [4e2e5f8a@static.138.95.46.78.clients.your-server.de] has quit [Remote host closed the connection]
07:10 -!- jonatack [~jon@213.152.162.79] has quit [Ping timeout: 268 seconds]
07:16 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev
07:17 -!- rule32 [~rule32@89.238.178.75] has joined #bitcoin-core-dev
07:23 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection]
07:23 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev
07:28 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
07:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:40 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 240 seconds]
07:51 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:53 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a311fa54a93...fe3b58b95955
07:53 < bitcoin-git> bitcoin/master 2fa8dc5 darosior: src/init: correct a typo
07:53 < bitcoin-git> bitcoin/master fe3b58b Wladimir J. van der Laan: Merge #17992: doc: Correct a small typo in help / manpage
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:53 < bitcoin-git> [bitcoin] laanwj merged pull request #17992: doc: Correct a small typo in help / manpage (master...typo) https://github.com/bitcoin/bitcoin/pull/17992
07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:04 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection]
08:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:16 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-hukfrhdjkutgjqrj] has joined #bitcoin-core-dev
08:36 -!- rex4539 [~rex4539@2a02:587:3514:7a00:93f:90b9:c920:81cd] has joined #bitcoin-core-dev
08:39 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Ping timeout: 268 seconds]
09:00 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
09:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
09:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
09:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
09:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
10:00 -!- rule32 [~rule32@89.238.178.75] has quit []
10:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds]
10:17 -!- Lestaty [~Lestaty@195.206.183.79] has joined #bitcoin-core-dev
10:17 -!- Lestaty is now known as Guest98773
10:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] furszy opened pull request #17993: gui: Avoid redundant cs_main locks in balance polling. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
11:02 < emilengler> no meeting today?
11:02 < wumpus> #startmeeting
11:02 < lightningbot> Meeting started Thu Jan 23 19:02:42 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:02 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:03 < sipsorcery> hi
11:03 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
11:03 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
11:03 < emilengler> hi
11:03 < achow101> hi
11:03 < hebasto> hi
11:03 < amiti> hi
11:03 < jonatack> hi
11:03 < fjahr> hi
11:03 < wumpus> no proposed topics for today on https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
11:03 < gwillen> hi
11:03 < wumpus> any last minute suggestions?
11:03 < sipa> hi
11:04 < emilengler> wumpus: yes
11:04 < emilengler> let me find just find the PR number
11:04 < wumpus> PSA: we're planning to tag the 0.19.1 rc1 right after the meeting, after merging the final backports (#17988)
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17988 | [0.19] Final backports for 0.19.1 by fanquake . Pull Request #17988 . bitcoin/bitcoin . GitHub
11:04 < emilengler> There we go, #17453
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/17453 | gui: Fix intro dialog labels when the prune button is toggled by hebasto . Pull Request #17453 . bitcoin/bitcoin . GitHub
11:05 < wumpus> anything specific you'd like to discuss about that?
11:05 < emilengler> It isn't that important and also probably too late but I think this PR should get into the code sooner or later
11:05 < wumpus> ohh just a review beg :D
11:05 < emilengler> It was already said some time ago that it should get into 0.19.1
11:05 < emilengler> I was more asking what's the current state of it
11:07 < wumpus> ok, looks like it has some ACKs, should me merged soon, but I guess it's too late for 0.19.1
11:07 < hebasto> I'd rather wait for jonasschnelli's ACK
11:07 < wumpus> it should have had a 0.19 (backport) label
11:07 < wumpus> right
11:08 < wumpus> #topic High priority for review
11:08 < emilengler> Its predecessor had it (#17035)
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler . Pull Request #17035 . bitcoin/bitcoin . GitHub
11:08 < wumpus> https://github.com/bitcoin/bitcoin/projects/8   9 blockers, 6 chasing concept ACK right now
11:09 < wumpus> anything to add/remove, or is ready for merge?
11:11 < wumpus> #17957 seems pretty close 
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/17957 | Serialization improvements step 3 (compression.h) by sipa . Pull Request #17957 . bitcoin/bitcoin . GitHub
11:12 < wumpus> also #16702
11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
11:12 < wumpus> though jamesob had some new review comments, I think most of those can be done in follow-up PRs
11:13 < wumpus> there's also alredy #17812
11:13 < gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, test: asmap functional tests and feature refinements by jonatack . Pull Request #17812 . bitcoin/bitcoin . GitHub
11:14 < jonatack> yes - i have some questions on the unit tests to discuss with gleb, and will update the follow-up this weekend
11:15 < wumpus> #17737 has one ACK, I've been looking at it and will likely ACK it soon too, but it could use some more review still
11:15 < jonatack> (+1 on getting it in soon)
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/17737 | Add ChainstateManager, remove BlockManager global by jamesob . Pull Request #17737 . bitcoin/bitcoin . GitHub
11:15 < wumpus> jonatack: thanks, yes there's been some more questions about the unit tests, there's some functions (like the interpreter function) that are not tested directly and probably should
11:16 < wumpus> then again, this could all be added later, I have the idea it would be good to get the basic functionality in soon so iteration can be quicker
11:16 < jamesob> wumpus (and anyone else): thanks for the review
11:17 < jonatack> yes, will review https://github.com/sipa/asmap/pull/2 by jamesob 
11:17 < wumpus>  #16974 seems ready for merge
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/16974 | Walk pindexBestHeader back to ChainActive().Tip() if it is invalid by TheBlueMatt . Pull Request #16974 . bitcoin/bitcoin . GitHub
11:17 < wumpus> lots of (ut)ACKs
11:18 < wumpus> #16442 gives me the good old unicorn
11:18 < gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo . Pull Request #16442 . bitcoin/bitcoin . GitHub
11:19 < jamesob> re: 16442: I think gleb and ariard have some concept concerns that should be articulated somewhere at some point
11:19 < wumpus> ah, works not, that one has a lot of open comments still and no ACKs
11:20 < jamesob> the gist of which is, as far as I can tell, that neutrino is sort of useless for lightning because for sybil-resistance, lightning users need to verify all channel openings on-chain, which would result in downloading every incoming block anyway. but this is probably out of scope for this meeting
11:20 < wumpus> okay, yes, would be good to discuss concept concerns first before spending a lot of time reviewing code details
11:21 < sipa> jamesob: that sounds like a discussion for the ML
11:21 < jamesob> agreed
11:21 < wumpus> good point
11:22 < wumpus> ok then there is fanquake's MacOS toolchain update (#16392) which should be straightforward, but I think it's held up on a non-MacoSX way to extract the SDK, not so much review
11:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:22 < gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
11:24 < wumpus> #16411 just needs more review
11:24 < gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
11:24 < wumpus> I think that was all of them
11:24 < wumpus> ah no forgot #17261
11:24 < gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 . Pull Request #17261 . bitcoin/bitcoin . GitHub
11:25 -!- gleb [sid306870@gateway/web/irccloud.com/x-tapoouknqpxtsqlo] has left #bitcoin-core-dev []
11:25 -!- gleb [sid306870@gateway/web/irccloud.com/x-tapoouknqpxtsqlo] has joined #bitcoin-core-dev
11:25 < instagibbs> that one is getting close hopefully
11:25 < wumpus> seems it has ACKs, if my comment isn't really an issue then it can be merged soon
11:25 < wumpus> I'm really not sure about non-primitive constants in header files in C++
11:26 < wumpus> https://github.com/bitcoin/bitcoin/pull/17261#pullrequestreview-345490342 this used to be a problem at some point, but maybe not anymore
11:27 < wumpus> at least in the rest of our code we define string etc constants in the cpp and only reference them in the header
11:27 < achow101> wouldn't a simple test of printing out the memory address of that constant resolve it?
11:27 < wumpus> that only proves it for one compiler
11:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
11:27 < wumpus> or linker
11:28 < wumpus> but yeah it's a way...
11:28 < wumpus> any other topics?
11:29 < kanzure> just another request for topics for upcoming physical meeting
11:29 < wumpus> #action send topic suggestions for upcoming physical meeting to kanzure
11:29 < kanzure> basically, topics that you would like to hear about or you talk about
11:30 < kanzure> not mandatory, but it does help organize and figure out how much stuff is on everyone's minds
11:31 < wumpus> #endmeeting
11:31 < lightningbot> Meeting ended Thu Jan 23 19:31:01 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:31 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.html
11:31 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.txt
11:31 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.log.html
11:33 < hebasto> emilengler: mind adding a commit reference to your ack - https://github.com/bitcoin/bitcoin/pull/17453#issuecomment-576402317
11:41 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
11:42 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:45 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
11:49 < wumpus> going to tag 0.19.1rc1 in a bit
11:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:49 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/1b0afb71a2ad...178a8346871e
11:49 < bitcoin-git> bitcoin/0.19 c8ad23c Karl-Johan Alm: bug-fix macos: give free bytes to F_PREALLOCATE
11:49 < bitcoin-git> bitcoin/0.19 daf2fff Karl-Johan Alm: test: add missing #include to fix compiler errors
11:49 < bitcoin-git> bitcoin/0.19 178a834 Wladimir J. van der Laan: Merge #17988: [0.19] Final backports for 0.19.1
11:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:50 < bitcoin-git> [bitcoin] laanwj merged pull request #17988: [0.19] Final backports for 0.19.1 (0.19...0-19-1-final-backports) https://github.com/bitcoin/bitcoin/pull/17988
11:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:51 < MarcoFalke> wumpus: Are you going to create the list of pulls in the release notes?
11:52 < MarcoFalke> There was a missing author, which should be added
11:52 < MarcoFalke> From the discussion in #17258, mchrostowski should be added
11:52 < gribble> https://github.com/bitcoin/bitcoin/issues/17258 | Fix issue with conflicted mempool tx in listsinceblock by adamjonas . Pull Request #17258 . bitcoin/bitcoin . GitHub
11:57 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
11:58 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
11:59 < wumpus> MarcoFalke: yes, I'm going to--thanks, will keep that in mind
12:00 < MarcoFalke> thx
12:05 < emilengler> hebasto: Which should I ACK?
12:05 < emilengler> I would prefer to ACK a final squashed commit
12:05 < emilengler> Thats the reason why I asked for the sqash btw
12:05 < emilengler> But otherwise I will ACK HEAD~1
12:11 < wumpus> you should always ACK HEAD
12:12 < wumpus> at least, the topmost commit, this implies you ACK everything below it too
12:14 < jonatack> emilengler: review locally (not on GitHub, use it only for reading/writing comments) which makes it easy to simply use the topmost (HEAD) commit hash in the PR branch you pulled locally, for the ack commit
12:16 -!- kvaciral [~kvaciral@185.198.57.211] has joined #bitcoin-core-dev
12:16 < jonatack> see https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#technical-specifics
12:16 < jonatack> or https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#reference-prs-easily-with-refspecs
12:16 < jonatack> or https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally
12:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:21 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds]
12:22 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 258 seconds]
12:24 -!- orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: Textual IRC Client: www.textualapp.com]
12:24 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-dev
12:25 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:25 < bitcoin-git> [bitcoin] laanwj pushed tag v0.19.1rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.1rc1
12:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
12:26 -!- owowo [~ovovo@179.43.152.50] has joined #bitcoin-core-dev
12:26 -!- owowo [~ovovo@179.43.152.50] has quit [Changing host]
12:26 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
12:58 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
13:00 -!- Guest98773 [~Lestaty@195.206.183.79] has quit []
13:05 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
13:17 -!- LaserShark [~LaserShar@195.206.183.79] has joined #bitcoin-core-dev
13:18 -!- Netsplit *.net <-> *.split quits: votesmith, jkczyz, manantial, Highway61, niska, tryphe, filchef, gribble, ctrlbreak, willcl_ark
13:20 -!- warren_ [~warren@fedora/wombat/warren] has quit [Ping timeout: 268 seconds]
13:22 -!- Netsplit over, joins: tryphe, ctrlbreak
13:22 -!- Netsplit over, joins: manantial
13:24 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
13:25 -!- jkczyz [~jkczyz@135.84.132.250] has joined #bitcoin-core-dev
13:32 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
13:33 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:33 < bitcoin-git> [bitcoin] dongcarl closed pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:33 < fanquake> wumpus #16392 mostly held up by getting the 10.14 SDK up somewhere for Travis and the gitian build bot
13:34 < gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
13:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
13:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
13:34 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
13:34 < fanquake> The non-macOS extraction works, but is just a bit of a mess around. Obviously getting the SDK not necessarily straight forward either.
13:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
13:46 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-hukfrhdjkutgjqrj] has quit [Quit: Connection closed for inactivity]
13:50 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: Connection reset by peer]
13:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
13:51 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
13:59 -!- jonatack [~jon@213.152.161.138] has joined #bitcoin-core-dev
14:01 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
14:01 -!- Highway61 [~Thunderbi@173.254.255.34] has joined #bitcoin-core-dev
14:01 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
14:01 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
14:01 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev
14:04 -!- Highway62 [~Thunderbi@173.254.255.34] has joined #bitcoin-core-dev
14:04 -!- Highway61 [~Thunderbi@173.254.255.34] has quit [Remote host closed the connection]
14:04 -!- Highway62 is now known as Highway61
14:07 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
14:29 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer]
15:13 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
15:13 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
15:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
15:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:33 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 268 seconds]
15:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
16:00 -!- LaserShark [~LaserShar@195.206.183.79] has quit []
16:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:14 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
16:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:17 -!- derek1 [~derek@195.206.183.79] has joined #bitcoin-core-dev
16:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
16:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
16:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:00 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:01 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
17:01 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
17:01 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:06 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:06 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:09 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:10 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:12 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:16 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
17:31 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:32 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
17:32 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
17:32 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:35 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:36 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:40 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
17:41 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
17:41 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
17:41 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
17:53 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:57 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
18:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:09 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
18:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
18:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
18:10 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
18:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:39 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
19:00 -!- derek1 [~derek@195.206.183.79] has quit []
19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev
19:04 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds]
19:06 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
19:17 -!- nihui [~nihui@185.204.1.185] has joined #bitcoin-core-dev
19:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
19:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:54 -!- felixfoertsch23 [~felixfoer@2001:16b8:50b4:2b00:3c93:5966:2ade:64e9] has joined #bitcoin-core-dev
19:56 -!- felixfoertsch [~felixfoer@92.117.41.97] has quit [Ping timeout: 268 seconds]
19:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
20:13 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
20:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:46 -!- Highway61 [~Thunderbi@173.254.255.34] has quit [Ping timeout: 268 seconds]
21:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
21:02 -!- TheRec [~toto@drupal.org/user/146860/view] has quit []
21:06 -!- side^effects [~al|iss@gateway/tor-sasl/aliss/x-63218493] has quit [Quit: side^effects]
21:16 -!- Testing [642b1906@100.43.25.6] has joined #bitcoin-core-dev
21:17 -!- Testing is now known as Guest77761
21:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
21:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
21:33 -!- Guest77761 [642b1906@100.43.25.6] has quit [Remote host closed the connection]
22:00 -!- nihui [~nihui@185.204.1.185] has quit []
22:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:05 < bitcoin-git> [bitcoin] kallewoof opened pull request #17994: validation: flush undo files after last block write (master...200124-rev-files) https://github.com/bitcoin/bitcoin/pull/17994
22:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:10 < kallewoof> Nicolas Dorier has an interesting suggestion for Signet: use the same genesis block for all networks. I noticed that most implementations of software hard codes the genesis block hash, and would have to have rather complex code to deal with signet "dynamic genesis"... which defeats the purpose of Signet, since it's supposed to be easy and fun to drop in place when testing stuff. It obviously means light/non-block-
22:10 < kallewoof> signature-checking nodes risk following the wrong chain, though...
22:15 -!- VoidVextor0 [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has joined #bitcoin-core-dev
22:16 -!- pandorian [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has quit [Ping timeout: 268 seconds]
22:17 -!- andyvk5 [~andyvk5@89.238.178.75] has joined #bitcoin-core-dev
22:35 -!- pandorian [~voidvecto@ool-d18c28e9.dyn.optonline.net] has joined #bitcoin-core-dev
22:35 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
22:36 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
22:37 -!- VoidVextor0 [~voidvecto@ool-44c6b9e4.dyn.optonline.net] has quit [Ping timeout: 268 seconds]
22:43 < aj> kallewoof: "easy to drop in" is just a different way of saying "light nodes risk following the wrong chain" i think...
22:44 < kallewoof> aj: Right. I think having the magic number = sha256d(signet_challenge) would greatly reduce that risk, though. And presumably light nodes will connect to trusted peers already.
22:45 < kallewoof> The big issue is if there are two parallel long-term signets and a light client on the less-work-chain accidentally finds a peer on the more-work-chain.
22:45 < aj> kallewoof: maybe you could distinguish chains in a light friendly way by having different outputs in the coinbase of the block 1?
22:46 < kallewoof> aj: one idea was to suggest that light clients download block 1 and verify it including its signature. But that means custom code.
22:46 < aj> kallewoof: looking at the output is a wallet-y thing to do, and you could make it neverspendable as far as full nodes are concerned so it's always in the utxo set
22:47 < aj> kallewoof: yeah, that sounds like as much custome code as it would be to cope with non-const genesis?
22:49 < kallewoof> aj: I'm not sure I see what you're suggesting. Should we add an output in block 1 with OP_RETURN hash256(signet-challenge)?
22:49 < aj> kallewoof: maybe an output in block 1 paying to p2pkh where the private key is hash256(signet-challenge) with an amount of 0?
22:49 < sipa> have a checkpoint at block 1 to force a chain?
22:51 < aj> have the block 1 hash be the signet challenge?
22:51 < aj> no that makes no sense. but be the signet id maybe?
22:52 < kallewoof> sipa: Can do that, but it means having to provide everyone with more parameters. Right now it has challenge and genesis_nonce and seed_nodes. With the static genesis block, we would drop to only providing challenge and seed node. providing the block 1 hash along sounds like it would mean more custom code (at least for non-full-sig-checking-nodes)...
22:52 < kallewoof> aj: That would mean custom code to deal with validation. Would love to avoid
22:53 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has quit [Remote host closed the connection]
22:53 -!- mfoolb [~mfoolb@gateway/tor-sasl/mfoolb] has joined #bitcoin-core-dev
22:53 < kallewoof> Bitcoin Core nodes would not need anything extra since they are checking the block signature for all blocks anyway. Light nodes would need something extra. The magic number being sha256d(challenge) would mitigate this to a great extent. Maybe simply provide the hash of block 1 as a checkpoint would be sufficient.
22:53 -!- VoidVextor0 [~voidvecto@ool-d18c28e9.dyn.optonline.net] has joined #bitcoin-core-dev
22:54 < aj> kallewoof: p2pkh where the public key is NUMS+hash256(signet-challenge)*G (nums point from elements)
22:55 -!- pandorian [~voidvecto@ool-d18c28e9.dyn.optonline.net] has quit [Ping timeout: 265 seconds]
22:55 < kallewoof> aj: someone could maliciously do this to multiple signet chains to screw with people.
22:56 < kallewoof> aj: i.e. have a p2pkh in one chain that sends to a different signet challenge
22:57 < aj> kallewoof: screwing with light nodes is trivial, this is just to prevent non-malicious accidents though?
22:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:59 < kallewoof> hm.. using the magic number truncated hash & a checkpoint sounds like it achieves this without anyone getting screwed, though.
22:59 -!- Highway61 [~Thunderbi@173.254.255.34] has joined #bitcoin-core-dev
22:59 < aj> kallewoof: if you were malicious you'd just build more unsigned blocks than the real chain after the checkpoint
23:00 < aj> kallewoof: but yeah, a checkpoint sounds really simple to me
23:00 < kallewoof> Yeah
23:01 < kallewoof> So basically, "base parameters = challenge and (optionally but helpfully) 1+ seed nodes; for light clients, it is recommended that they also set the checkpoint block 1 = <given hash>". yeah, that sounds better.
23:01 < aj> doesn't need to be block 1, i think?
23:05 < kallewoof> if it is, we dont have to say which block it is
23:06 < aj> checkpoints for block 50k after the signet's been up for a year could be helpful is all?
23:08 < luke-jr> are these test networks or not? who cares if light clients follow the wrong chain? :/
23:08 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:11 < kallewoof> luke-jr: if they are testing a specific feature, it would make no sense if they were on a chain that didn't support those features
23:17 < aj> kallewoof: hm, testing anyprevout by saying "this challenge, and here's a checkpoint after anyprevout's been activated" seems appealing. be nice to solve the seed nodes by looking up hash(challenge).seeds.signet.org or something
23:18 < kallewoof> thrown into a meeting, will comment soon. love the seeds.signet.org idea btw
23:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fe3b58b95955...28fbe68fdcac
23:36 < bitcoin-git> bitcoin/master 2525c09 fanquake: build: remove configure checks for win libraries we don't link against
23:36 < bitcoin-git> bitcoin/master 28fbe68 fanquake: Merge #17740: build: remove configure checks for win libraries we don't li...
23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:36 < bitcoin-git> [bitcoin] fanquake merged pull request #17740: build: remove configure checks for win libraries we don't link against (master...remove_windll_configure_checks) https://github.com/bitcoin/bitcoin/pull/17740
23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Jan 24 00:00:05 2020