--- Log opened Wed Jan 29 00:00:23 2020
00:05 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
00:06 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
00:06 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
00:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:07 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:08 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
00:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:21 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
00:28 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
00:29 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has joined #bitcoin-core-dev
00:34 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has quit [Quit: Leaving]
00:36 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has joined #bitcoin-core-dev
00:40 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has quit [Client Quit]
00:40 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has joined #bitcoin-core-dev
00:41 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has quit [Client Quit]
00:41 -!- torstein18 [~torstein1@184.62-24-34.net.intellit.no] has joined #bitcoin-core-dev
01:00 -!- luto1 [~luto@84.39.117.57] has quit []
01:08 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev
01:11 -!- peutetre [~peutetre@84.39.117.57] has joined #bitcoin-core-dev
01:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:47 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
02:00 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev
02:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
02:27 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:32 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
02:40 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds]
02:40 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:03 -!- Alessandra22Mori [~Alessandr@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:05 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:38 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:40 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fe48ac8580ae...1326092e6cef
03:40 < bitcoin-git> bitcoin/master f1ef7f0 Andrew Chow: Don't calculate tx fees for PSBTs with invalid money values
03:40 < bitcoin-git> bitcoin/master deaa6dd Andrew Chow: psbt: check output index is within bounds before accessing
03:40 < bitcoin-git> bitcoin/master 1326092 fanquake: Merge #17156: psbt: check that various indexes and amounts are within boun...
03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:41 < bitcoin-git> [bitcoin] fanquake merged pull request #17156: psbt: check that various indexes and amounts are within bounds (master...psbt-fuzz-fix) https://github.com/bitcoin/bitcoin/pull/17156
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:48 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
03:49 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Client Quit]
04:00 -!- peutetre [~peutetre@84.39.117.57] has quit []
04:00 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds]
04:02 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
04:10 -!- AIM` [~AIM`@104.254.90.235] has joined #bitcoin-core-dev
04:10 -!- Alessandra22Mori [~Alessandr@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds]
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1326092e6cef...e061b8dc8fba
04:16 < bitcoin-git> bitcoin/master e80317b Bushstar: refactor: Remove redundant conditional
04:16 < bitcoin-git> bitcoin/master e061b8d fanquake: Merge #17971: refactor: Remove redundant conditional
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] fanquake merged pull request #17971: refactor: Remove redundant conditional (master...remove-redundant-conditional) https://github.com/bitcoin/bitcoin/pull/17971
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:23 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
04:26 -!- Skirmant [~Skirmant@mobile-access-2e8457-16.dhcp.inet.fi] has joined #bitcoin-core-dev
04:31 -!- Skirmant [~Skirmant@mobile-access-2e8457-16.dhcp.inet.fi] has quit [Remote host closed the connection]
04:34 < fanquake> Thanks fjahr
04:35 < fjahr> fanquake: sure :)
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e061b8dc8fba...c434282d2cb8
04:49 < bitcoin-git> bitcoin/master b35567f fanquake: test: only declare a main() when fuzzing with AFL
04:49 < bitcoin-git> bitcoin/master c434282 fanquake: Merge #18008: test: only declare a main() when fuzzing with AFL
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:49 < bitcoin-git> [bitcoin] fanquake merged pull request #18008: test: only declare a main() when fuzzing with AFL (master...macos_libfuzzer_weak_main) https://github.com/bitcoin/bitcoin/pull/18008
04:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:50 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:56 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c434282d2cb8...01fc5891fb57
04:56 < bitcoin-git> bitcoin/master 8feb4e4 Gleb Naumenko:  Add asmap utility which queries a mapping
04:56 < bitcoin-git> bitcoin/master ec45646 Gleb Naumenko: Integrate ASN bucketing in Addrman and add tests
04:56 < bitcoin-git> bitcoin/master e4658aa Gleb Naumenko: Return mapped AS in RPC call getpeerinfo
04:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:57 < bitcoin-git> [bitcoin] laanwj merged pull request #16702: p2p: supplying and using asmap to improve IP bucketing in addrman (master...asn_buckets) https://github.com/bitcoin/bitcoin/pull/16702
04:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection]
05:10 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:19 < bitcoin-git> [bitcoin] laanwj closed pull request #17514: util: Make logging noexcept (master...2019_11_logging_noexcept) https://github.com/bitcoin/bitcoin/pull/17514
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
05:37 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/01fc5891fb57...3b5b27673414
05:47 < bitcoin-git> bitcoin/master b6c3e84 Fabian Jahr: doc: Improve fuzzing docs for macOS users
05:47 < bitcoin-git> bitcoin/master 3b5b276 MarcoFalke: Merge #17942: doc: Improve fuzzing docs for macOS users
05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:53 -!- Highway61 [~Thunderbi@96.44.189.226] has quit [Quit: Highway61]
05:59 < wumpus> replaced #17892 with #17994 in high prio 
05:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof . Pull Request #17892 . bitcoin/bitcoin . GitHub
05:59 < gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof . Pull Request #17994 . bitcoin/bitcoin . GitHub
06:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
06:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:11 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3b5b27673414...c1607b5df487
06:11 < bitcoin-git> bitcoin/master ca34c5c Pieter Wuille: Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters
06:11 < bitcoin-git> bitcoin/master 4de934b Pieter Wuille: Convert compression.h to new serialization framework
06:11 < bitcoin-git> bitcoin/master c1607b5 Wladimir J. van der Laan: Merge #17957: Serialization improvements step 3 (compression.h)
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:11 < bitcoin-git> [bitcoin] laanwj merged pull request #17957: Serialization improvements step 3 (compression.h) (master...202001_noncastserial_3) https://github.com/bitcoin/bitcoin/pull/17957
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:19 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
06:19 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
06:19 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Client Quit]
06:20 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
06:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
06:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
06:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] sdaftuar closed pull request #16401: Add package acceptance logic to mempool (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- AIM` [~AIM`@104.254.90.235] has quit []
07:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
07:05 -!- rex4539 [~rex4539@2a02:587:3514:7a00:9a1:2caa:b916:69d3] has joined #bitcoin-core-dev
07:05 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
07:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:15 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
07:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
07:21 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:31 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
07:34 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:35 -!- cpow [~cpow@77.243.177.38] has joined #bitcoin-core-dev
07:43 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
07:44 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
07:45 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
07:48 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:53 -!- felixfoertsch [~felixfoer@92.117.56.158] has quit [Read error: Connection reset by peer]
07:53 -!- felixfoertsch23 [~felixfoer@92.117.56.158] has joined #bitcoin-core-dev
08:00 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:02 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
08:05 -!- tsujp [~tsujp@110-175-55-149.tpgi.com.au] has joined #bitcoin-core-dev
08:15 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:16 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:19 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
08:21 -!- frankie [1b6680c4@27.102.128.196] has joined #bitcoin-core-dev
08:22 -!- frankie is now known as Guest41554
08:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit]
08:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:31 -!- Guest41554 [1b6680c4@27.102.128.196] has quit [Ping timeout: 260 seconds]
08:31 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
08:34 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:37 -!- davterra [~dulyNoded@172.98.86.80] has joined #bitcoin-core-dev
08:38 -!- prettycolors [~prettycol@2605:e000:141a:4c54:7156:5500:e443:f4d1] has quit [Quit: Leaving]
08:43 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
08:48 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has joined #bitcoin-core-dev
08:54 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
09:05 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
09:05 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer]
09:07 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
09:08 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-dev
09:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
09:12 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds]
09:12 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
09:13 -!- jonatack [~jon@213.152.161.170] has joined #bitcoin-core-dev
09:14 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
09:20 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:23 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Quit: Highway61]
09:23 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
09:29 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
09:37 -!- kiwi_74 [32657615@gateway/web/cgi-irc/kiwiirc.com/ip.50.101.118.21] has joined #bitcoin-core-dev
09:41 -!- kiwi_74 [32657615@gateway/web/cgi-irc/kiwiirc.com/ip.50.101.118.21] has quit [Remote host closed the connection]
09:49 -!- hanhua [68850952@104.133.9.82] has joined #bitcoin-core-dev
09:52 -!- pelt [~pelt@195.181.160.175.adsl.inet-telecom.org] has joined #bitcoin-core-dev
10:00 -!- cpow [~cpow@77.243.177.38] has quit []
10:03 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:04 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has joined #bitcoin-core-dev
10:11 -!- wgolden [~wgolden@84.39.117.57] has joined #bitcoin-core-dev
10:14 -!- tsujp [~tsujp@110-175-55-149.tpgi.com.au] has quit [Ping timeout: 272 seconds]
10:15 -!- Highway61 [~Thunderbi@144.178.1.38] has joined #bitcoin-core-dev
10:15 -!- Highway61 [~Thunderbi@144.178.1.38] has quit [Client Quit]
10:21 -!- tsujp [~tsujp@115-64-137-22.static.tpgi.com.au] has joined #bitcoin-core-dev
10:28 < jeremyrubin> Anyone opposed to adding a reference to review #15465 in the style guide?
10:28 < gribble> https://github.com/bitcoin/bitcoin/issues/15465 | Code style PRs after v0.18 branch split . Issue #15465 . bitcoin/bitcoin . GitHub
11:01 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
11:07 < jonatack> jeremyrubin: I learned a great deal from reading and taking notes on the discussion in that PR. Out of curiosity were there particular comments you are referring to?
11:10 < gwillen> jeremyrubin: like, adding it as a reference / further explanation where the styleguide talks about when one should or should not make style changes?
11:10 < gwillen> (and to encourage people not to argue about it without reading this first? :-) )
11:16 < jeremyrubin> yeah
11:16 -!- michaelfolkson [~textual@host-92-6-97-247.as43234.net] has quit [Quit: Sleep mode]
11:24 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] sipa opened pull request #18021: Serialization improvements step 4 (undo.h) (master...202001_noncastserial_4) https://github.com/bitcoin/bitcoin/pull/18021
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:31 < gwillen> jeremyrubin: I feel like after reading that thread, one thing that I would love to see would be guidelines for how to _review_ PRs
11:32 < jeremyrubin> Certainly. I don't want to point at specific examples, as it's a bit more of a general issue with review presently.
11:32 < gwillen> yeah, and I think it's absolutely not bitcoin-specific, I have had similar problems with code review processes in most contexts where I've had code review
11:33 < jeremyrubin> But the way I think about style is it's a sub-goal. And as long as the style is flagrantly bad, focusing on the substance of a PR and correctness are priroties
11:33 < gwillen> is not* I think you meant, but yeah
11:33 < jeremyrubin> yes
11:33  * jeremyrubin adds whitespace to the end of every line
11:34 < jeremyrubin> I also think that unlike other projects perhaps we have a low trust environment, which means that re-review is particularly annoying
11:34 < gwillen> I think a more-structured review process would be helpful, i.e. "currently we are in design review, next we will be in general code review, then after that is nitpick review"
11:34 < jonatack> gwillen: been working on guidelines since last Spring https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
11:34 < jeremyrubin> Paired with a culture of preferring squashed branches it's kind of annoying because you trigger re-review for all prior reviewers
11:34 < jeremyrubin> Which can then add weeks to the cycle of a PR
11:35 < gwillen> one problem with any kind of more structured review is that, as you say it's a bit low-trust, and the longer your PR is open the more likely you are to draw a comment that says "please make huge changes", which has a good chance of killing your work
11:35 -!- tripleslash is now known as imsaguy
11:35 < sipa> really? i've never felt that requests for squashing delay things
11:35 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Ping timeout: 260 seconds]
11:35 -!- imsaguy is now known as [\\\]
11:36 < gwillen> well, if you require everybody to re-ack after squash because the commit ID changed, it seems like it would be surprising if it did not create dleay?
11:36 < sipa> sure, but those acks are trivial
11:37 < sipa> i mean, obviously it adds something... but i've never seen that being a problem
11:38 < jeremyrubin> I think they're also just not worth it -- people are likely to be less dilligent in their re-review unless they are actually fetching the branch and diffiing
11:38 < sipa> i don't think so
11:38 < sipa> the majority of the work when reviewing a PR is understanding it
11:38 < gwillen> I have indeed been fetching the branch and diffing the squash
11:39 < jeremyrubin> Anyways the squashing is a minor issue sipa
11:39 < sipa> a re-review can be much faster, even if you diligently read every line again, just because you already know what's going on
11:39 < sipa> jeremyrubin: fair
11:39 < jeremyrubin> I think that if it's a functional change, fixing a bug, yes, squash it
11:39 < gwillen> just as a matter of policy I'm not comfortable giving an ack unless I'm confident I know exactly what changed since my last ack
11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:40 < gwillen> but also I tend not to be comfortable giving an ack without a pretty detailed understanding of the change, to the point where doing a re-review (without a diff-since-last-review) does feel like a significant burden
11:40 < jeremyrubin> but for things like comments improvements or renaming variables for semantics it's not a great use of contributor time compared to a separate fix up
11:40 < gwillen> is everybody aware that git will show you the diff across a force-push (usually) if you click the words 'force push'
11:41 < jeremyrubin> click?
11:41 < sipa> sure, comment improvements can totally be separate commits
11:41 < gwillen> sorry, github, oops. I have become the thing I despise XD
11:42 < sipa> git push --force will also show you the diff (in the form of commitid..commitid)
11:42 < jeremyrubin> sipa: I think this is all we're expressing is a desire to better contextualize when that's OK to just be like "address this later"
11:42 < sipa> jeremyrubin: i think those things are mostly up to the author really
11:43 < jeremyrubin> Because pointing to a doc or something that says "in general, style changes are not worth a re-ack unless the author wants to" is good
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:44 < jeremyrubin> I like jonatack's doc
11:44 < gwillen> it's a little tricky because I'd say you want at least one person other than the contributor to carefully examine it enough to say "yes, this is indeed just a style change"
11:44 < jonatack> gwillen: even if GitHub can show the diff, i reckon it's best to do git diffing locally after pulling the changes, moreso for final acks
11:44 < gwillen> jonatack: I agree, but I discovered the other day that if you don't have all the previous branch heads after a force push, you can't easily get them to diff them
11:45 < jonatack> jeremyrubin: thanks, looks like i need to add a section about re-acking and git diffing
11:45 < gwillen> there's a trick but it's annoying
11:46 < jonatack> gwillen: agreed, pulling prev branch heads seems par for the course
11:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:47 < gwillen> well in particular, after a force push of a PR branch from X to Y, if you do not already have X locally, you can't easily get X in order to "git diff X Y"
11:47 < gwillen> you have to have already done it (which I guess is a good habit to be in anyway, having reviewed it)
11:48 < sipa> some reviewers prefer not rebasing unless necessary (even if you're rewriting commits)
11:48 < jeremyrubin> it also might not be the worst to have it be a maintainer script that we maintain a master unsquashed and a master squashed branch -- where master squashed squashes all commits prefixed as a fixup@<hash> to fixup @hash
11:49 < jeremyrubin> retract that idea
11:49 < jeremyrubin> sounds like a nightmare
11:50 < sipa> at some point it's a tradeoff between tangible benefits and process overhead
11:51 < jeremyrubin> I think it's reasonable to say that style/whatever fixes don't need a rebase. But if there's a bug, which requires a fix, it actually *should* invalidate all acks, because they missed the bug.
11:53 -!- vasild_ is now known as vasild
11:53 < jeremyrubin> Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable.
11:54 < jonatack> jeremyrubin: I still update it frequently, but maybe when it settles down
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:10 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1607b5df487...aabec94541e2
12:10 < bitcoin-git> bitcoin/master f41d589 Antoine Riard: Document better -keypool as a look-ahead safety mechanism
12:10 < bitcoin-git> bitcoin/master aabec94 Samuel Dobson: Merge #17719: Document better -keypool as a look-ahead safety mechanism
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:11 < bitcoin-git> [bitcoin] meshcollider merged pull request #17719: Document better -keypool as a look-ahead safety mechanism (master...2019-12-improve-keypool-doc) https://github.com/bitcoin/bitcoin/pull/17719
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:11 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has joined #bitcoin-core-dev
12:12 -!- pelt [~pelt@195.181.160.175.adsl.inet-telecom.org] has quit [Quit: pelt]
12:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
12:14 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
12:14 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
12:17 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has quit [Ping timeout: 265 seconds]
12:30 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
12:31 -!- rex4539 [~rex4539@2a02:587:3514:7a00:9a1:2caa:b916:69d3] has quit [Ping timeout: 272 seconds]
12:33 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:34 -!- [\\\] is now known as tripleslash
12:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:40 -!- rex4539 [~rex4539@2a02:587:3514:7a00:cfc:41ec:b10d:6e8] has joined #bitcoin-core-dev
12:53 < elichai2> <<jeremyrubin> > Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable. I'd definitely like to read it :) 
12:57 -!- jonatack [~jon@213.152.161.170] has quit [Ping timeout: 265 seconds]
13:00 -!- wgolden [~wgolden@84.39.117.57] has quit []
13:03 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
13:03 -!- tecnecio_ [~tecnecio_@92.58.58.54] has quit [Read error: No route to host]
13:03 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
13:10 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Remote host closed the connection]
13:12 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
13:15 -!- kpyke [~kpyke@185.169.255.76] has joined #bitcoin-core-dev
13:45 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer]
13:52 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
13:53 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 268 seconds]
13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:58 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:01 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
14:03 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Read error: Connection reset by peer]
14:06 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:14 -!- meshcollider [meshcollid@209.141.50.204] has quit [Remote host closed the connection]
14:15 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds]
14:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
14:40 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 265 seconds]
14:41 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
14:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:05 -!- hanhua [68850952@104.133.9.82] has quit [Remote host closed the connection]
15:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:08 < bitcoin-git> [bitcoin] sipa opened pull request #18023: Some asmap improvements (master...202001_asmap_nits) https://github.com/bitcoin/bitcoin/pull/18023
15:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aabec94541e2...638239de7502
15:15 < bitcoin-git> bitcoin/master fa1a46e MarcoFalke: build: Fix appveyor test_bitcoin build of *.raw
15:15 < bitcoin-git> bitcoin/master 638239d MarcoFalke: Merge #18022: test: Fix appveyor test_bitcoin build of *.raw
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
15:41 -!- rex4539 [~rex4539@2a02:587:3514:7a00:cfc:41ec:b10d:6e8] has quit []
16:00 -!- kpyke [~kpyke@185.169.255.76] has quit []
16:03 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ljjxmkqlqsykocbq] has joined #bitcoin-core-dev
16:11 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Read error: Connection reset by peer]
16:12 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
16:17 -!- frank001 [~frank001@84.39.117.57] has joined #bitcoin-core-dev
16:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:30 -!- thelounge2467250 [~m1rror@109.134.206.46] has quit [Quit: Ping timeout (120 seconds)]
16:30 -!- thelounge2467250 [~m1rror@109.134.206.46] has joined #bitcoin-core-dev
16:32 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 265 seconds]
16:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:35 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
16:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:36 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
16:38 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
16:38 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
16:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
16:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
16:45 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ljjxmkqlqsykocbq] has quit [Quit: ZNC 1.7.4 - https://znc.in]
16:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:47 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
16:49 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
16:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
16:53 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Excess Flood]
16:53 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
16:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
16:55 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Max SendQ exceeded]
16:55 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
17:04 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 240 seconds]
17:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
17:13 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev
17:14 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 268 seconds]
17:33 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-sbtjxckdujyurjue] has joined #bitcoin-core-dev
19:00 -!- frank001 [~frank001@84.39.117.57] has quit []
19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev
19:04 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds]
19:15 -!- netsoundW1 [~netsoundW@84.39.116.180] has joined #bitcoin-core-dev
19:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:27 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
19:34 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 268 seconds]
19:44 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 265 seconds]
19:47 -!- felixfoertsch [~felixfoer@92.117.46.2] has joined #bitcoin-core-dev
19:48 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
19:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:48 < bitcoin-git> [bitcoin] andrewtoth opened pull request #18025: doc: Add missing supported rpcs to doc/descriptors.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18025
19:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:48 -!- felixfoertsch23 [~felixfoer@92.117.56.158] has quit [Ping timeout: 268 seconds]
20:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:22 < bitcoin-git> [bitcoin] meshcollider pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/638239de7502...2d6e76af2409
20:22 < bitcoin-git> bitcoin/master f5be479 Joao Barbosa: wallet: Improve CWallet:MarkDestinationsDirty
20:22 < bitcoin-git> bitcoin/master fadc08a Andrew Chow: Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
20:22 < bitcoin-git> bitcoin/master eb81fc3 Andrew Chow: Refactor: Allow LegacyScriptPubKeyMan to be null
20:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:23 < bitcoin-git> [bitcoin] meshcollider merged pull request #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple (master...wallet-box-pr-2) https://github.com/bitcoin/bitcoin/pull/17261
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:23 < meshcollider> achow101 ^
20:26 < achow101> \o/
20:26 < achow101> finally
20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
20:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
22:00 -!- netsoundW1 [~netsoundW@84.39.116.180] has quit []
22:08 < aj> did travis not run for 17261 ? looks like it missed a unique_ptr<SigningProvider> in wallet/test/psbt_wallet_tests.cpp
22:08 < fanquake> Probably a merge issue. 
22:09 < fanquake> Which is concerning given it got a tested ACK
22:10 < fanquake> Hard to test something that doesn't compile
22:10 < aj> ah, the PR introducin the test also only just got merged
22:10 < aj> so the PRs independently were okay, didn't conflict to cause a rebase, and the merge wasn't tested
22:10 < aj> or not
22:12 < aj> no psbt_wallet_tests was part of this pr
22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:14 < bitcoin-git> [bitcoin] ajtowns opened pull request #18026: psbt_wallet_tests: use unique_ptr for GetSigningProvider (master...202001-getsigningprovider-fix) https://github.com/bitcoin/bitcoin/pull/18026
22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:14 < fanquake> I'm seeing the failure locally now as well. So I assume the merge script was run, but nothing was actually compiled and no tests were run before signing off.
22:15 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
22:17 -!- Mark_Cockrell [~Mark_Cock@141.98.101.133] has joined #bitcoin-core-dev
22:18 < aj> it was #17156 that conflicted with 17261 by the looks
22:18 < gribble> https://github.com/bitcoin/bitcoin/issues/17156 | psbt: check that various indexes and amounts are within bounds by achow101 . Pull Request #17156 . bitcoin/bitcoin . GitHub
22:20 < fanquake> Yea looks like it. I'll test and merge the fixup in a few.
22:31  * fanquake aj are the functional tests broken as well? I see at least one failure in rpc_rawtransaction.py
22:31 < gwillen> huh, as a result of this I went down a rabbit hole and learned about the undocumented github pull/n/merge refs that Travis uses to test the "if it were merged right now" version of a PR
22:31 < gwillen> it's interesting to see that they show as passing, I guess because we do manual merges, so our merge was at a slightly different time than travis's merge
22:32 < fanquake> The merge script should always be on top of master. The travis test run would be been the changes on top of master when the PR was last modified, so ~ a week ago.
22:32 < aj> fanquake: didn't check, hang on
22:33 < fanquake> aj I'm seeing: https://gist.github.com/fanquake/e5cd365667afbfe9d022fe372fcd7d90
22:33 < fanquake> After merging 18026.
22:36 < aj> fanquake: rpc_rawtransaction seems to work fine for me (compiled with gcc)
22:37 < fanquake> aj is that with master + 18026 ?
22:37 < aj> just 18026, but it's directly on top of master
22:38 < aj> 1115ba693b6f6e216cd8417aa499fd018a7c016e to be exact
22:38 -!- tecnecio_ [~tecnecio_@92.58.58.54] has joined #bitcoin-core-dev
22:40 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 265 seconds]
22:40 < fanquake> aj hmm. Passed two times in a row now. So maybe just a random failure.
22:44 < meshcollider> Sorry, my fault completely. I didn't run the tests after the merge script, i merged it in manually when i tested, so it was not on an entirely up-to-date master
22:44 < meshcollider> thanks for catching and fixing aj
22:44 < fanquake> meshcollider going to have to buy him a pint hah
22:45 < meshcollider> in SF, sure ;)
22:51 < aj> fanquake: do you have the logs for the failure? i think it might have the partial txs it was trying to combine logged at DEBUG level
22:51 < fanquake> aj yea I've got em. 1 sec
22:54 < fanquake> aj 12000 lines of consolidated log in https://gist.github.com/fanquake/48b9003af82f5ec5f1f44d1275eb21f0
22:59 -!- cryptoIndio [~cryptoInd@49.145.111.146] has joined #bitcoin-core-dev
23:04 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:10 < aj> fanquake: i don't get it, the lines matching 'complete...False' should be the output of signrawtransaction, but they appear not to specify any vins just a weird vout, when they should be matching rawTx2 which unfortunately isn't printed in the log
23:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
23:15 < aj> oh, hmm, now one of them looks sensible to me
23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:16 < bitcoin-git> [bitcoin] gwillen opened pull request #18027: "PSBT Operations" dialog (master...feature-psbt-ops-dialog) https://github.com/bitcoin/bitcoin/pull/18027
23:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:17 < fanquake> aj is there a specific node you need a tx from?
23:17 < aj> fanquake: no, don't think so
23:17 < gwillen> fanquake: is the PR tagging done by a robot under your name, or are you just extremely fast
23:17 < aj> fanquake: seems like the first partially signed tx's hex isn't being decoded properly of all things?
23:18 < gwillen> (labelling I mean)
23:18 < fanquake> gwillen It's done by me. I'm normally around.
23:19 < fanquake> aj ok. I have the datadirs so can spin the nodes back up.
23:19 < aj> great
23:22 -!- thor [~thor@114.252.126.154] has joined #bitcoin-core-dev
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d6e76af2409...44c2400bccbc
23:24 < bitcoin-git> bitcoin/master 1115ba6 Anthony Towns: psbt_wallet_tests: use unique_ptr for GetSigningProvider
23:24 < bitcoin-git> bitcoin/master 44c2400 fanquake: Merge #18026: psbt_wallet_tests: use unique_ptr for GetSigningProvider
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] fanquake merged pull request #18026: psbt_wallet_tests: use unique_ptr for GetSigningProvider (master...202001-getsigningprovider-fix) https://github.com/bitcoin/bitcoin/pull/18026
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:25 < achow101> damn silent merge conflicts
23:25 < achow101> too many wallet PRs conflict with each other. glad most of it's over now. just time to rebase everything
23:26 < fanquake> the bot is doing the rounds
23:28 < achow101> gwillen: fanquake's actually a robot :)
23:30 < gwillen> thus, all is explained
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:51 -!- vasild_ is now known as vasild
--- Log closed Thu Jan 30 00:00:24 2020