--- Log opened Fri Jan 31 00:00:24 2020 00:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:03 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 00:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 00:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:19 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 00:19 -!- sipa_ [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:20 < bitcoin-git> [bitcoin] promag closed pull request #18035: gui: Drop BanTableModel dependency to ClientModel (master...2020-01-bantablemodel) https://github.com/bitcoin/bitcoin/pull/18035 00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 00:41 -!- pkr [~pkr@158.140.254.215] has quit [Quit: Leaving] 00:46 -!- cryptoIndio [~cryptoInd@49.145.111.146] has joined #bitcoin-core-dev 00:50 -!- cryptoIndio [~cryptoInd@49.145.111.146] has quit [Client Quit] 01:00 -!- jesusabdullah [~jesusabdu@185.189.112.11] has quit [] 01:02 -!- earlz [~earlz@earlz.net] has quit [Quit: leaving] 01:02 -!- earlz [~earlz@earlz.net] has joined #bitcoin-core-dev 01:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds] 01:15 -!- robwerks [~robwerks@195.206.183.79] has joined #bitcoin-core-dev 01:15 -!- robwerks is now known as Guest26827 01:25 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:28 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 01:29 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds] 01:30 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 01:30 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev 01:35 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 01:36 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 01:44 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 01:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds] 01:57 -!- jonatack [~jon@213.152.161.133] has joined #bitcoin-core-dev 02:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:03 < jonasschnelli> Anyone know why the macos build failes on the buitcoinbuilds site? https://bitcoinbuilds.org/index.php?ansilog=e9054288-51c8-4e70-923f-84dea2dfcd15.log#l1752 02:03 < jonasschnelli> It should compile Qt from depends... 02:06 < fanquake> jonasschnelli: that looks like a Linux build, if it's compiling dbus and freedesktop notifications 02:06 < fanquake> Neither are used on macOS 02:06 < jonasschnelli> thats a point. :/ 02:07 < jonasschnelli> though: /home/ubuntu/src/depends/x86_64-apple-darwin14/native/bin/clang -target x86_64-apple-darwin14 -mmacosx-version-min=10.12 --sysroot /home/ubuntu/src/depends/SDKs/MacOSX10.11.sdk 02:08 < jonasschnelli> But yes,.. it passes the #ifdef USE_DBUS macro 02:16 < jonasschnelli> fanquake: but USE_DBUS is enabled on macOS 02:23 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 02:24 < fanquake> jonasschnelli: if you're compiling qt from depends, we explicitly disable the dbus module when targeting macos, so when configure checks for QtDbus, it shouldn't find it, and USE_DBUS shouldn't get set. 02:31 < jonasschnelli> Thanks. Maybe my cache is invalid... 02:34 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 02:34 < fanquake> If you blow everything away and still seeing issues let me know and I'll have a look 02:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:03 -!- Brisa3Smitham [~Brisa3Smi@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:07 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:14 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has joined #bitcoin-core-dev 03:24 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev 03:28 -!- diogosergio [~diogoserg@185.201.63.254] has joined #bitcoin-core-dev 03:36 -!- Brisa3Smitham [~Brisa3Smi@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 272 seconds] 03:37 -!- diogosergio [~diogoserg@185.201.63.254] has quit [Ping timeout: 265 seconds] 03:38 -!- jonatack [~jon@213.152.161.133] has quit [Ping timeout: 268 seconds] 03:43 -!- diogosergio [~diogoserg@185.201.63.254] has joined #bitcoin-core-dev 04:00 -!- Guest26827 [~robwerks@195.206.183.79] has quit [] 04:00 -!- diogosergio [~diogoserg@185.201.63.254] has quit [Ping timeout: 265 seconds] 04:17 -!- alex12 [~alex12@139.28.218.198] has joined #bitcoin-core-dev 04:28 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has quit [Ping timeout: 265 seconds] 04:28 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has joined #bitcoin-core-dev 04:38 -!- thelounge2467250 [~m1rror@109.134.206.46] has quit [Ping timeout: 268 seconds] 04:40 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 04:41 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 05:02 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 05:02 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 05:02 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev 05:10 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 05:12 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 05:14 < sdaftuar> wumpus: fyi I think #17951 is ready for merge 05:14 < gribble> https://github.com/bitcoin/bitcoin/issues/17951 | Use rolling bloom filter of recent block txs for AlreadyHave() check by sdaftuar . Pull Request #17951 . bitcoin/bitcoin . GitHub 05:16 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 05:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 05:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 05:32 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 05:38 -!- vasild_ is now known as vasild 05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:43 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e1bf71064cc...d104aa0ace36 05:43 < bitcoin-git> bitcoin/master a029e18 Suhas Daftuar: Use rolling bloom filter of recent block tx's for AlreadyHave() check 05:43 < bitcoin-git> bitcoin/master d104aa0 Jonas Schnelli: Merge #17951: Use rolling bloom filter of recent block txs for AlreadyHave... 05:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:44 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #17951: Use rolling bloom filter of recent block txs for AlreadyHave() check (master...2020-01-improve-alreadyhave) https://github.com/bitcoin/bitcoin/pull/17951 05:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 05:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 05:51 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 06:04 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 06:09 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 06:23 < jonasschnelli> fanquake: hmm.. still facing the macOS cross compile DBUS error 06:23 < jonasschnelli> fanquake: https://bitcoinbuilds.org/logs/b8458fba-f290-4431-b5ab-4cebb700b2f6.log (a normal macOS depends build with x86_64-apple-darwin16 and MacOS SDK 10.11) 06:24 < jonasschnelli> -no-dbus gets passed into the depends qt builds 06:32 -!- lnostdal_ [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 06:43 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 06:43 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:43 -!- pncl [~pncl____@95.219.161.166] has joined #bitcoin-core-dev 06:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 06:47 < provoostenator> fanquake: the macOS Travis #16392 build is failing, but it's marked as high priority for review. Should I try it anyway? 06:48 < gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub 06:48 -!- molly [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 06:51 < jonasschnelli> feature_block.py fails (reproducible) on bitcoinbuilds: https://bitcoinbuilds.org/index.php?ansilog=b682c112-b8f3-4ad8-859b-d0916e5b3a85.log#l6123 06:58 < jonasschnelli> fanquake: found more about the DBus issue. Our qt m4 detects QT_DBUS even if it has not been compiled via depends. Probably detects it if it has been installed locally as non crosscompile host shared library 07:00 -!- alex12 [~alex12@139.28.218.198] has quit [] 07:06 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:17 -!- chrippa [~chrippa@185.169.255.76] has joined #bitcoin-core-dev 07:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:22 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #18042: Don't check for DBUS notification on macOS (master...2020/01/mac_dbus) https://github.com/bitcoin/bitcoin/pull/18042 07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:34 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 07:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:39 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:41 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:41 -!- selevit_ [~selevit@95.211.188.21] has joined #bitcoin-core-dev 07:43 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has quit [Ping timeout: 268 seconds] 07:46 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has quit [Quit: brianhoffman] 07:51 -!- selevit [~selevit@37.48.118.75] has joined #bitcoin-core-dev 07:53 -!- selevit_ [~selevit@95.211.188.21] has quit [Ping timeout: 265 seconds] 07:56 -!- selevit_ [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has joined #bitcoin-core-dev 07:58 -!- selevit [~selevit@37.48.118.75] has quit [Ping timeout: 260 seconds] 08:06 -!- pncl [~pncl____@95.219.161.166] has quit [Ping timeout: 260 seconds] 08:09 -!- sipa_ is now known as sipa 08:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:11 -!- selevit_ [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has quit [Ping timeout: 260 seconds] 08:14 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has joined #bitcoin-core-dev 08:14 -!- promag_ is now known as promag 08:16 < promag> jonasschnelli: imo these are good to go #17937 #18036 08:16 < gribble> https://github.com/bitcoin/bitcoin/issues/17937 | gui: Remove WalletView and BitcoinGUI circular dependency by promag . Pull Request #17937 . bitcoin/bitcoin . GitHub 08:16 < gribble> https://github.com/bitcoin/bitcoin/issues/18036 | gui: Break trivial circular dependencies by promag . Pull Request #18036 . bitcoin/bitcoin . GitHub 08:18 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has quit [Ping timeout: 240 seconds] 08:23 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has joined #bitcoin-core-dev 08:27 -!- rex4539 [~rex4539@2a02:587:3514:7a00:bdc6:b63d:9f84:4dde] has joined #bitcoin-core-dev 08:31 -!- selevit [~selevit@broadband-77-37-179-213.ip.moscow.rt.ru] has quit [Ping timeout: 265 seconds] 08:36 -!- lightlike [~lightlike@p200300C7EF0D7F0088CA903BA173634E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:42 < bitcoin-git> [bitcoin] sdaftuar opened pull request #18044: Use wtxid for transaction relay (master...2020-01-wtxid-inv) https://github.com/bitcoin/bitcoin/pull/18044 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:43 -!- lightlike [~lightlike@p200300C7EF0D7F0088CA903BA173634E.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds] 08:48 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 08:51 -!- jnewbery [~john@4.53.92.114] has quit [Quit: leaving] 08:51 -!- jnewbery [~john@4.53.92.114] has joined #bitcoin-core-dev 08:51 -!- jnewbery [~john@4.53.92.114] has quit [Client Quit] 08:51 -!- jnewbery [~john@4.53.92.114] has joined #bitcoin-core-dev 08:53 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:55 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Quit: Konversation terminated!] 08:57 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 268 seconds] 08:59 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 09:01 -!- jarthur [~jarthur@2605:6000:1019:4971:e46d:eb84:4296:e026] has joined #bitcoin-core-dev 09:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 09:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:06 -!- jarthur [~jarthur@2605:6000:1019:4971:e46d:eb84:4296:e026] has quit [Remote host closed the connection] 09:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:18 < bitcoin-git> [bitcoin] hebasto opened pull request #18045: build: Do not use QtDBus for macOS builds (master...20200131-macos-qdbus) https://github.com/bitcoin/bitcoin/pull/18045 09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:18 < hebasto> jonasschnelli: mind looking ^ 09:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 09:30 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 09:30 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 09:38 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:48 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev 09:53 < provoostenator> Wallet meeting in 1 hour? Or is the schedule different? 09:53 < achow101> sounds about right 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:54 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #18042: Don't check for DBUS notification on macOS (master...2020/01/mac_dbus) https://github.com/bitcoin/bitcoin/pull/18042 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:00 -!- chrippa [~chrippa@185.169.255.76] has quit [] 10:17 -!- leafstorm [~leafstorm@195.206.183.79] has joined #bitcoin-core-dev 10:23 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Ping timeout: 240 seconds] 10:28 -!- PaulTroo_ [~paultroon@37.120.208.230] has joined #bitcoin-core-dev 10:31 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 265 seconds] 10:32 -!- goatpig [~goat@h-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev 10:33 -!- PaulTroon [~paultroon@173.244.209.80] has joined #bitcoin-core-dev 10:37 -!- PaulTroo_ [~paultroon@37.120.208.230] has quit [Ping timeout: 268 seconds] 11:00 < meshcollider> #startmeeting 11:00 < lightningbot> Meeting started Fri Jan 31 19:00:13 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:00 < provoostenator> hi 11:00 < kanzure> hi 11:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 11:00 < meshcollider> jeremyrubin emilengler jonatack hebasto jb55 11:00 < fjahr> hi 11:01 < achow101> hi 11:01 < meshcollider> So, wallet boxes merged this week, thanks to those who helped review it and get it in \o/ 11:01 < sipa> hi 11:01 < meshcollider> Topics? 11:02 < achow101> does the descriptor wallets PR need to be broken up? 11:02 < provoostenator> It's not HUGE, but it's a lot of moving parts, so might be better to get some stuff in seperately. E.g. serialization. 11:03 < meshcollider> #16528 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 . Pull Request #16528 . bitcoin/bitcoin . GitHub 11:03 < jnewbery> hi 11:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 11:04 < meshcollider> Hmm yeah I think splitting it up at least a bit might help get it in quicker 11:04 < jonatack> hi 11:04 < provoostenator> If you do split however, it'll be more difficult to rely on the functional test suite to check everything. So you may need to add regular unit tests. 11:05 < provoostenator> Not necessarily a bad thing, but maybe unpleasant :-) 11:05 < meshcollider> Andrew has lots of time to add tests in between waiting for reviews ;) 11:06 < achow101> a lot of things in the test suite need to be changed to not rely on deprecated RPCs 11:06 < achow101> but those changes don't make sense (or work) without descriptor wallets already 11:08 < achow101> but threre aren't a lot of commits that can standalone. most of the commits are just implementing different functions 11:10 < provoostenator> I think the wallet encoding stuff can be done seperately, but it'll need unit tests. 11:10 < provoostenator> In other words, it wouldn't be reachable via RPC. 11:11 < meshcollider> You could probably do it in the kind of, implement first, then connect it to the existing code second, like you did with the first boxing PR 11:11 < achow101> you mean the WalletDescriptor class? 11:12 < provoostenator> Maybe the WalletDescriptor class and its WalletDB stuff. 11:12 < provoostenator> Not sure how easy it is to get that in without the whole ScriptpubkeyMan structure to support it. 11:13 < achow101> I'll try 11:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:14 < achow101> I won't be making changes until after next week, so feel free to leave your review comments next week before anything changes 11:15 < sipa> achow101: ? 11:16 < sipa> oh 11:16 < meshcollider> Sounds good 11:16 < sipa> i missed the "until" 11:16 < meshcollider> Anything else anyone wants to discuss? 11:16 < jonatack> meshcollider: 17585 might be RFM, has acks from jnewbery and wumpus 11:16 < provoostenator> Related to descriptor wallets... 11:16 < sipa> #17585 11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/17585 | rpc: deprecate getaddressinfo label by jonatack . Pull Request #17585 . bitcoin/bitcoin . GitHub 11:17 < jonatack> sipa: thank you 11:17 < provoostenator> One thing I brought up in the review is if we really want to switch to BIP44/49/84 or stick to our hardened derivation thing. 11:17 < meshcollider> jonatack: sweet I'll review it too and merge later today 11:17 < achow101> he'll merge it soon(tm) :p 11:18 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 11:19 < achow101> provoostenator: maybe we should discuss that nnow 11:19 < achow101> I think the reason we didn't do public derivation before was because privkeys could be exported easily with dumpprivkey 11:19 < achow101> (and lots of things online casually mention that people can do this to check whether they have the private keys) 11:20 < provoostenator> We currently use m/0'/0'/i' derivation in the wallet 11:20 < provoostenator> Where the last 0' is 1' for change 11:20 < provoostenator> Every key is hardened 11:20 < sipa> i'm not opposed to having the option of having publicly derivable wallets 11:20 < sipa> i'm unsure if it should be default 11:21 < achow101> well it also means we don't need to unlock wallets to get more addresses 11:21 < achow101> so the "keypool" can be way smaller 11:21 < meshcollider> Yeah itd be quite nice to at least have the option there 11:21 < jonatack> +1 11:22 < achow101> descriptor wallets will always give you that option as you can import a descriptor with different derivs. the question is the setting for newly created wallets 11:22 < sipa> yeah 11:22 < sipa> achow101: the keypool (=precomputed pubkeys for descriptors?) still needs to be as large as the gap limit, right? 11:23 < achow101> yes, it still needs to be as large as the gap limit 11:23 < achow101> but that doesn't need to be 1000 11:23 < achow101> could go back to 100 11:23 < sipa> fair, possibly not 11:23 < provoostenator> What happens in the current wallet if you import and rescan a wallet that uses keys beyond the gap limit? 11:23 < sipa> the overhead of a large keypool would also be smaller, i think? 11:24 < sipa> as you don't get new key entries and whatever in the wallet, or do you? 11:24 < achow101> yes 11:24 < achow101> every pubkey is still precomputed and stored for the descriptor cache 11:24 < provoostenator> The serialized descriptor only needs to hold on to its public cache 11:25 < provoostenator> And we can stop storing the encrypted indivual private keys 11:25 < provoostenator> And just derive those when signing. 11:25 < sipa> yeah 11:25 < achow101> I don't think we store individual private keys 11:25 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:25 < sipa> achow101: we do now :p 11:25 < provoostenator> Maybe I misread that today 11:25 < achow101> sipa: in descriptor wallets :) 11:25 < sipa> or do you mean in descriptor wallets PR? 11:25 < provoostenator> Today we do that for backwards compatibility with legacy wallets 11:26 < sipa> right, that's what I assumed 11:26 < sipa> we store individual keys for legacy wallets but not for descriptor wallets 11:26 < provoostenator> The descriptor wallet PR currently maintains that behavior afaik, but doesn't have to. 11:26 < sipa> i hope it does not 11:26 < sipa> descriptor wallets can't be and shouldn't be compatible with old software 11:27 < meshcollider> Yeah that's what we are trying to escape with the redesign 11:27 < provoostenator> sipa: the descriptor wallet flag already prevents old software from loading 11:27 < achow101> at one point, an implementation did do that because it was easier. but I thought I changed that 11:27 < provoostenator> achow101: maybe you only kept the serialization code aorund; that's where I ended reviewing today 11:28 < achow101> provoostenator: maybe you are confusing the descriptor master private key storage? 11:28 < provoostenator> https://github.com/bitcoin/bitcoin/commit/d6f0c337f5bbf935cd93ed3884f5c10bcaa5d493 11:29 < provoostenator> AddKey and AddCryptedKey 11:29 < achow101> that's for the master private key 11:29 < achow101> just bad naming lol 11:29 < provoostenator> Aargh, not the first time I trip over that name. 11:29 < achow101> I'll rename it 11:30 < provoostenator> Ok, so assuming that's all great, we only need the password when expanding the (public) keypool. 11:30 < provoostenator> And when signing a transaction 11:30 < provoostenator> And it's not much burden. 11:30 < provoostenator> So that's not a reason to avoid hardened derivation by default 11:31 < achow101> it's the same thing you have to do today 11:33 < achow101> I suppose part of this is also that it seems like every other wallet has settled on a standardized derivation path scheme 11:33 < achow101> but at the same time, descriptors are completely unambiguous about the derivation to use 11:34 < provoostenator> https://walletsrecovery.org 11:34 -!- pncl [~pncl____@95.219.161.166] has joined #bitcoin-core-dev 11:34 < provoostenator> Reasonably strong BIP44/49/84 adoption 11:35 < provoostenator> But definately not universal 11:35 < provoostenator> See also https://github.com/bitcoin/bitcoin/issues/18043 11:35 < achow101> it's not a problem for people to import their stuff into our descriptor wallet as we can use any derivation path 11:35 < achow101> it's only a problem for people importing core to another wallet that may not allow custom derivation paths 11:36 < provoostenator> I wonder how common that use case is though, exporting keys to another wallet. Usually it's easier to just send them. 11:37 < achow101> Core -> other wallet is fairly common because people don't want to wait for IBD 11:37 < meshcollider> Yeah if you're restoring a backup or something and have keys but haven't synced to send tx 11:38 < meshcollider> It's probably fair to add a wallet creation option to be BIP 44/49/84 compliance 11:38 < achow101> threads on bitcointalk and questions on stackexchange about that show up pretty commonly 11:38 < provoostenator> AssumeUTXO to the rescue? 11:38 < provoostenator> meshcollider: as an option for sure 11:39 < provoostenator> Though without BIP39 mnemonic export that's still not practical 11:39 < achow101> that makes setup more annoying though, possibly need SetupGeneration to take more args 11:39 < provoostenator> achow101: it'll need more args for multisig too probably 11:40 < provoostenator> Actually no, those are still single descriptors. 11:40 < achow101> for multisigs, I would expect that to be imports rather than something we specifically allow in wallet creation 11:40 < provoostenator> If we were to add BIP39 support, then descriptors could contain the mnemonic. 11:41 < sipa> no 11:41 < sipa> the mnemonic is private information, and should be protected by the private key infrastructure 11:41 < sipa> descriptors are public 11:42 < achow101> sipa: descriptors can contain privkeys though 11:42 < achow101> that's supported for imports at least 11:42 < sipa> achow101: as syntactig sugar 11:42 < achow101> yes 11:42 < provoostenator> True, so inpractice you'd have a mnemonic in one place, and then have descriptors that just refer to the master key fingerprint 11:42 < sipa> for imports, supporting mnemonics is not a problem 11:42 < sipa> in descriptors 11:42 < sipa> but they'd be converted to a private key + descriptor with xpubs 11:43 < provoostenator> yes 11:43 < jonatack> "What happens in the current wallet if you import and rescan a wallet that uses keys beyond the gap limit?" -> #17719 just merged, related to this 11:43 < gribble> https://github.com/bitcoin/bitcoin/issues/17719 | Document better -keypool as a look-ahead safety mechanism by ariard . Pull Request #17719 . bitcoin/bitcoin . GitHub 11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:43 < provoostenator> Or a descriptor without xpubs which assumes you have the matser key (doesn't work atm) 11:43 < sipa> provoostenator: hmm, no 11:44 < sipa> the descriptor needs to have enough information to generate future addresses 11:44 < provoostenator> OK, that's a reasonable constraint 11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:45 < achow101> iirc, to be an "active" descriptor, we require IsSolvable() and IsRanged() 11:46 < achow101> although I think IsRanged() implies IsSolvable() 11:46 < provoostenator> (re multisig, I have an experimental createmultisigwallet RPC call in #16895 but I'm not convinced that's the way to go) 11:46 < gribble> https://github.com/bitcoin/bitcoin/issues/16895 | External signer multisig support by Sjors . Pull Request #16895 . bitcoin/bitcoin . GitHub 11:47 < provoostenator> The tricky part of multisig is that you need to collect information from multiple sources. Or one of the [devices] has to be responsible to generate an import incantation. 11:48 < provoostenator> Based on some info it gets from other devices. 11:48 < provoostenator> But maybe for some other time... 11:48 < achow101> i think we can think about multisig after descriptor wallets is merged 11:49 < achow101> (in like 6 months) 11:49 < provoostenator> 2 weeks 11:49 < meshcollider> lol 11:49 < achow101> back to the public deriv thing, what do we want for the default? 11:50 < meshcollider> Will there be a "dumpprivdescriptor" RPC or something, how is the user even going to extract it from their wallet to import? 11:51 < provoostenator> Not initially but hard to guarantee that'll never happen. 11:51 < achow101> not initially 11:51 < sipa> i don't see a big problem with that 11:51 < achow101> I think eventually there will be 11:52 < sipa> it's obviously scary, and needs big warnings 11:52 < meshcollider> Probably 11:52 < sipa> but it's in the same order of dangerous as dumpprivkey now 11:52 < meshcollider> Or dumpwallet 11:52 < sipa> yeah, dumpwallet is a better comparison 11:52 < achow101> dumpwallet is deprecated now I think 11:52 < achow101> with descriptor wallets 11:52 < sipa> good 11:52 < meshcollider> Good 11:52 < provoostenator> More like dumpwallet than dumpkey, because one compromised privkey can comprise the full wallet without hardned deriv 11:52 < sipa> it should be 11:53 < achow101> I think i'll add a dumppublicdescriptor 11:53 < achow101> so at least you can import watch only to another wallet, and then do psbt signing 11:53 < provoostenator> achow101: +1 11:53 < meshcollider> Yeah then with that, BIP derivation seems more sensible 11:53 < jonatack> Yes 11:54 < jonatack> will try to look at #16528 next week 11:54 < gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 . Pull Request #16528 . bitcoin/bitcoin . GitHub 11:55 < meshcollider> Alright any last topics? 11:55 < provoostenator> sipa: taproot wallet support in two weeks? 11:55 < fjahr> just a review beg for #17824, there was some discussion 4 weeks ago but no ACKs yet 11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/17824 | wallet: Improve coin selection for destination groups >10 by fjahr . Pull Request #17824 . bitcoin/bitcoin . GitHub 11:55 < meshcollider> Yep, merge before SF ;) 11:57 < meshcollider> #endmeeting 11:57 < lightningbot> Meeting ended Fri Jan 31 19:57:28 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:57 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-31-19.00.html 11:57 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-31-19.00.txt 11:57 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-31-19.00.log.html 11:57 < jonatack> fjahr: thanks 11:58 < meshcollider> fjahr: it's always hard to get coin selection review haha 11:59 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev 11:59 < fjahr> meshcollider: hehe, I will try to be patient :) 12:02 < hebasto> jonasschnelli: is it feasible to point the latest successful feature_block.py on bitcoinbuild? 12:03 < jonasschnelli> hebasto: I found the issue (why the tests fail)... its out-of-memory 12:03 < jonasschnelli> Somehow running test_runner.py with the sanitizers requires more then 5GB of ram... 12:03 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Client Quit] 12:03 < jonasschnelli> 1603 ubuntu 20 0 1233224 1.071g 9028 S 2.0 22.1 0:24.26 python3 12:04 < jonasschnelli> Some tests require up to 1GB of ram (python part) 12:04 < jonasschnelli> running with -j 1 or -j 2 (default are 4 jobs) 12:05 < jonasschnelli> ... should reduce the mem footprint 12:05 < hebasto> jonasschnelli: thanks for info 12:06 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 260 seconds] 12:09 -!- pncl [~pncl____@95.219.161.166] has quit [Remote host closed the connection] 12:11 -!- nirved [~nirved@2a02:8071:b58a:3c00:3ca6:9fb9:2e23:4e12] has quit [Ping timeout: 272 seconds] 12:13 -!- pncl [~pncl____@95.219.161.166] has joined #bitcoin-core-dev 12:13 -!- nirved [~nirved@2a02:8071:b58a:3c00:3ca6:9fb9:2e23:4e12] has joined #bitcoin-core-dev 12:55 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 13:00 -!- leafstorm [~leafstorm@195.206.183.79] has quit [] 13:12 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 13:12 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev 13:16 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 13:17 -!- lgedeon [~lgedeon@185.204.1.185] has joined #bitcoin-core-dev 14:01 -!- kvaciral [~kvaciral@185.198.57.211] has quit [Quit: Lost terminal] 14:10 < jonatack> Could someone kindly restart travis for #17812 please 14:10 < gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, test: asmap functional tests and feature refinements by jonatack . Pull Request #17812 . bitcoin/bitcoin . GitHub 14:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:17 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 14:34 -!- selevit [~selevit@94.25.168.54] has joined #bitcoin-core-dev 14:41 -!- pncl [~pncl____@95.219.161.166] has quit [Ping timeout: 272 seconds] 14:42 -!- selevit [~selevit@94.25.168.54] has quit [Ping timeout: 265 seconds] 14:44 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 14:44 -!- selevit [~selevit@94.25.171.129] has joined #bitcoin-core-dev 14:52 -!- selevit_ [~selevit@94.25.169.227] has joined #bitcoin-core-dev 14:55 -!- selevit [~selevit@94.25.171.129] has quit [Ping timeout: 265 seconds] 14:59 -!- selevit [~selevit@94.25.170.1] has joined #bitcoin-core-dev 15:01 -!- selevit_ [~selevit@94.25.169.227] has quit [Ping timeout: 268 seconds] 15:03 -!- selevit [~selevit@94.25.170.1] has quit [Ping timeout: 268 seconds] 15:04 -!- selevit_ [~selevit@94.25.171.117] has joined #bitcoin-core-dev 15:09 -!- selevit [~selevit@94.25.169.157] has joined #bitcoin-core-dev 15:10 -!- selevit_ [~selevit@94.25.171.117] has quit [Ping timeout: 265 seconds] 15:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 15:20 -!- selevit_ [~selevit@94.25.168.206] has joined #bitcoin-core-dev 15:21 -!- selevit [~selevit@94.25.169.157] has quit [Ping timeout: 268 seconds] 15:25 -!- selevit_ [~selevit@94.25.168.206] has quit [Ping timeout: 260 seconds] 15:25 -!- selevit [~selevit@94.25.170.55] has joined #bitcoin-core-dev 15:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 15:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 15:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:34 -!- selevit [~selevit@94.25.170.55] has quit [Ping timeout: 268 seconds] 15:36 -!- selevit [~selevit@94.25.168.20] has joined #bitcoin-core-dev 15:40 -!- selevit [~selevit@94.25.168.20] has quit [Ping timeout: 240 seconds] 15:41 -!- selevit [~selevit@94.25.168.157] has joined #bitcoin-core-dev 15:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 15:46 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:47 -!- selevit_ [~selevit@94.25.171.126] has joined #bitcoin-core-dev 15:50 -!- selevit [~selevit@94.25.168.157] has quit [Ping timeout: 268 seconds] 15:52 -!- selevit [~selevit@94.25.169.177] has joined #bitcoin-core-dev 15:55 -!- selevit_ [~selevit@94.25.171.126] has quit [Ping timeout: 260 seconds] 16:00 -!- lgedeon [~lgedeon@185.204.1.185] has quit [] 16:03 -!- selevit_ [~selevit@94.25.170.133] has joined #bitcoin-core-dev 16:06 -!- selevit [~selevit@94.25.169.177] has quit [Ping timeout: 260 seconds] 16:08 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:08 -!- selevit_ [~selevit@94.25.170.133] has quit [Ping timeout: 260 seconds] 16:08 -!- selevit [~selevit@94.25.171.16] has joined #bitcoin-core-dev 16:13 -!- selevit [~selevit@94.25.171.16] has quit [Ping timeout: 268 seconds] 16:13 -!- selevit_ [~selevit@94.25.169.131] has joined #bitcoin-core-dev 16:17 -!- pabelanger1 [~pabelange@184.75.223.227] has joined #bitcoin-core-dev 16:18 -!- selevit_ [~selevit@94.25.169.131] has quit [Ping timeout: 240 seconds] 16:18 -!- zavan [~textual@46.7.131.222] has joined #bitcoin-core-dev 16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:18 < bitcoin-git> [bitcoin] practicalswift opened pull request #18047: tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) (master...fuzzers-netaddress) https://github.com/bitcoin/bitcoin/pull/18047 16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:19 -!- zavan [~textual@46.7.131.222] has quit [Read error: Connection reset by peer] 16:20 -!- zavan [~textual@46.7.131.222] has joined #bitcoin-core-dev 16:21 -!- zavan [~textual@46.7.131.222] has quit [Read error: Connection reset by peer] 16:22 -!- zavan [~textual@46.7.131.222] has joined #bitcoin-core-dev 16:23 -!- tecnecio_ [~tecnecio_@92.58.58.54] has quit [Ping timeout: 265 seconds] 16:26 -!- zavan_ [~textual@46.7.131.222] has joined #bitcoin-core-dev 16:26 -!- zavan [~textual@46.7.131.222] has quit [Read error: Connection reset by peer] 16:31 -!- zavan_ [~textual@46.7.131.222] has quit [Ping timeout: 265 seconds] 17:40 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7] 17:49 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 17:51 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev 18:06 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 18:07 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 18:20 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 18:21 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 18:22 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 18:29 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 18:31 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 19:00 -!- pabelanger1 [~pabelange@184.75.223.227] has quit [] 19:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:01 -!- abrissbi1ne [~abrissbir@unaffiliated/abrissbirne] has joined #bitcoin-core-dev 19:05 -!- abrissbirne [~abrissbir@unaffiliated/abrissbirne] has quit [Ping timeout: 256 seconds] 19:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 19:17 -!- Trixar_za [~Trixar_za@141.98.101.133] has joined #bitcoin-core-dev 19:38 -!- felixfoertsch [~felixfoer@92.117.41.181] has joined #bitcoin-core-dev 19:40 -!- felixfoertsch23 [~felixfoer@2001:16b8:507b:6000:655c:a676:294e:501d] has quit [Ping timeout: 272 seconds] 19:47 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 19:54 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev 20:04 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 20:09 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Remote host closed the connection] 20:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:14 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:15 -!- pinheadmz_ [~matthewzi@195.181.168.216] has joined #bitcoin-core-dev 20:18 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 20:18 -!- pinheadmz_ is now known as pinheadmz 20:24 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection] 20:45 -!- gkrizek [~gkrizek@ec2-54-149-179-115.us-west-2.compute.amazonaws.com] has quit [Read error: Connection reset by peer] 21:12 -!- pinheadmz [~matthewzi@195.181.168.216] has quit [Quit: pinheadmz] 21:12 -!- pinheadmz [~matthewzi@195.181.168.216] has joined #bitcoin-core-dev 21:14 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 21:19 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 21:34 -!- r8921039 [~r8921039@2601:644:303:18c0:198d:3aa3:d8ec:6377] has joined #bitcoin-core-dev 21:37 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-rovapxuunislleex] has joined #bitcoin-core-dev 21:56 -!- tecnecio_ [~tecnecio_@92.58.58.54] has joined #bitcoin-core-dev 22:00 -!- Trixar_za [~Trixar_za@141.98.101.133] has quit [] 22:01 -!- tecnecio_ [~tecnecio_@92.58.58.54] has quit [Quit: Leaving] 22:04 -!- gkrizek [~gkrizek@ec2-54-149-179-115.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 22:10 < kallewoof> Seems g++/gcc is super slow on some macs. This is causing ./configure to take like 5 minutes to finish, since it runs a bunch of tiny g++ compiles. [ echo "int main(){}" > tst.cpp; time ( for i in {1..10}; do g++ -std=c++11 -c -g -O2 -g3 -O0 -DDEBUG -DDEBUG_LOCKORDER -DMAC_OSX tst.cpp; done ) ] takes 0.3s on linux but 13s on my mac... 22:12 < fanquake> kallewoof can you dump the verbose output of your test programs? 22:13 < kallewoof> fanquake: I tried -ftime-report and basically only a few ms go into the compilation, the rest goes into the starting of g++. how do i make it more verbose? 22:14 < fanquake> -v 22:14 < fanquake> That should dump the compiler, flags, SDK, include dirs etc 22:15 < fanquake> i.e https://gist.github.com/fanquake/fa260b6be2ee262ca390df5bfe54bf00 22:17 < kallewoof> https://gist.github.com/kallewoof/41bc47cdc169dbd37af1da78e4c7787c 22:17 -!- Lestaty [~Lestaty@84.39.117.57] has joined #bitcoin-core-dev 22:17 -!- Lestaty is now known as Guest10104 22:17 < kallewoof> 1.31s for "int main(){}"... I suspect this is Apple's new system that checks permissions and stuff. 22:18 < sipa> is this actually gcc, or clang? 22:18 < kallewoof> clang under the hood 22:18 < fanquake> The same invocation for me takes 0.073s 22:19 < kallewoof> fanquake: I'm on mojave. You're on latest? 22:19 < fanquake> No, 10.14.6. At this point I don't think anyone could convince me to upgrade heh. 22:19 < kallewoof> same. wonder what is different. 22:21 < fanquake> The apple clang version is the same. clang-1100.0.33.17. A few differences in include search paths. 22:22 < fanquake> I see -fmessage-length 101 for you, 131 for me. That's the only difference in compiler options. 22:24 < sipa> like the width of your terminal 22:24 < sipa> *likely 22:24 < fanquake> yea, something to do with debug output formatting 22:25 < kallewoof> Running that command directly drops it to 0.66s (both yours and mine are the same).. 22:25 < sipa> which command? 22:25 < kallewoof> the line that start with "/Applications/Xcode.app[...] 22:25 < sipa> can you see if this is time spent in user, system, or waiting for io? 22:26 < kallewoof> ( -cc1 -triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage ) 0.01s user 0.65s system 99% cpu 0.657 total 22:26 < sipa> all system 22:27 < sipa> maybe a weird filesystem configuration? 22:27 < kallewoof> I've got encrypted APFS 22:27 < kallewoof> I thought fanquake did too, though? 22:27 < fanquake> Yea my HD is also encrypted APFS 22:28 < fanquake> kallewoof could try mounting a new, different type of volume, and running commands in there? 22:29 < kallewoof> I can try with an external HDD when I get to the office, but I'm not going there until I get back from London so it'll be a bit :) 22:30 < fanquake> You could create and mount a ramdisk 22:30 < fanquake> i.e: https://stackoverflow.com/questions/46224103/create-apfs-ram-disk-on-macos-high-sierra 22:30 < kallewoof> oh! 22:34 < kallewoof> No change (even tried copying the clang binary into the ramdisk but no change) 22:38 < sipa> kallewoof: do any of the -D flags matter? 22:39 < sipa> i suspect not 22:39 < kallewoof> sipa: no, same results 22:40 < fanquake> kallewoof do you see similar slowness if you use a different Clang? Could install LLVM via brew and try clang++9 22:40 < kallewoof> will try! 22:41 < kallewoof> tho it's strange if that fixed it since you are using the same clang as i am 22:43 < fanquake> Wondering if you Xcode/Command Line tools install might be broken in some way 22:43 < fanquake> *your 22:44 < kallewoof> fanquake: thing is, i had this problem on my previous machine, so i explicitly chose not to migrate my settings over, but to back everything up and pull files from it and do a fresh install of everything, including xcode. same problem appeared... 22:48 < kallewoof> no change 23:34 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 23:42 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:42 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:44 -!- r8921039 [~r8921039@2601:644:303:18c0:198d:3aa3:d8ec:6377] has quit [Remote host closed the connection] 23:47 -!- r8921039 [~r8921039@204.11.107.220] has joined #bitcoin-core-dev 23:47 < aj> kallewoof: maybe filesystem is being super slow gathering include files and/or libs? 23:47 -!- tys0n_ [uid414503@gateway/web/irccloud.com/x-rovapxuunislleex] has quit [Quit: Connection closed for inactivity] 23:50 < kallewoof> aj: i looked around and don't see anything suspect about the dirs listed in the output 23:50 -!- r8921039 [~r8921039@204.11.107.220] has quit [Remote host closed the connection] 23:50 < kallewoof> aj: not sure how to test your theory 23:51 -!- r8921039 [~r8921039@2601:644:303:18c0:8950:ffe:7016:da68] has joined #bitcoin-core-dev 23:53 < kallewoof> fanquake: spot any differences between this and your output for 'diskutil list'? https://gist.github.com/kallewoof/e63b51f6b5aab2f104ebebc602f0e1a1 23:55 < fanquake> kallewoof https://gist.github.com/fanquake/0cf340622dbe24d74393e12935591bf1 23:55 -!- r8921039 [~r8921039@2601:644:303:18c0:8950:ffe:7016:da68] has quit [Ping timeout: 265 seconds] 23:56 < fanquake> only that i have about twice as much junk on my machine 23:57 -!- r8921039 [~r8921039@2601:644:303:18c0:f80c:d217:7081:ff1b] has joined #bitcoin-core-dev 23:58 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7] --- Log closed Sat Feb 01 00:00:07 2020