--- Log opened Mon Feb 24 00:00:03 2020 00:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 00:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 00:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 00:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:35 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 00:40 -!- rjected [~rjected@natp-128-119-202-229.wireless.umass.edu] has quit [Quit: WeeChat 2.7] 00:41 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 00:42 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 00:44 -!- yevaud [~yevaud@163.172.159.188] has quit [Ping timeout: 255 seconds] 00:56 -!- marcoagner [~user@2001:8a0:6a67:4700:af2a:23:5e6f:bccf] has joined #bitcoin-core-dev 01:00 -!- shrug [~shrug@195.206.169.238] has quit [] 01:00 -!- troy1 [~troy@198-84-225-103.cpe.teksavvy.com] has quit [Quit: Leaving.] 01:02 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 01:03 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Ping timeout: 258 seconds] 01:13 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:13 -!- Kiminuo [~mix@141.98.103.110] has joined #bitcoin-core-dev 01:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 01:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 01:36 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 01:39 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 01:40 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:41 -!- promag_ [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:42 -!- promag [~promag@188.250.106.244] has quit [Disconnected by services] 01:42 -!- promag_ is now known as promag 01:42 < promag> wumpus: ping re #18064 01:42 < gribble> https://github.com/bitcoin/bitcoin/issues/18064 | gui: Drop WalletModel dependency to RecentRequestsTableModel by promag · Pull Request #18064 · bitcoin/bitcoin · GitHub 01:46 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has quit [Read error: Connection reset by peer] 01:46 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 01:46 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 01:48 -!- skinkie1 [~skinkie@141.98.101.133] has joined #bitcoin-core-dev 01:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:08 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:11 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds] 02:13 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:29 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 255 seconds] 02:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:41 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 02:44 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 272 seconds] 02:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 02:46 < wumpus> promag: will take a look thanks 02:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds] 03:03 -!- vasild_ is now known as vasild 03:04 -!- Connie83Franecki [~Connie83F@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:33 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 03:36 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 03:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:40 -!- promag [~promag@188.250.106.244] has joined #bitcoin-core-dev 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] practicalswift closed pull request #18199: build: Enable AddressSanitizer as part of --enable-debug (master...enable-debug-asan) https://github.com/bitcoin/bitcoin/pull/18199 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 04:00 -!- skinkie1 [~skinkie@141.98.101.133] has quit [] 04:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 252 seconds] 04:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:17 -!- Greedi [~Greedi@185.169.255.76] has joined #bitcoin-core-dev 04:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 04:31 -!- Rasmus [b905a591@185.5.165.145] has joined #bitcoin-core-dev 04:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 04:49 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has quit [Ping timeout: 260 seconds] 04:57 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Read error: Connection reset by peer] 04:58 -!- sipsorcery [~sipsorcer@37.228.255.208] has joined #bitcoin-core-dev 04:58 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has joined #bitcoin-core-dev 05:10 -!- promag [~promag@188.250.106.244] has quit [Remote host closed the connection] 05:18 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:27 < bitcoin-git> [bitcoin] zengyiheng opened pull request #18200: Sebible v0.18.1 prow (master...sebible-v0.18.1-prow) https://github.com/bitcoin/bitcoin/pull/18200 05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:30 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:30 < bitcoin-git> [bitcoin] fanquake closed pull request #18200: Sebible v0.18.1 prow (master...sebible-v0.18.1-prow) https://github.com/bitcoin/bitcoin/pull/18200 05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:31 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has joined #bitcoin-core-dev 05:36 -!- promag [~promag@a89-152-187-241.cpe.netcabo.pt] has quit [Ping timeout: 258 seconds] 05:36 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 05:39 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:44 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 05:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 05:47 -!- Rasmus [b905a591@185.5.165.145] has quit [Remote host closed the connection] 06:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:21 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-dcymijxouocopvqk] has joined #bitcoin-core-dev 06:25 < kanzure> #proposedmeetingtopic more topic collection for upcoming physical meeting 06:40 < instagibbs> achow101, descriptor wallet PR is a *great* place to redefine "IsChange" to be something much more meaningful than "address isn't in address book" 06:41 < instagibbs> since we're adhering to BIP44/49/84(throwing this out there in case someone thinks this is a bad idea) 07:00 -!- Greedi [~Greedi@185.169.255.76] has quit [] 07:18 -!- Velociraptor1 [~Velocirap@89.249.74.213] has joined #bitcoin-core-dev 07:22 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has joined #bitcoin-core-dev 07:23 -!- jcoe [seru@gateway/vpn/protonvpn/joncoe] has quit [Client Quit] 07:28 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 240 seconds] 07:41 -!- Kiminuo [~mix@141.98.103.110] has quit [Ping timeout: 255 seconds] 07:45 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 265 seconds] 07:46 -!- troy1 [~troy@198-84-225-103.cpe.teksavvy.com] has joined #bitcoin-core-dev 07:48 -!- oguzkoroglu [~ogu@213.74.213.65] has quit [Read error: Connection reset by peer] 07:48 -!- oguzkoroglu [~ogu@213.74.213.65] has joined #bitcoin-core-dev 07:49 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:51 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 07:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:59 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:01 -!- Connie83Franecki [~Connie83F@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 255 seconds] 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab9de435880c...225aa5d6d519 08:02 < bitcoin-git> bitcoin/master bca8665 Luke Dashjr: scripted-diff: Wallet: Rename incorrectly named *UsedDestination 08:02 < bitcoin-git> bitcoin/master 225aa5d MarcoFalke: Merge #18193: scripted-diff: Wallet: Rename incorrectly named *UsedDestina... 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18193: scripted-diff: Wallet: Rename incorrectly named *UsedDestination (master...rename_useddest) https://github.com/bitcoin/bitcoin/pull/18193 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 08:09 -!- Kiminuo [~mix@141.98.103.110] has joined #bitcoin-core-dev 08:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:23 -!- shesek [~shesek@185.3.145.161] has joined #bitcoin-core-dev 08:23 -!- shesek [~shesek@185.3.145.161] has quit [Changing host] 08:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:24 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 08:26 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 08:26 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 08:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 08:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:34 < bitcoin-git> [bitcoin] Sjors opened pull request #18201: rpc: sendmany and sendtoaddress return PSBT for wallets without private keys (master...2020/02/sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18201 08:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:37 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 08:37 < achow101> instagibbs: I'm not sure how that would fit in with LegacyScriptPubKeyMan though 08:38 < achow101> we could have the check be whether a destination belongs to a spkman in m_internal_spk_managers, but for legacy, that doesn't work 08:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:48 < sipa> achow101: have a IsChange(destination, label) function in spkmanagers, which is implemented in legacy as checking if label is empty, and has sane logic in descriptor spkmans? 08:49 < achow101> spkmans internally don't really have a concept of being change/not-change 08:50 < achow101> but I guess we can just have IsChange have more conditionals based on spkman type as we already do in a few places 08:51 < sipa> in an envisioned native descriptor wallet, you'd have separate spkmans for change and non-change, no? 08:51 < achow101> yes 08:53 < sipa> but it's not the spkman itself that knows it is for change or not? 08:53 < achow101> yes 08:53 < achow101> we would have to check whether a scriptPubKey belongs to a spkman in m_internal_spk_mans 08:53 < sipa> that makes sense 08:53 < sipa> but it also.sounds like there shoukd be an easy solution 08:57 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 08:57 < sipa> right, so the knowledge is in the wallet, not the spkmans 09:05 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 09:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:10 -!- yevaud [~yevaud@163.172.159.188] has joined #bitcoin-core-dev 09:10 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 265 seconds] 09:13 -!- benthecarman [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has joined #bitcoin-core-dev 09:21 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:23 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 09:27 < instagibbs> either way my point is that we should change it *now* before we're stuck with behavior again 09:28 < instagibbs> legacy spkm has to keep old behavior 09:28 < instagibbs> anything newer should do something better imo 09:28 < instagibbs> well, any wallet that employs a non-legacy spkm* 09:29 -!- benthecarman_ [~ben@141.98.255.147] has joined #bitcoin-core-dev 09:29 < luke-jr> [14:40:54] achow101, descriptor wallet PR is a *great* place to redefine "IsChange" to be something much more meaningful than "address isn't in address book" 09:29 < luke-jr> we'ver already violated this 09:30 < luke-jr> see #18192 09:30 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub 09:30 < instagibbs> Ok, doesn't change my point :) 09:30 < luke-jr> instagibbs: we can and should fix it for existing wallets ;) 09:31 < instagibbs> opt-in damage :P 09:31 < instagibbs> according to your PR at least 09:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:31 -!- benthecarman [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has quit [Ping timeout: 240 seconds] 09:32 < luke-jr> instagibbs: that's why I rename anything that could be misused 09:32 < luke-jr> any IsChange is inherently opt-in 09:42 < instagibbs> achow101, only edge cases i can think of is if a particular script is for some reason in both an internal and external spkm in the same wallet(though that's pretty dumb to do) 09:45 < instagibbs> otherwise yeah, just add a conditional. I wanted to do that previously but hadn't the opportunity 09:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:45 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 09:47 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 09:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:59 < provoostenator> luke-jr: "don't we want such cases to call an external signer and behave as normally?" - not sure what you mean there? (#18201) 09:59 < gribble> https://github.com/bitcoin/bitcoin/issues/18201 | rpc: sendmany and sendtoaddress return PSBT for wallets without private keys by Sjors · Pull Request #18201 · bitcoin/bitcoin · GitHub 10:00 -!- Velociraptor1 [~Velocirap@89.249.74.213] has quit [] 10:01 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 10:01 < provoostenator> I have a ExternalSignerScriptPubKeyManager subclass of (DescriptorScriptPubManager) which overrides FillPSBT to call an external signer. 10:02 < provoostenator> Which means that CWallet's FillBSBT will return a complete PSBT in that case. 10:02 < provoostenator> Whereas with a legacy watch-only wallet it always returns an incomplete one. 10:02 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:04 < luke-jr> provoostenator: I see. Then the problem is that the return signature changes based on the wallet 10:04 < luke-jr> and potentially based on whether someone forgot to pass -signer or whatever we end up with 10:04 < provoostenator> That's the same pattern we have with bumpfee 10:04 < provoostenator> No, ExternalSigner wallets have a flag 10:04 < luke-jr> bumpfee returns an Object IIRC? 10:05 < luke-jr> with different keys in this case 10:05 < provoostenator> Which causes a throw / exception when -signer isn't set 10:05 < luke-jr> sendmany on the other hand returns a string txid, which callers may very well ignore (while checking the return status) 10:06 < provoostenator> Ah yes, bumpfee always returns an object, but I think I've this pattern in other places. 10:07 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 10:07 -!- benthecarman_ [~ben@141.98.255.147] has quit [Remote host closed the connection] 10:08 -!- benthecarman_ [~ben@141.98.255.147] has joined #bitcoin-core-dev 10:09 < provoostenator> sendmany currently just fails if you use it on a watch-only wallet, which all ExternalDescriptor wallets are 10:09 < provoostenator> Perhaps it makes more sense to always return an object for watch-only wallets? 10:09 < luke-jr> I'm thinking more like having an input flag passed for the PSBT mode 10:10 -!- benthecarman_ [~ben@141.98.255.147] has quit [Remote host closed the connection] 10:10 -!- benthecarman_ [~ben@141.98.255.147] has joined #bitcoin-core-dev 10:11 < provoostenator> I hate extra params though. 10:11 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 10:11 < luke-jr> provoostenator: but what if you want to use it with a normal wallet? ;) 10:11 < luke-jr> eg, prepare a PSBT, manipulate it, resign it, then send it 10:12 < provoostenator> You mean a legacy wallet with imported public keys? 10:12 < provoostenator> But not watch-only? 10:12 < luke-jr> sure 10:12 < provoostenator> Because there's no point in producing a PSBT if you have all the keys 10:13 < luke-jr> I just gave an example 10:13 < provoostenator> I think the general idea is to encourage users to not mix private key and watch-only wallets. 10:14 < provoostenator> So in that case either a wallet is watch-only, and returns an object, or it's not, and returns a string. 10:15 < provoostenator> Alternatively, maybe easier, we always return an object for non-legacy, and for watch-only legacy. 10:15 -!- MasterGruntR75 [~MasterGru@77.243.177.38] has joined #bitcoin-core-dev 10:15 < luke-jr> having two behaviours like that, is going to confuse callers 10:16 < luke-jr> and my example is where you would want a PSBT for a non-watch-only wallet 10:16 < luke-jr> to modify it before sending 10:18 < luke-jr> remember RPC isn't for bitcoin-cli users; it's for scripts, apps, and such 10:18 < provoostenator> It's _also_ for bitcoin-cli users 10:18 < luke-jr> in this context, it doesn't matter 10:18 < luke-jr> point is, have a call signature that changes based on wallet is going to screw up programs 10:19 < luke-jr> also, I don't mean throwign it on params - I mean include it in options :P 10:19 < luke-jr> "options":{"psbt": true} 10:20 < sipa> probably not, as the failures would occur in situations where the call would fail anyway 10:20 < provoostenator> Neither sendmany nor sendtoaddress has an options dictionary 10:20 < sipa> but i do the risk for confusion 10:20 < sipa> *see 10:20 < Randolf> Breaking backward compatibility in an API is a very bad idea. Better not to change the call signature. 10:20 < sipa> it's not breaking compatibility 10:20 < sipa> right? 10:21 < provoostenator> My thinking was to deprecate the non-object response, but without breaking existing automation, which currently only works with private key wallets 10:21 < sipa> it's extending those RPCs to situations where they couldn't be used before 10:21 < provoostenator> Exactly 10:22 < Randolf> Adding options is fine as long as those options aren't made mandatory. Otherwise I would expect it to "screw up programs" as luke-jr pointed out. 10:23 -!- Randolf [~randolf@184.70.10.188] has left #bitcoin-core-dev ["Leaving"] 10:23 < luke-jr> provoostenator: add one 10:23 < luke-jr> sipa: if you call sendtoaddress(…) right now and it doesn't throw an error, you assume it worked 10:23 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 10:23 < luke-jr> sipa: if it's returning a PSBT, then it didn't do the job usually expected 10:24 < luke-jr> ie, it didn't broadcast 10:24 < provoostenator> luke-jr: that would be a bug, it should neverreturn a PSBT for legacy wallets with private keys enabled. 10:25 < luke-jr> provoostenator: the caller does not know the type of wallet loaded 10:25 -!- benthecarman_ [~ben@141.98.255.147] has quit [Remote host closed the connection] 10:26 -!- benthecarman_ [~ben@141.98.255.147] has joined #bitcoin-core-dev 10:26 < luke-jr> if I write a program expecting a watch-only wallet, it shouldn't break if I run it with a normal wallet 10:26 < luke-jr> (nor require extra handling to detect the different situation) 10:27 < provoostenator> Why not? Having private keys in a wallet is very different from not having them. 10:27 < luke-jr> having keys is a strict superset of not having them 10:28 < luke-jr> also, in this case, you would broadcast a transaction intended to just be a PSBT template made! 10:28 -!- ariard_ [~ariard@167.99.46.220] has quit [Quit: Lost terminal] 10:29 < sipa> i have a weak preference for doing this in a separate RPC too 10:29 < sipa> the places you'd use this seem to be distinct from the sending RPCs 10:30 -!- benthecarman__ [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has joined #bitcoin-core-dev 10:30 < luke-jr> actually, doesn't fundrawtransaction kind of already do it? 10:30 < provoostenator> I could revive #16378 10:30 < gribble> https://github.com/bitcoin/bitcoin/issues/16378 | [WIP] The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub 10:31 < luke-jr> provoostenator: I'd prefer that (if there are actual new use cases) 10:31 -!- benthecarman_ [~ben@141.98.255.147] has quit [Read error: Connection reset by peer] 10:31 < provoostenator> (which I closed in favor of this approach :-) 10:32 < provoostenator> Should I still make a PR for the first commit that refactors sendmany & sendtoaddress? 10:32 -!- benthecarman_ [~ben@108-95-148-10.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 10:32 < provoostenator> Not useful on its own though. 10:34 -!- benthecarman__ [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has quit [Remote host closed the connection] 10:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:34 < bitcoin-git> [bitcoin] Sjors closed pull request #18201: rpc: sendmany and sendtoaddress return PSBT for wallets without private keys (master...2020/02/sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18201 10:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:35 -!- ariard [~ariard@167.99.46.220] has joined #bitcoin-core-dev 10:45 -!- Kiminuo [~mix@141.98.103.110] has quit [Read error: Connection reset by peer] 10:49 -!- Kiminuo [~mix@141.98.103.118] has joined #bitcoin-core-dev 10:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:59 -!- troy1 [~troy@198-84-225-103.cpe.teksavvy.com] has left #bitcoin-core-dev [] 11:01 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 11:04 < instagibbs> provoostenator, yes please at least for separate consideration 11:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:05 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev 11:06 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 11:08 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 265 seconds] 11:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:13 < bitcoin-git> [bitcoin] Sjors opened pull request #18202: refactor: consolidate sendmany and sendtoaddress code (master...2020/02/refactor_sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18202 11:13 < provoostenator> instagibbs: done 11:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:21 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Remote host closed the connection] 11:22 -!- benthecarman_ [~ben@108-95-148-10.lightspeed.austtx.sbcglobal.net] has quit [Quit: Leaving] 11:23 -!- benthecarman [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has joined #bitcoin-core-dev 11:27 -!- benthecarman [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has quit [Client Quit] 11:32 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:35 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 255 seconds] 11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:42 -!- rafalcpp [~racalcppp@ip-178-211.ists.pl] has quit [Ping timeout: 255 seconds] 11:42 -!- Highway61 [~Thunderbi@96.44.189.170] has joined #bitcoin-core-dev 11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:47 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 11:48 < achow101> instagibbs: I prefer luke-jr's IsChange fix rather than figuring out change based on scriptPubKeyMan 11:48 < achow101> if solely based on the spkman, we would lose changeness when an internal spkman is changed 11:48 -!- Kiminuo [~mix@141.98.103.118] has quit [Ping timeout: 272 seconds] 12:02 -!- Kiminuo [~mix@141.98.103.118] has joined #bitcoin-core-dev 12:09 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 248 seconds] 12:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:15 -!- benthecarman [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has joined #bitcoin-core-dev 12:21 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 12:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:32 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 12:34 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:34 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer] 12:34 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:52 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 12:55 -!- benthecarman [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has quit [Quit: Leaving] 12:55 -!- benthecarman [6c5f940a@108-95-148-10.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 12:56 < instagibbs> :/ 12:56 -!- benthecarman_ [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has joined #bitcoin-core-dev 12:57 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:00 -!- MasterGruntR75 [~MasterGru@77.243.177.38] has quit [] 13:16 -!- TheCavalry [~TheCavalr@104.254.90.235] has joined #bitcoin-core-dev 13:21 -!- benthecarman__ [~ben@45.83.220.168] has joined #bitcoin-core-dev 13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:23 < bitcoin-git> [bitcoin] Sjors reopened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378 13:23 -!- fv [5d247184@93-36-113-132.ip60.fastwebnet.it] has joined #bitcoin-core-dev 13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:23 -!- bentheacarman__ [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has joined #bitcoin-core-dev 13:23 -!- benthecarman_ [~ben@2600:1700:bb80:db0:dd68:7061:d718:dfe6] has quit [Ping timeout: 240 seconds] 13:23 -!- bentheacarman__ [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has quit [Client Quit] 13:26 -!- benthecarman__ [~ben@45.83.220.168] has quit [Quit: Leaving] 13:31 < instagibbs> achow101, one large annoyance on today's wallet code is that recovering a wallet will mark every address you didn't "getnewaddress" as change, at least until you "getnewaddress" until you hit that particular address 13:33 -!- bentheacarman__ [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has joined #bitcoin-core-dev 13:34 < instagibbs> if you don't want to get confused about changeness, then don't blow away spkms I guess? 13:34 < achow101> you lose the changeness because they get removed from m_internal_spk_managers 13:35 < achow101> because they're no longer active 13:35 < sipa> achow101: hmm 13:35 < instagibbs> hmm let's take this offline 13:35 < instagibbs> or not, if sipa is reading 13:35 < instagibbs> when do they become inactive? 13:36 < achow101> if you were to import a new descriptor for change 13:36 < achow101> whatever was there originally gets inactivatated 13:36 < instagibbs> oh 13:36 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 255 seconds] 13:37 < sipa> it shouldn't lose change-info when you import a new active one? 13:37 < sipa> (would be the ideal behavior, i mean) 13:37 -!- pinheadmz [~matthewzi@5.181.234.220] has joined #bitcoin-core-dev 13:38 < instagibbs> So you have 6 spkm, how does it decide which of the 3 changey ones to deactivate? 13:38 < achow101> the one that's occupying that address type spot 13:38 < achow101> if you imported a new change p2sh-segwit descriptor, the existing change p2sh-segwit descriptor becomes inactive 13:38 < luke-jr> maybe IsChange should pay attention to the derivation of HD keys 13:39 < achow101> luke-jr: I'd rather not 13:39 < instagibbs> luke-jr, that was my original attempt years ago, with current API you can have whatever derivation be change when imported at least 13:39 < sipa> achow101: i feel that the changeness in a descriptor world should be metadata associated with the spkman 13:39 < sipa> independent of what it's active for 13:39 < instagibbs> sipa, mhmm 13:40 < achow101> I guess another m_internal_change_spkmans set could be added where you put all the inactive change spkmans 13:40 < sipa> there may be other metadata too at some point (say: which hw device to use for signing) 13:49 < instagibbs> ACK 13:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 260 seconds] 14:04 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 14:06 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 14:16 -!- bentheacarman__ [~benthecar@2600:1700:bb80:db0:1189:5d22:ab1c:5d53] has quit [Ping timeout: 240 seconds] 14:16 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 14:17 -!- benthecarman [6c5f940a@108-95-148-10.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 260 seconds] 14:17 -!- Kiminuo [~mix@141.98.103.118] has quit [Ping timeout: 255 seconds] 14:19 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 14:29 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 14:32 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 14:49 -!- fv [5d247184@93-36-113-132.ip60.fastwebnet.it] has quit [Remote host closed the connection] 14:51 -!- braydonf_ [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 15:00 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 258 seconds] 15:07 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:21 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 15:24 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 15:25 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 15:35 < luke-jr> why doesn't C++ have a QFlags equivalent yet? -.- 15:48 < sipa> std::bitset comes close 15:48 < sipa> combined with an enum for naming the bits 15:52 < luke-jr> I mean something compatible with class enums and including proper type checking 15:58 -!- sipsorcery [~sipsorcer@37.228.255.208] has quit [Ping timeout: 258 seconds] 15:58 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:59 -!- sipsorcery [~sipsorcer@37.228.224.26] has joined #bitcoin-core-dev 15:59 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 16:00 -!- TheCavalry [~TheCavalr@104.254.90.235] has quit [] 16:00 -!- MasterdonX [~masterdon@42.0.30.151] has quit [Ping timeout: 260 seconds] 16:00 -!- MasterdonX [~masterdon@165.231.253.164] has joined #bitcoin-core-dev 16:12 -!- moth [~moth@89.249.74.213] has joined #bitcoin-core-dev 16:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 16:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:20 < bitcoin-git> [bitcoin] achow101 opened pull request #18204: descriptors: improve descriptor cache and cache xpubs (master...desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/18204 16:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:26 -!- marcoagner [~user@2001:8a0:6a67:4700:af2a:23:5e6f:bccf] has quit [Ping timeout: 240 seconds] 16:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 17:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 17:19 -!- learnday20 [~learnday2@2601:190:c400:3550::1] has joined #bitcoin-core-dev 17:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:22 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 17:25 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 17:29 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 18:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:07 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/225aa5d6d519...a674e89d2771 18:07 < bitcoin-git> bitcoin/master 12a2f37 practicalswift: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t ... 18:07 < bitcoin-git> bitcoin/master a674e89 fanquake: Merge #18162: util: Avoid potential uninitialized read in FormatISO8601Dat... 18:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:07 < bitcoin-git> [bitcoin] fanquake merged pull request #18162: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t) by checking gmtime_s/gmtime_r return value (master...FormatISO8601DateTime-unitialized-read) https://github.com/bitcoin/bitcoin/pull/18162 18:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:09 < bitcoin-git> [bitcoin] fanquake closed pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523 18:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:13 < bitcoin-git> [bitcoin] fanquake closed pull request #15873: Rpc removemempoolentry (master...rpc-removemempoolentry) https://github.com/bitcoin/bitcoin/pull/15873 18:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:15 < bitcoin-git> [bitcoin] fanquake closed pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:20 < bitcoin-git> [bitcoin] fanquake closed pull request #13989: add avx512 instrinsic (master...1-avx512) https://github.com/bitcoin/bitcoin/pull/13989 18:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:27 < bitcoin-git> [bitcoin] fanquake closed pull request #17815: rpc: Make __cookie__ user immune to rpcwhitelist (master...2019-12-rpc-cookie-user-independence) https://github.com/bitcoin/bitcoin/pull/17815 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:28 < ariard> #17443 has been rebased and is quite simple to review and push forward wallet-node refactoring (though maybe conflicts with other wallet PRs) 18:28 < gribble> https://github.com/bitcoin/bitcoin/issues/17443 | Drop checkFinalTx and use Median Time Past to check finality of wallet transactions by ariard · Pull Request #17443 · bitcoin/bitcoin · GitHub 18:30 -!- Highway61 [~Thunderbi@96.44.189.170] has quit [Ping timeout: 272 seconds] 19:00 -!- moth [~moth@89.249.74.213] has quit [] 19:17 -!- gac410 [~gac410@37.120.217.243] has joined #bitcoin-core-dev 19:18 -!- gac410 is now known as Guest80845 19:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 19:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:30 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-dcymijxouocopvqk] has quit [Quit: Connection closed for inactivity] 19:36 < hadjiszs> sipa: MarcoFalke: is there someone working on dandelion++ implementation as for BIP156 ? I am planning to work on top of your #13947 19:36 < gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub 19:41 -!- felixfoertsch [~felixfoer@2001:16b8:507f:6500:50b5:9df8:654c:ee60] has joined #bitcoin-core-dev 19:42 -!- felixfoertsch23 [~felixfoer@2001:16b8:5026:ec00:8d2b:757:c78:2f7b] has quit [Ping timeout: 240 seconds] 19:49 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 19:49 -!- DougieBot5000 is now known as Guest92832 19:49 -!- Guest92832 [~DougieBot@unaffiliated/dougiebot5000] has quit [Killed (card.freenode.net (Nickname regained by services))] 19:49 -!- DougieBot5000_ is now known as DougieBot5000 19:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:50 -!- stevenro- [~steven@irc.roose.io] has quit [Ping timeout: 260 seconds] 19:50 -!- dongcarl8 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 19:51 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-core-dev 19:52 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 19:52 -!- brikk [~ernylund@tuxedo.abo.fi] has quit [Ping timeout: 260 seconds] 19:52 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has quit [Ping timeout: 260 seconds] 19:52 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 19:52 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 260 seconds] 19:52 -!- commavir [~vir@23.226.237.192] has quit [Ping timeout: 260 seconds] 19:52 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Ping timeout: 260 seconds] 19:52 -!- dongcarl8 is now known as dongcarl 19:52 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 260 seconds] 19:52 -!- exhoplex [~exhoplex@btc.tfuel.video] has quit [Ping timeout: 260 seconds] 19:53 -!- brikk [~ernylund@tuxedo.abo.fi] has joined #bitcoin-core-dev 19:53 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 19:53 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 19:53 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 19:53 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 19:54 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev 19:54 -!- exhoplex [~exhoplex@btc.tfuel.video] has joined #bitcoin-core-dev 19:54 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 19:58 -!- hex17or [~hex17or@HSI-KBW-46-223-238-38.hsi.kabel-badenwuerttemberg.de] has joined #bitcoin-core-dev 20:00 -!- kris11 [0256a798@ppp-2-86-167-152.home.otenet.gr] has joined #bitcoin-core-dev 20:04 -!- spinny [55f248bc@bl9-72-188.dsl.telepac.pt] has joined #bitcoin-core-dev 20:05 -!- kris11 [0256a798@ppp-2-86-167-152.home.otenet.gr] has quit [Remote host closed the connection] 20:18 < sipa> hadjiszs: i believe dandelion os a dead end 20:19 < sipa> hadjiszs: https://bitcoin.stackexchange.com/q/81503/208 20:22 < aj> sipa: hmm, i thought that was just "it's a lot more work than we thought" not "it's impossible and not worth further work" ? 20:26 < sipa> i pretty much believe there isn't a reasonable solution that ticks all the boxes 20:26 < sipa> i don't have a strong argument for this, and would be very happy to be convinced otherwise 20:30 -!- shapeare [3b8aa947@KD059138169071.ppp-bb.dion.ne.jp] has joined #bitcoin-core-dev 20:35 < aj> ok, i'll remain naively optimistic then 20:37 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 20:43 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 20:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 20:46 -!- learnday20 [~learnday2@2601:190:c400:3550::1] has quit [Quit: Leaving] 20:46 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 20:47 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 21:03 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:04 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 21:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 21:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds] 21:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 21:42 -!- spinny [55f248bc@bl9-72-188.dsl.telepac.pt] has quit [Remote host closed the connection] 21:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 22:00 -!- Guest80845 [~gac410@37.120.217.243] has quit [] 22:06 -!- sipsorcery [~sipsorcer@37.228.224.26] has quit [Ping timeout: 272 seconds] 22:07 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 22:17 -!- kermit2 [~kermit@176.113.74.179] has joined #bitcoin-core-dev 22:29 -!- Kiminuo [~mix@141.98.103.118] has joined #bitcoin-core-dev 23:14 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:19 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 23:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:35 -!- shapeare [3b8aa947@KD059138169071.ppp-bb.dion.ne.jp] has quit [Remote host closed the connection] 23:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 23:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:52 < bitcoin-git> [bitcoin] fanquake closed pull request #18116: depends: Use clang for Ubuntu 16.04 (master...20200211-clang-ubuntu) https://github.com/bitcoin/bitcoin/pull/18116 23:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] --- Log closed Tue Feb 25 00:00:04 2020