--- Log opened Sun Mar 01 00:00:10 2020
00:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
00:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 256 seconds]
00:34 -!- Kiminuo [~mix@141.98.103.150] has quit [Read error: Connection reset by peer]
00:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:41 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
01:00 -!- efge [~efge@195.206.169.238] has quit []
01:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:04 -!- filchef [~filchef@212.104.97.177] has quit [Ping timeout: 256 seconds]
01:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
01:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 256 seconds]
01:21 -!- andyvk5 [~andyvk5@176.113.74.179] has joined #bitcoin-core-dev
01:23 -!- Giderey36 [~Giderey36@85.208.72.251] has joined #bitcoin-core-dev
01:24 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:29 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
01:35 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
01:36 -!- kexkey [~kexkey@37.120.205.237] has joined #bitcoin-core-dev
01:42 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
01:45 -!- sdddddd [~fa@180.162.132.55] has quit [Read error: Connection reset by peer]
01:47 -!- sdddddd [~fa@240e:e0:ca6a:d000:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
01:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:01 < provoostenator> Weekend food for thought (cc sipa): what would a taproot mulitsig output descriptor look like? Is it safe to share xpub with cosigners?
02:03 < provoostenator> Musig style multisig I should add, tapscript with OP_CHECKSIGADD shouldn't be an issue.
02:04 -!- kexkey [~kexkey@37.120.205.237] has quit [Ping timeout: 255 seconds]
02:04 < provoostenator> IIUC you can't know the musig receive address without nonce (commitments). In that case you'd have an output descriptor that can't produce an address  without additional info.
02:05 < provoostenator> I guess that's no different than  a descriptor without and xpub followed by hardened derivation.
02:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:06 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
02:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:13 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
02:14 < provoostenator> Oh wait, this is actually a non issue. There's no nonces involved in public key aggregation, only in signatures: https://github.com/bitcoinops/taproot-workshop/blob/master/1.2-musig.ipynb
02:15 < provoostenator> At least for n-of-n no design changes to output descriptors seem necessary.
02:18 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
02:21 -!- Kiminuo [~mix@141.98.103.86] has joined #bitcoin-core-dev
02:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:40 -!- yevaud [~yevaud@163.172.159.188] has quit [Ping timeout: 240 seconds]
03:03 -!- Victoria32Nitzsc [~Victoria3@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]
03:05 -!- Giderey36 [~Giderey36@85.208.72.251] has quit [Ping timeout: 256 seconds]
03:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
03:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:10 -!- Victoria32Nitzsc [~Victoria3@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 258 seconds]
03:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
03:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
03:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
03:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:00 -!- andyvk5 [~andyvk5@176.113.74.179] has quit []
04:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
04:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
04:21 -!- fluffypony1 [~fluffypon@185.204.1.185] has joined #bitcoin-core-dev
04:24 -!- mol [~molly@unaffiliated/molly] has quit [Remote host closed the connection]
04:24 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
04:40 -!- Giderey36 [~Giderey36@85.208.72.251] has joined #bitcoin-core-dev
04:40 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
04:40 -!- goatpig_ [~goat@h-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
05:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:12 -!- sdddddd [~fa@240e:e0:ca6a:d000:81:7cff:fe07:f49e] has quit [Ping timeout: 256 seconds]
05:17 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
05:25 -!- sdddddd [~fa@240e:e0:ca1d:2d00:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
05:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:40 -!- sdddddd [~fa@240e:e0:ca1d:2d00:81:7cff:fe07:f49e] has quit [Ping timeout: 256 seconds]
05:41 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7.1]
05:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:46 -!- stevenroose [~steven@irc.roose.io] has quit [Quit: ZNC 1.7.4 - https://znc.in]
05:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:47 -!- stevenroose [~steven@irc.roose.io] has joined #bitcoin-core-dev
05:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
05:53 -!- sdddddd [~fa@240e:e0:ca63:3400:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
05:56 < elichai2> god. `sync.h` is complex
06:06 -!- sdddddd [~fa@240e:e0:ca63:3400:81:7cff:fe07:f49e] has quit [Ping timeout: 256 seconds]
06:06 -!- kexkey [~kexkey@37.120.205.237] has joined #bitcoin-core-dev
06:11 -!- kexkey [~kexkey@37.120.205.237] has quit [Client Quit]
06:15 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has joined #bitcoin-core-dev
06:15 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
06:19 -!- sdddddd [~fa@240e:e0:ca74:3500:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
06:19 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 255 seconds]
06:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:23 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Quit: Leaving]
06:30 -!- sdddddd [~fa@240e:e0:ca74:3500:81:7cff:fe07:f49e] has quit [Ping timeout: 256 seconds]
06:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:40 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
06:43 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
06:43 -!- sdddddd [~fa@240e:e0:ca51:b400:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
06:53 -!- sdddddd [~fa@240e:e0:ca51:b400:81:7cff:fe07:f49e] has quit [Ping timeout: 240 seconds]
07:00 -!- fluffypony1 [~fluffypon@185.204.1.185] has quit []
07:02 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
07:07 -!- sdddddd [~fa@240e:e0:ca54:e00:81:7cff:fe07:f49e] has joined #bitcoin-core-dev
07:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
07:19 -!- sdddddd [~fa@240e:e0:ca54:e00:81:7cff:fe07:f49e] has quit [Ping timeout: 256 seconds]
07:22 -!- maurits [~maurits@185.204.1.185] has joined #bitcoin-core-dev
07:39 -!- sdddddd [~fa@114.82.52.25] has joined #bitcoin-core-dev
07:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
08:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
08:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:16 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
08:20 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
08:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
08:34 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
08:39 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
08:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds]
08:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
08:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
08:54 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:59 -!- lightlike [~lightlike@p200300C7EF04A600F9A7B751C098C242.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:00 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
09:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has left #bitcoin-core-dev ["Gone frying asparagus or my Windows had a BSOD"]
09:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:16 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
09:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
09:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
09:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:33 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
09:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds]
09:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds]
09:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
09:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:55 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
09:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:00 -!- maurits [~maurits@185.204.1.185] has quit []
10:04 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 255 seconds]
10:14 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 258 seconds]
10:17 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-dev
10:19 -!- DireFog [~DireFog@104.254.90.235] has joined #bitcoin-core-dev
10:34 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
10:37 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7.1]
10:38 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
10:42 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving]
10:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]
10:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
10:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
11:00 -!- kexkey [~kexkey@37.120.205.237] has joined #bitcoin-core-dev
11:00 -!- kexkey [~kexkey@37.120.205.237] has quit [Client Quit]
11:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 255 seconds]
11:15 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
11:20 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
11:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
11:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
11:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
11:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:53 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in]
11:54 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev
11:58 -!- lightlike [~lightlike@p200300C7EF04A600F9A7B751C098C242.dip0.t-ipconnect.de] has quit [Quit: Leaving]
12:12 -!- kexkey [~kexkey@37.120.205.237] has joined #bitcoin-core-dev
12:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]
12:28 -!- marcoagner [~user@dsl-52-201.bl26.telepac.pt] has joined #bitcoin-core-dev
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/715dbbe9e8b6...54a7ef612a3b
12:35 < bitcoin-git> bitcoin/master 0aed17e Jeffrey Czyz: Refactor FormatStateMessage into ValidationState
12:35 < bitcoin-git> bitcoin/master 10e85d4 Jeffrey Czyz: Remove ValidationState's constructor
12:35 < bitcoin-git> bitcoin/master 10efc04 Jeffrey Czyz: Templatize ValidationState instead of subclassing
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:36 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17399: validation: Templatize ValidationState instead of subclassing (master...2019-11-validation-state) https://github.com/bitcoin/bitcoin/pull/17399
12:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds]
12:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:00 -!- DireFog [~DireFog@104.254.90.235] has quit []
13:48 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
13:52 -!- ferringb [~ferringb@185.189.112.19] has joined #bitcoin-core-dev
13:53 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 255 seconds]
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] v1048576 opened pull request #18236: script: prevent OP_NEGATE from generating negative zero. (master...master) https://github.com/bitcoin/bitcoin/pull/18236
13:53 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:58 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:21 < bitcoin-git> [bitcoin] v1048576 closed pull request #18236: [WIP] script: prevent OP_NEGATE from generating negative zero. (master...master) https://github.com/bitcoin/bitcoin/pull/18236
14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:24 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:30 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 255 seconds]
14:37 -!- ekrok [~ekrok@238.89-10-238.nextgentel.com] has quit [Quit: Leaving]
14:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:47 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
14:48 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:53 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
15:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:12 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
15:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:26 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
15:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:42 -!- marcoagner [~user@dsl-52-201.bl26.telepac.pt] has quit [Ping timeout: 240 seconds]
15:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
15:45 -!- hg [~hg@c-98-248-173-49.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:46 -!- hg is now known as Guest43261
15:50 -!- Guest43261 [~hg@c-98-248-173-49.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds]
16:00 -!- ferringb [~ferringb@185.189.112.19] has quit []
16:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:05 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds]
16:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
16:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:22 -!- Azor [~Azor@89.249.74.213] has joined #bitcoin-core-dev
16:36 -!- Giderey36 [~Giderey36@85.208.72.251] has quit [Read error: Connection reset by peer]
16:59 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
17:01 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
17:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
17:06 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
17:08 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
17:09 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
17:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:13 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
17:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:16 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
17:18 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
17:20 -!- promag_ [~promag@83.223.243.44] has joined #bitcoin-core-dev
17:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
17:24 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
17:29 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:41 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
18:06 -!- promag_ [~promag@83.223.243.44] has quit [Ping timeout: 256 seconds]
18:09 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
18:09 -!- Highway61 [~Thunderbi@ip184-186-2-14.no.no.cox.net] has quit [Quit: Highway61]
18:11 -!- felixfoertsch23 [~felixfoer@i6DFA6E4F.versanet.de] has quit [Ping timeout: 260 seconds]
18:15 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
19:00 -!- Azor [~Azor@89.249.74.213] has quit []
19:02 -!- felixfoertsch [~felixfoer@i6DFA6E4F.versanet.de] has joined #bitcoin-core-dev
19:04 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
19:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
19:10 -!- Highway61 [~Thunderbi@96.44.147.114] has joined #bitcoin-core-dev
19:11 -!- Highway61 [~Thunderbi@96.44.147.114] has quit [Client Quit]
19:14 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has joined #bitcoin-core-dev
19:22 -!- davidfg41 [~davidfg4@185.204.1.185] has joined #bitcoin-core-dev
19:32 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
19:33 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
19:33 -!- felixfoertsch23 [~felixfoer@2001:16b8:5096:d500:e08e:824b:5f77:3c58] has joined #bitcoin-core-dev
19:35 -!- felixfoertsch [~felixfoer@i6DFA6E4F.versanet.de] has quit [Ping timeout: 256 seconds]
19:47 -!- Klox [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Remote host closed the connection]
19:59 -!- captjakk [~captjakk@75-166-188-3.hlrn.qwest.net] has quit [Remote host closed the connection]
20:04 -!- Klox [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev
20:08 -!- Klox [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Remote host closed the connection]
20:14 -!- Klox [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:23 < bitcoin-git> [bitcoin] zachwylde00 opened pull request #18237: Create circle.ci.yml (master...master) https://github.com/bitcoin/bitcoin/pull/18237
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:24 < bitcoin-git> [bitcoin] fanquake closed pull request #18237: Create circle.ci.yml (master...master) https://github.com/bitcoin/bitcoin/pull/18237
20:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:37 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:57 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 255 seconds]
21:10 < kallewoof> So, bitcoin core right now seems to lean towards constant func/method parameters to pointers in the form "type* const" (55 instances of "CWallet* const pwallet") over "const type*" (15 instances of "const CWallet*"), but from what I understand, "type* const" means the pointer itself is const (i.e. "pwallet = blarf" is illegal) but the pointed to instance is not const (i.e. pwallet->MutableThing() is legal). I tested this 
21:10 < kallewoof> by adding a call to pwallet->handleNotifications(), a non-const marked function, and it compiles w/o issue.
21:12 < kallewoof> Switching the parameter to "const CWallet* pwallet" and recompiling gave an error, so yeah, those type* const declarations are all pretty much pointless.
21:12 < sipa> kallewoof: that's correct
21:13 < sipa> i wouldn't say it's "leaning towards"... they're completely different things
21:13 < sipa> with different meanings
21:13 < sipa> if someone wrote on while meaning the other, that's a bug
21:13 < sipa> you can also have "const Type* const varname" to make both the variable amd the pointed-to object const
21:13 < kallewoof> I can't see why "retval method(CWallet* const pwallet, ...)" would ever mean "let's not change the pwallet pointer"
21:14 < sipa> i don't understand; that is what it means
21:14 < kallewoof> Yeah I mean, I can't see the reason why anyone would wanna do that
21:15 < kallewoof> The thing expires on return anyway. If you really want to a CWallet pointer to something else, just make a new one. That's better practice anyway.
21:15 < sipa> some people like making parameters const-valued if they know the function body won't change it
21:15 < sipa> in general
21:16 < sipa> i don't (i don't think it adds much), but it's not unreasonable to mark everything you know to be const as const
21:16 < kallewoof> Yeah, that's a fair point. I do think this is easy to mis(s/understand). I did, until I looked it up again for the Nth time.
21:17 < sipa> maybe it's worth trying to make the CWallet const as well in those 55 instances
21:17 < sipa> and see if it still compiles in some of the.
21:17 < kallewoof> I'd say that the majority of those 55 "CWallet* const" parameters were indeed meant to be "const CWallet*", but I could be mistaken.
21:17 < kallewoof> Yeah, I'll give it a shot
21:17 < sipa> if so, that would be strong indication that those const markers were added in error
21:21 < luke-jr> kallewoof: the reason is so you don't accidentally change the param
21:21 < luke-jr> I certainly mean *const when I put *const :p
21:23 < fanquake> kallewoof looks like similar comments have been made before: https://github.com/bitcoin/bitcoin/pull/8775#discussion_r103283605
21:26 < kallewoof> luke-jr: you mean, so you don't accidentally set e.g. pwallet to something else while inside the method? sounds like a rather obvious thing to spot, though, but safe > sorry. I think the drawback in this case is that people who add code will see a bunch of "CWallet* const" declarations and assume they mean "immutable CWallets" when they mean "immutable pointers to mutable CWallets".
21:28 < aj> better to use "Foo&" than "Foo* const" for a class member, isn't it?
21:37 < sipa> aj: ifyou k
21:37 < sipa> if you know it can't be nullptr
21:37 < aj> fair point
21:50 < sipa> also if you store references in a class and also accept a reference type in the constructor to build it with, it may not be clear to callers that the new object's lifetime is limited to that of the argument
21:51 < sipa> if you pass a pointer, it's generally more obvious (to me, at least) that you need to be careful
22:00 -!- davidfg41 [~davidfg4@185.204.1.185] has quit []
22:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
22:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
22:28 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds]
22:55 -!- Guest47070 [~Lestaty@185.204.1.185] has joined #bitcoin-core-dev
22:58 -!- sdddddd [~fa@114.82.52.25] has quit [Ping timeout: 260 seconds]
23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:05 < bitcoin-git> [bitcoin] ajtowns opened pull request #18238: net_processing: Retry notfounds with more urgency (master...202002-bump-notfound) https://github.com/bitcoin/bitcoin/pull/18238
23:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:15 -!- manantial [~tecnecio_@92.189.192.127] has joined #bitcoin-core-dev
23:16 -!- manantial [~tecnecio_@92.189.192.127] has quit [Changing host]
23:16 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
23:19 -!- sdddddd [~fa@180.162.135.24] has joined #bitcoin-core-dev
23:24 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
23:26 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 256 seconds]
23:35 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
23:35 -!- Kiminuo [~mix@141.98.103.142] has joined #bitcoin-core-dev
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:51 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:57 < bitcoin-git> [bitcoin] promag opened pull request #18239: gui: Refactor to drop client and wallet models setters (master...2020-03-drop-setmodel) https://github.com/bitcoin/bitcoin/pull/18239
23:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Mon Mar 02 00:00:12 2020