--- Log opened Tue Mar 24 00:00:31 2020 00:00 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:00 < vasild> I am talking about buffering in ram. Buffering on disk makes no sense to me. 00:01 < sipa> buffering in ram makes no sense to me 00:01 < sipa> it's not data we likely ever need 00:03 < vasild> Maybe I would write a tool to analyze an existent blk/rev database and it would show max peak buffer size for that database, if it was downloaded in a way that out of order blocks are buffered in ram. 00:05 < sipa> the max peak buffer size is 4 GB 00:05 < sipa> 1000 blocks @ 4 MB/block 00:05 < vasild> but it feels like the similification of writing block and undo in the same order will come at a cost - complicating parallel block download with buffering out of order blocks. 00:07 < vasild> ok, sipa, aj, thanks for the explanations! 00:24 < sipa> vasild: yw! 00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:37 < bitcoin-git> [bitcoin] pierreN opened pull request #18416: Prevent num op overflows in ParseScript() helper (master...fix-parsescript-numop-overflow) https://github.com/bitcoin/bitcoin/pull/18416 00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:43 -!- vasild_ is now known as vasild 01:02 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 01:05 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 01:18 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 01:20 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 01:21 -!- brakmic_ [brakmic@gateway/vpn/nordvpn/brakmic] has joined #bitcoin-core-dev 01:23 -!- brakmic_ [brakmic@gateway/vpn/nordvpn/brakmic] has quit [Read error: Connection reset by peer] 01:23 -!- brakmic__ [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 01:24 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Ping timeout: 264 seconds] 01:25 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 01:37 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 01:40 -!- brakmic__ [~brakmic@185.183.85.108] has quit [] 01:46 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 246 seconds] 02:00 -!- greylica [~greylica@176.113.74.179] has quit [] 02:12 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 02:16 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:18 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev 02:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 02:20 -!- StarBrilliant1 [~StarBrill@185.204.1.185] has joined #bitcoin-core-dev 02:22 -!- Kiminuo [~mix@141.98.103.116] has joined #bitcoin-core-dev 02:31 -!- csknk [~csknk@88.87.164.26] has joined #bitcoin-core-dev 02:47 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:52 -!- MrSquanchee [uid421192@gateway/web/irccloud.com/x-kxyftlpyiewnudut] has joined #bitcoin-core-dev 02:56 -!- Scrat [herp@gateway/vpn/nordvpn/scrat] has joined #bitcoin-core-dev 03:08 -!- Scrat [herp@gateway/vpn/nordvpn/scrat] has left #bitcoin-core-dev [] 03:38 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:42 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 03:48 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has quit [Ping timeout: 256 seconds] 04:00 -!- apaval [~apaval@124.108.22.44] has quit [Remote host closed the connection] 04:06 -!- Priscilla43Stied [~Priscilla@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 04:17 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 260 seconds] 04:38 -!- willcl_ark__ [~quassel@95.211.225.220] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 04:50 -!- Highway61 [~Thunderbi@104.223.94.138] has joined #bitcoin-core-dev 05:00 -!- StarBrilliant1 [~StarBrill@185.204.1.185] has quit [] 05:13 -!- Priscilla43Stied [~Priscilla@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 250 seconds] 05:20 -!- hali [~hali@139.28.218.198] has joined #bitcoin-core-dev 05:53 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Read error: Connection reset by peer] 05:55 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev 06:07 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has joined #bitcoin-core-dev 06:22 < fjahr> sipa: when you looked into single block *.blk files did you also think about concatenating these to a larger file at a certain depth? At least there would not be too many small files or were there other issues caused by the file system? Just curious. 06:31 -!- someone235 [uid419897@gateway/web/irccloud.com/x-vtfqplmmluceqnyd] has joined #bitcoin-core-dev 06:40 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:45 < bitcoin-git> [bitcoin] practicalswift opened pull request #18417: tests: Add fuzzing harnesses for functions in addrdb.h, net_permissions.h and timedata.h (master...fuzzers-misc) https://github.com/bitcoin/bitcoin/pull/18417 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:28 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 07:34 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:47 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 07:52 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 07:54 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 07:59 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:00 -!- hali [~hali@139.28.218.198] has quit [] 08:03 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:07 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:12 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:13 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Quit: killed] 08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:13 < bitcoin-git> [bitcoin] fjahr opened pull request #18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 (master...groups100) https://github.com/bitcoin/bitcoin/pull/18418 08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac579ada7e83...98fbb2a1844a 08:14 < bitcoin-git> bitcoin/master 5aab011 Sebastian Falbesoner: test: add unit test for non-standard "scriptsig-not-pushonly" txs 08:14 < bitcoin-git> bitcoin/master 98fbb2a MarcoFalke: Merge #17720: test: add unit test for non-standard "scriptsig-not-pushonly... 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17720: test: add unit test for non-standard "scriptsig-not-pushonly" txs (master...20191211-test-check-for-non-standard-txs-with-non-push-scriptsig) https://github.com/bitcoin/bitcoin/pull/17720 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:14 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:16 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:19 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:21 < sipa> fjahr: no, i didn't 08:21 -!- Raccoon [~Raccoon@195.206.169.238] has joined #bitcoin-core-dev 08:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 08:24 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:29 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:34 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:35 -!- Kiminuo [~mix@141.98.103.116] has quit [Ping timeout: 256 seconds] 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/98fbb2a1844a...5236b2e267a5 08:36 < bitcoin-git> bitcoin/master a8695db practicalswift: tests: Add fuzzing harness for functions in addrdb.h 08:36 < bitcoin-git> bitcoin/master 43ff0d9 practicalswift: tests: Add fuzzing harness for functions in timedata.h 08:36 < bitcoin-git> bitcoin/master 4308aa6 practicalswift: tests: Add fuzzing harness for functions in net_permissions.h 08:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18417: tests: Add fuzzing harnesses for functions in addrdb.h, net_permissions.h and timedata.h (master...fuzzers-misc) https://github.com/bitcoin/bitcoin/pull/18417 08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:38 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:43 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:45 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:47 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:48 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 08:51 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] jonatack opened pull request #18420: test: listsinceblock block height checks (master...listsinceblock-block-height-checks) https://github.com/bitcoin/bitcoin/pull/18420 08:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:53 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 08:58 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 08:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] naumenkogs opened pull request #18421: Periodically update DNS caches for better privacy of non reachable-nodes (master...2020_03_dns_cache_update) https://github.com/bitcoin/bitcoin/pull/18421 08:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:00 -!- apaval [~apaval@124.108.22.44] has joined #bitcoin-core-dev 09:03 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:07 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:13 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:18 -!- Kiminuo [~mix@141.98.103.94] has joined #bitcoin-core-dev 09:18 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:20 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:25 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:29 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:33 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:35 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:40 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:42 < achow101> is anyone else missing bitcoin/bitcoin on the travis.org sidebar (under My Repositories)? 09:42 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:45 -!- captjakk [~captjakk@174-16-139-142.hlrn.qwest.net] has joined #bitcoin-core-dev 09:47 < achow101> oh, it looks like i've lost access to our travis stuff. no longer have the option to restart things. also lost access to HWI's travis 09:47 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:49 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 09:54 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 09:58 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:58 < bitcoin-git> [bitcoin] jnewbery opened pull request #18422: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (master...2020-03-evalchecksig) https://github.com/bitcoin/bitcoin/pull/18422 09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:00 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:01 -!- MrSquanchee [uid421192@gateway/web/irccloud.com/x-kxyftlpyiewnudut] has quit [Quit: Connection closed for inactivity] 10:03 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 246 seconds] 10:05 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:07 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:09 < bitcoin-git> [bitcoin] practicalswift opened pull request #18423: tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing. (master...fuzzers-misc-2) https://github.com/bitcoin/bitcoin/pull/18423 10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:11 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:12 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:18 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 10:23 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:25 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 10:30 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:34 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 10:39 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:40 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:44 -!- shesek [~shesek@185.3.145.94] has quit [Ping timeout: 265 seconds] 10:45 -!- Netsplit *.net <-> *.split quits: niska, jnewbery, real_or_random, treyzania, baldur, Victorsueca, achow101, sipsorcery, kanzure 10:45 -!- Netsplit over, joins: kanzure 10:45 -!- Netsplit over, joins: treyzania, achow101, niska 10:45 -!- Netsplit over, joins: sipsorcery 10:46 -!- Netsplit over, joins: Victorsueca 10:46 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev 10:48 -!- shesek [~shesek@185.3.145.94] has joined #bitcoin-core-dev 10:50 -!- jnewbery [~john@cpe-74-72-241-241.nyc.res.rr.com] has joined #bitcoin-core-dev 11:00 -!- Raccoon [~Raccoon@195.206.169.238] has quit [] 11:13 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 11:13 -!- tylerlevine6 [~hardforkt@li120-195.members.linode.com] has quit [Quit: The Lounge - https://thelounge.chat] 11:19 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 11:20 -!- skydrome1 [~skydrome@141.98.102.243] has joined #bitcoin-core-dev 11:33 < ryanofsky> I also lost travis access. related: anybody seen "Mempool sync timed out" from mempool_reorg.py? https://travis-ci.org/github/bitcoin/bitcoin/jobs/666384343 11:34 < sipa> ryanofsky: yeah i've seen that a few times the past few days 11:35 < sipa> i'm still able to restart travis jobs it seems 11:35 -!- enasigurd [enasigurd@gateway/shell/xshellz/x-yqiuofkbweobgerk] has joined #bitcoin-core-dev 11:39 -!- trotski2000_ [uid206086@gateway/web/irccloud.com/x-bxgcctbjrwpsxsol] has joined #bitcoin-core-dev 11:44 < ryanofsky> Thanks, signing out and in fixed it on my end too, also found https://www.traviscistatus.com/incidents/ntxbkxt8lrx9 11:47 < wumpus> looks like i still have access to travis for bitcoin/bitcoin 11:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:00 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 12:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 12:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:01 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 12:11 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 260 seconds] 12:13 -!- shesek [~shesek@185.3.145.94] has quit [Changing host] 12:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:28 -!- balbirs [~balbirs__@bilbo.ozlabs.org] has quit [Remote host closed the connection] 12:28 -!- balbirs [~balbirs__@bilbo.ozlabs.org] has joined #bitcoin-core-dev 12:39 < achow101> logging out and back in did not fix it for me 12:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 12:53 -!- BamBaRay36 [~2BamBaRay@213.232.87.72] has quit [Ping timeout: 264 seconds] 12:56 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 12:56 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:00 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 13:03 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 13:06 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 13:12 -!- captjakk [~captjakk@174-16-139-142.hlrn.qwest.net] has quit [Remote host closed the connection] 13:14 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 13:17 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 265 seconds] 13:19 -!- BamBaRay36 [~2BamBaRay@213.232.87.72] has joined #bitcoin-core-dev 13:25 -!- dviola [~diego@187.39.21.46] has joined #bitcoin-core-dev 13:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:33 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 13:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:57 < bitcoin-git> [bitcoin] hebasto opened pull request #18424: qt: Use parent-child relation to manage lifetime of OptionsModel object (master...20200324-options-model) https://github.com/bitcoin/bitcoin/pull/18424 13:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:59 < bitcoin-git> [bitcoin] achow101 opened pull request #18425: releases: Update with new Windows code signing certificate (master...win-cert-3-20) https://github.com/bitcoin/bitcoin/pull/18425 13:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 -!- skydrome1 [~skydrome@141.98.102.243] has quit [] 14:01 -!- dviola [~diego@187.39.21.46] has quit [Changing host] 14:01 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 14:01 -!- dviola [~diego@unaffiliated/dviola] has left #bitcoin-core-dev ["WeeChat 2.7.1"] 14:01 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 14:07 -!- felixfoertsch [~felixfoer@2001:16b8:50d0:9800:ad41:93ff:f87d:6ee7] has quit [Ping timeout: 272 seconds] 14:14 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:15 -!- felixfoertsch [~felixfoer@200116b840340e00ad4193fff87d6ee7.dip.versatel-1u1.de] has joined #bitcoin-core-dev 14:22 -!- rejon1 [~rejon@84.39.117.57] has joined #bitcoin-core-dev 14:27 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 250 seconds] 14:37 -!- csknk [~csknk@88.87.164.26] has quit [Quit: leaving] 14:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 14:54 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:54 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:20 < bitcoin-git> [bitcoin] theStack opened pull request #18426: scripts: previous_release: improve behaviour on failed download (master...20200324-scripts-previous-release-show-error-message-if-download-fails) https://github.com/bitcoin/bitcoin/pull/18426 15:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:00 -!- apaval [~apaval@124.108.22.44] has quit [Remote host closed the connection] 16:00 -!- apaval [~apaval@124.108.22.44] has joined #bitcoin-core-dev 16:08 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 16:14 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 246 seconds] 16:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 16:26 -!- kvaciral [~kvaciral@185.198.57.211] has quit [Quit: Lost terminal] 16:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:33 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:38 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 16:56 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 17:00 -!- rejon1 [~rejon@84.39.117.57] has quit [] 17:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:04 -!- felixfoertsch [~felixfoer@200116b840340e00ad4193fff87d6ee7.dip.versatel-1u1.de] has quit [Ping timeout: 246 seconds] 17:11 < luke-jr> did anyone ever confirm that #17740 doesn't reintroduce CVE-2012-1910? 17:11 < gribble> https://github.com/bitcoin/bitcoin/issues/17740 | build: remove configure checks for win libraries we dont link against by fanquake · Pull Request #17740 · bitcoin/bitcoin · GitHub 17:12 < fanquake> luke-jr: Those checks don't determine what is linked against 17:14 < fanquake> From what I remember we did discuss that in the issue, and the only libs that were removed were unused. 17:15 < luke-jr> fanquake: it's supposed to 17:15 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 264 seconds] 17:17 < fanquake> You're right. I've just re-read, and at the time I did check that none of those libs were being passed to the linker 17:20 -!- felixfoertsch [~felixfoer@i6DFA6313.versanet.de] has joined #bitcoin-core-dev 17:22 -!- hmachado [~hmachado@195.206.183.79] has joined #bitcoin-core-dev 17:22 < luke-jr> which makes my question: have we reintroduced it previously? XD 17:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:24 < fanquake> luke-jr: I'll look. btw if you've got time can you rebase #15704 17:24 < gribble> https://github.com/bitcoin/bitcoin/issues/15704 | Move Win32 defines to configure.ac to ensure they are globally defined by luke-jr · Pull Request #15704 · bitcoin/bitcoin · GitHub 17:26 < fanquake> This is the link for master: https://gist.github.com/fanquake/7d1c147ba28a36b1690e8b42bed3bfc8 17:28 < luke-jr> well, of course it won't be linking with the removed checks _now_ :P 17:30 < luke-jr> if I add the AC_CHECK_LIB back in, it seems to link to it 17:33 < fanquake> luke-jr: It's the same for something like winspool though right? It'll link to it even though we don't use it 17:33 < luke-jr> fanquake: using threads in mingw requires linking it 17:33 < luke-jr> otherwise we get thread-unsafe stuff linked in 17:33 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 260 seconds] 17:35 < fanquake> Can you point to any mingwthrd documentation? I'm struggling to find anything that isn't close to 10+ years old 17:36 < luke-jr> -mthreads 17:36 < luke-jr> Support thread-safe exception handling on MinGW. Programs that rely on thread-safe exception handling must compile and link all code with 17:36 < luke-jr> the -mthreads option. When compiling, -mthreads defines -D_MT; when linking, it links in a special thread helper library -lmingwthrd which 17:36 < luke-jr> cleans up per-thread exception-handling data. 17:36 < luke-jr> from `man gcc` 17:37 < luke-jr> (-mthreads IIRC is itself broken for static linking though) 17:38 * fanquake looking 17:42 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 17:42 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 17:48 < luke-jr> wumpus: ping^ in case you investigated already 17:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:56 < luke-jr> fanquake: http://gavintech.blogspot.com/2012/03/full-disclosure-bitcoin-qt-on-windows.html 17:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 18:01 -!- Highway61 [~Thunderbi@104.223.94.138] has quit [Quit: Highway61] 18:10 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has joined #bitcoin-core-dev 18:12 < fanquake> luke-jr: I can’t test right now but will by the end of the day 18:15 < luke-jr> I'm working on it; will just dig out the Windows test box 18:16 -!- Krellan_ [~Krellan@2601:640:4100:e:8453:2472:8414:d108] has quit [Ping timeout: 246 seconds] 18:16 < fanquake> Just make sure you update it first so you don’t get RCE’d 18:21 < luke-jr> RCE'd? 18:22 < luke-jr> or I should ask: which one? :p 18:40 -!- GreyJediCode [~Jarvis@24-212-233-230.cable.teksavvy.com] has joined #bitcoin-core-dev 18:47 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:20 < luke-jr> 21633 ? S 0:00 /usr/bin/i686-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -pie -static -Wl,--large-address-aware -o bitcoin-cli.exe bitcoin_cli-bitcoin-cli.o bitcoin-cli-res.o -L/home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../lib libbitcoin_cli.a 19:20 < luke-jr> univalue/.libs/libunivalue.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a -lboost_system-mt-s-x32 -lboost_filesystem-mt-s-x32 -lboost_thread-mt-s-x32 -levent -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 - 19:20 < luke-jr> ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread 19:20 < luke-jr> so -lmingwthrd is definitely being passed here 19:26 -!- Klox [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 19:29 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.7.1] 19:30 < fanquake> luke-jr: looking at the mingw-w64 source, in regards to mingwthrd I'm seeing: As _CRT_MT is getting defined in libgcc when using shared version, or it is getting defined by startup code itself, this library is a dummy version for supporting the link library for gcc's option -mthreads. As we support TLS-cleanup even without specifying this library, this library is deprecated and just kept for compatibility. 19:31 < fanquake> The only code in mingwthrd_mt.c is: int _CRT_MT_OLD = 1; 19:31 < fanquake> mingwthrd_mt.c is the source for libmingwthrd.a 19:33 < fanquake> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-crt/libsrc/mingwthrd_mt.c 19:41 < luke-jr> that file hasn't changed since Date: Fri Jun 26 10:49:35 2009 +0000 19:42 < fanquake> Yea I'm looking at the history now. Those changes happened in 22b6398a8acf17e6687375c414fae832888de53a 19:42 < luke-jr> we also don't have a minimum mingw version afaik 19:43 < luke-jr> if we decide to bump it, we should also check it meets the required version 19:44 < luke-jr> that commit first released in 2.0, sometime after Date: Tue Oct 4 15:17:14 2011 +0000 19:44 < luke-jr> but CVE-2012-1910 was Date: 2012-03-17 19:45 < fanquake> Right, because gitian builds would likely have been done with an older version of mingw-w64 19:46 -!- justan0theruser [~justanoth@2600:8804:980:523:b996:c6a6:556:cf14] has joined #bitcoin-core-dev 19:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 19:47 * luke-jr checking that 19:49 < fanquake> Need to find out what version of mingw-w64 was shipping with ubuntu lucid 19:49 < fanquake> *mingw32 19:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 19:53 < luke-jr> Version: 3.15.2-0ubuntu1 19:53 < luke-jr> :/ 19:54 < luke-jr> there is no 3.15 tho 19:55 -!- GreyJediCode [~Jarvis@24-212-233-230.cable.teksavvy.com] has quit [Quit: Leaving] 19:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:56 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has quit [Ping timeout: 265 seconds] 20:00 -!- hmachado [~hmachado@195.206.183.79] has quit [] 20:00 < luke-jr> mingwrt-3.15.2-mingw32/include/_mingw.h:#define __MINGW32_VERSION 3.15.2 20:00 < luke-jr> sigh 20:01 < luke-jr> I propose we just add mingwthrd back in. It's harmless at worst. 20:06 < luke-jr> 26805 ? S 0:00 /usr/bin/x86_64-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie -static -o bitcoind.exe bitcoind-bitcoind.o bitcoind-res.o -L/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../lib libbitcoin_server.a libbitcoin_ 20:06 < luke-jr> wallet.a libbitcoin_common.a univalue/.libs/libunivalue.a libbitcoin_util.a libbitcoin_zmq.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a leveldb/libleveldb.a crc32c/libcrc32c.a crc32c/libcrc32c_sse42.a leveldb/libmemenv.a secp256k1/.libs/libsecp256k1.a -lboost_system-mt-s-x64 -lboost_filesystem-mt-s-x64 -lboost_thread-mt-s-x64 -ldb_ 20:06 < luke-jr> cxx-4.8 -lminiupnpc -levent -lzmq -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread 20:06 < luke-jr> so x86_64 uses it too 20:10 < fanquake> I just checked that binaries produced with and without -lmingwthrd are basically identical. I see 5 bytes difference, and that's the git commit and what looks like 2 timestamps. 20:13 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:13 < bitcoin-git> [bitcoin] luke-jr opened pull request #18427: Bugfix? Restore linking to libmingwthrd (master...2020mingwthrd) https://github.com/bitcoin/bitcoin/pull/18427 20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:20 -!- laen_ [~laen_@176.113.74.179] has joined #bitcoin-core-dev 20:23 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:24 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 20:27 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 20:29 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 20:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 20:32 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 20:34 -!- justan0theruser [~justanoth@2600:8804:980:523:b996:c6a6:556:cf14] has quit [Quit: WeeChat 2.7.1] 20:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:38 -!- Highway61 [~Thunderbi@66.154.110.242] has joined #bitcoin-core-dev 20:44 -!- felixfoertsch23 [~felixfoer@i6DFA620C.versanet.de] has joined #bitcoin-core-dev 20:47 -!- felixfoertsch [~felixfoer@i6DFA6313.versanet.de] has quit [Ping timeout: 264 seconds] 21:14 < fanquake> MarcoFalke: did DrahtBot get an upgrade: https://github.com/bitcoin/bitcoin/pull/18426#discussion_r397534721 21:16 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:19 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has joined #bitcoin-core-dev 21:59 -!- Highway61 [~Thunderbi@66.154.110.242] has quit [Ping timeout: 250 seconds] 22:19 -!- Krellan_ [~Krellan@c-24-130-205-67.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 22:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:44 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 22:48 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 22:50 -!- apaval [~apaval@124.108.22.44] has quit [Ping timeout: 258 seconds] 22:58 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 22:59 -!- Highway61 [~Thunderbi@66.154.110.242] has joined #bitcoin-core-dev 22:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 22:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 23:00 -!- laen_ [~laen_@176.113.74.179] has quit [] 23:13 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-dev 23:21 -!- zerstoerer [~zerstoere@192.145.126.115] has joined #bitcoin-core-dev 23:23 -!- tsujp [~tsujp@163.47.59.73] has joined #bitcoin-core-dev 23:33 -!- tsujp [~tsujp@163.47.59.73] has quit [Read error: No route to host] 23:34 -!- tsujp [~tsujp@163.47.59.73] has joined #bitcoin-core-dev 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:36 < bitcoin-git> [bitcoin] kallewoof closed pull request #16440: BIP-322: Generic signed message format (master...feature-generic-signed-message-format) https://github.com/bitcoin/bitcoin/pull/16440 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:38 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.] 23:39 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 23:47 -!- tsujp [~tsujp@163.47.59.73] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:51 -!- Kiminuo [~mix@141.98.103.94] has quit [Ping timeout: 240 seconds] 23:58 -!- apaval [~apaval@68.183.88.61] has joined #bitcoin-core-dev --- Log closed Wed Mar 25 00:00:29 2020