--- Log opened Thu Apr 02 00:00:40 2020
00:04 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:19 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
00:21 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
00:24 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
00:24 < wumpus> fanquake: done
00:29 -!- mrostecki [mrosteckim@gateway/shell/matrix.org/x-vxmqijyeumrtcxwm] has quit [Quit: killed]
00:29 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-varqpujdivceaowa] has quit [Quit: killed]
00:29 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-rcwygjdzteempiky] has quit [Quit: killed]
00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
00:44 -!- vasild_ is now known as vasild
00:44 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
00:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
00:54 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:56 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-wwlnqkaihrrrlsvy] has joined #bitcoin-core-dev
01:02 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-hwtfxdqfnnsfqelt] has joined #bitcoin-core-dev
01:02 -!- mrostecki [mrosteckim@gateway/shell/matrix.org/x-shgdamvxmtjeighl] has joined #bitcoin-core-dev
01:14 -!- jarthur_ [~jarthur@2605:6000:1019:4971:91dd:6a15:d0d6:6f41] has joined #bitcoin-core-dev
01:15 -!- jarthur_ [~jarthur@2605:6000:1019:4971:91dd:6a15:d0d6:6f41] has quit [Remote host closed the connection]
01:17 -!- jarthur [~jarthur@2605:6000:1019:4971:d92b:645d:968b:6713] has quit [Ping timeout: 240 seconds]
01:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
01:31 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev
01:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
01:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
01:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
01:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:37 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
01:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
02:00 -!- michal_kubenka [~michal_ku@176.113.74.179] has quit []
02:01 -!- guest534543 [~mix@141.98.103.174] has joined #bitcoin-core-dev
02:01 -!- ogu [~ogu@213.74.213.65] has joined #bitcoin-core-dev
02:03 -!- Kiminuo [~mix@141.98.103.174] has quit [Ping timeout: 265 seconds]
02:04 -!- oguzkoroglu [~ogu@213.74.213.65] has quit [Ping timeout: 265 seconds]
02:06 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
02:12 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
02:13 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
02:21 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
02:22 -!- MononcQc1 [~MononcQc@77.243.177.38] has joined #bitcoin-core-dev
02:24 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Read error: Connection reset by peer]
02:25 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
02:29 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
02:38 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:51 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has joined #bitcoin-core-dev
02:53 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:53 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:53 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has quit [Client Quit]
02:54 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has joined #bitcoin-core-dev
02:55 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
02:56 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
02:57 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
02:58 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:58 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
02:59 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:01 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
03:01 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds]
03:04 -!- Gianni41Nicolas [~Gianni41N@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev
03:05 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
03:06 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:13 -!- Gianni41Nicolas [~Gianni41N@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds]
03:17 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has quit [Quit: Sleep mode]
03:21 -!- cdecker_ [~cdecker@mail.snyke.net] has quit [Quit: Bye bye]
03:21 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev
03:24 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has joined #bitcoin-core-dev
03:24 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:11be:312f:adcf:42dd] has quit [Client Quit]
03:26 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
03:44 < promag> wumpus: in #18482 kryvel verified that #18487 fixes the deadlock
03:44 < gribble> https://github.com/bitcoin/bitcoin/issues/18482 | RPC stuck on walletpassphrase call · Issue #18482 · bitcoin/bitcoin · GitHub
03:44 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/41fa2926d86a...5c1ba3a10a18
03:48 < bitcoin-git> bitcoin/master a46484c Ben Woosley: build: Detect gmtime_* definitions via configure
03:48 < bitcoin-git> bitcoin/master 5c1ba3a Wladimir J. van der Laan: Merge #18358: util: fix compilation with mingw-w64 7.0.0
03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:48 < bitcoin-git> [bitcoin] laanwj merged pull request #18358: util: fix compilation with mingw-w64 7.0.0 (master...mingw_w64_gmtime_s) https://github.com/bitcoin/bitcoin/pull/18358
03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:50 < promag> still thing #16923 is good for 0.20, hebasto and jonatack__ did a good review/test there
03:50 < gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub
04:09 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
04:11 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
04:15 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
04:16 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has quit [Ping timeout: 240 seconds]
04:17 < hebasto> wumpus: fanquake: it seems we need cd1e7bb064315ce909dfa1a0a14a5660d985f266 from 0.19 in the master before branching off to fix #17010, no?
04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/17010 | Missing Boost::System on ARM Ubuntu 18.04 · Issue #17010 · bitcoin/bitcoin · GitHub
04:21 -!- Highway61 [~Thunderbi@192.252.213.14] has joined #bitcoin-core-dev
04:21 -!- theStack [~theStack@81.223.165.6] has joined #bitcoin-core-dev
04:22 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:23 < hebasto> https://github.com/bitcoin/bitcoin/commit/cd1e7bb064315ce909dfa1a0a14a5660d985f266
04:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:37 -!- Highway62 [~Thunderbi@104.223.94.154] has joined #bitcoin-core-dev
04:38 -!- Highway61 [~Thunderbi@192.252.213.14] has quit [Ping timeout: 240 seconds]
04:38 -!- Highway62 is now known as Highway61
04:47 -!- Highway61 [~Thunderbi@104.223.94.154] has quit [Remote host closed the connection]
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:48 < bitcoin-git> [bitcoin] hebasto opened pull request #18501: build: Fix boost detection on Ubuntu ARM 18.04 (master...20200402-boost-arm) https://github.com/bitcoin/bitcoin/pull/18501
04:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:48 -!- Highway61 [~Thunderbi@104.223.94.154] has joined #bitcoin-core-dev
04:54 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in]
04:55 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev
04:55 -!- oguz [~ogu@176.88.44.188] has joined #bitcoin-core-dev
04:57 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
04:58 -!- ogu [~ogu@213.74.213.65] has quit [Ping timeout: 258 seconds]
04:59 -!- oguz [~ogu@176.88.44.188] has quit [Client Quit]
05:00 -!- MononcQc1 [~MononcQc@77.243.177.38] has quit []
05:00 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:00 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:01 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
05:04 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #bitcoin-core-dev
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18500: chainparams: Bump assumed valid hash (master...2004-chainparamsBump) https://github.com/bitcoin/bitcoin/pull/18500
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18500: chainparams: Bump assumed valid hash (master...2004-chainparamsBump) https://github.com/bitcoin/bitcoin/pull/18500
05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:16 < bitcoin-git> [bitcoin] uzyn opened pull request #18502: doc: Update docs for getbalance (default minconf should be 0) (master...doc-getbalance) https://github.com/bitcoin/bitcoin/pull/18502
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18503: init: Replace URL_WEBSITE with PACKAGE_URL (master...2004-initRebrand) https://github.com/bitcoin/bitcoin/pull/18503
05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:19 -!- Highway61 [~Thunderbi@104.223.94.154] has quit [Ping timeout: 240 seconds]
05:20 -!- Highway61 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev
05:21 -!- Fare [~Fare@192.145.126.115] has joined #bitcoin-core-dev
05:22 -!- Fare is now known as Guest54802
05:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
05:38 < luke-jr> maybe we should just remove getbalance if it isn't going to get fixed :x
05:57 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:58 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:03 < instagibbs> I thought getbalances was going to replace it anyways
06:03 < wumpus> hebasto: if we don't want that in master, then we need to cherry-pick it *after* the branch off right?
06:03 < instagibbs> i guess i don't see any deprecation on that tho
06:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:04 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
06:04 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
06:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
06:06 < luke-jr> instagibbs: yeah, that was my understanding as well
06:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
06:09 < wumpus> I don't think we should be deprecating wallet RPCs left and right tbh
06:09 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds]
06:09 < wumpus> every change requires changes to all software using bitcoin core, sure, sometimes it's really unavoidable (APIs that don't make sense anymore given our implementation, or are a lot of bother to maintain), but I don't think `getbalance` is that
06:10 < hebasto> wumpus: https://github.com/autoconf-archive/autoconf-archive/pull/198 seems stalled. What plan do you suggest for master?
06:10 < luke-jr> wumpus: it's been broken for several releases now tho
06:12 < wumpus> if we can't find a way to handle this that is acceptable to autoconf upstream, we should probably drop it completely
06:13 < hebasto> ok
06:14 < luke-jr> eh, but the current upstream is broken?
06:15 < jonatack__> luke-jr: before removing getbalance, i began with removing getunconfirmedbalance with #18451 
06:15 < gribble> https://github.com/bitcoin/bitcoin/issues/18451 | rpc: remove deprecated getunconfirmedbalance by jonatack · Pull Request #18451 · bitcoin/bitcoin · GitHub
06:15 < luke-jr> there's already autoconf stuff to handle this afaik
06:15 < jonatack__> but no hurry and they need to go through a deprecation process
06:16 -!- jonatack__ [~jon@37.170.215.215] has quit [Quit: jonatack__]
06:17 -!- jonatack [~jon@37.170.215.215] has joined #bitcoin-core-dev
06:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
06:21 < wumpus> well on the plus side, at some point we might not need boost anymore and can close the issue :')
06:24 < wumpus> in any case I don't have a strong opinion about it, if the build system ppl thing it's ok to merge our own version into master now and risk overwriting it later that's fine with me too
06:25 < aj> wumpus: (we need boost for multi_index_container in txmempool; seems hard to do away with)
06:25 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:25 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Remote host closed the connection]
06:25 < luke-jr> is there a reason we need the boost lib path at all?
06:25 < luke-jr> why can't it just use -lboost_*
06:25 < luke-jr> ?
06:26 < wumpus> aj: sure but I mean if that's the only thing left, we can probably find a replacment
06:26 < wumpus> luke-jr: because -lboost_ doesn't work if the right -L is not specified
06:26 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #bitcoin-core-dev
06:26 < wumpus> boost libraries are not in the linker default library path
06:26 < luke-jr> wumpus: unlikely, we're probably going to add boost::process soon?
06:26 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
06:26 < luke-jr> wumpus: yes they are?
06:27 < wumpus> in modern libraries this is solved by pkg-config and similar mechanisms but ofc boost needs to be special
06:27 < luke-jr> and this m4 stuff only checks the default library paths anyway
06:27 < aj> wumpus: sure, as far as i can tell, boost's is actually pretty good though
06:27 < wumpus> aj: okay it's fine if people want to stick with boost forever now that's ok with me too
06:27 < wumpus> this changes every few months
06:28 < aj> wumpus: boost forever would be a great pr idea in about 364 days i guess
06:28 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
06:28 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
06:29 < luke-jr> probably will be some time before all of our boost needs are in C++ std
06:29 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
06:29 < wumpus> aj: I"m just tired of the back and forth, one day there's a flurry of 'move away form boost' PRs the next everyone is defending boost
06:30 < aj> wumpus: ah, sorry then. didn't mean to end up on the defending boost side
06:30 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
06:31 < luke-jr> wumpus: it makes sense to migrate stuff from boost to C++ std, but C++ std doesn't do everything yet
06:31 < wumpus> aj: no problem, sorry, not feeling well at the moment shoudln't take it out on you
06:31 < aj> wumpus: i am feeling well, so it's fine :)
06:41 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
06:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
06:41 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:44 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6bdd515ccf1b...b83565625e32
06:44 < bitcoin-git> bitcoin/master 222253e MarcoFalke: chainparams: Bump assumed valid hash
06:44 < bitcoin-git> bitcoin/master b835656 Wladimir J. van der Laan: Merge #18500: chainparams: Bump assumed valid hash
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:44 < bitcoin-git> [bitcoin] laanwj merged pull request #18500: chainparams: Bump assumed valid hash (master...2004-chainparamsBump) https://github.com/bitcoin/bitcoin/pull/18500
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
07:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
07:17 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:26 < bitcoin-git> [bitcoin] laanwj opened pull request #18506: net: Hardcoded seeds update for 0.20 (master...2020_04_hardcoded_seeds) https://github.com/bitcoin/bitcoin/pull/18506
07:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:52 -!- guest534543 [~mix@141.98.103.174] has quit [Ping timeout: 240 seconds]
07:53 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
07:57 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!]
08:00 -!- Guest54802 [~Fare@192.145.126.115] has quit []
08:13 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
08:13 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
08:13 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:17 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:21 < luke-jr> bleh, my comma removal screwed up other formatting
08:21 -!- skorgon [~skorgon@141.98.102.235] has joined #bitcoin-core-dev
08:23 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
08:26 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
08:30 < promag> MarcoFalke: I can pick your commit if you want
08:30 < promag> btw, comment added
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:31 < bitcoin-git> [bitcoin] luke-jr opened pull request #18508: RPC: Fix more formatting nits (master...rpcdoc_format_20200402) https://github.com/bitcoin/bitcoin/pull/18508
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:42 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
08:44 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
09:09 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection]
09:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
09:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
09:23 -!- tryphe_ is now known as tryphe
09:28 -!- jarthur [~jarthur@2605:6000:1019:4971:c167:6add:93a5:3b9a] has joined #bitcoin-core-dev
09:29 -!- jarthur [~jarthur@2605:6000:1019:4971:c167:6add:93a5:3b9a] has quit [Remote host closed the connection]
09:29 -!- jarthur [~jarthur@2605:6000:1019:4971:91f6:7e3:18e9:b431] has joined #bitcoin-core-dev
09:32 -!- Kiminuo [~mix@141.98.103.92] has joined #bitcoin-core-dev
09:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
09:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
09:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
09:46 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev
09:46 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection]
09:52 < MarcoFalke> Looks like #18487 , #18487 and #18487 are the last three things to get in before branch-off?
09:52 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
09:52 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
09:52 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
09:53 < MarcoFalke> * #18458 #18506
09:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18458 | net: Add missing cs_vNodes lock by MarcoFalke · Pull Request #18458 · bitcoin/bitcoin · GitHub
09:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18506 | net: Hardcoded seeds update for 0.20 by laanwj · Pull Request #18506 · bitcoin/bitcoin · GitHub
09:54 < MarcoFalke> Even if they miss, they can be backported. I think we should open the master branch again for merges for 0.21
09:57 < luke-jr> #18192 and #18465 should be fixed before rc1 IMO
09:57 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
09:57 < gribble> https://github.com/bitcoin/bitcoin/issues/18465 | bitcoin-tx (and probably others) fails to build without libevent · Issue #18465 · bitcoin/bitcoin · GitHub
09:57 < promag> well no need to hold them, you can backport a revert \m/
09:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:07 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
10:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]
10:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:19 -!- filchef [~fiilchef@212.104.97.177] has joined #bitcoin-core-dev
10:21 < MarcoFalke> There will always be bugs and bugfixes, which can be backported after sufficient review. But at some point we need to open master again.
10:21 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
10:23 < achow101> instagibbs: sipa: it turns out that signing with all spkmans still doesn't work for traditional signrawtransaction* workflows. It should work with PSBTs though. Could we just tell everyone who wants to use descriptor wallets to use PSBT and just disable *rawtransaction RPCs for it as well?
10:25 -!- jonatack_ [~jon@37.166.71.71] has joined #bitcoin-core-dev
10:26 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
10:28 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
10:28 -!- jonatack [~jon@37.170.215.215] has quit [Ping timeout: 265 seconds]
10:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:31 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev
10:31 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection]
10:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds]
10:34 < sipa> achow101: hmm, why not?
10:34 < sipa> (i don't actually understand the issue)
10:37 -!- filchef|2 [~fiilchef@212.104.97.177] has joined #bitcoin-core-dev
10:38 -!- filchef|2 [~fiilchef@212.104.97.177] has quit [Client Quit]
10:40 < achow101> We need to know the reddenScript but that would worker not be in the wallet, or be in a different spkman
10:41 < achow101> So the spkman currently attending to sign doesn't know the redeemScript
10:41 < achow101> *attempting
10:43 < sipa> can't you import it?
10:45 < sipa> oh, i see
10:45 < sipa> because the private key will be in a different spkman than the one that knows the redeemscript?
10:45 < achow101> Yes
10:46 < achow101> i suppose one method could be to convert everything into PSBTs internally and just pass around PSBTs between the spkmans
10:47 < sipa> or make private keys global for the entire wallet
10:48 < sipa> but converting everything to PSBTs internally seems like a good idea in any case
10:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:50 < achow101> since descriptor wallets is currently an optional feature, I would be fine with requiring PSBTs for now
10:50 < achow101> then change the wallet to use PSBTs internally everywhere to solve this particular issue
10:50 < achow101> I do have a long term goal of making the wallet use PSBTs everywhere anyways
10:53 < sipa> agreed
10:55 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
10:57 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
11:00 -!- skorgon [~skorgon@141.98.102.235] has quit []
11:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:04 < promag> hi
11:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:05 < fjahr> I think meeting starts in one hour
11:05 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
11:05 < promag> fjahr: right, summer time
11:06 -!- filchef [~fiilchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
11:06 < promag> thanks
11:06 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
11:09 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
11:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b83565625e32...ff53433fe4ed
11:13 < bitcoin-git> bitcoin/master 6112a20 Jon Atack: test: replace (send_message + sync_with_ping) with send_and_ping
11:13 < bitcoin-git> bitcoin/master ff53433 MarcoFalke: Merge #18494: test: replace (send_message + sync_with_ping) with send_and_...
11:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18494:  test: replace (send_message + sync_with_ping) with send_and_ping (master...send_and_ping) https://github.com/bitcoin/bitcoin/pull/18494
11:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:20 -!- subdriven1 [~subdriven@192.145.126.115] has joined #bitcoin-core-dev
11:25 < wumpus> emzy: your list contains no 0.19.x nodes at all, that's weird!
11:26 < emzy> strange. But I think I'm on master
11:27 < wumpus> but e.g. cat seeds_sipa.txt |grep "Satoshi:0\\.19"|wc  gives 4026 matches, doing the same for your list gives none :/
11:28 < wumpus> I'm going to merge alle the lists and deduplicate so for me it's not a big deal, but it might indicate a problem with your crawler
11:28 < emzy> I will invastigate later.
11:31 < emzy> after update to master I have 0.19 clients
11:31 < emzy> so sorry wrong grep. there are still none.
11:34 < sipa> i wonder if i turned off tor after realizing it made crawling super slow
11:35 < sipa> my % of outgoing connections of my crawler is going up
11:40 < emzy> do I have to generate the seeds.txt.gz file?
11:41 < emzy> Ok seems to be this: dnsseed.dump  S
11:42 < emzy> So it was my fault. I had a old seeds.txt.gz file.
11:42 < sipa> yeah, it's a gzip of the dnsseed.dump file
11:47 < emzy> like: gzip --best <dnsseed.dump >seeds.txt.gz
11:47 < emzy> I put a old file up. :(
11:49 < wumpus> emzy: no problem, can you post a new one please?
11:50 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-xeemlvjxnmvjoimv] has joined #bitcoin-core-dev
11:51 < emzy> I also deleted my dnsseed.dump and all other files. So I will have to wait until it is full again. I only have 902 lines in the file.
11:53 < sipa> ah, that's unfortunate
11:54 < emzy> And no backup for that server :(
11:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
11:57 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
11:57 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
12:00 < wumpus> hopefully someone has a list with recent onions in them
12:00 < emzy> no onions in my file now :(
12:01 < wumpus> #startmeeting
12:01 < lightningbot> Meeting started Thu Apr  2 19:01:12 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:01 < jonasschnelli> hi
12:01 < sipsorcery> hi
12:01 < hebasto> hi
12:01 < cfields> hi
12:01 < fjahr> hi
12:01 < sipa> hi
12:01 < amiti> hi
12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
12:01 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
12:01 < jkczyz> hi
12:01 < jb55> hi
12:02 < achow101> hi
12:02 < jonatack_> hi
12:02 < nehan_> hi
12:02 < wumpus> no proposed topics for this week, it appears
12:02 < elichai2> Hi
12:02 < wumpus> any last minute ones?
12:03 < jeremyrubin> hi
12:03 < luke-jr> wumpus: I saw one earlier.. :p
12:03 < jeremyrubin> Hope everyone is safe & healthy :)
12:03 < luke-jr> 0.20 bugfixes
12:03 < luke-jr> or smth like that
12:03 < wumpus> FWIW it's time to do the branch-off for 0.20
12:03 < wumpus> and release rc1
12:03 < wumpus> luke-jr: don't see it in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt, but that makes sense
12:04 < luke-jr> IMO #18192 and #18465 should be fixed before rc1
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/18465 | bitcoin-tx (and probably others) fails to build without libevent · Issue #18465 · bitcoin/bitcoin · GitHub
12:04 < luke-jr> could perhaps still branch off anyway, as they're not really ready :/
12:05 < luke-jr> 18192 only affects avoid-reuse wallets, but the harm is irrepairable once affected
12:05 < wumpus> those are not even tagged for 0.20
12:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:05 < promag> hi
12:06 < wumpus> unless they're realy urgent might include them in a later rc or 0.20.1 
12:06 < sipa> are they 0.20 regressions?
12:06 < dongcarl> hi
12:06 < luke-jr> not regressions, no
12:07 < luke-jr> I suppose 18465 has an easy workaround
12:07 < sipa> when was 18192 introduced?
12:07 < sipa> or when was the problem it solves introduced?
12:07 < luke-jr> when avoid-reuse wallets were introduced, 0.19.0 IIRC
12:08 < sipa> this sounds moderately serious... i suspect we just haven't heard about it much because few people enable that setting, i expect?
12:08 < luke-jr> maybe; I don't know how popular it is
12:09 < luke-jr> IMO if we don't fix it, we should at least put it in rel notes as a known issue
12:09 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
12:09 < achow101> i doubt people really use multiwallet or create non-default wallets
12:09 < luke-jr> achow101: it's not multiwallet-related
12:09 < achow101> luke-jr: but you have to be using the multiwallet feature to enable it
12:10 < achow101> i.e. create a new wallet
12:10 < luke-jr> hmm
12:11 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds]
12:11 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
12:12 < luke-jr> also from earlier [16:52:31] <MarcoFalke> Looks like #18487 , #18487 and #18487 are the last three things to get in before branch-off?
12:12 < achow101> oh wait, we can use the setwalletflag rpc to enable it. but that requires knowing what you're doing. it's not exposed in the gui
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
12:12 < luke-jr> rtt
12:12 < luke-jr> err*
12:12 < luke-jr> [16:53:06] <MarcoFalke> * #18458 #18506
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18458 | net: Add missing cs_vNodes lock by MarcoFalke · Pull Request #18458 · bitcoin/bitcoin · GitHub
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18506 | net: Hardcoded seeds update for 0.20 by laanwj · Pull Request #18506 · bitcoin/bitcoin · GitHub
12:13 < promag> lol
12:13 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
12:13 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
12:13 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
12:14 < wumpus> yes those are tagged https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.20.0
12:14 < luke-jr> 18192 & 18465 should probably at least get tagged, even if they end up slipping the release
12:15 < wumpus> ok
12:15 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds]
12:17 < jonatack_> another avoid_reuse related bugfix is #17824 (2 acks)
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/17824 | wallet: Prefer full destination groups in coin selection by fjahr · Pull Request #17824 · bitcoin/bitcoin · GitHub
12:17 < wumpus> this adds way more things last-minute for 0.20 than I expected
12:18 < jonatack_> (not saying it's as urgent)
12:18 < sipa> 17824 seems like a bigger change
12:18 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
12:18 < wumpus> we could also add a note to the release notes that avoid-reuse is buggy
12:18 < wumpus> or disable it
12:18 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
12:19 < wumpus> oh wait it was introduced in 0.19 not 0.20
12:19 < wumpus> so not that
12:22 < sipa> maybe let's prioritize review on #18192, and see how far we get?
12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
12:22 < sipa> if not, a release note can always be added
12:23 < wumpus> let's set a new deadline for the branch-off then?
12:23 < wumpus> we missed yesterday at least :)
12:23 < luke-jr> why not just branch off now?
12:24 < promag> +1
12:24 < wumpus> I want to do rc1 release at the same time
12:24 < promag> oh kk
12:24 < sipa> seems reasonable to aim to do them simultaneously
12:24 < jeremyrubin> #proposedmeetingtopic limited use of boost in consensus for backports
12:25  * luke-jr shrugs
12:25 < wumpus> I don't see a reason to do a branch-off without immediately doing rc1, that would just result in more backporting work
12:26 < wumpus> oh no, no boost topic please
12:26 < jeremyrubin> lol :| 
12:26 < sipa> at least not when we have known issues to solve still
12:26 < luke-jr> jeremyrubin: we'd need to adapt the build system.. isn't it avoidable?
12:26 < jeremyrubin> luke-jr: no it isn't
12:27 < wumpus> sipa: right
12:27 < luke-jr> what kind of bugfix requires boost? :/
12:27 < jeremyrubin> anyways we can discuss after the meeting if needed or when it's the topics turn 
12:27 < jeremyrubin> but I don't think anyone wants to discuss it now
12:27 < jeremyrubin> Except maybe you and I
12:28 < wumpus> well it's not like we have other topics
12:28 < luke-jr> ^
12:28 < jeremyrubin> Ah I took your request literally
12:28 < wumpus> #topic limited use of boost in consensus for backports
12:29 < jeremyrubin> Well; I think on the 0.21 horizon is upgrading to c++17, one feature of which means things like std::option being available
12:29 < jeremyrubin> We're currently reviewing code for things like #18401
12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/18401 | Refactor: Initialize PrecomputedTransactionData in CheckInputScripts by jnewbery · Pull Request #18401 · bitcoin/bitcoin · GitHub
12:29 < jeremyrubin> Which IMO should be properly written/refactored using option types
12:30 < jeremyrubin> See https://github.com/bitcoin/bitcoin/pull/17977#discussion_r370948973
12:30 < sipa> if it came at no cost, sure
12:30 < sipa> but the level of review necessary for those things already far outweighs the (imho) minimal complication of just splitting variables up into a bool + other var
12:30 < jeremyrubin> issue exists outside of taproot
12:31 < sipa> sure
12:31 < sipa> i wasn't speaking about that specifically
12:31 < jeremyrubin> at large, not just in this context -- if we need to gate development of features which touch consensus to not use c++17 features in consensus
12:31 < jeremyrubin> because it will interfere with backports
12:31 < luke-jr> IMO we should just not allow C++17 for consensus code where it would make this problem
12:32 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer]
12:32 < jeremyrubin> So there's three "solutions"
12:32 < sipa> right, until those are outside of backport window
12:32 < jeremyrubin> 1) No c++17 stuff for a while because of backports
12:32 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
12:32 < jeremyrubin> 2) Allow linking in boost c++17 API fill-ins  that we already have until out of support window
12:32 < wumpus> I think we should either switch to C++17 for the entire codebase, or not at all
12:33 < luke-jr> jeremyrubin: we don't have in libconsensus
12:33 < sipa> i think that once master is c++17, we can switch backports to c++17 as well, actually
12:33 < wumpus> moderating which parts of the codebase C++17 features are allowed and where not makes things very complicated for reviewers and maintainers
12:33 < luke-jr> sipa: defeats one big point of backports?
12:33 < jeremyrubin> 3) upgrade backports to c++17 :)
12:34 < wumpus> so I'd prefer to not use C++17 at all then
12:34 < hebasto> Not switching from c++11 for the entire codebase could be a problem for Qt stuff on macOS
12:34 < luke-jr> IIRC backports only delays us an extra year, right?
12:34 < wumpus> it's not like we really need it
12:34 < sipa> wumpus: well that's a deadlock, because there will always be some backport to support
12:34 < wumpus> it'[s always 'it would be nice to use this new c++ standard'
12:34 < wumpus> which it would be, sure
12:34 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Client Quit]
12:34 < sipa> so independent of the urgency of c++17 or when it is introduced, it's a good question to address
12:35 < sipa> luke-jr: backports exist because introduced features introduce compatibility issues for people who want a safer upgrade path
12:35 < jeremyrubin> It's also the right time to start thinking about it IMO -- if 0.21 will be c++17 release
12:36 < jeremyrubin> Which I've seen wumpus say is feasible 
12:36 < wumpus> yes, I just think using C++17 for only parts of the codebase is impractical
12:36 < luke-jr> sipa: one of those issues is C++ version compat
12:36 < sipa> but if there are a significant amount of people who wouldn't be able to upgrade to a new major version because of c++ language compatibility issues, we simply shouldn't update to c++17 (yet)
12:36 < luke-jr> how hard would it be to compile some of the codebase with C++17 enabled, and not others?
12:36 < sipa> wumpus: that's fair
12:36 < cfields> luke-jr: I really don't like that idea.
12:37 < wumpus> luke-jr: I'm sure it's *possible* but I fear all kinds of API conflicts
12:37 < jeremyrubin> luke-jr: would probably make binaries bigger 
12:37 < luke-jr> hmm
12:37 < cfields> luke-jr: I think the threat of something like an uncaught exception is very real in that scenario.
12:37 < jeremyrubin> wumpus: yeah
12:37 < luke-jr> cfields: right, I see
12:37 < wumpus> cfields: yes, it's probably an unacceptable risk in our case
12:37 < jeremyrubin> How was this handled historically?
12:37 < wumpus> of course, if it's only for checking
12:38 < sipa> so maybe we can settle on: we don't update to c++17 until we're in a position where no new backport releases are expected
12:38 < wumpus> you could compile the consensus files with c++11 *as well*
12:38 < jeremyrubin> Or was the switch to 11 widely supported enough at the time
12:38 < wumpus> and throw away the result
12:38 < sipa> if then an emergency happens that causes us to revert on that - so be it
12:38 < jeremyrubin> Or we can turn on c++17 for 0.20, but compile both for checking as wumpus suggests
12:38 < jeremyrubin> That way we're "priming" our backport window
12:39 < wumpus> I'd still prefer not to do this (also because what is 'consensus code' is not very well isolated in our code base)
12:39 < jeremyrubin> I don't think c++17 has any *breaking* changes?
12:39 < jeremyrubin> wumpus: I'm saying the whole codebase not just consensus
12:40 < cfields> jeremyrubin: iirc ^^ is what we did for c++11.
12:40 < wumpus> compile the entire codebase with c++17 and c++11? that's a lot of cverhead
12:40 < jeremyrubin> We can upgrade to c++17 today but not accept code changes that break c++11 compat.
12:40 < sipa> wumpus: we did that for a while with c++11 i think, i actually?
12:40 < sipa> though i'm not sure this is the right time; our focus now is 0.20
12:40 < jeremyrubin> Releases etc can be c++17, but anyone can build for c++11. We probably need to do this for 1-2 releases
12:40 < jeremyrubin> sipa: it is the right time to start worrying about this
12:40 < sipa> and i think the discussion of when c++17 is a different one
12:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
12:41 < wumpus> sipa: oh you mean more like a travis run that compiles with c++17 instead of c++11?
12:41 < cfields> sipa: yea, that's what we did.
12:41 < sipa> wumpus: right
12:41 < jeremyrubin> Because if we do it for 0.20 it means 0.21 and 0.22 can use c++17
12:41 < cfields> sipa: we had a release that was "technically" c++11, but iirc we didn't force the flag on.
12:41 -!- vincenzopalazzo [~vincent@153.33.4.21] has joined #bitcoin-core-dev
12:41 < cfields> Then we forced it on in master.
12:41 < sipa> cfields: right
12:41 < wumpus> makes sense to do that again then
12:41 < wumpus> for 0.21
12:41 < cfields> Don't remember for backports, I guess we were just kinda careful/reasonable about it?
12:42 < sipa> i guess if someone does the work for adding a c++17 travis build, and it passes with effectively no code changes... why not
12:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds]
12:42 < wumpus> I don't expect that to take a lot of changes
12:43 < sipa> i think so
12:44 < jeremyrubin> sounds like a plan to me?
12:44 < cfields> Also, we banned certain features when we started with c++11. thread_local is the obvious one that comes to mind, but IIRC there were others as well.
12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
12:44 -!- vasild_ is now known as vasild
12:44 < dongcarl> if there's consensus, can someone summarize the game plan?
12:45 < jeremyrubin> I can try...
12:46 < jeremyrubin> 1) Make 0.20 c++17 and c++11 buildable if easily doable
12:46 < wumpus> dongcarl: the idea is to add a travis run to compile the current code with c++17, do the minimum changes to be compatible with c++17 as well as c++11, for 0.21
12:46 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
12:46 < sipa> trying a C++17 build now
12:46 < sipa> with gcc 9.3
12:46 < jeremyrubin> I thought we'd do it for 0.20 if it's a small patchset and we haven't branched it yet?
12:46 < wumpus> and delay the real switch to c++17 (like actually using new features) to 0.22
12:46 < wumpus> no, we're not going to do anything like that for 0.20 
12:46 < jeremyrubin> Why not do it in 0.20 if it can be done?
12:47 < jeremyrubin> It has basically 0 functional changes?
12:47 < wumpus> 0.20.0rc1 should have been tagged yesterday
12:47 < wumpus> if anything is going in it's bugfixes
12:47 < cfields> fwiw, I'd like to do at least a small audit on the c++17/c++20 errata to see if there are any obvious implementation minefields to look out for.
12:47 < jeremyrubin> I mean it sort of doesn't really matter if it's in 0.20 or not as c++17 compat can be backported into a minor anyways...
12:48 < dongcarl> Okay, so what will gitian builds use? v0.20: c++11, v0.21: c++11, v0.22: c++17?
12:48 < cfields> (c++20 because presumably several c++17 issues were fixed there)
12:48 < dongcarl> cfields: Right, good call
12:49 < wumpus> dongcarl: gitian builds could use c++17 from 0.21 on
12:49 < wumpus> it just still has to be compatible with c++1
12:49 < sipa> wumpus: ah, so we can easily back out back to c++11 if issues are discovered?
12:49 < wumpus> so that things can be backported
12:49 < wumpus> sipa: that too
12:49 < sipa> right
12:50 < sipa> that seems reasonable
12:50 < cfields> Not sure about g++, but clang++ definitely has a switch for enforcing c++11 syntax/features for newer standards.
12:50 < cfields> So that'd be easy enough to lint/automate.
12:50 < sipa> oh the irony
12:50 < jeremyrubin> cfields: we only need one compiler to have that feature fortunately 
12:50 < sipa> the only compile error i get with c++17 is Span related
12:51 < cfields> jeremyrubin: right
12:51 < dongcarl> Got it: v0.20: COMPAT with c++11 + c++17 only if easily doable, GITIAN with c++11; v0.21: COMPAT with c++11 + c++17, GITIAN with c++17; v0.22: COMPAT with c++17, GITIAN with c++17. Is this the plan?
12:51 < wumpus> sgtm
12:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:52 < sipa> dongcarl: ack
12:52 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
12:52 < dongcarl> Great. Will post on the c++17 issue
12:52 < jeremyrubin> Loks right. And backports from 0.22 only go to 0.21? 
12:52 < jeremyrubin> Or to 0.20 too if we can get those builds up easily
12:52 < jeremyrubin> (depending on the feature using APIs that make backport non-trivial)
12:53 < wumpus> jeremyrubin: yes
12:53 < cfields> I think as long as we don't race to replace every line of code with a c++17ism we'll be fine, generally.
12:53 < wumpus> it's pretty rare in the first place to backport things two releases
12:54 < wumpus> cfields: also that
12:54 < jeremyrubin> cfields: noooo you can't just refactor the whole.... hahahah find and replace go refactorrrrrrrrrr
12:55 < sipa> refactorrr̅
12:55 < wumpus> hehe I think we had a rule for that for C++11 as well, don't C++11-ize things for the sake of doing so
12:55 < sipa> right
12:57 < wumpus> is someone going to post this into the c++17 issue?
12:57 < jeremyrubin> dongcarl: 
12:57 < sipa> FWIW, with #18468 + updating ax_cxx_compile_stdcxx.m4, everything compiles in c++17
12:57 < gribble> https://github.com/bitcoin/bitcoin/issues/18468 | Span improvements by sipa · Pull Request #18468 · bitcoin/bitcoin · GitHub
12:58 < dongcarl> Yeah making a little table now, perhaps jeremyrubin can add on about the backporting plan, not sure I understand it fully yet
12:58 < dongcarl> (add on in the issue)
12:59 < cncr04s> don't make me have to upgrade my distro to support new c++ versions
12:59 < sipa> cncr04s: what distro might that be?
12:59 < sipa> (we don't generally update c++ versions when it interferes with building on common platforms)
12:59 < cncr04s> ubuntu 14.04
13:00 < jeremyrubin> I'm not sure upgrading core is your largest concern there
13:00 < cfields> cncr04s: also, runtime is not affected. Releases are linked statically against lib(std)c++.
13:00 < cfields> So this is 99% a development decision.
13:00 < wumpus> #endmeeting
13:00 < lightningbot> Meeting ended Thu Apr  2 20:00:43 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
13:00 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-02-19.01.html
13:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-02-19.01.txt
13:00 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-02-19.01.log.html
13:00 < wumpus> cfields: +1
13:01 < jeremyrubin> 14.04 has been EOL for a while so you want to upgrade anyways...
13:01 < wumpus> the binaries will still work on 14.04
13:01 < cncr04s> I should have said new gcc versions but, I stick with the versions that come from repo
13:01 < wumpus> but if you want to do development you'll need a gcc that supports c++17
13:02 < cncr04s> 18.04 likley then
13:02 < sipa> not that according to the plan, you'd need to do so at the earliest once 0.22 branches off (+- a year from now)
13:02 < wumpus> this is not unreasonable in these days, mind that this is a discussion for 0.22 at first which is a year away
13:02 < wumpus> 16.04 should have (can't find the issue right now tho)
13:02 < cfields> Yea, it's much simpler these days. c++11 took _years_ to gain compiler support.
13:03 < luke-jr> [19:38:06] <luke-jr> how about only building libconsensus with C++11?
13:03 < luke-jr> [19:38:25] <luke-jr> eg a dedicated Travis job that only builds that
13:03 < luke-jr> [19:38:39] <luke-jr> might be good to do anyway to ensure we don't accidentally boost-ify it
13:03 < cfields> so it was more understandable as a holdup imo.
13:03 < luke-jr> [19:38:46] <luke-jr> (don't install boost either)
13:03 < luke-jr> sorry, my internet cut out
13:03 < cncr04s> still using 0x only just over a year ago
13:03 < cncr04s> personally
13:03 < dongcarl> jeremyrubin: Updated issue description here: #16684
13:03 < gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
13:03 < sipa> c++14 is a very minor change; c++17 is somewhat bigger, but not nearly as big as c++03->c++11
13:04 < dongcarl> jeremyrubin: Perhaps you can write a little about the backporting situation
13:04 < cncr04s> mostly due to compilers and distros taking forever to update to them
13:04 < cfields> sipa: good point.
13:04 < sipa> also, all functional/unit tests run with c++17 (after 18468 )
13:08 < dongcarl> cfields: I think libstdc++ errata is the important one, yes?
13:08 < cfields> dongcarl: hmm?
13:09 < cfields> dongcarl: Sorry, I meant errata from the standard itself. Somewhere there's a collection of "oops, stuff we clearly got wrong in the spec".
13:10 < dongcarl> Ah okay I understand now
13:11 < cfields> dongcarl: but looking at implementation notes makes sense too.
13:15 < sipa> also compiles with clang++ 6.0 under c++17
13:18 < elichai2> So the time to start slowly replacing boost with c++17 is after 0.21 is branched off? 
13:20 < jeremyrubin> elichai2: maybe; it kinda depends. If it takes 6+ months for your contribution to get reviewed and stuff to be merged you can do that... now! But you'd then possibly be merge gated until 0.21 is branched.
13:20 < elichai2> (I belive this isn't considered C++17-ize things just for the sake of doing so) 
13:20 < jeremyrubin> It also depends on if your stuff has obvious backport shims
13:20 < jeremyrubin> We're already using option types for instance
13:21 < elichai2> Right. option should be easy to replace. I'm more thinking std::fs and the harder parts 
13:22 < sipa> elichai2: after 0.22 is branched off
13:22 < sipa> eh, i guess that's ambiguous
13:22 < sipa> as soon as master branch is on the path to become 0.22, a year from now approximately
13:22 < jeremyrubin> sipa: there's a difference between the review window and the merge window
13:22 < sipa> oh no
13:22 < sipa> i'm confusing myself
13:23 < elichai2> Sipa, right so when 0.21 is branched off and master is 0.22 ;) 
13:23 < sipa> so half a year from now, at the very earliest
13:23 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 265 seconds]
13:24 < sipa> this is funny in the list of deprecated c++17 features:
13:24 < sipa> P0618R0 Deprecate <codecvt> The entire header <codecvt> (which does not contain the class codecvt!) is deprecated, as are the utilities wstring_convert and wbuffer_convert. These features are hard to use correctly, and there are doubts whether they are even specified correctly. Users should use dedicated text-processing libraries instead.
13:26 < sipa> "this turns out to be hard; let someone else do it"
13:32 < elichai2> Loool
13:33 < elichai2> I think the new standards are cool on one hand, but on the other it seems like stl is just getting messier and messier 
13:33 < jeremyrubin> messy stl > boost tho
13:35 < jeremyrubin> ugh github is kinda down
13:35 < sipa> elichai2: i think modern stl is pretty nice 
13:35 < sipa> it's of course growing is features
13:35 < sipa> but they do seem to put a lot of work in making sure things work together nicely
13:36 < elichai2> jeremyrubin: oh that's a give. Boost is the kind of messy 
13:36 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 256 seconds]
13:36 < elichai2> sipa: right, Altough I'm not sure how I feel about their ADL overuse 
13:36 < sipa> boost is really the STL sandbox :p
13:36 < sipa> ADL?
13:37 < elichai2> Argument dependent lookup 
13:38 < elichai2> That you can have `void my_func(A& a);` and then you can just call `a.my_func()`
13:39 < sipa> elichai2: reading up on it
13:40 < jeremyrubin> Oh so you can patch in stuff to a class?
13:40 < sipa> it doesn't seem to be what you're saying
13:40 < jeremyrubin> Is it a syntax change?
13:40 < elichai2> Yeah I might be confusing 2 terms 
13:40 < elichai2> Hard to see on my phone
13:40 < sipa> just that if you havea function A in namespace B, you can call `A(B::something)`, and it will attempt resolving it as "B::A(B::something)"
13:41 < sipa> without being in namespace B
13:46 < elichai2> what I remembered also doesn't seem to work hmm, maybe I'm confusing a c++2x proposal I've read, let me check
13:46 < promag> sorry, so when rc1?
13:47 < sipa> elichai2: it's hard to claim there is ADL overuse, when what you imagined ADL was isn't even possible :p
13:48 < elichai2> sipa: you're right hehe, I'm now doubting me memory lol
13:48 < elichai2> seeing way too many cppcon talks
13:49 < sipa> STL does use ADL for some things, for example the idion for calling swap on generic types is {using namespace std; swap(a, b); }
13:49 < sipa> which will use std::swap if possible, but also consider the namespaces a and b are to find a definition for a swap
13:50 < sipa> otherwise you'd need to inject swap into the std namespace for user-defined types
13:50 < sipa> arguably, it's saying that anything, in whatever namespace, with the name swap should have swap-like semantics, which is pretty polluting conceptually
13:52 < jonatack_> luke-jr: 18192 lgtm... github killed my review ack
13:53 < elichai2> sipa: Ok, at this point I honestly got no idea where that came into my mind. it seems non existent :O
13:53 < kanzure> hi/win 237
13:53 < elichai2> I should re-watch the C++17 talks 
13:53 < dongcarl> GitHub is down! *crab dance*
13:53 < kanzure> ah crap
13:54 < jonatack_> github yay 🏆
13:54 < elichai2> dongcarl: that explains why cargo is giving me troubles :/
13:56 -!- jonatack_ [~jon@37.166.71.71] has quit [Read error: Connection reset by peer]
13:56 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
13:57 < elichai2> Finally finished compiling stage2 clang-10 :D
13:58 < sipa> even gcc 9.3 doesn't have std::span :(
13:58 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
13:58 < elichai2> yeah std::span is c++2x
13:58 < sipa> gcc 9.3 has some parts of c++2a
13:58 < sipa> but not std::span, it seems
13:58 < elichai2> right 2a not 2x
13:59 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
13:59 < elichai2> yeah clang guys are really into experimental stuff where gcc seems less so
13:59 < sipa> it was c++1x(=11), c++1y(=14), c++1z(=17), c++a2(=20)
13:59 < dongcarl> std::span support starts with libstdc++ 10
13:59 < sipa> and in clang libc++ 7
14:00 -!- subdriven1 [~subdriven@192.145.126.115] has quit []
14:01 < elichai2> https://en.cppreference.com/w/cpp/header/experimental
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff53433fe4ed...0d71395848bb
14:07 < bitcoin-git> bitcoin/master fa6e01f MarcoFalke: doc: block-relay-only is not blocksonly
14:07 < bitcoin-git> bitcoin/master 0d71395 MarcoFalke: Merge #18464: doc: block-relay-only vs blocksonly
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18464: doc: block-relay-only vs blocksonly (master...2003-docBlockRelayOnly) https://github.com/bitcoin/bitcoin/pull/18464
14:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:13 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]
14:19 -!- vkmc1 [~vkmc@192.145.126.115] has joined #bitcoin-core-dev
14:27 -!- jarthur_ [~jarthur@2605:6000:1019:4971:c167:6add:93a5:3b9a] has joined #bitcoin-core-dev
14:27 -!- jarthur_ [~jarthur@2605:6000:1019:4971:c167:6add:93a5:3b9a] has quit [Remote host closed the connection]
14:28 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
14:31 -!- jarthur [~jarthur@2605:6000:1019:4971:91f6:7e3:18e9:b431] has quit [Ping timeout: 252 seconds]
14:32 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving]
14:40 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
14:45 -!- jarthur [~jarthur@2605:6000:1019:4971:c9a3:78d:3094:7f90] has joined #bitcoin-core-dev
14:50 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
15:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
15:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
15:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:40 -!- ahmed_ [uid14086@gateway/web/irccloud.com/x-xeemlvjxnmvjoimv] has quit [Quit: Connection closed for inactivity]
15:48 < jeremyrubin> [13:50] <sipa> arguably, it's saying that anything, in whatever namespace, with the name swap should have swap-like semantics, which is pretty polluting conceptually
15:49 < jeremyrubin> sipa: I think this will be improved with concepts right?
15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d71395848bb...dce6f3b29b41
15:51 < bitcoin-git> bitcoin/master f65c9ad Elichai Turkel: Check for overflow when calculating sum of outputs
15:51 < bitcoin-git> bitcoin/master dce6f3b MarcoFalke: Merge #18383: refactor: Check for overflow when calculating sum of tx outp...
15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18383: refactor: Check for overflow when calculating sum of tx outputs (master...2020-03-value-overflow) https://github.com/bitcoin/bitcoin/pull/18383
15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:52 < sipa> jeremyrubin: partially maybe
15:54 -!- sonofhan [~sonofhan@ip72-193-7-145.lv.lv.cox.net] has joined #bitcoin-core-dev
15:54 < sipa> it still means that various stl libraries will try to invoke your user-defined namespace's swap functions if you're not careful
15:54 < sipa> *stl functions
15:54 < jeremyrubin> True.
15:54 < jeremyrubin> Also looking at c++20 swappable it looks wrong for accomplishing this
15:55 < jeremyrubin> But in theory you could have a concept which uses std::swap to delegate to the member function swap
15:56 < sipa> it seems c++20 actually explicitly allows user-defined std::swap (in the std namespace)
15:56 < jeremyrubin> Probably a better way to fix it as most existing code bases will take a long time to get any sort of concepts deeply integrated
15:57 < jeremyrubin> TBH one of the c++17 features I'm most excited for is the map/unordered_map node extract API :p
15:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
16:05 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:08 -!- sonofhan [~sonofhan@ip72-193-7-145.lv.lv.cox.net] has quit [Quit: Leaving...]
16:08 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:13 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
16:15 < fanquake> jonatack: why did you remove parts of the release notes in the wiki? i.e dark mode support on macOS?
16:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 264 seconds]
16:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
16:22 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
16:23 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
16:25 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
16:27 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds]
16:46 -!- vincenzopalazzo [~vincent@153.33.4.21] has quit [Quit: Leaving]
16:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:49 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 252 seconds]
16:50 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
16:53 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
16:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds]
16:57 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
17:00 -!- vkmc1 [~vkmc@192.145.126.115] has quit []
17:03 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
17:05 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 265 seconds]
17:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
17:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:21 -!- iMast777 [~iMast777@84.39.116.180] has joined #bitcoin-core-dev
17:25 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
17:29 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Read error: Connection reset by peer]
17:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:32 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18509: fuzz: Avoid running over all inputs after merging them (master...2004-fuzzMergeOnce) https://github.com/bitcoin/bitcoin/pull/18509
17:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:39 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
17:43 < achow101> is it intentional that a new default wallet cannot be created when running with -nowallet?
17:44 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
17:54 < luke-jr> achow101: afaik -nowallet currently emulates a build w/o wallet support
17:55 < achow101> you can make and add new wallets even when -nowallet
17:55 < achow101> I think this is just a bug because who would want to make a wallet with no name
18:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:08 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18510: fuzz: Add CScriptNum::getint coverage (master...2004-fuzzScriptNumGetInt) https://github.com/bitcoin/bitcoin/pull/18510
18:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:08 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
18:19 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
18:19 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
18:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:31 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev
18:31 -!- stackingcore21 [~stackingc@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection]
18:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
18:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:34 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
18:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:35 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
18:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
18:38 -!- Highway61 [~Thunderbi@104.223.95.34] has quit [Ping timeout: 256 seconds]
18:46 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]
19:04 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
19:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:09 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 260 seconds]
19:09 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-rviojcfpsmsuuupn] has quit [Ping timeout: 240 seconds]
19:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
19:10 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
19:18 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-dlgnnxyhocgpzbpx] has joined #bitcoin-core-dev
19:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:20 < bitcoin-git> [bitcoin] sipa opened pull request #18512: Improve asmap checks and add sanity check (master...202003_asmap_checks) https://github.com/bitcoin/bitcoin/pull/18512
19:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:24 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
19:44 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
19:58 < luke-jr> MarcoFalke: I have a working test for the bug #18192 fixes; should I leave it for another PR since it already has 2 ACKs?
19:58 < gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
20:00 -!- iMast777 [~iMast777@84.39.116.180] has quit []
20:16 -!- pehjota1 [~pehjota@176.113.74.179] has joined #bitcoin-core-dev
20:36 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
20:37 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
20:37 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
20:40 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
20:42 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
20:44 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
20:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:54 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
21:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
21:04 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
21:12 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
21:12 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
21:17 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
21:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
21:27 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
21:43 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
21:49 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
22:22 -!- Kiminuo [~mix@141.98.103.92] has quit [Ping timeout: 260 seconds]
22:25 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
22:28 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds]
22:30 -!- Kiminuo [~mix@141.98.103.206] has joined #bitcoin-core-dev
22:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
22:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: No route to host]
22:59 -!- Highway61 [~Thunderbi@104.223.95.34] has joined #bitcoin-core-dev
23:00 -!- pehjota1 [~pehjota@176.113.74.179] has quit []
23:05 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
23:10 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 240 seconds]
23:12 -!- jarthur_ [~jarthur@2605:6000:1019:4971:80d0:9425:d633:5659] has joined #bitcoin-core-dev
23:12 -!- jarthur_ [~jarthur@2605:6000:1019:4971:80d0:9425:d633:5659] has quit [Remote host closed the connection]
23:15 -!- jarthur [~jarthur@2605:6000:1019:4971:c9a3:78d:3094:7f90] has quit [Ping timeout: 240 seconds]
23:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
23:19 -!- ToBeFree [~ToBeFree@84.39.116.180] has joined #bitcoin-core-dev
23:20 -!- ToBeFree is now known as Guest52194
23:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:25 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 264 seconds]
23:28 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
23:36 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 264 seconds]
23:37 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
23:44 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
23:44 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
23:45 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
23:49 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 250 seconds]
23:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
23:54 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 265 seconds]
--- Log closed Fri Apr 03 00:00:10 2020