--- Log opened Thu Apr 09 00:00:48 2020 00:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 00:27 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 265 seconds] 00:34 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 00:38 -!- jonatack [~jon@213.152.161.229] has joined #bitcoin-core-dev 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:42 < bitcoin-git> [bitcoin] fanquake closed pull request #18333: build: Drop deprecated ACLOCAL_AMFLAGS variable (master...20200311-deprecated-amflags) https://github.com/bitcoin/bitcoin/pull/18333 00:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 00:45 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 00:48 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 00:59 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:01 < jonasschnelli> Can someone restart https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32034256? 01:01 < jonasschnelli> Or tell me how to do it? I logged in but don't have a restart build button 01:01 < fanquake> done 01:02 < sipa> fanquake beat me to it 01:02 < fanquake> how unusual 01:02 < sipa> not really 01:02 < jonasschnelli> heh... bored in quarantaine? 01:03 < fanquake> jonasschnelli: I'm not sure how to get you a restart button. Are you authed via github, or a different method? 01:04 < jonasschnelli> I just logged in via github, yes. 01:04 < jonasschnelli> I haven't manually added a project,.. which I think i don't have to do? 01:04 < jonasschnelli> well,... i won't use it too much. So no urgency. 01:05 < fanquake> I don't think so, but can't quite remember. 01:05 < fanquake> I've currently lost my Travis restart button, which is much more annoying. 01:05 < fanquake> Re-authing didn't seem to help either. 01:13 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 01:13 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 01:20 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 01:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:39 < bitcoin-git> [bitcoin] sipa opened pull request #18573: [RFC] bitcoin-asmap utility (master...202004_asmap_tool) https://github.com/bitcoin/bitcoin/pull/18573 01:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:00 -!- tasmo [~tasmo@77.243.177.38] has quit [] 02:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:12 < bitcoin-git> [bitcoin] jonatack opened pull request #18574: getinfo: call getbalances.ismine.trusted instead of getwalletinfo.balance (master...getinfo-call-getbalances-instead-of-getwalletinfo-balances) https://github.com/bitcoin/bitcoin/pull/18574 02:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:20 -!- Dantman [~Dantman@185.104.184.43] has joined #bitcoin-core-dev 02:26 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:35 < bitcoin-git> [bitcoin] brakmic closed pull request #18570: rpc: return block hash in getbalances json (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/18570 02:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:52 < bitcoin-git> [bitcoin] brakmic reopened pull request #18570: rpc: return block hash in getbalances json (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/18570 02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:01 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:01 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 03:03 -!- Chanel50Weissnat [~Chanel50W@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:24 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 03:31 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 03:32 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:46 -!- lucaferr [~lucaferr@2a00:801:420:525d:a950:8687:28c8:580e] has joined #bitcoin-core-dev 03:46 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 264 seconds] 03:49 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:50 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds] 03:51 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 03:56 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 03:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:04 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:06 -!- Victor_sueca is now known as Victorsueca 04:17 -!- amsudeep [~sudeep@122.171.196.218] has quit [Ping timeout: 265 seconds] 04:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:34 -!- amsudeep [~sudeep@122.179.61.200] has joined #bitcoin-core-dev 04:47 -!- Chanel50Weissnat [~Chanel50W@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 264 seconds] 04:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 05:00 -!- Dantman [~Dantman@185.104.184.43] has quit [] 05:08 < wumpus> unless anyone disagrees strongly I'm going to merge #18553 and tag rc1 in a bit 05:08 < gribble> https://github.com/bitcoin/bitcoin/issues/18553 | Avoid non-trivial global constants in SHA-NI code by sipa · Pull Request #18553 · bitcoin/bitcoin · GitHub 05:08 < wumpus> (after branching off 0.20 etc ofc) 05:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/661bd5dea3d0...dcef5ad6ec10 05:09 < bitcoin-git> bitcoin/master fa68a3e MarcoFalke: appveyor: Enable minimal unit test logging to aid debugging 05:09 < bitcoin-git> bitcoin/master fa7af33 MarcoFalke: ci: Run unit tests sequential once 05:09 < bitcoin-git> bitcoin/master dcef5ad MarcoFalke: Merge #18562: ci: Run unit tests sequential once 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18562: ci: Run unit tests sequential once (master...2004-qaFixTestTeardown) https://github.com/bitcoin/bitcoin/pull/18562 05:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:16 -!- izy [~izy@2a0b:f4c2:1::1] has joined #bitcoin-core-dev 05:21 -!- peeja [~peeja@185.169.255.76] has joined #bitcoin-core-dev 05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dcef5ad6ec10...87374d80a71d 05:22 < bitcoin-git> bitcoin/master fa5e973 MarcoFalke: test: Set -use_value_profile=1 when merging fuzz inputs 05:22 < bitcoin-git> bitcoin/master 87374d8 MarcoFalke: Merge #18566: test: Set -use_value_profile=1 when merging fuzz inputs 05:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18566: test: Set -use_value_profile=1 when merging fuzz inputs (master...2004-fuzzValueProfile) https://github.com/bitcoin/bitcoin/pull/18566 05:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 05:28 -!- izy [~izy@2a0b:f4c2:1::1] has quit [Remote host closed the connection] 05:40 < fanquake> wumpus: sounds good 05:41 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 05:42 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 05:44 < wumpus> the other option would be to skip #18553 for now 05:44 < gribble> https://github.com/bitcoin/bitcoin/issues/18553 | Avoid non-trivial global constants in SHA-NI code by sipa · Pull Request #18553 · bitcoin/bitcoin · GitHub 05:45 < wumpus> as some people think it invokes strange undefined C++ behavior maybe that's better, though I'm not sure it's strictly worse than calling optional instruction sets in the initializers 05:46 < wumpus> but I don't want to block 0.20 for it for days 05:46 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 05:49 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Disconnected by services] 05:51 -!- Victor_sueca is now known as Victorsueca 06:07 -!- plaza [~plaza@net-2-36-128-226.cust.vodafonedsl.it] has joined #bitcoin-core-dev 06:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:08 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 06:10 -!- Highway61 [~Thunderbi@96.44.144.74] has joined #bitcoin-core-dev 06:17 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 06:17 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 06:17 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Remote host closed the connection] 06:17 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 06:17 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 06:17 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 06:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 06:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:17 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 06:17 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 06:17 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 06:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Write error: Broken pipe] 06:17 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 06:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 06:17 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 06:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 06:18 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 06:18 < wumpus> fanquake: we might want a linter at some point that checks for init.* sections in the object files for optional instruction sets 06:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 06:19 < fanquake> wumpus: interesting 06:19 < wumpus> i mean, .text.startup sections 06:20 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 06:20 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:20 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 06:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:22 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 06:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 06:22 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 06:24 < wumpus> a quick hack using "find -name \*.o -print0 | xargs -0 grep -l '.text.startup'" doesn't seem to find any others that might be problematic 06:26 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Remote host closed the connection] 06:27 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 06:27 < fanquake> wumpus: I see these sections in a fairly recent master https://gist.github.com/fanquake/90bfbed7d8e31e2191ec806cb67b78cf 06:28 -!- kljasdfvv [~flack@p200300D46F0C140010480FD6C7B7626C.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 06:29 < wumpus> sections such as .text.startup won't be in the final executable (the linker map collapses them) 06:29 < wumpus> but it's fine to have them in .o's compiled with the default compiler options 06:29 < fanquake> ah I see. I do have a map 06:29 < fanquake> I see: 06:30 < fanquake> .rela.text.startup 06:30 < fanquake> *(.text.startup .text.startup.*) 06:30 < fanquake> .text.startup 0x0000000000001090 0x74 /tmp/ccjlo7po.o 06:32 < fanquake> Was playing around with this for #17929. We are going to swap to just passing the optimization flags to the linker, and I was examining the differences in the binaries. 06:32 < gribble> https://github.com/bitcoin/bitcoin/issues/17929 | build: add --enable-linker-optimizations configure flag by fanquake · Pull Request #17929 · bitcoin/bitcoin · GitHub 06:32 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 06:32 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 06:33 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 06:34 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 06:35 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 06:39 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:40 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 06:51 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 06:53 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:57 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has quit [Ping timeout: 252 seconds] 07:01 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 07:14 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:20 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Ping timeout: 272 seconds] 07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/87374d80a71d...1ae366ecb067 07:21 < bitcoin-git> bitcoin/master 97ba77a Hennadii Stepanov: ci: Add native s390x 07:21 < bitcoin-git> bitcoin/master 6136a96 Hennadii Stepanov: ci: Rename RUN_CI_ON_HOST to DANGER_RUN_CI_ON_HOST 07:21 < bitcoin-git> bitcoin/master 1ae366e MarcoFalke: Merge #18569: ci: Add big endian native s390x build 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18569: ci: Add big endian native s390x build (master...20200326-allow-s390x) https://github.com/bitcoin/bitcoin/pull/18569 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ae366ecb067...081dcbde6623 07:22 < bitcoin-git> bitcoin/master faede1b MarcoFalke: test: Properly raise FailedToStartError when rpc shutdown before warmup fi... 07:23 < bitcoin-git> bitcoin/master 081dcbd MarcoFalke: Merge #18561: test: Properly raise FailedToStartError when rpc shutdown be... 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18561: test: Properly raise FailedToStartError when rpc shutdown before warmup finished (master...2004-qaFailedToStartConnectionReset) https://github.com/bitcoin/bitcoin/pull/18561 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:23 -!- shigeya [~shigeya@202.182.116.58] has joined #bitcoin-core-dev 07:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 07:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 07:34 -!- Kiminuo [~mix@141.98.103.228] has quit [Ping timeout: 256 seconds] 07:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:49 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:56 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Remote host closed the connection] 07:57 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 07:58 -!- amsudeep [~sudeep@122.179.61.200] has quit [Ping timeout: 256 seconds] 08:00 -!- peeja [~peeja@185.169.255.76] has quit [] 08:02 -!- Kiminuo [~mix@141.98.103.108] has joined #bitcoin-core-dev 08:07 -!- amsudeep [~sudeep@122.179.47.223] has joined #bitcoin-core-dev 08:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 08:17 -!- filchef [~filchef@212.104.97.177] has quit [Ping timeout: 256 seconds] 08:19 -!- amsudeep [~sudeep@122.179.47.223] has quit [Ping timeout: 256 seconds] 08:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 08:22 -!- tummy [~tummy@77.243.177.38] has joined #bitcoin-core-dev 08:27 -!- amsudeep [~sudeep@122.167.144.12] has joined #bitcoin-core-dev 08:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:44 -!- amsudeep [~sudeep@122.167.144.12] has quit [Ping timeout: 256 seconds] 08:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:05 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 09:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:06 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.] 09:06 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 09:10 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 09:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:14 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 09:19 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 09:19 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:551c:fe47:f31d:1b86] has joined #bitcoin-core-dev 09:21 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 09:22 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 09:27 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:551c:fe47:f31d:1b86] has quit [Quit: Sleep mode] 09:31 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:551c:fe47:f31d:1b86] has joined #bitcoin-core-dev 09:31 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:551c:fe47:f31d:1b86] has quit [Client Quit] 09:38 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 09:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 09:42 -!- Guyver2_ is now known as Guyver2 09:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18575: bench: Remove requirement that all benches use same testing setup (master...2004-benchNoGlobalReg) https://github.com/bitcoin/bitcoin/pull/18575 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 09:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 10:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 10:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:04 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 10:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 10:07 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 10:14 -!- xinan [dcf7c292@220.247.194.146] has joined #bitcoin-core-dev 10:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 10:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 10:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 10:16 -!- kabaum [~kabaum@84.216.157.2] has joined #bitcoin-core-dev 10:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:18 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 10:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:23 -!- xinan [dcf7c292@220.247.194.146] has quit [Remote host closed the connection] 10:26 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Ping timeout: 260 seconds] 10:28 -!- nijhh [dcf7c292@220.247.194.146] has joined #bitcoin-core-dev 10:30 -!- nijhh [dcf7c292@220.247.194.146] has quit [Remote host closed the connection] 10:30 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has joined #bitcoin-core-dev 10:31 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has quit [Client Quit] 10:31 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has joined #bitcoin-core-dev 10:39 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 10:41 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 10:41 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 265 seconds] 10:42 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 10:46 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:49 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 11:00 -!- tummy [~tummy@77.243.177.38] has quit [] 11:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 11:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 11:05 -!- kabaum [~kabaum@84.216.157.2] has quit [Ping timeout: 256 seconds] 11:15 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Quit: Leaving] 11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:20 < bitcoin-git> [bitcoin] gzhao408 opened pull request #18576: wip [test] use unittest for test_framework unit testing (master...framework-unittests) https://github.com/bitcoin/bitcoin/pull/18576 11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:21 -!- ram1 [~ram@184.75.223.195] has joined #bitcoin-core-dev 11:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 11:21 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 11:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 11:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 11:23 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 11:25 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has joined #bitcoin-core-dev 11:26 -!- kabaum [~kabaum@84.216.157.2] has joined #bitcoin-core-dev 11:28 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has quit [Remote host closed the connection] 11:30 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has joined #bitcoin-core-dev 11:34 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev 11:41 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 11:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:46 < bitcoin-git> [bitcoin] yahiheb opened pull request #18577: doc: Correct scripted-diff example link (master...correct-link) https://github.com/bitcoin/bitcoin/pull/18577 11:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [] 11:50 -!- sdaftuar_ is now known as sdaftuar 11:52 -!- amsudeep [~sudeep@171.61.74.163] has joined #bitcoin-core-dev 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu Apr 9 19:00:05 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < sipa> hi 12:00 < elichai2> hi 12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr 12:00 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55 12:00 < achow101> hi 12:00 < jonasschnelli> hi 12:00 < jonatack> hi 12:00 < hebasto> hi 12:00 < jkczyz> hi 12:01 < aj> hola 12:01 < MarcoFalke> hi 12:01 < sdaftuar> hi! 12:01 < MarcoFalke> (sorry, merge bot incoming in a few secs) 12:01 < cfields> hi 12:01 < amiti> hi 12:01 < wumpus> any proposed topics? 12:02 < jnewbery> hi 12:02 < MarcoFalke> wen release? 12:02 < wumpus> looks like there's one by achow101: deprecating signrawtx RPCs 12:02 < sipa> low priority topic if there's time: future of asmap? 12:02 < wumpus> MarcoFalke:depends on whether #18553 is a blocker 12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/081dcbde6623...405713d00fb4 12:02 < bitcoin-git> bitcoin/master 5560845 Pieter Wuille: Make a fuzzer-based copy of the prevector randomized test 12:02 < bitcoin-git> bitcoin/master eda8309 Pieter Wuille: Assert immediately rather than caching failure 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/18553 | Avoid non-trivial global constants in SHA-NI code by sipa · Pull Request #18553 · bitcoin/bitcoin · GitHub 12:02 < bitcoin-git> bitcoin/master 402ad5a Pieter Wuille: Only run sanity check once at the end 12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18529: Add fuzzer version of randomized prevector test (master...202004_prevector_fuzz) https://github.com/bitcoin/bitcoin/pull/18529 12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:03 < achow101> rc1 soon? 12:03 < MarcoFalke> I wish rebroad could ACK it, since they reported the issue 12:03 < hebasto> why 18553 could be a blocker? 12:03 < wumpus> it's the only PR left that is tagged for 0.20 12:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:03 < wumpus> hebasto: because if your system doesn't support the instruction it'll just crash before main() 12:04 < MarcoFalke> Does anyone have that CPU to test? 12:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 12:04 < elichai2> MarcoFalke: I'm surprised this is the first time we're hearing about this issue. I would've thought everyone without SSE* support will get this error 12:04 < sipa> i'm not sure the problem will appear in every build (it may be compiler dependent) 12:04 < wumpus> no, bitcoind master runs fine even on my oldest pc, but it might depend on compiler too 12:04 < sipa> would i understand how our existing code is broken for systems that do not have sse4 12:04 < sipa> *but i understand 12:05 < wumpus> movaps is SSE2, right? 12:05 < promag> hi 12:05 < wumpus> if the init code contained *SSE4* oh sure we'd have noticed 12:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 12:05 < cfields> *sse2 12:05 < cfields> wumpus: right 12:06 < sipa> i suspect he is executing an sse4 instruction 12:06 < wumpus> almost(?) all amd64 processors support SSE2 12:06 < sipa> because his system has sse2 12:06 < wumpus> oh 12:06 < wumpus> okay in that case we don't know if the PR fixes theproblem at all 12:06 < sipa> it does 12:06 < wumpus> I suggest we just move on with the branch-off and rc1 12:06 < cfields> ah, I guess if we're targetting sse4 it's free to ignore the sse2 intrinsic. Annoying that those are only hints. 12:07 < sipa> wumpus: the sha256-shani module is compiled with sse4 on, so any code the compiler produces in that module is allowed to have sse4 instructions 12:07 < sipa> the fact that it has a global initializer is a bug regardless 12:07 < wumpus> sipa: yes, I agree 12:07 < wumpus> I'm the person who ACKed that PR, I think it's a good change 12:07 < elichai2> anyways the current code is somewhat broken 12:07 < elichai2> even if that's not his specific problem 12:08 < sipa> we don't know the exact conditions to reproduce it (which is hard, as it's compiler dependent), but i believe my PR is a bugfix independently of that 12:08 < elichai2> sipa: exactly 12:08 < wumpus> yes 12:08 < wumpus> it makes sense no matter what 12:08 < wumpus> even reduces code size a bit 12:09 < sipa> but if we want to make sure rebroad's issue is fixed in 0.20... we have no choice but to wait for him 12:09 < sipa> i think we can do that in rc1 12:09 < jarthur> If anyone needs time on a machine w/ hardware SHA-NI for profiling/memory sanitization, send me your SSH pubkey and I'll give you a VM 12:09 < sipa> i have one too 12:09 < wumpus> I'm not going to hold up rc1 on them testing it 12:09 < sipa> a machine without sse4 would be more useful :p 12:10 < luke-jr> (proposed topic: change destdata) 12:10 < sipa> there are very few x86_64 systems without sse4 i think 12:10 < luke-jr> although maybe better for wallet meeting tomorrow 12:10 < wumpus> true, even my old dev machine has "sse4a" 12:10 < luke-jr> (but does relate to 0.20) 12:12 < elichai2> jarthur: I would like to run some UB sanitizer on the patch, just because I'm a bit uncomfortable with C++'s alignment rules 12:13 < wumpus> in that case, let's do rc1 without it 12:13 < sipa> ack 12:13 -!- kabaum [~kabaum@84.216.157.2] has quit [Ping timeout: 265 seconds] 12:13 < cfields> elichai2: if you're that uncomfortable, there's an intrinsic that doesn't require alignment. 12:13 < luke-jr> should probably get at least #18572 into 0.20 12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/18572 | Wallet: Accept "changedata" db key as an alias to "destdata" by luke-jr · Pull Request #18572 · bitcoin/bitcoin · GitHub 12:13 < cfields> compiler might even auto-upgrade it? 12:14 < sipa> cfields: i don't think it can 12:14 < wumpus> the current solution has 0 overhead at least 12:14 < elichai2> cfields: I'm not saying it's UB/ID just that I don't know the rules well enough :) I assume the unaligned load is costlier 12:14 < sipa> elichai2: on most systems they have the same cost, but not all 12:14 < wumpus> it even generates the same code as before 12:15 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has quit [Remote host closed the connection] 12:15 < elichai2> sipa: I thought SIMD instructions do require aligned pointers. unlike regular loads/stores 12:15 < elichai2> (x86/x86_64) 12:15 < cfields> yeah, I'm not really understanding the concern. We use alignment tricks in sse4 as well. 12:15 < sipa> elichai2: correct 12:15 < luke-jr> depends on the CPU in my expereince 12:15 < wumpus> yes, alignas(__m128i) should just work 12:15 < sipa> elichai2: movdqa requires alignment, movdqu does not 12:16 < elichai2> Ok, if other people are confident in this than I'm ACK too 12:16 < luke-jr> for a long time at least, Mesa and glibc used ssse3 for memcpy-type stuff, even when unaligned - and it broke on (IIRC) Sandy Bridge 12:16 < sipa> but still on most systems they have the same cost; the distinction was made because on early CPUs they differed 12:16 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has joined #bitcoin-core-dev 12:17 < wumpus> we use alignas() in a few other places too 12:17 < wumpus> if the compier ignores it, we're screwed with regard to UB in either case 12:17 < sipa> yeah, i'm not worried about the alignment thing 12:17 < wumpus> (prevector comes to mind) 12:19 < elichai2> wasn't there a UB in a version of prevector? 12:19 < wumpus> yes, that was solved using the current explicit construction 12:19 < sipa> elichai2: the kind of technically-UB-by-the-C++-spec-but-not-on-any-real-platform one only, afaik 12:20 < wumpus> it wasn't alignas()'s fault 12:20 < elichai2> isn't that the worse kind? :P 12:20 < sipa> elichai2: i think bugs that affect production code are just *slightly* more serious 12:20 < elichai2> right it's a pragma thing 12:21 < elichai2> anyhow, we're talking about this too much :) I'm ACK if people feel confident, my lack of understanding shouldn't stop anything 12:21 < jeremyrubin> just noting that there is a pragma free version of prevector that could be written and has no UB; but it's a bigger refactor 12:21 < cfields> elichai2: nothing wrong with being paranoid. 12:21 < sipa> of course 12:21 < wumpus> #topic deprecating signrawtx RPCs (achow101) 12:22 < wumpus> jeremyrubin: we're not discussing refactoring prevector again :) 12:23 < achow101> so multisig signrawtransaction workflows don't work with descriptor wallets 12:23 < achow101> I was thinking that because we have psbt now, we should deprecate the signrawtx RPCs 12:23 < MarcoFalke> completely or only for multisig? 12:23 < jonasschnelli> can you quickly elaborate why it won't work with desc. wallets? 12:23 < wumpus> I'm not generally in favor of depracating signrawtx RPCs, many people use the raw transactions workflow 12:23 < achow101> it should be a longer deprecation cycle because it's so widely used 12:23 < wumpus> if we do it should be *very* well documented first 12:24 < sipa> i'm not so convinced here 12:24 < jonasschnelli> agree with wumpus 12:24 < sipa> i believe it's good to "nudge" people towards PSBT, but deprecation is probably too hard a hammer for that 12:24 < luke-jr> [19:23:38] can you quickly elaborate why it won't work with desc. wallets? 12:24 < wumpus> like make a blog post how to *old thing* in *new way* 12:24 < achow101> jonasschnelli: because of the separation of watchonly things, currently we can't create a wallet that has both the multisig script and keys to sign for it 12:24 < wumpus> yes, I agree 12:24 < achow101> so doing a multisig becomes a half assed psbt workflow 12:25 < sipa> achow101: i don't understand why we'd want descriptor wallets to not support private keys for multisig 12:25 < achow101> sipa: the issue is with exporting the private keys to the multisig 12:25 < achow101> IIRC there was contention about exporting keys that used unhardened derivation 12:26 < jonasschnelli> are those technical or conceptual limitations? 12:26 < sipa> achow101: so use hardened derivation? 12:26 < achow101> jonasschnelli: conceptual and current implementation limitations 12:26 < sipa> i understand there may be UI issues on how to make this easy 12:27 < sipa> but say you have a private key, even generated manually or whatever... you should be able to import a descriptor for a multisig based on it, and have that private key in the same wallet 12:27 -!- go11111111111 [~go1111111@104.156.98.86] has quit [Quit: Leaving] 12:28 < achow101> sipa: sure 12:28 -!- go11111111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 12:28 < sipa> and that would work fine with signraw*, right? 12:28 < achow101> (this is also partly in the context of making all of the RPC tests work) 12:28 < achow101> sipa: yes 12:29 -!- jonatack [~jon@213.152.161.229] has quit [Ping timeout: 256 seconds] 12:29 < sipa> ok 12:30 < achow101> but conceptually, it feels like psbt should be a directly replacement to raw txs, so we should move to remove those eventually 12:30 < jonasschnelli> I could understand why the signraw commands could refuse to work for BIP44-ish descriptor wallets (due to the hardening violation),... though for manual privkey-ckd it should work 12:30 -!- amsudeep [~sudeep@171.61.74.163] has quit [Ping timeout: 258 seconds] 12:30 < sipa> jonasschnelli: once you have all the right things in a descriptor wallet, it doesn't matter - hardened or not 12:31 < sipa> (is my understanding) 12:31 < sipa> achow101: i think my preference would be to mark signraw* as in "maintenance mode" or so, where they don't receive new features (e.g. they wouldn't support taproot signing when that gets in) 12:32 -!- jonatack [~jon@37.164.104.82] has joined #bitcoin-core-dev 12:32 < instagibbs> +1 12:32 < sipa> but i feel like deprecation is kind of ruthless 12:32 < achow101> I was thinking of an extra long deprecation cycle 12:32 < wumpus> yes 12:32 < instagibbs> imo I think the tooling is too widely used and PSBT still has an adoption curve to hit 12:32 < wumpus> agree 12:33 < achow101> like 2 releases with a note saying it's deprecated, but don't disable yet. then 2 releases with it hidden behind -deprecatedprc. then remove 12:33 < instagibbs> the tooling meaning *raw* 12:33 < wumpus> maybe in a few years bring this up again :) 12:34 * achow101 adds to 2022 calendar 12:34 < jonasschnelli> I can't completely follow why we should remove/deprecate it since in many use cases those commands work fine. 12:34 < jonasschnelli> (the accounting system had conceptual flaw in contrast) 12:35 < jonasschnelli> *flaws 12:35 < luke-jr> jonasschnelli: what flaws? 12:35 < wumpus> yes 12:35 < sipa> jonasschnelli: i think the reasoning is "it's hard to make it work nicely with descriptors, and there is a better system already... would be easy to just get rid of it" 12:35 < luke-jr> the accounting system worked fine AFAIK, just nobody cared to maintain it 12:35 < wumpus> accounting system discussion is off topic 12:35 < luke-jr> true 12:36 < luke-jr> couldn't signrawtx be reimplemented as a wrapper around PSBT? 12:36 < jonasschnelli> is the plan to only support descriptor wallets in the future? 12:36 < jonasschnelli> with some sort of migration 12:36 < sipa> luke-jr: yes (and probably should), but that wouldn't solve the problem 12:36 -!- go11111111111 is now known as go1111111 12:36 < achow101> my plan is to make descriptor wallets the default wallet type 12:36 < achow101> eventually 12:36 < jonasschnelli> this would be fine. As long as "legacy" wallets are still supported, signwith* commands shound't go away? 12:37 < sipa> the issue (as i understand it) is constructing a descriptor wallet that has all the same pieces of information as a current legacy wallet is unclear (where do the keys come from, how to import without reintroducing mixed wallets or watching the wrong kind of things...) 12:37 < achow101> sipa: yes 12:38 < sipa> i believe it would be nice to spend some time on actually solving that... because there is no technical reason why a descriptor wallet couldn't have that information 12:38 < jonasschnelli> exactly 12:38 < sipa> achow101: FWIW, i think your envisioned workflow (having two wallets, one with the multisig, and one with the private keys) is also pretty suboptimal 12:38 < jonasschnelli> we shouldn't enforce modes of use due to solvable technical imitations 12:38 < MarcoFalke> If the call doesn't work with descriptor wallets, it should be disabled for those wallets, not for legacy wallets as well. 12:38 < MarcoFalke> agree with jonasschnelli 12:38 < sipa> it isn't a technical limitation 12:39 < sipa> it's an unsolved UI question 12:39 < sipa> (where UI includes RPC and workflows) 12:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:42 < achow101> i suppose it is 12:42 < sipa> i don't think disabling signraw* for descriptor wallets would even solve the root of the issue - users would still need a workaround to do what they could before (having two wallets, and run PSBT RPCs on both) 12:43 < jonasschnelli> achow101: maybe you could write a short gist/paper about the issue for help us to understand it better? 12:43 < sipa> can i try in 3 lines? 12:43 < jonasschnelli> plz 12:43 < achow101> jonasschnelli: sure. I should write release notes for descriptor wallets anyways and there should be section on known limitations 12:43 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Read error: Connection reset by peer] 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 12:44 < wumpus> +1 12:45 < sipa> currently you can construct a legacy wallet which has (1) a private key for one key and (2) watchonly records for multisigs involving that public key - this is crazy (because it means payments to the individual single key will be treated as incoming money, unable to separate it from the multisig funds), but it works great: you have the script information (the the multisig watchonly) and the private 12:45 < sipa> key for one of the keys in one wallet,... 12:45 < sipa> so it can do everything 12:46 < sipa> in descriptor wallets, you'd need to explicitly import a descriptor for the multisig, and then add a private key for one - you can't have started with a wallet that had that private key already as a single-key wallet (because then you reintroduce the mixing of singlekey/multisig funds), and you can't export that private key from another wallet (because we don't want export of non-hardened keys).... 12:47 < sipa> so where does it come from? 12:47 < sipa> i think the only question is a UX one around construction of such wallets 12:47 < sipa> 12:48 < jonasschnelli> I see. So one would need a watch-only-ms desc wallet and a single-key desc wallet for signing the PSBT (or whatever) 12:48 < achow101> yes 12:48 < achow101> and with both psbt and raw tx, the workflow is the same 12:48 < sipa> right, that would work - and the PSBT would carry the script information from the watch-only-ms wallet to the signing-key wallet 12:49 < instagibbs> user stories may help cover cases, I tend to only think about MY use case 12:49 < jonasschnelli> Which the signraw commands could construct in the background (assume providing all the infos)? 12:49 < luke-jr> aren't the multisig funds classified as watchonly? 12:49 < sipa> luke-jr: right, fair - that's the reason watchonly exists 12:49 < achow101> you go to the watch-only-ms wallet with a psbt or rawtx, it adds the scripts. then you go to the single-key wallet and sign it. it's the same workflow, but psbt is better suited for carrying this data 12:50 < sipa> but it's ridiculous that you currently can't do multisig stuff without also having payments to individual keys as balance in your wallet 12:50 < jonasschnelli> sipa: though that is rarely used, right? 12:50 < sipa> jonasschnelli: "used" ? 12:50 < sipa> it's an attack 12:51 < sipa> you can send funds to a individual key in a multisig, and the user may think it's paid to the multisig 12:51 < luke-jr> so we need a way to have can-sign non-ismine descriptors 12:51 < jonasschnelli> Kida. Yes. I see. Agree that it is a flaw/ridiculous 12:51 < sipa> luke-jr: descriptor wallets already do that 12:51 < achow101> luke-jr: we already do that. it's a question of the scripts 12:51 < sipa> we just need a good way to import a multisig descriptor + individual key into a descriptor wallet 12:51 < instagibbs> IsMine implementation in descriptor is a relative beauty :P 12:52 < sipa> if that works, signraw* and PSBT* will function just as before 12:52 < sipa> if that doesn't work, it's going to be shitty to use for both 12:52 < jonasschnelli> Now I see why it's a UX issue. We have set our own limitations which IMO could be worked around by creating the right structures on the fly for the signraw* commands when using desc.-wallets 12:52 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 12:53 < instagibbs> achow101, if you do this you're also going to have to get rid of the "private keys disabled" hack we've been using 12:53 < instagibbs> to detect if we want to do PSBT stuff or try to sign the transaction 12:54 < achow101> instagibbs: I don't think so. but I'll experiment 12:54 < achow101> jonasschnelli: which "right structures" 12:54 < instagibbs> achow101, well, if there exists a private key, it will try to sign and fail unexpectedly, I think, but you can test yes :) 12:56 < jeremyrubin> BTW: if you have thoughts on BIP-119 Next Steps please submit them in this survey; want to collect feedback from everyone https://forms.gle/rT3v4JjHbdn3RMnL6 12:57 < instagibbs> The wallet should just probably know explicitly that it should try to auto-sign or return a PSBT, but that's yet another UX q. 12:57 < wumpus> 3 minutes to go 12:57 < jonasschnelli> achow101: maybe I get it wrong. But if someone invokes a signraw, depending on the input, you could create either a watch-only-ms wallet or a single-privkey wallet in the background and use the PSBT workflow 12:58 < achow101> but where does the multisig script come from? 12:59 < sipa> jonasschnelli: the question is not about signraw* or PSBT*; the question is constructing a wallet that has the right information 12:59 < achow101> it's not hard to wrap signrawtx around psbts so it uses psbt internally. but it just doesn't have all of the data there 12:59 < luke-jr> descriptor wallets can or can't have multiple descriptors? 12:59 < jonasschnelli> provide it manually or provide it via a second wallet 12:59 < sipa> luke-jr: can; change and payments in general will come from distinct descriptors 13:00 < instagibbs> luke-jr, you can import any number of descriptors, there are 6 "Active" ones, aka keypool, by default 13:00 < achow101> luke-jr: can, but having a descriptor wallet contain both multisig and single key descriptors goes back to the mixed watchonly wallet thing 13:00 < instagibbs> legacy/p2sh-segwit/bech32 x internal/external 13:00 < luke-jr> achow101: not if you flag the single-keys descriptor as non-ismine? 13:00 < wumpus> sorry, time to wrap up the meeting 13:00 < achow101> jonasschnelli: yes, and that's the shitty ux sipa was talking about 13:01 < wumpus> #endmeeting 13:01 < lightningbot> Meeting ended Thu Apr 9 20:01:06 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:01 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-09-19.00.html 13:01 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-09-19.00.txt 13:01 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-09-19.00.log.html 13:01 < instagibbs> luke-jr, what you need is a way to import a key and say "yeah it's not an address", right 13:01 < instagibbs> that's what people were discussing 13:01 < sipa> instagibbs: and also how do you then come up with that key 13:02 < luke-jr> [19:51:16] so we need a way to have can-sign non-ismine descriptors [19:51:31] luke-jr: descriptor wallets already do that 13:02 < luke-jr> :/ 13:02 < sipa> luke-jr: the internals can do this fine 13:02 < sipa> the question is UX 13:02 < achow101> luke-jr: given a psbt with the redeemScript, a descriptor wallet without the multisig can sign the psbt 13:02 < instagibbs> if you have a privkey, and it can sign something, it does. So single-key desc wallet can sign a multisig 13:02 < instagibbs> but that's a 2 wallet solution 13:03 < sipa> but it there shouldn't need to be any single-key desc wallet whatsoever 13:03 < instagibbs> right 13:03 < sipa> there should just be one multisig wallet with one of the keys 13:03 < instagibbs> "just a key" 13:03 < luke-jr> achow101: descriptor wallet w/ multisig descriptors ismine + singlekey descriptors non-ismine? 13:03 < jonasschnelli> I think that -> there should just be one multisig wallet with one of the keys 13:03 < achow101> luke-jr: can't do that 13:03 < luke-jr> why not? 13:03 < sipa> luke-jr: my point is that's even a stretch; there shouldn't be a singlekey descriptor at all 13:04 < sipa> a descriptor is a way to encode information about scriptPubKeys 13:04 < sipa> there is no interesting scriptPubKey here 13:04 < jnewbery> sipa: we didn't get to it in the meeting, but is the future of asmap to fork https://github.com/sipa/asmap to https://github.com/bitcoin-core/asmap ? 13:04 < sipa> there should just be a key in the wallet, without a descriptor for the single-key version of that key 13:05 < luke-jr> sipa: so just multisig descriptor + private seed 13:05 < sipa> luke-jr: right, something like that 13:05 < instagibbs> "just" 13:05 < instagibbs> ;P 13:05 < sipa> jnewbery: #18573 would make my asmap repo obsolete 13:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18573 | [RFC] bitcoin-asmap utility by sipa · Pull Request #18573 · bitcoin/bitcoin · GitHub 13:06 < sipa> we still need infrastructure for determining the mappings we want, which gleb has been working on 13:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 13:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:45 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 13:53 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Quit: Leaving] 14:00 -!- ram1 [~ram@184.75.223.195] has quit [] 14:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 14:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:21 -!- AntiSpamMeta [~AntiSpamM@185.103.96.135] has joined #bitcoin-core-dev 14:21 -!- AntiSpamMeta is now known as Guest9036 14:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 14:38 -!- jarthur [~jarthur@2605:6000:1019:4971:5893:28c6:217f:69ad] has quit [] 14:43 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 264 seconds] 15:09 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 15:11 -!- per [~per@gateway/tor-sasl/wsm] has quit [Ping timeout: 240 seconds] 15:15 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #bitcoin-core-dev 15:21 < achow101> jonasschnelli: https://gist.github.com/achow101/94d889715afd49181f8efdca1f9faa25 here's a writeup of some of the issues 15:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 15:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 15:27 < sipa> achow101: i think exporting descriptors (without private keys) should always be fine 15:28 < achow101> sipa: yes, but it's only really useful if unhardened derivation is being used 15:28 < sipa> agree 15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:29 < bitcoin-git> [bitcoin] promag opened pull request #18578: gui: Fix itemWalletAddress leak when not tree mode (master...2020-fix-coincontroldialog-leak) https://github.com/bitcoin/bitcoin/pull/18578 15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:29 < achow101> so one question is how to support the two use cases in the same wallet 15:31 < sipa> i *think* that exporting descriptors including private keys is also fine, as it doesn't risk exporting something that leaks the entire wallet while the user thinks it's just a single key (as in: it'll always leak the entire thing) 15:31 < sipa> but it shouldn't be possible to export derived private keys (except maybe if they're hardened... unsure) 15:32 < achow101> yes 15:33 < achow101> but exporting derived keys is necessary for the usual multisig workflow 15:33 < achow101> otherwise all you can do are ranged multisigs when maybe you just want a one time thing 15:34 < sipa> i feel that in that case you should also have started from just a single key, rather than an xpub 15:34 < sipa> i see the complication, but i'm not sure how important it is 15:34 < achow101> but how would you have started from just a single key? 15:35 < sipa> that's a great question :p 15:41 < sipa> it would be great if a ranged multisig setup already just worked 15:43 < sipa> say there was an RPC generatexpub which would generate an xprv, and import the private key, but not watch anything, and then return the xpub 15:44 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:45 < achow101> maybe if used a wallet global SigningProvider? so keys aren't associated with the scripts directly 15:45 < sipa> yeah, i think that makes sense 15:46 < achow101> ugh, rewriting it all again :( 15:47 < achow101> i'm not sure that's necessarily useful though 15:48 < sipa> you'd still need to be able to generate derived private keys 15:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 15:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 15:51 < sipa> alternatively, i think it'd be fine if there was just a way to import descriptors with some public and some private keys... without worrying how someone would obtain those for now 15:52 < achow101> sipa: yes, but worrying about how someone would obtain those is important 15:52 < sipa> oh absolutely 15:52 < sipa> but as a first step... that'd be great already 15:59 < sipa> fanquake: what is link-time garbage collection? 16:00 < fanquake> sipa: basically just the use of --gc-sections. 16:01 < fanquake> Curious, was there anything in particular that prompted you to test building like that? 16:06 < sipa> fanquake: seeing the size of bitcoin-asmap in #18573 16:06 < gribble> https://github.com/bitcoin/bitcoin/issues/18573 | [RFC] bitcoin-asmap utility by sipa · Pull Request #18573 · bitcoin/bitcoin · GitHub 16:06 < sipa> it's around 600 kB, nothing too terrible... but with gc sections etc, it's 100 kB 16:07 < sipa> i had always assumed we already enabled those options 16:07 < sipa> so i went to check if it would benefit our existing binaries as well 16:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 16:26 -!- plaza [~plaza@net-2-36-128-226.cust.vodafonedsl.it] has quit [Quit: Leaving] 16:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/405713d00fb4...d486991aa59d 16:42 < bitcoin-git> bitcoin/master 5ca90f8 fanquake: scripts: add MACHO lazy bindings check to security-check.py 16:42 < bitcoin-git> bitcoin/master d486991 fanquake: Merge #18295: scripts: add MACHO lazy bindings check to security-check.py 16:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:43 < bitcoin-git> [bitcoin] fanquake merged pull request #18295: scripts: add MACHO lazy bindings check to security-check.py (master...does_noone_care_about_MH_BINDATLOAD_anymore) https://github.com/bitcoin/bitcoin/pull/18295 16:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 16:59 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 17:00 -!- Guest9036 [~AntiSpamM@185.103.96.135] has quit [] 17:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 17:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:22 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d486991aa59d...2b9a4a13324a 17:22 < bitcoin-git> bitcoin/master 478c11d Yahia Chiheb: Correct scripted-diff example link 17:22 < bitcoin-git> bitcoin/master 2b9a4a1 fanquake: Merge #18577: doc: Correct scripted-diff example link 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:22 < bitcoin-git> [bitcoin] fanquake merged pull request #18577: doc: Correct scripted-diff example link (master...correct-link) https://github.com/bitcoin/bitcoin/pull/18577 17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 17:44 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 17:55 -!- doomas [~doomas@77.243.177.38] has joined #bitcoin-core-dev 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:56 < bitcoin-git> [bitcoin] hebasto opened pull request #18581: ci: Print ccache stats, add pip cache, and cleanups (master...20200409-ci-plus) https://github.com/bitcoin/bitcoin/pull/18581 17:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:58 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 17:59 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds] 18:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 19:00 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 19:27 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 19:28 -!- amsudeep [~sudeep@122.182.232.200] has joined #bitcoin-core-dev 19:36 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 19:40 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 19:54 -!- captjakk [~captjakk@208.85.181.91] has joined #bitcoin-core-dev 20:00 -!- doomas [~doomas@77.243.177.38] has quit [] 20:02 -!- amsudeep [~sudeep@122.182.232.200] has quit [Ping timeout: 256 seconds] 20:21 -!- edunham1 [~edunham@176.113.74.179] has joined #bitcoin-core-dev 20:23 -!- amsudeep [~sudeep@122.179.64.196] has joined #bitcoin-core-dev 20:59 -!- captjakk [~captjakk@208.85.181.91] has quit [Remote host closed the connection] 20:59 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:59 -!- captjakk [~captjakk@208.85.181.91] has joined #bitcoin-core-dev 21:02 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 21:03 -!- captjakk [~captjakk@208.85.181.91] has quit [Ping timeout: 250 seconds] 21:10 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 21:17 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 21:26 -!- amsudeep [~sudeep@122.179.64.196] has quit [Ping timeout: 250 seconds] 21:36 -!- amsudeep [~sudeep@122.179.62.139] has joined #bitcoin-core-dev 21:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 21:46 -!- amsudeep [~sudeep@122.179.62.139] has quit [Ping timeout: 260 seconds] 21:48 -!- Highway61 [~Thunderbi@96.44.144.74] has quit [Quit: Highway61] 21:48 -!- Highway61 [~Thunderbi@96.44.144.74] has joined #bitcoin-core-dev 21:48 -!- ppisati [~ppisati@net-37-119-21-5.cust.vodafonedsl.it] has quit [Quit: leaving] 21:53 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 21:53 -!- amsudeep [~sudeep@122.171.210.166] has joined #bitcoin-core-dev 21:55 -!- ppisati [~ppisati@net-5-95-148-13.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:56 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 22:15 -!- amsudeep [~sudeep@122.171.210.166] has quit [Ping timeout: 256 seconds] 22:24 -!- amsudeep [~sudeep@122.171.187.46] has joined #bitcoin-core-dev 22:33 -!- amsudeep [~sudeep@122.171.187.46] has quit [Ping timeout: 256 seconds] 22:43 -!- amsudeep [~sudeep@171.48.17.240] has joined #bitcoin-core-dev 22:49 -!- amsudeep [~sudeep@171.48.17.240] has quit [Ping timeout: 240 seconds] 22:57 -!- amsudeep [~sudeep@122.171.207.203] has joined #bitcoin-core-dev 23:00 -!- edunham1 [~edunham@176.113.74.179] has quit [] 23:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 23:02 < jonasschnelli> achow101: thanks for the writeup! Will go through it now... 23:02 < sipa> 23:04 < gwillen> uh, assuming there is not something wrong with my IRC client, I see one line from jonasschnelli which is (presumably accidentally) written in black-on-black text, followed by a blank line from sipa 23:06 < achow101> gwillen: it's a space 23:07 < achow101> I see jonasschnelli's line fine, probably becaue I'm highlighted? 23:07 -!- amsudeep [~sudeep@122.171.207.203] has quit [Ping timeout: 258 seconds] 23:08 < sipa> oh, i didn't see jonasschnelli's at all, assuming it was an empty line 23:08 < sipa> sneaky. 23:13 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 23:13 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 23:14 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:14 < gwillen> yeah I figured that might have been what happened 23:15 -!- amsudeep [~sudeep@122.182.253.248] has joined #bitcoin-core-dev 23:16 < vasild> I see jonasschnelli's message as black-on-black too, had to copy-paste into another terminal so I can read it 23:18 -!- glyph1 [~glyph@185.204.1.185] has joined #bitcoin-core-dev 23:22 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Quit: leaving] 23:24 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 23:27 -!- amsudeep [~sudeep@122.182.253.248] has quit [Ping timeout: 256 seconds] 23:27 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 23:36 -!- amsudeep [~sudeep@122.179.63.144] has joined #bitcoin-core-dev 23:49 -!- amsudeep [~sudeep@122.179.63.144] has quit [Ping timeout: 264 seconds] 23:55 -!- amsudeep [~sudeep@122.171.168.139] has joined #bitcoin-core-dev 23:58 < jonasschnelli> hmm... I used my mobile (iOS) irc client (via a znc bouncer). Now back on my desktop client. Better? 23:59 < gwillen> your text is no longer black 23:59 < jonasschnelli> I also have a empty line from sipa. :} 23:59 < jonasschnelli> maybe someone is messing with my znc --- Log closed Fri Apr 10 00:00:48 2020