--- Log opened Fri Apr 10 00:00:48 2020 00:24 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 00:25 -!- amsudeep [~sudeep@122.171.168.139] has quit [Ping timeout: 264 seconds] 00:26 -!- jonatack_ [~jon@37.166.238.163] has joined #bitcoin-core-dev 00:29 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 00:29 -!- jonatack [~jon@37.164.104.82] has quit [Ping timeout: 250 seconds] 00:30 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 00:30 -!- amsudeep [~sudeep@122.179.42.220] has joined #bitcoin-core-dev 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 00:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 00:48 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Ping timeout: 240 seconds] 00:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 00:54 -!- kabaum [~kabaum@84.216.156.66] has joined #bitcoin-core-dev 00:55 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 00:58 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Quit: Leaving] 01:06 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 01:07 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Client Quit] 01:07 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 01:08 -!- kabaum [~kabaum@84.216.156.66] has quit [Ping timeout: 265 seconds] 01:12 -!- amsudeep [~sudeep@122.179.42.220] has quit [Remote host closed the connection] 01:13 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 01:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:14 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 01:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 01:19 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 01:19 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 01:46 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:50 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 01:55 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 02:00 -!- glyph1 [~glyph@185.204.1.185] has quit [] 02:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 02:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 02:05 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 02:08 -!- Arvidt [~Arvidt@p5DC4533E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:13 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 02:36 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 02:49 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 02:52 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 02:53 -!- inquis [~inquis@185.104.184.43] has joined #bitcoin-core-dev 03:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:02 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 03:03 -!- Morton73MacGyver [~Morton73M@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:08 -!- Morton73MacGyver [~Morton73M@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 258 seconds] 03:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:27 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 03:42 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 03:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:45 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 03:48 -!- CryptoNC [3269a33c@50-105-163-60.snpr.wi.frontiernet.net] has joined #bitcoin-core-dev 03:50 -!- CryptoNC [3269a33c@50-105-163-60.snpr.wi.frontiernet.net] has quit [Remote host closed the connection] 04:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:39 < bitcoin-git> [bitcoin] tom19990101 opened pull request #18583: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18583 04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:40 < bitcoin-git> [bitcoin] fanquake closed pull request #18583: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18583 04:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:47 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Read error: Connection reset by peer] 04:49 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 04:49 -!- per_ [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 04:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 05:00 -!- inquis [~inquis@185.104.184.43] has quit [] 05:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 05:01 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev 05:11 -!- jonatack_ [~jon@37.166.238.163] has quit [Ping timeout: 258 seconds] 05:20 -!- rex4539 [~rex4539@2a02:587:350c:a200:84e:b908:ccaf:2600] has joined #bitcoin-core-dev 05:21 -!- [n1x]_ [~n1x]_@195.206.183.79] has joined #bitcoin-core-dev 05:28 < vasild> MarcoFalke: https://github.com/bitcoin/bips/pull/907#issuecomment-611997913 -- I have just started looking into this, digesting the BIP for now. 05:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 05:30 < MarcoFalke> Yeah, I wasn't sure if dongcarl had done the fixups as well (locally, not public) 05:38 -!- ppisati [~ppisati@net-5-95-148-13.cust.vodafonedsl.it] has quit [Quit: leaving] 05:43 -!- rex4539 [~rex4539@2a02:587:350c:a200:84e:b908:ccaf:2600] has quit [Ping timeout: 246 seconds] 05:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:50 -!- ppisati [~ppisati@net-93-144-91-81.cust.dsl.teletu.it] has joined #bitcoin-core-dev 05:50 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:54 -!- Ralayax [2d0f3de9@233-61-15-45.ftth.cust.kwaoo.net] has joined #bitcoin-core-dev 05:56 -!- Ralayax [2d0f3de9@233-61-15-45.ftth.cust.kwaoo.net] has quit [Remote host closed the connection] 05:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:14 -!- rex4539 [~rex4539@2a02:587:350c:a200:84e:b908:ccaf:2600] has joined #bitcoin-core-dev 06:16 -!- jonatack [~jon@82.102.27.195] has joined #bitcoin-core-dev 06:16 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 06:17 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:30 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:32 < bitcoin-git> [bitcoin] hebasto closed pull request #18400: gui: Import only required Objective-C headers (master...20200321-objc-headers) https://github.com/bitcoin/bitcoin/pull/18400 06:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 06:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:51 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:54 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 06:55 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:59 -!- sipsorcery [~sipsorcer@37.228.254.212] has quit [Ping timeout: 240 seconds] 07:01 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880:388d:7cd4:47ce:721f] has joined #bitcoin-core-dev 07:06 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 07:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2b9a4a13324a...29893ec8751f 07:14 < bitcoin-git> bitcoin/master fa47a0b MarcoFalke: net: Make addr relay mockable 07:14 < bitcoin-git> bitcoin/master fa1793c MarcoFalke: net: Pass connman const when relaying address 07:14 < bitcoin-git> bitcoin/master fa1da3d MarcoFalke: test: Add basic addr relay test 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18454: net: Make addr relay mockable, add test (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18454 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:18 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 07:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:27 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 07:27 < hebasto> promag: around? 07:30 -!- rex4539 [~rex4539@2a02:587:350c:a200:84e:b908:ccaf:2600] has quit [] 07:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 07:49 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18584: test: Check that the version message does not leak the local address (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18584 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:00 -!- [n1x]_ [~n1x]_@195.206.183.79] has quit [] 08:02 -!- fearbeag [~sseanicid@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29893ec8751f...3347ca48816c 08:08 < bitcoin-git> bitcoin/master 7fcdec0 Hennadii Stepanov: Remove PID file at the very end 08:08 < bitcoin-git> bitcoin/master 3347ca4 MarcoFalke: Merge #18526: Remove PID file at the very end 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18526: Remove PID file at the very end (master...20200404-del-pid) https://github.com/bitcoin/bitcoin/pull/18526 08:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:14 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 08:17 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 08:20 -!- r2wj [~r2wj@37.120.217.243] has joined #bitcoin-core-dev 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3347ca48816c...a840dab2a582 08:24 < bitcoin-git> bitcoin/master fad691c MarcoFalke: rpc: Make verifychain default values static, not depend on global args 08:24 < bitcoin-git> bitcoin/master a840dab MarcoFalke: Merge #18541: rpc: Make verifychain default values static, not depend on g... 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:38 < instagibbs> ryanofsky, indeed looking at private keys disabled to change logic was basically a hack, moving forward with descriptor wallets we should try to do better 08:39 < instagibbs> I'm merely describing what will not work(and likely surprise the user) with #16528 08:39 < gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub 08:46 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 08:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:48 < bitcoin-git> [bitcoin] theStack opened pull request #18585: test: use zero-argument super() shortcut (Python 3.0+) (master...20201004-test-use-python3-non-zero-arg-super) https://github.com/bitcoin/bitcoin/pull/18585 08:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:15 < wumpus> PSA: please don't push anything to the master branch, I'm working on forking off 0.20 09:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:22 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/a840dab2a582...d84c9aa25d8b 09:22 < bitcoin-git> bitcoin/master d84c9aa Wladimir J. van der Laan: build: Bump version to 0.20.99 09:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:23 -!- alec [~alec@gateway/tor-sasl/alec] has quit [Ping timeout: 240 seconds] 09:24 < wumpus> ok, 0.20 branch has been created, master is free for merging for 0.21 09:25 < jonatack> 0.20 \o/ 09:25 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 09:30 -!- alec [~alec@gateway/tor-sasl/alec] has joined #bitcoin-core-dev 09:31 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 09:36 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-wwlnqkaihrrrlsvy] has quit [Ping timeout: 246 seconds] 09:36 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-ggeuxyvkfmehppau] has joined #bitcoin-core-dev 09:44 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Disconnected by services] 09:44 -!- promag_ is now known as promag 09:44 < promag> hebasto: yup 09:44 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:45 < promag> 0.20 \m/ 09:45 < promag> #18578 simple leak fix btw 09:45 < gribble> https://github.com/bitcoin/bitcoin/issues/18578 | gui: Fix itemWalletAddress leak when not tree mode by promag · Pull Request #18578 · bitcoin/bitcoin · GitHub 09:45 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880:388d:7cd4:47ce:721f] has quit [Ping timeout: 265 seconds] 09:47 < hebasto> promag: mind clarifying https://github.com/bitcoin/bitcoin/pull/18452#discussion_r406780940 ? 09:48 < promag> ah yes, I think it's fine doing in NodeImpl::startShutdown 09:49 < promag> it's not a gui concern I think 09:49 < MarcoFalke> 0.20 'o' 09:50 < promag> MarcoFalke: 18578 is a fix, so I can PR for 0.20 branch right? 09:50 < promag> (after merging is master) 09:51 < promag> *in 09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d84c9aa25d8b...6ab96ec5469c 09:52 < bitcoin-git> bitcoin/master 7501977 Jon Atack: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance 09:52 < bitcoin-git> bitcoin/master 5df0877 Jon Atack: test: update and harden interface_bitcoin_cli tests 09:52 < bitcoin-git> bitcoin/master 6ab96ec MarcoFalke: Merge #18574: cli: call getbalances.ismine.trusted instead of getwalletinf... 09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18574: cli: call getbalances.ismine.trusted instead of getwalletinfo.balance (master...getinfo-call-getbalances-instead-of-getwalletinfo-balances) https://github.com/bitcoin/bitcoin/pull/18574 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6ab96ec5469c...4eb1eeb02c57 09:54 < bitcoin-git> bitcoin/master 0660119 Russell Yanofsky: Drop unintended bitcoin-tx dependency on libevent 09:54 < bitcoin-git> bitcoin/master 01a3392 Russell Yanofsky: Drop bitcoin-wallet dependency on libevent 09:54 < bitcoin-git> bitcoin/master 4eb1eeb MarcoFalke: Merge #18504: build: Drop bitcoin-tx and bitcoin-wallet dependencies on li... 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18504: build: Drop bitcoin-tx and bitcoin-wallet dependencies on libevent (master...pr/dep-libevent) https://github.com/bitcoin/bitcoin/pull/18504 09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:56 < hebasto> promag: thanks 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/4eb1eeb02c57...1b3076136048 09:56 < bitcoin-git> bitcoin/master e6e44ee Russell Yanofsky: Multiprocess build changes 09:56 < bitcoin-git> bitcoin/master d630646 Russell Yanofsky: libmultiprocess depends build 09:56 < bitcoin-git> bitcoin/master 787f406 Russell Yanofsky: Set LD_LIBRARY_PATH consistently in travis tests 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367 09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1b3076136048...99d6a5be8bf1 09:59 < bitcoin-git> bitcoin/master 1dde238 Russell Yanofsky: Add ChainClient setMockTime, getWallets methods 09:59 < bitcoin-git> bitcoin/master 3ce16ad Russell Yanofsky: refactor: Use psbt forward declaration 09:59 < bitcoin-git> bitcoin/master 99d6a5b MarcoFalke: Merge #17999: refactor: Add ChainClient setMockTime, getWallets methods 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17999: refactor: Add ChainClient setMockTime, getWallets methods (master...pr/ipc-clients) https://github.com/bitcoin/bitcoin/pull/17999 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99d6a5be8bf1...a9213bbe75c6 10:01 < bitcoin-git> bitcoin/master 14e8cf9 Pieter Wuille: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChec... 10:01 < bitcoin-git> bitcoin/master a9213bb MarcoFalke: Merge #18422: [consensus] MOVEONLY: Move single-sig checking EvalScript co... 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:01 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18422: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (master...2020-03-evalchecksig) https://github.com/bitcoin/bitcoin/pull/18422 10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/a9213bbe75c6...10358a381aee 10:03 < bitcoin-git> bitcoin/master 8e2ecfe James O'Beirne: validation: add CChainState.m_from_snapshot_blockhash 10:03 < bitcoin-git> bitcoin/master 89cdf4d James O'Beirne: validation: introduce unused ChainstateManager 10:03 < bitcoin-git> bitcoin/master 5b690f0 James O'Beirne: refactor: move RewindBlockIndex to CChainState 10:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17737: Add ChainstateManager, remove BlockManager global (master...2019-12-au.chainman) https://github.com/bitcoin/bitcoin/pull/17737 10:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:10 < promag> MarcoFalke: Multi Merge 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/10358a381aee...51e2ce45d682 10:14 < bitcoin-git> bitcoin/master dcc8332 Andrew Toth: Add generateblock rpc 10:14 < bitcoin-git> bitcoin/master 7524b64 Andrew Toth: Add tests for generateblock 10:14 < bitcoin-git> bitcoin/master 51e2ce4 MarcoFalke: Merge #17693: rpc: Add generateblock to mine a custom set of transactions 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17693: rpc: Add generateblock to mine a custom set of transactions (master...generateblock) https://github.com/bitcoin/bitcoin/pull/17693 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 10:37 -!- lightlike [~lightlike@p200300C7EF13DC00E5298854FB323B21.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 10:47 < luke-jr> is the wallet meeting today or next week? :x 10:47 < achow101> luke-jr: today 10:47 < luke-jr> phew 10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:48 < bitcoin-git> [bitcoin] laanwj opened pull request #18586: build: Bump gitian descriptors to 0.21 (master...2020_04_bump_descriptors) https://github.com/bitcoin/bitcoin/pull/18586 10:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:49 < bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.0rc1 10:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:50 < achow101> \o/ 10:51 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:53 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 10:55 -!- roconnor [~roconnor@host-45-78-205-127.dyn.295.ca] has quit [Quit: Konversation terminated!] 10:59 -!- Netsplit *.net <-> *.split quits: tnaka, hadjiszs, stevenroose, BlueMatt, GoldmanSats 11:00 -!- r2wj [~r2wj@37.120.217.243] has quit [] 11:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 11:02 -!- theStack [~theStack@81.223.165.6] has quit [Remote host closed the connection] 11:03 -!- Netsplit over, joins: tnaka, stevenroose, BlueMatt, hadjiszs, GoldmanSats 11:19 -!- hadjiszs [~yourname@ns348042.ip-5-39-92.eu] has quit [Ping timeout: 240 seconds] 11:20 -!- hadjiszs [~yourname@ns348042.ip-5-39-92.eu] has joined #bitcoin-core-dev 11:21 -!- kest10 [~kest10@139.28.218.198] has joined #bitcoin-core-dev 11:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:33 -!- xavierfabric [~xavierfab@51.15.58.154] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in] 11:40 < MarcoFalke> #proposedwalletmeetingtopic (short topic) Return last processed block in most wallet RPCs 11:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:57 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving] 11:59 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:01 < achow101> wallet meeting? 12:03 < achow101> #startmeeting 12:03 < lightningbot> Meeting started Fri Apr 10 19:03:30 2020 UTC. The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:03 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:03 < achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 12:03 < achow101> jeremyrubin emilengler jonatack hebasto jb55 12:03 < jonatack> hi 12:03 < MarcoFalke> hi 12:04 < achow101> topics? 12:04 < MarcoFalke> mine 12:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:04 < achow101> I would also like to discuss watchonly descriptor wallet things 12:05 < achow101> #topic (short topic) Return last processed block in most wallet RPCs (MarcoFalke) 12:05 < MarcoFalke> In light of #17954 and generally that the wallet may fall behind on the best tip, the RPCs should return the last processed block 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/17954 | wallet: Remove calls to Chain::Lock methods by ryanofsky · Pull Request #17954 · bitcoin/bitcoin · GitHub 12:05 < MarcoFalke> This should be uncontroversial, but just making sure shouldn't hurt 12:06 < achow101> All the wallet RPCs? 12:06 < achow101> there are a bunch that don't return objects, and some that it probably doesn't matter 12:06 < MarcoFalke> At least the ones that report the balance or otherwise depend on the latest block processed 12:08 < jonatack> FWIW I've added fetching multiwallet balances client-side to -getinfo 12:08 < achow101> well getbalance returns just a number 12:08 < achow101> so you would have to make that an object, which would break a ton of things 12:08 < MarcoFalke> getbalances *smirk* 12:08 < jonatack> getbalance is superseded by getbalances anyway... could probably leave it be? 12:09 < achow101> yeah but who uses that? 12:10 < MarcoFalke> Maybe long term it makes sense to break the API 12:10 < MarcoFalke> getreceivedby* also returns only a plain number 12:11 < jonatack> if the rpc doesn't return an object i'm not sure it's worth breaking only for that 12:11 < jonatack> api v2 (tm) 12:12 < MarcoFalke> gettransaction, getbalances, getwalletinfo should be trivial to amend, since they are an object already 12:12 < achow101> yes 12:12 < MarcoFalke> jonatack: the API version is always v${VERSION_OF_BITCOIN_CORE} 12:13 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:fdd0:9d8c:d74d:864c] has joined #bitcoin-core-dev 12:13 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:fdd0:9d8c:d74d:864c] has quit [Client Quit] 12:14 < MarcoFalke> Anyway, that was the short topic. My issue is here: #18567 12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/18567 | Return block hash with wallet calls · Issue #18567 · bitcoin/bitcoin · GitHub 12:14 < jonatack> MarcoFalke: right... bitcoin-cli -version 12:15 < achow101> would it be ok to just not have it returned for getbalance and getreceivedby? 12:15 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:16 < jonatack> and getunconfirmedbalance 12:16 < achow101> iirc those can include unconfirmed txs too so even at a given block hash, the balance can still change 12:16 < MarcoFalke> I suspect most clients will ignore the value anyway 12:17 < achow101> jonatack: I think that's the one rpc that this is completely useless for 12:17 < MarcoFalke> achow101: Same is true for getbalances (it can change between blocks as well) 12:17 < jonatack> yes 12:17 < achow101> MarcoFalke: sure, just trying not to cause things to explode 12:18 < achow101> anyways, I think we can all just comment on the issue 12:18 -!- sipsorcery [~sipsorcer@37.228.254.212] has joined #bitcoin-core-dev 12:18 < achow101> #topic watchonly and descriptor wallets 12:19 < achow101> yesterday I wrote https://gist.github.com/achow101/94d889715afd49181f8efdca1f9faa25 which describes some of the motivations, use cases, and issues for descriptor wallets 12:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds] 12:19 -!- fearbeag [~sseanicid@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Quit: Leaving] 12:20 < achow101> one point that has come up in discussions is watchonly, in particular handling multisigs 12:20 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 12:20 < sipa> where watchonly just means "you don't have all private keys in your wallet locally" ? 12:21 < achow101> I think so 12:21 < sipa> (i bring that up, because say in a HW wallet situation, just because the key is not in your wallet.dat, doesn't mean you don't have the ability to spend) 12:23 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Client Quit] 12:23 < achow101> ryanofsky suggested having some descriptors be marked as "watchonly" and others as not, independent of private keys 12:24 < achow101> "I wonder if in this kind of wallet, ability to mark individual descriptors watchonly or not, ability to display two balances, and ability to have RPCs that know which descriptors are intended for signing regardless of whether private keys are present might help with UX, and maybe let someone get away with just having have one bitcoin wallet instead of two and having to exporting/import between them." 12:24 < sipa> i'm not sure how i feel about that 12:25 < sipa> there really shouldn't be a descriptor in the first place for the stuff you don't care about (and turning it into a watchonly thing to separate it feels like a hack) 12:25 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev 12:26 < sipa> i also don't have a better solution for how you'd go from "create single-key thing first, and then construct a multisig out of it" 12:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:27 < achow101> instagibbs also points out that if we allow descriptors with some but not all private keys, bumpfee and PSBT GUI break 12:27 < sipa> how so? 12:27 < achow101> so having a bool on the descriptors to indicate signing-ness or something would help with that 12:27 < achow101> but it does feel like we're regressing to legacy wallet territory 12:27 < sipa> i agree 12:28 < achow101> sipa: they switch on disable_private_keys. so if not disable_private_keys, sign, otherwise show/copy psbt 12:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 12:28 < achow101> but a multisig with some but not all privkeys is not disable_private_keys but will fail to sign 12:29 < sipa> wouldn't it be better to have separate RPCs for when you expect a fully-signed output vs PSBT output? 12:29 < sipa> and the latter would always work, and the former would just fail if not enough keys are present 12:30 < achow101> the other problem is that coin selection may choose to include a multisig utxo that you can't always sign for so sometimes sending will fail 12:30 < achow101> sipa: I think that's reasonable 12:30 < sipa> achow101: i think that's inherent to the no-mixed-wallet philosophy 12:31 < sipa> if you really want coin selection to choose directly-spendable coins over multisig ones, you should have two separate wallets 12:31 < sipa> the idea that you'd ever want those two mixed in the same wallet was a mistake i think, and it's what we're getting rid of? 12:31 < achow101> right. I don't think it's really a supported use case, but I'm not sure that we can/should block it 12:32 < sipa> i think to the extent possible the behavior of wallets and RPCs should not depend on whether you happen to have a private key locally 12:32 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 12:33 < achow101> right 12:33 < achow101> I think the separate RPCs and buttons idea mostly solves this. we can disable the signing one when explicitly there are no private keys 12:34 < achow101> those functionality may also be useful even when you do have all the private keys 12:34 < sipa> right 12:34 < sipa> maybe you want to get a PSBT out even when you have all private keys, e.g. for a final auditing on a secure machine before broadcasting or so 12:35 < sipa> (as they retain fee information) 12:35 < achow101> and we should stop changing behavior based on disable_private_keys 12:36 < sipa> yeah 12:36 < achow101> any other topics? 12:36 < sipa> at least for descriptor wallets... 12:37 < jonatack> sgtm (and good doc achow101, thanks) 12:39 < achow101> #endmeeting 12:39 < lightningbot> Meeting ended Fri Apr 10 19:39:12 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:39 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.html 12:39 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.txt 12:39 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.log.html 12:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:41 < instagibbs> achow101, "just add more buttons" still would result in things semi-randomly failing though 12:42 < instagibbs> like, sometimes maybe the "send" button would work, sometimes not, depending on what mixture of stuff you imported 12:43 < achow101> instagibbs: that was discussed as "don't do it" 12:43 < sipa> could it be greyed out when not enough private keys are present? :p 12:43 < instagibbs> sipa, don't know until you do coin selection :P 12:43 < instagibbs> achow101, oh I might have missed the result, looking through scrollback... 12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:44 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51e2ce45d682...75917591c840 12:44 < bitcoin-git> bitcoin/master dabe2bb Wladimir J. van der Laan: build: Bump gitian descriptors to 0.21 12:44 < bitcoin-git> bitcoin/master 7591759 Wladimir J. van der Laan: Merge #18586: build: Bump gitian descriptors to 0.21 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:44 -!- vasild_ is now known as vasild 12:44 < sipa> instagibbs: it feels very wrong that things would depend on coin selection 12:44 < instagibbs> yes. 12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:44 < bitcoin-git> [bitcoin] laanwj merged pull request #18586: build: Bump gitian descriptors to 0.21 (master...2020_04_bump_descriptors) https://github.com/bitcoin/bitcoin/pull/18586 12:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:47 < instagibbs> sipa, I'm reading your comments above as supportive of the idea that sometimes it wouldn't work, if the user had imported a private key of some sort? 12:48 < instagibbs> oh, "don't do it" as in user doesn't do it 12:49 < instagibbs> got it 12:51 < sipa> hmm 12:52 < sipa> i guess the relevant property that "no private keys" is conveying is "are sign operations guaranteed to always result in a fully-signed transaction" 12:53 < sipa> for a descriptor wallet you could technically infer this information from the descriptors (generate an sPK from them, try signing for it) 12:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 12:54 < instagibbs> i.e., if you can sign for all descriptors in wallet, magic behavior, vs "are there private keys" 12:54 < instagibbs> well, button greyed out at least 12:55 < sipa> which isn't so much "does this wallet have any private keys", but "is this a wallet that needs external stuff for signing" 12:58 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 12:58 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 12:59 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:18 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds] 13:23 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75917591c840...3eb8b1c3924c 13:36 < bitcoin-git> bitcoin/master 96cb597 Russell Yanofsky: gui: Avoid redundant tx status updates 13:36 < bitcoin-git> bitcoin/master 3eb8b1c MarcoFalke: Merge #17905: gui: Avoid redundant tx status updates 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:36 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17905: gui: Avoid redundant tx status updates (master...pr/ipc-txup) https://github.com/bitcoin/bitcoin/pull/17905 13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:40 < luke-jr> doh, missed it >_< 13:40 < luke-jr> wallet ppl still around? >.> 13:43 < luke-jr> After #18546, avoid-reuse wallets should be working correctly in 0.20, but remain broken in 0.19 which interprets "destdata" as a destination being non-change. 13:43 < achow101> luke-jr: kinda 13:43 < luke-jr> Since avoid-reuse was a new feature in 0.19 and doesn't affect older wallets or wallets that don't opt-in at all, we can probably get away with just saying "it's broken; upgrade or don't use it"… but this issue makes "destdata" unsafe to use for anything else. 13:43 < gribble> https://github.com/bitcoin/bitcoin/issues/18546 | Bugfix: Wallet: Safely deal with change in the address book [part 2] by luke-jr · Pull Request #18546 · bitcoin/bitcoin · GitHub 13:43 < luke-jr> #18550 instead moves/stores change "destdata" in a new key which older wallets will ignore, thereby making it safe to add new "destdata" keys even in old wallets without breaking backward compatibility. 13:43 < gribble> https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub 13:43 < luke-jr> However, doing this in 0.21 will mean extra code to support 0.20 avoid-reuse wallets as a special case. Or we can just merge something like #18572 into 0.20 to be forward compatible. 13:43 < gribble> https://github.com/bitcoin/bitcoin/issues/18572 | Wallet: Accept "changedata" db key as an alias to "destdata" by luke-jr · Pull Request #18572 · bitcoin/bitcoin · GitHub 13:43 < luke-jr> (Once it's safe to use "destdata" again, I hope to - for an example - reimplement address reuse warnings without bloom filters.) 13:45 < achow101> luke-jr: maybe add a wallet flag and don't let people downgrade from 0.21 if they used avoid_reuse? 13:47 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:47 < luke-jr> I think that would be even more complexity than the special-casing of "used" :x 13:47 < luke-jr> (which is about 3 LOC) 13:50 < achow101> why can't the change be backwards compatible? 13:50 < achow101> with 0.20 13:51 < luke-jr> that's the special casing of "used" 13:51 < luke-jr> for 0.20 (as is) to see it, it needs to be on a "destdata" db key, which breaks 0.19 and earlier 13:52 < luke-jr> for avoid-reuse, 0.19 and earlier didn't support it (or were just broken) 13:52 < luke-jr> but to use destdata for anything else requires fixing this for new keys 13:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 13:53 < achow101> i think i'm missing some context. I'll look at it more closely later and comment in the PR 13:54 < luke-jr> there isn't really much context.. ryanofsky got confused by the PRs :/ 13:55 < luke-jr> this is basically just trying to pick up the pieces broken by avoid-reuse being prematurely merged 13:56 < luke-jr> (and to an extent, working toward using destdata for address reuse warnings) 13:59 < luke-jr> oh well, I'll try to be around to answer ?s 14:00 -!- kest10 [~kest10@139.28.218.198] has quit [] 14:03 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 14:03 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 14:13 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:21 -!- Voker571 [~Voker57@139.28.218.198] has joined #bitcoin-core-dev 14:26 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:33 < bitcoin-git> [bitcoin] ryanofsky opened pull request #18587: gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged (master...pr/ipc-bal) https://github.com/bitcoin/bitcoin/pull/18587 14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:48 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 14:50 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:58 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 260 seconds] 14:59 -!- lightlike [~lightlike@p200300C7EF13DC00E5298854FB323B21.dip0.t-ipconnect.de] has quit [Quit: Leaving] 15:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 15:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:09 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 265 seconds] 15:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:18 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:28 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18322: refactor: Add params to node context (master...2003-nodeParams) https://github.com/bitcoin/bitcoin/pull/18322 15:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18322: refactor: Add params to node context (master...2003-nodeParams) https://github.com/bitcoin/bitcoin/pull/18322 15:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:34 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 15:35 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 15:50 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 256 seconds] 15:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 16:16 < MarcoFalke> #proposedmeetingtopic experimental libmultiprocess, next steps for multiprocess in general (MarcoFalke, fanquake, cfields, ryanofsky) 16:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 16:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:44 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18588: Revert "Merge #16367: Multiprocess build support" (master...2004-buildMultiProcess) https://github.com/bitcoin/bitcoin/pull/18588 16:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:48 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-cmynczamhlrpxplj] has quit [Quit: Connection closed for inactivity] 17:00 -!- Voker571 [~Voker57@139.28.218.198] has quit [] 17:03 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 250 seconds] 17:04 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 17:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:12 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:16 < bitcoin-git> [bitcoin] achow101 opened pull request #18589: Fix naming of macOS SDK and clarify version (master...fix-osx-sdk-extract) https://github.com/bitcoin/bitcoin/pull/18589 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:21 -!- Azor [~Azor@139.28.218.198] has joined #bitcoin-core-dev 17:23 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 260 seconds] 17:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:52 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 18:22 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:23 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:24 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:28 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:29 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 18:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 18:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:49 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 18:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 19:15 -!- Highway61 [~Thunderbi@96.44.144.74] has quit [Ping timeout: 258 seconds] 19:22 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 19:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 19:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 19:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 19:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 20:00 -!- Azor [~Azor@139.28.218.198] has quit [] 20:05 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 20:08 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:14 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:15 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 20:19 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 20:20 -!- EvanFettel [711656b0@113.22.86.176] has joined #bitcoin-core-dev 20:21 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 20:22 -!- visser_ [~visser_@185.104.184.43] has joined #bitcoin-core-dev 20:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 20:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 20:25 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 20:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 20:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:27 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 20:28 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 20:28 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 20:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 20:33 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 20:37 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:41 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 20:45 -!- EvanFettel [711656b0@113.22.86.176] has quit [Remote host closed the connection] 20:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:52 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 20:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 21:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 21:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 21:37 -!- molly [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 21:38 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 22:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:50 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 22:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 22:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 22:58 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:00 -!- visser_ [~visser_@185.104.184.43] has quit [] 23:10 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 258 seconds] 23:15 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 260 seconds] 23:16 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 23:16 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds] 23:16 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 23:16 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds] 23:16 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 23:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:16 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 23:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 23:19 -!- fajro [~fajro@185.104.184.43] has joined #bitcoin-core-dev 23:21 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev 23:22 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Client Quit] 23:23 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 23:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:24 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 23:24 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 23:35 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 23:38 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 23:53 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 23:53 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 23:56 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev --- Log closed Sat Apr 11 00:00:49 2020