--- Log opened Fri Apr 17 00:00:54 2020 00:03 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Ping timeout: 250 seconds] 00:04 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 00:07 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 00:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 00:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:32 -!- jarthur [~jarthur@2605:6000:1019:4971:a4cb:2ac8:5aba:91ef] has joined #bitcoin-core-dev 00:36 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 00:36 -!- SiAnDoG__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev 00:37 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection] 00:37 -!- jarthur [~jarthur@2605:6000:1019:4971:a4cb:2ac8:5aba:91ef] has quit [Ping timeout: 240 seconds] 00:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:44 -!- vasild_ is now known as vasild 01:02 -!- mytwocentimes [~mytwocent@104.140.54.51] has quit [Remote host closed the connection] 01:09 -!- jarthur [~jarthur@2605:6000:1019:4971:5cae:71af:e6d5:9560] has joined #bitcoin-core-dev 01:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:13 -!- jarthur [~jarthur@2605:6000:1019:4971:5cae:71af:e6d5:9560] has quit [Ping timeout: 240 seconds] 01:25 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev 01:36 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:46 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 01:58 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 02:00 -!- alorente [~alorente@184.75.223.227] has quit [] 02:01 -!- unruly247 [~unruly247@104.194.248.178] has quit [Remote host closed the connection] 02:01 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:07 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:09 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has joined #bitcoin-core-dev 02:14 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has quit [Ping timeout: 256 seconds] 02:18 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 02:21 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has left #bitcoin-core-dev [] 02:22 -!- jeremybennett [~jeremyben@184.75.223.227] has joined #bitcoin-core-dev 02:22 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has joined #bitcoin-core-dev 02:28 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has left #bitcoin-core-dev [] 02:29 -!- icota [~igor@cm-2242.cable.globalnet.hr] has joined #bitcoin-core-dev 02:33 -!- unruly247 [~unruly247@104.194.248.178] has joined #bitcoin-core-dev 02:42 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 02:42 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 02:43 -!- icota [~igor@cm-2242.cable.globalnet.hr] has quit [Quit: Konversation terminated!] 02:44 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has joined #bitcoin-core-dev 03:03 -!- Eliezer30Halvors [~Eliezer30@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:31 < hebasto> wumpus: if reasons for minimal libevent version 2.0.22 are unsure, it seems unsafe to allow build against 2.0.21, no? 03:32 < wumpus> as MarcoFalke says we have already allowed it forever 03:32 < wumpus> it works 03:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:32 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/969ee8549496...0856c1570679 03:32 < bitcoin-git> bitcoin/master 9b5950d Andrew Chow: bnb: exit selection when best_waste is 0 03:32 < wumpus> you are breaking it with your PR 03:32 < bitcoin-git> bitcoin/master 0856c15 Samuel Dobson: Merge #18262: bnb: exit selection when best_waste is 0 03:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:33 < bitcoin-git> [bitcoin] meshcollider merged pull request #18262: bnb: exit selection when best_waste is 0 (master...bnb-waste-zero) https://github.com/bitcoin/bitcoin/pull/18262 03:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:33 < wumpus> unless you intend to come up with a reason for that, which none of us really know for sure, that's hard to defend 03:33 < hebasto> wumpus: ok, going to set minimum to 2.0.21 03:34 -!- Eliezer30Halvors [~Eliezer30@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 03:34 < wumpus> thanks! if the fuzz test really turns out to be a problem to make compatible, you could just #ifdef it out for that version 03:35 < wumpus> but I don't know the error message they get 03:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:38 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:39 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 03:41 < wumpus> so that's why I recommended to enable building the fuzz tests on the xenial travis run so we can see 03:42 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 03:44 < wumpus> I see I still have a xenial VM myself, will try... 03:45 -!- icota [d5953ef3@cm-2242.cable.globalnet.hr] has joined #bitcoin-core-dev 03:46 -!- icota [d5953ef3@cm-2242.cable.globalnet.hr] has quit [Remote host closed the connection] 03:47 -!- icota [~igor@cm-2242.cable.globalnet.hr] has joined #bitcoin-core-dev 03:49 < icota> has anyone tried compiling libbitcoind.so since https://github.com/bitcoin/bitcoin/pull/5084 ? 03:49 < icota> i'm trying to use the rdynamic trick 03:50 < icota> i configure with: LDFLAGS='-rdynamic' --disable-reduce-exports --disable-tests --disable-bench --enable-debug --with-utils=no --with-gui=no --enable-shared 03:50 < icota> but i can't link my hello world against the resulting binary 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0856c1570679...4a71c469058b 03:51 < bitcoin-git> bitcoin/master 69ffddc Sebastian Falbesoner: refactor: Remove unused methods CBloomFilter::reset()/clear() 03:51 < bitcoin-git> bitcoin/master 4a71c46 MarcoFalke: Merge #18670: refactor: Remove unused methods CBloomFilter::reset()/clear(... 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:51 < theStack> ad libevent 2.0.21: the problem is that the fuzz test http_request calls functions from libevent that are not part from the API, i.e. internal functions: evhttp_parse_firstline_ 03:51 < emilengler> icota: Can you send a link to a pastebin with the error message? 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18670: refactor: Remove unused methods CBloomFilter::reset()/clear() (master...20200416-refactor-remove-unused-bloom-filter-reset) https://github.com/bitcoin/bitcoin/pull/18670 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:52 < theStack> and those functions are named slightly different on libevent 2.0.21, the last underline is missing (at least on my system, ubuntu xenial) 03:52 < icota> emilengler: sure thing, https://pastebin.com/EmKEZcuP 03:52 < icota> it seems to be exporting std::cout amongst other symbols 03:52 < icota> i'd like to play with this. any clever way to stop it from exporting stdlib symbols? 03:53 < emilengler> icota: Can you try `LD_RUN_PATH=. g++ test.cpp -l:bitcoind -L.` 03:53 < icota> emilengler: same error 03:53 < emilengler> Maybe the problem is the argument order in your g++ invoke 03:54 < emilengler> `LD_RUN_PATH=. g++ test.cpp -L .-l:bitcoind` 03:54 < emilengler> Oh, please put a space between the dot before invoking -l 03:54 < emilengler> Mistake on my side... 03:54 < emilengler> Also is the colon required? I never saw a colon when invoking -l 03:55 < icota> no worries 03:55 < icota> colon is because the binary doesn't have a conventional name 03:55 < icota> libwhatever.so 03:55 < icota> it finds it, hence the erro 03:55 < icota> r 03:59 < meshcollider> what do we do with changes like #18466 which is API breaking 03:59 < gribble> https://github.com/bitcoin/bitcoin/issues/18466 | rpc: fix invalid parameter error codes for {sign,verify}message RPCs by theStack · Pull Request #18466 · bitcoin/bitcoin · GitHub 04:01 < meshcollider> The change looks correct but I also suspect we have to just keep incorrect error codes as-is 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:08 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4a71c469058b...c189bfd260ca 04:08 < bitcoin-git> bitcoin/master 1abbdac Fabian Jahr: wallet: Prefer full destination groups in coin selection 04:08 < bitcoin-git> bitcoin/master a2324e4 Fabian Jahr: test: Improve naming and logging of avoid_reuse tests 04:08 < bitcoin-git> bitcoin/master c189bfd Samuel Dobson: Merge #17824: wallet: Prefer full destination groups in coin selection 04:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:09 < wumpus> theStack: thanks, that sounds easy to work around with an ifdef at least then :) 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:09 < bitcoin-git> [bitcoin] meshcollider merged pull request #17824: wallet: Prefer full destination groups in coin selection (master...i17603) https://github.com/bitcoin/bitcoin/pull/17824 04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:09 < wumpus> meshcollider: if it's minor things, just mention it in the release notes 04:10 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has joined #bitcoin-core-dev 04:11 < wumpus> (and in this case it is, I don't have much of an optinion on the PR itself looks like it slightly improves consistency, though, no one has written strong guidelines when to use what RPC error code) 04:12 < meshcollider> Yeah, alright 04:12 < theStack> wumpus: yes, a preprocessor check should solve the problem for libevent 2.0.21 04:13 < meshcollider> promag: what's the status of #18471 04:13 < gribble> https://github.com/bitcoin/bitcoin/issues/18471 | qa: Test shared validation interface by promag · Pull Request #18471 · bitcoin/bitcoin · GitHub 04:13 < meshcollider> You asked for 0.20 milestone a while back, is it still important? 04:14 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has quit [Ping timeout: 252 seconds] 04:15 < wumpus> I'm really wondering about https://github.com/bitcoin/bitcoin/issues/18652#issuecomment-614646655 04:16 < wumpus> what in libc was blocking thread-local support, I have been unable to figure this out, compiled a few small C++ programs using __thread but didn't see any libc dependencies appear 04:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:20 -!- unruly247 [~unruly247@104.194.248.178] has quit [Remote host closed the connection] 04:21 < wumpus> the only tls-related libc function I could find is " __tls_get_addr@GLIBC_2.3", which would suggest libc 2.3 04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:34 < bitcoin-git> [bitcoin] laanwj opened pull request #18681: donotmerge: build: Enable thread-local with glibc compat (master...2020_04_thread_local_compat) https://github.com/bitcoin/bitcoin/pull/18681 04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:35 < fanquake> wumpus: I haven’t gone back to read the old threads, but a gitian build sounds like a good idea 04:36 < wumpus> right, probably most efficient way to find out :) 04:37 < fanquake> In regards to libevent 2.0.21. Also tried to find all the old discussion, my gut feeling was bugs that we were trying to avoid, maybe shutdown related. Haven’t got anything conclusive though 04:38 < fanquake> It's also possible in the mean time that we've done refactorings such that those concerns are no longer relevant. 04:39 < wumpus> given that everyone with xenial has been building against 2.0.21 and we got, afaik, zero complaints about that (besides the fuzzer build issue), it can't be *that* bad 04:40 < wumpus> yes, that's possible too 04:54 < wumpus> it highlights that it's kind of important to document *why* something is the minimum version somewhere, sure, it's always possible to find it between reams of commits and github comments, but for older projects that gets less and less efficient 04:54 < wumpus> #8639 does that ofcourse for most deps 04:54 < gribble> https://github.com/bitcoin/bitcoin/issues/8639 | Docs: Minimum required dependencies and current CVEs · Issue #8639 · bitcoin/bitcoin · GitHub 04:55 < wumpus> and in the case of libevent i'm sure no CVE was involved 04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c189bfd260ca...c2e53ff064df 04:58 < bitcoin-git> bitcoin/master bda84a0 Fabian Jahr: rpc: Add documentation for deactivating settxfee 04:58 < bitcoin-git> bitcoin/master 3867727 Fabian Jahr: rpc: settxfee respects -maxtxfee wallet setting 04:58 < bitcoin-git> bitcoin/master c2e53ff MarcoFalke: Merge #18467: rpc: Improve documentation and return value of settxfee 04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18467: rpc: Improve documentation and return value of settxfee (master...txfee0) https://github.com/bitcoin/bitcoin/pull/18467 04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- jeremybennett [~jeremyben@184.75.223.227] has quit [] 05:00 < hebasto> theStack: on xenial trying to replicate compiling bug for fuzzing code. Currently, configure returns error: checking whether C++ compiler accepts -fsanitize=fuzzer,address,undefined... no 05:00 < hebasto> did you encounter it? 05:01 < hebasto> having system clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final) 05:07 < theStack> hebasto: i only tried with clang-8 so far, where the configure script didn't cause problems 05:07 < hebasto> theStack: ok, going to upgrade clang :) 05:09 < wumpus> clang-8 is a xenial package? 05:10 < theStack> wumpus: yup, seems like that: https://packages.ubuntu.com/search?suite=xenial&keywords=clang-8 05:11 -!- Highway61 [~Thunderbi@104.129.24.138] has joined #bitcoin-core-dev 05:20 < theStack> i found out that libevent 2.1.1-alpha was the first release with internal functions renamed with underscore suffix 05:20 < theStack> see upcoming PR 05:21 -!- cassier [~cassier@89.40.181.148] has joined #bitcoin-core-dev 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:21 < bitcoin-git> [bitcoin] theStack opened pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682 05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:43 < hebasto> it seems GH has connection issues. Or just for me? 05:55 -!- icota [~igor@cm-2242.cable.globalnet.hr] has quit [Quit: Konversation terminated!] 06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683 06:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:10 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has joined #bitcoin-core-dev 06:11 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Remote host closed the connection] 06:12 -!- Highway61 [~Thunderbi@104.129.24.138] has joined #bitcoin-core-dev 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2e53ff064df...ecc2e4e363ee 06:12 < bitcoin-git> bitcoin/master eab7367 Jon Atack: fuzz: fix unused variable compiler warning 06:12 < bitcoin-git> bitcoin/master ecc2e4e MarcoFalke: Merge #18664: fuzz: fix unused variable compiler warning 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18664: fuzz: fix unused variable compiler warning (master...fix-unused-variable-warning) https://github.com/bitcoin/bitcoin/pull/18664 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:14 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:15 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has quit [Ping timeout: 252 seconds] 06:19 -!- kljasdfvv [~flack@p200300D46F0C1400A4A3CF9874767CDB.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 06:19 < hebasto> wow! we have "Needs Guix build" label now. cool :) 06:41 -!- geforce04 [~geforce04@37-2-111-208-in-addr-arpa.omnispring.net] has joined #bitcoin-core-dev 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:43 < bitcoin-git> [bitcoin] jnewbery closed pull request #17562: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562 06:43 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: Connection reset by peer] 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:44 < promag> meshcollider: thanks for taking a look, needs rebase. don't worry 06:47 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 06:55 -!- mol_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:57 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:58 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 07:00 -!- mol_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:02 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ecc2e4e363ee...54f812d9d298 07:14 < bitcoin-git> bitcoin/master fac5c37 MarcoFalke: scripted-diff: Sort test includes 07:14 < bitcoin-git> bitcoin/master fa488f1 MarcoFalke: scripted-diff: Bump copyright headers 07:14 < bitcoin-git> bitcoin/master fa4632c MarcoFalke: test: Move boost/stdlib includes last 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has quit [Remote host closed the connection] 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18673: scripted-diff: Sort test includes (master...2004-testSortIncludes) https://github.com/bitcoin/bitcoin/pull/18673 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:32 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:34 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 07:35 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 07:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 07:36 < MarcoFalke> Does anyone run the tests locally? Is anyone seeing failures in wallet_dump? 07:36 < MarcoFalke> via the test_runner.py 07:40 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:40 < bitcoin-git> [bitcoin] jnewbery opened pull request #18685: [validation] Simplify ConnectTrace (master...2020-04-connecttrace-simplify) https://github.com/bitcoin/bitcoin/pull/18685 07:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:40 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 07:43 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 07:44 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 07:45 -!- someone235 [uid419897@gateway/web/irccloud.com/x-pyrkbqdjxkhnokzd] has joined #bitcoin-core-dev 07:50 -!- grunch__ [~grunch@2800:810:547:857b:b467:713c:becb:5f23] has joined #bitcoin-core-dev 07:51 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 07:55 < jonatack> MarcoFalke: I run them locally. Rerunning now on master. 07:56 < MarcoFalke> They reproducibly fail for me, so either no one is running the tests or everyone has horribly slow machines or no one reports test failures 07:57 < MarcoFalke> They are broken for the last 3 days or so 07:57 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has joined #bitcoin-core-dev 08:00 -!- cassier [~cassier@89.40.181.148] has quit [] 08:03 < jonatack> yup it fails line 161 08:04 < jonatack> first run both via the runner and directly calling it 08:16 -!- pmuir [~pmuir@89.40.181.148] has joined #bitcoin-core-dev 08:25 -!- Guyver2__ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:28 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 08:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 08:30 -!- alko89 [~alko@cpe-85-10-28-138.static.amis.net] has quit [Quit: Konversation terminated!] 08:37 < MarcoFalke> Anyway, the fix is here: #18641 08:37 < gribble> https://github.com/bitcoin/bitcoin/issues/18641 | test: Create cached blocks not in the future by MarcoFalke · Pull Request #18641 · bitcoin/bitcoin · GitHub 08:43 -!- grunch__ [~grunch@2800:810:547:857b:b467:713c:becb:5f23] has quit [Ping timeout: 246 seconds] 08:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:00 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 09:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 09:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:17 < hebasto> wumpus: sipa: could block TBAALi-ros on GH ? 09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/54f812d9d298...244daa482151 09:18 < bitcoin-git> bitcoin/master fa86a4b MarcoFalke: rpc: Rename first arg of generateblock RPC to "output" 09:18 < bitcoin-git> bitcoin/master fa5b1f0 MarcoFalke: rpc: Document all aliases for second arg of getblock 09:18 < bitcoin-git> bitcoin/master fa168d7 MarcoFalke: rpc: Document all aliases for first arg of listtransactions 09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18607: rpc: Fix named arguments in documentation (master...2004-rpcDoc) https://github.com/bitcoin/bitcoin/pull/18607 09:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:21 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 09:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 09:36 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 09:37 < dongcarl> Did we ever reach a conclusion about PPA organization? 09:42 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:43 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:47 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:49 -!- jarthur [~jarthur@2605:6000:1019:4971:1031:3df2:bbe7:45dc] has quit [Remote host closed the connection] 09:50 -!- jarthur [~jarthur@2605:6000:1019:4971:1dcc:bbdd:88f8:1c01] has joined #bitcoin-core-dev 09:51 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 09:56 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Ping timeout: 258 seconds] 09:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 10:03 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 246 seconds] 10:06 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Ping timeout: 256 seconds] 10:12 -!- mytwocentimes [~mytwocent@178.197.227.159] has joined #bitcoin-core-dev 10:14 -!- grunch__ [~grunch@2800:810:547:857b:b467:713c:becb:5f23] has joined #bitcoin-core-dev 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:14 < bitcoin-git> [bitcoin] hebasto opened pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686 10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:16 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:19 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 10:20 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:21 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 10:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:22 < bitcoin-git> [bitcoin] hebasto closed pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686 10:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 10:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 10:26 -!- pinheadmz_ [~matthewzi@172.98.93.212] has joined #bitcoin-core-dev 10:27 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 10:27 -!- pinheadmz_ is now known as pinheadmz 10:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:40 -!- Highway61 [~Thunderbi@104.129.24.138] has joined #bitcoin-core-dev 10:48 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:57 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal] 10:57 -!- Kiminuo [~mix@141.98.103.150] has quit [Remote host closed the connection] 10:58 -!- Kiminuo [~mix@141.98.103.150] has joined #bitcoin-core-dev 11:00 -!- pmuir [~pmuir@89.40.181.148] has quit [] 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/244daa482151...d7bdba460cc0 11:02 < bitcoin-git> bitcoin/master faceeae MarcoFalke: ci: Disable valgrind functionl tests on forked repos to avoid timeouts 11:02 < bitcoin-git> bitcoin/master d7bdba4 MarcoFalke: Merge #18683: ci: Disable valgrind functionl tests on forked repos to avoi... 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7bdba460cc0...c54295c1a206 11:06 < bitcoin-git> bitcoin/master fa32097 MarcoFalke: test: Create cached blocks not in the future 11:06 < bitcoin-git> bitcoin/master c54295c MarcoFalke: Merge #18641: test: Create cached blocks not in the future 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:12 -!- geforce04 [~geforce04@37-2-111-208-in-addr-arpa.omnispring.net] has quit [Remote host closed the connection] 11:15 -!- commavir [~vir@23.226.237.192] has quit [Remote host closed the connection] 11:15 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev 11:27 < sipa> fanquake: deleted comments from and blocked jasdeep9899 11:40 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 11:41 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:47 -!- Seyaryuki [~Seyaryuki@84.39.116.180] has joined #bitcoin-core-dev 11:52 < midnight> go sipa \o/ 12:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 12:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:09 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18688: fuzz: Merge in parallel (master...2004-fuzzPar) https://github.com/bitcoin/bitcoin/pull/18688 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:40 < bitcoin-git> [bitcoin] pierreN opened pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689 12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 13:00 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 13:01 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:04 -!- pinheadmz [~matthewzi@172.98.93.212] has quit [Ping timeout: 256 seconds] 13:04 -!- pinheadmz_ is now known as pinheadmz 13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:14 < bitcoin-git> [bitcoin] robot-visions opened pull request #18690: test: Check object hashes in wait_for_getdata (master...wait-for-getdata) https://github.com/bitcoin/bitcoin/pull/18690 13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:37 < bitcoin-git> [bitcoin] jonatack opened pull request #18691: test: fix intermittent error in interface_bitcoin_cli (master...fix-intermittent-credentials-issue) https://github.com/bitcoin/bitcoin/pull/18691 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:38 -!- captjakk [~captjakk@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 13:41 < captjakk> Currently the behavior of Bitcoin Core in a pruned state is to return an RPC error when a block is requested that has been pruned. I was thinking about working on a change that would allow Core to dynamically fetch a block it didn't have, and verify it against the retained headers. This ultimately implies a slight implementation change to the peer protocol, but at first glance this seems harmless and potentially very helpful 13:41 < captjakk> as we get to larger numbers of applications/protocols that depend on core. Does anyone know of a reason this would be bad? 13:43 < gwillen> that's kind of interesting. I'm not an expert so you should wait for one of those to chime in, but I expect this sort of thing mostly doesn't exist due to lack of demand? 13:44 < gwillen> you would need a more complicated scheme for managing pruning if you have random old blocks lying around because an RPC client wanted them, you'd want some kind of cacheing or pinning scheme, presumably you'd need new RPCs to implement that (not just make it implicit, it's too expensive an operation for that I think) 13:45 < captjakk> Here's why we want it. At Start9 We are building the Embassy which allows you to run a pruned node quite easily. Archives are necessary for some and helpful for everyone, but we want to make it such that running a full node that is usable by various wallets today does not necessitate full archives/txindex 13:46 < gwillen> I think it's rare to want single old blocks, do you have a specific place that's coming up? 13:46 < captjakk> Here's the situation 13:46 < captjakk> say you have a full node synced from genesis but it's pruned to only keep 5GB of data 13:47 < captjakk> if you want to add a new application, say, c-lightning, you either require a resync or it needs to be able to register itself with core to inform core to retain all blocks newer than a certain height 13:47 < captjakk> OR 13:47 < captjakk> it would need to be able to dynamically fetch a block that had been pruned 13:48 < captjakk> my understanding is that currently pruned nodes keep ALL block headers 13:48 < captjakk> even if the associated blocks have been long since purged 13:48 < sipa> applications that require access to historical blocks are broken, except for debugging/emergency recovery situations 13:48 < captjakk> even for new syncs? 13:48 < gwillen> well "new syncs" are why I asked about "random" blocks specifically 13:49 < sipa> a new wallet doesn't need access to old blocks, because its keys are new 13:49 < captjakk> OK so dynamic fetching may be unnecessarily expensive here 13:49 < gwillen> also, isn't "retain all blocks after a certain height" in fact already supported in RPC 13:49 < sipa> that said, i see no technical reason why implementing your suggestion would be a problem 13:49 < gwillen> so you might already have what you need 13:49 < captjakk> it needs to support it from multiple dependents 13:50 < captjakk> if I want both C-lightning and wasabi to share a full node, they need a way to deconflict the specification of which old blocks they need 13:50 < sipa> captjakk: there is a recently opened issue about multiple applications being able to register they need blocks, and letting them individually declare to be done up to block X 13:51 < captjakk> do you know what number? or the name of the rpc call? 13:51 < captjakk> (proposed) 13:51 < gwillen> for reference the mentioned issue is https://github.com/bitcoin/bitcoin/issues/18599 13:51 < captjakk> This was opened by my brother, I am the other commenter :) 13:51 < captjakk> captjakk == ProofOfKeags 13:52 < captjakk> haven't changed my irc handle yet 13:52 < gwillen> ah! hah. 13:52 < captjakk> But either way, great! 13:52 < captjakk> We are more than happy to develop this proposal/code it up 13:52 < gwillen> this seems like it may be a "patches accepted" situation -- that is, it's probably not too hard to write 'keepheight', but you might have to do it if you want it 13:53 < captjakk> I just wanted to check in to see if it may be controversial 13:53 < sipa> gwillen: well there already exists manual pruning mode 13:53 < sipa> where you need to issue an RPC to prune 13:53 < sipa> the issue is that this is "single user" 13:53 < captjakk> correct 13:53 < gwillen> right, so it seems like modifying it to track multiple "pins" wouldn't be too complex 13:53 < captjakk> because it pruning is done via positiva 13:53 < captjakk> great 13:54 < captjakk> again, we're happy to code it up 13:54 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 13:54 < sipa> patches welcome, as far as i'm concerned 13:54 < captjakk> cool! 13:56 < gwillen> I don't know if you've worked in the bitcoin core tree before, but in addition to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md I highly recommend looking around under /doc/, especially /doc/productivity.md . 13:57 < captjakk> This will be the first code contributions we've made 13:57 < captjakk> so yes, any info on how to do this from a process standpoint is appreciated 13:58 < gwillen> cool, definitely read through CONTRIBUTING.md, whatever links from it look relevant, plus productivity.md, which has some big time-saving tips in it 13:58 -!- captjakk is now known as proofofkeags 13:58 < jonatack> good tips. also don't miss doc/developer-notes.md 13:59 < gwillen> honestly the whole 'doc' folder is good to skim for stuff that appears relevant 13:59 < gwillen> also I would consider fleshing out your proposed RPC interface and detailing it on the issue thread before you start coding too much, so people can comment on the design 13:59 < proofofkeags> yeah I figured 13:59 < gwillen> (probably come back here with a link once you have that) 14:00 -!- Seyaryuki [~Seyaryuki@84.39.116.180] has quit [] 14:00 < proofofkeags> is this something that should be detailed in the issue, or does it warrant a Bip 14:00 < proofofkeags> seems that since it's limited to RPC the bip isn't necessary 14:00 < proofofkeags> but I'm not sure what heuristic is used for bips 14:01 < sipa> proofofkeags: BIPs == things that require cross-application standards 14:01 < sipa> i don't think that's applicable here 14:02 < proofofkeags> cool, makes sense 14:02 -!- drbonez [~drbonez@174-16-155-177.hlrn.qwest.net] has joined #bitcoin-core-dev 14:02 < proofofkeags> so any change or addition to the peer protocol or address schemes and the like 14:02 -!- Guyver2__ [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18692: test: Bump timeout in wallet_import_rescan (master...2004-qaBumpTimeout) https://github.com/bitcoin/bitcoin/pull/18692 14:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:03 < sipa> P2P protocol changes, consensus changes, address formats, but also general things like standard derivation paths for keys, ... 14:03 < sipa> there is a BIP for the "bits" denomination 14:04 < proofofkeags> lol, I suppose that's fair 14:04 < sipa> changes to the BIP process itself (BIP 1, BIP 2) 14:05 < proofofkeags> cool, thanks for the input y'all 14:07 < yevaud> for a rare one, BIP50 is a report, not a change. 14:08 < sipa> ah, indeed 14:08 < yevaud> an incorrect report, but one none the less. 14:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 14:12 < proofofkeags> incorrect how? 14:13 -!- proofofkeags [~captjakk@174-29-9-247.hlrn.qwest.net] has quit [Quit: Leaving...] 14:13 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 14:16 < yevaud> it's conclusion is wrong, fundamentally. it suggests that the correct option was to encourage people to downgrade to 0.7, limit block size to 500KB, and increase the number of locks allowed in berkleydb. 14:17 < yevaud> simply, no version of Bitcoin before 0.8 was able to maintain consensus even between nodes of the same version. realistically there's no amount of increase in berkeleydb which can allow nodes to operate properly, and the number in that document is well, well below the value required even for the time. 14:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 14:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Client Quit] 14:17 < sipa> the document does mention "This would be an issue even if the entire network was running version 0.7.2. It is theoretically possible for one 0.7.2 node to create a block that others are unable to validate, or for 0.7.2 nodes to create block re-orgs that peers cannot validate, because the contents of each node's blkindex.dat database is not identical, and the number of locks required depends on the 14:18 < sipa> exact arrangement of the blkindex.dat on... 14:18 < sipa> disk (locks are acquired per-page). " 14:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 14:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c54295c1a206...895c71e53557 14:19 < bitcoin-git> bitcoin/master 6f8b498 Sebastian Falbesoner: fuzz: http_request workaround for libevent < 2.1.1 14:19 < bitcoin-git> bitcoin/master 895c71e MarcoFalke: Merge #18682: fuzz: http_request workaround for libevent < 2.1.1 14:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:19 < yevaud> I've seen a few people argue based on BIP50 that if the locks are set to the value described, it is safe. 14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682 14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:20 < yevaud> perhaps that's down to interpretation. 14:20 < sipa> due to the way locks were grabbed for an entire reorg, arguably for any finite value of the lock limits, pre-0.8 was unable to handle arbirarily long reorgs, which is arguably a consensus failure 14:21 < sipa> then again, i believe there have been plenty of other versions since 0.8 that also weren't practically capable of doing very deep (say 1000s of blocks) reorgs 14:21 -!- ButterflyOfFire [~Butterfly@84.39.116.180] has joined #bitcoin-core-dev 14:22 < yevaud> true. in those versions reverting a UTXO change wrote back into the mempool for every block (or something close), it was excruciatingly slow. 14:23 < yevaud> I've attempted to sync 0.7 with 2**32 locks, it ends up failing consensus effectively at random. it was never clear exactly why. 14:24 < sipa> by unable i don't just mean infeasibly slow - i mean it'd go OOM 14:25 < yevaud> right. it would be an interesting exercise to get 0.7 to sync with the modern network, but it's in the order of months of sync time, even entirely in NVMe cache. 14:26 < yevaud> I'm not even confident it can process blocks fast enough to stay in sync at the head. 14:28 < sipa> haha, yes 14:28 < sipa> that too is arguably a consensus failure... 14:29 < yevaud> presumably if we had CPUs that were orders of magnitude faster, it would be consensus compatible again. sort of stretching the definition. 14:30 -!- grunch__ [~grunch@2800:810:547:857b:b467:713c:becb:5f23] has quit [Ping timeout: 272 seconds] 14:34 < gwillen> ugh, I hate the fact that every time some fucking altcoin brings over a commit that has my name in it, I get pinged 14:34 < gwillen> if anybody knows a way to prevent that I'd love to hear it 14:35 < sipa> i think we have some recommendation somewhere not to put @username in commit messages 14:35 < sipa> someone even suggested having a linter for it 14:35 < gwillen> welp 14:55 -!- Kiminuo [~mix@141.98.103.150] has quit [Read error: Connection reset by peer] 15:11 < fanquake> sipa: ok 15:12 < sipa> fanquake: were you... asleep? 15:13 < fanquake> Yes I was hah 15:13 < fanquake> Can you also block amirabbaska 15:20 < sipa> done 15:30 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:33 < achow101> fanquake sleeps? that's new :p 15:40 < sipa> it must be a sporadic activity 15:40 < dongcarl> achow101: You see, he has a secondary brain directly attached to an X server, which never sleeps 15:43 < sipa> dongcarl: his computer? 15:44 < dongcarl> XD 15:50 < jonatack> :D 16:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:08 < bitcoin-git> [bitcoin] hebasto opened pull request #18695: test: Replace boost::mutex with std::mutex (master...200417-boost-mu) https://github.com/bitcoin/bitcoin/pull/18695 16:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:16 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection] 16:17 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #bitcoin-core-dev 16:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 16:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:36 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 240 seconds] 16:44 < hebasto> IIUC, it seems our unit tests ignore the case when g_parallel_script_checks=false. Is it intended? 16:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 16:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:47 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 16:58 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 17:00 -!- ButterflyOfFire [~Butterfly@84.39.116.180] has quit [] 17:01 -!- mytwocentimes [~mytwocent@178.197.227.159] has quit [Remote host closed the connection] 17:01 -!- mytwocentimes [~mytwocent@104.206.206.83] has joined #bitcoin-core-dev 17:08 -!- brakmic [~brakmic@185.183.85.108] has quit [] 17:12 -!- jarthur_ [~jarthur@2605:6000:1019:4971:797d:5c2c:1d7c:eee6] has joined #bitcoin-core-dev 17:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:15 -!- jarthur_ [~jarthur@2605:6000:1019:4971:797d:5c2c:1d7c:eee6] has quit [Client Quit] 17:15 -!- jarthur [~jarthur@2605:6000:1019:4971:1dcc:bbdd:88f8:1c01] has quit [Ping timeout: 240 seconds] 17:21 -!- dfkt [~dfkt@77.243.177.38] has joined #bitcoin-core-dev 17:26 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 17:35 -!- tryphe_ is now known as tryphe 17:54 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 250 seconds] 17:55 -!- drbonez [~drbonez@174-16-155-177.hlrn.qwest.net] has quit [Remote host closed the connection] 18:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:07 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 18:08 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:10 -!- drbonez [~drbonez@174-16-155-177.hlrn.qwest.net] has joined #bitcoin-core-dev 18:15 -!- drbonez [~drbonez@174-16-155-177.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 18:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:54 -!- Highway61 [~Thunderbi@104.129.24.138] has quit [Ping timeout: 256 seconds] 18:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 19:13 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:22 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:23 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 19:23 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:38 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: Bye] 19:39 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 19:48 < fanquake> sipa: can you block Karensheraton from bitcoin-core 19:50 < sipa> done 19:55 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: Bye] 19:56 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 19:57 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Client Quit] 19:59 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 20:00 -!- dfkt [~dfkt@77.243.177.38] has quit [] 20:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:13 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:11f0:d5d:3ee0:8885] has joined #bitcoin-core-dev 20:20 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 20:22 -!- phyll1s_work [~phyll1s_w@185.104.184.43] has joined #bitcoin-core-dev 20:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 20:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:15 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 21:16 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 21:20 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 21:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 21:58 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:11f0:d5d:3ee0:8885] has quit [Quit: Quit] 21:58 -!- yzernik [~yzernik@2600:1700:dc40:3dd0:11f0:d5d:3ee0:8885] has joined #bitcoin-core-dev 21:58 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 21:59 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 22:45 -!- mytwocentimes [~mytwocent@104.206.206.83] has quit [Remote host closed the connection] 22:45 -!- mytwocentimes [~mytwocent@104.206.206.83] has joined #bitcoin-core-dev 23:00 -!- phyll1s_work [~phyll1s_w@185.104.184.43] has quit [] 23:19 -!- nandub [~nandub@185.104.184.43] has joined #bitcoin-core-dev 23:19 -!- nandub is now known as Guest71560 23:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:52 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 23:52 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] --- Log closed Sat Apr 18 00:00:55 2020