--- Log opened Sun May 03 00:00:11 2020 00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:46 -!- masteringbtc [2efbc52f@46.251.197.47] has joined #bitcoin-core-dev 01:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 01:36 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 01:37 -!- brakmic_ [brakmic@gateway/vpn/nordvpn/brakmic] has joined #bitcoin-core-dev 01:39 -!- brakmic__ [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 01:40 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Ping timeout: 256 seconds] 01:42 -!- brakmic_ [brakmic@gateway/vpn/nordvpn/brakmic] has quit [Ping timeout: 260 seconds] 02:00 -!- ski1 [~ski@185.204.1.185] has quit [] 02:03 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 02:08 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 02:10 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev 02:13 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 02:21 -!- afb [~afb@195.206.183.79] has joined #bitcoin-core-dev 02:35 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 02:39 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds] 02:47 -!- masteringbtc [2efbc52f@46.251.197.47] has quit [Remote host closed the connection] 02:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 03:29 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 03:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:42 -!- dmkathayat [~quassel@ec2-13-233-97-253.ap-south-1.compute.amazonaws.com] has quit [Ping timeout: 258 seconds] 03:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:44 -!- vasild_ is now known as vasild 03:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:02 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 04:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 04:07 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds] 04:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 04:16 -!- Victor_sueca is now known as Victorsueca 04:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 04:52 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 05:00 -!- afb [~afb@195.206.183.79] has quit [] 05:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 05:21 -!- Nimda3 [~Nimda3@178.162.204.238] has joined #bitcoin-core-dev 05:30 -!- Nimda3 [~Nimda3@178.162.204.238] has quit [Disconnected by services] 05:36 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:38 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 05:43 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 05:52 -!- Nebraskka [~Nebraskka@178.62.130.190] has quit [Quit: Good day, my fellow citizens!~] 05:55 -!- gorthx [~gorthx@141.98.102.235] has joined #bitcoin-core-dev 05:57 < yevaud> luke-jr: objectively, providing a connection to someone incoming who you know is on a different chain is a denial of service attack against them. 05:59 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68ef9523d1bc...ddc0a600b38a 06:00 < bitcoin-git> bitcoin/master 2742c34 Harris: test: add factor option to adjust test timeouts 06:00 < bitcoin-git> bitcoin/master ddc0a60 MarcoFalke: Merge #18617: test: add factor option to adjust test timeouts 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:00 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18617: test: add factor option to adjust test timeouts (master...test-timeouts-with-factor) https://github.com/bitcoin/bitcoin/pull/18617 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 06:14 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Quit: The Lounge - https://thelounge.chat] 06:17 -!- masteringbtc [2efbc55f@46.251.197.95] has joined #bitcoin-core-dev 06:18 -!- sudeep_ [~sudeep@122.171.159.44] has joined #bitcoin-core-dev 06:18 -!- amsudeep [~sudeep@122.171.146.239] has quit [Read error: Network is unreachable] 06:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 06:31 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 06:34 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:36 -!- AnotherHaxker [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has joined #bitcoin-core-dev 06:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 06:39 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 06:41 -!- AnotherHaxker [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has quit [Remote host closed the connection] 06:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 06:44 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 06:50 -!- masteringbtc [2efbc55f@46.251.197.95] has quit [Ping timeout: 245 seconds] 06:56 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:59 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 07:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 07:09 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 07:12 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 256 seconds] 07:13 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 07:15 < luke-jr> yevaud: they're not on another chain in this scenario; it's *providing* a service, not denying one 07:18 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] vasild opened pull request #18857: build: avoid repetitions when enabling warnings in configure.ac (master...avoid_repetitions_in_configure.ac) https://github.com/bitcoin/bitcoin/pull/18857 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:20 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 07:23 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 07:28 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddc0a600b38a...cce034b02800 07:32 < bitcoin-git> bitcoin/master fa8614a MarcoFalke: test: Fix intermittent p2p_segwit issue 07:32 < bitcoin-git> bitcoin/master fab7ee3 MarcoFalke: test: Fix p2p_leak intermittent issue 07:32 < bitcoin-git> bitcoin/master cce034b MarcoFalke: Merge #18839: test: Fix intermittent issues 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18839: test: Fix intermittent issues (master...2004-qaSegwitNoIntermittentFail) https://github.com/bitcoin/bitcoin/pull/18839 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:33 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 07:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:36 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cce034b02800...2e6a16b968a9 07:36 < bitcoin-git> bitcoin/master 489ebfd Andrew Chow: tests: feature_backwards_compatibility.py test downgrade after upgrade 07:36 < bitcoin-git> bitcoin/master 2e6a16b MarcoFalke: Merge #18855: tests: feature_backwards_compatibility.py test downgrade aft... 07:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18855: tests: feature_backwards_compatibility.py test downgrade after upgrade (master...test-backcompat-updowngrade) https://github.com/bitcoin/bitcoin/pull/18855 07:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:42 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:43 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:55 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 08:00 -!- gorthx [~gorthx@141.98.102.235] has quit [] 08:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 08:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 08:08 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:11 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 08:20 -!- jedi1 [~jedi@195.206.169.238] has joined #bitcoin-core-dev 08:20 < elichai2> jonasschnelli: Hi, I'm trying to review #18242, and I don't get something, it looks like you use AAD a lot in relation with chacha(ie encrypting the AAD), why is that? traditionally AAD is Additional Authenticated Data (meaning not encrypted) and also `CHACHA20_POLY1305_AEAD_AAD_LEN = 3` is that because the AAD is always the length which is capped at 24bits? 08:20 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub 08:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:31 -!- brakmic__ [~brakmic@185.183.85.108] has quit [] 08:31 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 08:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 08:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 08:41 < elichai2> I read the BIP again, and maybe I understand it now. you create 2 instances of chacha, `chacha_K1` and `chacha_K2` you encrypt the length of the data with `chacha_K1` and the data with chacha_K2`, but you use the encrypted `chacha_K1` length as the AAD of `chacha_K2`+Poly1305? 08:41 < elichai2> * I read the BIP again, and maybe I understand it now. you create 2 instances of chacha, `chacha_K1` and `chacha_K2` you encrypt the length of the data with `chacha_K1` and the data with `chacha_K2`, but you use the encrypted `chacha_K1` length as the AAD of `chacha_K2`+Poly1305? 08:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 08:46 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 08:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 08:51 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 08:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:21 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 09:25 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 09:28 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:49 < jonasschnelli> elichai2: hi 09:49 < jonasschnelli> the AD is encrypted to keep the package length confidential 09:49 < jonasschnelli> it's based on the openssh chacha20poly1305 protocol 09:49 < jonasschnelli> https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.chacha20poly1305 09:50 < jonasschnelli> and yes the AAD length is always 3 bytes. 09:50 < jonasschnelli> 23bits length plus 1 bit rekey flag 09:51 < jonasschnelli> with encrypted package length, it makes the stream pseudo-random... and it would allow to pad random data (to obfuscate size-based package detection, which is not in the scope of the BIP though) 09:56 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 09:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 09:59 < elichai2> oh, openssh does this whole encrypt the length separately? 10:00 < elichai2> But do we really gain anything by encrypting the length? it will probably be really easy to see anyway 10:03 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 10:03 < elichai2> I haven't realized this is almost 100% openSSH protocol, I thought only their impl was used not the protocol itself, thanks! 10:06 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:18 < jonasschnelli> elichai2: expect the reusing of the AAD keystream and the 3byte length, it's very much then openssh version 10:18 < jonasschnelli> *except 10:19 < elichai2> you mean limiting the length to constant size 3 bytes? 10:19 < jonasschnelli> that and mainly not throwing a way 60 bytes per AAD chacha round 10:30 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 10:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 10:35 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 10:35 -!- davterra [~dulyNoded@2601:603:4f00:63d0:a00:27ff:fed5:b769] has quit [Quit: Leaving] 10:41 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 10:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:00 -!- jedi1 [~jedi@195.206.169.238] has quit [] 11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:20 < bitcoin-git> [bitcoin] practicalswift opened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859 11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:21 -!- paxed1 [~paxed@178.162.204.238] has joined #bitcoin-core-dev 11:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:28 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 11:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 11:42 < vasild> sipa: wrt https://github.com/bitcoin/bitcoin/pull/18843#issuecomment-623158435 -- what would the current inline assembly do on a system that doesn't have that instruction? I guess it will cause SIGILL (illegal instruction) at runtime? 11:43 < sipa> yeah 11:43 < sipa> i would be very surprised that the compiler emits an rdrand instruction anywhere without invoking a corresponding intrinsic, though 11:44 < sipa> but that's specific to rdrand... e.g. the compiler will happily emit sse4 instructions for normal non-intrinsic c code when you compile with -msse4 11:45 < sipa> so in general, you always want to move code that needs certain hardware assumptions to a separate module that gets compiled with those flags, and only invoke its functions after testing at runtime the feature is available 11:46 < vasild> so there is room for improvement wrt the current inline assembly which assumes the instruction is present and if not would crash at runtime 11:47 < vasild> although I guess the instruction is available on all platforms where bitcoin core is being run, otherwise somebody would have reported the crash 11:48 < sipa> the current code is fine 11:49 < sipa> InitHardwareRand checks whether the instruction is available at runtime, and GetRdRand is only called if it reports true in g_rdrand_supported 11:49 < vasild> ah 11:50 < vasild> I was looking at GetRdRand() in isolation 11:50 < sipa> but if we'd compile the entirety of random.cpp with -mrdrnd, the compiler might also emit rdrand instructions in other functions (though i would be surprised if it did) 11:51 < sipa> there are compiler-specific extensions that let you compile just one function with different hardware assumptions, but i'm not sure they exist for all compilers we support 11:52 < vasild> "emit rdrand instructions in other functions" -- I don't get this, which other functions? 11:52 < sipa> literally anything 11:53 < vasild> if you have a function like `int f(int x) { return x * 2; }`? 11:53 < sipa> if you compile a module with -mrdrnd it means the compiler assumes all code in that module will be run on hardware that supports the rdrand instruction 11:53 < vasild> right 11:54 < sipa> as i said, i wouldn't expect a compiler to do that for rdrand... it's a very specific purpose instruction that likely wouldn't be used unless you explicitly invoke it using an intrinsic 11:54 < vasild> hmm, I see your point now 11:54 < sipa> but for other target flags it absolutely will 11:55 < sipa> this was the cause of #18456, btw 11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub 11:55 < sipa> sort of 11:55 < vasild> and even if we do a runtime check before using it, that instruction may be sneaked somewhere else where the code does not do a runtime check 11:55 < sipa> right 11:56 < elichai2> #18456 was even worse imo, because it generated sse instructions in the global initialization function 11:56 < gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub 11:57 < sipa> elichai2: which arguably we told it it was fine to do 11:57 < elichai2> right. but it's also a limitation of C and C++ that you can't always know what will be constantly evaluated and what will be in the global init 11:57 < sipa> you totally can; constexpr keyword 11:58 < sipa> only it doesn't work for vector registers :p 11:58 < vasild> sipa: ok, thanks for the patience with explanations. I catch up slowly, but otoh tend to forget quickly... 11:59 < sipa> np 11:59 < elichai2> hehe yeah, we have constexpr now 12:00 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 12:11 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:12 -!- vasild_ is now known as vasild 12:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:25 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 12:40 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 12:43 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:15 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 13:16 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 13:21 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:49 < bitcoin-git> [bitcoin] practicalswift closed pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:50 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:53 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:56 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 13:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:00 -!- paxed1 [~paxed@178.162.204.238] has quit [] 14:12 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:17 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859 14:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:22 -!- DarTar [~DarTar@195.206.183.79] has joined #bitcoin-core-dev 14:33 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 14:39 -!- davterra [~dulyNoded@172.98.86.80] has joined #bitcoin-core-dev 15:09 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 15:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 15:14 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 15:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:28 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:31 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-dev 15:32 < thomasb06> Is it possible to participate writing python test scripts without installing 200Gb? 15:36 < sipa> sure 15:37 < sipa> you don't need to run mainnet bitcoind to run or develop tests 15:41 < thomasb06> sipa: hey. 15:42 < thomasb06> would you have the link on the website, until now I only found instructions to run a node? 15:43 < sipa> i don't know what instructions you need 15:43 < sipa> you can submit pull requests without running anything 15:44 < thomasb06> well, that would be even better: my disk is 60Gb... 15:44 < sipa> that's no problem 15:44 < sipa> just don't run bitcoind 15:45 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 15:45 < sipa> or you can run it in pruning mode which only needs a few GB 15:45 < sipa> but neither is relevant for the python tests 15:45 < thomasb06> cool... Promised I won't, even in pruning (I'm a student) 15:46 < thomasb06> how can I find what tests are needed? 15:47 < fanquake> thomasb06: If you want to start contributing, look at the "Good first issue" list: https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 15:50 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 15:50 < thomasb06> fanquake: thanks. Any advice? 15:53 < fanquake> thomasb06: read https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md if you haven't already 15:55 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 15:56 < thomasb06> I just started. Is there an issue or a category among those flaged "Good 15:56 < thomasb06> first issue" I should privilege, or I can pick on randomly? 15:59 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds] 16:01 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 16:05 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 16:11 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 272 seconds] 16:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:20 -!- brakmic [~brakmic@185.183.85.108] has quit [] 16:28 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev 16:30 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has joined #bitcoin-core-dev 16:30 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has quit [Client Quit] 16:37 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection] 16:38 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps] 16:53 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev 16:58 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Quit: ERC (IRC client for Emacs 26.3)] 17:00 -!- DarTar [~DarTar@195.206.183.79] has quit [] 17:00 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has joined #bitcoin-core-dev 17:00 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has quit [Client Quit] 17:00 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has joined #bitcoin-core-dev 17:01 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has quit [Client Quit] 17:01 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has joined #bitcoin-core-dev 17:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55] 17:22 -!- b_b1 [~b_b@195.206.169.238] has joined #bitcoin-core-dev 17:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:58 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:00 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 18:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 18:06 -!- davterra [~dulyNoded@172.98.86.80] has quit [Read error: Connection reset by peer] 18:10 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:16 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 18:24 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 18:25 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 18:29 -!- sudeep_ [~sudeep@122.171.159.44] has quit [Ping timeout: 272 seconds] 18:29 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 18:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:42 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:55 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:58 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 19:09 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 19:29 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:56 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:59 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 258 seconds] 20:00 -!- b_b1 [~b_b@195.206.169.238] has quit [] 20:01 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds] 20:21 -!- Wolfy87 [~Wolfy87@217.146.82.122] has joined #bitcoin-core-dev 20:50 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 20:56 -!- commavir [~vir@23.226.237.192] has quit [Excess Flood] 20:56 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev 20:58 -!- jarthur [~jarthur@2605:6000:1019:4971:4c57:5a5d:398c:db0f] has quit [] 21:07 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 21:11 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 21:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:22 -!- vasild_ is now known as vasild 21:39 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 21:47 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 265 seconds] 21:53 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 21:54 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 21:54 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 21:55 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 22:04 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 22:05 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 22:05 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 22:08 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 22:10 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 22:12 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 22:15 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 22:20 -!- ricky35 [2d98b697@45.152.182.151] has joined #bitcoin-core-dev 22:22 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 258 seconds] 22:23 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 22:30 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 22:58 -!- Homelander [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has joined #bitcoin-core-dev 22:59 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 23:00 -!- Wolfy87 [~Wolfy87@217.146.82.122] has quit [] 23:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:04 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] 23:04 -!- ricky35 [2d98b697@45.152.182.151] has quit [Remote host closed the connection] 23:21 -!- hack_bot [~hack_bot@195.206.169.238] has joined #bitcoin-core-dev 23:36 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #bitcoin-core-dev 23:41 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 240 seconds] --- Log closed Mon May 04 00:00:10 2020