--- Log opened Tue May 05 00:00:11 2020 00:00 < achow101> one of my concerns is whether we should even try to do this for descriptor wallets now 00:00 < jonasschnelli> the code needs to be ready to support both formats 00:00 < achow101> or if it's too late 00:00 < jonasschnelli> since you dont want to abandon old wallets 00:01 < sipa> achow101: you mean *only* for descriptor wallets? 00:01 < achow101> jonasschnelli: my idea was to make it a descriptor wallets only thing 00:01 < jonasschnelli> yeah. that would be an ideal time 00:01 < sipa> i think that's crazy 00:01 < achow101> the reasoning being that since descriptor wallets is a wholly new thing, might be a good time to also bring in a new disk format 00:02 -!- per [~per@gateway/tor-sasl/wsm] has quit [Ping timeout: 240 seconds] 00:02 < sipa> if will complicate maintaining support for legacy wallets, by duplicating all storage level stuff work now for bdb and whatever is chosen 00:02 < sipa> imo it's something to do completely orthogonally 00:02 < jonasschnelli> sipa: but you have to support both storage backends anyways. right? 00:02 < achow101> sipa: how so? 00:02 < achow101> the thought was that legacy wallets would only use bdb, and descriptor wallets only the new thing 00:03 < achow101> then whenver we get around to killing legacy wallets, bdb goes with it 00:03 < sipa> achow101: yeah, i think that's crazy 00:03 < sipa> you'll need two walletdb 00:03 < jonasschnelli> If an storage upgrade is required for legacy wallets (which would be a no-go IMO), it could go over bitcoin-wallet (where we still need both storage backend in the code) 00:03 < sipa> you'll need two walletdb.cpp's 00:03 < jonasschnelli> yes. 00:03 < sipa> and you'll duplicate work for all improvements that aren't specific to descriptor wallets 00:03 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 256 seconds] 00:03 < jonasschnelli> I once tried to make the storage backend flexible, changable,... not very easy 00:04 < achow101> but you need that already 00:04 < sipa> and it seems completely unnecessary 00:04 < sipa> as long as what is exposed is a key-value store, the choice of storage format can be independent of what the keys in it meam 00:04 < sipa> and sure, descriptor walleta would by default by the new thing 00:05 < jonasschnelli> yes. it needs a new layers. 00:05 < sipa> and.old wallets would generally be the old thing 00:05 < achow101> sipa: I think you could still get it to be shared even with different db backends 00:05 -!- Anduck_ [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 00:05 < sipa> achow101: yes, if the ly're orthogonal 00:05 < achow101> i get that the separation doesn't make sense technically. but i'm also trying to make it a logical separation to 00:06 < sipa> i think you shouldn't try to make this a descriptor-wallet-only thing 00:06 < sipa> that risks huge compatibility problems if it doesn't get in by 0.21 00:07 < achow101> and that's the other problem 00:08 < sipa> and there's no need, i think - you'll want to abstract out the storage layer, amlnd if that's done cleanly, there should be no reason why you couldn't supoort a legacy new-format wallet or a descriptor bdb wallet 00:08 < sipa> (perhaps you wouldn't want to support creating such things through RPC or whatever - but i think internally you want things separated that way) 00:09 < achow101> well yeah, that was kind of the idea. that in theory you could write a legacy wallet to the new storage, but we just wouldn't allow it 00:09 < sipa> right, but the decision on what to allow can come late 00:09 -!- Netsplit *.net <-> *.split quits: votesmith, TheHoliestRoger, wraithm, mol, jarthur, frogar, Anduck, aj, justinmoon, tripleslash, (+2 more, use /NETSPLIT to show all of them) 00:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 00:10 < sipa> if things are in by 0.21 you could indeed say descriptor wallets only in the new format 00:10 < achow101> i suppose so 00:10 < sipa> but i think you'll want support for legacy new-format wallets in any caze too 00:10 < sipa> eventually someone may want to run a convert tool to convert a bdb wallet to a new format wallet 00:11 < sipa> if bdb gets dropped 00:11 < sipa> but that process can't convert a legacy wallet into a descriptor wallet 00:11 < achow101> right 00:12 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 00:13 < jonasschnelli> I think the bdb support can't be drop in near and longterm future. 00:14 < jonasschnelli> If an "tool" (like bitcoin-wallet) would allow the migration from bdb-storage to new-storage, we still would require the bdb support 00:14 < achow101> so bdb's file format isn't that hard to parse so it wouldn't be all that hard to move to new storage 00:14 < jonasschnelli> an it would be foolish to tell people to use a third party tool for that 00:14 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 00:15 < jonasschnelli> achow101: you mean a simple record by record migration... yeah. maybe. Still would required the bdb dependency... and some parts of our bdb db.cpp code 00:15 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 00:15 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 00:15 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 00:15 -!- justinmoon [~quassel@157.245.122.126] has joined #bitcoin-core-dev 00:15 -!- votesmith [~votesmith@237.ip-217-182-75.eu] has joined #bitcoin-core-dev 00:15 -!- frogar [~frogar_@w.x.y.z.mooo.com] has joined #bitcoin-core-dev 00:15 -!- roasbeef [~root@104.131.26.124] has joined #bitcoin-core-dev 00:15 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 00:15 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:15 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 00:15 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 00:16 < jonasschnelli> which makes me think supporting both storage backends in the long term future is easier and unavoidable 00:16 < achow101> jonasschnelli: #18836 has a pure python deserializer for bdb files. That with python3's sqlite lib should make a python script that can do a record for record conversion in <200 LOC 00:16 < gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub 00:17 < achow101> (the python deserializer is to inspect wallet files to make sure that records are being updated by upgradedwallet) 00:17 < sipa> achow101: wow. 00:18 < jonasschnelli> achow101: I think only python scripts is not an adequate option to a must-migrate approach 00:18 < sipa> i'm surprised and impressed that it's so simple 00:18 < jonasschnelli> Think of the novice gui only windows users 00:18 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 00:18 < achow101> jonasschnelli: right. my point is that it wouldn't be that hard to do add a function within bitcoind itself and it doesn't require bdb 00:18 < jonasschnelli> also,.. I think it would be non-ideal to tell people to use third party libraries (python stack) to migrate their most crucial database 00:19 < jonasschnelli> achow101: ah. I see. Yes. Thats a good point. 00:19 < jonasschnelli> Just; we where really careful to not force walletupgrade for things like HD, etc. Then we suddenly force people to upgrade due to a storage engine change? 00:20 < jonasschnelli> I'd rather support both storage backends long term 00:21 < achow101> same. I think supporting both would be required for quite a while. then the super long term solution is an upgrade with a minimal tool/function 00:21 < jonasschnelli> achow101: yes. 00:21 < sipa> that's starting to look much more reasonable now 00:21 < sipa> given how simple bdb is to read 00:21 < sipa> not short or medium term 00:21 < sipa> but perhaps long term 00:22 < achow101> sipa: I was surprised too. Unfortunately none of this was documented anywhere and it required rooting around in the source code for a while. at least all the things were in structs in one file in their source tarball 00:22 < jonasschnelli> At one point, bdb depdency could be optional / disabled by default, leaving only the internal conversion tool. 00:22 < jonasschnelli> later, the bdb dependency will be removed and users are forced to upgrade (long long term) 00:23 < achow101> sipa: part of the simplicity is also that we don't use advanced feature of bdb so the page layout is also very predictable 00:23 < sipa> right 00:24 < sipa> sqlite3 is very well defined apparently; all releases back 3.0 can read/write those filss 00:25 < sipa> ah, not perfectly forward compatible :( 00:26 < sipa> i also like that it's just a single file 00:26 < jonasschnelli> sqlite3 would have some nice benefits for large (many tx) wallets allowing some nice queries 00:26 < jonasschnelli> Though I wonder how much of a concern it will be in 10 years and if we would not end up at the same point as we are now with bdb 00:27 * midnight would cheer if bdb went away 00:27 < achow101> i think that bdb isn't that bad of a choice for a wallet file format. my main gripe is that we're using a version that's now more than 10 years old. and also oracle messing with the licensing 00:28 < sipa> achow101: my... experience is different 00:29 < achow101> i'm sure it is :) I know there were a lot of consistency and corruption issues before, but I haven't seen a lot of those recently 00:29 < jonasschnelli> achow101: Yes. And how big would be the risk of repeating that when using another library like sqlite? 00:30 < sipa> my impression is that bdb was origonally designed for large multi-process databases, where there was a dedicated and competent database mantainer who would manually perform tweaking, and upgrades 00:30 < sipa> rather than as an application storage format 00:30 < jonasschnelli> *just send me your wallets, i'm a competent database maintainer.* 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:31 < bitcoin-git> [bitcoin] fanquake opened pull request #18882: build: fix -Wformat-security check when compiling with GCC (master...fix_gcc_wformat_security) https://github.com/bitcoin/bitcoin/pull/18882 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:32 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Read error: Connection reset by peer] 00:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 00:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:33 < achow101> jonasschnelli: with sqlite itself, I would expect there to be few to no compatibility or licensing issues. For consistency and corruption, i'd trust it more than a homegrown format tbh 00:33 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev 00:33 < jonasschnelli> Maybe. Yes. 00:33 < sipa> i believe sqlite is very well tested 00:34 < jonasschnelli> Also,.. it would allow better handling of larger wallets 00:34 < sipa> how so? 00:34 < jonasschnelli> (without more homegrown code) 00:34 < jonasschnelli> A decent option to query stuff if we use not just k/v storage 00:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:35 < jonasschnelli> right now,.. all txns are in memory... assume you just want to show the first page of txns (the most recent 10) 00:35 < sipa> i think that's just asking for problems again 00:36 < sipa> if we want a chance of.doing this, it can't be tied to any other changes 00:36 < sipa> and should be just a straight change from one storage format to another (i.e. remain a k/v store, with the same keys and the same meaning) 00:37 < sipa> maybe later (much later...) you could start using other features, but i'm unconvinced that's even worth it 00:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:52 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [] 00:52 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 01:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:19 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 01:21 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 01:21 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 01:21 -!- molz_ [~mol@unaffiliated/molly] has quit [Remote host closed the connection] 01:21 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 01:24 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 01:28 -!- tryphe_ is now known as tryphe 01:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:32 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:47 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:54 < bitcoin-git> [bitcoin] hebasto opened pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883 01:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:56 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 01:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 02:00 -!- silvers- [~silvers-@141.98.102.235] has quit [] 02:05 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-xurpobhjeosdspnh] has quit [Quit: Connection closed for inactivity] 02:21 -!- ironmarx [~ironmarx@184.75.221.195] has joined #bitcoin-core-dev 02:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 02:27 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 02:28 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:17 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:17 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 03:17 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 03:17 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 03:17 -!- promag___ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:20 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 03:22 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:23 -!- devindia [9d3358f8@157.51.88.248] has joined #bitcoin-core-dev 03:24 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 03:27 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 03:28 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 03:29 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 264 seconds] 03:29 -!- cryptapus_ [~cryptapus@75.19.27.26] has joined #bitcoin-core-dev 03:29 -!- cryptapus_ [~cryptapus@75.19.27.26] has quit [Changing host] 03:29 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 03:29 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 03:29 -!- rockhouse1 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 03:29 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 03:29 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 03:30 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 246 seconds] 03:30 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 246 seconds] 03:30 -!- rockhouse1 is now known as rockhouse 03:30 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 264 seconds] 03:32 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 03:55 -!- jonatack_ [~jon@37.164.35.89] has joined #bitcoin-core-dev 03:55 -!- frogar [~frogar_@w.x.y.z.mooo.com] has quit [Ping timeout: 256 seconds] 03:58 -!- frogar [~frogar_@w.x.y.z.mooo.com] has joined #bitcoin-core-dev 03:58 -!- jonatack [~jon@37.167.8.190] has quit [Ping timeout: 260 seconds] 04:00 -!- cryptapus_ is now known as cryptapus 04:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:04 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: Connection reset by peer] 04:05 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 04:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 04:13 -!- frogar [~frogar_@w.x.y.z.mooo.com] has quit [Ping timeout: 246 seconds] 04:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885 04:30 -!- frogar [~frogar_@w.x.y.z.mooo.com] has joined #bitcoin-core-dev 04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:36 -!- devindia [9d3358f8@157.51.88.248] has quit [Remote host closed the connection] 04:38 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Ping timeout: 246 seconds] 04:42 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 05:00 -!- ironmarx [~ironmarx@184.75.221.195] has quit [] 05:04 -!- promag__ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 05:12 -!- Homelander [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has joined #bitcoin-core-dev 05:33 -!- Highway62 [~Thunderbi@104.223.94.42] has joined #bitcoin-core-dev 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:33 < bitcoin-git> [bitcoin] luke-jr closed pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:33 -!- molakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has joined #bitcoin-core-dev 05:33 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.8] 05:34 -!- Highway62 [~Thunderbi@104.223.94.42] has quit [Remote host closed the connection] 05:34 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 260 seconds] 05:34 -!- Highway61 [~Thunderbi@104.223.94.42] has joined #bitcoin-core-dev 05:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:42 -!- Homelander [7ca9cba8@124-169-203-168.dyn.iinet.net.au] has quit [Remote host closed the connection] 05:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:51 < bitcoin-git> [bitcoin] vasild opened pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:55 -!- josef641 [~josef64@178.162.204.238] has joined #bitcoin-core-dev 06:05 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 06:35 -!- jonatack_ [~jon@37.164.35.89] has quit [Quit: jonatack_] 06:35 -!- jonatack [~jon@134.19.179.147] has joined #bitcoin-core-dev 06:51 -!- promag___ is now known as promag 06:51 < promag> sipa: mind taking a look at #18863? 06:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:54 < bitcoin-git> [bitcoin] promag closed pull request #18246: wip: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ec79b5f86b22...52ce396b2a47 07:08 < bitcoin-git> bitcoin/master 708e3c7 fanquake: valgrind: remove rest_blockhash_by_height suppression 07:08 < bitcoin-git> bitcoin/master d7120f7 fanquake: valgrind : remove duplicate BCLog::Logger suppression 07:08 < bitcoin-git> bitcoin/master 52ce396 MarcoFalke: Merge #18879: valgrind: remove outdated suppressions 07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:08 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879 07:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:10 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:10 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev 07:15 -!- Daisy5Parker [~Daisy5Par@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 07:22 -!- Daisy5Parker [~Daisy5Par@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 246 seconds] 07:26 -!- grubles [~blockhash@unaffiliated/grubles] has quit [Quit: brb] 07:26 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Remote host closed the connection] 07:31 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 07:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 07:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52ce396b2a47...fbd522721cb8 07:42 < bitcoin-git> bitcoin/master fa13090 MarcoFalke: contrib: Remove optimize-pngs.py script, which lives in the maintainer rep... 07:42 < bitcoin-git> bitcoin/master fbd5227 MarcoFalke: Merge #18885: contrib: Move optimize-pngs.py script to the maintainer repo... 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885 07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection] 08:00 -!- josef641 [~josef64@178.162.204.238] has quit [] 08:02 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:24ba:114a:98c2:e556] has joined #bitcoin-core-dev 08:21 -!- geek00l [~geek00l@185.204.1.185] has joined #bitcoin-core-dev 08:25 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 08:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 08:27 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer] 08:29 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888 08:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:43 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 08:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:51 -!- Daren32Bruen [~Daren32Br@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 08:53 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:24ba:114a:98c2:e556] has quit [Ping timeout: 272 seconds] 08:57 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 09:02 -!- Daren32Bruen [~Daren32Br@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection] 09:03 -!- Jalon40Moore [~Jalon40Mo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 09:09 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:61cf:f8b9:99ca:98fa] has joined #bitcoin-core-dev 09:10 -!- Jalon40Moore [~Jalon40Mo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 09:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:29 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev 09:43 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 09:55 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:59 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 10:05 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:08 -!- geek00l [~geek00l@185.204.1.185] has quit [Ping timeout: 264 seconds] 10:11 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:30 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 10:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:50 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 10:54 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 10:57 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:00 < bitcoin-git> [bitcoin] robot-visions opened pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890 11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:19 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 11:21 -!- dougvann [~dougvann@141.98.102.235] has joined #bitcoin-core-dev 11:32 -!- Technoprenerd [~Technopre@212.182.169.185] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 11:34 -!- Technoprenerd [~Technopre@212.182.169.185] has joined #bitcoin-core-dev 11:43 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Quit: Leaving] 11:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 12:20 -!- lightlike [~lightlike@p200300C7EF1BD600101E879D4F25D86D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 12:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:34 -!- u0_a180 [~u0_a180@2409:4071:2093:85f:b75c:4ec:ece8:c02a] has joined #bitcoin-core-dev 12:35 -!- u0_a180 [~u0_a180@2409:4071:2093:85f:b75c:4ec:ece8:c02a] has quit [Remote host closed the connection] 13:01 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:61cf:f8b9:99ca:98fa] has quit [Ping timeout: 240 seconds] 13:06 < luke-jr> anyone ever seen this before? /usr/include/db4.8/db_cxx.h:59:10: fatal error: iostream.h: No such file or directory 13:07 -!- robot-visions [~robot-vis@172.92.4.53] has joined #bitcoin-core-dev 13:09 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 244 seconds] 13:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 13:16 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 13:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:22 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 13:30 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 13:32 -!- Highway62 [~Thunderbi@192.252.213.82] has joined #bitcoin-core-dev 13:32 -!- Highway61 [~Thunderbi@104.223.94.42] has quit [Ping timeout: 264 seconds] 13:32 -!- Highway62 is now known as Highway61 13:32 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 13:33 -!- Highway61 [~Thunderbi@192.252.213.82] has quit [Remote host closed the connection] 13:34 -!- Highway61 [~Thunderbi@192.252.213.82] has joined #bitcoin-core-dev 13:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 13:36 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 13:37 < jonatack> luke-jr: i may have seen that once or twice... 13:38 < luke-jr> hmm, looks like bdb got installed without C++ support, yet still installs the header :x 13:38 < jonatack> testing #18870 rn with bdb 5.3 13:38 < gribble> https://github.com/bitcoin/bitcoin/issues/18870 | build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb by achow101 · Pull Request #18870 · bitcoin/bitcoin · GitHub 14:00 -!- dougvann [~dougvann@141.98.102.235] has quit [] 14:01 -!- roconnor [~roconnor@host-45-58-197-21.dyn.295.ca] has joined #bitcoin-core-dev 14:08 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-hexqobpuhyxefuqe] has quit [Quit: Connection closed for inactivity] 14:18 -!- nielsonm [~nielsonm@84.39.117.57] has joined #bitcoin-core-dev 14:21 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 264 seconds] 14:29 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds] 14:32 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 14:33 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 14:34 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 14:52 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 15:03 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:08 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:10 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 15:13 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:18 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:20 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:45 -!- go11111111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 15:48 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 240 seconds] 15:51 -!- dfmb [0252ea95@bl21-234-149.dsl.telepac.pt] has joined #bitcoin-core-dev 15:53 -!- brakmic [~brakmic@185.183.85.108] has quit [] 15:54 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 15:54 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:56 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 16:00 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:00 -!- Anduck_ is now known as Anduck 16:00 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:05 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 16:10 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:21 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:26 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:27 < bitcoin-git> [bitcoin] promag opened pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894 16:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:28 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 16:29 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 256 seconds] 16:29 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:31 < bitcoin-git> [bitcoin] promag closed pull request #17457: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725) https://github.com/bitcoin/bitcoin/pull/17457 16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:31 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 16:34 -!- molakala [~sumanth.b@2601:192:4701:87f0:14c3:3458:88a7:2e1d] has quit [Ping timeout: 260 seconds] 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:37 < bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fbd522721cb8...60091d20f9bb 16:37 < bitcoin-git> bitcoin/master 2b9cba2 Russell Yanofsky: Remove CWalletTx merging logic from AddToWallet 16:37 < bitcoin-git> bitcoin/master bd2fbc7 Russell Yanofsky: Get rid of unneeded CWalletTx::Init parameter 16:37 < bitcoin-git> bitcoin/master 65b9d8f Russell Yanofsky: Avoid copying CWalletTx in LoadToWallet 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:39 < bitcoin-git> [bitcoin] meshcollider merged pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381 16:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:42 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:46 -!- surja795_ [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 16:46 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:47 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 16:48 -!- lightlike [~lightlike@p200300C7EF1BD600101E879D4F25D86D.dip0.t-ipconnect.de] has quit [Quit: Leaving] 16:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:53 -!- jonatack [~jon@134.19.179.147] has quit [Ping timeout: 264 seconds] 16:55 -!- jonatack [~jon@37.164.75.174] has joined #bitcoin-core-dev 17:00 -!- nielsonm [~nielsonm@84.39.117.57] has quit [] 17:06 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:18 -!- dfmb [0252ea95@bl21-234-149.dsl.telepac.pt] has quit [Remote host closed the connection] 17:21 -!- creffett|irssi [~creffett|@84.39.117.57] has joined #bitcoin-core-dev 17:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:38 < bitcoin-git> [bitcoin] gzhao408 opened pull request #18895: [wip] unbroadcast followups (master...unbroadcast-followup) https://github.com/bitcoin/bitcoin/pull/18895 17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:39 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:53 < meshcollider> ryanofsky thanks for being so proactive with rebasing that PR for 4 years now, good to have the oldest open wallet PR in now! 17:54 < ryanofsky> heh, I don't mind rebasing, but I need to get better at asking for reviews :) 18:03 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 18:05 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 18:30 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 18:57 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 18:57 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:59 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 18:59 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 19:04 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 19:09 -!- popyer [25789a62@37.120.154.98] has joined #bitcoin-core-dev 19:22 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 19:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 19:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 19:37 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:40 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 19:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 19:45 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 19:49 -!- popyer [25789a62@37.120.154.98] has quit [Remote host closed the connection] 19:53 -!- Highway61 [~Thunderbi@192.252.213.82] has quit [Ping timeout: 240 seconds] 20:00 -!- creffett|irssi [~creffett|@84.39.117.57] has quit [] 20:21 -!- jtk1 [~jtk@185.204.1.185] has joined #bitcoin-core-dev 20:23 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 20:23 -!- davterra [~dulyNoded@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:49 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-mmmwgyqypouwdpgr] has joined #bitcoin-core-dev 20:51 < jnewbery> #proposedmeetingtopic removing valgrind from travis PR builds 20:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:19 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 256 seconds] 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:24 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:27 -!- Dianalondon [b280dcf7@gateway/web/cgi-irc/kiwiirc.com/ip.178.128.220.247] has joined #bitcoin-core-dev 21:29 -!- Dianalondon [b280dcf7@gateway/web/cgi-irc/kiwiirc.com/ip.178.128.220.247] has quit [Client Quit] 21:34 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 21:34 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 21:37 -!- go11111111111 [~go1111111@104.156.98.86] has quit [Ping timeout: 264 seconds] 21:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 22:00 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection] 22:01 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:05 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:14 < bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/60091d20f9bb...d96fdc2a396f 22:14 < bitcoin-git> bitcoin/master 395c113 Carl Dong: gitian: Limit sourced script to just assignments 22:14 < bitcoin-git> bitcoin/master f5a6ac4 Carl Dong: guix: Make source tarball using git-archive 22:14 < bitcoin-git> bitcoin/master 1470160 Carl Dong: guix: Expose GIT_COMMON_DIR in container as readonly 22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:14 < bitcoin-git> [bitcoin] fanquake merged pull request #18741: guix: Make source tarball using git-archive (master...2020-04-sync-guix) https://github.com/bitcoin/bitcoin/pull/18741 22:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:16 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:21 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 22:29 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has joined #bitcoin-core-dev 22:44 -!- brakmic [~brakmic@ip-176-198-41-116.hsi05.unitymediagroup.de] has quit [Remote host closed the connection] 22:44 -!- brakmic [~brakmic@185.183.85.108] has joined #bitcoin-core-dev 22:52 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev 22:56 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 22:58 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 260 seconds] 22:59 -!- Highway61 [~Thunderbi@192.252.213.82] has joined #bitcoin-core-dev 23:00 -!- jtk1 [~jtk@185.204.1.185] has quit [] 23:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:03 < bitcoin-git> [bitcoin] hebasto opened pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896 23:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:15 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds] 23:21 -!- Kampala [~Kampala@139.28.218.198] has joined #bitcoin-core-dev 23:36 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 23:39 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 23:48 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 258 seconds] 23:52 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev --- Log closed Wed May 06 00:00:14 2020