--- Log opened Thu May 14 00:00:20 2020
00:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds]
00:16 -!- nubescaeli [~10402C85B@95.245.163.112] has quit [Remote host closed the connection]
00:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
00:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
00:54 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev
01:00 -!- Cory [~Cory@071-013-023-252.res.spectrum.com] has quit [Changing host]
01:00 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
01:13 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:14 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-vraowspxdppwvmxy] has quit [Quit: Connection closed for inactivity]
01:17 -!- tmoc [~textual@c-73-41-135-128.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:43 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
01:43 < goatpig> hi
01:43 < goatpig> would a transaction with no outputs be valid?
02:00 -!- OneFixt [~OneFixt@139.28.218.198] has quit []
02:00 < aj> goatpig: https://github.com/bitcoin/bitcoin/blob/master/src/consensus/tx_check.cpp#L15
02:00 < goatpig> thanks
02:03 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
02:05 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev
02:15 -!- desperad0 [7ac73ee0@122-199-62-224.ip4.superloop.com] has quit [Remote host closed the connection]
02:17 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev
02:18 -!- tty11 [~tty1@178.162.209.171] has joined #bitcoin-core-dev
02:21 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-nlshvcdteqhevlfy] has joined #bitcoin-core-dev
02:25 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
02:25 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
02:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:27 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:56 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
02:58 -!- milieu__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
02:58 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has quit [Ping timeout: 240 seconds]
03:00 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
03:01 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
03:19 -!- jarthur [~jarthur@2605:6000:1019:4971:80b1:4d3a:6e1f:4635] has quit [Ping timeout: 240 seconds]
03:19 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection]
03:22 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
03:32 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
03:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
03:39 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
03:44 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds]
03:54 -!- milieu__ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
03:55 -!- milieu__ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
04:04 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
04:24 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-nlshvcdteqhevlfy] has quit [Quit: Connection closed for inactivity]
04:30 -!- Izl [~Izl@unaffiliated/aru01] has joined #bitcoin-core-dev
04:34 < theStack> has anyone ever used the functional test framework to interact with an already running full node? for some (performance) tests it would make sense to use the mainnet i think
04:42 < fjahr> theStack: have you seen the TestShell class from James Chiang? It is used in the jupyter notebooks for the optech Taproot course, that might be helpful for you.
04:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:42 < fjahr> https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_shell.py
04:42 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer]
04:44 < theStack> fjahr: thanks for the hint, will take a look at it!
04:44 < fjahr> I am not sure about the already running part though. Should probably work if you just change the pid? But I have not tried it.
04:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds]
04:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
04:57 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
04:58 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 258 seconds]
05:00 -!- tty11 [~tty1@178.162.209.171] has quit []
05:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
05:12 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds]
05:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
05:19 -!- gonemad3 [~gonemad3@185.204.1.185] has joined #bitcoin-core-dev
05:20 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
05:20 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
05:20 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
05:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:31 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
05:32 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has joined #bitcoin-core-dev
05:33 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
05:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
05:36 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 265 seconds]
05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:38 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:39 < fanquake> promag: can you check the coin control backports in #18973
05:39 < gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:41 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/04c09553d898...b9c504cbc4ba
05:41 < bitcoin-git> bitcoin/master fab6d06 MarcoFalke: test: Add unregister_validation_interface_race test
05:41 < bitcoin-git> bitcoin/master fa770ce MarcoFalke: validationinterface: Rework documentation, Rename pwalletIn to callbacks
05:41 < bitcoin-git> bitcoin/master fa5ceb2 MarcoFalke: test: Remove UninterruptibleSleep from test and replace it by SyncWithVali...
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:41 < bitcoin-git> [bitcoin] fanquake merged pull request #18742: miner: Avoid stack-use-after-return in validationinterface (master...2004-minerNoCrash) https://github.com/bitcoin/bitcoin/pull/18742
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
05:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
05:43 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev
05:43 < theStack> fjahr: the interesting part for me would be that it doesn't start a new chain from scratch; if i need 100000s of blocks for performance tests starting a new regtest chain is not an option
05:44 < theStack> creating a TestNode() instance with right parameters could maybe work
05:45 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:46 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving]
05:48 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
05:48 < jnewbery> theStack: I made some modifications to test_shell to connect to a running full node: https://github.com/jnewbery/bitcoin/tree/node-shell YMMV
05:49 < jnewbery> were you planning to do some perf testing for 18960?
05:52 < fanquake> MarcoFalke: is there anything obvious to backport into the 0.20 branch to fix the test failures in 18973. Looks like it's mostly in the valgrind builds
05:53 < theStack> jnewbery: sounds like exactly what i need, will take a look. thanks!
05:53 < jnewbery> fanquake: #18899 removes the valgrind build from travis because it was timing out jobs
05:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18899 | travis: Remove valgrind by MarcoFalke · Pull Request #18899 · bitcoin/bitcoin · GitHub
05:54 < theStack> jnewbery: yes indeed i was planning to repeatedly fetch the bip 157 checkpoint headers, comparing how long it takes in master and 18960 branches
05:55 < theStack> (maybe also compare it with the original proposed solutions by jimpo)
05:55 < fanquake> jnewbery: guess that might be worth backporting as  well then
05:56 < jnewbery> theStack: great. Thanks! The first time you send a getcfcheckpt, it's reading the values from disk, so it should be slower than the second and subsequent requests
05:57 < jnewbery> fanquake: as long as it's not hiding and actual bugs that need to be backported. https://travis-ci.org/github/bitcoin/bitcoin/builds/686857580 do actually look like actual test failures rather than timeouts.
05:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:11 < fanquake> jnewbery: if you've got test backport suggestions I'm all ears. I see some process_message related in the fuzzer, which I assume we've fixed.
06:13 < fanquake> I'm going to untag #18287 for 0.20.0. Only myself and sipsorcery have tested it, and neither of us could verify that the change is fixing the actual problem. The patch does fix libevents getaddrinfo detection, but Core still doesn't behave as expected; so I think this needs further testing, and shouldn't be bundled in last minute.
06:13 < gribble> https://github.com/bitcoin/bitcoin/issues/18287 | depends: Patch libevent build to fix IPv6 -rpcbind on Windows by luke-jr · Pull Request #18287 · bitcoin/bitcoin · GitHub
06:14 < theStack> jnewbery: do you think that is also true for the version without the cache implementation (i.e. master branch)? i don't know if BDB does caching internally (or maybe even the OS?), but there must be something as some people have expressed their doubt if the cache implementation is really improving anything
06:14 < theStack> but anyways, i will hopefully find out soon through the benchmarks :)
06:19 -!- davterra [~dulyNoded@2601:603:4f00:63d0::5] has joined #bitcoin-core-dev
06:28 < jnewbery> theStack: perhaps. It's worth testing.
06:29 < jnewbery> (the block filter index uses leveldb, not bdb. bdb is only used in the wallet)
06:29 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev
06:44 < jnewbery> fanquake: looks like you'll need #18757 to avoid those false fuzzing failures
06:44 < gribble> https://github.com/bitcoin/bitcoin/issues/18757 | test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer by practicalswift · Pull Request #18757 · bitcoin/bitcoin · GitHub
06:53 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
07:07 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
07:09 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection]
07:14 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev
07:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:21 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev
07:29 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 272 seconds]
07:31 -!- emilengler [~emilengle@stratum0/entity/emilengler] has joined #bitcoin-core-dev
07:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
07:33 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:33 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:35 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
07:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
07:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
07:46 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
07:48 < vasild> ResolveSubNet("::/0").Match(ResolveIP("1.2.3.4")) -- is true
07:48 < vasild> ResolveSubNet("::AAAA:0:0/80").Match(ResolveIP("1.2.3.4")) -- is true
07:49 < vasild> but
07:49 < vasild> ResolveSubNet("::FFFF:0:0/96").Match(ResolveIP("1.2.3.4")) -- is false
07:49 < vasild> is this a bug?
07:51 < vasild> I think it is strange to match IPv4 addresses as belonging to some IPv6 network, so IMO all should be false. But if I accept that we should, for some reason, match IPv4 addresses as belonging to some IPv6 networks, then also the last one should be true.
07:53 < vasild> It is not true because "::FFFF:0:0" is interpreted as an IPv4 address (0.0.0.0) and the netmask /96 bricks it. It is the same as "0.0.0.0/96".
07:54 < wumpus> it's somewhat strange, but it's a by-effect of IPv4 addresses have always been encoded as a kind of IPv6 address in bitcoin
07:55 < wumpus> not sure this should affect anything in practice
07:56 < vasild> What about stopping to accept IPv4 as IPv6 addresses? That is - all of the above return false?
07:57 < vasild> Sorry, "stopping to accept IPv4 as belonging to some IPv6 networks"
07:59 < vasild> I am modifying this code wrt ADDRv2 and the new code would return false for all of the above 3 tests. So I wonder if this change in behavior would be ok. In order to mimic the current (strange) behavor a few twists and tweaks would have to be made to the new code, making it less straight forward and a bit more difficult to review.
08:00 -!- gonemad3 [~gonemad3@185.204.1.185] has quit []
08:11 < vasild> I will go for "no change in behavior" (+some twists in the patch). If it turns out that we don't need to accept IPv4 as part of IPv6 networks (e.g. `::/0`), then the patch can be simplified.
08:16 -!- maxfragg1 [~maxfragg@217.138.197.102] has joined #bitcoin-core-dev
08:17 < wumpus> I think that's fine, I don't think it'll affect anything in practice
08:17 < wumpus> there's no reason to do mixed IPv6 IPv4 subnet matching
08:18 < wumpus> so having it always return false if someone tries seems ok to me
08:19 -!- Izl [~Izl@unaffiliated/aru01] has quit [Read error: Connection reset by peer]
08:19 < vasild> ah, excellent!
08:23 -!- Brenna40Balistre [~Brenna40B@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
08:24 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
08:26 -!- Brenna40Balistre [~Brenna40B@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
08:27 -!- Kelsi26Mitchell [~Kelsi26Mi@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
08:28 -!- Kelsi26Mitchell [~Kelsi26Mi@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
08:29 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
08:29 -!- Leonie66Hegmann [~Leonie66H@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
08:29 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
08:32 -!- russo [~russo@190-78-205-162.dyn.dsl.cantv.net] has joined #bitcoin-core-dev
08:33 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
08:34 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
08:35 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
08:39 -!- brianhoffman [~brianhoff@pool-96-240-138-69.washdc.fios.verizon.net] has joined #bitcoin-core-dev
08:43 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:43 -!- Leonie66Hegmann [~Leonie66H@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
08:44 < Pavlenex> Hello. I've asked before but got no reply. Serbian translation for 0.20 is ready, it was translated from scratch basically as the language never got much translators. However the language does not have a coordinator or reviewer so it can't be pushed as complete. Who is in charge of Transifex that can provide me with an access so we can proceed? Thanks.
08:53 < wumpus> Pavlenex: I should be able to set someone as coordinator
08:54 < Pavlenex> wumpus: Hey! https://www.transifex.com/user/profile/nedved/ is my transifex username. However if you want to set somebody else from that team instead, it's fine as long as we can proceed with a review.
08:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
08:56 < Pavlenex> If I can suggest alternative member that would be  casperBGD, he continued on my initial efforts and completed the translations. Thanks in advance.
08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:56 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/5747c4ca1bf8...7d87ba0e0227
08:56 < bitcoin-git> bitcoin/0.20 7d87ba0 MarcoFalke: travis: Remove valgrind
08:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:57 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/7d87ba0e0227...aa7c6858e6e4
08:57 < bitcoin-git> bitcoin/0.20 aa7c685 MarcoFalke: travis: Remove s390x
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:57 < wumpus> Pavlenex: okay! let me see
09:01 < wumpus> Pavlenex: I added you as coordinator for all the Serbian languages, I think you should be able to add other reviewers now
09:02 < Pavlenex> wumpus:  Yup, just got the notification. Thanks. I'll try to begin the review process asap.
09:02 < wumpus> thank you!
09:03 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
09:05 -!- geeker [~geeker@221.179.156.57] has joined #bitcoin-core-dev
09:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
09:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:26 -!- lightlike [~lightlike@p200300C7EF1BAB0059BDFFF3A040C7D2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:30 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
09:32 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
09:42 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
09:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:42 < bitcoin-git> [bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
09:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
09:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:48 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:53 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has quit [Ping timeout: 240 seconds]
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:00 < theStack> jnewbery: i posted the results of my getcfcheckpt cache (#18960) research in the PR thread, with a link to the script; there doesn't seem to be any difference, any request up to block 630000 takes 50ms on my machine
10:00 < gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
10:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:04 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:08 < MarcoFalke> hi, I won't make it to today's meeting, but I'd like to put something up for high prio
10:08 < MarcoFalke> #proposedmeetingtopic Add #18638 to high prio (MarcoFalke, not actually a topic)
10:08 < gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
10:16 -!- tmoc [~textual@c-73-41-135-128.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:17 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev
10:22 -!- russo_ [~russo@190-78-205-162.dyn.dsl.cantv.net] has joined #bitcoin-core-dev
10:24 -!- russo [~russo@190-78-205-162.dyn.dsl.cantv.net] has quit [Ping timeout: 272 seconds]
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:26 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b9c504cbc4ba...4dd2e5255a7f
10:26 < bitcoin-git> bitcoin/master fa182a8 MarcoFalke: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T...
10:26 < bitcoin-git> bitcoin/master fa1f840 MarcoFalke: rpcwallet: Replace pwallet-> with wallet.
10:26 < bitcoin-git> bitcoin/master 4dd2e52 Wladimir J. van der Laan: Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple a...
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:27 < bitcoin-git> [bitcoin] laanwj merged pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:34 -!- russo_ [~russo@190-78-205-162.dyn.dsl.cantv.net] has quit [Quit: Leaving]
10:38 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 260 seconds]
10:41 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:48 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev
10:51 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
10:53 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
11:00 -!- maxfragg1 [~maxfragg@217.138.197.102] has quit []
11:00 -!- Kiminuo [~mix@141.98.103.230] has quit [Ping timeout: 265 seconds]
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:00 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4dd2e5255a7f...2d7489be8f77
11:00 < bitcoin-git> bitcoin/master 061acf6 fanquake: scripts: no-longer check for 32 bit windows in security-check.py
11:00 < bitcoin-git> bitcoin/master 13f606b fanquake: scripts: remove NONFATAL from security-check.py
11:00 < bitcoin-git> bitcoin/master 83d063e fanquake: scripts: add run_command to security-check.py
11:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:01 < bitcoin-git> [bitcoin] laanwj merged pull request #18796: scripts: security-check.py refactors (master...security_check_no_more_32bit) https://github.com/bitcoin/bitcoin/pull/18796
11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:19 -!- kik1 [~kik1@184.75.221.43] has joined #bitcoin-core-dev
11:27 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
11:31 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has joined #bitcoin-core-dev
11:32 -!- geeker [~geeker@221.179.156.57] has quit [Ping timeout: 240 seconds]
11:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
11:33 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
11:33 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:42 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal]
11:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:43 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:44 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d7489be8f77...553bb3fc3d95
11:44 < bitcoin-git> bitcoin/master 7467366 John Newbery: [net processing] Only send a getheaders for one block in an INV
11:44 < bitcoin-git> bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:44 < bitcoin-git> [bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:46 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
11:46 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
11:56 -!- Kiminuo [~mix@141.98.103.230] has joined #bitcoin-core-dev
11:57 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Remote host closed the connection]
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu May 14 19:00:31 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < kanzure> hi
12:00 < sipsorcery>  hi
12:00 < elichai2> Hi
12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
12:00 < wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
12:01 < jonasschnelli> Hi
12:01 -!- per [~per@gateway/tor-sasl/wsm] has quit [Ping timeout: 240 seconds]
12:01 < jnewbery> hi
12:01 < hebasto> hi
12:01 < fjahr> hi
12:01 < jkczyz> hi
12:01 < meshcollider> hi
12:01 < aj> hi
12:01 < jeremyrubin> hola
12:02 < wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (only a suggestion for high prio for review)
12:02 < achow101> hi
12:03 < jeremyrubin> w.r.t. hi prio, i'd like to get the mempool project back on track it's review blocked
12:03 < sipa> i have a topic: ok to update to boost 1.59? and if so, when?
12:03 < wumpus> any any last minute proposals?
12:03 < wumpus> sipa: sgtm (though I'm not sure everyone is here wrt that discussion)
12:04 < wumpus> #topic High priority for review
12:04 < wumpus> Add #18638 to high prio (MarcoFalke, not actually a topic)
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
12:05 < jnewbery> Could we add #18960 as a blocker?
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
12:05 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
12:05 < wumpus> sure
12:05 < wumpus> added
12:06 < jnewbery> thanks!
12:06 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
12:06 < wumpus> https://github.com/bitcoin/bitcoin/projects/8   6 blockers, 1 bugfix, 4 chasing concept ACK now
12:07 < jeremyrubin> Can we add https://github.com/bitcoin/bitcoin/pull/18191?
12:07 < wumpus> jeremyrubin: do you have any specific suggestions wrt prs?
12:07 < wumpus> ah thanks
12:08 < wumpus> added
12:09 < wumpus> #topic required boost to 1.59 (sipa)
12:09 < sipa> hi
12:10 < wumpus> see also  #8875
12:10 < sipa> i'm considering various approaches to improving to some of the p2p tx download logic
12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/8875 | Bump minimum required Boost version · Issue #8875 · bitcoin/bitcoin · GitHub
12:10 < sipa> and one of them would rely on boost multi_index's ranked indexes
12:10 < sipa> which were added in boost 1.59
12:11 < sipa> so i was wondering if that's a possibility for 0.21
12:11 < sipa> or if i should consider other options (which i may do anyway)
12:11 < wumpus> that seems a fair enough reason
12:11  * luke-jr grumbles about RHEL/CentOS packages being hard to search
12:11 < wumpus> I think the most important thing to check is the versions in currently supported linux distros for building
12:12 < wumpus> "Version 1.59.0  August 13th, 2015 15:23 GMT" that sounds old enough, but knowing what old crap some distros ship with, it doesn't say everything
12:12 < sipa> well if we're going to be building with c++17, it seems we'd be relying on compilers newer than that anyway
12:13 < hebasto> https://github.com/bitcoin/bitcoin/pull/16381#issuecomment-511277755
12:13 < wumpus> yes
12:13 < jeremyrubin> sipa: ranked indexes look pretty cool
12:13 < sipa> they're very cool
12:13 < luke-jr> sounds like RHEL/CentOS 8 has boost 1.66
12:13 < wumpus> sipa: the dumbest way to find out would be to do a PR that uses that feature and see if it passes travis :)
12:14 < wumpus> luke-jr: oh! that's surprisingly new
12:14 < luke-jr> Debian has 1.67
12:14 < sipa> ok, will try opening a dummy PR and see what happens
12:14 < sipa> good enough for me
12:14 < jeremyrubin> does it make sense to do a minimum bump for feature or to bump to the highest minimum target we support?
12:14 < luke-jr> wumpus: not 100% sure
12:15 < wumpus> well sipa has a good reason now
12:15 < jeremyrubin> sipa: maybe check there's no bug-fixes to that new functionality in newer versions?
12:15 < wumpus> the reason #16381 was closed is that it wasn't important/urgent at the time
12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
12:15 < sipa> 1.64 has a bug fix related to ranked indices
12:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
12:15 < jeremyrubin> sipa: how severe?
12:15 < sipa> but the bug is just something that doesn't compile, which should
12:16 < sipa> so not severe at all
12:16 < wumpus> "it's eight years old" isn't enough to bump a minimum version, "I need this new data structure" well might be
12:16 < luke-jr> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/8.0_release_notes/index "Boost updated to version 1.66"
12:17 < wumpus> we already use boost 1.70 in depends so that's definitely new enough
12:17 < sipa> oh!
12:17 < sipa> ok
12:17 < wumpus> so yeah the current version used for gitian builds doesn't need to be bumped, only the minimum version
12:17 < sipa> that's enough for my topic
12:17 < jeremyrubin> sipa: are you adding this to mempool or to a diff data structure?
12:17 < wumpus> (supported at all)
12:18 < luke-jr> Ubuntu LTS is at 1.71
12:18 < luke-jr> Arch has 1.72
12:18 < jeremyrubin> Just worried that if it goes to mempool multiindex it looks like there's a non-trivial perfromance overhead on all erases
12:18 < luke-jr> Gentoo stablre is 1.72
12:18 < wumpus> if luke-jr  is right it's complely uncontroversial to bump the minimum to 1.59
12:18 < jeremyrubin> but this is less build systemy and more about how you're using it
12:18 < wumpus> (it likely depends on CenOS which is alwasys slowest)
12:19 < luke-jr> SuSE is 1.66
12:19 < sipa> jeremyrubin: no, this is unrelated to mempool
12:19 < luke-jr> any other popular distros these days?
12:19 < sipa> it's in net processing
12:19 < jeremyrubin> cool looking forward to seeing it.
12:20 < jeremyrubin> use might actually have some speedups for mempool come to think of it for the eviction logic & mining logic. will noodle on that.
12:21 < wumpus> any other topics for this week?
12:21 < wumpus> PSA: we're wrapping up 0.20.0rc2 at the moment
12:22 < sipa> they add 1 pointer memory usage per entry, fwiw (compared to ordered_index)
12:22 < luke-jr> wumpus: do you want me to try to reduce the size of my 0.20 release tarball fixes PR?
12:22 < wumpus> #18973 
12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
12:22 < wumpus> (finally)
12:22 < jeremyrubin> sipa: it's the log n erase that's more worrisome 
12:22 < wumpus> luke-jr: sure, but we're not going to hold up the rc on it
12:23 < luke-jr> wumpus: it's a security violation for users who build from source
12:23 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
12:23 < luke-jr> to answer how relevant it is
12:24 < wumpus> how so?
12:24 < luke-jr> and can result in leaking user private info to the network
12:24 < luke-jr> wumpus: it's looking at every parent directory to the source code for a git repo
12:24 < wumpus> I mean, it's been absurd how long it's taking to roll this release
12:24 < luke-jr> and taking whatever HEAD hash it finds into the version number
12:25 < luke-jr> pulling a hash out of an unrelated git repo the user might have, and publishing it, isn't very nice
12:25 < wumpus> I agree
12:25 < sipa> that sounds like something we should fix
12:25 < luke-jr> (Gentoo will kill the build instead)
12:26 < wumpus> but honestly we should cut a release at some point, there's aalways some edge case
12:26 < luke-jr> this is a regression, too
12:27 < wumpus> also #18902 rewrites a large part of the gitian descriptor and changes 6 files, can't this be fixed with some small patch?
12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
12:27 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds]
12:27 < luke-jr> probably
12:27 < luke-jr> I was trying to avoid conflicts with the autogen fix, but I guess we're missing that?
12:28 < wumpus> in any case: I agree it should be fixed, but I don't think it's terribly urgent
12:28 < hebasto> as a workaround a user could use BITCOIN_GENBUILD_NO_GIT variable
12:28 < luke-jr> maybe a release notes mention of the known issues
12:29 < wumpus> yes
12:29 < wumpus> I think that's fine
12:31 < luke-jr> current draft is in wiki still? or git?
12:31 < wumpus> wiki https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft
12:32 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 272 seconds]
12:32 < luke-jr> k, I'll see about writing something up for that
12:32 < wumpus> thanks!
12:32 < luke-jr> should I reduce the footprint of #18902 and/or #18909 also?
12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/18909 | [0.20] Fix release tarball by luke-jr · Pull Request #18909 · bitcoin/bitcoin · GitHub
12:33 < luke-jr> would be nice to just get 18902 merged to master as-is to fix all the issues at once :x   but maybe reducing 18909 makes more sense
12:35 < wumpus> fwiw the git_check_in_repo() check looks straightforward enough
12:35 < wumpus> why isn't that enough?
12:36 < wumpus> (or alternatively, check if a .git is in the top level of the source directory)
12:37 < wumpus> besides that change in genbuild.sh, are any other changes needed to fix this?
12:37 < hebasto> it is all about "version hack"
12:38 < hebasto> in gitian builds
12:38 < luke-jr> wumpus: we'd need to restore the "version hack"
12:38 < wumpus> luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
12:38 < luke-jr> the genbuild changes in 18902 are a proper fix for that
12:39 < wumpus> (I mean, in the right git repo)
12:39 < wumpus> yes my question is why isn't that the only change needed?
12:40 < wumpus> hebasto: so we can fix this by reverting a change too?
12:40 < hebasto> #18349 probably has simpler approach
12:40 < luke-jr> those are the only commits specific to 18902 - the other 3 are inherited from 18818
12:40 < gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
12:40 < wumpus> (at least in 0.20)
12:41 < hebasto> wumpus: not sure
12:41 < luke-jr> reverting a change would be the first commit of 18902 + restoring the "version hack"
12:42 < wumpus> ok
12:42 < luke-jr> (to literally revert, would be undoing all of the git-archive stuff)
12:42 < wumpus> so it's much more complex than I thought
12:42 < luke-jr> wumpus: it can be simplified with a few hours I suspect
12:42 < wumpus> let's just add a note to the release notes then
12:42 < wumpus> any other topics?
12:44 < wumpus> #endmeeting
12:44 < lightningbot> Meeting ended Thu May 14 19:44:05 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:44 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.html
12:44 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.txt
12:44 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.log.html
12:46 < luke-jr> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft#known-bugs
12:46 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer]
12:48 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
12:48 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
12:48 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
12:50 < wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most
12:54 < wumpus> FWIW for releases *and RCs all the version information in in configure.ac
12:54 < wumpus> I'm not sure what it gets from git at all
12:55 < sipa> random brainstorming (and highly unsure it's worth spending time on): what if we create a file that contains a list of (sha512 tree hash, version string) pairs, and at build time we compare the tree with that file, and use its name if found, tree hash otherwise
12:55 < sipa> that would disentangle version naming entirely from git
12:56 < wumpus> that's pretty much what git tags are
12:57 < wumpus> I mean all the version information is in configure.ac. My point is I don't see why any external information is needed.
12:57 < wumpus> neither from git tags nor any external file
12:57 < sipa> fair
12:58 < wumpus> this used to be differnt, to be clear, at some point the build process derives the rcX from the git tag
12:58 < wumpus> but we've already made everything explicit now
12:58 < sipa> oh, ok
12:58 < wumpus> derived*
12:58 < sipa> i was not aware of that
12:59 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
12:59 -!- fearbeag [~seanicide@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has quit [Quit: Leaving]
12:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:00 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
13:00 < wumpus> no worries, I don't have a full grasp in the version logic actually used either :)
13:02 < luke-jr> wumpus: but then we can't build non-releases with correct version info?
13:03 < wumpus> luke-jr: what is 'correct version info' in that case anyway?
13:03 < luke-jr> [19:50:46] <wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most <-- I suppose we could just not publish the tarball
13:03 < luke-jr> wumpus: a commit hash abbreviation seems fine
13:03 < wumpus> well the tarballs are fine, they are for releases and thus contain correct version info
13:04 < luke-jr> something like git-describe
13:04 < wumpus> they don't need *any* reference to git
13:04 < luke-jr> wumpus: currently, they don't..
13:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:04 < wumpus> luke-jr: they contain configure.ac, which has all the version info
13:04 < wumpus> including rc level
13:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:06 < wumpus> I know this because I have to set this every time before a rc
13:06 < luke-jr> hmm
13:10 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Quit: Leaving]
13:27 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:28 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
13:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:35 -!- tryphe_ is now known as tryphe
13:46 -!- emilengler [~emilengle@stratum0/entity/emilengler] has quit [Remote host closed the connection]
14:00 -!- kik1 [~kik1@184.75.221.43] has quit []
14:00 -!- Kiminuo [~mix@141.98.103.230] has quit [Quit: Leaving]
14:04 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
14:05 -!- molakala [~sumanth.b@2601:192:4701:87f0:257a:5b91:a1f4:3f48] has quit [Quit: Leaving]
14:11 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds]
14:17 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 256 seconds]
14:17 -!- alexsuraci [~alexsurac@84.39.116.180] has joined #bitcoin-core-dev
14:22 -!- manantial [~tecnecio_@unaffiliated/manantial] has quit [Ping timeout: 256 seconds]
14:22 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-dcqgscyptsukdjhi] has joined #bitcoin-core-dev
14:23 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
14:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:33 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
14:34 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
14:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 265 seconds]
14:37 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev
14:37 -!- shesek [~shesek@185.3.145.28] has quit [Changing host]
14:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
14:38 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds]
14:41 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 256 seconds]
14:43 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
14:44 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 265 seconds]
14:46 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
14:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
14:49 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer]
15:05 -!- dfmbbtc [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev
15:09 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Ping timeout: 260 seconds]
15:20 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
15:27 -!- dfmbbtc [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving]
15:38 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 240 seconds]
15:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:45 < bitcoin-git> [bitcoin] sipa opened pull request #18977: Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
15:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:50 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 272 seconds]
15:50 -!- jarthur [~jarthur@2605:6000:1019:4971:34b7:1cf6:c28e:1ebf] has joined #bitcoin-core-dev
15:59 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
16:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Quit: Leaving]
16:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:10 < sipa> it seems xenial only have boost 1.58
16:11 < jeremyrubin> so.... not till 2021 then?
16:12 < jeremyrubin> (Xenial is 16.04 LTS, which goes out of mantenance and to security only in 2021
16:13 < jeremyrubin> Personally I think it's probably OK given that it's 4 LTS's old, but it is still in maintenance so conceivable someone is relying on it still...
16:14 < jeremyrubin> err 3 LTS's old, not 4 (or 2 depending on how you count the current one)
16:14 < MarcoFalke> copy the hpp to our repo? I wanted to remove boost for 0.22.0
16:14 < sipa> remove boost? how are you going to do that?
16:14 < jeremyrubin> MarcoFalke: IDK if it's feasible givent that multiindex uses like all of boost internally.
16:14 < MarcoFalke> Switch to c++17 ;)
16:15 < MarcoFalke> If we need a single boost file we could subtree that single file?
16:15 < sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
16:15 < sipa> it's a zillion .hpp files
16:15 < sipa> across various boost packages
16:15 < jeremyrubin>  MarcoFalke: I don't think that's feasible, you can try bcp'ing multiindex out and it's big
16:16 < MarcoFalke> Ok, didn't know how big it is
16:16 < sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
16:16 < sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
16:16 < sipa> heh
16:16 < sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
16:17 < sipa> 78
16:17 < MarcoFalke> ouch
16:17 < jeremyrubin> Oh 78? I thought surely it was more than 80, so let's do it!
16:17 < sipa> which depends on boost mpl, boost move, a bunch of shared boost utility stuff, ...
16:18 < MarcoFalke> fanquake: Looks like you can do your bump ^
16:18 < jeremyrubin> MarcoFalke: OTOH rewriting multiindex for our specific use cases seems doable.
16:18 < sipa> boost mpl is 1045 files...
16:18 < fanquake> 👀
16:18 < MarcoFalke> jeremyrubin: Can you write one in less than 100 LOC (clang-formatted)?
16:18 < sipa> lol
16:19 < sipa> i do not want to write and maintain a copy of multi_index
16:19 < jeremyrubin> You can't even define a concrete type for the one we have in less than 100 LOC
16:19 < sipa> wahaha
16:19 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
16:20 < jeremyrubin> sipa: I think it wouldn't be writing a custom one, but writing a non template concrete impl for the one that we currently use.
16:20 < sipa> jeremyrubin: i spent 2 weeks trying to design a custom data structure for the thing i want :)
16:20 < sipa> and gave up
16:20 < jeremyrubin> Yeah. I'm just prodding MarcoFalke if he wants to ever get rid of boost
16:21 < sipa> i mean, it obviously could be done
16:21 < sipa> but it'd be far harder to review, and a properly abstracted version would like tend to have some minimal multi_index like reimplementation anyway
16:22 < luke-jr> sipa: jeremyrubin: since when do we support anything more than the latest LTS?
16:22 < sipa> MarcoFalke: i think as an intermediate goal maybe it's worth trying to only have header-only boost dependencies
16:22 < luke-jr> MarcoFalke: copying the hpp is strictly worse than depending on boost
16:22 < luke-jr> removing boost doesn't seem like a goal
16:22 < luke-jr> just using C++11 (or C++17 eventually) instead
16:23 < sipa> i think replacing boost with standard replacements when they're appropriate is great
16:23 < sipa> removing boost at all costs seems counter-productive
16:23 < luke-jr> exactly
16:23 < luke-jr> and we want to add boost::process soon for several things
16:23 < luke-jr> which AFAIK there is no C++ std alternative to
16:24 < sipa> what for?
16:24 < sipa> (just curous)
16:24 < jeremyrubin> smooth brain: replacing boost multiindex; galaxy brain: getting multiindex into c++next std
16:24 < luke-jr> sipa: HWI, Tor, IIRC there were a few others
16:24 < sipa> jeremyrubin: great, let's switch to C++29
16:24 < MarcoFalke> ACK
16:25 < jeremyrubin> TBH capnproto sounds like a better step to do than boost::process
16:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:25 < jeremyrubin> Should be able to handle similar use cases?
16:26 < sipa> ?
16:26 < sipa> i don't see how they're related
16:27 < luke-jr> jeremyrubin: totally different things..
16:27 < jeremyrubin> Isn't boost::process just some inter-process glue stuff? IIRC capnproto allows you to setup similar constructs but I could be off.
16:27 < luke-jr> boost::process lets us manage running other processes
16:27 < sipa> jeremyrubin: that's like saying JSON can replace TCP-IP
16:28 < jeremyrubin> gotcha, I just glanced at boost::process and saw that it was talking about IPC stuff
16:28 < sipa> i'm not convinced we need boost::process btw, but i haven't thought hard about it
16:32 -!- _Francisco_ [uid397221@gateway/web/irccloud.com/x-dcqgscyptsukdjhi] has quit [Quit: Connection closed for inactivity]
16:32 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:32 < MarcoFalke> If we require boost::process, we also need to ditch bionic
16:34 < fanquake> Just require Debian sid from here on out
16:36 < MarcoFalke> At least the switch to C++20 will be included for free /s
16:37 < luke-jr> latest stable Ubuntu is focal
16:37 < luke-jr> anything older is not guaranteed supported
16:38 < luke-jr> also, boost::process can/will probably be optional at first?
16:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:40 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:41 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
16:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:42 -!- fearbeag [~sseanicid@clwdon2201w-lp130-08-70-49-29-22.dsl.bell.ca] has joined #bitcoin-core-dev
16:45 < MarcoFalke> And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
16:45 < sipa> which bug?
16:45 < MarcoFalke> https://github.com/boostorg/thread/issues/308
16:45 < sipa> ha
16:45 -!- lightlike [~lightlike@p200300C7EF1BAB0059BDFFF3A040C7D2.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
16:46 < sipa> i think the quality differs a lot between boost libraries
16:46 < sipa> and for every goal, we should find the right solution
16:46 < sipa> whether that's boost or something else
16:47 < sipa> like... boost filesystem and boost shared_ptr effectively turned into c++ stl
16:47 < jeremyrubin> Well I think to MarcoFalke's point, if something like multiindex is thousands of files/78 modules
16:47 < sipa> yes, and it's great
16:48 < sipa> i know nothing that compares to it
16:48 < MarcoFalke> Just saying we should be cautious about pulling in dependencies
16:48 < sipa> MarcoFalke: absolutely
16:48 < jeremyrubin> I think MarcoFalke point is more around security than on features
16:48 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
16:48 < sipa> but "it's boost" on itself is not a point against a particular solution
16:48 < sipa> "it's unmaintained" is
16:49 < sipa> or "it's a logistical pain for our build system" is
16:49 < fanquake> MarcoFalke: did you save the log that you wanted. I'm about to push more commits
16:49 < MarcoFalke> fanquake: I reset the build, which archives the log. Go ahead!
16:50 < MarcoFalke> Let's pray the issue is just a race in the test
16:50 < MarcoFalke> At least it is not a regression
16:51 < MarcoFalke> sipa: I guess your feature wouldn't make sense if it was enabled conditionally on boost multi_index being available?
16:52 < MarcoFalke> So xenial users can still compile, but wouldn't get your feature
16:52 < sipa> MarcoFalke: it can be worked around with O(n) complexity instead of O(log n)
16:53 < sipa> which is probably not terrible in practice, but harder to guarantee no remotely-triggerable extreme conditions that become very slow
16:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
16:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:56 < jeremyrubin> sipa: Out of curiosity for the design you're making, wouldn't you have to take an action for everything in that rank group anyways?
16:57 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds]
16:57 < jeremyrubin> e.g., isn't this fundamentally O(N)?
16:57 < jeremyrubin> *ie
16:59 < sipa> jeremyrubin: no
17:00 -!- alexsuraci [~alexsurac@84.39.116.180] has quit []
17:00 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
17:00 < sipa> jeremyrubin: specifically, in a ranked index you can count how many set/index elements have a certain property, and then pick a uniformly random one in O(log n) time
17:01 < sipa> in an ordered index those are O(n) in the number of matching elements
17:02 < jeremyrubin> Gotcha. So some cached property or ordered predicate, you can see how many things satisfy in O(log(N)) and then pick  in O(1) time from that?
17:04 < sipa> picking is still O(log n) in the size of the index in a ranked_index
17:04 < sipa> and counting too
17:04 < jeremyrubin> sipa: interesting. So every query is log(n) for that, (e.g., n queries cost n log n not n)
17:04 < sipa> indeed
17:05 < sipa> well, no
17:05 < sipa> say n is the total index size and m is the number of matching elements
17:05 < jeremyrubin> was just going to ask
17:05 < sipa> then finding the number of matching elements is O(log n)
17:05 < sipa> picking one of them randomly is O(log m)
17:06 < sipa> hmm, in theory - not sure that's implemented though
17:06 < sipa> it may be O(log n) still
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:06 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/553bb3fc3d95...e2f6866cca3e
17:06 < bitcoin-git> bitcoin/master 050e2ee Wladimir J. van der Laan: test: Remove const to work around compiler error on xenial
17:06 < jeremyrubin> Interesting
17:06 < bitcoin-git> bitcoin/master e2f6866 fanquake: Merge #18975: test: Remove const to work around compiler error on xenial
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:06 < jeremyrubin> Because there are algorithms where you pick your rank M so that log(m) is small
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:06 < bitcoin-git> [bitcoin] fanquake merged pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:07 < jeremyrubin> But the interesting point is you only see a benefit on repeated queries if you're making a few queries to it
17:07 < jeremyrubin> Otherwise you may as well do O(n) to make a new filter, then have O(1) uniform drawing
17:07 < sipa> i don't understand
17:08 < sipa> you cannot pick an element in O(1) time in a tree structure
17:08 < sipa> you need something like a vector for that
17:08 < jeremyrubin> No you're missing what I'm saying 
17:08 < jeremyrubin> new filter == make a vector that is the filtered things to match predicate
17:08 < sipa> ok, but that's O(m)
17:09 < jeremyrubin> Depending on the underlying container, O(m) or O(n)
17:09 < jeremyrubin> O(n) if the property isn't already sorted
17:09 < sipa> (no need for a new vector though; you can just do repeated iterator operations, which is always O(m))
17:09 < jeremyrubin> Nope!
17:09 < sipa> picking a random element doesn't require an order
17:09 < jeremyrubin> The vector lets you index in O(1)
17:10 < jeremyrubin> WHich if you're drawing multiple times
17:10 < jeremyrubin> is a speedup.
17:10 < sipa> yes but constructing is at least O(m)
17:10 < sipa> ah
17:10 < jeremyrubin> That's why I asked :)
17:10 < sipa> i only need to pick a random one once
17:10 < sipa> the next time a random element gets picked, the set may have changex
17:10 < jeremyrubin> gotcha.
17:11 < jeremyrubin> So kinda "pick random thing newer than last reconnect"
17:11 < jeremyrubin> *disconnect
17:12 < jeremyrubin> sipa: do you query the property in different ways?
17:12 < jeremyrubin> Or is it just one query
17:13 < jeremyrubin> E.g., top 15% known statically?
17:13 < jeremyrubin> Or is it some per-node %
17:13 < jeremyrubin> also if you have code happy to just look at that
17:16 < sipa> jeremyrubin: i'm stl considering several other approaches
17:16 < sipa> will show code when i have something to show
17:17 < sipa> jeremyrubin: and no, it's not a percentage, it's just to be able to pick uniformly random elements
17:17 < jeremyrubin> over the whole range?
17:18 < jeremyrubin> ah is it also picking uniformly over the range of values? Not just their indexes?
17:18 < sipa> within a subset with some property, which has an index over it
17:18 < sipa> so you find the first index entry with that property, and the last
17:18 < sipa> compute the rank of both
17:18 < sipa> subtract them to count them
17:18 < sipa> pick a uniformly random entry in that range
17:19 < sipa> and then use nth to map that rank to the index entry
17:19 -!- wright [~wright@185.204.1.185] has joined #bitcoin-core-dev
17:25 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 265 seconds]
17:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
17:40 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
17:41 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
17:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
17:46 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
17:48 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds]
18:02 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
18:13 -!- jarthur [~jarthur@2605:6000:1019:4971:34b7:1cf6:c28e:1ebf] has quit []
18:14 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:14 -!- geeker [~geeker@221.179.156.57] has joined #bitcoin-core-dev
18:20 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:21 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:23 -!- gzhao408 [49fcfb03@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
18:30 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:33 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
18:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
18:48 -!- gleb [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has quit [Ping timeout: 258 seconds]
18:49 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
18:56 -!- veleiro`` [~user@184-15-126-175.dr02.chtn.wv.frontiernet.net] has joined #bitcoin-core-dev
18:59 -!- veleiro` [~user@50-110-108-202.blfd.wv.frontiernet.net] has quit [Ping timeout: 258 seconds]
19:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
19:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:05 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
19:10 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
19:17 -!- SiAnDoG_ [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
19:20 -!- milieu__ [~514nDoG@gateway/tor-sasl/siandog] has quit [Remote host closed the connection]
19:34 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
19:35 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
19:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:48 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
19:58 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds]
20:00 -!- wright [~wright@185.204.1.185] has quit []
20:00 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20:07 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
20:11 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds]
20:13 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
20:20 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds]
20:43 -!- aowi [~aowi@195.206.183.79] has joined #bitcoin-core-dev
20:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:07 -!- davterra [~dulyNoded@2601:603:4f00:63d0::5] has quit [Quit: Leaving]
21:08 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
21:09 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
21:09 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
21:12 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds]
21:19 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:51 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has joined #bitcoin-core-dev
22:05 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
22:05 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:16 -!- proofofkeags [~proofofke@174-29-9-247.hlrn.qwest.net] has quit [Remote host closed the connection]
22:51 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
22:55 -!- manantial [~tecnecio_@unaffiliated/manantial] has joined #bitcoin-core-dev
23:00 -!- aowi [~aowi@195.206.183.79] has quit []
23:01 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
23:07 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer]
23:07 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
23:16 < fanquake> Looking for opinions on just removing the remaining fuzz job for the 0.20 branch. It's not going to pass in Travis without even more backporting: https://github.com/bitcoin/bitcoin/pull/18973#issuecomment-629050088
23:17 < fanquake> I think having the fuzzers / valgrind /*san etc just running on master is ok
23:19 < luke-jr> without knowing the detail, I'm not sure I'm comfortable with forgoing the valgrind/*san stuff.. if those don't pass, surely we ought to fix them?
23:20 < fanquake> The issues are fixed in master, but unless you want to start backporting even more to 0.20.0, like #18413, they are always going to fail on that branch
23:20 < gribble> https://github.com/bitcoin/bitcoin/issues/18413 | script: prevent UB when computing abs value for num opcode serialize by pierreN · Pull Request #18413 · bitcoin/bitcoin · GitHub
23:21 < fanquake> The valgrind and s390x jobs have already been removed from 0.20.0 in https://github.com/bitcoin/bitcoin/commit/7d87ba0e022796b42d6c17b59bb735c94dd6e045 and https://github.com/bitcoin/bitcoin/commit/aa7c6858e6e480eb841195bdaf2ee0185f17f9a7
23:22 -!- defnordic [~defnordic@185.204.1.185] has joined #bitcoin-core-dev
23:33 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev
23:43 < wumpus> fanquake: I think I'd prefer disabling the particular tests that fail for now, instead of disabling fuzzing on the 0.20 branch wholesale
23:43 < wumpus> I disabled valgrind and s390x to be on the same basis as master at least 
23:44 < wumpus> but I do think some of the fuzz testing on the release branch is good, I mean it could uncover e.g. faulty backports
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:44 < bitcoin-git> [bitcoin] hebasto opened pull request #18980: build: Decouple clientversion.cpp from the git repo (master...0515-decouple) https://github.com/bitcoin/bitcoin/pull/18980
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:46 < fanquake> wumpus: ok. I’ll revert the last backport abd disable the scriptnum_ops fuzz test. Will see if anything else fails
23:56 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
23:56 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
--- Log closed Fri May 15 00:00:21 2020