--- Log opened Wed May 27 00:00:32 2020
00:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
00:01 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
00:03 -!- Pavlenex1 is now known as Pavlenex
00:12 -!- jonatack_ [~jon@37.170.255.11] has quit [Ping timeout: 246 seconds]
00:13 -!- jonatack_ [~jon@184.75.223.203] has joined #bitcoin-core-dev
00:23 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
00:24 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
00:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:47 -!- Kiminuo [~mix@141.98.103.244] has joined #bitcoin-core-dev
00:49 -!- Kiminuo [~mix@141.98.103.244] has quit [Read error: Connection reset by peer]
00:53 -!- skypper [54e88c13@84.232.140.19] has joined #bitcoin-core-dev
00:53 -!- jonatack_ [~jon@184.75.223.203] has quit [Quit: jonatack_]
00:58 -!- jonatack [~jon@184.75.223.203] has joined #bitcoin-core-dev
01:05 -!- skypper [54e88c13@84.232.140.19] has left #bitcoin-core-dev []
01:06 -!- skypper [54e88c13@84.232.140.19] has joined #bitcoin-core-dev
01:12 -!- jkczyz_ [sid419941@gateway/web/irccloud.com/x-wjxmksunuwrmguxl] has joined #bitcoin-core-dev
01:12 -!- NicolasDorier_ [sid129442@gateway/web/irccloud.com/x-sgleoopqggjruvdz] has joined #bitcoin-core-dev
01:20 -!- Netsplit *.net <-> *.split quits: jkczyz, NicolasDorier, cncr04s
01:20 -!- NicolasDorier_ is now known as NicolasDorier
01:20 -!- jkczyz_ is now known as jkczyz
01:22 -!- cncr04s_ [~cncr04s@afxr.net] has joined #bitcoin-core-dev
01:29 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:50 -!- skypper [54e88c13@84.232.140.19] has quit [Remote host closed the connection]
02:00 -!- Guest5579 [~andrea@139.28.218.198] has quit []
02:21 -!- shortdudey1231 [~shortdude@217.146.82.122] has joined #bitcoin-core-dev
02:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:26 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
02:26 < provoostenator> harding: #17219 was merged on April 17th, which if after 0.20 branched off
02:27 < gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub
02:31 < provoostenator> I plan to do a write-up on hardware wallet pull requests and they relate. The meat and potatos is in #16546, which I keep up to date regularly.
02:32 < gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
02:34 < provoostenator> It depends on an improvment to sendmany  sendaddress to work with PSBT. There's multiple ways to do that, including writing a whole new send RPC method like in #16378
02:34 < gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
02:34 < provoostenator> It also needs a way to communicate with the device, which for now I'm using Boost::Process for. Similar to the dicussion with multiprocess, that method can be swapped out later
02:35 < provoostenator> But I haven't seen any worked out alternatives in over a year, so #15382  appears the way to go.
02:35 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
02:36 < provoostenator> Finally there's a GUI PR which is more rough, and depends on all the above. But it nicely illustrates what a relatively user friendly experience could look like. #16546
02:36 < gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
02:36 < provoostenator> I mean #16549
02:36 < gribble> https://github.com/bitcoin/bitcoin/issues/16549 | UI external signer support (e.g. hardware wallet) by Sjors · Pull Request #16549 · bitcoin/bitcoin · GitHub
02:37 < provoostenator> I keep that one rebased too.
02:38 < provoostenator> Everything is designed to work with HWI, but any other script or program with the same interface works too.
02:39 < provoostenator> Which I imagine could be more than just a locally connected hardware wallet. E.g. perhaps an online multisig cosigner service.
02:43 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 240 seconds]
02:47 < jonatack> provoostenator: per our recent discussion offline, it would be great to move these forward by highlighting the highest or first priority one to focus review on, and maybe add to the blockers tomorrow... 15382 or 16546 IIUC? 
02:48 < provoostenator> 15382 would make sense for that, since it has no dependencies
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:50 < provoostenator> But also kallewoof's #11413 (though he has a Signet PR in prioriy list)
02:50 < gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
02:51 < provoostenator> ^ that PR is a such a bit change to the send RPC calls that it blocks other work on them
02:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/520e435b5e56...48e114e0a86f
02:51 < bitcoin-git> bitcoin/master 1c91ffe pad: doc : add link to readme.md in the first section
02:51 < bitcoin-git> bitcoin/master 48e114e fanquake: Merge #19061: doc: Add link to Visual Studio build readme
02:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:52 < bitcoin-git> [bitcoin] fanquake merged pull request #19061: doc: Add link to Visual Studio build readme (master...master) https://github.com/bitcoin/bitcoin/pull/19061
02:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
02:52 < jonatack> provoostenator: ok, noting for my review list. (i probably won't be at the irc meeting since they are during my sleep hours ATM, but i'll check the blockers list anyway) 
02:56 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has joined #bitcoin-core-dev
03:03 -!- Diego42Wiza [~Diego42Wi@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:03 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:09 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
03:10 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
03:12 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
03:15 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
03:18 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
03:24 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev
03:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48e114e0a86f...cffbf1eb9a47
03:36 < bitcoin-git> bitcoin/master 4c82579 Elichai Turkel: Remove outdated comment about DER encoding
03:36 < bitcoin-git> bitcoin/master cffbf1e fanquake: Merge #19073: Remove outdated comment about DER encoding
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:36 < bitcoin-git> [bitcoin] fanquake merged pull request #19073: Remove outdated comment about DER encoding (master...2020-05-remove-der-comment) https://github.com/bitcoin/bitcoin/pull/19073
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:40 -!- jonatack [~jon@184.75.223.203] has quit [Quit: jonatack]
03:41 < harding> provoostenator: yeah, I don't know why 17219 seemed to be described in the 0.20 draft release notes.  Let me see if I can figure out who added it.
03:42 < fanquake> It might have been achow101 on my misdirection. I thought that PR was part of 0.20.0
03:43 < fanquake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/c5bd4e39348402cd9d2cbadf9bbc049836a9df16
03:45 < harding> Ok, mystery solved.  I just wanted to make sure I wasn't removing something that actually did apply to 0.20.  I've got it queued for a PR to master for when I finish editing all the 0.20 stuff.
03:45 -!- Diego42Wiza [~Diego42Wi@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
03:46 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
03:47 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
04:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
04:12 < meshcollider> instagibbs: I *will* get around to reviewing #17331 (and its parent) next week even though I hate coin selection, I promise. The next couple of days are just going to be super busy but after that, as you requested... 
04:12 < gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
04:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
04:14 -!- jonatack [~jon@184.75.221.43] has joined #bitcoin-core-dev
04:14 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:15 < meshcollider> Same with #18275, sorry kalle, it's been on my list for a while but I promise it isn't forgotten
04:15 < gribble> https://github.com/bitcoin/bitcoin/issues/18275 | wallet: error if an explicit fee rate was given but the needed fee rate differed by kallewoof · Pull Request #18275 · bitcoin/bitcoin · GitHub
04:16 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cffbf1eb9a47...9ccaee1d5e2e
04:18 < bitcoin-git> bitcoin/master c57f03c Calvin Kim: refactor: Replace const char* to std::string
04:18 < bitcoin-git> bitcoin/master 9ccaee1 MarcoFalke: Merge #19004: refactor: Replace const char* to std::string
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19004: refactor: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
04:52 -!- pinheadmz [~pinheadmz@96.47.229.196] has joined #bitcoin-core-dev
04:58 < elichai2> Hi, why is the nVersion of the block header the top bits instead of the "regular" ones? (ie why `0x20000000UL` instead of `4`)
04:58 -!- someone235 [uid419897@gateway/web/irccloud.com/x-unvycqhiaghgckcv] has joined #bitcoin-core-dev
05:00 -!- shortdudey1231 [~shortdude@217.146.82.122] has quit []
05:18 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
05:18 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
05:19 -!- tasmo [~tasmo@139.28.218.198] has joined #bitcoin-core-dev
05:20 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
05:34 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:42 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
05:49 < harding> I added some previously-undocumented changes to the 0.20 release notes draft.  Review is appreciated; I'm happy to make any edits: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/cd86fd949c5dc3bf8c85f7f4935cac0c1ae0fb55...d87bc6f05e506ae1ff358ccff4e7f4cbbe2c1fb3
05:57 < fanquake> harding: probably just squashing the "build system" section added at the bottom with the "build system section" at the top of the notes. Unless they were kept split for a reason.
06:06 < jonatack> harding: lgtm. micro-nit: s/parameter than can be used/parameter that can be used/
06:13 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Ping timeout: 272 seconds]
06:24 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
06:24 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:54 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
07:06 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
07:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 272 seconds]
07:07 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
07:07 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
07:09 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Client Quit]
07:10 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has quit [Ping timeout: 265 seconds]
07:20 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
07:27 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Quit: Pavlenex]
07:29 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
07:30 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Client Quit]
07:30 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
07:30 < harding> fanquake, jonatack: thanks!
07:32 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Client Quit]
07:57 -!- rmoura [~rmoura@114.52.115.89.rev.vodafone.pt] has quit [Quit: buy some bitcoin. bye bye]
08:00 -!- tasmo [~tasmo@139.28.218.198] has quit []
08:00 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
08:01 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
08:08 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
08:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:16 -!- jarthur_ [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has joined #bitcoin-core-dev
08:19 -!- jarthur_ [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has quit [Remote host closed the connection]
08:20 -!- jarthur [~jarthur@2605:6000:1019:4971:47f:8c2a:6cbf:5b80] has quit [Ping timeout: 260 seconds]
08:22 -!- engil1 [~engil@84.39.116.180] has joined #bitcoin-core-dev
08:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:39 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 256 seconds]
08:41 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:45 -!- owowo [~ovovo@s91904426.blix.com] has joined #bitcoin-core-dev
08:45 -!- owowo [~ovovo@s91904426.blix.com] has quit [Changing host]
08:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:46 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
08:48 -!- roconnor [~roconnor@host-45-78-247-135.dyn.295.ca] has joined #bitcoin-core-dev
08:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
08:49 -!- wullon5 [~wullon@182.234.86.88.rdns.comcable.net] has joined #bitcoin-core-dev
08:50 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
08:57 < roconnor> elichai2: See BIP-9
08:58 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
09:02 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:03 -!- wullon5 [~wullon@182.234.86.88.rdns.comcable.net] has quit [Quit: The Lounge - https://thelounge.chat]
09:09 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev
09:11 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:13 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:23 -!- vasild_ is now known as vasild
09:24 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Quit: Pavlenex]
09:24 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds]
09:24 -!- Pavlenex [~Thunderbi@178.220.42.62] has joined #bitcoin-core-dev
09:26 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
09:29 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Ping timeout: 246 seconds]
09:34 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
09:35 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
09:44 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
09:45 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
09:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
09:50 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
09:50 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Read error: Connection reset by peer]
09:51 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
09:51 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
09:55 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev
10:00 -!- tarboss [~tarboss@p54a034ab.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
10:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:03 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:07 < bitcoin-git> [bitcoin] gillichu opened pull request #19082: Moved the CScriptNum asserts into the unit test in script.py (master...issue24) https://github.com/bitcoin/bitcoin/pull/19082
10:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:11 -!- jarthur [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has joined #bitcoin-core-dev
10:18 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
10:22 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 258 seconds]
10:24 -!- Ridwan102 [b9d975ed@185.217.117.237] has joined #bitcoin-core-dev
10:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
10:25 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev
10:25 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
10:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:30 -!- r251d [~r251d@162-196-59-192.lightspeed.irvnca.sbcglobal.net] has quit [Quit: r251d]
10:31 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
10:32 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
10:33 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
10:38 -!- someone235 [uid419897@gateway/web/irccloud.com/x-unvycqhiaghgckcv] has quit [Quit: Connection closed for inactivity]
10:39 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds]
10:45 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
10:46 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
10:52 -!- Ridwan102 [b9d975ed@185.217.117.237] has quit [Remote host closed the connection]
10:52 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:54 -!- pinheadmz [~pinheadmz@96.47.229.196] has quit [Ping timeout: 264 seconds]
11:00 -!- engil1 [~engil@84.39.116.180] has quit []
11:01 -!- tarboss [~tarboss@p54a034ab.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
11:10 -!- danielyin [~danielyin@204.11.107.220] has joined #bitcoin-core-dev
11:20 -!- Ceriand [~Ceriand@217.146.82.122] has joined #bitcoin-core-dev
11:34 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving]
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:11 < bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19063: rpc: testmempoolaccept returns transaction fee (master...fee-in-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/19063
12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:12 -!- Pavlenex [~Thunderbi@178.220.42.62] has quit [Quit: Pavlenex]
12:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:29 -!- lehnberg_ [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev
12:30 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
12:31 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
12:32 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Ping timeout: 246 seconds]
12:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
12:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
12:38 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has quit [Quit: The Lounge - https://thelounge.chat]
12:38 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has joined #bitcoin-core-dev
12:48 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
12:55 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: Lost terminal]
12:57 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:03 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
13:10 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
13:26 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: Lost terminal]
13:27 -!- jonatack [~jon@184.75.221.43] has quit [Ping timeout: 246 seconds]
13:29 -!- jonatack [~jon@37.166.127.107] has joined #bitcoin-core-dev
13:31 -!- lehnberg_ [~lehnberg@unaffiliated/lehnberg] has quit [Quit: lehnberg_]
13:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
13:49 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has quit [Ping timeout: 272 seconds]
13:51 -!- SiAnDoG [~514nDoG@gateway/tor-sasl/siandog] has joined #bitcoin-core-dev
14:00 -!- Ceriand [~Ceriand@217.146.82.122] has quit []
14:01 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev
14:05 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Remote host closed the connection]
14:21 -!- variable [~variable@217.138.204.90] has joined #bitcoin-core-dev
14:21 -!- variable is now known as Guest8623
14:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
14:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
14:27 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
14:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:35 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadm_]
14:36 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:48 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 256 seconds]
15:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:04 < bitcoin-git> [bitcoin] gzhao408 opened pull request #19083: test: msg_mempool, fRelay, and other bloomfilter tests (master...test-bloomfilter) https://github.com/bitcoin/bitcoin/pull/19083
15:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:14 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev
15:31 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Remote host closed the connection]
15:40 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
15:47 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
15:51 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
15:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:04 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:04 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
16:06 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Read error: Connection reset by peer]
16:07 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
16:07 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 258 seconds]
16:09 -!- jonatack_ [~jon@37.172.61.28] has joined #bitcoin-core-dev
16:12 -!- jonatack [~jon@37.166.127.107] has quit [Ping timeout: 260 seconds]
16:14 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 272 seconds]
16:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
16:19 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Read error: Connection reset by peer]
16:19 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
16:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
16:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:32 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9ccaee1d5e2e...55b4c65bd1d8
16:34 < bitcoin-git> bitcoin/master c3cf2f5 Anthony Towns: rpc/blockchain.cpp: Remove g_utxosetscan mutex that is only protecting a s...
16:34 < bitcoin-git> bitcoin/master de7c5f4 Anthony Towns: wallet/wallet.h: Remove mutexScanning which was only protecting a single a...
16:34 < bitcoin-git> bitcoin/master 8b5af3d Anthony Towns: net: fMsgProcWake use LOCK instead of lock_guard
16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16127: More thread safety annotation coverage (master...201905-locking) https://github.com/bitcoin/bitcoin/pull/16127
16:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:45 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:51 -!- kaftejiman [~kaftejima@212.252.143.42] has joined #bitcoin-core-dev
16:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
17:00 -!- Guest8623 [~variable@217.138.204.90] has quit []
17:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
17:01 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
17:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
17:06 -!- kaftejiman [~kaftejima@212.252.143.42] has left #bitcoin-core-dev ["Leaving"]
17:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:15 < bitcoin-git> [bitcoin] ajtowns opened pull request #19084: net: add comments on dns seed behaviour (master...202005-dns-seed-doc) https://github.com/bitcoin/bitcoin/pull/19084
17:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:18 -!- RC-3004 [~RC-3004@84.39.116.180] has joined #bitcoin-core-dev
17:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
17:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
17:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:42 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
17:51 -!- jarthur [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has quit []
18:20 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
18:20 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Read error: No route to host]
18:21 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
18:24 -!- proofofk_ [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
18:33 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
18:38 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 264 seconds]
18:41 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:49 -!- roconnor [~roconnor@host-45-78-247-135.dyn.295.ca] has quit [Ping timeout: 246 seconds]
19:29 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
19:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
19:30 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
19:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
19:40 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev
19:40 -!- shesek [~shesek@185.3.145.28] has quit [Changing host]
19:40 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
19:50 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
19:55 -!- Highway61 [~Thunderbi@209.95.56.160] has quit [Ping timeout: 265 seconds]
19:57 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:00 -!- RC-3004 [~RC-3004@84.39.116.180] has quit []
20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:01 < bitcoin-git> [bitcoin] jnewbery opened pull request #19085: Refactor: clean up PeriodicFlush() (master...2020-05-refactor-periodic-flush) https://github.com/bitcoin/bitcoin/pull/19085
20:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:01 -!- tylerdmace [~tyler@136.36.154.185] has joined #bitcoin-core-dev
20:06 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
20:17 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20:21 -!- Darki [~Darki@84.39.116.180] has joined #bitcoin-core-dev
20:22 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
20:26 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
21:01 < jeremyrubin> For #18191 I'm really conflicted with what to do on the compiler warnings that jonatack is reporting. The const txiter that I wrote is intentionally const. I'm a const-me-if-you-can beleiver. But it causes a false-positive compiler warning on certain clangs, and I don't love removing a safety annotation for a compiler warning.
21:01 < gribble> https://github.com/bitcoin/bitcoin/issues/18191 | Change UpdateForDescendants to use Epochs by JeremyRubin · Pull Request #18191 · bitcoin/bitcoin · GitHub
21:02 < jeremyrubin> I'm happy to do whatever wumpus says I should do here
21:06 < sipa> jeremyrubin: making it const txiter& isn't removing any safety?
21:07 -!- jarthur [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has joined #bitcoin-core-dev
21:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
21:14 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
21:16 < jeremyrubin> Ah right I am a bit foggy today I misremembered what the fix is and why I didn't like it. I think maybe if we should change this code, it's maybe worth style guiding to not use copy vs ref or remove -Wrange-loop-analysis if we don't want to require it
21:16 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 272 seconds]
21:21 < sipa> i think for any moderately decent optimizing compiler, passing by reference is never worse (and often better)
21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:24 < sipa> so the advice of -Wrange-loop-analysis always applies
21:26 < jeremyrubin> ok I guess i'll squash in changing them. My frustration is less so about this one in specific and more so that there's like 30 some odd other commits that I need to re-write for this warning for the pending work on the mempool project.
21:27 < jeremyrubin> Is there any way that gcc can throw this warning as well or we can make it more reliably triggered?
21:27 -!- jarthur [~jarthur@2605:6000:1019:4971:dccb:bf82:c23e:89d3] has quit []
21:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:30 < jeremyrubin> I re-asked this on the github thread in case anyone knows
21:30 < jeremyrubin> 'night
21:32 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
21:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
21:39 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
21:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
22:09 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
22:17 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 265 seconds]
22:25 -!- marcoagner [~user@2001:8a0:6a5f:a900:6d3e:1158:b50:97b6] has joined #bitcoin-core-dev
22:33 -!- Wendell69Maggio [~Wendell69@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
22:45 -!- Wendell69Maggio [~Wendell69@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
23:00 -!- Darki [~Darki@84.39.116.180] has quit []
23:06 -!- danielyin [~danielyin@204.11.107.220] has quit [Quit: leaving]
23:19 -!- Harwood [~Harwood@172.98.137.26] has joined #bitcoin-core-dev
23:19 -!- Harwood [~Harwood@172.98.137.26] has quit [Excess Flood]
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:25 < bitcoin-git> [bitcoin] lareq opened pull request #19086: fixed typo - polish translation (master...master) https://github.com/bitcoin/bitcoin/pull/19086
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:26 < bitcoin-git> [bitcoin] fanquake closed pull request #19086: fixed typo - polish translation (master...master) https://github.com/bitcoin/bitcoin/pull/19086
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:41 -!- frogar [~frogar_@w.x.y.z.mooo.com] has quit [Remote host closed the connection]
23:41 -!- frogar [~frogar_@w.x.y.z.mooo.com] has joined #bitcoin-core-dev
23:51 -!- johanna1 [~johanna@184.75.223.235] has joined #bitcoin-core-dev
23:52 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
--- Log closed Thu May 28 00:00:33 2020