--- Log opened Mon Jun 01 00:00:38 2020 00:08 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 00:31 -!- jarthur [~jarthur@2605:6000:1019:4971:859:c2cc:4c9b:c380] has quit [Remote host closed the connection] 00:31 -!- jarthur [~jarthur@2605:6000:1019:4971:859:c2cc:4c9b:c380] has joined #bitcoin-core-dev 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a65b55fa45d4...a8327fd71f5c 00:39 < bitcoin-git> bitcoin/master fab893e MarcoFalke: doc: Fix unrelated typos reported by codespell 00:39 < bitcoin-git> bitcoin/master 100000d MarcoFalke: doc: Add headings to CONTRIBUTING.md 00:39 < bitcoin-git> bitcoin/master fae2fb2 MarcoFalke: doc: Expand section on Getting Started 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] fanquake merged pull request #19072: doc: Expand section on Getting Started (master...2005-docContribClarif) https://github.com/bitcoin/bitcoin/pull/19072 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:53 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 00:57 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a8327fd71f5c...9bc7751cadbd 01:07 < bitcoin-git> bitcoin/master fa86179 MarcoFalke: doc: Add release notes for 17219 01:07 < bitcoin-git> bitcoin/master fac0ed1 MarcoFalke: doc: Sync "how to upgrade" with 0.20.0 release notes 01:07 < bitcoin-git> bitcoin/master 9bc7751 fanquake: Merge #19115: doc: Add release notes for 17219 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] fanquake merged pull request #19115: doc: Add release notes for 17219 (master...2005-docRel) https://github.com/bitcoin/bitcoin/pull/19115 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:25 < bitcoin-git> [bitcoin] jonathanschoeller opened pull request #19131: refactor: Fix unreachable code in init arg checks (master...fix-Wunreachable-code-loop-increment) https://github.com/bitcoin/bitcoin/pull/19131 01:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:27 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #bitcoin-core-dev 01:29 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 01:31 -!- Processus42_ is now known as Processus42 01:31 -!- nullptr_ [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Ping timeout: 256 seconds] 01:34 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev 01:49 -!- jarthur_ [~jarthur@2605:6000:1019:4971:bc25:b77e:2984:653f] has joined #bitcoin-core-dev 01:49 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:50 -!- jarthur_ [~jarthur@2605:6000:1019:4971:bc25:b77e:2984:653f] has quit [Client Quit] 01:51 -!- jarthur [~jarthur@2605:6000:1019:4971:859:c2cc:4c9b:c380] has quit [Ping timeout: 260 seconds] 01:59 -!- Yukinochan [~Yukinocha@gateway/tor-sasl/yukinochan] has joined #bitcoin-core-dev 02:00 -!- SummerNinja [~SummerNin@37.120.203.188] has quit [] 02:03 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:09 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 02:10 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 02:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 02:18 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:22 -!- jeremyb [~jeremyb@139.28.218.198] has joined #bitcoin-core-dev 02:22 -!- jeremyb is now known as Guest23530 02:23 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev 02:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 02:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 02:46 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 02:50 -!- dr-orlov1ky [~user@31.14.40.19] has joined #bitcoin-core-dev 02:54 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 02:55 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 02:58 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 03:01 -!- Kiminuo [~mix@141.98.103.180] has joined #bitcoin-core-dev 03:03 -!- Matt5Crooks [~Matt5Croo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 03:08 -!- Matt5Crooks [~Matt5Croo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds] 03:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 03:12 < fanquake> practicalswift asked for #18288 to be their high-prio PR; so I've added it. 03:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18288 | build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory by practicalswift · Pull Request #18288 · bitcoin/bitcoin · GitHub 03:14 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 03:18 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 04:00 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev 04:05 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 04:05 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 04:32 < Kiminuo> Hi, can I make my PR https://github.com/bitcoin/bitcoin/pull/18210 more attractive for review somehow? I have just rewritten the first post to articulate more clearly what the PR does. 04:45 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 04:46 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 04:49 < jonatack> Kiminuo: rebasing promptly helps, and giving review is a good way to (a) to see the review bottleneck and (b) receive review back 04:50 < jonatack> Kiminuo: because there are more people who open PRs than people who review them 04:51 -!- Yukinochan [~Yukinocha@gateway/tor-sasl/yukinochan] has quit [Quit: Yukinochan] 04:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 05:00 -!- Guest23530 [~jeremyb@139.28.218.198] has quit [] 05:01 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:04 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 246 seconds] 05:05 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 05:15 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:16 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 05:22 -!- defnordic [~defnordic@217.146.82.122] has joined #bitcoin-core-dev 05:24 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:28 < bitcoin-git> [bitcoin] vasild opened pull request #19132: qt: lock cs_main, m_cached_tip_mutex in that order (master...lock_order_m_cached_tip_mutex) https://github.com/bitcoin/bitcoin/pull/19132 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:33 < bitcoin-git> [bitcoin] jonatack opened pull request #19133: rpc, cli, test: add bitcoin-cli -generate command (master...cli-generate-command) https://github.com/bitcoin/bitcoin/pull/19133 05:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:33 -!- Highway61 [~Thunderbi@209.95.56.142] has joined #bitcoin-core-dev 05:37 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 05:37 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 260 seconds] 05:40 < vasild> Maybe #19132 should be included in the coming release. It fixes a regression since 0.19. 05:40 < gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub 05:42 < vasild> Either a deadlock (infinite hang) or a crash if the (possible) deadlock is detected. I am not sure if the deadlock detecting code is always enabled - in release builds and for all compilers? 05:42 < fanquake> vasild: how is it an issue since 0.19 if the PR that supposedly introduced it (17993), was only merged 3 days ago? 05:43 < vasild> well, the problem does not exist in 0.19 05:43 < fanquake> Right. So the issue only currently exists in master? 05:44 < vasild> yes 05:44 < fanquake> If so, there is no need to backport anything. 05:44 < vasild> by "regression since 0.19" I mean that the problem does not exist in 0.19 but would exist in 0.20 (if released without a fix) 05:45 < vasild> right, I think no need to backport anything 05:45 < fanquake> I don't see how it can exist in 0.20 if it's only been merged into master 05:45 < fanquake> It will be fixed in master, and should hopefully never exist in any release. 05:47 < vasild> It _would_ exist in 0.20 if 0.20 is released without a fix. 05:48 < vasild> All I am saying is that this is a new problem that IMO should be fixed before the release. If the problem existed in 0.19 (an old one), maybe it would have been less important to get the fix into 0.20. 05:50 < fanquake> vasild: the 0.20 release is currently based on the 0.20. branch: https://github.com/bitcoin/bitcoin/tree/0.20 (not master), so if the PR introduced the issue (17993) has. only been merged into master, then there is no issue with 0.20. 05:50 < Kiminuo> jonatack, My PR is buried at this point, so I don't expect anyone to find it really.. 05:51 < Kiminuo> and rebasing also does not make too much sense because it only claims valuable resources for other PRs 05:51 < Kiminuo> (I don't modify cpp code) 05:52 < vasild> fanquake: oh, this is my confusion - I assumed that 0.20 is yet to be created from master, sorry. So 0.20 does not have the bug, meaning it should only be fixed before 0.21! :) 05:53 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 05:53 < fanquake> vasild: 👍 06:04 < vasild> What about attaching a "lock order" number to each mutex (hardcoded in the source code) and enforce that locking always happens in ascending order? 06:09 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 06:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:11 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev 06:12 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 06:13 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 06:15 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 06:19 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds] 06:27 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 06:55 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 265 seconds] 06:59 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 07:00 < hebasto> vasild: maybe some of thread safety annotations could be useful? 07:04 < vasild> hebasto: you mean for detecting cycles in the waits-for DAG? That would be excellent as I think our deadlock detection mechanism has a deficiency. https://github.com/google/sanitizers/wiki/ThreadSanitizerDeadlockDetector 07:04 < vasild> is relevant 07:06 < hebasto> what a deficiency? 07:09 < vasild> hebasto: https://paste.gg/p/anonymous/4f3dd080b5ef4a09a0cba6a6eaffc6a6 -- if somebody can confirm that this is indeed a problem and I am not delusional, then I will open a bug report about it. 07:09 < vasild> The push_lock() function is in src/sync.cpp 07:18 < hebasto> vasild: does TSan detect such deadlock possibilities? 07:23 -!- Kiminuo [~mix@141.98.103.180] has quit [Ping timeout: 260 seconds] 07:31 < vasild> no idea 07:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 07:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] dboures opened pull request #19134: test: Replace global wait_until with mininode.wait_until (master...master) https://github.com/bitcoin/bitcoin/pull/19134 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:54 < vasild> hebasto: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-acquired-after is promising, but it is only limited to things that can be detected at compile time. 07:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:54 < hebasto> vasild: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-and-acquired-after-are-currently-unimplemented 07:55 < vasild> I just tried the following on master (which has #19132): 07:55 < gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub 07:55 < vasild> - Mutex m_cached_tip_mutex; 07:55 < vasild> + Mutex m_cached_tip_mutex ACQUIRED_AFTER(cs_main); 07:55 < vasild> 1. it compiled and 2. it abort()ed at runtime, detecting the deadlock from inside our push_lock() 07:56 < vasild> oh, are currently unimplemented :( 07:57 < vasild> but even if they are implemented I doubt it would be possible to detect complicated lock order violations at compile time 08:00 -!- defnordic [~defnordic@217.146.82.122] has quit [] 08:02 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds] 08:03 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 08:19 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 08:22 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:23 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:24 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 08:25 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:29 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 08:37 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 08:44 -!- hugohn [sid304114@gateway/web/irccloud.com/x-ujjrkpqnostiyppi] has joined #bitcoin-core-dev 08:44 -!- moneyball [sid299869@gateway/web/irccloud.com/x-idfrgkxmsbhwxvay] has joined #bitcoin-core-dev 08:50 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 08:56 -!- kexkey [~kexkey@217.138.200.222] has joined #bitcoin-core-dev 09:00 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:01 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:01 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 09:10 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 09:10 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 09:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:16 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev 09:19 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:29 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds] 09:33 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 10:01 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 246 seconds] 10:02 -!- Bille [~Bille@185.189.114.11] has joined #bitcoin-core-dev 10:06 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 10:08 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 10:13 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 10:14 -!- Highway61 [~Thunderbi@209.95.56.142] has quit [Ping timeout: 240 seconds] 10:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 10:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 10:37 -!- jarthur [~jarthur@2605:6000:1019:4971:5829:a166:7475:4fe4] has joined #bitcoin-core-dev 10:43 -!- Highway61 [~Thunderbi@209.95.56.142] has joined #bitcoin-core-dev 10:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:49 < bitcoin-git> [bitcoin] andersonbr opened pull request #19135: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135 10:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:57 -!- shesek [~shesek@5.102.247.31] has joined #bitcoin-core-dev 10:57 -!- shesek [~shesek@5.102.247.31] has quit [Changing host] 10:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:00 -!- Bille [~Bille@185.189.114.11] has quit [] 11:13 -!- Kiminuo [~mix@141.98.103.196] has joined #bitcoin-core-dev 11:14 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Ping timeout: 265 seconds] 11:21 -!- bcremer [~bcremer@37.120.203.188] has joined #bitcoin-core-dev 11:25 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 11:35 -!- Netsplit *.net <-> *.split quits: TheFuzzStone[m] 11:38 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 11:38 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:41 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-sctvyrivogphjxke] has quit [Ping timeout: 252 seconds] 11:44 -!- Netsplit over, joins: TheFuzzStone[m] 11:45 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-beaywrpjuzlflyen] has quit [Ping timeout: 244 seconds] 12:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 12:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 12:13 -!- Highway61 [~Thunderbi@209.95.56.142] has quit [Ping timeout: 246 seconds] 12:15 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 12:16 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-wfhuaxymifzteebb] has joined #bitcoin-core-dev 12:17 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 12:19 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 12:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:23 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-pddrdfbeqlimpmps] has joined #bitcoin-core-dev 12:23 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-uebcwpjignixusai] has joined #bitcoin-core-dev 12:33 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 12:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 12:34 -!- dr-orlov1ky [~user@31.14.40.19] has quit [Remote host closed the connection] 12:34 -!- nullptr| [~nullptr|@ip-94-112-129-192.net.upcbroadband.cz] has joined #bitcoin-core-dev 12:35 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 12:39 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 258 seconds] 12:46 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has joined #bitcoin-core-dev 12:46 -!- lehnberg [~lehnberg@unaffiliated/lehnberg] has quit [Client Quit] 12:48 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.8.0 - https://znc.in] 12:49 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 12:49 -!- Highway61 [~Thunderbi@209.95.56.142] has joined #bitcoin-core-dev 13:09 < gwillen> MarcoFalke: I'm curious what inspired you to fix all the codespell typos a few days ago -- I was never sure if those only show up for me, or for mac users, or what 13:09 < gwillen> I always assumed they must not be in whatever dictionary Travis uses, or something 13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:18 < bitcoin-git> [bitcoin] achow101 opened pull request #19136: wallet: add dumpwalletdescriptor RPC (master...export-descriptor) https://github.com/bitcoin/bitcoin/pull/19136 13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:22 -!- Kiminuo [~mix@141.98.103.196] has quit [Ping timeout: 246 seconds] 13:24 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:48 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 13:58 -!- Eulah89Stracke [~Eulah89St@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 14:00 -!- bcremer [~bcremer@37.120.203.188] has quit [] 14:00 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 14:10 -!- Eulah89Stracke [~Eulah89St@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds] 14:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:15 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:22 -!- chrippa [~chrippa@185.189.114.11] has joined #bitcoin-core-dev 14:24 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 14:29 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 14:45 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:45 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev 14:48 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Client Quit] 14:49 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 14:51 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds] 14:54 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 15:17 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 15:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:20 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 15:25 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 15:27 -!- kexkey [~kexkey@217.138.200.222] has quit [Quit: Scaling pentatonically] 15:29 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds] 15:30 -!- kexkey [~kexkey@217.138.200.222] has joined #bitcoin-core-dev 15:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:30 < bitcoin-git> [bitcoin] achow101 opened pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137 15:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:31 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 15:36 -!- kexkey [~kexkey@217.138.200.222] has quit [Quit: Do, don't don't] 15:56 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds] 15:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 16:02 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 16:02 < promag> are there real benefits of rpc batching? 16:03 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 16:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:04 < bitcoin-git> [bitcoin] fanquake closed pull request #19135: qt: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135 16:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:21 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 258 seconds] 16:21 < jarthur> promag: definitely, at least vs single RPC per HTTP request. A new HTTP request is expensive. From dynamic languages that have an expensive stack like Python and JavaScript, not having to go up and down the stack as much for multiple sends carries a performance benefit. JSON-RPC Pipelining is better on memory usage than batching, just harder to program support for. 16:22 < promag> at least vs single RPC per HTTP request <- yeah I don't mind in this case 16:24 < promag> so in the case the connection is established, only saving is on http protocol right? 16:25 < promag> because for the server batching is actually worse, at least memory wise 16:26 < promag> s/mind in /mean/ 16:26 < aj> sipa: "after how much time are we okay with attackers knowing everything that was in the mempool at the time?" -- if 99.9% of tx's are relayed to 99.9% of nodes within X seconds, then 2*X seconds? (fsv of 2 and 99.9%) 16:27 < sipa> aj: maybe that's even to strong a question 16:27 < sipa> "after how much time beyond the time it takes to send an INV are we ok with attackers knowing our mempool" 16:28 < sipa> if the answer is: whenever we send an INV, attackers can know our entire mempool before that point... it's very easy 16:28 < jarthur> promag: right, assuming the server supports pipelining multiple requests on the same connection (like JSON-RPC 2.0 TCP Transport w/ JSON Splitting, Stratum Mining TCP Transport, Stratum Wallet TCP Transport etc), I don't see an advantage batching would have. 16:29 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 16:32 < sipa> aj: if so, we'd just keep track of the last timestamp when we sent out a tx INV, and respond to requests for anything that was in the mempool before that point 16:32 < sipa> we'd still need a relay pool + bloom filter for dealing with things not in the mempool 16:32 < aj> sipa: "whenever we send an INV, an attacker can know the presence or absence of every tx that entered our mempool prior to the latest tx in that INV" maybe. i don't see a lot of benefit to doing much else, since an attacker could just make more connections to get around it? 16:33 < sipa> but the latter can go away once fast NOTFOUND handling is widespread on the network 16:38 < aj> sipa: is this protecting against anything other than tracing transaction sources? 16:38 < sipa> i don't think so 16:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 16:51 < sipa> aj: here is a downside: for a very new connection, by observing the difference between what we actually announce to a peer, and what they can request (after our first INV)... they get an exact point distinguishing transaction we learned right before and right after the connection was created 16:54 < aj> sipa: ha. could hack around that by not sending the first INV worth of tx's to them? 16:55 < sipa> does that help? 16:56 < sipa> right, it does a bit 16:56 < aj> sipa: it makes it no more leaky than anytime you get an INV after the two prior INVs had less than 100 txids, i think? 16:57 < aj> wish it was easier to keep all the relay related rules in my head at the same time 16:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:00 -!- chrippa [~chrippa@185.189.114.11] has quit [] 17:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 17:04 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 17:04 < sipa> where does the number 100 come from? 17:04 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 17:09 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 260 seconds] 17:09 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:12 < aj> sipa: sorry 35 not 100; if you get less than that in a single message, it means you've emptied setInventoryTxToSend 17:13 < sipa> right 17:16 < aj> sipa: which brings you back to knowing about a timepoint, but the timepoint's chosen by the victim's poisson schedule, not the attacker's choice of when to connect? 17:16 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 17:16 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 17:20 < phantomcircuit> promag, it depends on which rpc calls you're making 17:20 < promag> how so? 17:21 < phantomcircuit> if you're making lots of fast calls it will matter, if you make a few slow calls you won't even notice 17:22 -!- Darki [~Darki@77.243.177.38] has joined #bitcoin-core-dev 17:27 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 17:32 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 246 seconds] 17:35 < promag> phantomcircuit: #5050 17:35 < gribble> https://github.com/bitcoin/bitcoin/issues/5050 | contrib: Use batched JSON-RPC in linearize.py for speedup by laanwj · Pull Request #5050 · bitcoin/bitcoin · GitHub 17:41 < sipa> aj: it feels fragile to rely on that 17:42 < phantomcircuit> promag, yeah the getblockhash rpc is probably the biggest win for batching, ages ago i implemented a getblockhashes that took a range but it was too craptastic for a pr 17:45 < aj> sipa: yes, it does 17:45 < promag> phantomcircuit: right 17:49 < sipa> aj: so WDYT about relay pool 2 minutes, bloom filter per peer for last (whatever can be relayed in 2 minutes) transactions, things can be requested if they're in the bloom filter OR in mempool and older than 2 minutes OR older than the last BIP35 response; BIP35 responses don't go into the bloom filter 17:51 < aj> oh, i see, bitcoin does 7tx/second because that's 420tx/minute -- blazing fast 17:51 < sipa> ? 17:52 < aj> "420 blaze it" nevermind 17:52 < phantomcircuit> ok so now i have a keypool problem, i've generated a list of scripPubKeys and can get notified when the keypool changes... but this is in a tight loop and im not sure if the NotifyCanGetAddressesChanged thing is guaranteed to run before anything else 17:52 < phantomcircuit> also it's kind of ugly to use a callback here 17:52 < aj> sipa: why not do bip35 via bloom as well? 17:53 < sipa> aj: it would easily overflow the filter 17:53 < aj> right, right 17:54 < sipa> unless the filter is made much larger 17:56 < aj> yeah, i was thinking of making it so bip35 wouldn't let you see stuff that hadn't made it into the bloom filter, but seems too complicated, esp if we think bip35 is only for trusted-ish peers 17:56 < sipa> you have to explicitly enable bip37, or whitelist the peer 17:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:00 < aj> so "whatever can be relayed in 2 minutes" ~= 840 tx for inbound, 2110 tx for outbound? i think it'd make sense to be "bloom filter (for whatever can be relayed in 1.5*X minutes) OR in the mempool and older than X minutes" so there's no weird, exploitable gaps? 18:06 < sipa> hmm, what kind of gaps? 18:07 < sipa> the rolling bloom filter is already maintaining between 1.5*x and x entries 18:07 < aj> sipa: as in txs drop out of the bloom filter in <2m, because your poisson timing goes really quick by random chance? 18:08 < aj> i guess there's 24 intervals in 2minutes, so 1.5x is probably vast overkill 18:09 < sipa> ah! 18:09 < sipa> this calls for some statistics 18:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:09 < aj> (when you said "ah!" i thought, "oh no, a spider??", now i wish it were just that) 18:12 -!- Morton29Crooks [~Morton29C@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 18:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 18:17 < sipa> so this is a poisson distribution with lambda=24 (we expect 24 inv broadcasts in 2 minutes)... there could be up to 50 broadcasts however in 2 minutes, with probability up to 99.9999% 18:18 < aj> lambda=60 for outbounds, i guess? 18:18 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Read error: Connection reset by peer] 18:19 < sipa> yup, and there we need to account for up to 95 broadcasts in 2 minutes 18:19 < sipa> (to have 99.9999% probability) 18:23 < aj> means about 1800 and 3500 txs for 9.7kB and 19kB filters? 18:24 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 18:24 -!- Morton29Crooks [~Morton29C@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 18:25 < sipa> more accurate numbers: 51 and 100 18:27 < midnight> har har "blazing fast" 18:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:33 < aj> sipa: 52 would stay just under 10kB; 105 would be just under 20kB. so about 1.3M in total with max peers? 18:35 < sipa> i think anything in the order of 10s of kilobytes per peer is negligable 18:39 < aj> yeah 18:41 < sipa> could just go for an even 3500 sized filter for everyone 19:44 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:46 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds] 19:47 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 20:00 -!- Darki [~Darki@77.243.177.38] has quit [] 20:01 -!- Highway61 [~Thunderbi@209.95.56.142] has quit [Ping timeout: 256 seconds] 20:03 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:04 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 20:04 -!- surja795 [~surja795@c-24-62-248-154.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 20:09 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 20:10 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 20:15 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 246 seconds] 20:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:33 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 20:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:51 -!- jarthur [~jarthur@2605:6000:1019:4971:5829:a166:7475:4fe4] has quit [] 20:56 -!- ajbiz11 [~ajbiz11@37.120.203.188] has joined #bitcoin-core-dev 21:08 -!- tylerdmace [~tyler@136.36.154.185] has quit [Ping timeout: 272 seconds] 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:24 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 21:25 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:27 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:31 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 21:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:50 < bitcoin-git> [bitcoin] laanwj opened pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138 21:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:11 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 22:14 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 22:24 -!- Guest13 [544ef02d@gateway/web/cgi-irc/kiwiirc.com/ip.84.78.240.45] has joined #bitcoin-core-dev 22:27 -!- Guest13 [544ef02d@gateway/web/cgi-irc/kiwiirc.com/ip.84.78.240.45] has left #bitcoin-core-dev [] 22:30 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has joined #bitcoin-core-dev 22:44 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 256 seconds] 22:47 < hebasto> MarcoFalke: how to preserve travis log with an intermittent error for issue submitting? If I re-run build log pointed by url will be re-written... 22:48 < hebasto> https://travis-ci.org/github/bitcoin/bitcoin/jobs/692067912 22:52 -!- cncr04s_ [~cncr04s@afxr.net] has left #bitcoin-core-dev [] 22:53 -!- cncr04s_ [~cncr04s@afxr.net] has joined #bitcoin-core-dev 22:54 -!- cncr04s_ [~cncr04s@afxr.net] has quit [Quit: See you real soon!] 22:55 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev 22:56 -!- Kiminuo [~mix@141.98.103.196] has joined #bitcoin-core-dev 23:00 -!- ajbiz11 [~ajbiz11@37.120.203.188] has quit [] 23:01 < cncr04s> can any one explain this "[00:47:45] cncr04s #bitcoin-core-dev Cannot change nickname while banned/quieted on channel" I have not spoken on this channel in weeks so... 23:03 < gwillen> cncr04s: assuming someone doesn't come correct me, and given that you appear not to be banned or quieted now, I would assume it was an accident / collateral damage of some other ban 23:03 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 23:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/6f7f94a27687...60e8e74d1085 23:14 < bitcoin-git> bitcoin/0.20 1dfad42 Wladimir J. van der Laan: doc: Merge 0.20.0 release notes from wiki 23:14 < bitcoin-git> bitcoin/0.20 60e8e74 fanquake: Merge #19138: doc: Merge 0.20.0 release notes from wiki 23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:15 < bitcoin-git> [bitcoin] fanquake merged pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138 23:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:21 -!- paulk-collins [~paulk-col@77.243.177.38] has joined #bitcoin-core-dev 23:36 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 23:36 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 23:42 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:48 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bc7751cadbd...44307449f758 23:48 < bitcoin-git> bitcoin/master 4f49d52 João Barbosa: gui, refactor: Register Qt meta types in application constructor 23:48 < bitcoin-git> bitcoin/master 4430744 Jonas Schnelli: Merge #19104: gui, refactor: Register Qt meta types in application constru... 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:49 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19104: gui, refactor: Register Qt meta types in application constructor (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev --- Log closed Tue Jun 02 00:00:40 2020